[clang] [llvm] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-09-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64le-rhel` running on `ppc64le-clang-rhel-test` while building `clang,llvm` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/1644 Here is the releva

[clang] [Clang] [Driver] Ensure `-fms-volatile` is set for x86 for `*-windows-msvc` triple on non cl driver modes (PR #107509)

2024-09-06 Thread via cfe-commits
zmodem wrote: > Similar reasoning as this PR: #107177 I think this is reasonable. @nico mentioned that he found the other PR a bit surprising though. It's not obvious which features that should be gated on the driver mode or target flag, but we do enable MS compatibility extensions based on t

[clang] fb6c10d - [MC] Emit a jump table size section (#101962)

2024-09-06 Thread via cfe-commits
Author: Nabeel Omer Date: 2024-09-06T13:41:36+01:00 New Revision: fb6c10da1f6cb4eb9556548d51dafe97d953ba58 URL: https://github.com/llvm/llvm-project/commit/fb6c10da1f6cb4eb9556548d51dafe97d953ba58 DIFF: https://github.com/llvm/llvm-project/commit/fb6c10da1f6cb4eb9556548d51dafe97d953ba58.diff L

[clang] [llvm] [MC] Emit a jump table size section (PR #101962)

2024-09-06 Thread Nabeel Omer via cfe-commits
https://github.com/omern1 closed https://github.com/llvm/llvm-project/pull/101962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2024-09-06 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 4feca6db7e49f1429b63f432f31c2f8f177a7132 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] [Clang] [Driver] Ensure `-fms-volatile` is set for x86 for `*-windows-msvc` triple on non cl driver modes (PR #107509)

2024-09-06 Thread Nico Weber via cfe-commits
nico wrote: I don't have a very strong opinion. I find it surprising in that the clang driver is supposed to be gcc-compatible, and having to use `clang -fstrict-aliasing` (but only when targeting Windows) to get the default behavior looks a bit surprising. (I agree it's a better default, but

[clang] [Clang] [Driver] Ensure `-fms-volatile` is set for x86 for `*-windows-msvc` triple on non cl driver modes (PR #107509)

2024-09-06 Thread Nico Weber via cfe-commits
nico wrote: For this patch here, I don't know if gcc even has a `fms-volatile`. If not, this here seems less surprising to me than the strict aliasing patch. https://github.com/llvm/llvm-project/pull/107509 ___ cfe-commits mailing list cfe-commits@lis

[clang] [clang] Catch missing format attributes (PR #105479)

2024-09-06 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From ee5e59583140024ea6428bf2edfd5d614125c39b Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT-DS new instructions. (PR #102592)

2024-09-06 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,443 @@ +/*===--- avx10_2satcvtdsintrin.h - AVX512SATCVTDS intrinsics === + * + * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + * See https://llvm.org/LICENSE.txt for license information. + * SPDX-License-Identifier: Ap

[clang] [clang] Catch missing format attributes (PR #105479)

2024-09-06 Thread Budimir Aranđelović via cfe-commits
@@ -5335,6 +5335,217 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// This function is called only if function call is not inside template body. +// TODO: Add call

[clang] [analyzer] Model constructor initializer for an array member (PR #107537)

2024-09-06 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM. FYI "modelled" should contain only 1 "l" if I'm not mistaken. Also llvm style suggests capitalizing and punctuating comments. None of these are blockers. https://github.com/llvm/llvm-project/pull/107537 _

[clang] [analyzer] Model constructor initializer for an array member (PR #107537)

2024-09-06 Thread Arseniy Zaostrovnykh via cfe-commits
https://github.com/necto updated https://github.com/llvm/llvm-project/pull/107537 >From 63c856732aeda977786534d66597d0aba12cb0d4 Mon Sep 17 00:00:00 2001 From: Arseniy Zaostrovnykh Date: Tue, 3 Sep 2024 18:01:02 +0200 Subject: [PATCH 1/2] [analyzer] Model constructor initializer for an array m

[clang] [clang][bytecode] Implement placement-new (PR #107033)

2024-09-06 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/107033 >From 19abb83b47cbbdfac84dd5a30ff01e3f55e2d4d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 3 Sep 2024 02:52:35 +0200 Subject: [PATCH] [clang][bytecode] Implement placement-new ---

[clang] [analyzer] Model constructor initializer for an array member (PR #107537)

2024-09-06 Thread Arseniy Zaostrovnykh via cfe-commits
necto wrote: > LGTM. FYI "modelled" should contain only 1 "l" if I'm not mistaken. Also llvm > style suggests capitalizing and punctuating comments. None of these are > blockers. fixed eecf42ac8fc4 https://github.com/llvm/llvm-project/pull/107537 __

[clang] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-09-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-with-lto-ubuntu` running on `as-worker-91` while building `clang,llvm,mlir` at step 7 "test-stage1-compiler". Full details are available at: https://lab.llvm.org/buildbot/#/builders/49/builds/431 Here is the relevant

[clang] [clang][bytecode] Only visit local variables if they have constant init (PR #107576)

2024-09-06 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/107576 See the comment I added for why this is weird. We might want to have a different mechanism for this in the future. >From 7149533c281d2e7c9a3e669336645776bf03c9a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=2

[clang] [clang][bytecode] Only visit local variables if they have constant init (PR #107576)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes See the comment I added for why this is weird. We might want to have a different mechanism for this in the future. --- Full diff: https://github.com/llvm/llvm-project/pull/107576.diff 4 Files Affected: -

[clang] [analyzer] Model constructor initializer for an array member (PR #107537)

2024-09-06 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > LGTM. FYI "modelled" should contain only 1 "l" if I'm not mistaken. British English uses "modeled", while American uses "modelled". I don't know which is preferred in LLVM. https://github.com/llvm/llvm-project/pull/107537 ___ cfe-

[clang] [Clang] Emit error for duplicate mangled names within a lambda (PR #107581)

2024-09-06 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm created https://github.com/llvm/llvm-project/pull/107581 When functions are passed as arguments to a lambda, it's possible for the mangled names of these functions to be the same despite the prototypes being different. For example: ``` int non_streaming_fn(i

[clang] [Clang] Emit error for duplicate mangled names within a lambda (PR #107581)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Kerry McLaughlin (kmclaughlin-arm) Changes When functions are passed as arguments to a lambda, it's possible for the mangled names of these functions to be the same despite the prototypes being different. For example: ``` int non

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-09-06 Thread Neil Henning via cfe-commits
https://github.com/sheredom updated https://github.com/llvm/llvm-project/pull/106577 >From 2d73b6c8463a36ec087fe66c2a48c3ae8fe5b05e Mon Sep 17 00:00:00 2001 From: Neil Henning Date: Thu, 29 Aug 2024 13:15:49 +0100 Subject: [PATCH] Make PCH's respect any VFS specified. We want to be able to gen

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-06 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd updated https://github.com/llvm/llvm-project/pull/107410 >From a20158570f15b4200937650b90e07b99e230e3df Mon Sep 17 00:00:00 2001 From: Edd Dawson Date: Wed, 4 Sep 2024 12:30:11 +0100 Subject: [PATCH 1/2] [PS4,PS5][Driver] Detangle --sysroot and -isysroot The

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-06 Thread Edd Dawson via cfe-commits
playstation-edd wrote: > According to [gcc > docs](https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html) `--sysroot` > applies to headers and libraries, and `-isysroot` overrides it for headers > only. This is different from the "independence" described for World 2. That > is, if we have

[clang] [clang][ExprConst] Allow comparisons with string literals (PR #106733)

2024-09-06 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/106733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c64dac2 - [clang] Fix noisy -Wcovered-switch-default warning after 1f70fcefa9 / #100278

2024-09-06 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2024-09-06T09:17:45-04:00 New Revision: c64dac2e6c39f0f7f1c676857e7d34c764b4d632 URL: https://github.com/llvm/llvm-project/commit/c64dac2e6c39f0f7f1c676857e7d34c764b4d632 DIFF: https://github.com/llvm/llvm-project/commit/c64dac2e6c39f0f7f1c676857e7d34c764b4d632.diff LO

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-06 Thread Erich Keane via cfe-commits
@@ -2943,6 +2943,9 @@ class Parser : public CodeCompletionHandler { return false; } + bool ParseGNUSingleAttribute(ParsedAttributes &Attrs, SourceLocation &EndLoc, erichkeane wrote: Ah, I see. The WG14 specified one is `__builtin_has_c_attribute`, cor

[clang] [RISCV][FMV] Support target_clones (PR #85786)

2024-09-06 Thread Piyou Chen via cfe-commits
BeMg wrote: > A test case will crash, missing `+` before `zbc`: > > ``` > __attribute__((target_clones("default", "arch=+zbb,zbc;priority=-1", > "priority=-2;arch=+zba", "priority=3;arch=+zbb,+zba"))) int foo1(void) { > return 2; } > > > int bar() { return foo1(); } > ``` > > ``` > $ clang

[clang] [RISCV][FMV] Support target_clones (PR #85786)

2024-09-06 Thread Piyou Chen via cfe-commits
BeMg wrote: Rename and update the description of err_os_unsupport_riscv_target_clones because not only target clones trigger FMV. https://github.com/llvm/llvm-project/pull/85786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I'm not sold on this patch, particularly the changes to the overload. I also wonder if we would better off having `CXXRecordDecl` save its 'variable' for lambdas (and look it up from there) rather than this. https://github.com/llvm/llvm-project/pull/1

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/101857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Erich Keane via cfe-commits
@@ -2390,7 +2390,8 @@ static bool LookupQualifiedNameInUsingDirectives(Sema &S, LookupResult &R, } bool Sema::LookupQualifiedName(LookupResult &R, DeclContext *LookupCtx, - bool InUnqualifiedLookup) { + bool InUnqual

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Erich Keane via cfe-commits
@@ -10204,15 +10205,14 @@ class Sema final : public SemaBase { /// both @c a1 and @c a2. If @p SuppressUserConversions, then don't /// allow user-defined conversions via constructors or conversion /// operators. - void - AddMethodCandidate(CXXMethodDecl *Method, DeclAcc

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Erich Keane via cfe-commits
@@ -4022,7 +4022,10 @@ CodeCompleteConsumer::OverloadCandidate::CreateSignatureString( std::string Name; llvm::raw_string_ostream OS(Name); -FDecl->getDeclName().print(OS, Policy); +auto const DeclName = (getKind() == CK_Lambda) erichkeane wro

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Erich Keane via cfe-commits
@@ -876,6 +876,11 @@ class Sema; /// function pointer or reference (C++ [over.call.object]). FunctionDecl *Function; +/// LambdaName - When the OverloadCandidate is for a +/// lambda's operator(), points to the declaration of +/// the lambda variable. +

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Erich Keane via cfe-commits
@@ -6292,11 +6298,16 @@ SemaCodeCompletion::ProduceCallSignatureHelp(Expr *Fn, ArrayRef Args, SmallVector ArgExprs(1, NakedFn); ArgExprs.append(ArgsWithoutDependentTypes.begin(), ArgsWithoutDependentTypes.end()); +auto *const Lam

[clang] [clang] Catch missing format attributes (PR #105479)

2024-09-06 Thread Budimir Aranđelović via cfe-commits
@@ -5335,6 +5335,217 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// This function is called only if function call is not inside template body. +// TODO: Add call

[clang] [Clang] Don't assert non-empty packs for FunctionParmPackExprs (PR #107561)

2024-09-06 Thread Erich Keane via cfe-commits
@@ -1,13 +0,0 @@ -// RUN: %clang_cc1 -std=c++17 %s -fsyntax-only -verify - -template void g(Ts... p1s) { - (void)[&](auto... p2s) { ([&] { p1s; p2s; }, ...); }; -} - -void f1() { - g(); -} - -template void g2(Ts... p1s) { - (void)[&](auto... p2s) { [&] { p1s; p2s; }; }; // ex

[clang] [Clang] Don't assert non-empty packs for FunctionParmPackExprs (PR #107561)

2024-09-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: This looks reasonable, I want to think on it a little and give others a chance to look at it, plus I want ot make sure we didn't lose test coverage. Else LGTM. https://github.com/llvm/llvm-project/pull/107561 ___

[clang] [clang] Catch missing format attributes (PR #105479)

2024-09-06 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 952689f4675e5c6465d4a4322a4fde8f1c2c3e15 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] e4bb68b - [analyzer] Model constructor initializer for an array member (#107537)

2024-09-06 Thread via cfe-commits
Author: Arseniy Zaostrovnykh Date: 2024-09-06T15:55:16+02:00 New Revision: e4bb68b8717a20c5828b479f83c8648c2596e598 URL: https://github.com/llvm/llvm-project/commit/e4bb68b8717a20c5828b479f83c8648c2596e598 DIFF: https://github.com/llvm/llvm-project/commit/e4bb68b8717a20c5828b479f83c8648c2596e59

[clang] [analyzer] Model constructor initializer for an array member (PR #107537)

2024-09-06 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/107537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used. (PR #106810)

2024-09-06 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov updated https://github.com/llvm/llvm-project/pull/106810 >From 8232271806ea605fb4f7212d842a328307070003 Mon Sep 17 00:00:00 2001 From: dfukalov Date: Sat, 31 Aug 2024 01:45:27 +0200 Subject: [PATCH 1/3] [NFC] Add explicit #include llvm-config.h where its macros are

[clang] [clang-tools-extra] [NFC] Add explicit #include llvm-config.h where its macros are used, clang part. (PR #107301)

2024-09-06 Thread Daniil Fukalov via cfe-commits
@@ -15,6 +15,7 @@ #include "clang/Driver/InputInfo.h" #include "clang/Driver/Options.h" #include "clang/Driver/SanitizerArgs.h" +#include "llvm/Config/llvm-config.h" // for LLVM_HOST_TRIPLE dfukalov wrote: Well, I guess such files (with configuration defines o

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-06 Thread via cfe-commits
@@ -15,26 +15,25 @@ using namespace clang::ast_matchers; namespace clang::tidy::readability { void ContainerContainsCheck::registerMatchers(MatchFinder *Finder) { - const auto SupportedContainers = hasType( - hasUnqualifiedDesugaredType(recordType(hasDeclaration(cxxRecor

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-06 Thread via cfe-commits
@@ -116,7 +116,11 @@ Changes in existing checks ` check to support replacing member function calls too. -- Improved :doc:`readablility-implicit-bool-conversion +- Improved :doc:`readability-container-contains + ` check + to let it work on any class that has a `contains`

[clang] 383057e - [Clang][AArch64] Fix -Wcovered-switch-default warning (SemaARM)

2024-09-06 Thread Spencer Abson via cfe-commits
Author: Spencer Abson Date: 2024-09-06T14:19:13Z New Revision: 383057e5a0b53a79926dbdbae4cfcd39bfb44645 URL: https://github.com/llvm/llvm-project/commit/383057e5a0b53a79926dbdbae4cfcd39bfb44645 DIFF: https://github.com/llvm/llvm-project/commit/383057e5a0b53a79926dbdbae4cfcd39bfb44645.diff LOG:

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107397 >From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 5 Sep 2024 05:42:26 -0700 Subject: [PATCH 1/2] [NFC] Move warning from COdeGen to Sema. --- clang/i

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-06 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/107521 >From f0f305a3deabafa9874f8b63325750bd3b1b831d Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Fri, 6 Sep 2024 10:30:22 -0400 Subject: [PATCH] [clang-tidy][readability-container-contains] Extend to any

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-06 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/107521 >From f0f305a3deabafa9874f8b63325750bd3b1b831d Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Fri, 6 Sep 2024 10:30:22 -0400 Subject: [PATCH] [clang-tidy][readability-container-contains] Extend to any

[clang] [Clang] Don't assert non-empty packs for FunctionParmPackExprs (PR #107561)

2024-09-06 Thread Younan Zhang via cfe-commits
@@ -1,13 +0,0 @@ -// RUN: %clang_cc1 -std=c++17 %s -fsyntax-only -verify - -template void g(Ts... p1s) { - (void)[&](auto... p2s) { ([&] { p1s; p2s; }, ...); }; -} - -void f1() { - g(); -} - -template void g2(Ts... p1s) { - (void)[&](auto... p2s) { [&] { p1s; p2s; }; }; // ex

[clang] [llvm] [RISCV][VCIX] Add vcix_state to GNU inline assembly register set (PR #106914)

2024-09-06 Thread Brandon Wu via cfe-commits
@@ -44,7 +44,7 @@ ArrayRef RISCVTargetInfo::getGCCRegNames() const { "v24", "v25", "v26", "v27", "v28", "v29", "v30", "v31", // CSRs - "fflags", "frm", "vtype", "vl", "vxsat", "vxrm" + "fflags", "frm", "vtype", "vl", "vxsat", "vxrm", "sf_vcix_state"

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Add support for two ends_with patterns (PR #105366)

2024-09-06 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/105366 >From 7e734f7c2e5e487bb3c6f9e30ff92f0ef129f409 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Fri, 6 Sep 2024 10:34:49 -0400 Subject: [PATCH] [clang-tidy][modernize-use-starts-ends-with] Add support fo

[clang] [Clang] Don't assert non-empty packs for FunctionParmPackExprs (PR #107561)

2024-09-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/107561 >From 92a30ff72fd922df3c29ac31fc2c7d46df1ff84e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 6 Sep 2024 18:35:45 +0800 Subject: [PATCH 1/2] [Clang] Don't assert non-empty packs for FunctionParmPackExpr

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Add support for two ends_with patterns (PR #105366)

2024-09-06 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: Rebase to resolve merge conflict. Ping. https://github.com/llvm/llvm-project/pull/105366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/107521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-06 Thread Julian Schmidt via cfe-commits
@@ -15,26 +15,26 @@ using namespace clang::ast_matchers; namespace clang::tidy::readability { void ContainerContainsCheck::registerMatchers(MatchFinder *Finder) { - const auto SupportedContainers = hasType( - hasUnqualifiedDesugaredType(recordType(hasDeclaration(cxxRecor

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: > I applied this modified version to llvm-project root One PR per subproject seems to be the preferred way, judging by the responses to some of those *all of llvm* PRs. IMO, this is a readability cleanup and would probably be accepted. https://github.com

[clang-tools-extra] b8d6885 - [NFC] Add explicit #include llvm-config.h where its macros are used, clang part. (#107301)

2024-09-06 Thread via cfe-commits
Author: Daniil Fukalov Date: 2024-09-06T16:41:24+02:00 New Revision: b8d6885ff67efbc3142a2b49506ed0cc2b95e054 URL: https://github.com/llvm/llvm-project/commit/b8d6885ff67efbc3142a2b49506ed0cc2b95e054 DIFF: https://github.com/llvm/llvm-project/commit/b8d6885ff67efbc3142a2b49506ed0cc2b95e054.diff

[clang] [clang-tools-extra] [NFC] Add explicit #include llvm-config.h where its macros are used, clang part. (PR #107301)

2024-09-06 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov closed https://github.com/llvm/llvm-project/pull/107301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-06 Thread via cfe-commits
@@ -15,26 +15,26 @@ using namespace clang::ast_matchers; namespace clang::tidy::readability { void ContainerContainsCheck::registerMatchers(MatchFinder *Finder) { - const auto SupportedContainers = hasType( - hasUnqualifiedDesugaredType(recordType(hasDeclaration(cxxRecor

[clang] [llvm] [Driver] Default -msmall-data-limit= to 0 and clean up code (PR #83093)

2024-09-06 Thread Michael Maitland via cfe-commits
michaelmaitland wrote: Adding a data point here: changing the small data limit to 0 is causing significant regressions on dhrystone, spec2006, spec2017, and geekbench5 on the sifive-x280 and sifive-p470. Separate from this data point, a default of 8 bytes may be justified because most scalar

[clang-tools-extra] a37f7ae - [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (#106801)

2024-09-06 Thread via cfe-commits
Author: Nicolas van Kempen Date: 2024-09-06T16:47:53+02:00 New Revision: a37f7ae6268b25ff1673c94a7294ab242b9a11d8 URL: https://github.com/llvm/llvm-project/commit/a37f7ae6268b25ff1673c94a7294ab242b9a11d8 DIFF: https://github.com/llvm/llvm-project/commit/a37f7ae6268b25ff1673c94a7294ab242b9a11d8.

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-09-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti closed https://github.com/llvm/llvm-project/pull/106801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move 'alpha.core.PointerSub' checker into 'core.PointerSub' (PR #107596)

2024-09-06 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/107596 Checker was tested on 16 projects. The only results were the offset calculations that were considered as valid (faulty) cases already. https://codechecker-demo.eastus.cloudapp.azure.com/Default/reports?run=vim_

[clang] [clang][analyzer] Move 'alpha.core.PointerSub' checker into 'core.PointerSub' (PR #107596)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balázs Kéri (balazske) Changes Checker was tested on 16 projects. The only results were the offset calculations that were considered as valid (faulty) cases already. https://codechecker-demo.eastus.cloudapp.azure.com/Defa

[clang] [Clang] Don't assert non-empty packs for FunctionParmPackExprs (PR #107561)

2024-09-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I think with the test, I'm happy. Please give other folks ~24 hrs to get a chance to take a look in case there is something I missed. https://github.com/llvm/llvm-project/pull/107561 ___ cfe-c

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-06 Thread Paul T Robinson via cfe-commits
@@ -323,46 +323,63 @@ toolchains::PS4PS5Base::PS4PS5Base(const Driver &D, const llvm::Triple &Triple, const ArgList &Args, StringRef Platform, const char *EnvVar) : Generic_ELF(D, Triple, Args) { - // D

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/107598 In https://github.com/llvm/llvm-project/pull/100302, `int` TBAA information was added to math function calls to indicate the type of non-argument memory a function might modify. The purpose of this change was

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
@@ -0,0 +1,22 @@ +//===-- Implementation of ctime_r function ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff eec1fac9b51d06c8afafe9952a20ba7cd4c3ce1c 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 --e

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
@@ -0,0 +1,22 @@ +//===-- Implementation of ctime_r function ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [Clang][ARM] Make CRC and DSP intrinsics always available. (PR #107417)

2024-09-06 Thread Daniel Kiss via cfe-commits
DanielKristofKiss wrote: Clang-format failure is expected as I kept intentionally the format to match with the rest of the file. https://github.com/llvm/llvm-project/pull/107417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-06 Thread Edd Dawson via cfe-commits
@@ -323,46 +323,63 @@ toolchains::PS4PS5Base::PS4PS5Base(const Driver &D, const llvm::Triple &Triple, const ArgList &Args, StringRef Platform, const char *EnvVar) : Generic_ELF(D, Triple, Args) { - // D

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107598 >From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 6 Sep 2024 08:01:25 -0700 Subject: [PATCH 1/2] Don't emit int TBAA metadata on more complex FP math

[clang] [llvm] [AMDGPU] Add target intrinsic for s_buffer_prefetch_data (PR #107293)

2024-09-06 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. I think the parent needs some revision for global/flat/infer handling https://github.com/llvm/llvm-project/pull/107293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [llvm] [AMDGPU] Add target intrinsic for s_buffer_prefetch_data (PR #107293)

2024-09-06 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,36 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 +; RUN: llc -global-isel=0 -march=amdgcn -mcpu=gfx1200 < %s | FileCheck --check-prefix=GCN %s +; RUN: llc -global-isel=1 -march=amdgcn -mcpu=gfx1200 < %s | FileC

[clang] [llvm] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-09-06 Thread via cfe-commits
SpencerAbson wrote: Thank you, @nico . The '-WError' buildbot failiures have been fixed since https://github.com/llvm/llvm-project/commit/383057e5a0b53a79926dbdbae4cfcd39bfb44645. https://github.com/llvm/llvm-project/pull/100278 ___ cfe-commits mailin

[clang] [NFC][Clang][SVE] Refactor AArch64SVEACLETypes.def to enabled more uses. (PR #107599)

2024-09-06 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm created https://github.com/llvm/llvm-project/pull/107599 Some switch statements require all SVE builtin types to be manually specified. This patch refactors the SVE_*_TYPE macros so that such code can be generated during preprocessing. I've tried to establish

[clang] [NFC][Clang][SVE] Refactor AArch64SVEACLETypes.def to enabled more uses. (PR #107599)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Paul Walker (paulwalker-arm) Changes Some switch statements require all SVE builtin types to be manually specified. This patch refactors the SVE_*_TYPE macros so that such code can be generated during preprocessing. I've tried to

[clang] [NFC][Clang][SVE] Refactor AArch64SVEACLETypes.def to enabled more uses. (PR #107599)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul Walker (paulwalker-arm) Changes Some switch statements require all SVE builtin types to be manually specified. This patch refactors the SVE_*_TYPE macros so that such code can be generated during preprocessing. I've tried to establi

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] [llvm] [AArch64] Implement NEON vamin/vamax intrinsics (PR #99041)

2024-09-06 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. https://github.com/llvm/llvm-project/pull/99041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Younan Zhang via cfe-commits
@@ -1139,6 +1139,8 @@ class SignatureHelpCollector final : public CodeCompleteConsumer { switch (K) { case OC::CK_Aggregate: return 0; + case OC::CK_Lambda: +[[fallthrough]]; zyn0217 wrote: ```suggestion ``

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Younan Zhang via cfe-commits
@@ -1437,6 +1437,15 @@ TEST(SignatureHelpTest, Overloads) { EXPECT_EQ(0, Results.activeParameter); } +TEST(SignatureHelpTest, ShowLambdaNameInsteadOfOperatorParens) { + auto const Results = signatures(R"cpp( +auto foo = [](int x, int y){}; +int main() { foo(^); } --

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Younan Zhang via cfe-commits
@@ -4022,7 +4022,10 @@ CodeCompleteConsumer::OverloadCandidate::CreateSignatureString( std::string Name; llvm::raw_string_ostream OS(Name); -FDecl->getDeclName().print(OS, Policy); +auto const DeclName = (getKind() == CK_Lambda) zyn0217 wrote:

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Younan Zhang via cfe-commits
@@ -6292,11 +6298,16 @@ SemaCodeCompletion::ProduceCallSignatureHelp(Expr *Fn, ArrayRef Args, SmallVector ArgExprs(1, NakedFn); ArgExprs.append(ArgsWithoutDependentTypes.begin(), ArgsWithoutDependentTypes.end()); +auto *const Lam

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Younan Zhang via cfe-commits
@@ -6292,11 +6298,16 @@ SemaCodeCompletion::ProduceCallSignatureHelp(Expr *Fn, ArrayRef Args, SmallVector ArgExprs(1, NakedFn); ArgExprs.append(ArgsWithoutDependentTypes.begin(), ArgsWithoutDependentTypes.end()); +auto *const Lam

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Younan Zhang via cfe-commits
@@ -6292,11 +6298,16 @@ SemaCodeCompletion::ProduceCallSignatureHelp(Expr *Fn, ArrayRef Args, SmallVector ArgExprs(1, NakedFn); ArgExprs.append(ArgsWithoutDependentTypes.begin(), ArgsWithoutDependentTypes.end()); +auto *const Lam

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Younan Zhang via cfe-commits
@@ -9147,7 +9147,8 @@ class Sema final : public SemaBase { /// /// \returns true if lookup succeeded, false if it failed. bool LookupQualifiedName(LookupResult &R, DeclContext *LookupCtx, - bool InUnqualifiedLookup = false); +

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Younan Zhang via cfe-commits
@@ -876,6 +876,11 @@ class Sema; /// function pointer or reference (C++ [over.call.object]). FunctionDecl *Function; +/// LambdaName - When the OverloadCandidate is for a +/// lambda's operator(), points to the declaration of +/// the lambda variable. +

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Chris Apple via cfe-commits
cjappl wrote: Weekly reviewer ping @vitalybuka @MaskRay @pcc https://github.com/llvm/llvm-project/pull/106736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/101857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-06 Thread Edd Dawson via cfe-commits
@@ -323,46 +323,63 @@ toolchains::PS4PS5Base::PS4PS5Base(const Driver &D, const llvm::Triple &Triple, const ArgList &Args, StringRef Platform, const char *EnvVar) : Generic_ELF(D, Triple, Args) { - // D

[clang] [llvm] [ARM] Save floating point registers and status registers with save_fp function attribute (PR #89654)

2024-09-06 Thread Benson Chu via cfe-commits
https://github.com/pestctrl updated https://github.com/llvm/llvm-project/pull/89654 >From bf936c53e3a2052a945787dc2efc17218e0352d5 Mon Sep 17 00:00:00 2001 From: Jake Vossen Date: Wed, 30 Jun 2021 15:13:13 -0500 Subject: [PATCH 1/3] [ARM] Save floating point registers with save_fp function att

[clang] [llvm] [ARM] Save floating point registers and status registers with save_fp function attribute (PR #89654)

2024-09-06 Thread Benson Chu via cfe-commits
pestctrl wrote: ping https://github.com/llvm/llvm-project/pull/89654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RecursiveASTVisitor] Do not inline TraverseStmt (NFC) (PR #107601)

2024-09-06 Thread Nikita Popov via cfe-commits
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/107601 As things are now, this reduces size of clang bootstrapped with ThinLTO by 0.3% and reduces thin link time by 0.3%. More importantly, it avoids a large regression once https://github.com/llvm/llvm-project/pull/10

[clang] [RecursiveASTVisitor] Do not inline TraverseStmt (NFC) (PR #107601)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nikita Popov (nikic) Changes As things are now, this reduces size of clang bootstrapped with ThinLTO by 0.3% and reduces thin link time by 0.3%. More importantly, it avoids a large regression once https://github.com/llvm/llvm-project/pull

[clang] [RecursiveASTVisitor] Do not inline TraverseStmt (NFC) (PR #107601)

2024-09-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2ee7183e38b91525ebd803144a588a9548ca9a46 c56f9d8cb3766fd867c4ebd483abedc5a8b88f29 --e

[clang] [RecursiveASTVisitor] Do not inline TraverseStmt (NFC) (PR #107601)

2024-09-06 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/107601 >From f16539428465d61c9017c0f7686d9632913aa853 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Fri, 6 Sep 2024 17:45:14 +0200 Subject: [PATCH] [RecursiveASTVisitor] Do not inline TraverseStmt (NFC) --- clang/i

<    1   2   3   4   5   6   >