[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread Timm Baeder via cfe-commits
@@ -198,11 +198,11 @@ def NoRet : Opcode {} def Call : Opcode { - let Args = [ArgFunction, ArgUint32]; + let Args = [ArgFunction, ArgUint32, ArgExpr]; tbaederr wrote: You forgot the `This && IsMemberCall` check from the current interpreter. Consider these

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/102170 >From 9665cf5b791b89ca9f1f80e408135f052b808b31 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 7 Aug 2024 22:15:31 +0800 Subject: [PATCH 1/2] [Clang][Interp] Fix display of syntactically-invalid note for me

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-08-08 Thread Kishan Parmar via cfe-commits
Long5hot wrote: > I'm wondering why the GNU-compatible behavior is not on by default, > especially when in GNU mode (e.g., `-std=gnu17`)? ATR-PASS-COMPLEX-IN-GPRS was missing in clang as shown in ABI doc : https://example61560.wordpress.com/wp-content/uploads/2016/11/powerpc_abi.pdf > Also, t

[clang] [Clang][AST][NFC] Store template parameter position for TemplateTypeParmType in TypeBit (PR #102481)

2024-08-08 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM Are there any performance numbers worth mentioning? https://github.com/llvm/llvm-project/pull/102481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
@@ -198,11 +198,11 @@ def NoRet : Opcode {} def Call : Opcode { - let Args = [ArgFunction, ArgUint32]; + let Args = [ArgFunction, ArgUint32, ArgExpr]; yronglin wrote: Thanks, I've updated this PR, WDYT? https://github.com/llvm/llvm-project/pull/102170 ___

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/102170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugInfo][RemoveDIs] Use iterator-inserters in clang (PR #102006)

2024-08-08 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse updated https://github.com/llvm/llvm-project/pull/102006 >From cf967317327aa3971da62a15f357ee5b29268f14 Mon Sep 17 00:00:00 2001 From: Jeremy Morse Date: Mon, 5 Aug 2024 16:21:53 +0100 Subject: [PATCH 1/3] [DebugInfo][RemoveDIs] Use iterator-inserters in clang As part

[clang] [llvm] [ARM][AArch64] BTI, GCS, PAC Module flag update. (PR #86212)

2024-08-08 Thread Daniel Kiss via cfe-commits
@@ -0,0 +1,35 @@ +; This file contains the new semantic of the branch-target-enforcement, sign-return-address. +; Used for test mixing a mixed link case and also verify the import too in llc. + +; RUN: llc %s -o - | FileCheck %s + +target datalayout = "e-m:e-i8:8:32-i16:16:32-i64

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-08 Thread Tom Stellard via cfe-commits
tstellar wrote: It looks like this change also fixed some build failures on macOS too. https://github.com/llvm/llvm-project/pull/101344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 876ee11 - [Bounds Safety][NFC] Add some missing coverage for `-fexperimental-late-parse-attributes` (#102236)

2024-08-08 Thread via cfe-commits
Author: Dan Liew Date: 2024-08-08T09:57:47-07:00 New Revision: 876ee11eeeb2b6a7ccfefea00265b4bfd5f9b6dd URL: https://github.com/llvm/llvm-project/commit/876ee11eeeb2b6a7ccfefea00265b4bfd5f9b6dd DIFF: https://github.com/llvm/llvm-project/commit/876ee11eeeb2b6a7ccfefea00265b4bfd5f9b6dd.diff LOG:

[clang] [Bounds Safety][NFC] Add some missing coverage for `-fexperimental-late-parse-attributes` (PR #102236)

2024-08-08 Thread Dan Liew via cfe-commits
https://github.com/delcypher closed https://github.com/llvm/llvm-project/pull/102236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-08 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/101344 >From a39c6d5e3decabab87ff9360851981123ff962d7 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 31 Jul 2024 07:36:48 -0700 Subject: [PATCH 1/4] workflows/release-binaries: Enable flang builds on Windows

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread Timm Baeder via cfe-commits
@@ -198,11 +198,11 @@ def NoRet : Opcode {} def Call : Opcode { - let Args = [ArgFunction, ArgUint32]; + let Args = [ArgFunction, ArgUint32, ArgExpr]; tbaederr wrote: The `assert(MyCE == CallExpr);` needs to go, but other than that, `test/AST/Interp` work

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-08 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/101344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/102170 >From 9665cf5b791b89ca9f1f80e408135f052b808b31 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 7 Aug 2024 22:15:31 +0800 Subject: [PATCH 1/3] [Clang][Interp] Fix display of syntactically-invalid note for me

[clang] [llvm] [ARM][AArch64] BTI, GCS, PAC Module flag update. (PR #86212)

2024-08-08 Thread Daniel Kiss via cfe-commits
@@ -0,0 +1,35 @@ +; This file contains the new semantic of the branch-target-enforcement, sign-return-address. +; Used for test mixing a mixed link case and also verify the import too in llc. + +; RUN: llc %s -o - | FileCheck %s + +target datalayout = "e-m:e-i8:8:32-i16:16:32-i64

[clang] [llvm] [RISCV] Add Hazard3 CPU (PR #102452)

2024-08-08 Thread Alex Bradbury via cfe-commits
asb wrote: > I do have some worries about the definition as-is, as the core in the repo > has optional features (configurable at tape-out time). Reading the RP2350 > datasheet, not all of the optional features for Hazard3 are enabled (and I'm > of the opinion that the lack of arm-like `-mcpu=+

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/102170 >From 9665cf5b791b89ca9f1f80e408135f052b808b31 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 7 Aug 2024 22:15:31 +0800 Subject: [PATCH 1/3] [Clang][Interp] Fix display of syntactically-invalid note for me

[clang] [Clang] Simplify specifying passes via -Xoffload-linker (PR #102483)

2024-08-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. LG, thanks https://github.com/llvm/llvm-project/pull/102483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Simplify specifying passes via -Xoffload-linker (PR #102483)

2024-08-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/102483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Simplify specifying passes via -Xoffload-linker (PR #102483)

2024-08-08 Thread Joseph Huber via cfe-commits
@@ -571,9 +572,10 @@ Expected clang(ArrayRef InputFiles, const ArgList &Args) { } // Pass on -mllvm options to the linker invocation. - for (const opt::Arg *Arg : Args.filtered(OPT_mllvm)) -CmdArgs.push_back( -Args.MakeArgString("-Wl,-mllvm=" + StringRef(Arg-

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread Timm Baeder via cfe-commits
@@ -599,7 +599,7 @@ namespace Destructors { }; constexpr int testS() { S{}; // ref-note {{in call to 'S{}.~S()'}} \ - // expected-note {{in call to '&S{}->~S()'}} + // expected-note {{in call to 'S{}.~S()'}} tbaederr wrote: ```suggestio

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread Timm Baeder via cfe-commits
@@ -0,0 +1,87 @@ +// RUN: %clang_cc1 -DNEW_CONST_INTERP -std=c++20 -fexperimental-new-constant-interpreter -fsyntax-only -verify %s tbaederr wrote: ```suggestion // RUN: %clang_cc1 -std=c++20 -fexperimental-new-constant-interpreter -fsyntax-only -verify %s ```

[clang] [llvm] [ARM][AArch64] BTI, GCS, PAC Module flag update. (PR #86212)

2024-08-08 Thread Daniel Kiss via cfe-commits
@@ -0,0 +1,35 @@ +; This file contains the new semantic of the branch-target-enforcement, sign-return-address. DanielKristofKiss wrote: done. https://github.com/llvm/llvm-project/pull/86212 ___ cfe-commits mailing lis

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread Timm Baeder via cfe-commits
@@ -169,11 +170,32 @@ void InterpFrame::describe(llvm::raw_ostream &OS) const { F && (F->isBuiltin() || F->isLambdaStaticInvoker())) return; + const Expr *CallExpr = Caller->getExpr(getRetPC()); const FunctionDecl *F = getCallee(); - if (const auto *M = dyn_cast

[clang] [llvm] [ARM][AArch64] BTI, GCS, PAC Module flag update. (PR #86212)

2024-08-08 Thread Daniel Kiss via cfe-commits
@@ -0,0 +1,35 @@ +; This file contains the new semantic of the branch-target-enforcement, sign-return-address. +; Used for test mixing a mixed link case and also verify the import too in llc. + +; RUN: llc %s -o - | FileCheck %s DanielKristofKiss wrote: ack. ht

[clang] [llvm] [ARM][AArch64] BTI, GCS, PAC Module flag update. (PR #86212)

2024-08-08 Thread Daniel Kiss via cfe-commits
@@ -0,0 +1,86 @@ +;; Test verifies inlining happens cross module when module flags are upgraded. +;; `foo` and `main` are both old semantic while bar is the new semantic. +;; Regression test for #82763 + +; RUN: split-file %s %t +; RUN: opt -module-summary %t/foo.s -o %t/foo.o +;

[clang] [Clang] Simplify specifying passes via -Xoffload-linker (PR #102483)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102483 >From 9e8a8e78f3014324d8aa35dd1615b3f5720a5cb4 Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Wed, 7 Aug 2024 19:10:33 -0400 Subject: [PATCH 1/3] [Clang] Simplify specifying passes via -Xoffload-linker

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/102170 >From f14464c0734776cd79a2fbd93cec94e815276009 Mon Sep 17 00:00:00 2001 From: yronglin Date: Fri, 9 Aug 2024 01:22:29 +0800 Subject: [PATCH] [Clang][Interp] Fix display of syntactically-invalid note for member

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
@@ -198,11 +198,11 @@ def NoRet : Opcode {} def Call : Opcode { - let Args = [ArgFunction, ArgUint32]; + let Args = [ArgFunction, ArgUint32, ArgExpr]; yronglin wrote: Thank you, It works! https://github.com/llvm/llvm-project/pull/102170 __

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
@@ -169,11 +170,32 @@ void InterpFrame::describe(llvm::raw_ostream &OS) const { F && (F->isBuiltin() || F->isLambdaStaticInvoker())) return; + const Expr *CallExpr = Caller->getExpr(getRetPC()); const FunctionDecl *F = getCallee(); - if (const auto *M = dyn_cast

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
@@ -0,0 +1,87 @@ +// RUN: %clang_cc1 -DNEW_CONST_INTERP -std=c++20 -fexperimental-new-constant-interpreter -fsyntax-only -verify %s yronglin wrote: Done! https://github.com/llvm/llvm-project/pull/102170 ___ cfe-commit

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
@@ -599,7 +599,7 @@ namespace Destructors { }; constexpr int testS() { S{}; // ref-note {{in call to 'S{}.~S()'}} \ - // expected-note {{in call to '&S{}->~S()'}} + // expected-note {{in call to 'S{}.~S()'}} yronglin wrote: Done. https

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/102170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] #101784 part 1: introduce ctyped in an independent manner (PR #101941)

2024-08-08 Thread via cfe-commits
TsXor wrote: > 17. this does not work out of the box, at least not without further changes. > E.g. the exact example you gave there results in an error for me. If you mean `conf.lib.clang_Cursor_getTemplateArgumentKind`, then it just happened to be that exception. This function uses a deprecate

[clang] [llvm] [PAC][ELF][AArch64] Encode several ptrauth features in PAuth core info (PR #102508)

2024-08-08 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 created https://github.com/llvm/llvm-project/pull/102508 For llvm_linux platform, define the following meaning for bits 9, 10, 11: - bit 9: set if indirect gotos signing is enabled; - bit 10: set if type info vtable pointer discrimination is enabled; - bit 11: set if

[clang] [llvm] [PAC][ELF][AArch64] Encode several ptrauth features in PAuth core info (PR #102508)

2024-08-08 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 ready_for_review https://github.com/llvm/llvm-project/pull/102508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC][ELF][AArch64] Encode several ptrauth features in PAuth core info (PR #102508)

2024-08-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-llvm-binary-utilities Author: Daniil Kovalev (kovdan01) Changes For llvm_linux platform, define the following meaning for bits 9, 10, 11: - bit 9: set if indirect gotos signing is enabled; - bit 10: set if type info

[clang] #101784 part 1: introduce ctyped in an independent manner (PR #101941)

2024-08-08 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: > If you mean conf.lib.clang_Cursor_getTemplateArgumentKind, then it just > happened to be that exception. That one worked fine for me (need the args passed as well, but that's it), I meant the `SourceLocation` example with `clang_getRangeStart` below that https://github.c

[clang] [clang] Add frontend flag to enable support for broken external resugarers (PR #102510)

2024-08-08 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/102510 There are some external projects that can't rely on our own sugar propagation for templated entities, because they need to resugar types which only exist within their framework, and so are entirely invisible t

[clang] [clang] Add frontend flag to enable support for broken external resugarers (PR #102510)

2024-08-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes There are some external projects that can't rely on our own sugar propagation for templated entities, because they need to resugar types which only exist within their framework, and so are entirely invis

[clang] [clang] Add frontend flag to enable support for broken external resugarers (PR #102510)

2024-08-08 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/102510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6b5308b - [NFC] Remove unnecessary copy of Triples (#102469)

2024-08-08 Thread via cfe-commits
Author: Abhina Sree Date: 2024-08-08T13:58:30-04:00 New Revision: 6b5308b7924108d63149d7c521f21c5e90da7a09 URL: https://github.com/llvm/llvm-project/commit/6b5308b7924108d63149d7c521f21c5e90da7a09 DIFF: https://github.com/llvm/llvm-project/commit/6b5308b7924108d63149d7c521f21c5e90da7a09.diff L

[clang] [NFC] Remove unnecessary copy of Triples (PR #102469)

2024-08-08 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/102469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [clang] Reland: Instantiate alias templates with sugar (PR #101858)

2024-08-08 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > @mizvekov I will provide a more detailed response to the points you made in > your last message separately, but for now I would like to ask you to revert > the commit to unbreak us. @gribozavr see https://github.com/llvm/llvm-project/pull/102510 for alternative. > which mea

[clang] #101784 part 1: introduce ctyped in an independent manner (PR #101941)

2024-08-08 Thread via cfe-commits
TsXor wrote: I don't quite get what 17 meant. As far as I know about ctypes, `conf.lib.clang_getRangeStart` should be guaranteed to return an instance of `SourceLocation`. If it is to extinguish type errors, `typing.cast(SourceLocation, conf.lib.clang_getRangeStart(self))` can do this. https:

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #102364)

2024-08-08 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/102364 >From 88f1a873d6c6ef06ad9a1847d098d65845cf1469 Mon Sep 17 00:00:00 2001 From: Carlos Galvez Date: Tue, 6 Aug 2024 22:50:10 +0200 Subject: [PATCH 1/2] [clang] Turn -Wenum-constexpr-conversion into a hard e

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #102364)

2024-08-08 Thread Carlos Galvez via cfe-commits
@@ -49,6 +49,9 @@ C++ Specific Potentially Breaking Changes few users and can be written as ``__is_same(__remove_cv(T), decltype(nullptr))``, which GCC supports as well. +- The warning `-Wenum-constexpr-conversion` has been upgraded into a hard + compiler error that cann

[clang] [clang-tools-extra] [lldb] [clang] Reland: Instantiate alias templates with sugar (PR #101858)

2024-08-08 Thread Dmitri Gribenko via cfe-commits
gribozavr wrote: > @gribozavr see #102510 for alternative. Thank you! We are looking at this now. > That's not really true. You only need to upstream the AST affecting parts. > The attributes itself and AST node which represent it. The attributes are already upstream (we are reusing nullabili

[clang] [clang][modules] Enable built-in modules for the upcoming Apple releases (PR #102239)

2024-08-08 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > Failed to cherry-pick: > [0f1361b](https://github.com/llvm/llvm-project/commit/0f1361baf650641a59aaa1710d7a0b7b02f2e56d) > > https://github.com/llvm/llvm-project/actions/runs/10294025156 > > Please manually backport the fix and push it to your github fork. Once this

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-08-08 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/102040 >From 5e03c06d51600dff093bee15fd9cfb08e0afa5f3 Mon Sep 17 00:00:00 2001 From: higher-performance Date: Mon, 5 Aug 2024 15:04:19 -0400 Subject: [PATCH] Add Clang attribute to ensure that fields are ini

[clang] [llvm] [PAC][ELF][AArch64] Encode several ptrauth features in PAuth core info (PR #102508)

2024-08-08 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl approved this pull request. https://github.com/llvm/llvm-project/pull/102508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC][ELF][AArch64] Encode several ptrauth features in PAuth core info (PR #102508)

2024-08-08 Thread Anton Korobeynikov via cfe-commits
asl wrote: But please wait for @MaskRay or other reviwers https://github.com/llvm/llvm-project/pull/102508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Fix bug in `SourceRange.__contains__`, add tests (PR #101802)

2024-08-08 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/101802 >From 444d9480cf9629c81ae26636922af20db5bd52bf Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Sat, 3 Aug 2024 09:28:02 +0100 Subject: [PATCH 1/2] [libclang/python] Fix bug in SourceRange.__contains__,

[clang] [libclang/python] Fix bug in `SourceRange.__contains__`, add tests (PR #101802)

2024-08-08 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/101802 >From 444d9480cf9629c81ae26636922af20db5bd52bf Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Sat, 3 Aug 2024 09:28:02 +0100 Subject: [PATCH 1/2] [libclang/python] Fix bug in SourceRange.__contains__,

[clang] [libclang/python] Fix bug in `SourceRange.__contains__`, add tests (PR #101802)

2024-08-08 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/101802 >From fd7a542c37d2da85b0994af77569a3b9e281c9a8 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Sat, 3 Aug 2024 09:28:02 +0100 Subject: [PATCH 1/2] [libclang/python] Fix bug in SourceRange.__contains__,

[clang] [clang] Implement CWG2627 Bit-fields and narrowing conversions (PR #78112)

2024-08-08 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/78112 >From 92f8720e3d21521b589d5291f086a2f32b87bfe0 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 14 Jan 2024 19:52:31 + Subject: [PATCH 01/13] [clang] [SemaCXX] Implement CWG2627 Bit-fields and narrow

[clang] [Clang][AST][NFC] Store template parameter position for TemplateTypeParmType in TypeBit (PR #102481)

2024-08-08 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: > LGTM > > Are there any performance numbers worth mentioning? I haven't checked... I'll check with llvm-compile-time-tracker. https://github.com/llvm/llvm-project/pull/102481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][AST][NFC] Store template parameter position for TemplateTypeParmType in TypeBit (PR #102481)

2024-08-08 Thread Matheus Izvekov via cfe-commits
@@ -6131,52 +6149,30 @@ class BTFTagAttributedType : public Type, public llvm::FoldingSetNode { class TemplateTypeParmType : public Type, public llvm::FoldingSetNode { friend class ASTContext; // ASTContext creates these - // Helper data collector for canonical types. - s

[clang] [clang] Implement CWG2627 Bit-fields and narrowing conversions (PR #78112)

2024-08-08 Thread Mital Ashok via cfe-commits
MitalAshok wrote: @AaronBallman I think I've addressed all your comments, thanks for the review! Could you please merge this for me if there is nothing else? https://github.com/llvm/llvm-project/pull/78112 ___ cfe-commits mailing list cfe-commits@list

[clang-tools-extra] [clang-tidy] Create bugprone-public-enable-shared-from-this check (PR #102299)

2024-08-08 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: Yu could use isDerivedFrom, should do a trick https://github.com/llvm/llvm-project/pull/102299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add flag to suppress overflow errors in C++ constant expressions. (PR #102390)

2024-08-08 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I targeted all overflows with this fix because we were missing diagnostics for all overflows. For example, "enum{x=99*99};" only produces a pedantic warning on clang 18. So if we need the extra flexibility, we should just add it for everything. I think a default

[clang] [Clang][AST][NFC] Store template parameter position for TemplateTypeParmType in TypeBit (PR #102481)

2024-08-08 Thread Krystian Stasiowski via cfe-commits
@@ -6131,52 +6149,30 @@ class BTFTagAttributedType : public Type, public llvm::FoldingSetNode { class TemplateTypeParmType : public Type, public llvm::FoldingSetNode { friend class ASTContext; // ASTContext creates these - // Helper data collector for canonical types. - s

[clang] [Clang] Fix Handling of Init Capture with Parameter Packs in LambdaScopeForCallOperatorInstantiationRAII (PR #100766)

2024-08-08 Thread via cfe-commits
@@ -712,22 +712,30 @@ bool Sema::addInstantiatedCapturesToScope( auto AddSingleCapture = [&](const ValueDecl *CapturedPattern, unsigned Index) { ValueDecl *CapturedVar = LambdaClass->getCapture(Index)->getCapturedVar(); -if (CapturedVar->

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl created https://github.com/llvm/llvm-project/pull/102521 When working on very busy systems, check-offload frequently fails many tests with this diagnostic: ``` clang: error: cannot determine amdgcn architecture: /tmp/llvm/build/bin/amdgpu-arch: Child timed out:

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joel E. Denny (jdenny-ornl) Changes When working on very busy systems, check-offload frequently fails many tests with this diagnostic: ``` clang: error: cannot determine amdgcn architecture: /tmp/llvm/build/bin/amdgpu-arch: Child timed o

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-testing-tools @llvm/pr-subscribers-backend-amdgpu Author: Joel E. Denny (jdenny-ornl) Changes When working on very busy systems, check-offload frequently fails many tests with this diagnostic: ``` clang: error: cannot determine amdgcn architecture: /t

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. LGTM otherwise. The CI currently fails on Windows, but that looks like it's using an old version of the test? https://github.com/llvm/llvm-project/pull/102170 ___ cfe-commits mailing list cfe-com

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread Timm Baeder via cfe-commits
@@ -46,7 +46,7 @@ constexpr int div(int a, int b) { return a / b; // both-note {{division by zero}} }; - return f(); // expected-note {{in call to '&f->operator()()'}} \ + return f(); // expected-note {{in call to 'f.operator()()'}} \ tbaederr wrote:

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/102170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: Maybe we should bump the default time up? I don't know what's reasonable in this area, but the GPU drivers have a bad habit of timing out. I think you could document the env var in the error message itself, and `-1` should mean effectively infinite. https

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > Maybe we should bump the default time up? I don't know what's reasonable in > this area, but the GPU drivers have a bad habit of deadlocking, so this is to > prevent that. I don't know the right value either. If no one else is complaining, maybe 10s is fine under normal

[clang] [HLSL] Split out the ROV attribute from the resource attribute, make it a new spellable attribute. (PR #102414)

2024-08-08 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/102414 >From c35e4ec3f8ea27eedc0658921d8d9055451acd91 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 7 Aug 2024 19:34:54 -0700 Subject: [PATCH 1/3] split out ROV from resource attr --- clang/include/clang/

[clang] [Clang][Interp] Fix display of syntactically-invalid note for member function calls (PR #102170)

2024-08-08 Thread Timm Baeder via cfe-commits
tbaederr wrote: And FYI, no additional regressions reported: ![Screenshot from 2024-08-08 21-24-55](https://github.com/user-attachments/assets/ea9af278-a428-41f2-835c-22780859ef88) https://github.com/llvm/llvm-project/pull/102170 ___ cfe-commits mai

[clang] [llvm] [AArch64] Add FEAT_SME_B16B16 and remove FEAT_B16B16 (PR #102501)

2024-08-08 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM :) https://github.com/llvm/llvm-project/pull/102501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86_64] Fix empty field error in vaarg of C++. (PR #101639)

2024-08-08 Thread Eli Friedman via cfe-commits
@@ -3124,26 +3124,40 @@ RValue X86_64ABIInfo::EmitVAArg(CodeGenFunction &CGF, Address VAListAddr, CGF.Builder.CreateStore(V, CGF.Builder.CreateStructGEP(Tmp, 1)); RegAddr = Tmp.withElementType(LTy); - } else if (neededInt) { -RegAddr = Address(CGF.Builder.CreateG

[clang] [clang] Implement CWG2627 Bit-fields and narrowing conversions (PR #78112)

2024-08-08 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/78112 >From 92f8720e3d21521b589d5291f086a2f32b87bfe0 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 14 Jan 2024 19:52:31 + Subject: [PATCH 01/14] [clang] [SemaCXX] Implement CWG2627 Bit-fields and narrow

[clang] [Clang][AST][NFC] Store template parameter position for TemplateTypeParmType in TypeBit (PR #102481)

2024-08-08 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @mizvekov [llvm-compile-time-tracker](https://llvm-compile-time-tracker.com/compare.php?from=3e3ea54aada44212b4e273f2fc879a419dea053f&to=77585f02c39d182e6aef60856ec6816d28ce0888&stat=instructions:u) reports a 0.07% improvement in userspace instruction retired. Not bad :). htt

[clang] d52cc9d - [Clang][AST][NFC] Store template parameter position for TemplateTypeParmType in TypeBit (#102481)

2024-08-08 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-08-08T15:46:27-04:00 New Revision: d52cc9de5ad92854613143bbd5f8b0771b2db1e1 URL: https://github.com/llvm/llvm-project/commit/d52cc9de5ad92854613143bbd5f8b0771b2db1e1 DIFF: https://github.com/llvm/llvm-project/commit/d52cc9de5ad92854613143bbd5f8b0771b2db1e1

[clang] [Clang][AST][NFC] Store template parameter position for TemplateTypeParmType in TypeBit (PR #102481)

2024-08-08 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/102481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-08 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B updated https://github.com/llvm/llvm-project/pull/100247 >From 44a1045eee71777fa916e2a8043b2f99afc96a96 Mon Sep 17 00:00:00 2001 From: Artem Belevich Date: Thu, 18 Jul 2024 15:05:01 -0700 Subject: [PATCH 1/3] [CUDA] Add a pseudo GPU sm_next which allows overrides for

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > Maybe we should bump the default time up? I don't know what's reasonable in > > this area, but the GPU drivers have a bad habit of deadlocking, so this is > > to prevent that. > > I don't know the right value either. If no one else is complaining, maybe 10s > is fine under

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-08 Thread Artem Belevich via cfe-commits
@@ -26,24 +27,38 @@ static cl::opt NoF16Math("nvptx-no-f16-math", cl::Hidden, cl::desc("NVPTX Specific: Disable generation of f16 math ops."), cl::init(false)); +static cl::opt +NextSM("nvptx-next-sm", cl::Hidden, + cl::desc("NVPTX

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #102364)

2024-08-08 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: By the way, the latest revision of the GDB patch (improved after the first round of review) can be found here: https://sourceware.org/pipermail/gdb-patches/2024-June/210252.html https://github.com/llvm/llvm-project/pull/102364 __

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-08 Thread Artem Belevich via cfe-commits
@@ -26,24 +27,38 @@ static cl::opt NoF16Math("nvptx-no-f16-math", cl::Hidden, cl::desc("NVPTX Specific: Disable generation of f16 math ops."), cl::init(false)); +static cl::opt +NextSM("nvptx-next-sm", cl::Hidden, + cl::desc("NVPTX

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-08-08 Thread via cfe-commits
higher-performance wrote: RFC: https://discourse.llvm.org/t/rfc-add-clang-attribute-to-ensure-that-fields-are-initialized-explicitly/80626 https://github.com/llvm/llvm-project/pull/102040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-08 Thread Joseph Huber via cfe-commits
@@ -52,6 +53,42 @@ const char *CudaVersionToString(CudaVersion V); // Input is "Major.Minor" CudaVersion CudaStringToVersion(const llvm::Twine &S); +enum class PTXVersion { + PTX_UNKNOWN = 0, + PTX_32 = 32, + PTX_40 = 40, + PTX_41, + PTX_42, + PTX_43, + PTX_50 = 50, +

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: Makes sense overall https://github.com/llvm/llvm-project/pull/100247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/100247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM][AArch64] BTI, GCS, PAC Module flag update. (PR #86212)

2024-08-08 Thread Daniel Kiss via cfe-commits
@@ -5278,6 +5278,106 @@ void llvm::UpgradeFunctionAttributes(Function &F) { } } +// Check if the module attribute is present and set to one. +static bool isModuleAttributeOne(Module &M, const StringRef &ModAttr) { + const auto *Attr = + mdconst::extract_or_null(M.getMo

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-08-08 Thread Artem Belevich via cfe-commits
@@ -52,6 +53,42 @@ const char *CudaVersionToString(CudaVersion V); // Input is "Major.Minor" CudaVersion CudaStringToVersion(const llvm::Twine &S); +enum class PTXVersion { + PTX_UNKNOWN = 0, + PTX_32 = 32, + PTX_40 = 40, + PTX_41, + PTX_42, + PTX_43, + PTX_50 = 50, +

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102521 >From 6546428805b52f1b6f350193ab08ff027892710f Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 8 Aug 2024 15:02:04 -0400 Subject: [PATCH 1/2] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl edited https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
@@ -116,6 +117,15 @@ ToolChain::executeToolChainProgram(StringRef Executable, }; std::string ErrorMessage; + int SecondsToWait = DefaultSecondsToWait; + if (std::optional Str = + llvm::sys::Process::GetEnv("CLANG_TOOL_CHAIN_PROGRAM_WAIT")) { +int Val = std::

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joel E. Denny via cfe-commits
https://github.com/jdenny-ornl updated https://github.com/llvm/llvm-project/pull/102521 >From 6546428805b52f1b6f350193ab08ff027892710f Mon Sep 17 00:00:00 2001 From: "Joel E. Denny" Date: Thu, 8 Aug 2024 15:02:04 -0400 Subject: [PATCH 1/3] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout

[clang] [clang-tools-extra] [lldb] [clang] Reland: Instantiate alias templates with sugar (PR #101858)

2024-08-08 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: > From past conversations with IWYU maintainer, this was desirable, since IWYU > rolls its own resugarer, which is faulty and difficult to maintain. I just want to mention that, actually, IWYU doesn't probably need any resugarer at all. A type template argument as-written is

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joseph Huber via cfe-commits
@@ -116,6 +117,15 @@ ToolChain::executeToolChainProgram(StringRef Executable, }; std::string ErrorMessage; + int SecondsToWait = DefaultSecondsToWait; + if (std::optional Str = + llvm::sys::Process::GetEnv("CLANG_TOOL_CHAIN_PROGRAM_WAIT")) { +int Val = std::

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joseph Huber via cfe-commits
@@ -99,7 +99,8 @@ def warn_drv_amdgpu_cov6: Warning< " use at your own risk">; def err_drv_undetermined_gpu_arch : Error< "cannot determine %0 architecture: %1; consider passing it via " - "'%2'">; + "'%2' or increasing the tool timeout using the environment variable " +

[clang] [llvm] [Clang] Add env var for nvptx-arch/amdgpu-arch timeout (PR #102521)

2024-08-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/102521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >