[clang] [Sema] Fix computations of "unexpanded packs" in substituted lambdas (PR #99882)

https://github.com/cor3ntin commented: I think I prefer the approach chosen by @zyn0217. The changes are more targeted, and using a visitor for the call operator avoid a lot of code duplication. In particular, if we want to properly handle attributes, we might need code in `CollectUnexpandedPa

[clang] [Sema] Fix computations of "unexpanded packs" in substituted lambdas (PR #99882)

@@ -4854,15 +4855,7 @@ class CXXFoldExpr : public Expr { CXXFoldExpr(QualType T, UnresolvedLookupExpr *Callee, SourceLocation LParenLoc, Expr *LHS, BinaryOperatorKind Opcode, SourceLocation EllipsisLoc, Expr *RHS, SourceLocation RParenLoc, -

[clang] [clang-format] Add BreakBinaryOperations configuration (PR #95013)

ameerj wrote: > Failed Tests (1): Fixed in the latest commit https://github.com/llvm/llvm-project/pull/95013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix computations of "unexpanded packs" in substituted lambdas (PR #99882)

@@ -353,7 +353,11 @@ Sema::DiagnoseUnexpandedParameterPacks(SourceLocation Loc, } if (!EnclosingStmtExpr) { -LSI->ContainsUnexpandedParameterPack = true; +// It is ok to have unexpanded packs in captures, template parameters +// and paramete

[clang] [llvm] [PowerPC] Add builtin_cpu_is P11 support (PR #99550)

azhan92 wrote: > Should there be a lit test for the linux part as well? Is there a pre-existing test already, or should I add a new one? I can't seem to find an equivalent to `clang/test/CodeGen/aix-builtin-cpu-is.c` https://github.com/llvm/llvm-project/pull/99550 _

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

arsenm wrote: > Also, apparently there's some driver tests that expect > `--target=amdgcn-amd-amdhsa-opencl` as the environment type. Is that the > expected way to specify OpenCL? I'm not overly familiar. > That was a mistake from long ago we shouldn't continue. A language is not an environm

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

jhuber6 wrote: > > Also, apparently there's some driver tests that expect > > `--target=amdgcn-amd-amdhsa-opencl` as the environment type. Is that the > > expected way to specify OpenCL? I'm not overly familiar. > > That was a mistake from long ago we shouldn't continue. A language is not an

[clang] [Clang][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

@@ -21703,32 +21703,37 @@ const ValueDecl *SemaOpenMP::getOpenMPDeclareMapperVarName() const { return cast(DSAStack->getDeclareMapperVarRef())->getDecl(); } -OMPClause *SemaOpenMP::ActOnOpenMPNumTeamsClause(Expr *NumTeams, +OMPClause *SemaOpenMP::ActOnOpenMPNumTeamsClause(A

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

@@ -2854,10 +2854,121 @@ void CodeGenFunction::EmitMultiVersionResolver( case llvm::Triple::aarch64: EmitAArch64MultiVersionResolver(Resolver, Options); return; + case llvm::Triple::riscv32: + case llvm::Triple::riscv64: +EmitRISCVMultiVersionResolver(Resolver,

[clang] [Sema] Fix computations of "unexpanded packs" in substituted lambdas (PR #99882)

ilya-biryukov wrote: > I think I prefer the approach chosen by @zyn0217. > > The changes are more targeted, and using a visitor for the call operator > avoid a lot of code duplication. In particular, if we want to properly handle > attributes, we might need code in `CollectUnexpandedParameterP

[clang] [Sema] Fix computations of "unexpanded packs" in substituted lambdas (PR #99882)

@@ -353,7 +353,11 @@ Sema::DiagnoseUnexpandedParameterPacks(SourceLocation Loc, } if (!EnclosingStmtExpr) { -LSI->ContainsUnexpandedParameterPack = true; +// It is ok to have unexpanded packs in captures, template parameters +// and paramete

[clang] [Sema] Fix computations of "unexpanded packs" in substituted lambdas (PR #99882)

https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/99882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

@@ -21703,32 +21703,37 @@ const ValueDecl *SemaOpenMP::getOpenMPDeclareMapperVarName() const { return cast(DSAStack->getDeclareMapperVarRef())->getDecl(); } -OMPClause *SemaOpenMP::ActOnOpenMPNumTeamsClause(Expr *NumTeams, +OMPClause *SemaOpenMP::ActOnOpenMPNumTeamsClause(A

[clang] [llvm] [AArch64][PAC] Sign block addresses used in indirectbr. (PR #97647)

asl wrote: FWIW, we are seeing authentication fails when running musl with pauth enabled and this PR. Working on reproducer. https://github.com/llvm/llvm-project/pull/97647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] 0b12e18 - [clang-fuzzer-dictionary] Fix build failure with libfuzzer (#99871)

Author: Raphael Isemann Date: 2024-07-22T09:29:34-07:00 New Revision: 0b12e185bd81b2199f95e211743f011084a79195 URL: https://github.com/llvm/llvm-project/commit/0b12e185bd81b2199f95e211743f011084a79195 DIFF: https://github.com/llvm/llvm-project/commit/0b12e185bd81b2199f95e211743f011084a79195.dif

[clang] [clang-fuzzer-dictionary] Fix build failure with libfuzzer (PR #99871)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/99871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From 294a7cce4f72324ac9042ef0c3725d3e088b16b5 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [llvm] [PowerPC] Add builtin_cpu_is P11 support (PR #99550)

daltenty wrote: > > Should there be a lit test for the linux part as well? > > Is there a pre-existing test already, or should I add a new one? I can't seem > to find an equivalent to `clang/test/CodeGen/aix-builtin-cpu-is.c` There's an existing `ppc64le` block in `clang/test/CodeGen/builtin-

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

dcci wrote: Reduced: https://github.com/llvm/llvm-project/issues/99894 https://github.com/llvm/llvm-project/pull/90574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Interp] `__builtin_os_log_format_buffer_size` should be an unevaluated builtin (PR #99895)

https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/99895 Follow the current behavior of constant evaluator, `__builtin_os_log_format_buffer_size` should be an unevaluated builtin. The following code is well-formed: ``` void test_builtin_os_log(void *buf, int i, const

[clang] [Clang][Interp] `__builtin_os_log_format_buffer_size` should be an unevaluated builtin (PR #99895)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (yronglin) Changes Follow the current behavior of constant evaluator, `__builtin_os_log_format_buffer_size` should be an unevaluated builtin. The following code is well-formed: ``` void test_builtin_os_log(void *buf, int i, const cha

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From 4b8c087dc0318d1802f7635e1d33942cbf833109 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/99727 >From e956b0deb6dff3513f725ad601c2003123841832 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 19 Jul 2024 17:53:44 -0700 Subject: [PATCH] [clang][headers] Including stddef.h always redefines NUL

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

https://github.com/asb created https://github.com/llvm/llvm-project/pull/99898 As discussed at the last sync-up call, mark Zacas as experimental until this ABI issue is resolved . >From 7862d7e5fc63749f68bfdc0f0d8c226d341c55e1 Mon

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

ahatanak wrote: Should we use unreachable If it's not possible to suppress the warning from gcc? https://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations https://github.com/llvm/llvm-project/pull/99763 __

[clang] [Clang] Loop over FieldDecls instead of all Decls (PR #99574)

bwendling wrote: Okay. I'll look into it. On Sun, Jul 21, 2024 at 4:35 PM Nathan Chancellor ***@***.***> wrote: > I see a crash in drivers/thermal/thermal_core.c in Linux kernels without > commit daeeb032f42d > > ("thermal:

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

llvmbot wrote: @llvm/pr-subscribers-mc @llvm/pr-subscribers-clang Author: Alex Bradbury (asb) Changes As discussed at the last sync-up call, mark Zacas as experimental until this ABI issue is resolved ;. --- Patch is 21.32

[clang] [APINotes] Support nested tags (PR #99655)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/99655 >From f1e3a236ca5dbc64913b0d44bdf92a30d38b8277 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Fri, 19 Jul 2024 15:24:10 +0100 Subject: [PATCH] [APINotes] Support nested tags This allows annotating C/C++ struc

[clang] [APINotes] Support nested tags (PR #99655)

@@ -456,6 +458,7 @@ template <> struct MappingTraits { IO.mapOptional("EnumKind", T.EnumConvenienceKind); IO.mapOptional("SwiftCopyable", T.SwiftCopyable); IO.mapOptional("Methods", T.Methods); +IO.mapOptional("Tags", T.Tags); egorzhdan wrote:

[clang] [Sema] Fix computations of "unexpanded packs" in substituted lambdas (PR #99882)

@@ -353,7 +353,11 @@ Sema::DiagnoseUnexpandedParameterPacks(SourceLocation Loc, } if (!EnclosingStmtExpr) { -LSI->ContainsUnexpandedParameterPack = true; +// It is ok to have unexpanded packs in captures, template parameters +// and paramete

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

@@ -3363,6 +3363,7 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx, #include "clang/Basic/RISCVVTypes.def" llvm_unreachable("not yet implemented"); } +break; AaronBallman wrote: Does inserting an `llvm_unreachable()` here w

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

https://github.com/preames approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/99898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Support nested tags (PR #99655)

@@ -783,51 +783,76 @@ static void ProcessVersionedAPINotes( } } +static std::optional +UnwindNamespaceContext(DeclContext *DC, api_notes::APINotesManager &APINotes) { + if (auto NamespaceContext = dyn_cast(DC)) { +for (auto Reader : APINotes.findAPINotes(NamespaceContex

[clang] [SPARC][clang] Add -m(no-)v8plus flags handling (PR #98713)

https://github.com/AaronBallman commented: The changes LGTM as far as they go, but I've added the driver and options code owners just to make sure they're also happy. https://github.com/llvm/llvm-project/pull/98713 ___ cfe-commits mailing list cfe-com

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

dtcxzyw wrote: Please update this line :) https://github.com/llvm/llvm-project/blob/90569e02e63ff5d0915446919f564e9b3638fe2a/llvm/lib/TargetParser/Host.cpp#L2070 https://github.com/llvm/llvm-project/pull/99898 ___ cfe-commits mailing list cfe-commits@l

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

ilovepi wrote: Ah, it looks like we had another set of these. I just filed https://github.com/llvm/llvm-project/issues/99901 after a similar issue was reported in LLD. https://github.com/llvm/llvm-project/pull/99763 ___ cfe-commits mailing list cfe-c

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

4vtomat wrote: > Should we use unreachable If it's not possible to suppress the warning from > gcc? > > https://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations Maybe, but I just want to keep the original semantic here since if the case wa

[clang-tools-extra] [libc] clang-tidy: readability-redundant-smartptr-get does not remove -> (#97964) (PR #98757)

@@ -235,3 +276,13 @@ void Negative() { if (MACRO(x) == nullptr) ; } + +void test_redundant_get() { + std::vector> v; + auto f = [](int) {}; + for (auto i = v.begin(); i != v.end(); ++i) { +f(*i->get()); akshaykumars614 wrote: I tried something lik

[clang] [Clang][AST] Don't use canonical type when checking dependence in Type::isOverloadable (PR #98563)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/98563 >From 5cefddec13ca2bafb58a6f714fd2bef435166c8d Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Thu, 11 Jul 2024 18:28:50 -0400 Subject: [PATCH 1/2] [Clang][AST] Don't use canonical type when checking

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

@@ -3363,6 +3363,7 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx, #include "clang/Basic/RISCVVTypes.def" llvm_unreachable("not yet implemented"); } +break; 4vtomat wrote: Would it break if the case is not presented if we

[clang] [AST] RecursiveASTVisitor: Don't traverse the alias deduction guides in the default mode. (PR #91454)

keith wrote: @hokein looks like this test wasn't added to any CMakeLists.txt so it doesn't actually run? https://github.com/llvm/llvm-project/pull/91454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

https://github.com/4vtomat edited https://github.com/llvm/llvm-project/pull/99763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] RecursiveASTVisitor: Don't traverse the alias deduction guides in the default mode. (PR #91454)

keith wrote: I think you want it here? https://github.com/llvm/llvm-project/blob/c7bfc41860a6abe5c92dc5afb47348b0c9e69963/clang/unittests/Tooling/CMakeLists.txt#L42 https://github.com/llvm/llvm-project/pull/91454 ___ cfe-commits mailing list cfe-commi

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

@@ -3363,6 +3363,7 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx, #include "clang/Basic/RISCVVTypes.def" llvm_unreachable("not yet implemented"); } +break; 4vtomat wrote: I mean, it's not supposed to crash if the case is

[clang] [AST] RecursiveASTVisitor: Don't traverse the alias deduction guides in the default mode. (PR #91454)

keith wrote: I think the tests broke in https://github.com/llvm/llvm-project/pull/99840 https://github.com/llvm/llvm-project/pull/91454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

4vtomat wrote: > Ah, it looks like we had another set of these. I just filed #99901 after a > similar issue was reported in LLD. Thanks for filing this! https://github.com/llvm/llvm-project/pull/99763 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/99905 Given "loop" construct, clang will try to treat it as "for", "distribute" or "simd", depending on either the implied binding, or the bind clause if present. This patch moves the code that performs this construc

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Krzysztof Parzyszek (kparzysz) Changes Given "loop" construct, clang will try to treat it as "for", "distribute" or "simd", depending on either the implied binding, or the bind clause if present. This patch moves the code that per

[clang] Add _MM_FROUND_TIES_TO_EVEN to avx512fintrin.h (PR #99691)

https://github.com/hpkfft updated https://github.com/llvm/llvm-project/pull/99691 >From b4fcf05f7df9365cd8289a20badad6ff485ecbd5 Mon Sep 17 00:00:00 2001 From: "hpkfft.com" Date: Fri, 19 Jul 2024 12:35:33 -0700 Subject: [PATCH 1/2] Add _MM_FROUND_TIES_TO_EVEN to avx512fintrin.h Intrinsics such

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

@@ -3363,6 +3363,7 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx, #include "clang/Basic/RISCVVTypes.def" llvm_unreachable("not yet implemented"); } +break; AaronBallman wrote: It would crash anyway if we fell through beca

[clang] [clang-scan-deps] Ignore import/include directives with missing filenames (PR #99520)

https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/99520 >From bcddefdce00a1e15f29181bc92eab86098a8b328 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Thu, 18 Jul 2024 08:56:24 -0700 Subject: [PATCH 1/2] [clang-scan-deps] Ignore import/include directives with m

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d7e185cca98411e82655feecc297906cb7ed0850 4657c66f04cf5b603afcc356468e61f8805cb264 --e

[clang] Add _MM_FROUND_TIES_TO_EVEN to avx512fintrin.h (PR #99691)

@@ -43,6 +43,7 @@ typedef unsigned short __mmask16; /* Rounding mode macros. */ #define _MM_FROUND_TO_NEAREST_INT 0x00 +#define _MM_FROUND_TIES_TO_EVEN 0x00 hpkfft wrote: I agree and have made the change. I think this will improve readability of user c

[clang] [clang][test] Add missing test file to cmake (PR #99907)

https://github.com/keith created https://github.com/llvm/llvm-project/pull/99907 Seems like this test was never running with cmake, but is running with bazel and broke at head. >From 82a1e48e7643b552f898f6866f768a78ea3ba7da Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Mon, 22 Jul 2024 17:

[clang] [AST] RecursiveASTVisitor: Don't traverse the alias deduction guides in the default mode. (PR #91454)

keith wrote: https://github.com/llvm/llvm-project/pull/99907 https://github.com/llvm/llvm-project/pull/91454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add _MM_FROUND_TO_NEAREST_TIES_EVEN to avx512fintrin.h (PR #99691)

https://github.com/hpkfft edited https://github.com/llvm/llvm-project/pull/99691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFCI] Prefer non-canonical template arguments for synthesized CTAD guides (PR #99840)

keith wrote: FYI this change broke a test that wasn't actually running, I made the test run but disabled the broken case here https://github.com/llvm/llvm-project/pull/99907 https://github.com/llvm/llvm-project/pull/99840 ___ cfe-commits mailing list

[clang] [clang][test] Add missing test file to cmake (PR #99907)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Keith Smiley (keith) Changes Seems like this test was never running with cmake, but is running with bazel and broke at head. --- Full diff: https://github.com/llvm/llvm-project/pull/99907.diff 2 Files Affected: - (modified) clang/unitt

[clang] [clang-scan-deps] Ignore import/include directives with missing filenames (PR #99520)

cyndyishida wrote: > This is similar feedback that I gave for #97654, could you test the change > with a unit test in `DependencyDirectivesScannerTest.cpp` instead? It's much > simpler to set up and execution-wise it's orders of magnitude more > lightweight than a whole new lit test. > > For

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

@@ -3363,6 +3363,7 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx, #include "clang/Basic/RISCVVTypes.def" llvm_unreachable("not yet implemented"); } +break; 4vtomat wrote: I guess it won't get into `Type::Record` if it fal

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/99905 >From 4657c66f04cf5b603afcc356468e61f8805cb264 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 18 Jul 2024 15:21:10 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Move "loop" directive mapping from sem

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/99763 >From 97dff508a361bbab478735eb4bf186d698649acf Mon Sep 17 00:00:00 2001 From: Brandon Wu Date: Sat, 20 Jul 2024 07:27:53 -0700 Subject: [PATCH] [ASTContext] Add a default case to nested switch in `encodeTypeForF

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

@@ -3363,6 +3363,7 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx, #include "clang/Basic/RISCVVTypes.def" llvm_unreachable("not yet implemented"); } +break; ilovepi wrote: won't you get an error for having a `default` case

[clang] Handle constant "pointers" for `__atomic_always_lock_free`/`__atomic_is_lock_free`. (PR #99340)

@@ -124,6 +124,24 @@ _Static_assert(__atomic_always_lock_free(4, &i64), ""); _Static_assert(!__atomic_always_lock_free(8, &i32), ""); _Static_assert(__atomic_always_lock_free(8, &i64), ""); +// Validate use with fake pointers constants. This mechanism is used to allow +// vali

[clang] Handle constant "pointers" for `__atomic_always_lock_free`/`__atomic_is_lock_free`. (PR #99340)

https://github.com/AaronBallman approved this pull request. LGTM but please add a release note when landing so users know about the changes. https://github.com/llvm/llvm-project/pull/99340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [HLSL][clang] Add elementwise builtins for trig intrinsics (PR #95999)

https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/95999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

@@ -3363,6 +3363,7 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx, #include "clang/Basic/RISCVVTypes.def" llvm_unreachable("not yet implemented"); } +break; 4vtomat wrote: Do you mean we should allow it to work if someone

[clang] [llvm] [mlir] Remove the `x86_mmx` IR type. (PR #98505)

@@ -94,14 +94,15 @@ entry: ; ; MMX Store +; Note: doesn't actually emit a non-temporal store here. ; define void @test_mmx(ptr nocapture %a0, ptr nocapture %a1) { ; ALL-LABEL: test_mmx: ; ALL: # %bb.0: # %entry ; ALL-NEXT:movq (%rdi), %mm0 ; ALL-NEXT:psrl

[clang] [clang] replaced the usage of `asctime` with `strftime` (PR #99075)

@@ -1721,11 +1721,13 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) { Diag(Tok.getLocation(), diag::warn_pp_date_time); // MSVC, ICC, GCC, VisualAge C++ extension. The generated string should be // of the form "Ddd Mmm dd hh::mm::ss ", which is returned b

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

@@ -2534,21 +2563,24 @@ static void emitCommonSimdLoop(CodeGenFunction &CGF, const OMPLoopDirective &S, static void emitOMPSimdRegion(CodeGenFunction &CGF, const OMPLoopDirective &S, PrePostActionTy &Action) { Action.Enter(CGF); - assert(isOpen

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

@@ -3852,44 +3895,44 @@ static bool emitWorksharingDirective(CodeGenFunction &CGF, OMPLoopScope LoopScope(CGF, S); return CGF.EmitScalarExpr(S.getNumIterations()); }; -const auto &&FirstGen = [&S, HasCancel](CodeGenFunction &CGF) { - CodeGenFunction::O

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

@@ -20,19 +20,18 @@ * modules. */ #if defined(__MVS__) && __has_include_next() -#include <__stdarg_header_macro.h> #undef __need___va_list #undef __need_va_list #undef __need_va_arg #undef __need___va_copy #undef __need_va_copy +#include <__stdarg_header_macro.h> ---

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

https://github.com/AaronBallman commented: These changes should come with a release note so users know about the fix. https://github.com/llvm/llvm-project/pull/99727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] [PAC][clang][Driver] Add signed GOT flag (PR #96160)

MaskRay wrote: Sorry, I haven't spent a lot of time on the review and the user interface. -mllvm and -Xclang options are for internal testing and might change names or disappear in the future. Driver options offer more stability for users. Given the complexity of the feature and lack of upstre

[clang] [clang-scan-deps] Ignore import/include directives with missing filenames (PR #99520)

akyrtzi wrote: > I switched to the unit test, though I didn't figure out how to capture the > same sort of round-trip testing as with the lit test. Are you not seeing the same "infinite calls append the same token into CurDirTokens" issue via the unit test? https://github.com/llvm/llvm-projec

[clang] [PS5] Adopt new compiler-rt naming scheme for the profile library. (PR #99862)

https://github.com/MaskRay approved this pull request. LGTM. The majority of patches omit the trailing period in the subject. https://github.com/llvm/llvm-project/pull/99862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [ASTContext] Add a break to nested switch in `encodeTypeForFunctionPointerAuth` (PR #99763)

@@ -3363,6 +3363,7 @@ static void encodeTypeForFunctionPointerAuth(const ASTContext &Ctx, #include "clang/Basic/RISCVVTypes.def" llvm_unreachable("not yet implemented"); } +break; AaronBallman wrote: My thinking was: if we add the `llvm_unreacha

[clang] [clang-scan-deps] Ignore import/include directives with missing filenames (PR #99520)

cyndyishida wrote: > > I switched to the unit test, though I didn't figure out how to capture the > > same sort of round-trip testing as with the lit test. > > Are you not seeing the same "infinite calls append the same token into > CurDirTokens" issue via the unit test? Oh yeah, that part is

[clang] [llvm] [PAC][clang][Driver] Add signed GOT flag (PR #96160)

kovdan01 wrote: > and lack of upstream runtime linker (rtld) support @MaskRay We actually have proof-of-concept support for musl https://github.com/access-softek/musl/commit/cbf25fbb2aaff125e232d5126dce7936f70a6453 (probably not ready for meaningful production usage though), and the signed GO

[clang] [llvm] [PAC][Driver] Support `pauthtest` ABI for AArch64 Linux triples (PR #97237)

https://github.com/smithp35 approved this pull request. After discussion in the PAuthABI call. We agreed that it would be best to have an exemplar of how a signing schema for a platform should be encoded rather than always using the individual options. Anton mentioned that we can document that

[clang] [clang-scan-deps] Ignore import/include directives with missing filenames (PR #99520)

https://github.com/akyrtzi approved this pull request. https://github.com/llvm/llvm-project/pull/99520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/99905 >From 4657c66f04cf5b603afcc356468e61f8805cb264 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 18 Jul 2024 15:21:10 -0500 Subject: [PATCH 1/3] [clang][OpenMP] Move "loop" directive mapping from sem

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/99905 >From 4657c66f04cf5b603afcc356468e61f8805cb264 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 18 Jul 2024 15:21:10 -0500 Subject: [PATCH 1/4] [clang][OpenMP] Move "loop" directive mapping from sem

[clang] Handle constant "pointers" for `__atomic_always_lock_free`/`__atomic_is_lock_free`. (PR #99340)

https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/99340 >From 2cb327b0377d4196982842455e2aaf4e6a21f667 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Wed, 17 Jul 2024 10:43:45 -0400 Subject: [PATCH 1/4] Handle constant "pointers" for `__atomic_always_lock_free`

[clang] [clang][OpenMP] Move "loop" directive mapping from sema to codegen (PR #99905)

https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/99905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 146fd7c - [PAC][Driver] Support `pauthtest` ABI for AArch64 Linux triples (#97237)

Author: Daniil Kovalev Date: 2024-07-22T21:18:39+03:00 New Revision: 146fd7cd454d71afb94d5d7ad7a3dbd6f3344d04 URL: https://github.com/llvm/llvm-project/commit/146fd7cd454d71afb94d5d7ad7a3dbd6f3344d04 DIFF: https://github.com/llvm/llvm-project/commit/146fd7cd454d71afb94d5d7ad7a3dbd6f3344d04.diff

[clang] [llvm] [PAC][Driver] Support `pauthtest` ABI for AArch64 Linux triples (PR #97237)

https://github.com/kovdan01 closed https://github.com/llvm/llvm-project/pull/97237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] replaced the usage of `asctime` with `strftime` (PR #99075)

@@ -1721,11 +1721,13 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) { Diag(Tok.getLocation(), diag::warn_pp_date_time); // MSVC, ICC, GCC, VisualAge C++ extension. The generated string should be // of the form "Ddd Mmm dd hh::mm::ss ", which is returned b

[clang] [clang] replaced the usage of `asctime` with `strftime` (PR #99075)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/99075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 511e93b - Handle constant "pointers" for `__atomic_always_lock_free`/`__atomic_is_lock_free`. (#99340)

Author: James Y Knight Date: 2024-07-22T14:20:25-04:00 New Revision: 511e93b96ee74438cbd643cec63281aff0663933 URL: https://github.com/llvm/llvm-project/commit/511e93b96ee74438cbd643cec63281aff0663933 DIFF: https://github.com/llvm/llvm-project/commit/511e93b96ee74438cbd643cec63281aff0663933.diff

[clang] Handle constant "pointers" for `__atomic_always_lock_free`/`__atomic_is_lock_free`. (PR #99340)

https://github.com/jyknight closed https://github.com/llvm/llvm-project/pull/99340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] replaced the usage of `asctime` with `strftime` (PR #99075)

@@ -1721,11 +1721,13 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) { Diag(Tok.getLocation(), diag::warn_pp_date_time); // MSVC, ICC, GCC, VisualAge C++ extension. The generated string should be // of the form "Ddd Mmm dd hh::mm::ss ", which is returned b

[clang-tools-extra] 315561c - [run-clang-tidy.py] Refactor, add progress indicator, add type hints (#89490)

Author: Nicolas van Kempen Date: 2024-07-22T20:23:49+02:00 New Revision: 315561c867784ebd9ca387e94ea6597918e7cc1c URL: https://github.com/llvm/llvm-project/commit/315561c867784ebd9ca387e94ea6597918e7cc1c DIFF: https://github.com/llvm/llvm-project/commit/315561c867784ebd9ca387e94ea6597918e7cc1c.

[clang-tools-extra] [run-clang-tidy.py] Refactor, add progress indicator, add type hints (PR #89490)

https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/89490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test] Add missing test file to cmake (PR #99907)

https://github.com/hokein approved this pull request. oops, good catch! https://github.com/llvm/llvm-project/pull/99907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test] Add missing test file to cmake (PR #99907)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/99907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test] Add missing test file to cmake (PR #99907)

@@ -58,7 +58,7 @@ Bar s(1); DeductionGuideVisitor::Lang_CXX2a)); } -TEST(RecursiveASTVisitor, DeductionGuideImplicitMode) { +TEST(RecursiveASTVisitor, DISABLED_DeductionGuideImplicitMode) { DeductionGuideVisitor Visitor(/*ShouldVisitImplicitCode*/ true); Visitor.Ex

[clang] [llvm] [OpenMPIRBuilder][Clang][NFC] - Combine `emitOffloadingArrays` and `emitOffloadingArraysArgument` in OpenMPIRBuilder (PR #97088)

https://github.com/bhandarkar-pranav updated https://github.com/llvm/llvm-project/pull/97088 >From dc9e64a29d6d1fd84ad630cb002d1129ea6a0a31 Mon Sep 17 00:00:00 2001 From: Pranav Bhandarkar Date: Sat, 15 Jun 2024 02:00:48 -0500 Subject: [PATCH 01/13] checkpoint commit. Use emitOffloadinArrays fr

[clang] [clang][headers] Including stddef.h always redefines NULL (PR #99727)

ian-twilightcoder wrote: > These changes should come with a release note so users know about the fix. Does it need a release note? It was introduced in 19 with https://github.com/llvm/llvm-project/pull/90676, and this will fix it in 19 too. https://github.com/llvm/llvm-project/pull/99727 _

<    1   2   3   4   5   6   7   >