[clang] [llvm] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-06-27 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/82819 >From df64bb1a12ea2b2a89151fa034a16cd641129347 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Mon, 22 Jan 2024 11:33:15 +0100 Subject: [PATCH] Emit attributes for functions always. Branch protection,

[clang] [clang][NFC] Move more things out of `SemaChecking.cpp` (PR #96641)

2024-06-27 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/96641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Clang: Add warning flag for storage class specifiers on explicit specializations (PR #96699)

2024-06-27 Thread David Blaikie via cfe-commits
dwblaikie wrote: > Minor nit: Probably don't need to explicitly define a diagnostic group, since > it's only ever used for this diagnostic. Not sure what the conventions are - but I rather like the normalization of having the explicit group, better chance of finding the group/reusing it maybe?

[clang] a1bce0b - Clang: Add warning flag for storage class specifiers on explicit specializations (#96699)

2024-06-27 Thread via cfe-commits
Author: David Blaikie Date: 2024-06-27T08:17:40-07:00 New Revision: a1bce0b89e800cb7ab1d3cf3437f8f34d0695468 URL: https://github.com/llvm/llvm-project/commit/a1bce0b89e800cb7ab1d3cf3437f8f34d0695468 DIFF: https://github.com/llvm/llvm-project/commit/a1bce0b89e800cb7ab1d3cf3437f8f34d0695468.diff

[clang] Clang: Add warning flag for storage class specifiers on explicit specializations (PR #96699)

2024-06-27 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie closed https://github.com/llvm/llvm-project/pull/96699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] improve messages when auto-fix does not work (PR #96917)

2024-06-27 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/96917 Fixes: #93157 >From 079e341092da1ce8b893887dc6f58a9986e5b6bd Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 27 Jun 2024 23:05:00 +0800 Subject: [PATCH] [clang-tidy] improve messages when auto-fix do

[clang-tools-extra] [clang-tidy] improve messages when auto-fix does not work (PR #96917)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes Fixes: #93157 --- Full diff: https://github.com/llvm/llvm-project/pull/96917.diff 4 Files Affected: - (modified) clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp (+35

[clang-tools-extra] [clang-tidy] improve messages when auto-fix does not work (PR #96917)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes Fixes: #93157 --- Full diff: https://github.com/llvm/llvm-project/pull/96917.diff 4 Files Affected: - (modified) clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp (+35-7) -

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Congcong Cai via cfe-commits
=��___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Congcong Cai via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang] [clang] Emitting a warning if optimizations are enabled with sanitizers (PR #95934)

2024-06-27 Thread via cfe-commits
Ritanya-B-Bharadwaj wrote: ping https://github.com/llvm/llvm-project/pull/95934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dade11f - [RISCV] Bump Pointer Masking extension version (#96715)

2024-06-27 Thread via cfe-commits
Author: Michael Maitland Date: 2024-06-27T11:42:05-04:00 New Revision: dade11f55e7c1045fc322bf61e84345f3dadb958 URL: https://github.com/llvm/llvm-project/commit/dade11f55e7c1045fc322bf61e84345f3dadb958 DIFF: https://github.com/llvm/llvm-project/commit/dade11f55e7c1045fc322bf61e84345f3dadb958.di

[clang] [llvm] [RISCV] Bump Pointer Masking extension version (PR #96715)

2024-06-27 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland closed https://github.com/llvm/llvm-project/pull/96715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Aaron Ballman via cfe-commits
@@ -1126,9 +1126,6 @@ class QualType { /// Return true if this is a trivially relocatable type. bool isTriviallyRelocatableType(const ASTContext &Context) const; - /// Return true if this is a trivially equality comparable type. - bool isTriviallyEqualityComparableType(c

[clang] [clang] Emitting a warning if optimizations are enabled with sanitizers (PR #95934)

2024-06-27 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I'm not certain we should issue a diagnostic when optimizations are enabled with sanitizers. For example, there is [explicit documentation that users *should* use `-O1` with address sanitizer](https://github.com/google/sanitizers/wiki/AddressSanitizer

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Nikolas Klauser via cfe-commits
@@ -1126,9 +1126,6 @@ class QualType { /// Return true if this is a trivially relocatable type. bool isTriviallyRelocatableType(const ASTContext &Context) const; - /// Return true if this is a trivially equality comparable type. - bool isTriviallyEqualityComparableType(c

[clang] 50b1534 - [clang][Interp] Don't diagnose non-const reads from the evaluating decl

2024-06-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-27T18:01:11+02:00 New Revision: 50b15341182e0a5f53dd6e9b4a00fef56f31147c URL: https://github.com/llvm/llvm-project/commit/50b15341182e0a5f53dd6e9b4a00fef56f31147c DIFF: https://github.com/llvm/llvm-project/commit/50b15341182e0a5f53dd6e9b4a00fef56f31147c.diff LO

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-27 Thread Tomas Matheson via cfe-commits
tmatheson-arm wrote: The only thing `AArch64TargetInfo::initFeatureMap` adds is features from the selected CPU. IMHO this was not an appropriate place to be doing that. Since #94279 the CPU features are added either by `AArch64TargetInfo::parseTargetAttr` when dealing with `__attribute(target

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-27 Thread via cfe-commits
ldrumm wrote: Can you please include rationale for why this this name e.g. why not `__NVPTX_VERSION__`? How does it relate to `__CUDA_ARCH__`, and why is `__CUDA_ARCH__` not sufficient? Are there ever point releases that might mean we should max +ptx78 should actually expand to `780` rather th

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-27 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/96921 This patch updates the return type HTMLTag::toString from SmallString<16> to const char*, since this API only has a single use to emit the string into an output stream. As a result, there is no need to construct a

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Paul Kirth (ilovepi) Changes This patch updates the return type HTMLTag::toString from SmallString<16> to const char*, since this API only has a single use to emit the string into an output stream. As a result, there is no need

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-27 Thread Paul Kirth via cfe-commits
ilovepi wrote: @PeterChou1 please take a look and provide some feedback. https://github.com/llvm/llvm-project/pull/96921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-27 Thread Paul Kirth via cfe-commits
@@ -56,7 +56,7 @@ class HTMLTag { operator bool() = delete; bool IsSelfClosing() const; - llvm::SmallString<16> ToString() const; + const char* toString() const; ilovepi wrote: Maybe this should be renamed to `c_str()` or `str()`? https://github.com/ll

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Aaron Ballman via cfe-commits
@@ -1126,9 +1126,6 @@ class QualType { /// Return true if this is a trivially relocatable type. bool isTriviallyRelocatableType(const ASTContext &Context) const; - /// Return true if this is a trivially equality comparable type. - bool isTriviallyEqualityComparableType(c

[clang-tools-extra] [clang-doc][NFC] Fix style guide violations in HTMLGenerator.cpp (PR #96924)

2024-06-27 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/96924 This patch addresses several code style issues that conflict with the project's style guide. Primarily the naming of functions, and `else` after `return` statements. It only addresses issues found in HTMLGenerator

[clang-tools-extra] [clang-doc][NFC] Fix style guide violations in HTMLGenerator.cpp (PR #96924)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Paul Kirth (ilovepi) Changes This patch addresses several code style issues that conflict with the project's style guide. Primarily the naming of functions, and `else` after `return` statements. It only addresses issues found in

[clang-tools-extra] [clang-doc][NFC] Fix style guide violations in HTMLGenerator.cpp (PR #96924)

2024-06-27 Thread Paul Kirth via cfe-commits
ilovepi wrote: @PeterChou1 please take a look at this patch, and provide some feedback. https://github.com/llvm/llvm-project/pull/96924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-27 Thread Victor Lomuller via cfe-commits
Naghasan wrote: Thanks for setting the reviewer > Can you please include rationale for why this this name e.g. why not > __NVPTX_VERSION__? `NVPTX` is the name of the LLVM backend, `PTX` is the name of assembly which have a version hence `__PTX_VERSION__`. Happy to use a better name, but it i

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

2024-06-27 Thread Alexis Perry-Holby via cfe-commits
@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s AlexisPerry wrote: Thank you so much for the catch! Yes, this guard is absolutely needed. https://github.com/llvm/llvm-project/pull/96688 ___

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-27 Thread Victor Lomuller via cfe-commits
https://github.com/Naghasan edited https://github.com/llvm/llvm-project/pull/94934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

2024-06-27 Thread Alexis Perry-Holby via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: mlir-translate -mlir-to-llvmir %s | FileCheck %s AlexisPerry wrote: Thanks again! Yes, you are absolutely correct. https://github.com/llvm/llvm-project/pull/96688 ___ cfe-commits mailing list

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

2024-06-27 Thread Alexis Perry-Holby via cfe-commits
https://github.com/AlexisPerry updated https://github.com/llvm/llvm-project/pull/96688 >From 2312d31b14aecc6eeea2e81d221ee004e5de3efc Mon Sep 17 00:00:00 2001 From: Alexis Perry-Holby Date: Thu, 6 Jun 2024 14:02:52 -0600 Subject: [PATCH 01/13] [flang] Add basic -mtune support --- clang/includ

[clang] [clang] Catch missing format attributes (PR #70024)

2024-06-27 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,277 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -Wmissing-format-attribute %s + +typedef unsigned short char16_t; +typedef unsigned int char32_t; +typedef __WCHAR_TYPE__ wchar_t; +typedef __SIZE_TYPE__ size_t; +typedef __builtin_va_list va_list; + +__attribute__((__for

[clang] e258bb3 - [clang][docs] Update the gsl::Pointer/Owner attr doc (#96908)

2024-06-27 Thread via cfe-commits
Author: Haojian Wu Date: 2024-06-27T18:53:54+02:00 New Revision: e258bb38dc8f00cc366df877d0e6f869657b7a8b URL: https://github.com/llvm/llvm-project/commit/e258bb38dc8f00cc366df877d0e6f869657b7a8b DIFF: https://github.com/llvm/llvm-project/commit/e258bb38dc8f00cc366df877d0e6f869657b7a8b.diff LO

[clang] [clang][docs] Update the gsl::Pointer/Owner attr doc (PR #96908)

2024-06-27 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/96908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Nikolas Klauser via cfe-commits
@@ -1126,9 +1126,6 @@ class QualType { /// Return true if this is a trivially relocatable type. bool isTriviallyRelocatableType(const ASTContext &Context) const; - /// Return true if this is a trivially equality comparable type. - bool isTriviallyEqualityComparableType(c

[clang] [clang][OpenMP] Simplify handling of `if` clause (PR #96936)

2024-06-27 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/96936 Get the allowed name modifiers from the list of constituent leaf directives. >From e42fa94623d920a216636318600c7e303ef6fc9d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 27 Jun 2024 12:11:06 -05

[clang] [clang][OpenMP] Simplify handling of `if` clause (PR #96936)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krzysztof Parzyszek (kparzysz) Changes Get the allowed name modifiers from the list of constituent leaf directives. --- Full diff: https://github.com/llvm/llvm-project/pull/96936.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaOp

[clang] [Clang] Access tls_guard via llvm.threadlocal.address (PR #96633)

2024-06-27 Thread John McCall via cfe-commits
@@ -1059,9 +1059,15 @@ CodeGenFunction::GenerateCXXGlobalInitFunc(llvm::Function *Fn, if (Guard.isValid()) { // If we have a guard variable, check whether we've already performed // these initializations. This happens for TLS initialization functions. - ll

[clang] [clang][OpenMP] Simplify handling of `if` clause (PR #96936)

2024-06-27 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG, thanks! https://github.com/llvm/llvm-project/pull/96936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][FMV] Do not omit explicit default target_version attribute. (PR #96628)

2024-06-27 Thread Alexandros Lamprineas via cfe-commits
@@ -11523,10 +11525,16 @@ static bool CheckTargetCausesMultiVersioning(Sema &S, FunctionDecl *OldFD, const auto *OldTVA = OldFD->getAttr(); // If the old decl is NOT MultiVersioned yet, and we don't cause that // to change, this is a simple redeclaration. - if ((NewTA &

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Aaron Ballman via cfe-commits
@@ -1126,9 +1126,6 @@ class QualType { /// Return true if this is a trivially relocatable type. bool isTriviallyRelocatableType(const ASTContext &Context) const; - /// Return true if this is a trivially equality comparable type. - bool isTriviallyEqualityComparableType(c

[clang] [llvm] [AMDGPU] Enable atomic optimizer for 64 bit divergent values (PR #96473)

2024-06-27 Thread Vikram Hegde via cfe-commits
https://github.com/vikramRH closed https://github.com/llvm/llvm-project/pull/96473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Enable atomic optimizer for 64 bit divergent values (PR #96473)

2024-06-27 Thread Vikram Hegde via cfe-commits
vikramRH wrote: closing this in favour of https://github.com/llvm/llvm-project/pull/96933 and https://github.com/llvm/llvm-project/pull/96934 https://github.com/llvm/llvm-project/pull/96473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] 61975cd - [clang][Interp][NFC] Print global temporary value in Program::dump()

2024-06-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-27T19:24:35+02:00 New Revision: 61975cdf44a75917a738ca7fa9971b03f6d4fad8 URL: https://github.com/llvm/llvm-project/commit/61975cdf44a75917a738ca7fa9971b03f6d4fad8 DIFF: https://github.com/llvm/llvm-project/commit/61975cdf44a75917a738ca7fa9971b03f6d4fad8.diff LO

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

2024-06-27 Thread Andrzej Warzyński via cfe-commits
@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s banach-space wrote: Hm, ninja `check-mlir` worked for me just fine on Aarch64 🤔 I think that `mlir-translate` doesn't really care :) Put differently, `REQUIRES` is not neede

[clang] [clang] Fix incomplete umbrella warnings when building clang modules (NFC) (PR #96939)

2024-06-27 Thread Med Ismail Bennani via cfe-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/96939 This patch silences the incomplete-umbrella warnings when building clang modules, by adding the missing textual headers to the clang module map. >From 8de45df731f37ced94f7dfad3ff9ad0c86266163 Mon Sep 17 00:

[clang] [clang] Fix incomplete umbrella warnings when building clang modules (NFC) (PR #96939)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Med Ismail Bennani (medismailben) Changes This patch silences the incomplete-umbrella warnings when building clang modules, by adding the missing textual headers to the clang module map. --- Full diff: https://github.com/llvm/llvm-project

[clang] [clang][NVPTX] Define macro indicating the PTX version (PR #94934)

2024-06-27 Thread Victor Lomuller via cfe-commits
Naghasan wrote: Still I forgot to answer this point as well... > Are there ever point releases that might mea +ptx78 should actually expand to > 780 rather than 78? not sure what you exactly mean with your question. I guess we can mirror the cuda arch macro so, major * 100 + minor * 10, no op

[clang] [ParserHLSL] Attempt to parse HLSL annotations on Field Decls. (PR #96346)

2024-06-27 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/96346 >From c267be670adf7aac050484dc1b243aa0eff60b5f Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 21 Jun 2024 11:25:22 -0700 Subject: [PATCH 1/7] parse hlsl annotations on struct, add test --- clang/lib/

[clang] [llvm] [X86][CodeGen] security check cookie execute only when needed (PR #95904)

2024-06-27 Thread via cfe-commits
https://github.com/mahesh-attarde updated https://github.com/llvm/llvm-project/pull/95904 >From 6d6619f8f7a37906ac45791487a4d63b51a48ad1 Mon Sep 17 00:00:00 2001 From: mahesh-attarde Date: Wed, 12 Jun 2024 06:15:51 -0700 Subject: [PATCH 1/6] added regcall strct by reg support --- clang/lib/Co

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-27 Thread via cfe-commits
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T *D) { // If there is an error generating a USR for the decl, skip this decl. if (index::generateUSRForDecl(D, USR)) return true; + + // Prevent Visiting USR twice + { +std::lock_guard Guard(USRVisi

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-27 Thread via cfe-commits
@@ -56,7 +56,7 @@ class HTMLTag { operator bool() = delete; bool IsSelfClosing() const; - llvm::SmallString<16> ToString() const; + const char* toString() const; PeterChou1 wrote: I think it be more appropriate to rename it c_str https://github.com/llv

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-27 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/96921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-27 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/96809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ParserHLSL] Attempt to parse HLSL annotations on Field Decls. (PR #96346)

2024-06-27 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. https://github.com/llvm/llvm-project/pull/96346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][CodeGen] security check cookie execute only when needed (PR #95904)

2024-06-27 Thread via cfe-commits
@@ -114,250 +25,93 @@ return:; preds = %entry declare void @escape(ptr) define void @test_vla(i32 %n) nounwind ssp { -; MSVC-X86-LABEL: test_vla: -; MSVC-X86: # %bb.0: -; MSVC-X86-NEXT:pushl %ebp -; MSVC-X86-NEXT:movl %esp, %ebp -; MSVC-X86-NEXT:pushl %ea

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-27 Thread weiwei chen via cfe-commits
weiweichen wrote: > The only thing `AArch64TargetInfo::initFeatureMap` adds is features from the > selected CPU. IMHO this was not an appropriate place to be doing that. Since > #94279 the CPU features are added either by > `AArch64TargetInfo::parseTargetAttr` when dealing with > `__attribute

[clang] [clang] Allow class with anonymous union member to be const-default-constructible even if a union member has a default member initializer (#95854) (PR #96301)

2024-06-27 Thread via cfe-commits
@@ -1392,7 +1392,8 @@ class CXXRecordDecl : public RecordDecl { bool allowConstDefaultInit() const { return !data().HasUninitializedFields || !(data().HasDefaultedDefaultConstructor || - needsImplicitDefaultConstructor()); + needsImplici

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

2024-06-27 Thread Tobias Gysi via cfe-commits
@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s gysit wrote: Interesting! Did you build your LLVM with the x86 target enabled (besides Aarch64)? If not, `mlir-translate` may indeed be fine with the attribute independent o

[clang] [clang] deprecate alias, class templates without arg list after template kw (PR #94789)

2024-06-27 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/94789 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] deprecate alias, class templates without arg list after template kw (PR #94789)

2024-06-27 Thread Aaron Ballman via cfe-commits
@@ -891,6 +891,10 @@ def missing_template_arg_list_after_template_kw : Extension< "a template argument list is expected after a name prefixed by the template " "keyword">, InGroup>, DefaultError; +def warn_missing_template_arg_list_after_template_kw_deprecated : Warning

[clang] [clang] deprecate alias, class templates without arg list after template kw (PR #94789)

2024-06-27 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! The changes should also come with a release note in clang/docs/ReleaseNotes.rst https://github.com/llvm/llvm-project/pull/94789 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang] deprecate alias, class templates without arg list after template kw (PR #94789)

2024-06-27 Thread Aaron Ballman via cfe-commits
@@ -891,6 +891,10 @@ def missing_template_arg_list_after_template_kw : Extension< "a template argument list is expected after a name prefixed by the template " "keyword">, InGroup>, DefaultError; +def warn_missing_template_arg_list_after_template_kw_deprecated : Warning

[clang] [clang] deprecate alias, class templates without arg list after template kw (PR #94789)

2024-06-27 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Ideally, i think the warning would only happen by default in pedantic modes, > in C++23 and later (This was deprecated as part of P1787R6). It's a pretty > noisy warning for an harmless construct. It's not really a `-pedantic` diagnostic though because it's not an extensi

[clang] [llvm] [X86][CodeGen] security check cookie execute only when needed (PR #95904)

2024-06-27 Thread via cfe-commits
https://github.com/mahesh-attarde updated https://github.com/llvm/llvm-project/pull/95904 >From 6d6619f8f7a37906ac45791487a4d63b51a48ad1 Mon Sep 17 00:00:00 2001 From: mahesh-attarde Date: Wed, 12 Jun 2024 06:15:51 -0700 Subject: [PATCH 1/7] added regcall strct by reg support --- clang/lib/Co

[clang-tools-extra] [clang-tidy] Attempt to fix issue 96247 (PR #96856)

2024-06-27 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/96856 >From 2b0ccb7a78ea6d694b93ebc10677056d1bcd0340 Mon Sep 17 00:00:00 2001 From: cqwrteur <100043421+trcrsi...@users.noreply.github.com> Date: Thu, 27 Jun 2024 02:10:40 -0400 Subject: [PATCH] Attempt to fix issue 9

[clang] [CodeGen] Add a flag to disable emitting block signature strings (PR #96944)

2024-06-27 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/96944 Users who don't need the signature string to be emitted can use the flag to reduce code size. rdar://121933818 >From 5f71f113b27482114904eae8234c6ebc17eef5a4 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date

[clang] [CodeGen] Add a flag to disable emitting block signature strings (PR #96944)

2024-06-27 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/96944 >From d21bdaec94a169b27e7f7bace399e77bf99fd572 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 25 Jun 2024 19:37:46 -0700 Subject: [PATCH] [CodeGen] Add a flag to disable emitting block signature strin

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-27 Thread Tomas Matheson via cfe-commits
tmatheson-arm wrote: I think a test demonstrating the problem would be the fastest way forward. https://github.com/llvm/llvm-project/pull/96832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [clang] Fix incomplete umbrella warnings when building clang modules (NFC) (PR #96939)

2024-06-27 Thread Med Ismail Bennani via cfe-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/96939 >From 7d0a3e33840db80344075696726de1bf46a62861 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Thu, 27 Jun 2024 11:30:05 -0700 Subject: [PATCH] [clang] Fix incomplete umbrella warnings when building

[clang] [clang] Fix incomplete umbrella warnings when building clang modules (NFC) (PR #96939)

2024-06-27 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM, but I'd prefer to land the re-ordering in a separate commit. https://github.com/llvm/llvm-project/pull/96939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [llvm] [llvm][AArch64] Move Apple aliases into the CpuAlias map (PR #96249)

2024-06-27 Thread Jon Roelofs via cfe-commits
@@ -88,10 +88,14 @@ StringRef AArch64::getArchExtFeature(StringRef ArchExt) { void AArch64::fillValidCPUArchList(SmallVectorImpl &Values) { for (const auto &C : CpuInfos) - Values.push_back(C.Name); +Values.push_back(C.Name); for (const auto &Alias : CpuAliases

[clang] [llvm] [llvm][AArch64] Move Apple aliases into the CpuAlias map (PR #96249)

2024-06-27 Thread Jon Roelofs via cfe-commits
@@ -304,8 +304,21 @@ struct Alias { StringRef Name; }; -inline constexpr Alias CpuAliases[] = {{"cobalt-100", "neoverse-n2"}, - {"grace", "neoverse-v2"}}; +inline constexpr Alias CpuAliases[] = { +{"cobalt-100", "neoverse-n2"}, +

[clang] [llvm] [llvm][AArch64] Move Apple aliases into the CpuAlias map (PR #96249)

2024-06-27 Thread Jon Roelofs via cfe-commits
@@ -304,8 +304,21 @@ struct Alias { StringRef Name; }; -inline constexpr Alias CpuAliases[] = {{"cobalt-100", "neoverse-n2"}, - {"grace", "neoverse-v2"}}; +inline constexpr Alias CpuAliases[] = { jroelofs wrote: Since I

[clang] [llvm] [llvm][AArch64] Move Apple aliases into the CpuAlias map (PR #96249)

2024-06-27 Thread Jon Roelofs via cfe-commits
@@ -5,11 +5,11 @@ // RUN: not %clang_cc1 -triple arm64--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix AARCH64 // AARCH64: error: unknown target CPU 'not-a-cpu' -// AARCH64-NEXT: note: valid target CPU values are: generic, cortex-a35, cortex-a34,

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-27 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/96809 >From 7733243a7b9660ce2bcbd43f6219314fcd1e4a73 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Wed, 26 Jun 2024 14:20:03 -0400 Subject: [PATCH 1/4] [clang-doc] add short circuit in mapper --- clang-tools-ext

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-27 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/96809 >From 7733243a7b9660ce2bcbd43f6219314fcd1e4a73 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Wed, 26 Jun 2024 14:20:03 -0400 Subject: [PATCH 1/5] [clang-doc] add short circuit in mapper --- clang-tools-ext

[clang] [clang][CodeGen] Remove unnecessary ShouldLinkFiles conditional (PR #96951)

2024-06-27 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j created https://github.com/llvm/llvm-project/pull/96951 We have reworked the bitcode linking option to no longer link twice if post-optimization linking is requested. As such, we no longer need to conditionally link bitcodes supplied via -mlink-bitcode-file, as there

[clang] [clang][CodeGen] Remove unnecessary ShouldLinkFiles conditional (PR #96951)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Jacob Lambert (lamb-j) Changes We have reworked the bitcode linking option to no longer link twice if post-optimization linking is requested. As such, we no longer need to conditionally link bitcodes supplied via -mlink-bitcode-fi

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-27 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/96809 >From 7733243a7b9660ce2bcbd43f6219314fcd1e4a73 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Wed, 26 Jun 2024 14:20:03 -0400 Subject: [PATCH 1/6] [clang-doc] add short circuit in mapper --- clang-tools-ext

[clang] [C23] Add INFINITY and NAN macros to (PR #96659)

2024-06-27 Thread Joshua Cranmer via cfe-commits
jcranmer-intel wrote: Some thoughts of my own: The decision being discussed here has two main repercussions: * An attempt to use `INFINITY` gets a symbol-not-found error message, or it gets whatever warning/error message we attach to `__builtin_inf()` in `-ffinite-math-only` mode. * Code that

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-27 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/96809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Add a flag to disable emitting block signature strings (PR #96944)

2024-06-27 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak ready_for_review https://github.com/llvm/llvm-project/pull/96944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Add a flag to disable emitting block signature strings (PR #96944)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang-driver Author: Akira Hatanaka (ahatanak) Changes Users who don't need the signature string to be emitted can use the flag to reduce code size. rdar://121933818 --- Full diff: https://github.com/llvm/llvm-projec

[clang] [clang-format] Allow ternary in all templates (PR #96801)

2024-06-27 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: > I'm not even sure if this change is a good idea! I think it's very likely it > will lead to regressions, for we don't have tests for such cases yet, it seems I'm sure you will look after them, so I'd say let them come. ;) https://github.com/llvm/llvm-project/pull/96

[clang] [CodeGen] Add a flag to disable emitting block signature strings (PR #96944)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Akira Hatanaka (ahatanak) Changes Users who don't need the signature string to be emitted can use the flag to reduce code size. rdar://121933818 --- Full diff: https://github.com/llvm/llvm-project/pull/96944.diff 7 Files Affected: - (

[clang] [clang-format] Allow ternary in all templates (PR #96801)

2024-06-27 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/96801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Remove unnecessary ShouldLinkFiles conditional (PR #96951)

2024-06-27 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. https://github.com/llvm/llvm-project/pull/96951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Nikolas Klauser via cfe-commits
@@ -1126,9 +1126,6 @@ class QualType { /// Return true if this is a trivially relocatable type. bool isTriviallyRelocatableType(const ASTContext &Context) const; - /// Return true if this is a trivially equality comparable type. - bool isTriviallyEqualityComparableType(c

[clang] [clang-format] Introduce "ReflowComments: IndentOnly" to re-indent comments without breaking internal structure (think Doxygen). (PR #96804)

2024-06-27 Thread Björn Schäpers via cfe-commits
@@ -3749,24 +3749,47 @@ struct FormatStyle { /// \version 13 ReferenceAlignmentStyle ReferenceAlignment; - // clang-format off - /// If ``true``, clang-format will attempt to re-flow comments. That is it - /// will touch a comment and *reflow* long comments into new lin

[clang] [clang-format] Introduce "ReflowComments: IndentOnly" to re-indent comments without breaking internal structure (think Doxygen). (PR #96804)

2024-06-27 Thread Björn Schäpers via cfe-commits
@@ -493,9 +493,25 @@ TEST_F(FormatTestComments, AlignsBlockComments) { TEST_F(FormatTestComments, CommentReflowingCanBeTurnedOff) { FormatStyle Style = getLLVMStyleWithColumns(20); - Style.ReflowComments = false; - verifyFormat("// a aa aa", Style);

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

2024-06-27 Thread Alexis Perry-Holby via cfe-commits
@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s AlexisPerry wrote: I ran into failures if I didn't include the guard. I have separate builds for x86 and Aarch64. https://github.com/llvm/llvm-project/pull/96688 __

[clang] 868b90d - [clang] Fix incomplete umbrella warnings when building clang modules (NFC) (#96939)

2024-06-27 Thread via cfe-commits
Author: Med Ismail Bennani Date: 2024-06-27T12:23:58-07:00 New Revision: 868b90df07e08617a9be33178ac33437aaa00942 URL: https://github.com/llvm/llvm-project/commit/868b90df07e08617a9be33178ac33437aaa00942 DIFF: https://github.com/llvm/llvm-project/commit/868b90df07e08617a9be33178ac33437aaa00942.

[clang] [clang] Fix incomplete umbrella warnings when building clang modules (NFC) (PR #96939)

2024-06-27 Thread Med Ismail Bennani via cfe-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/96939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Add INFINITY and NAN macros to (PR #96659)

2024-06-27 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > In short: IMHO, `INFINITY` should expand to something that bops the user > (i.e., warn/error by default) and says "you're doing something wrong" in > finite-math-only mode. @jcranmer-intel and I had a really nice offline discussion on this topic and I've come around to h

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Carlos Galvez via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang] [clang][CodeGen] Remove unnecessary ShouldLinkFiles conditional (PR #96951)

2024-06-27 Thread via cfe-commits
b-sumner wrote: No objection here. https://github.com/llvm/llvm-project/pull/96951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Aaron Ballman via cfe-commits
@@ -1126,9 +1126,6 @@ class QualType { /// Return true if this is a trivially relocatable type. bool isTriviallyRelocatableType(const ASTContext &Context) const; - /// Return true if this is a trivially equality comparable type. - bool isTriviallyEqualityComparableType(c

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/93113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >