https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/95901
>From 8f6ff99ddb035d63e99910f873a8d9938bd0b3e4 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Mon, 17 Jun 2024 15:33:34 +
Subject: [PATCH 1/2] [clang][transformer] Introduce a `constructExprArgs`
https://github.com/rnk approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/96487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-flang-driver
@llvm/pr-subscribers-clang-driver
Author: Lucas Duarte Prates (pratlucas)
Changes
Reverts llvm/llvm-project#95805 due to test failures caught by the
buildbots.
---
Patch is 159.79 KiB, truncated to 20.00 KiB bel
https://github.com/pratlucas closed
https://github.com/llvm/llvm-project/pull/96768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -158,23 +158,85 @@ void test_ds_faddf(local float *out, float src) {
}
// CHECK-LABEL: @test_ds_fmin
-// CHECK: {{.*}}call{{.*}} float @llvm.amdgcn.ds.fmin.f32(ptr addrspace(3)
%out, float %src, i32 0, i32 0, i1 false)
+// CHECK: atomicrmw fmin ptr addrspace(3) %out, float
@@ -3636,6 +3648,22 @@ def Fmin : FPMathTemplate, LibBuiltin<"math.h"> {
let OnlyBuiltinPrefixedAliasIsConstexpr = 1;
}
+def FmaximumNum : FPMathTemplate, LibBuiltin<"math.h"> {
wzssyqa wrote:
Yes. They are in C23: https://libc.llvm.org/c23.html
https://gi
https://github.com/Xazax-hun edited
https://github.com/llvm/llvm-project/pull/96758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/96758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,1258 @@
+//===--- CheckExprLifetime.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,1258 @@
+//===--- CheckExprLifetime.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
Author: Timm Bäder
Date: 2024-06-26T16:12:13+02:00
New Revision: dead8f845f2549db5dec16b59b80d3e321948674
URL:
https://github.com/llvm/llvm-project/commit/dead8f845f2549db5dec16b59b80d3e321948674
DIFF:
https://github.com/llvm/llvm-project/commit/dead8f845f2549db5dec16b59b80d3e321948674.diff
LO
https://github.com/sstwcw created
https://github.com/llvm/llvm-project/pull/96770
The new option is `KeepEmptyLines`.
This patch was initially part of 9267f8f19a2e502e. I neglected to check the
server builds before I added it. It broke clangd. Jie Fu fixed the problem in
4c91b49bab0728d4.
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: None (sstwcw)
Changes
The new option is `KeepEmptyLines`.
This patch was initially part of 9267f8f19a2e502e. I neglected to check the
server builds before I added it. It broke clangd. Jie Fu fixed the problem in
4c91b49bab
earnol wrote:
> Indeed, Clang doesn't provide int128_t for 32 bit targets, AFAIK.
It looks like a little bit more complex.
I checked with Standalone-i386 and AddressSanitizer-i386 targets. They do have
int128_t for 32 bit targets as soon as clang itself built as 64-bit binary.
> > Could you pl
dougsonos wrote:
> So it sounds like the act of adding an additional trailing object will slow
> down the performance regardless of whether we use the new trailing object?
I was confused by some comments on `FunctionProtoType` which have diverged from
the source, and thought that it was necess
jroelofs wrote:
Looks like the new tests in `Driver` are missing `// REQUIRES:
aarch64-registered-target`
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
Author: Congcong Cai
Date: 2024-06-26T22:30:15+08:00
New Revision: 019f525716348578802b02961c328b43f7cad0fb
URL:
https://github.com/llvm/llvm-project/commit/019f525716348578802b02961c328b43f7cad0fb
DIFF:
https://github.com/llvm/llvm-project/commit/019f525716348578802b02961c328b43f7cad0fb.diff
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/96203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,77 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -emit-llvm -o - %s | FileCheck
%s
+
+extern void varargs_simple(int, ...);
+
+// CHECK-LABEL: define dso_local vo
@@ -25,3 +25,16 @@ Example:
}
// already declared as extern
extern int v2;
+
+Options
+---
+
+.. option:: FixMode
PiotrZSL wrote:
should say what is default value
https://github.com/llvm/llvm-project/pull/96203
__
@@ -0,0 +1,77 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -emit-llvm -o - %s | FileCheck
%s
+
+extern void varargs_simple(int, ...);
+
+// CHECK-LABEL: define dso_local vo
@@ -0,0 +1,1258 @@
+//===--- CheckExprLifetime.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
https://github.com/ilya-biryukov approved this pull request.
LGTM, this opens up the possibility to extend this for assignments and provides
better modularity!
https://github.com/llvm/llvm-project/pull/96758
___
cfe-commits mailing list
cfe-commits@li
https://github.com/alexfh approved this pull request.
LGTM
Thank you!
https://github.com/llvm/llvm-project/pull/96699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pratlucas wrote:
> Looks like the new tests in `Driver` are missing `// REQUIRES:
> aarch64-registered-target`
Yes, I'm adding those now. There was also an odd ThreadSanitizer failure in
clangd (https://lab.llvm.org/buildbot/#/builders/134/builds/680), which I'm
investigating to check if is i
@@ -284,3 +284,48 @@ Example Usage
Base* basePtr = &obj;
basePtr->virtualFunction(); // Allowed since obj is constructed in
device code
}
+
+SPIR-V Support on HIPAMD ToolChain
+==
+
+The HIPAMD ToolChain supports targetting
+`AMDG
https://github.com/llvm-beanz approved this pull request.
HLSL changes look good to me.
https://github.com/llvm/llvm-project/pull/96641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyknight wrote:
> Really, the question is whether we plan to completely drop support for the
> x86_mmx type (including inline asm operands/results)
Yes, I do think it would be good to eliminate the type.
For inline-asm, we could switch to using a standard IR vector type for "y"
constraint ope
@@ -284,3 +284,48 @@ Example Usage
Base* basePtr = &obj;
basePtr->virtualFunction(); // Allowed since obj is constructed in
device code
}
+
+SPIR-V Support on HIPAMD ToolChain
+==
+
+The HIPAMD ToolChain supports targetting
+`AMDG
@@ -0,0 +1,77 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -emit-llvm -o - %s | FileCheck
%s
+
+extern void varargs_simple(int, ...);
+
+// CHECK-LABEL: define dso_local vo
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Congcong Cai (HerrCai0907)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/96779.diff
1 Files Affected:
- (modified)
clang-tools-extra/docs/clang-tidy/checks/misc/use-internal-linkage.rst (+1-1)
``diff
@@ -25,3 +25,16 @@ Example:
}
// already declared as extern
extern int v2;
+
+Options
+---
+
+.. option:: FixMode
HerrCai0907 wrote:
#96779
https://github.com/llvm/llvm-project/pull/96203
___
cfe-commits
dtcxzyw wrote:
Any thoughts? Hopefully I can catch up with the 19 release :)
https://github.com/llvm/llvm-project/pull/94352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NagyDonat wrote:
> These results look correct according to the checker, but I am not sure if
> such results are useful or really invalid:
> https://codechecker-demo.eastus.cloudapp.azure.com/Default/reports?run=vim_v8.2.1920_pointersub1&is-unique=on&diff-type=New&checker-name=alpha.core.Pointer
DavidSpickett wrote:
I very much doubt it is, your change is still in the next build
(https://lab.llvm.org/buildbot/#/builders/134/builds/681) and that's green.
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
cfe-commits@l
@@ -296,6 +300,47 @@ void BareMetal::AddClangCXXStdlibIncludeArgs(const ArgList
&DriverArgs,
return;
const Driver &D = getDriver();
+ std::string Target = getTripleString();
+
+ auto AddCXXIncludePath = [&](StringRef Path) {
+std::string Version = detectLibcxxVers
@@ -296,6 +300,47 @@ void BareMetal::AddClangCXXStdlibIncludeArgs(const ArgList
&DriverArgs,
return;
const Driver &D = getDriver();
+ std::string Target = getTripleString();
+
+ auto AddCXXIncludePath = [&](StringRef Path) {
+std::string Version = detectLibcxxVers
@@ -296,6 +300,47 @@ void BareMetal::AddClangCXXStdlibIncludeArgs(const ArgList
&DriverArgs,
return;
const Driver &D = getDriver();
+ std::string Target = getTripleString();
+
+ auto AddCXXIncludePath = [&](StringRef Path) {
nickdesaulniers wrote:
Is
@@ -296,6 +300,47 @@ void BareMetal::AddClangCXXStdlibIncludeArgs(const ArgList
&DriverArgs,
return;
const Driver &D = getDriver();
+ std::string Target = getTripleString();
+
+ auto AddCXXIncludePath = [&](StringRef Path) {
+std::string Version = detectLibcxxVers
@@ -296,6 +300,47 @@ void BareMetal::AddClangCXXStdlibIncludeArgs(const ArgList
&DriverArgs,
return;
const Driver &D = getDriver();
+ std::string Target = getTripleString();
+
+ auto AddCXXIncludePath = [&](StringRef Path) {
+std::string Version = detectLibcxxVers
@@ -0,0 +1,18 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -o - %s
-verify
+
+// expected-no-diagnostics
+
+struct MyBitFields {
+unsigned int field1 : 3; // 3 bits for field1
+unsigned int field2 : 4; // 4 bits for field2
+int field3 : 5;
@@ -0,0 +1,30 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -o - %s
-verify
+
+// previously, this test would result in an error shown below on the line that
+// declares variable a in struct Eg9:
+// error: use of undeclared identifier
+// 'SV_Dispat
https://github.com/DominikAdamski updated
https://github.com/llvm/llvm-project/pull/96742
>From 5b487aac3c8414b6f37f6888f361ca7488094048 Mon Sep 17 00:00:00 2001
From: Dominik Adamski
Date: Fri, 21 Jun 2024 18:03:53 +0200
Subject: [PATCH] [Flang-new][OpenMP] Add offload related flags for AMDGPU
balazske wrote:
The warning message may be still misleading if the LHS or RHS "arrays" are
non-array variables. Is it better to improve the messages in this case (or
detect if `offsetof` can be used and include it in the message)?
https://github.com/llvm/llvm-project/pull/96501
___
@@ -652,6 +652,134 @@ in the future. The expected roadmap for Reduced BMIs as
of Clang 19.x is:
comes, the term BMI will refer to the Reduced BMI and the Full BMI will only
be meaningful to build systems which elect to support two-phase compilation.
+Experimental No Tra
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as
of Clang 19.x is:
comes, the term BMI will refer to the Reduced BMI and the Full BMI will only
be meaningful to build systems which elect to support two-phase compilation.
+Experimental No Tra
@@ -652,6 +652,134 @@ in the future. The expected roadmap for Reduced BMIs as
of Clang 19.x is:
comes, the term BMI will refer to the Reduced BMI and the Full BMI will only
be meaningful to build systems which elect to support two-phase compilation.
+Experimental No Tra
@@ -229,6 +229,10 @@ C++20 Feature Support
will now work.
(#GH62925).
+- Clang refactored the BMI format to make it possible to support no transitive
changes
ilya-biryukov wrote:
> Good suggestions. Applied. (Just change should to can. Since I feel shoul
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/94352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5229,13 +5382,284 @@ static void emitTargetOutlinedFunction(
OMPBuilder.emitTargetRegionFunction(EntryInfo, GenerateOutlinedFunction,
true,
OutlinedFn, OutlinedFnID);
}
+OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::emitTargetTask(
ldionne wrote:
I'm sorry to be the bearer of bad news, but it looks like Android is failing
with this patch:
https://buildkite.com/llvm-project/libcxx-ci/builds/35981#01905269-56a0-4314-a350-0b99ece37e89
This is kinda weird, it fails due to the ABI list changing. I checked other
recent execut
@@ -1274,4 +1277,97 @@ COMPILER_RT_VISIBILITY int
__llvm_profile_set_file_object(FILE *File,
return 0;
}
+int __llvm_write_custom_profile(const char *Target,
+const __llvm_profile_data *DataBegin,
+const __llvm
@@ -296,6 +296,17 @@ int __llvm_profile_get_padding_sizes_for_counters(
*/
void __llvm_profile_set_dumped();
+/*!
+ * \brief Write custom target-specific profiling data to a seperate file.
+ * Used by libomptarget for GPU PGO.
jdoerfert wrote:
```suggestion
@@ -829,6 +829,25 @@ Error GenericDeviceTy::deinit(GenericPluginTy &Plugin) {
DeviceMemoryPoolTracking.AllocationMax);
}
+ for (auto *Image : LoadedImages) {
+GenericGlobalHandlerTy &Handler = Plugin.getGlobalHandler();
+if (!Handler.hasProfilingGlobals(*
@@ -829,6 +829,25 @@ Error GenericDeviceTy::deinit(GenericPluginTy &Plugin) {
DeviceMemoryPoolTracking.AllocationMax);
}
+ for (auto *Image : LoadedImages) {
+GenericGlobalHandlerTy &Handler = Plugin.getGlobalHandler();
+if (!Handler.hasProfilingGlobals(*
https://github.com/michaelmaitland updated
https://github.com/llvm/llvm-project/pull/96715
>From f6a4cf6b13442deac91c9ee49b7ba97617508c9d Mon Sep 17 00:00:00 2001
From: Michael Maitland
Date: Tue, 25 Jun 2024 16:35:25 -0700
Subject: [PATCH 1/3] [RISCV] Bump Pointer Masking extension version
--
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Lucas Duarte Prates (pratlucas)
Changes
This introduces the new `--print-enabled-extensions` command line option
to AArch64, which prints the list of extensions that are enabled for the
target specified by the combination of `--target`/`-ma
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Lucas Duarte Prates (pratlucas)
Changes
This introduces the new `--print-enabled-extensions` command line option
to AArch64, which prints the list of extensions that are enabled for the
target specified by the combination of `--targe
llvmbot wrote:
@llvm/pr-subscribers-mc
Author: Lucas Duarte Prates (pratlucas)
Changes
This introduces the new `--print-enabled-extensions` command line option
to AArch64, which prints the list of extensions that are enabled for the
target specified by the combination of `--target`/`-march
llvmbot wrote:
@llvm/pr-subscribers-flang-driver
Author: Lucas Duarte Prates (pratlucas)
Changes
This introduces the new `--print-enabled-extensions` command line option
to AArch64, which prints the list of extensions that are enabled for the
target specified by the combination of `--targe
pratlucas wrote:
Good catch. I also wasn't able to reproduce it locally.
I've created #96795 to re-land the changes with the updated tests.
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
https://github.com/jthackray commented:
LGTM so far. Just a couple of minor comments.
https://github.com/llvm/llvm-project/pull/96795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jthackray edited
https://github.com/llvm/llvm-project/pull/96795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -343,7 +350,9 @@ bool isX18ReservedByDefault(const Triple &TT);
// themselves, they are sequential (0, 1, 2, 3, ...).
uint64_t getCpuSupportsMask(ArrayRef FeatureStrs);
-void PrintSupportedExtensions(StringMap DescMap);
+void PrintSupportedExtensions();
+
+void printEnabled
@@ -9,28 +9,46 @@
//
//===--===//
-// A SubtargetFeature that can be toggled from the command line, and therefore
-// has an AEK_* entry in ArmExtKind.
+// A SubtargetFeature that represents one or more Archi
https://github.com/mjklemm created
https://github.com/llvm/llvm-project/pull/96799
This PR re-enables the command line option `-print-resources-dir` after PR
#96557 has reverted the changes made.
The way this works now, is that it simply prints the current resource dir,
which points to clang/
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Klemm (mjklemm)
Changes
This PR re-enables the command line option `-print-resources-dir` after PR
#96557 has reverted the changes made.
The way this works now, is that it simply prints the current resource dir,
which points to c
PBHDK wrote:
> The name sounds nice. Thanks.
> Please address the concerns here and in #90043 to always suggest `at` as
> well. An option to enable suggesting and providing a fix to use `at` (or
> `gsl::at`), like others have suggested, sounds like the best option.
Thank you for taking another
https://github.com/banach-space commented:
> fcuda-is-device flag is not used by Flang currently. In the future it will be
> needed for Flang equivalent functions:
> AMDGPUTargetCodeGenInfo::getGlobalVarAddressSpace
> AMDGPUTargetInfo::getTargetDefines .
I don't follow - why would anything re
https://github.com/banach-space edited
https://github.com/llvm/llvm-project/pull/96742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -333,6 +333,9 @@ void Flang::AddAMDGPUTargetArgs(const ArgList &Args,
StringRef Val = A->getValue();
CmdArgs.push_back(Args.MakeArgString("-mcode-object-version=" + Val));
}
+
+ const ToolChain &TC = getToolChain();
+ TC.addClangTargetOptions(Args, CmdArgs, Actio
rymdtian wrote:
> you have test failure
> https://buildkite.com/llvm-project/github-pull-requests/builds/73905#01902d01-7814-41af-b8e6-4d7d258fd4ec
> and
> https://buildkite.com/llvm-project/github-pull-requests/builds/73905#01902d01-7817-438a-b2cc-554580bfe611.
> Need to get it fixed before
https://github.com/yxsamliu approved this pull request.
https://github.com/llvm/llvm-project/pull/95957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rymiel created
https://github.com/llvm/llvm-project/pull/96801
Currently, question mark and colon tokens are not allowed between angle
brackets, as a template argument, if we are in an expression context.
However, expressions can still allowed in non-expression contexts, lea
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Emilia Kond (rymiel)
Changes
Currently, question mark and colon tokens are not allowed between angle
brackets, as a template argument, if we are in an expression context.
However, expressions can still allowed in non-expression con
rymiel wrote:
I'm not even sure if this change is a good idea! I think it's very likely it
will lead to regressions, for we don't have tests for such cases yet, it seems
https://github.com/llvm/llvm-project/pull/96801
___
cfe-commits mailing list
cfe-
cjappl wrote:
Bumped the branch to resolve the conflict in config-ix.cmake
https://github.com/llvm/llvm-project/pull/92460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jaidTw approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/96715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -184,6 +184,7 @@ Changes to the RISC-V Backend
* B (the collection of the Zba, Zbb, Zbs extensions) is supported.
* Added smcdeleg, ssccfg, smcsrind, and sscsrind extensions to -march.
* ``-mcpu=syntacore-scr3-rv32`` and ``-mcpu=syntacore-scr3-rv64`` were added.
+* Ssnpm, Sm
@@ -21,7 +21,7 @@
// RUN: %clang --target=aarch64 -march=armv8a+fp16fml -### -c %s 2>&1 |
FileCheck -check-prefix=GENERICV8A-FP16FML %s
jroelofs wrote:
needs a `// REQUIRES: aarch64-registered-target`. Ditto for all the rest of the
`aarch64-*` files being mo
@@ -315,37 +315,37 @@
// RUN: %clang -target aarch64 -mcpu=thunderx2t99 -### -c %s 2>&1 | FileCheck
-check-prefix=CHECK-MCPU-THUNDERX2T99 %s
// RUN: %clang -target aarch64 -mcpu=a64fx -### -c %s 2>&1 | FileCheck
-check-prefix=CHECK-MCPU-A64FX %s
// RUN: %clang -target aarch64
https://github.com/michaelmaitland updated
https://github.com/llvm/llvm-project/pull/96715
>From f6a4cf6b13442deac91c9ee49b7ba97617508c9d Mon Sep 17 00:00:00 2001
From: Michael Maitland
Date: Tue, 25 Jun 2024 16:35:25 -0700
Subject: [PATCH 1/4] [RISCV] Bump Pointer Masking extension version
--
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/96715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dwblaikie wrote:
Ah, I think this right solution to /this/ case is that the compiler should be
emitting the alignment for the structure?
Like there's no way for the debugger to know that this structure is
underaligned at the moment:
```
struct __attribute__((packed)) t1 {
int i;
};
```
Which
dwblaikie wrote:
oh, slight misquote above - `aligned(1)` is a no-op, as that attribute can't
reduce the alignment...
But I think my argument still stands, roughly as - if increases in alignment
are explicitly specified, decreases in alignment should be too.
https://github.com/llvm/llvm-proj
dwblaikie wrote:
The other effects of `packed` are encoded (the changes to the member offsets)
but that's not the only effect, and we shouldn't use that effect (which isn't
guaranteed to be observable - as in the case of "packed struct with a single
member/that just happens to not have padding
https://github.com/ichaer created
https://github.com/llvm/llvm-project/pull/96804
* Convert `ReflowComments` from boolean into a new `enum` which can take on the
value `RCS_Never`, `RCS_IndentOnly`, or `RCS_Always`. The first one is
equivalent to the old `false`, the third one is `true`, and t
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Iuri Chaer (ichaer)
Changes
* Convert `ReflowComments` from boolean into a new `enum` which can take on the
value `RCS_Never`, `RCS_IndentOnly`, or `RCS_Always`. The first one is
equivalent to the old `false`, the third one is `tru
@@ -185,10 +185,33 @@ llvm::MDNode *CodeGenTBAA::getTypeInfoHelper(const Type
*Ty) {
return getChar();
// Handle pointers and references.
- // TODO: Implement C++'s type "similarity" and consider dis-"similar"
- // pointers distinct.
- if (Ty->isPointerType() || Ty->
https://github.com/rjmccall commented:
Generally looking good.
https://github.com/llvm/llvm-project/pull/76612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rjmccall edited
https://github.com/llvm/llvm-project/pull/76612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -185,10 +185,33 @@ llvm::MDNode *CodeGenTBAA::getTypeInfoHelper(const Type
*Ty) {
return getChar();
// Handle pointers and references.
rjmccall wrote:
Probably worth putting standard citations here:
```suggestion
// Handle pointers and references.
dpalermo wrote:
This patch breaks the build of flang when quad math support is enabled
(https://github.com/llvm/llvm-project/pull/81971). Quad math support is off
by default (why no buildbot tripper over this), and can be enabled by setting
the following cmake variable:
-DFLANG_RUNTIME_F128
dwblaikie wrote:
Here's the smallest patch that would put explicit alignment on any packed
structure:
```
diff --git a/clang/lib/CodeGen/CGDebugInfo.cpp
b/clang/lib/CodeGen/CGDebugInfo.cpp
index a072475ba770..bbb13ddd593b 100644
--- a/clang/lib/CodeGen/CGDebugInfo.cpp
+++ b/clang/lib/CodeGen/CG
dwblaikie wrote:
Oh, this code was touched really recently in
66df6141659375e738d9b9b74bf79b2317576042 (@augusto2112 ) (see notes in previous
comments about how this code should be generalized)
https://github.com/llvm/llvm-project/pull/93809
___
cfe-
https://github.com/amykhuang updated
https://github.com/llvm/llvm-project/pull/96578
>From 1b436900146e1a91efac95416077485571722517 Mon Sep 17 00:00:00 2001
From: Amy Huang
Date: Mon, 24 Jun 2024 16:55:08 -0700
Subject: [PATCH 1/2] Add __hlt intrinsic for Windows ARM.
---
clang/include/clang/
https://github.com/amykhuang edited
https://github.com/llvm/llvm-project/pull/96578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PeterChou1 created
https://github.com/llvm/llvm-project/pull/96809
This patch adds a short circuit which address performance problem referenced in
issue: https://github.com/llvm/llvm-project/issues/96570
>From my local testing it cut the runtime of generating LLVM docs from
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: None (PeterChou1)
Changes
This patch adds a short circuit which address performance problem referenced in
issue: https://github.com/llvm/llvm-project/issues/96570
>From my local testing it cut the runtime of generating LLVM do
101 - 200 of 360 matches
Mail list logo
