[clang] [clang] AST Visitor: skip empty qualifiers in QualifiedTemplateName (PR #93926)

2024-05-31 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/93926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Introduce target-specific `Sema` components (PR #93179)

2024-05-31 Thread Nikita Popov via cfe-commits
nikic wrote: > I wonder if compile-time regressions come from new translation units I add, > because they definitely include stuff. Yes, I believe that is the primary contributor. You can see the per-file breakdown here: https://llvm-compile-time-tracker.com/compare_clang.php?from=59e2a6b08f3

[clang-tools-extra] [IncludeCleaner] display overview (PR #93932)

2024-05-31 Thread via cfe-commits
https://github.com/TheHillBright created https://github.com/llvm/llvm-project/pull/93932 Overview was written but not displayed. This fixes it. >From 4c97edfc73754bdcafeeecf09e8c60c6086393f5 Mon Sep 17 00:00:00 2001 From: TheHillBright <150074496+thehillbri...@users.noreply.github.com> Date: Fr

[clang-tools-extra] [IncludeCleaner] display overview (PR #93932)

2024-05-31 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [IncludeCleaner] display overview (PR #93932)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (TheHillBright) Changes Overview was written but not displayed. This fixes it. --- Full diff: https://github.com/llvm/llvm-project/pull/93932.diff 1 Files Affected: - (modified) clang-tools-extra/include-cleaner/tool/In

[clang] [llvm] AMDGPU: Add gfx12-generic target (PR #93875)

2024-05-31 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh approved this pull request. https://github.com/llvm/llvm-project/pull/93875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e1cc9e4 - [ConstantFold] Remove non-trivial gep-of-gep fold (#93823)

2024-05-31 Thread via cfe-commits
Author: Nikita Popov Date: 2024-05-31T09:25:38+02:00 New Revision: e1cc9e4eaddcc295b4e775512e33b947b1514c17 URL: https://github.com/llvm/llvm-project/commit/e1cc9e4eaddcc295b4e775512e33b947b1514c17 DIFF: https://github.com/llvm/llvm-project/commit/e1cc9e4eaddcc295b4e775512e33b947b1514c17.diff

[clang] [llvm] [ConstantFold] Remove non-trivial gep-of-gep fold (PR #93823)

2024-05-31 Thread Nikita Popov via cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/93823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] AST Visitor: skip empty qualifiers in QualifiedTemplateName (PR #93926)

2024-05-31 Thread Matheus Izvekov via cfe-commits
@@ -855,10 +855,14 @@ bool RecursiveASTVisitor::TraverseDeclarationNameInfo( template bool RecursiveASTVisitor::TraverseTemplateName(TemplateName Template) { - if (DependentTemplateName *DTN = Template.getAsDependentTemplateName()) + if (DependentTemplateName *DTN = Templ

[clang] be566d2 - [clang] AST Visitor: skip empty qualifiers in QualifiedTemplateName (#93926)

2024-05-31 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-05-31T04:31:31-03:00 New Revision: be566d2eacdaed972b90d2eeb1e66d732c9fe7c1 URL: https://github.com/llvm/llvm-project/commit/be566d2eacdaed972b90d2eeb1e66d732c9fe7c1 DIFF: https://github.com/llvm/llvm-project/commit/be566d2eacdaed972b90d2eeb1e66d732c9fe7c1.dif

[clang] [clang] AST Visitor: skip empty qualifiers in QualifiedTemplateName (PR #93926)

2024-05-31 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/93926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86]Add support for _outp{|w|d} (PR #93774)

2024-05-31 Thread Malay Sanghi via cfe-commits
https://github.com/MalaySanghi updated https://github.com/llvm/llvm-project/pull/93774 >From 17c3fc95c0753ec013b22ce0c539992b24b21055 Mon Sep 17 00:00:00 2001 From: Malay Sanghi Date: Wed, 29 May 2024 22:40:47 -0700 Subject: [PATCH 1/3] Add support for _outp{|w|d} --- clang/lib/Headers/intrin

[clang] [llvm] [AArch64] Support preserve_none calling convention (PR #91046)

2024-05-31 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss approved this pull request. Thanks for the PR, just NITS otherwise LGTM https://github.com/llvm/llvm-project/pull/91046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [llvm] [AArch64] Support preserve_none calling convention (PR #91046)

2024-05-31 Thread Daniel Kiss via cfe-commits
@@ -7949,9 +7966,10 @@ AArch64TargetLowering::LowerCall(CallLoweringInfo &CLI, ++NumTailCalls; } - if (!IsTailCall && CLI.CB && CLI.CB->isMustTailCall()) + if (!IsTailCall && CLI.CB && CLI.CB->isMustTailCall()) { DanielKristofKiss wrote: if with 1 s

[clang] [llvm] [AArch64] Support preserve_none calling convention (PR #91046)

2024-05-31 Thread Daniel Kiss via cfe-commits
@@ -494,6 +494,32 @@ def CC_AArch64_GHC : CallingConv<[ CCIfType<[i64], CCAssignToReg<[X19, X20, X21, X22, X23, X24, X25, X26, X27, X28]>> ]>; +let Entry = 1 in +def CC_AArch64_Preserve_None : CallingConv<[ +// We can pass arguments in all general registers, except: +

[clang] [llvm] [AArch64] Support preserve_none calling convention (PR #91046)

2024-05-31 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss edited https://github.com/llvm/llvm-project/pull/91046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Support preserve_none calling convention (PR #91046)

2024-05-31 Thread Daniel Kiss via cfe-commits
@@ -0,0 +1,92 @@ +; RUN: sed -e "s/RETTYPE/void/;s/RETVAL//" %s | llc -mtriple=aarch64-apple-darwin | FileCheck --check-prefixes=ALL %s +; RUN: sed -e "s/RETTYPE/i32/;s/RETVAL/undef/" %s | llc -mtriple=aarch64-apple-darwin | FileCheck --check-prefixes=ALL %s +; RUN: sed -e "s/RE

[clang] [clang][analyzer][NFC] Improve docs of alpha.unix.BlockInCriticalSection (PR #93812)

2024-05-31 Thread Endre Fülöp via cfe-commits
gamesh411 wrote: > What's the relationship between this PR and #93799 ? > > Otherwise, the change LGTM, but you might want to either unify these two NFC > changes into a single commit or ensure that they're independent. Thanks for checking this! To be honest, I started working on this, and the

[clang] [clang][analyzer][NFC] Add test for a limitation of alpha.unix.Bloc… (PR #93799)

2024-05-31 Thread Endre Fülöp via cfe-commits
gamesh411 wrote: > It's good to document this, the commit LGTM. Are you planning to fix this > soon? I have been looking into the [alpha.unix.PthreadLock](https://clang.llvm.org/docs/analyzer/checkers.html#alpha-unix-pthreadlock-c) checker. By reusing the logic there https://github.com/llvm/

[clang] [clang][analyzer][NFC] Improve docs of alpha.unix.BlockInCriticalSection (PR #93812)

2024-05-31 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/93812 From 54f117258b936b9448e2fb93dc2307e23629b85d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Tue, 28 May 2024 23:13:07 +0200 Subject: [PATCH] [clang][analyzer][NFC] Improve docs of al

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-31 Thread via cfe-commits
@@ -1329,6 +1341,100 @@ bool Preprocessor::LexAfterModuleImport(Token &Result) { return true; } +/// Lex a token following the 'module' contextual keyword. +/// +/// [cpp.module]/p2: +/// The pp-tokens, if any, of a pp-module shall be of the form: +/// pp-module-name p

[clang] [clang][analyzer][NFC] Improve docs of alpha.unix.BlockInCriticalSection (PR #93812)

2024-05-31 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 edited https://github.com/llvm/llvm-project/pull/93812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 51e459a - Revert "[ConstantFold] Remove non-trivial gep-of-gep fold (#93823)"

2024-05-31 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2024-05-31T10:37:32+02:00 New Revision: 51e459a561519c8d51e2b4cadddc0d1f99c8b7ef URL: https://github.com/llvm/llvm-project/commit/51e459a561519c8d51e2b4cadddc0d1f99c8b7ef DIFF: https://github.com/llvm/llvm-project/commit/51e459a561519c8d51e2b4cadddc0d1f99c8b7ef.diff

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-05-31 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/93815 From 895ff8779b11294f132604e40572ebec8b6bc4c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Wed, 29 May 2024 00:38:07 +0200 Subject: [PATCH 1/2] [clang][analyzer] Move unix.BlockInCri

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-05-31 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/89217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] remove goma support from clang (PR #93942)

2024-05-31 Thread Takuto Ikuta via cfe-commits
https://github.com/atetubou created https://github.com/llvm/llvm-project/pull/93942 goma is deprecated and not maintained anymore. https://chromium.googlesource.com/infra/goma/client/ >From eb50f67d29325ded7bf49834fb9fed0d588b5529 Mon Sep 17 00:00:00 2001 From: Takuto Ikuta Date: Fri, 31 May

[clang] remove goma support from clang (PR #93942)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Takuto Ikuta (atetubou) Changes goma is deprecated and not maintained anymore. https://chromium.googlesource.com/infra/goma/client/ --- Full diff: https://github.com/llvm/llvm-project/pull/93942.diff 2 Files Affected: - (modified) clan

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-05-31 Thread Jay Foad via cfe-commits
https://github.com/jayfoad edited https://github.com/llvm/llvm-project/pull/89217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-05-31 Thread Jay Foad via cfe-commits
@@ -5496,6 +5496,9 @@ const char* AMDGPUTargetLowering::getTargetNodeName(unsigned Opcode) const { NODE_NAME_CASE(LDS) NODE_NAME_CASE(FPTRUNC_ROUND_UPWARD) NODE_NAME_CASE(FPTRUNC_ROUND_DOWNWARD) + NODE_NAME_CASE(READLANE) + NODE_NAME_CASE(READFIRSTLANE) ---

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-05-31 Thread Jay Foad via cfe-commits
@@ -5496,6 +5496,9 @@ const char* AMDGPUTargetLowering::getTargetNodeName(unsigned Opcode) const { NODE_NAME_CASE(LDS) NODE_NAME_CASE(FPTRUNC_ROUND_UPWARD) NODE_NAME_CASE(FPTRUNC_ROUND_DOWNWARD) + NODE_NAME_CASE(READLANE) + NODE_NAME_CASE(READFIRSTLANE) + NODE_NAME_CA

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-05-31 Thread Jay Foad via cfe-commits
https://github.com/jayfoad commented: Does this need IR autoupgrade? https://github.com/llvm/llvm-project/pull/89217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove dangling conversion to `optional &` (PR #93385)

2024-05-31 Thread via cfe-commits
cor3ntin wrote: @davidstone you need me to merge that for you? https://github.com/llvm/llvm-project/pull/93385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang-format: Allow open brace with trailing comment (no line break) (PR #89956)

2024-05-31 Thread via cfe-commits
GertyP wrote: Ping ... and tweaking the title formatting to use square braces in case it's important: Can someone tell me if it makes a difference to have `[clang-format] ...` in title over `clang-format: ...`? I haven't seen anything saying so in any readme but I could have missed something

[clang] [clang-format] Allow open brace with trailing comment (no line break) (PR #89956)

2024-05-31 Thread via cfe-commits
https://github.com/GertyP edited https://github.com/llvm/llvm-project/pull/89956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer][NFC] Improve docs of alpha.unix.BlockInCriticalSection (PR #93812)

2024-05-31 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > My intention was to ease the review as much as possible by cutting them into > atomic parts. This is a good idea in general, but I feel that these two changes are so trivial, that they'd be very easy to review even together. Feel free to merge them both in whatever combinat

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-05-31 Thread Matt Arsenault via cfe-commits
arsenm wrote: > Does this need IR autoupgrade? This type of auto upgrade is free, it just happens https://github.com/llvm/llvm-project/pull/89217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #81545)

2024-05-31 Thread William Junda Huang via cfe-commits
huangjd wrote: How do I reopen the PR after fixing the test case? https://github.com/llvm/llvm-project/pull/81545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Option to ignore anonymous namespaces in avoid-non-const-global-variables (PR #93827)

2024-05-31 Thread Pascal Jungblut via cfe-commits
https://github.com/pascalj updated https://github.com/llvm/llvm-project/pull/93827 >From abe862b84fd6915edb281a21e49f1be2aac3a626 Mon Sep 17 00:00:00 2001 From: Pascal Jungblut Date: Thu, 30 May 2024 14:28:50 +0200 Subject: [PATCH] Add option to ignore anonymous namespaces in avoid-non-const-g

[clang] [clang][analyzer][NFC] Improve docs of alpha.unix.BlockInCriticalSection (PR #93812)

2024-05-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/93812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-05-31 Thread Mariya Podchishchaeva via cfe-commits
@@ -2012,26 +2015,27 @@ llvm::Value *CodeGenFunction::EmitLoadOfScalar(Address Addr, bool Volatile, } llvm::Value *CodeGenFunction::EmitToMemory(llvm::Value *Value, QualType Ty) { - // Bool has a different representation in memory than in registers. - if (hasBooleanRepresen

[clang-tools-extra] [clang-tidy] Option to ignore anonymous namespaces in avoid-non-const-global-variables (PR #93827)

2024-05-31 Thread Pascal Jungblut via cfe-commits
@@ -1,29 +1,39 @@ -// RUN: %check_clang_tidy %s cppcoreguidelines-avoid-non-const-global-variables %t +// RUN: %check_clang_tidy %s -check-suffix=DEFAULT cppcoreguidelines-avoid-non-const-global-variables %t +// RUN: %check_clang_tidy %s -check-suffix=NAMESPACE cppcoreguideline

[clang-tools-extra] [clang-tidy] Option to ignore anonymous namespaces in avoid-non-const-global-variables (PR #93827)

2024-05-31 Thread Pascal Jungblut via cfe-commits
pascalj wrote: Thanks for your feedback! > * what about "static" non const global variables Good point, forgot about these. If both are allowed, it is more about the internal linkage than it is about the namespace. I renamed the option to `AllowInternalLinkage` and permit variables in ano

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-05-31 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm commented: > 3. PowerPC: has some interaction with the behavior of `minnum/maxnum`: need > define `fcanonicalize`. AMDGPU has the same handling. This is to break the signaling nan handling from IEEE to the broken old glibc libm behavior. If we fix the definition to ma

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-05-31 Thread Matt Arsenault via cfe-commits
@@ -3636,6 +3648,22 @@ def Fmin : FPMathTemplate, LibBuiltin<"math.h"> { let OnlyBuiltinPrefixedAliasIsConstexpr = 1; } +def FmaximumNum : FPMathTemplate, LibBuiltin<"math.h"> { arsenm wrote: I'd prefer to split the clang changes into a separate change ht

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-05-31 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/93841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-05-31 Thread Matt Arsenault via cfe-commits
@@ -16049,6 +16094,84 @@ of the two arguments. -0.0 is considered to be less than +0.0 for this intrinsic. Note that these are the semantics specified in the draft of IEEE 754-2019. +.. _i_minimumnum: + +'``llvm.minimumnum.*``' Intrinsic +^ + +

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-05-31 Thread Matt Arsenault via cfe-commits
@@ -5005,8 +5007,11 @@ void computeKnownFPClass(const Value *V, const APInt &DemandedElts, // If either operand is not NaN, the result is not NaN. if (NeverNaN && (IID == Intrinsic::minnum || IID == Intrinsic::maxnum)) Known.knownNot(fcNan); + if (Neve

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-05-31 Thread Jay Foad via cfe-commits
jayfoad wrote: There is a latent problem to do with convergence. If you add a new test case like this: ```diff diff --git a/llvm/test/CodeGen/AMDGPU/convergence-tokens.ll b/llvm/test/CodeGen/AMDGPU/convergence-tokens.ll index 238f6ab39e83..22995083293d 100644 --- a/llvm/test/CodeGen/AMDGPU/conv

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-05-31 Thread Henry Linjamäki via cfe-commits
linehill wrote: Ping, @svenvh. The patch has been rebased, good for landing? https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-05-31 Thread Sven van Haastregt via cfe-commits
Henry =?utf-8?q?Linjamäki?= Message-ID: In-Reply-To: svenvh wrote: > Ping, @svenvh. The patch has been rebased, good for landing? Thanks for the ping, it seems github didn't send me a notification when you rebased. Just waiting for the final checks to complete, then I'll merge it. https://

[clang] [llvm] [WIP] Expand variadic functions in IR (PR #89007)

2024-05-31 Thread Matt Arsenault via cfe-commits
arsenm wrote: > I think the comments here are fed into #93362 successfully, will go through > the list again to check. So #93362 is the replacement, and not the sequential next piece? Can we close this one then? https://github.com/llvm/llvm-project/pull/89007

[clang] [Clang][Sema] Push an evaluation context for type constraints (PR #93945)

2024-05-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/93945 This helps getTemplateInstantiationArgs to properly recover template arguments of an enclosing concept Decl. Fixes https://github.com/llvm/llvm-project/issues/93821 >From 088c4199dd37172a57d965fe1b22f782084e127

[clang] [Clang][Sema] Push an evaluation context for type constraints (PR #93945)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes This helps getTemplateInstantiationArgs to properly recover template arguments of an enclosing concept Decl. Fixes https://github.com/llvm/llvm-project/issues/93821 --- Full diff: https://github.com/llvm/ll

[clang] a65771f - [SPIR-V] Prefer llvm-spirv- tool (#77897)

2024-05-31 Thread via cfe-commits
Author: Henry Linjamäki Date: 2024-05-31T12:21:21+02:00 New Revision: a65771fce4a2f25f16d4b3918ad6a11370637f7b URL: https://github.com/llvm/llvm-project/commit/a65771fce4a2f25f16d4b3918ad6a11370637f7b DIFF: https://github.com/llvm/llvm-project/commit/a65771fce4a2f25f16d4b3918ad6a11370637f7b.dif

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-05-31 Thread Sven van Haastregt via cfe-commits
Henry =?utf-8?q?Linjamäki?= Message-ID: In-Reply-To: https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-05-31 Thread Peter Waller via cfe-commits
peterwaller-arm wrote: > @peterwaller-arm I noticed that in > `llvm/test/CodeGen/AArch64/combine_andor_with_cmps.ll`, `FMAXNUM_IEEE` is > claimed that it is not supported. While I noticed that `fmaxnm` follows the > rules of `maxNUM` of IEEE754-2008. Is there any other limitation of `fmaxnm`?

[clang] 196dca7 - [clang][analyzer][NFC] Improve docs of alpha.unix.BlockInCriticalSection (#93812)

2024-05-31 Thread via cfe-commits
Author: Endre Fülöp Date: 2024-05-31T12:50:04+02:00 New Revision: 196dca7561b4c3865ef7d5e45c22d215619d7385 URL: https://github.com/llvm/llvm-project/commit/196dca7561b4c3865ef7d5e45c22d215619d7385 DIFF: https://github.com/llvm/llvm-project/commit/196dca7561b4c3865ef7d5e45c22d215619d7385.diff L

[clang] [clang][analyzer][NFC] Improve docs of alpha.unix.BlockInCriticalSection (PR #93812)

2024-05-31 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 closed https://github.com/llvm/llvm-project/pull/93812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] `used` globals && the payloads for global ctors & dtors are globals (PR #93601)

2024-05-31 Thread Matt Arsenault via cfe-commits
@@ -2928,12 +2928,13 @@ static void emitUsed(CodeGenModule &CGM, StringRef Name, for (unsigned i = 0, e = List.size(); i != e; ++i) { UsedArray[i] = llvm::ConstantExpr::getPointerBitCastOrAddrSpaceCast( -cast(&*List[i]), CGM.Int8PtrTy); ---

[clang] 46b3145 - [clang][analyzer][NFC] Add test for a limitation of alpha.unix.BlockInCriticalSection checker (#93799)

2024-05-31 Thread via cfe-commits
Author: Endre Fülöp Date: 2024-05-31T12:51:14+02:00 New Revision: 46b3145b7c6bbe7014f9e790236717e4f8a711d8 URL: https://github.com/llvm/llvm-project/commit/46b3145b7c6bbe7014f9e790236717e4f8a711d8 DIFF: https://github.com/llvm/llvm-project/commit/46b3145b7c6bbe7014f9e790236717e4f8a711d8.diff L

[clang] [clang][analyzer][NFC] Add test for a limitation of alpha.unix.Bloc… (PR #93799)

2024-05-31 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 closed https://github.com/llvm/llvm-project/pull/93799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] remove goma support from clang (PR #93942)

2024-05-31 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/93942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][CodeGen] Global constructors/destructors are globals (PR #93914)

2024-05-31 Thread Matt Arsenault via cfe-commits
arsenm wrote: > The third argument here is like for llvm.used, it's a way to associate the > entry with a global or function. If the corresponding global or function is > omitted from the output then the entry will be removed. It isn't used for > anything at run time. So I think there should b

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-05-31 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 edited https://github.com/llvm/llvm-project/pull/93815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-05-31 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 ready_for_review https://github.com/llvm/llvm-project/pull/93815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-05-31 Thread via cfe-commits
Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Endre Fülöp (gamesh411) Changes After recent improvements, and testing on open source projects, the checker is ready to move out of the alpha p

[clang] [clang] ``README.txt``: Replace the link to the old bug tracker with the new one. (PR #93878)

2024-05-31 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! Do you need someone to land this on your behalf? https://github.com/llvm/llvm-project/pull/93878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [Clang][Sema] Push an evaluation context for type constraints (PR #93945)

2024-05-31 Thread via cfe-commits
@@ -5004,6 +5004,20 @@ static bool CheckDeducedPlaceholderConstraints(Sema &S, const AutoType &Type, return true; MultiLevelTemplateArgumentList MLTAL(Concept, CanonicalConverted, /*Final=*/false); + // Build up an EvaluationContex

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-05-31 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 edited https://github.com/llvm/llvm-project/pull/93815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Zabha (PR #93831)

2024-05-31 Thread via cfe-commits
AlexGhiti wrote: Damn, I missed it, good catch, thanks. https://github.com/llvm/llvm-project/pull/93831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Zabha (PR #93831)

2024-05-31 Thread via cfe-commits
https://github.com/AlexGhiti updated https://github.com/llvm/llvm-project/pull/93831 >From 64a56e792ce57cd807aebd7113a1180275f3547e Mon Sep 17 00:00:00 2001 From: Alexandre Ghiti Date: Thu, 30 May 2024 14:39:20 + Subject: [PATCH] [RISCV] Remove experimental from Zabha The Zabha extension w

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-31 Thread Aaron Ballman via cfe-commits
@@ -1329,6 +1341,100 @@ bool Preprocessor::LexAfterModuleImport(Token &Result) { return true; } +/// Lex a token following the 'module' contextual keyword. +/// +/// [cpp.module]/p2: +/// The pp-tokens, if any, of a pp-module shall be of the form: +/// pp-module-name p

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #81545)

2024-05-31 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > How do I reopen the PR after fixing the test case? AIUI, you cannot reopen a merged PR, you have to start a new PR and mention the old one to link the two together. https://github.com/llvm/llvm-project/pull/81545 ___ cfe-commits

[clang] [llvm] [AMDGPU] Implement variadic functions by IR lowering (PR #93362)

2024-05-31 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,1023 @@ +//===-- ExpandVariadicsPass.cpp *- C++ -*-=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[clang] [llvm] [AMDGPU] Implement variadic functions by IR lowering (PR #93362)

2024-05-31 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,1023 @@ +//===-- ExpandVariadicsPass.cpp *- C++ -*-=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[clang] [Clang][Sema] Push an evaluation context for type constraints (PR #93945)

2024-05-31 Thread Younan Zhang via cfe-commits
@@ -5004,6 +5004,20 @@ static bool CheckDeducedPlaceholderConstraints(Sema &S, const AutoType &Type, return true; MultiLevelTemplateArgumentList MLTAL(Concept, CanonicalConverted, /*Final=*/false); + // Build up an EvaluationContex

[clang] [llvm] Conditionalize use of POSIX features missing on WASI/WebAssembly (PR #92677)

2024-05-31 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Ah thank you for pointing that out, I had missed some updates on that thread. I think `defined(__wasi__)` would address my concerns. @MaskRay asked a good question about whether we should tie this to `LLVM_ON_UNIX` as well and I don't have a strong intuition there, but my n

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-05-31 Thread Henry Linjamäki via cfe-commits
linehill wrote: Thanks, @svenvh. https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] require template arg list after template kw (PR #80801)

2024-05-31 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/80801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] require template arg list after template kw (PR #80801)

2024-05-31 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. I think the changes are reasonable, but I'd like to wait a bit before landing to give @erichkeane a chance to review as templates code owner. https://github.com/llvm/llvm-project/pull/80801 _

[clang] [clang] require template arg list after template kw (PR #80801)

2024-05-31 Thread Aaron Ballman via cfe-commits
@@ -2995,13 +2996,23 @@ bool Parser::ParseUnqualifiedId(CXXScopeSpec &SS, ParsedType ObjectType, SS, ObjectType, ObjectHadErrors, TemplateKWLoc ? *TemplateKWLoc : SourceLocation(), Id, IdLoc, EnteringContext, Result, TemplateSpecified); -else

[clang] [llvm] Conditionalize use of POSIX features missing on WASI/WebAssembly (PR #92677)

2024-05-31 Thread via cfe-commits
whitequark wrote: > but my naive thinking is that it would help in some cases but be insufficient > in others (e.g., within Support/Unix/Path.inc, we'd still need to have a > conditional for WASI). `LLVM_ON_UNIX` is definitely a mixed bag for WASI and I'll take another look at whether it shou

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-05-31 Thread Mariya Podchishchaeva via cfe-commits
@@ -761,6 +761,10 @@ bool ConstStructBuilder::Build(const InitListExpr *ILE, bool AllowOverwrite) { if (Field->hasAttr()) AllowOverwrite = true; } else { + llvm::Type *LoadType = CGM.getTypes().convertTypeForLoadStore( Fznamznon wrote:

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-05-31 Thread Mariya Podchishchaeva via cfe-commits
@@ -1774,6 +1784,22 @@ llvm::Constant *ConstantEmitter::emitForMemory(CodeGenModule &CGM, return Res; } + if (destType->isBitIntType()) { +if (!CGM.getTypes().LLVMTypeLayoutMatchesAST(destType, C->getType())) { + // Long _BitInt has array of bytes as in-memory

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-05-31 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/91364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-05-31 Thread via cfe-commits
https://github.com/YanWQ-monad created https://github.com/llvm/llvm-project/pull/93952 Specification link: https://github.com/riscvarchive/riscv-indirect-csr-access The CSRs in Smcsrind/Sscsrind extensions are originally defined as part of the Smaia/Ssaia extensions, which are already support

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-05-31 Thread Mariya Podchishchaeva via cfe-commits
@@ -2567,16 +2567,16 @@ int main() { // CHECK3-NEXT:[[I:%.*]] = alloca i32, align 4 // CHECK3-NEXT:[[DOTCAPTURE_EXPR__CASTED:%.*]] = alloca i64, align 8 // CHECK3-NEXT:[[DOTBOUND_ZERO_ADDR:%.*]] = alloca i32, align 4 -// CHECK3-NEXT:[[DOTCAPTURE_EXPR__CASTED12:%

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Monad (YanWQ-monad) Changes Specification link: https://github.com/riscvarchive/riscv-indirect-csr-access The CSRs in Smcsrind/Sscsrind extensions are originally defined as part of the Smaia/Ssaia extensions, which are already s

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Monad (YanWQ-monad) Changes Specification link: https://github.com/riscvarchive/riscv-indirect-csr-access The CSRs in Smcsrind/Sscsrind extensions are originally defined as part of the Smaia/Ssaia extensions, which are already supported

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-05-31 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw commented: Can you also update `llvm/docs/ReleaseNotes.rst` ? https://github.com/llvm/llvm-project/pull/93952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-05-31 Thread via cfe-commits
https://github.com/YanWQ-monad updated https://github.com/llvm/llvm-project/pull/93952 >From 3e0d38aa84506cd364174190893cb62008948a87 Mon Sep 17 00:00:00 2001 From: YanWQ-monad Date: Fri, 31 May 2024 16:11:43 +0800 Subject: [PATCH 1/2] [RISCV] add smcsrind and sscsrind extension --- .../test/

[clang] [llvm] [clang][CodeGen] Global constructors/destructors are globals (PR #93914)

2024-05-31 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > llvm datalayout defines > > P - program addr space for functions G - global addr space for global > variables > > https://llvm.org/docs/LangRef.html#langref-datalayout > > should we use P for llvm.global_ctors instead of G? > llvm datalayout defines > > P - program addr s

[clang] [CodeGen] Simplify codegen for array initialization (PR #93956)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines Author: Nikita Popov (nikic) Changes This makes codegen for array initialization simpler in two ways: 1. Drop the zero-index GEP at the start, which is no longer needed with opaque pointers. 2. Emit GEPs directly to the correct element, inste

[clang] [CodeGen] Simplify codegen for array initialization (PR #93956)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nikita Popov (nikic) Changes This makes codegen for array initialization simpler in two ways: 1. Drop the zero-index GEP at the start, which is no longer needed with opaque pointers. 2. Emit GEPs directly to the correct element, instead of

[clang] [CodeGen] Simplify codegen for array initialization (PR #93956)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Nikita Popov (nikic) Changes This makes codegen for array initialization simpler in two ways: 1. Drop the zero-index GEP at the start, which is no longer needed with opaque pointers. 2. Emit GEPs directly to the correct element, in

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread via cfe-commits
https://github.com/earnol ready_for_review https://github.com/llvm/llvm-project/pull/93612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)

2024-05-31 Thread via cfe-commits
zmodem wrote: I looked at this some more. Here's a slightly reduced version of your test case: ``` template void foo(); template void f() { foo(); } void g() { f(); } template <> void __declspec(dllexport) foo() {} ``` What happens (when building with `-fno-delayed-template-parsing`) is s

[clang] [clang] Catch missing format attributes (PR #70024)

2024-05-31 Thread Budimir Aranđelović via cfe-commits
budimirarandjelovicsyrmia wrote: Ping @AaronBallman @aaronpuchert Any comment? (except Resolve conflicts) https://github.com/llvm/llvm-project/pull/70024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [llvm] [clang][CodeGen] Global constructors/destructors are globals (PR #93914)

2024-05-31 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > The third argument here is like for llvm.used, it's a way to associate the > entry with a global or function. If the corresponding global or function is > omitted from the output then the entry will be removed. It isn't used for > anything at run time. So I think there should

[clang] [CUDA] Fix a couple of driver tests that really weren't being run (PR #93960)

2024-05-31 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 created https://github.com/llvm/llvm-project/pull/93960 None >From efbbb7b729ba4a24413f3d2a1769effba3581d8f Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Fri, 31 May 2024 06:11:30 -0700 Subject: [PATCH] [CUDA] Fix a couple of driver tests that really weren't bein

  1   2   3   4   5   >