[clang] [Clang] Fix Null Pointer Dereference in Sema::BuildClassMessageImplicit() (PR #90482)

2024-04-30 Thread via cfe-commits
smanna12 wrote: > I believe the static analyzer is reporting a false positive in this case. I > don't think this change is correct. `BuildClassMessage()` only dereferences > `receiverTypeInfo` if the provided source location is not valid. The existing > `assert` already validates this case. Th

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-04-30 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,799 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang] [clang] Fix crash when destructor definition is preceded with '=' (PR #90220)

2024-04-30 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/90220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-04-30 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,799 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-04-30 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,799 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-04-30 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,799 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-04-30 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,799 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-04-30 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,799 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-04-30 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,799 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-04-30 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,799 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang] 7662f95 - [WebAssembly] Add preprocessor define for half-precision (#90528)

2024-04-30 Thread via cfe-commits
Author: Heejin Ahn Date: 2024-04-30T11:15:53-07:00 New Revision: 7662f95f2c767ae3c9b22eb4bdedb07ffcf258b7 URL: https://github.com/llvm/llvm-project/commit/7662f95f2c767ae3c9b22eb4bdedb07ffcf258b7 DIFF: https://github.com/llvm/llvm-project/commit/7662f95f2c767ae3c9b22eb4bdedb07ffcf258b7.diff LO

[clang] [WebAssembly] Add preprocessor define for half-precision (PR #90528)

2024-04-30 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin closed https://github.com/llvm/llvm-project/pull/90528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement CWG2851: floating-point conversions in converted constant expressions (PR #90387)

2024-04-30 Thread Shafik Yaghmour via cfe-commits
@@ -67,6 +68,69 @@ void B::g() requires true; } // namespace cwg2847 +namespace cwg2851 { // cwg2851: 19 + +#if __cplusplus >= 202002L +template struct Val { static constexpr T value = v; }; + + +// Floating-point promotions + +static_assert(Val::value == 0.0L); +static_asser

[clang] f061a39 - [Clang][Sema][Parse] Delay parsing of noexcept-specifiers in friend function declarations (#90517)

2024-04-30 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-04-30T14:23:02-04:00 New Revision: f061a395ffb78215a23e0f503e8ea121ee3b13ad URL: https://github.com/llvm/llvm-project/commit/f061a395ffb78215a23e0f503e8ea121ee3b13ad DIFF: https://github.com/llvm/llvm-project/commit/f061a395ffb78215a23e0f503e8ea121ee3b13ad

[clang] [Clang][Sema][Parse] Delay parsing of noexcept-specifiers in friend function declarations (PR #90517)

2024-04-30 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/90517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-04-30 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/90152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 8009bbe - Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependen

2024-04-30 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-04-30T14:25:09-04:00 New Revision: 8009bbec59d1c5d47ae06c431647ebee6d886ff2 URL: https://github.com/llvm/llvm-project/commit/8009bbec59d1c5d47ae06c431647ebee6d886ff2 DIFF: https://github.com/llvm/llvm-project/commit/8009bbec59d1c5d47ae06c431647ebee6d886ff2

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

2024-04-30 Thread Ben Langmuir via cfe-commits
@@ -0,0 +1,34 @@ +// UNSUPPORTED: system-windows +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: cd %t +// +// RUN: cp a1.h a.h +// RUN: %clang -fmodules -fmodules-validate-input-files-content -Xclang -fno-pch-timestamp -fimplicit-modules -fmodule-map-file=module.modulemap

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-04-30 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: I built boost with `-DBUILD_TESTING=ON` and didn't see any regressions... hopefully that remains the case https://github.com/llvm/llvm-project/pull/90152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] fa67986 - [OpenACC] Private Clause on Compute Constructs (#90521)

2024-04-30 Thread via cfe-commits
Author: Erich Keane Date: 2024-04-30T11:28:37-07:00 New Revision: fa67986d5b309ddd4c2ea74e8a5eeb0559aa8022 URL: https://github.com/llvm/llvm-project/commit/fa67986d5b309ddd4c2ea74e8a5eeb0559aa8022 DIFF: https://github.com/llvm/llvm-project/commit/fa67986d5b309ddd4c2ea74e8a5eeb0559aa8022.diff L

[clang] [OpenACC] Private Clause on Compute Constructs (PR #90521)

2024-04-30 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/90521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix a bug on constraint check with template friend function (PR #90646)

2024-04-30 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky created https://github.com/llvm/llvm-project/pull/90646 attempt to fix https://github.com/llvm/llvm-project/issues/90349 Skip to add outer class template arguments to `MTAL` when the friend function has the same depth with its lexical context(`CXXRecordDecl`). >From e

[clang] [Clang][Sema] fix a bug on constraint check with template friend function (PR #90646)

2024-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qizhi Hu (jcsxky) Changes attempt to fix https://github.com/llvm/llvm-project/issues/90349 Skip to add outer class template arguments to `MTAL` when the friend function has the same depth with its lexical context(`CXXRecordDecl`). --- Ful

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

2024-04-30 Thread Ivan Murashko via cfe-commits
https://github.com/ivanmurashko updated https://github.com/llvm/llvm-project/pull/90319 >From 3c36295b5f0f1e011e11d57c5ec4e685cb917cab Mon Sep 17 00:00:00 2001 From: Ivan Murashko Date: Fri, 26 Apr 2024 22:45:26 +0100 Subject: [PATCH] [Modules] Process include files changes with -fmodules-vali

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

2024-04-30 Thread Ivan Murashko via cfe-commits
@@ -0,0 +1,34 @@ +// UNSUPPORTED: system-windows +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: cd %t +// +// RUN: cp a1.h a.h +// RUN: %clang -fmodules -fmodules-validate-input-files-content -Xclang -fno-pch-timestamp -fimplicit-modules -fmodule-map-file=module.modulemap

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

2024-04-30 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/90319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Process include files changes with -fmodules-validate-input-files-content and -fno-pch-timestamp options (PR #90319)

2024-04-30 Thread Ivan Murashko via cfe-commits
https://github.com/ivanmurashko updated https://github.com/llvm/llvm-project/pull/90319 >From 71796a80e15b6700fec23fbec70635aae455b188 Mon Sep 17 00:00:00 2001 From: Ivan Murashko Date: Fri, 26 Apr 2024 22:45:26 +0100 Subject: [PATCH] [Modules] Process include files changes with -fmodules-vali

[clang] 41f9c78 - [OpenACC] Fix test failure from fa67986d

2024-04-30 Thread via cfe-commits
Author: erichkeane Date: 2024-04-30T11:53:57-07:00 New Revision: 41f9c78f6a4efe38edbb0b62131b0a0bf619c99a URL: https://github.com/llvm/llvm-project/commit/41f9c78f6a4efe38edbb0b62131b0a0bf619c99a DIFF: https://github.com/llvm/llvm-project/commit/41f9c78f6a4efe38edbb0b62131b0a0bf619c99a.diff LO

[clang] [clang-format] Fix a bug in annotating struct braces (PR #90555)

2024-04-30 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/90555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-04-30 Thread via cfe-commits
hiraditya wrote: I believe this is breaking the buildbot https://lab.llvm.org/buildbot/#/builders/245/builds/23936 please confirm. https://github.com/llvm/llvm-project/pull/90152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [clang][CodeGen] Fix MSVC ABI for classes with non static data members of reference type (PR #90547)

2024-04-30 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/90547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Fix MSVC ABI for classes with non static data members of reference type (PR #90547)

2024-04-30 Thread Eli Friedman via cfe-commits
@@ -1144,11 +1167,13 @@ bool MicrosoftCXXABI::classifyReturnType(CGFunctionInfo &FI) const { if (!RD) return false; - bool isTrivialForABI = RD->canPassInRegisters() && - isTrivialForMSVC(RD, FI.getReturnType(), CGM); - // MSVC always returns

[clang] [clang][CodeGen] Fix MSVC ABI for classes with non static data members of reference type (PR #90547)

2024-04-30 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: Maybe we should just be testing if the copy-assignment operator is deleted? For reference, MSVC also returns the following indirectly: ``` struct Test { int x; Test& operator=(const Test&) = delete; }; Test foo(); Test test(Test x) { return

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-04-30 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @erichkeane pushed a commit which fixes it https://github.com/llvm/llvm-project/pull/90152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

2024-04-30 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 updated https://github.com/llvm/llvm-project/pull/90625 >From 3b2f810ff3798ef073a8d1a10ca6fbafdbdb4641 Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Tue, 30 Apr 2024 11:18:15 -0500 Subject: [PATCH] [clang][Sema] Re-use existing BinaryOperator if possible First ro

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-04-30 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/85672 >From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Mon, 18 Mar 2024 10:19:38 -0700 Subject: [PATCH 1/5] [clang][CodeGen] Omit pre-opt link when post-opt link request

[clang] Fix -fno-unsafe-math-optimizations behavior (PR #89473)

2024-04-30 Thread Andy Kaylor via cfe-commits
andykaylor wrote: ping for review https://github.com/llvm/llvm-project/pull/89473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix -fno-unsafe-math-optimizations behavior (PR #89473)

2024-04-30 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: LGTM! Thanks. https://github.com/llvm/llvm-project/pull/89473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix -fno-unsafe-math-optimizations behavior (PR #89473)

2024-04-30 Thread Joshua Cranmer via cfe-commits
https://github.com/jcranmer-intel approved this pull request. https://github.com/llvm/llvm-project/pull/89473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [z/OS] treat text files as text files so auto-conversion is done (PR #90128)

2024-04-30 Thread Sean Perry via cfe-commits
@@ -413,8 +413,9 @@ static bool format(StringRef FileName, bool ErrorOnIncompleteFormat = false) { // On Windows, overwriting a file with an open file mapping doesn't work, // so read the whole file into memory when formatting in-place. ErrorOr> CodeOrErr = - !Outpu

[clang] [llvm] [z/OS] treat text files as text files so auto-conversion is done (PR #90128)

2024-04-30 Thread Sean Perry via cfe-commits
perry-ca wrote: > We don't normally commit in clang-format with a unit test I assume you mean "without a unit test". In this case the unit test is the existing test cases. Some fail on z/OS because the files are not read in as text. It's not really possible to detect this issue on other pla

[clang] [OpenMP][TR12] change property of map-type modifier. (PR #90499)

2024-04-30 Thread via cfe-commits
@@ -4675,8 +4709,10 @@ bool Parser::ParseOpenMPVarList(OpenMPDirectiveKind DKind, // Only parse map-type-modifier[s] and map-type if a colon is present in // the map clause. if (ColonPresent) { + if (getLangOpts().OpenMP >= 60 && getCurToken().is(tok::colon))

[clang] [Clang] Implement P2809: Trivial infinite loops are not Undefined Behavior (PR #90066)

2024-04-30 Thread via cfe-commits
@@ -908,6 +908,74 @@ void CodeGenFunction::EmitIfStmt(const IfStmt &S) { incrementProfileCounter(&S); } +bool CodeGenFunction::checkIfLoopMustProgress(const Expr *ControllingExpression, + bool IsTrivialCXXLoop) { + if (CGM.get

[clang] [Clang][HLSL] Add environment parameter to availability attribute (PR #89809)

2024-04-30 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/89809 >From 22b67d30ca087d6a912183039c87fd1790eedfe4 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Tue, 23 Apr 2024 00:49:28 -0700 Subject: [PATCH 1/4] Add environment parameter to clang availability attribute ---

[clang] [llvm] [x86] Add tan intrinsic part 4 (PR #90503)

2024-04-30 Thread Farzon Lotfi via cfe-commits
@@ -654,6 +655,7 @@ X86TargetLowering::X86TargetLowering(const X86TargetMachine &TM, setOperationAction(ISD::FSIN , VT, Expand); setOperationAction(ISD::FCOS , VT, Expand); setOperationAction(ISD::FSINCOS, VT, Expand); + setOperationAction(ISD::FTAN,

[clang] [OpenMP][TR12] change property of map-type modifier. (PR #90499)

2024-04-30 Thread Alexey Bataev via cfe-commits
@@ -4675,8 +4709,10 @@ bool Parser::ParseOpenMPVarList(OpenMPDirectiveKind DKind, // Only parse map-type-modifier[s] and map-type if a colon is present in // the map clause. if (ColonPresent) { + if (getLangOpts().OpenMP >= 60 && getCurToken().is(tok::colon))

[clang] [OpenMP][TR12] change property of map-type modifier. (PR #90499)

2024-04-30 Thread via cfe-commits
@@ -4675,8 +4709,10 @@ bool Parser::ParseOpenMPVarList(OpenMPDirectiveKind DKind, // Only parse map-type-modifier[s] and map-type if a colon is present in // the map clause. if (ColonPresent) { + if (getLangOpts().OpenMP >= 60 && getCurToken().is(tok::colon))

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-04-30 Thread Xiang Li via cfe-commits
@@ -0,0 +1,794 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang] [OpenMP][TR12] change property of map-type modifier. (PR #90499)

2024-04-30 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/90499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DXIL] Add tan intrinsic part 2 (PR #90277)

2024-04-30 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy approved this pull request. https://github.com/llvm/llvm-project/pull/90277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Improve support for explicit specializations of constrained member functions & member function templates (PR #88963)

2024-04-30 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/88963 >From 77de225477afd3689b8bf64107e8f3a4eeab85ac Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 16 Apr 2024 13:36:11 -0400 Subject: [PATCH 1/2] [Clang][Sema] Improve support for explicit speciali

[clang] [Clang][Sema] fix a bug on constraint check with template friend function (PR #90646)

2024-04-30 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: I'm actually working on constraint checking for function template specializations in #88963. I don't think this patch is quite right... this will cause a crash if the befriended function is a member of a class template specialization. Relative to the changes in #88963, I beli

[clang] [OpenMP][TR12] change property of map-type modifier. (PR #90499)

2024-04-30 Thread via cfe-commits
jyu2-git wrote: > LG Thanks Alexey! https://github.com/llvm/llvm-project/pull/90499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [BoundsSafety] WIP: Make 'counted_by' work for pointer fields; late parsing for 'counted_by' on decl attr position (PR #87596)

2024-04-30 Thread Dan Liew via cfe-commits
https://github.com/delcypher updated https://github.com/llvm/llvm-project/pull/87596 >From 03266b74d973075eb5dfa27f32bb9c1bb75d73f9 Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Mon, 29 Apr 2024 16:46:31 -0700 Subject: [PATCH 1/4] [BoundsSafety] Allow 'counted_by' attribute on pointers in stru

[clang] Add isTrivial() and isTriviallyCopyable() AST matchers (PR #90634)

2024-04-30 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/90634 >From 013b692fbd8ec3aab4913b65582e11c5be566c77 Mon Sep 17 00:00:00 2001 From: higher-performance <113926381+higher-performa...@users.noreply.github.com> Date: Tue, 30 Apr 2024 14:40:59 -0600 Subject: [

[clang] Add isTrivial() and isTriviallyCopyable() AST matchers (PR #90634)

2024-04-30 Thread via cfe-commits
higher-performance wrote: Hi, is this a new requirement? I don't wish to commit my personal information here. What are my options? https://github.com/llvm/llvm-project/pull/90634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

2024-04-30 Thread Sean Perry via cfe-commits
perry-ca wrote: ping @MaskRay. Thanks https://github.com/llvm/llvm-project/pull/89854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstallAPI] Cleanup I/O error handling for input lists (PR #90664)

2024-04-30 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/90664 Add validation in the FileList reader to check that the headers exist and use similar diagnostics in Options.cpp >From 42ad6921fdf179647f6529ddeb7d060e93e0f52f Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Da

[clang] [InstallAPI] Cleanup I/O error handling for input lists (PR #90664)

2024-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes Add validation in the FileList reader to check that the headers exist and use similar diagnostics in Options.cpp --- Full diff: https://github.com/llvm/llvm-project/pull/90664.diff 4 Files Affected: -

[clang] 6992433 - [Clang][NFC] Fix status colors

2024-04-30 Thread via cfe-commits
Author: cor3ntin Date: 2024-04-30T23:05:47+02:00 New Revision: 699243343439285ec2fe61b4ae568c7a958c7ce2 URL: https://github.com/llvm/llvm-project/commit/699243343439285ec2fe61b4ae568c7a958c7ce2 DIFF: https://github.com/llvm/llvm-project/commit/699243343439285ec2fe61b4ae568c7a958c7ce2.diff LOG:

[clang] 0232b77 - [Coroutines][Test] Specify target triple in coro-elide-thinlto (#90549)

2024-04-30 Thread via cfe-commits
Author: Wei Wang Date: 2024-04-30T14:31:31-07:00 New Revision: 0232b77e145577ab78e3ed1fdbb7eacc5a7381ab URL: https://github.com/llvm/llvm-project/commit/0232b77e145577ab78e3ed1fdbb7eacc5a7381ab DIFF: https://github.com/llvm/llvm-project/commit/0232b77e145577ab78e3ed1fdbb7eacc5a7381ab.diff LOG:

[clang] [Coroutines][Test] Specify target triple in coro-elide-thinlto (PR #90549)

2024-04-30 Thread Wei Wang via cfe-commits
https://github.com/apolloww closed https://github.com/llvm/llvm-project/pull/90549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fb85a28 - Fix -fno-unsafe-math-optimizations behavior (#89473)

2024-04-30 Thread via cfe-commits
Author: Andy Kaylor Date: 2024-04-30T14:43:45-07:00 New Revision: fb85a282d125a2805632285b29686392e6922b66 URL: https://github.com/llvm/llvm-project/commit/fb85a282d125a2805632285b29686392e6922b66 DIFF: https://github.com/llvm/llvm-project/commit/fb85a282d125a2805632285b29686392e6922b66.diff L

[clang] Fix -fno-unsafe-math-optimizations behavior (PR #89473)

2024-04-30 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/89473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coroutines][Test] Only run coro-elide-thinlto under x86_64-linux (PR #90672)

2024-04-30 Thread Wei Wang via cfe-commits
https://github.com/apolloww created https://github.com/llvm/llvm-project/pull/90672 Previous fix #90549 didn't completely address the Buildbot failures. Some target may not recognize the target triple. This time, only run the test under x86_64-linux. >From 66d63598d0c29cc7232715d0abfcfcc640dc

[clang] [Coroutines][Test] Only run coro-elide-thinlto under x86_64-linux (PR #90672)

2024-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Wei Wang (apolloww) Changes Previous fix #90549 didn't completely address the Buildbot failures. Some target may not recognize the target triple. This time, only run the test under x86_64-linux. --- Full diff: https://github.com/llvm/llv

[clang] [Coroutines][Test] Only run coro-elide-thinlto under x86_64-linux (PR #90672)

2024-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines Author: Wei Wang (apolloww) Changes Previous fix #90549 didn't completely address the Buildbot failures. Some target may not recognize the target triple. This time, only run the test under x86_64-linux. --- Full diff: https://github.com/llv

[clang] [Coroutines][Test] Only run coro-elide-thinlto under x86_64-linux (PR #90672)

2024-04-30 Thread Wei Wang via cfe-commits
apolloww wrote: https://lab.llvm.org/buildbot/#/builders/188/builds/45187 ``` Error running ThinLTO backend: No available targets are compatible with triple "x86_64-unknown-linux" ``` https://github.com/llvm/llvm-project/pull/90672 ___ cfe-commits m

[clang] [Clang] Implement P2809: Trivial infinite loops are not Undefined Behavior (PR #90066)

2024-04-30 Thread Eli Friedman via cfe-commits
@@ -908,6 +908,74 @@ void CodeGenFunction::EmitIfStmt(const IfStmt &S) { incrementProfileCounter(&S); } +bool CodeGenFunction::checkIfLoopMustProgress(const Expr *ControllingExpression, + bool IsTrivialCXXLoop) { + if (CGM.get

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #81545)

2024-04-30 Thread William Junda Huang via cfe-commits
@@ -1787,7 +1787,26 @@ Value *ScalarExprEmitter::VisitMemberExpr(MemberExpr *E) { } } - return EmitLoadOfLValue(E); + llvm::Value *Result = EmitLoadOfLValue(E); + + // If -fdebug_info_for_profiling is specified, emit a pseudo variable and its huangjd

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #81545)

2024-04-30 Thread William Junda Huang via cfe-commits
@@ -5636,6 +5636,84 @@ void CGDebugInfo::EmitExternalVariable(llvm::GlobalVariable *Var, Var->addDebugInfo(GVE); } +void CGDebugInfo::EmitPseudoVariable(CGBuilderTy &Builder, + llvm::Instruction *Value, QualType Ty) { + // Only when -g2

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #81545)

2024-04-30 Thread William Junda Huang via cfe-commits
@@ -5636,6 +5636,84 @@ void CGDebugInfo::EmitExternalVariable(llvm::GlobalVariable *Var, Var->addDebugInfo(GVE); } +void CGDebugInfo::EmitPseudoVariable(CGBuilderTy &Builder, + llvm::Instruction *Value, QualType Ty) { + // Only when -g2

[clang] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-04-30 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/90676 stdarg.h and especially stddef.h are textual and so everything they declare gets precompiled into all of their clients' pcm files. They shouldn't directly declare anything though, their purpose is to s

[clang] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ian Anderson (ian-twilightcoder) Changes stdarg.h and especially stddef.h are textual and so everything they declare gets precompiled into all of their clients' pcm files. They shouldn't directly declare anything though, their purpose is

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

2024-04-30 Thread Fangrui Song via cfe-commits
MaskRay wrote: Clang configuration files https://clang.llvm.org/docs/UsersManual.html#configuration-files cover your use case and the feature is exactly designed to avoid such cmake default configs. https://blogs.gentoo.org/mgorny/2022/10/07/clang-in-gentoo-now-sets-default-runtimes-via-config

[clang] [llvm] [Pipelines] Do not run CoroSplit and CoroCleanup in LTO pre-link pipeline (PR #90310)

2024-04-30 Thread Sam Clegg via cfe-commits
sbc100 wrote: This change seems to causing the auto-roller for emscripten to fail due to a crash in LTO. See https://ci.chromium.org/ui/p/emscripten-releases/builders/luci.emscripten-releases.ci/linux-test-suites ``` PromoteIntegerOperand Op #3: t22: i32,ch = llvm.coro.subfn.addr t26, Target

[clang] [llvm] [Pipelines] Do not run CoroSplit and CoroCleanup in LTO pre-link pipeline (PR #90310)

2024-04-30 Thread Sam Clegg via cfe-commits
sbc100 wrote: The function being compiled in the crash looks like this one: https://github.com/emscripten-core/emscripten/blob/56547157a37e25fb31f9193461a2c88bdaa44385/system/lib/embind/bind.cpp#L66-L68 https://github.com/llvm/llvm-project/pull/90310

[clang] [BoundsSafety] WIP: Make 'counted_by' work for pointer fields; late parsing for 'counted_by' on decl attr position (PR #87596)

2024-04-30 Thread Dan Liew via cfe-commits
https://github.com/delcypher updated https://github.com/llvm/llvm-project/pull/87596 >From 03266b74d973075eb5dfa27f32bb9c1bb75d73f9 Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Mon, 29 Apr 2024 16:46:31 -0700 Subject: [PATCH 1/4] [BoundsSafety] Allow 'counted_by' attribute on pointers in stru

[clang] [clang-tools-extra] [llvm] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-04-30 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/90676 >From 8d8756f00297e90e0b1125d2a78d3f41c9aae6a7 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Tue, 30 Apr 2024 15:16:38 -0700 Subject: [PATCH] [clang][modules] stdarg.h and stddef.h shouldn't directl

[clang] [clang-tools-extra] [llvm] [clang][modules] stdarg.h and stddef.h shouldn't directly declare anything (PR #90676)

2024-04-30 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/90676 >From 052dfeb8d94971dadfa65147f79d5fa37910b0e0 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Tue, 30 Apr 2024 15:16:38 -0700 Subject: [PATCH] [clang][modules] stdarg.h and stddef.h shouldn't directl

[clang] [llvm] [Pipelines] Do not run CoroSplit and CoroCleanup in LTO pre-link pipeline (PR #90310)

2024-04-30 Thread Wei Wang via cfe-commits
apolloww wrote: hmm, this looks like `llvm.coro.subfn.addr` is not lowered before codegen starts. And this is for wasm and MonoLTO. Let me check. https://github.com/llvm/llvm-project/pull/90310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [Clang][Sema] fix a bug on constraint check with template friend function (PR #90646)

2024-04-30 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > I'm actually working on constraint checking for function template > specializations in #88963. I don't think this patch is quite right... this > will cause a crash if the befriended function is a member of a class template > specialization. Relative to the changes in #88963, I

[clang] 278774e - [InstallAPI] Cleanup I/O error handling for input lists (#90664)

2024-04-30 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-04-30T16:10:20-07:00 New Revision: 278774e428c280b6ab62c147ac33b6837dad6dd5 URL: https://github.com/llvm/llvm-project/commit/278774e428c280b6ab62c147ac33b6837dad6dd5 DIFF: https://github.com/llvm/llvm-project/commit/278774e428c280b6ab62c147ac33b6837dad6dd5.diff

[clang] [InstallAPI] Cleanup I/O error handling for input lists (PR #90664)

2024-04-30 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/90664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstallAPI] Support mutually exclusive parse options (PR #90686)

2024-04-30 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/90686 Projects like libc use mutually exclusive macros to compile files multiple times and then merge the result into the final library. For installapi to accept these, we'd need to parse the same declarations in

[clang] [llvm] [InstallAPI] Support mutually exclusive parse options (PR #90686)

2024-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes Projects like libc use mutually exclusive macros to compile files multiple times and then merge the result into the final library. For installapi to accept these, we'd need to parse the same declarations

[clang] [llvm] [Pipelines] Do not run CoroSplit and CoroCleanup in LTO pre-link pipeline (PR #90310)

2024-04-30 Thread Wei Wang via cfe-commits
apolloww wrote: OK, so Mono LTO backend pipeline does not have any coro passes. We can add coroutine passes to `buildLTODefaultPipeline`, but I am not sure how big the use case it is. For now, I'll limit the tuning to ThinLTO only. Will send an update soon. https://github.com/llvm/llvm-projec

[clang] [llvm] [Pipelines][Coroutines] Tune coroutine passes only for ThinLTO pre-link pipeline (PR #90690)

2024-04-30 Thread Wei Wang via cfe-commits
https://github.com/apolloww created https://github.com/llvm/llvm-project/pull/90690 Follow up to #90310, limit the tune up only to ThinLTO pre-link as coroutine passes are not in MonoLTO backend Also coro-elide-thinlto test is still failing on some Buildbots, only run the test under x86_64 li

[clang] [llvm] [Pipelines][Coroutines] Tune coroutine passes only for ThinLTO pre-link pipeline (PR #90690)

2024-04-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines @llvm/pr-subscribers-clang Author: Wei Wang (apolloww) Changes Follow up to #90310, limit the tune up only to ThinLTO pre-link as coroutine passes are not in MonoLTO backend Also coro-elide-thinlto test is still failing on some Buildbots, on

[clang] [clang][CodeGen] Fix MSVC ABI for classes with non static data members of reference type (PR #90547)

2024-04-30 Thread Max Winkler via cfe-commits
MaxEW707 wrote: > Maybe we should just be testing if the copy-assignment operator is deleted? > For reference, MSVC also returns the following indirectly: > > ``` > struct Test > { > int x; > Test& operator=(const Test&) = delete; > }; > Test foo(); > Test test(Test x) > { > return x;

[clang] [llvm] [Pipelines][Coroutines] Tune coroutine passes only for ThinLTO pre-link pipeline (PR #90690)

2024-04-30 Thread Sam Clegg via cfe-commits
https://github.com/sbc100 approved this pull request. I'm not very familiar with this code, but it looks reasonable on the surface. https://github.com/llvm/llvm-project/pull/90690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-04-30 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 95200f3bb3859738981240a9d8c503a13ede9601 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 01/15] Add support for builtin_verbose_trap The builtin causes

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-04-30 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: We could use the function name without the prefix as the key when searching for the subprogram in `CGDebugInfo::createInlinedTrapSubprogram`. https://github.com/llvm/llvm-project/pull/79230 ___ cfe-commits mailing list cfe-commits@list

[clang] [Coroutines][Test] Only run coro-elide-thinlto under x86_64-linux (PR #90672)

2024-04-30 Thread via cfe-commits
dyung wrote: This test has been failing on bots for several hours now. Can we either get this fix in or the original change reverted to get the bots back to green? One failing bot is https://lab.llvm.org/buildbot/#/builders/280/builds/2876. https://github.com/llvm/llvm-project/pull/90672 _

[clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-04-30 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa updated https://github.com/llvm/llvm-project/pull/89638 >From aafa018b3d7657483738fa91812e3e8bbdd8205a Mon Sep 17 00:00:00 2001 From: YunQiang Su Date: Sat, 27 Apr 2024 10:55:38 +0800 Subject: [PATCH 1/2] Triple::normalize: Use none as OS for XX-none-ABI When we pars

[clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-04-30 Thread YunQiang Su via cfe-commits
wzssyqa wrote: @peterwaller-arm half-done. Do *NOT* merge it now. It has still some problem. See `clang/test/Driver/baremetal-multilib.yaml`. There is still some `none-unknown`. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing l

[clang] [Coroutines][Test] Only run coro-elide-thinlto under x86_64-linux (PR #90672)

2024-04-30 Thread Wei Wang via cfe-commits
apolloww wrote: > This test has been failing on bots for several hours now. Can we either get > this fix in or the original change reverted to get the bots back to green? > One failing bot is https://lab.llvm.org/buildbot/#/builders/280/builds/2876. sorry for the breakage, the same fix is incl

[clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-04-30 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa updated https://github.com/llvm/llvm-project/pull/89638 >From aafa018b3d7657483738fa91812e3e8bbdd8205a Mon Sep 17 00:00:00 2001 From: YunQiang Su Date: Sat, 27 Apr 2024 10:55:38 +0800 Subject: [PATCH 1/2] Triple::normalize: Use none as OS for XX-none-ABI When we pars

[clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-04-30 Thread YunQiang Su via cfe-commits
wzssyqa wrote: @peterwaller-arm It seems OK now. Let's wait the result of CI. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b1b1bfa - [Coroutines][Test] Only run coro-elide-thinlto under x86_64-linux (#90672)

2024-04-30 Thread via cfe-commits
Author: Wei Wang Date: 2024-04-30T18:08:40-07:00 New Revision: b1b1bfa7bea0ce489b5ea9134e17a43c695df5ec URL: https://github.com/llvm/llvm-project/commit/b1b1bfa7bea0ce489b5ea9134e17a43c695df5ec DIFF: https://github.com/llvm/llvm-project/commit/b1b1bfa7bea0ce489b5ea9134e17a43c695df5ec.diff LOG:

<    1   2   3   4   5   >