[clang] ca7d944 - [clang][dataflow] Support `CXXParenListInitExpr` in `PropagateResultObject()`. (#89235)

2024-04-19 Thread via cfe-commits
Author: martinboehme Date: 2024-04-19T09:06:13+02:00 New Revision: ca7d9442baf638f020c9594dc2af388d24c4a3e1 URL: https://github.com/llvm/llvm-project/commit/ca7d9442baf638f020c9594dc2af388d24c4a3e1 DIFF: https://github.com/llvm/llvm-project/commit/ca7d9442baf638f020c9594dc2af388d24c4a3e1.diff

[clang] [clang][dataflow] Support `CXXParenListInitExpr` in `PropagateResultObject()`. (PR #89235)

2024-04-19 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/89235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-19 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/89213 >From d4205b37d9ba3cecd7cd947a188ec84e9afec899 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Thu, 18 Apr 2024 10:50:40 + Subject: [PATCH 1/3] [clang][dataflow] Model conditional operator correctly.

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-19 Thread via cfe-commits
mahtohappy wrote: Check is for dependent types and earlier I was not checking that with the condition being only ```if (ArraySize)``` so normal arrays with new initializer also were passing the check. Now added the dependent type check as well ```if (ArraySize && E->isTypeDependent())``` https

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-19 Thread via cfe-commits
@@ -657,17 +658,25 @@ class TransferVisitor : public ConstStmtVisitor { } void VisitConditionalOperator(const ConditionalOperator *S) { -// FIXME: Revisit this once flow conditions are added to the framework. For -// `a = b ? c : d` we can add `b => a == c && !b =

[clang] [llvm] [mlir] Fix Definition Mismatches (PR #89294)

2024-04-19 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/89294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix Definition Mismatches (PR #89294)

2024-04-19 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw requested changes to this pull request. https://github.com/llvm/llvm-project/pull/89294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix Definition Mismatches (PR #89294)

2024-04-19 Thread Yingwei Zheng via cfe-commits
@@ -433,7 +433,7 @@ class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final Value *foldAndOrOfICmpsOfAndWithPow2(ICmpInst *LHS, ICmpInst *RHS, Instruction *CxtI, bool IsAnd, bool IsLogical = false); -

[clang] [clang][analyzer] Move StreamChecker out of the alpha package. (PR #89247)

2024-04-19 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/89247 From 7138f026e845ebb4f1a3e6a86bdeb534d666ae7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Thu, 18 Apr 2024 16:40:03 +0200 Subject: [PATCH 1/2] [clang][analyzer] Move StreamChecker ou

[clang] [clang][nullability] Remove `RecordValue`. (PR #89052)

2024-04-19 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/89052 >From a705853deb0cfa6596245c929e9b86ea2d2a7c26 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Wed, 17 Apr 2024 11:31:12 + Subject: [PATCH] [clang][nullability] Remove `RecordValue`. This class no l

[clang] b2323f4 - [AIX][Debug] generate an error instead of crash in backend for -gdwarf-5

2024-04-19 Thread Chen Zheng via cfe-commits
Author: Chen Zheng Date: 2024-04-19T03:39:17-04:00 New Revision: b2323f43e3cdb52b4e15a7d4f434cd5c64740dd4 URL: https://github.com/llvm/llvm-project/commit/b2323f43e3cdb52b4e15a7d4f434cd5c64740dd4 DIFF: https://github.com/llvm/llvm-project/commit/b2323f43e3cdb52b4e15a7d4f434cd5c64740dd4.diff LO

[clang] [clang][nullability] Remove `RecordValue`. (PR #89052)

2024-04-19 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/89052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e8fce95 - [clang][nullability] Remove `RecordValue`. (#89052)

2024-04-19 Thread via cfe-commits
Author: martinboehme Date: 2024-04-19T09:39:52+02:00 New Revision: e8fce95887ecfd87a83db8dbb0cc55966b004d6f URL: https://github.com/llvm/llvm-project/commit/e8fce95887ecfd87a83db8dbb0cc55966b004d6f DIFF: https://github.com/llvm/llvm-project/commit/e8fce95887ecfd87a83db8dbb0cc55966b004d6f.diff

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-19 Thread via cfe-commits
@@ -657,17 +658,22 @@ class TransferVisitor : public ConstStmtVisitor { } void VisitConditionalOperator(const ConditionalOperator *S) { -// FIXME: Revisit this once flow conditions are added to the framework. For -// `a = b ? c : d` we can add `b => a == c && !b =

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-19 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/89213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-19 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/89213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]MveEmitter:Pass Args as const references (PR #89202)

2024-04-19 Thread via cfe-commits
https://github.com/aniplcc updated https://github.com/llvm/llvm-project/pull/89202 >From 650a14ed69d1296d3674e58cf66364ca6fa21932 Mon Sep 17 00:00:00 2001 From: aniplcc Date: Thu, 18 Apr 2024 15:38:55 +0530 Subject: [PATCH] [clang]MveEmitter:Update args with const references --- clang/utils/T

[clang] [clang-repl] Clone the llvm::Modules to avoid invalid memory access. (PR #89031)

2024-04-19 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/89031 >From e5aae5f7b945f1f6da58453f03dafdb86c90 Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Fri, 19 Apr 2024 07:51:17 + Subject: [PATCH] [clang-repl] Keep the first llvm::Module empty to avoid inv

[clang] [clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (PR #89031)

2024-04-19 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/89031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (PR #89031)

2024-04-19 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/89031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (PR #89031)

2024-04-19 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: After an offline discussion with @lhames, we have a more simplified approach which should consume less memory. Now we just keep the first llvm::Module empty and make sure it's used only for read-only purposes such as computing the llvm::DataLayout out of it in CodeGen. https

[clang] [clang][dataflow][NFC] Fix code formatting in DataflowEnvironment.cpp (PR #89352)

2024-04-19 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/89352 For some reason, when I merged #89235, two lines were mis-formatted. This patch corrects this; while I'm here, I'm also correcting other existing formatting errors. >From 483a737432dc0e063addb9b15cf8853dab

[clang] [clang][dataflow][NFC] Fix code formatting in DataflowEnvironment.cpp (PR #89352)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis @llvm/pr-subscribers-clang Author: None (martinboehme) Changes For some reason, when I merged #89235, two lines were mis-formatted. This patch corrects this; while I'm here, I'm also correcting other existing formatting errors. --- Full

[clang] [clang][dataflow][NFC] Fix code formatting in DataflowEnvironment.cpp (PR #89352)

2024-04-19 Thread via cfe-commits
martinboehme wrote: Merging without review as this is a trivial, formatting-only change that was auto-generated by clang-format, and I'd like to expeditiously fix the formatting error I made in https://github.com/llvm/llvm-project/pull/89235. https://github.com/llvm/llvm-project/pull/89352 ___

[clang] [llvm] [mlir] Fix Definition Mismatches (PR #89294)

2024-04-19 Thread Mehdi Amini via cfe-commits
@@ -433,7 +433,7 @@ class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final Value *foldAndOrOfICmpsOfAndWithPow2(ICmpInst *LHS, ICmpInst *RHS, Instruction *CxtI, bool IsAnd, bool IsLogical = false); -

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

2024-04-19 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/89294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move StreamChecker out of the alpha package. (PR #89247)

2024-04-19 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/89247 From 7138f026e845ebb4f1a3e6a86bdeb534d666ae7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Thu, 18 Apr 2024 16:40:03 +0200 Subject: [PATCH 1/3] [clang][analyzer] Move StreamChecker ou

[clang] 1412210 - [clang][dataflow][NFC] Fix code formatting in DataflowEnvironment.cpp (#89352)

2024-04-19 Thread via cfe-commits
Author: martinboehme Date: 2024-04-19T10:12:57+02:00 New Revision: 14122106320b88f114301bbf8694ceac9bb7a27a URL: https://github.com/llvm/llvm-project/commit/14122106320b88f114301bbf8694ceac9bb7a27a DIFF: https://github.com/llvm/llvm-project/commit/14122106320b88f114301bbf8694ceac9bb7a27a.diff

[clang] [clang][dataflow][NFC] Fix code formatting in DataflowEnvironment.cpp (PR #89352)

2024-04-19 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/89352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

2024-04-19 Thread Nikita Popov via cfe-commits
nikic wrote: Isn't the warning about a mismatch between declaration and definition, not call args? The InstCombine change does make the definition and declaration match. On Fri, Apr 19, 2024, at 17:07, Mehdi Amini wrote: > > > ***@***. commented on this pull request. > > > In llvm/lib/T

[clang] [clang][RISCV] Support RVV bfloat16 C intrinsics (PR #89354)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-risc-v Author: Brandon Wu (4vtomat) Changes It follows the interface defined here: https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/293 --- Patch is 4.84 MiB, truncated to 20.00 KiB below, full version: https

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

2024-04-19 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: > Isn't the warning about a mismatch between declaration and definition, not > call args? The InstCombine change does make the definition and declaration > match. > […](#) > On Fri, Apr 19, 2024, at 17:07, Mehdi Amini wrote: ***@***. commented on > this pull request. In llvm

[clang] aac695d - [NFC] [Serialization] Use semantical type 'DeclID' for 'CreateDeserialized'

2024-04-19 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-04-19T16:24:47+08:00 New Revision: aac695da42cf48ccb29c2fe495ead564cc913471 URL: https://github.com/llvm/llvm-project/commit/aac695da42cf48ccb29c2fe495ead564cc913471 DIFF: https://github.com/llvm/llvm-project/commit/aac695da42cf48ccb29c2fe495ead564cc913471.diff LO

[clang] [llvm] demangle function names in trace files (PR #87626)

2024-04-19 Thread via cfe-commits
https://github.com/Trass3r updated https://github.com/llvm/llvm-project/pull/87626 >From 153bb2fd38b8bb18281bd52c2a21b6e4a75f3fc8 Mon Sep 17 00:00:00 2001 From: Andreas Hollandt Date: Tue, 4 Oct 2022 12:05:39 +0200 Subject: [PATCH 1/2] demangle OptFunction trace names This improves consistency

[clang] [clang][RISCV] Support RVV bfloat16 C intrinsics (PR #89354)

2024-04-19 Thread Kito Cheng via cfe-commits
kito-cheng wrote: vfncvtbf16.c, vfwcvtbf16.c and vfwmaccbf16.c already in the LLVM repo, so I think those files could removed from this PR? https://github.com/llvm/llvm-project/pull/89354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [clang][RISCV] Support RVV bfloat16 C intrinsics (PR #89354)

2024-04-19 Thread Brandon Wu via cfe-commits
4vtomat wrote: Oh, I forgot to remove them. Or do you think they should be moved to bfloat folder to make them consistent? https://github.com/llvm/llvm-project/pull/89354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [clang] Catch missing format attributes (PR #70024)

2024-04-19 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovicsyrmia updated https://github.com/llvm/llvm-project/pull/70024 From 79873c374c982eed00c3adbc91b5cbff91c5946b Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribut

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

2024-04-19 Thread Balazs Benics via cfe-commits
steakhal wrote: `StaticAnalyzer` changes LGTM. https://github.com/llvm/llvm-project/pull/89294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-04-19 Thread via cfe-commits
https://github.com/guillem-bartina-sonarsource edited https://github.com/llvm/llvm-project/pull/84515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix stores through label locations (PR #89265)

2024-04-19 Thread via cfe-commits
@@ -2358,11 +2358,12 @@ StoreRef RegionStoreManager::killBinding(Store ST, Loc L) { RegionBindingsRef RegionStoreManager::bind(RegionBindingsConstRef B, Loc L, SVal V) { - if (L.getAs()) + // We only care about region locations. + auto MemRegVal = L.getAs(); + if (!MemReg

[clang] [analyzer] Fix stores through label locations (PR #89265)

2024-04-19 Thread via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/89265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix stores through label locations (PR #89265)

2024-04-19 Thread via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM nice quickfix :) https://github.com/llvm/llvm-project/pull/89265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve documented sampling profiler steps to best known methods (PR #88438)

2024-04-19 Thread Wei Xiao via cfe-commits
@@ -2443,27 +2443,29 @@ usual build cycle when using sample profilers for optimization: usual build flags that you always build your application with. The only requirement is that DWARF debug info including source line information is generated. This DWARF information

[clang] [clang] CTAD: implement the missing IsDeducible constraint for alias templates (PR #89358)

2024-04-19 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/89358 Fixes https://github.com/llvm/llvm-project/issues/85192 Fixes https://github.com/llvm/llvm-project/issues/84492 This patch implements the "IsDeducible" constraint where the template arguments of the alias templat

[clang] [clang] CTAD: implement the missing IsDeducible constraint for alias templates (PR #89358)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes Fixes https://github.com/llvm/llvm-project/issues/85192 Fixes https://github.com/llvm/llvm-project/issues/84492 This patch implements the "IsDeducible" constraint where the template arguments of the alias templ

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu (PR #89359)

2024-04-19 Thread via cfe-commits
https://github.com/Khao7342 created https://github.com/llvm/llvm-project/pull/89359 This pull request adds definitions for the XiangShan-KunMingHu processor. "XiangShan" is a high-performance open-source RISC-V processor project, and "KunMingHu" architecture is its third generation. Official d

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu (PR #89359)

2024-04-19 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu (PR #89359)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: None (Khao7342) Changes This pull request adds definitions for the XiangShan-KunMingHu processor. "XiangShan" is a high-performance open-source RISC-V processor project, and "KunMingHu" architecture is its third generation. Offic

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu (PR #89359)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (Khao7342) Changes This pull request adds definitions for the XiangShan-KunMingHu processor. "XiangShan" is a high-performance open-source RISC-V processor project, and "KunMingHu" architecture is its third generation. Officia

[clang] [clang] CTAD: implement the missing IsDeducible constraint for alias templates (PR #89358)

2024-04-19 Thread Haojian Wu via cfe-commits
hokein wrote: Regarding the __is_deducible type trait, GCC also provides one, but it was hidden from users and only used for internal CTAD implementation. I'm not sure if we should follow the same strategy in clang, ideas? https://github.com/llvm/llvm-project/pull/89358 __

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu (PR #89359)

2024-04-19 Thread Pengcheng Wang via cfe-commits
wangpc-pp wrote: Has KunMingHu's RTl been finalized (IIRC, we have developing vector unit)? And can we have different doc for different generations of XiangShan? https://github.com/llvm/llvm-project/pull/89359 ___ cfe-commits mailing list cfe-commits@

[clang] [Clang][CodeGen] Optimised LLVM IR for atomic increments/decrements on floats (PR #89362)

2024-04-19 Thread Krishna Narayanan via cfe-commits
https://github.com/Krishna-13-cyber created https://github.com/llvm/llvm-project/pull/89362 Addresses #53079 >From 4e649d105a2af038e6dbd0e93b457eebea2e543a Mon Sep 17 00:00:00 2001 From: Krishna-13-cyber Date: Fri, 19 Apr 2024 15:09:26 +0530 Subject: [PATCH] Add optimised LLVM IR for atomic i

[clang] [Clang][CodeGen] Optimised LLVM IR for atomic increments/decrements on floats (PR #89362)

2024-04-19 Thread Krishna Narayanan via cfe-commits
https://github.com/Krishna-13-cyber converted_to_draft https://github.com/llvm/llvm-project/pull/89362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Optimised LLVM IR for atomic increments/decrements on floats (PR #89362)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krishna Narayanan (Krishna-13-cyber) Changes Addresses #53079 --- Patch is 48.64 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/89362.diff 3 Files Affected: - (modified) clang/lib/CodeGen/C

[clang] [clang][analyzer] Move StreamChecker out of the alpha package. (PR #89247)

2024-04-19 Thread via cfe-commits
=?utf-8?q?Balázs_Kéri?= , =?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: @@ -910,8 +910,8 @@ Unix Alpha Checkers - -alpha.unix.Stream + +unix.Stream NagyDonat wrote: Remove it from this file entirely. In fact, I strongly suspect that the entire HTML d

[clang] [clang][analyzer] Move StreamChecker out of the alpha package. (PR #89247)

2024-04-19 Thread via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= , =?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: @@ -48,7 +48,7 @@ Open Projects (Difficulty: Medium) - alpha.unix.StreamChecker + unix.StreamChecker NagyDonat wrote: Yes, remove it from

[clang] [clang-format] Do not update cursor pos if no includes replacement (PR #77456)

2024-04-19 Thread via cfe-commits
https://github.com/NorthBlue333 updated https://github.com/llvm/llvm-project/pull/77456 >From 6c184f9714c94af94c7692e1264061b8dc14e912 Mon Sep 17 00:00:00 2001 From: NorthBlue333 Date: Tue, 9 Jan 2024 14:01:14 +0100 Subject: [PATCH] [clang-format] Do not update cursor pos if no includes replac

[clang] [clang-format] Do not update cursor pos if no includes replacement (PR #77456)

2024-04-19 Thread via cfe-commits
NorthBlue333 wrote: Sure, that was was not very clear from my side I agree. Yes, your implementation is cleaner (I don't know why I did not do that from the beginning, I think I was struggling to fix the other tests and ended up with something more complicated than necessary). I have squashed

[clang] [Clang][Sema] Warn when 'exclude_from_explicit_instantiation' attribute is used on local classes and members thereof (PR #88777)

2024-04-19 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @mikaelholmen I believe there are two uses of `exclude_from_explicit_instantiation` in libc++ which are responsible for all these warnings. I was assuming that someone more experienced with the libc++ side of things would handle it, but I can submit a patch that addresses the

[clang] [AST] Dump argument types for TypeTraitExpr. (PR #89370)

2024-04-19 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/89370 The argument types are not modeled as children of TypeTraitExpr, therefore they are not dumped with the default implementation. Dumping them is really useful for ad-hoc debugging, context #89358 >From e8a9fcfa4

[clang] [AST] Dump argument types for TypeTraitExpr. (PR #89370)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes The argument types are not modeled as children of TypeTraitExpr, therefore they are not dumped with the default implementation. Dumping them is really useful for ad-hoc debugging, context #89358 --- Full diff

[clang] [Clang][Sema] Warn when 'exclude_from_explicit_instantiation' attribute is used on local classes and members thereof (PR #88777)

2024-04-19 Thread via cfe-commits
mikaelholmen wrote: Nice! I have no idea about this I just saw the warnings when I compiled and connected them to this patch. https://github.com/llvm/llvm-project/pull/88777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-19 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72400 >From dd0f87b25733b4569b89ce445630ee843e3bfb2b Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Mon, 11 Apr 2022 16:53:24 +0200 Subject: [PATCH] [libclang] Compute the right spelling location Locati

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-19 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: Thanks for the review @jansvoboda11; I've added an entry in the release notes and a unit test. https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] e2f1cba - [analyzer] Use explicit call description mode (easy cases) (#88879)

2024-04-19 Thread via cfe-commits
Author: NagyDonat Date: 2024-04-19T14:22:51+02:00 New Revision: e2f1cbae45f81f3cd9a4d3c2bcf69a094eb060fa URL: https://github.com/llvm/llvm-project/commit/e2f1cbae45f81f3cd9a4d3c2bcf69a094eb060fa DIFF: https://github.com/llvm/llvm-project/commit/e2f1cbae45f81f3cd9a4d3c2bcf69a094eb060fa.diff LOG

[clang] [analyzer] Use explicit call description mode (easy cases) (PR #88879)

2024-04-19 Thread via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/88879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Warn when 'exclude_from_explicit_instantiation' attribute is used on local classes and members thereof (PR #88777)

2024-04-19 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @mikaelholmen See #89377 https://github.com/llvm/llvm-project/pull/88777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] CTAD: Fix require-clause is not transformed. (PR #89378)

2024-04-19 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/89378 Fixes https://github.com/llvm/llvm-project/issues/89013 When building the deduction guide, we use the TemplateArgsForBuildingFPrime to transform the require-clause from the underlying class deduction guide. Howe

[clang] [clang] CTAD: Fix require-clause is not transformed. (PR #89378)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes Fixes https://github.com/llvm/llvm-project/issues/89013 When building the deduction guide, we use the TemplateArgsForBuildingFPrime to transform the require-clause from the underlying class deduction guide. Ho

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-19 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > @tbaederr -- this triggers an assertion with the new constexpr interpreter > > in `clang/test/AST/Interp/intap.cpp` but I'm not certain I understand why. > > Can you help me figure out how to fix that? > > https://buildkite.com/llvm-project/github-pull-requests/builds/56

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-19 Thread Leandro Lupori via cfe-commits
https://github.com/luporl approved this pull request. https://github.com/llvm/llvm-project/pull/88932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [polly] [clang-format] Revert breaking stream operators to previous default (PR #89016)

2024-04-19 Thread via cfe-commits
mydeveloperday wrote: Do you think we should push this into the 18 branch? https://github.com/llvm/llvm-project/pull/89016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow raw string literals in C as an extension (PR #88265)

2024-04-19 Thread Aaron Ballman via cfe-commits
@@ -130,6 +130,12 @@ struct LangStandard { /// hasDigraphs - Language supports digraphs. bool hasDigraphs() const { return Flags & Digraphs; } + /// hasRawStringLiterals - Language supports R"()" raw string literals. + bool hasRawStringLiterals() const { +// GCC supp

[clang] aa39b0b - [AIX][Debug]correct the cases on AIX bot, NFC

2024-04-19 Thread Chen Zheng via cfe-commits
Author: Chen Zheng Date: 2024-04-19T08:52:28-04:00 New Revision: aa39b0b13e3b56ac072acff2660dbef9db45bca0 URL: https://github.com/llvm/llvm-project/commit/aa39b0b13e3b56ac072acff2660dbef9db45bca0 DIFF: https://github.com/llvm/llvm-project/commit/aa39b0b13e3b56ac072acff2660dbef9db45bca0.diff LO

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Where is the repro from the original author? What did they share, and what ended up being the solution/test here for it? https://github.com/llvm/llvm-project/pull/89036 ___ cfe-commits mailing list cfe-commits

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/89036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-19 Thread Erich Keane via cfe-commits
@@ -12864,6 +12864,19 @@ TreeTransform::TransformCXXNewExpr(CXXNewExpr *E) { ArraySize = NewArraySize.get(); } + // Per C++0x [expr.new]p5, the type being constructed may be a + // typedef of an array type. + QualType AllocType = AllocTypeInfo->getType(); + if (Arra

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-19 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/89254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-19 Thread via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c23 %s + +// GH87641 noticed that integer promotion of a bit-field of bit-precise integer +// type was promoting to int rather than the type of the bit-field. +struct S { + unsigned _BitInt(7) x : 2; + unsigned _Bit

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-19 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. Just one comment but LGTM otherwise. https://github.com/llvm/llvm-project/pull/89254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [AST] Dump argument types for TypeTraitExpr. (PR #89370)

2024-04-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: It seems to me that exposing these as children is the better option here, right? That way it would better model a CallExpr or template type-trait, and would work in our StmtProfiler et-al. https://github.com/llvm/llvm-project/pull/89370 ___

[clang] [clang] CTAD: implement the missing IsDeducible constraint for alias templates (PR #89358)

2024-04-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Needs a release note, and I think we actually DO have to do those diagnostics here. https://github.com/llvm/llvm-project/pull/89358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [clang] CTAD: implement the missing IsDeducible constraint for alias templates (PR #89358)

2024-04-19 Thread Erich Keane via cfe-commits
@@ -6100,6 +6100,17 @@ static bool EvaluateBinaryTypeTrait(Sema &Self, TypeTrait BTT, const TypeSourceI tok::kw___is_pointer_interconvertible_base_of); return Self.IsPointerInterconvertibleBaseOf(Lhs, Rhs); + } + case BTT_IsDeducible: { +

[clang] [clang] CTAD: implement the missing IsDeducible constraint for alias templates (PR #89358)

2024-04-19 Thread Erich Keane via cfe-commits
@@ -3207,6 +3241,59 @@ Sema::DeduceTemplateArguments(VarTemplatePartialSpecializationDecl *Partial, return ::DeduceTemplateArguments(*this, Partial, TemplateArgs, Info); } +TemplateDeductionResult +Sema::DeduceTemplateArgumentsFromType(TemplateDecl *TD, QualType FromType, +

[clang] [clang] CTAD: implement the missing IsDeducible constraint for alias templates (PR #89358)

2024-04-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/89358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] CTAD: Fix require-clause is not transformed. (PR #89378)

2024-04-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/89378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/89254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. This change looks right to me! I don't know if there is value in a signed-test instead of unsigned, but a couple more tests might be nice anyway. https://github.com/llvm/llvm-project/pull/89254 _

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-19 Thread Erich Keane via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c23 %s + +// GH87641 noticed that integer promotion of a bit-field of bit-precise integer +// type was promoting to int rather than the type of the bit-field. +struct S { + unsigned _BitInt(7) x : 2; + unsigned _Bit

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-19 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c23 %s + +// GH87641 noticed that integer promotion of a bit-field of bit-precise integer +// type was promoting to int rather than the type of the bit-field. +struct S { + unsigned _BitInt(7) x : 2; + unsigned _Bit

[clang-tools-extra] [clangd] Use TargetOpts from preamble when building ASTs (PR #88381)

2024-04-19 Thread via cfe-commits
zibi2 wrote: @kadircet FYI, I noticed our Linux on Power down stream build failues related to this change. The upstream builds are also faling see https://lab.llvm.org/buildbot/#/builders/57/builds/34415 for example. ``` ld.lld: error: undefined symbol: llvm::Triple::getArchName() const >>> re

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-19 Thread via cfe-commits
@@ -12864,6 +12864,19 @@ TreeTransform::TransformCXXNewExpr(CXXNewExpr *E) { ArraySize = NewArraySize.get(); } + // Per C++0x [expr.new]p5, the type being constructed may be a + // typedef of an array type. + QualType AllocType = AllocTypeInfo->getType(); + if (Arra

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-19 Thread Erich Keane via cfe-commits
@@ -12864,6 +12864,19 @@ TreeTransform::TransformCXXNewExpr(CXXNewExpr *E) { ArraySize = NewArraySize.get(); } + // Per C++0x [expr.new]p5, the type being constructed may be a + // typedef of an array type. + QualType AllocType = AllocTypeInfo->getType(); + if (Arra

[clang] [polly] [clang-format] Correctly annotate braces in macros (PR #87953)

2024-04-19 Thread Tom Stellard via cfe-commits
tstellar wrote: @owenca Is there a PR for the cherry-pick ? https://github.com/llvm/llvm-project/pull/87953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix stores through label locations (PR #89265)

2024-04-19 Thread Balazs Benics via cfe-commits
@@ -2358,11 +2358,12 @@ StoreRef RegionStoreManager::killBinding(Store ST, Loc L) { RegionBindingsRef RegionStoreManager::bind(RegionBindingsConstRef B, Loc L, SVal V) { - if (L.getAs()) + // We only care about region locations. + auto MemRegVal = L.getAs(); + if (!MemReg

[clang] [analyzer] Fix stores through label locations (PR #89265)

2024-04-19 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/89265 >From 50964bf4f694ae21c2ba86b648b241b335e5d6e8 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Thu, 18 Apr 2024 18:36:29 +0200 Subject: [PATCH 1/2] [analyzer] Fix stores through label locations Interestingly

[clang] [analyzer] Fix stores through label locations (PR #89265)

2024-04-19 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/89265 >From 50964bf4f694ae21c2ba86b648b241b335e5d6e8 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Thu, 18 Apr 2024 18:36:29 +0200 Subject: [PATCH 1/2] [analyzer] Fix stores through label locations Interestingly

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-19 Thread via cfe-commits
@@ -12864,6 +12864,19 @@ TreeTransform::TransformCXXNewExpr(CXXNewExpr *E) { ArraySize = NewArraySize.get(); } + // Per C++0x [expr.new]p5, the type being constructed may be a + // typedef of an array type. + QualType AllocType = AllocTypeInfo->getType(); + if (Arra

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-19 Thread Erich Keane via cfe-commits
@@ -0,0 +1,23 @@ +// RUN: %clang --target=x86_64-pc-linux -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s + +namespace std { erichkeane wrote: Tests STILL haven't changed from the original patch. Please add the regression to this test as well. h

[clang] [clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (PR #89031)

2024-04-19 Thread Jonas Hahnfeld via cfe-commits
@@ -224,11 +228,8 @@ IncrementalParser::IncrementalParser(Interpreter &Interp, return; // PTU.takeError(); } - if (CodeGenerator *CG = getCodeGen()) { -std::unique_ptr M(CG->ReleaseModule()); -CG->StartModule("incr_module_" + std::to_string(P

  1   2   3   4   >