nikic wrote: Isn't the warning about a mismatch between declaration and definition, not call args? The InstCombine change does make the definition and declaration match.
On Fri, Apr 19, 2024, at 17:07, Mehdi Amini wrote: > > > ***@***.**** commented on this pull request. > > > In llvm/lib/Transforms/InstCombine/InstCombineInternal.h > <https://github.com/llvm/llvm-project/pull/89294#discussion_r1571996570>: > > > @@ -433,7 +433,7 @@ class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final > Value *foldAndOrOfICmpsOfAndWithPow2(ICmpInst *LHS, ICmpInst *RHS, > Instruction *CxtI, bool IsAnd, > bool IsLogical = false); > - Value *matchSelectFromAndOr(Value *A, Value *B, Value *C, Value *D, > > You could fix the warning by using vastly different names for the function > parameters? > > > — > Reply to this email directly, view it on GitHub > <https://github.com/llvm/llvm-project/pull/89294#discussion_r1571996570>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABUYEAZJZLPIULGGF2GY3TY6DGDPAVCNFSM6AAAAABGN5RRXWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJQG44TSNJQGY>. > You are receiving this because your review was requested.Message ID: > ***@***.***> > https://github.com/llvm/llvm-project/pull/89294 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
