[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-15 Thread Mike Weller via cfe-commits
https://github.com/MikeWeller updated https://github.com/llvm/llvm-project/pull/88138 >From 4cb9527430d3c7f9acc518427a29eae0aa7e00d1 Mon Sep 17 00:00:00 2001 From: Mike Weller Date: Tue, 9 Apr 2024 16:03:31 +0100 Subject: [PATCH 1/2] [clang-tidy] Ignore delete ctor in `bugprone-forwarding-refe

[clang] [clang][Sema] Preserve the initializer of invalid VarDecls (PR #88645)

2024-04-15 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/88645 >From 07424d8ee99fc418d071960bbdd4185564025139 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Sun, 14 Apr 2024 02:41:48 -0400 Subject: [PATCH] [clang][Sema] Preserve the initializer of invalid VarDecls

[clang] [clang][Sema] Preserve the initializer of invalid VarDecls (PR #88645)

2024-04-15 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > I added a new test case. However, the patch currently fails two existing test > cases: > > Clang :: Parser/cxx-class.cpp > Clang :: SemaCXX/cxx1z-init-statement.cpp > > I will leave the PR as a Draft while I investigate these failures. The latest version of the patch f

[clang] [clang][Sema] Preserve the initializer of invalid VarDecls (PR #88645)

2024-04-15 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 ready_for_review https://github.com/llvm/llvm-project/pull/88645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-15 Thread Mike Weller via cfe-commits
https://github.com/MikeWeller updated https://github.com/llvm/llvm-project/pull/88138 >From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001 From: Mike Weller Date: Tue, 9 Apr 2024 16:03:31 +0100 Subject: [PATCH] [clang-tidy] Ignore delete ctor in `bugprone-forwarding-referenc

[clang] [clang][Sema] Preserve the initializer of invalid VarDecls (PR #88645)

2024-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nathan Ridge (HighCommander4) Changes Fixes https://github.com/clangd/clangd/issues/1821 --- Full diff: https://github.com/llvm/llvm-project/pull/88645.diff 3 Files Affected: - (modified) clang/lib/Sema/JumpDiagnostics.cpp (+2-1) - (mo

[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-15 Thread Mike Weller via cfe-commits
MikeWeller wrote: Given the small size of the change I just did a rebase and force push to resolve conflicts with the release notes. https://github.com/llvm/llvm-project/pull/88138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [clang][Sema] Preserve the initializer of invalid VarDecls (PR #88645)

2024-04-15 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9617da88ab961145047076c45bb2bb1ac4513634 07424d8ee99fc418d071960bbdd4185564025139 --

[clang] [clang][Sema] Preserve the initializer of invalid VarDecls (PR #88645)

2024-04-15 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/88645 >From b43d8ddf8846db8a77d01c9fb2d246a0d0ba2ab2 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Sun, 14 Apr 2024 02:41:48 -0400 Subject: [PATCH] [clang][Sema] Preserve the initializer of invalid VarDecls

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-15 Thread Timm Baeder via cfe-commits
@@ -423,6 +423,10 @@ Bug Fixes in This Version - Fixed a regression in CTAD that a friend declaration that befriends itself may cause incorrect constraint substitution. (#GH86769). +- Clang now allowed the value of unroll count to be zero in ``#pragma GCC unroll`` and ``#p

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/86912 >From 8e07cbdd0f348484d532d7827e4b4a7888e70978 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Mon, 18 Mar 2024 08:36:55 +0800 Subject: [PATCH 1/2] [Modules] No transitive source location change --- clang/in

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -149,14 +157,44 @@ class SourceLocationSequence::State { operator SourceLocationSequence *() { return &Seq; } }; -inline uint64_t SourceLocationEncoding::encode(SourceLocation Loc, - SourceLocationSequence *Seq) { - return Se

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -942,6 +942,12 @@ class ASTReader /// Sema tracks these to emit deferred diags. llvm::SmallSetVector DeclsToCheckForDeferredDiags; + /// The module files imported by different module files. Indirectly imported + /// module files are included too. The information comes

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -5574,10 +5577,34 @@ void ASTWriter::AddFileID(FileID FID, RecordDataImpl &Record) { Record.push_back(getAdjustedFileID(FID).getOpaqueValue()); } +SourceLocationEncoding::RawLocEncoding +ASTWriter::getRawSourceLocationEncoding(SourceLocation Loc, LocSeq *Seq) { + unsign

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -2220,40 +2227,47 @@ class ASTReader return Sema::AlignPackInfo::getFromRawEncoding(Raw); } + using RawLocEncoding = SourceLocationEncoding::RawLocEncoding; + /// Read a source location from raw form and return it in its /// originating module file's source loc

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -696,7 +696,7 @@ class ASTReader /// Mapping from global submodule IDs to the module file in which the /// submodule resides along with the offset that should be added to the /// global submodule ID to produce a local ID. - GlobalSubmoduleMapType GlobalSubmoduleMap; +

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/86912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -149,14 +157,44 @@ class SourceLocationSequence::State { operator SourceLocationSequence *() { return &Seq; } }; -inline uint64_t SourceLocationEncoding::encode(SourceLocation Loc, - SourceLocationSequence *Seq) { - return Se

[clang] [clang-tools-extra] [clang analysis] ExprMutationAnalyzer avoid infinite recursion for recursive forwarding reference (PR #87954)

2024-04-15 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/87954 >From 19f66851204547232d586288fba79d8770837350 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 8 Apr 2024 09:20:58 +0800 Subject: [PATCH 1/4] [clang analysis] ExprMutationAnalyzer support recursive fo

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -149,14 +157,44 @@ class SourceLocationSequence::State { operator SourceLocationSequence *() { return &Seq; } }; -inline uint64_t SourceLocationEncoding::encode(SourceLocation Loc, - SourceLocationSequence *Seq) { - return Se

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -2220,40 +2227,47 @@ class ASTReader return Sema::AlignPackInfo::getFromRawEncoding(Raw); } + using RawLocEncoding = SourceLocationEncoding::RawLocEncoding; + /// Read a source location from raw form and return it in its /// originating module file's source loc

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -4078,8 +4065,8 @@ void ASTReader::ReadModuleOffsetMap(ModuleFile &F) const { return; ChuanqiXu9 wrote: Done. https://github.com/llvm/llvm-project/pull/86912 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -2220,40 +2227,47 @@ class ASTReader return Sema::AlignPackInfo::getFromRawEncoding(Raw); } + using RawLocEncoding = SourceLocationEncoding::RawLocEncoding; + /// Read a source location from raw form and return it in its /// originating module file's source loc

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
@@ -2220,40 +2227,47 @@ class ASTReader return Sema::AlignPackInfo::getFromRawEncoding(Raw); } + using RawLocEncoding = SourceLocationEncoding::RawLocEncoding; + /// Read a source location from raw form and return it in its /// originating module file's source loc

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-15 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > I have a few minor comments on the patch. I want to do some additional perf > testing on module scanning perf because I'm a bit concerned about the cost of > `ASTWriter::getRawSourceLocationEncoding`. What's the perf results about scanning? https://github.com/llvm/llvm-pro

[clang-tools-extra] [clang-tidy][NFC] Fix `linuxkernel-must-check-errs` documentation file name (PR #88655)

2024-04-15 Thread Piotr Zegar via cfe-commits
@@ -299,6 +299,10 @@ Miscellaneous ``--format`` option is specified. Now :program:`clang-apply-replacements` applies formatting only with the option. +- Fixed the :doc:`linuxkernel-must-check-errs + ` documentation to consistently + use the check's proper name.

[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-15 Thread Piotr Zegar via cfe-commits
@@ -102,6 +102,7 @@ Improvements to clang-tidy similar fashion to what `-header-filter` does for header files. - Improved :program:`check_clang_tidy.py` script. Added argument `-export-fixes` to aid in clang-tidy and test development. +- Fixed an issue with `bugprone-forwa

[clang] [analyzer] Handle builtin functions in MallocChecker (PR #88416)

2024-04-15 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/88416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add intrinsics for 16-bit non-widening FMLA/FMLS (PR #88553)

2024-04-15 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/88553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] aa27414 - Revert "[C++20] [Modules] Don't import non-inline function bodies even if it is marked as always_inline"

2024-04-15 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-04-15T17:06:03+08:00 New Revision: aa2741449c3609b2ae244d8d3f3e14ad16de72e4 URL: https://github.com/llvm/llvm-project/commit/aa2741449c3609b2ae244d8d3f3e14ad16de72e4 DIFF: https://github.com/llvm/llvm-project/commit/aa2741449c3609b2ae244d8d3f3e14ad16de72e4.diff LO

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-15 Thread via cfe-commits
martinboehme wrote: DataflowAnalysisContext.h is starting to accumulate more and more functions that serve to extract various types of information from the AST; these aren't really related to the `DataflowAnalysisContext`, so I wonder if it's time to separate these out into their own header an

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-15 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/88534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-15 Thread via cfe-commits
https://github.com/martinboehme requested changes to this pull request. https://github.com/llvm/llvm-project/pull/88534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-15 Thread via cfe-commits
@@ -62,6 +62,52 @@ FieldSet getObjectFields(QualType Type); bool containsSameFields(const FieldSet &Fields, const RecordStorageLocation::FieldToLoc &FieldLocs); +/// Returns the fields of a `RecordDecl` that are initialized by an +/// `InitListExpr`, in

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-15 Thread via cfe-commits
@@ -62,6 +62,52 @@ FieldSet getObjectFields(QualType Type); bool containsSameFields(const FieldSet &Fields, const RecordStorageLocation::FieldToLoc &FieldLocs); +/// Returns the fields of a `RecordDecl` that are initialized by an +/// `InitListExpr`, in

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-15 Thread via cfe-commits
@@ -62,6 +62,52 @@ FieldSet getObjectFields(QualType Type); bool containsSameFields(const FieldSet &Fields, const RecordStorageLocation::FieldToLoc &FieldLocs); +/// Returns the fields of a `RecordDecl` that are initialized by an +/// `InitListExpr`, in

[clang] [clang-tools-extra] [codegen] Emit missing cleanups when an expression contains a branch (PR #80698)

2024-04-15 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Alternate patch https://github.com/llvm/llvm-project/commit/89ba7e183e6e2c64370ed1b963e54c06352211db has landed. Closing this as obsolete. https://github.com/llvm/llvm-project/pull/80698 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [clang-tools-extra] [codegen] Emit missing cleanups when an expression contains a branch (PR #80698)

2024-04-15 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/80698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Coro destruct temporary ehcleanup (PR #83224)

2024-04-15 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/83224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use pushFullExprCleanup for deferred destroy (PR #88670)

2024-04-15 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: This fix is for a wrong refactoring change in https://github.com/llvm/llvm-project/commit/89ba7e183e6e2c64370ed1b963e54c06352211db and I would be inclined towards landing this in a few hours to unblock the build breakage (if there are no review comments). CC: @efriedma-quic htt

[clang] Use pushFullExprCleanup for deferred destroy (PR #88670)

2024-04-15 Thread via cfe-commits
cor3ntin wrote: @usx95 Could you maybe reduce a test from the crash? Thanks! https://github.com/llvm/llvm-project/pull/88670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Move tailclipping to bitfield allocation (PR #87090)

2024-04-15 Thread Nathan Sidwell via cfe-commits
urnathan wrote: @rjmccall can you take a look at this? as the description says, this turns out to not be NFC, but important on (probably only) LP64 machines. https://github.com/llvm/llvm-project/pull/87090 ___ cfe-commits mailing list cfe-commits@list

[clang] [llvm] [CLANG][LLVM][AArch64]SME2.1 intrinsics for MOVAZ tile to 2/4 vectors (PR #88710)

2024-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir @llvm/pr-subscribers-backend-aarch64 Author: None (CarolineConcatto) Changes According to the specification in ARM-software/acle#309 this adds the intrinsics // Variants are also available for _za8_u8, _za16_s16, _za16_u16, // _za16_f16, _za16_

[clang] [ARM64EC] Fix arm_neon.h on ARM64EC. (PR #88572)

2024-04-15 Thread Jacek Caban via cfe-commits
https://github.com/cjacek approved this pull request. https://github.com/llvm/llvm-project/pull/88572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix high memory consumption during pack deduction (PR #88637)

2024-04-15 Thread via cfe-commits
@@ -831,7 +831,7 @@ class PackDeductionScope { if (IsPartiallyExpanded) PackElements += NumPartialPackArgs; else if (IsExpanded) - PackElements += *FixedNumExpansions; + PackElements += FixedNumExpansions.value_or(1); Sirraide wrote: >

[clang] [analyzer] Harden security.cert.env.InvalidPtr checker fn matching (PR #88536)

2024-04-15 Thread via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM, thanks for introducing `CDM::CLibrary` in this checker. However, for the backporting note that this commit depends on two recently added commits: [1] https://github.com/llvm/llvm-project/pull/83432 -- this introduces `CDM::CLibrary

[clang] [analyzer] Harden security.cert.env.InvalidPtr checker fn matching (PR #88536)

2024-04-15 Thread via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/88536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

2024-04-15 Thread Jonathan Schleifer via cfe-commits
https://github.com/Midar created https://github.com/llvm/llvm-project/pull/88713 The other places all use the underscore. This is just a quick drive-by commit, LMK if more is needed. >From e39e2fc218c588d66937211f98a25eb2acf00a6b Mon Sep 17 00:00:00 2001 From: Jonathan Schleifer Date: Mon, 15

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

2024-04-15 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

2024-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jonathan Schleifer (Midar) Changes The other places all use the underscore. This is just a quick drive-by commit, LMK if more is needed. --- Full diff: https://github.com/llvm/llvm-project/pull/88713.diff 1 Files Affected: - (modified)

[clang] 8095b9c - [clang analysis] ExprMutationAnalyzer avoid infinite recursion for recursive forwarding reference (#87954)

2024-04-15 Thread via cfe-commits
Author: Congcong Cai Date: 2024-04-15T19:38:50+08:00 New Revision: 8095b9ce6bf5831a14c72028920708f38d13d0c3 URL: https://github.com/llvm/llvm-project/commit/8095b9ce6bf5831a14c72028920708f38d13d0c3 DIFF: https://github.com/llvm/llvm-project/commit/8095b9ce6bf5831a14c72028920708f38d13d0c3.diff

[clang] [clang-tools-extra] [clang analysis] ExprMutationAnalyzer avoid infinite recursion for recursive forwarding reference (PR #87954)

2024-04-15 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/87954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

2024-04-15 Thread Jonathan Schleifer via cfe-commits
https://github.com/Midar updated https://github.com/llvm/llvm-project/pull/88713 >From 8dc7333c0e9c757bba91ebfbe57280ad0635afa9 Mon Sep 17 00:00:00 2001 From: Jonathan Schleifer Date: Mon, 15 Apr 2024 13:36:05 +0200 Subject: [PATCH] Fix objc_sel_{name,types} missing an underscore The other plac

[clang] [clang-repl] Set up executor implicitly to account for init PTUs (PR #84758)

2024-04-15 Thread Jonas Hahnfeld via cfe-commits
Stefan =?utf-8?q?Gr=C3=A4nitz?= Message-ID: In-Reply-To: @@ -14,7 +14,7 @@ struct A { int a; A(int a) : a(a) {} virtual ~A(); }; // PartialTranslationUnit. inline A::~A() { printf("~A(%d)\n", a); } -// Create one instance with new and delete it. +// Create one instance with

[clang] Use pushFullExprCleanup for deferred destroy (PR #88670)

2024-04-15 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/88670 >From 599283c1845a25afe90163a5f0a7a809c622a521 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sun, 14 Apr 2024 21:21:21 + Subject: [PATCH 1/2] Use pushFullExprCleanup for deferred destroy --- clang/lib/Co

[clang] Use pushFullExprCleanup for deferred destroy (PR #88670)

2024-04-15 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: @cor3ntin Added tests for crash. https://github.com/llvm/llvm-project/pull/88670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Add AS for Globals to SPIR & SPIRV datalayouts (PR #88455)

2024-04-15 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts approved this pull request. https://github.com/llvm/llvm-project/pull/88455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIRV] Add any intrinsic lowering (PR #88325)

2024-04-15 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts approved this pull request. https://github.com/llvm/llvm-project/pull/88325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use pushFullExprCleanup for deferred destroy (PR #88670)

2024-04-15 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/88670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix result object location for builtin `<=>`. (PR #88726)

2024-04-15 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/88726 The newly added test causes an assertion failure in `PropagateResultObject()` without the fix added here. >From ffdde99a773e732fbc484a5f7647d78d1f15954e Mon Sep 17 00:00:00 2001 From: Martin Braenne Date:

[clang] [clang][dataflow] Fix result object location for builtin `<=>`. (PR #88726)

2024-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes The newly added test causes an assertion failure in `PropagateResultObject()` without the fix added here. --- Full diff: https://github.com/llvm/llvm-project/pull/88726.diff 2 Files Affected: - (mod

[clang] [clang][dataflow] Fix result object location for builtin `<=>`. (PR #88726)

2024-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes The newly added test causes an assertion failure in `PropagateResultObject()` without the fix added here. --- Full diff: https://github.com/llvm/llvm-project/pull/88726.diff 2 Files Affected: - (modified) cl

[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-15 Thread Mike Weller via cfe-commits
https://github.com/MikeWeller updated https://github.com/llvm/llvm-project/pull/88138 >From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001 From: Mike Weller Date: Tue, 9 Apr 2024 16:03:31 +0100 Subject: [PATCH 1/2] [clang-tidy] Ignore delete ctor in `bugprone-forwarding-refe

[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-15 Thread Mike Weller via cfe-commits
MikeWeller wrote: @PiotrZSL apologies, have put it in the correct location. Is there a way to preview/check the `:doc:` thing? I assume there is some kind of preprocessor/tool step for this? I copied what the rest are doing and put the appropriate section of the https://clang.llvm.org/extra/c

[clang] [clang] fix -Wnullability-completeness false-positive in dependent code (PR #88727)

2024-04-15 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall created https://github.com/llvm/llvm-project/pull/88727 The intent was that smart-pointers do not participate in completeness checks, but we failed to capture dependent `unique_ptr`, which is not a RecordType but a TemplateSpecializationType. >From f1bea480b599b43

[clang] [clang] fix -Wnullability-completeness false-positive in dependent code (PR #88727)

2024-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sam McCall (sam-mccall) Changes The intent was that smart-pointers do not participate in completeness checks, but we failed to capture dependent `unique_ptr`, which is not a RecordType but a TemplateSpecializationType. --- Full diff: h

[clang] [llvm] [ValueTracking] Convert `isKnownNonZero` to use SimplifyQuery (PR #85863)

2024-04-15 Thread Harald van Dijk via cfe-commits
@@ -645,7 +645,7 @@ LazyValueInfoImpl::solveBlockValueImpl(Value *Val, BasicBlock *BB) { // instruction is placed, even if it could legally be hoisted much higher. // That is unfortunate. PointerType *PT = dyn_cast(BBI->getType()); - if (PT && isKnownNonZero(BBI, DL)) +

[clang-tools-extra] [clangd] Propagate context into stdlib indexing thread (PR #87611)

2024-04-15 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall commented: I'm iffy on whether this is semantically right or not, but we need to solve this problem somehow, so let's try the most obvious way. https://github.com/llvm/llvm-project/pull/87611 ___ cfe-commits mailing list

[clang-tools-extra] [clangd] Propagate context into stdlib indexing thread (PR #87611)

2024-04-15 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/87611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Propagate context into stdlib indexing thread (PR #87611)

2024-04-15 Thread Sam McCall via cfe-commits
@@ -112,7 +112,10 @@ struct UpdateIndexCallbacks : public ParsingCallbacks { // Index outlives TUScheduler (declared first) FIndex(FIndex), // shared_ptr extends lifetime - Stdlib(Stdlib)]() mutable { +

[clang] [PATCH] [clang-repl] Builtin Type printing in ValuePrinter.cpp (PR #88729)

2024-04-15 Thread via cfe-commits
https://github.com/wlonestar created https://github.com/llvm/llvm-project/pull/88729 None >From c953691de3eda4b72e16d215a6a0e5d230742c59 Mon Sep 17 00:00:00 2001 From: wlonestar <68649094+wlones...@users.noreply.github.com> Date: Mon, 15 Apr 2024 13:12:55 + Subject: [PATCH] [PATCH] [clang-r

[clang] [PATCH] [clang-repl] Builtin Type printing in ValuePrinter.cpp (PR #88729)

2024-04-15 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-15 Thread Michael Buch via cfe-commits
@@ -5361,7 +5383,56 @@ static bool IsReconstitutableType(QualType QT) { return T.Reconstitutable; } -std::string CGDebugInfo::GetName(const Decl *D, bool Qualified) const { +bool CGDebugInfo::HasReconstitutableArgs( +ArrayRef Args) const { + return llvm::all_of(Args, [&

[clang] [PATCH] [clang-repl] Builtin Type printing in ValuePrinter.cpp (PR #88729)

2024-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: wlonestar (wlonestar) Changes --- Patch is 27.57 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/88729.diff 9 Files Affected: - (modified) clang/include/clang/Interpreter/Interpreter.h (+2)

[clang] [AST][RecoveryExpr] Fix a crash on c89/c90 invalid InitListExpr (#88008) (PR #88014)

2024-04-15 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/88014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST][RecoveryExpr] Fix a crash on c89/c90 invalid InitListExpr (#88008) (PR #88014)

2024-04-15 Thread Sam McCall via cfe-commits
@@ -3391,7 +3391,7 @@ class Sema final : public SemaBase { bool ConstexprSupported, bool CLinkageMayDiffer); /// type checking declaration initializers (C99 6.7.8) - bool CheckForConstantInitializer(Expr *e, QualType t); + bool CheckForConstantInitializer(Expr *Init,

[clang] [AST][RecoveryExpr] Fix a crash on c89/c90 invalid InitListExpr (#88008) (PR #88014)

2024-04-15 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall approved this pull request. Thanks, this looks like the right fix, and cleaning up DclT while here makes sense. https://github.com/llvm/llvm-project/pull/88014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] Reapply "[Clang][Sema] Fix crash when 'this' is used in a dependent class scope function template specialization that instantiates to a static member function (#87541, #88311)" (PR #88731)

2024-04-15 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/88731 Reapplies #87541 and #88311 (again) addressing the bug which caused expressions naming overload sets to be incorrectly rebuilt, as well as the bug which caused base class members to always be treated as overl

[clang] Reapply "[Clang][Sema] Fix crash when 'this' is used in a dependent class scope function template specialization that instantiates to a static member function (#87541, #88311)" (PR #88731)

2024-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-coroutines Author: Krystian Stasiowski (sdkrystian) Changes Reapplies #87541 and #88311 (again) addressing the bug which caused expressions naming overload sets to be incorrectly rebuilt, as well as the bug which caused base

[clang] Reapply "[Clang][Sema] Fix crash when 'this' is used in a dependent class scope function template specialization that instantiates to a static member function (#87541, #88311)" (PR #88731)

2024-04-15 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/88731 >From 02d98a20ad2214c928d6ffcc7f54abe1172a2407 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 15 Apr 2024 09:17:39 -0400 Subject: [PATCH] Reapply "[Clang][Sema] Fix crash when 'this' is used in

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-15 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/88666 >From 8d48a0bd1cf15b9cf00bc294912b674b5f94a11c Mon Sep 17 00:00:00 2001 From: yronglin Date: Mon, 15 Apr 2024 00:36:06 +0800 Subject: [PATCH 1/3] [Clang] Allow the value of unroll count to be zero in '#pragma

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-15 Thread via cfe-commits
@@ -423,6 +423,10 @@ Bug Fixes in This Version - Fixed a regression in CTAD that a friend declaration that befriends itself may cause incorrect constraint substitution. (#GH86769). +- Clang now allowed the value of unroll count to be zero in ``#pragma GCC unroll`` and ``#p

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-15 Thread via cfe-commits
yronglin wrote: Thanks for your review! @Endilll @tbaederr https://github.com/llvm/llvm-project/pull/88666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PATCH] [clang-repl] Builtin Type printing in ValuePrinter.cpp (PR #88729)

2024-04-15 Thread via cfe-commits
https://github.com/wlonestar updated https://github.com/llvm/llvm-project/pull/88729 >From c953691de3eda4b72e16d215a6a0e5d230742c59 Mon Sep 17 00:00:00 2001 From: wlonestar <68649094+wlones...@users.noreply.github.com> Date: Mon, 15 Apr 2024 13:12:55 + Subject: [PATCH] [PATCH] [clang-repl] B

[clang] [clang-repl] Set up executor implicitly to account for init PTUs (PR #84758)

2024-04-15 Thread Vassil Vassilev via cfe-commits
Stefan =?utf-8?q?Gr=C3=A4nitz?= Message-ID: In-Reply-To: @@ -14,7 +14,7 @@ struct A { int a; A(int a) : a(a) {} virtual ~A(); }; // PartialTranslationUnit. inline A::~A() { printf("~A(%d)\n", a); } -// Create one instance with new and delete it. +// Create one instance with

[clang-tools-extra] [clangd] Remove potential prefix from enum value names (PR #83412)

2024-04-15 Thread Julian Schmidt via cfe-commits
@@ -125,25 +123,42 @@ llvm::Error ScopifyEnum::addClassKeywordToDeclarations() { } llvm::Error ScopifyEnum::scopifyEnumValues() { - std::string PrefixToInsert(D->getName()); - PrefixToInsert += "::"; + StringRef EnumName(D->getName()); + bool StripPrefix = true; + for (au

[clang-tools-extra] [clangd] Remove potential prefix from enum value names (PR #83412)

2024-04-15 Thread Julian Schmidt via cfe-commits
@@ -125,25 +123,42 @@ llvm::Error ScopifyEnum::addClassKeywordToDeclarations() { } llvm::Error ScopifyEnum::scopifyEnumValues() { - std::string PrefixToInsert(D->getName()); - PrefixToInsert += "::"; + StringRef EnumName(D->getName()); + bool StripPrefix = true; + for (au

[clang-tools-extra] [clangd] Remove potential prefix from enum value names (PR #83412)

2024-04-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: I think this change could use a release note in the docs, could you please add one? https://github.com/llvm/llvm-project/pull/83412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang-tools-extra] [clangd] Remove potential prefix from enum value names (PR #83412)

2024-04-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/83412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Refactor how NamedDecl are renamed (PR #88735)

2024-04-15 Thread Edwin Vane via cfe-commits
https://github.com/revane created https://github.com/llvm/llvm-project/pull/88735 The handling of renaming failures and multiple usages related to those failures is currently spread over several functions. Identifying the failure NamedDecl for a given usage is also duplicated, once when creati

[clang-tools-extra] [clang-tidy] Refactor how NamedDecl are renamed (PR #88735)

2024-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Edwin Vane (revane) Changes The handling of renaming failures and multiple usages related to those failures is currently spread over several functions. Identifying the failure NamedDecl for a gi

[clang] [PATCH] [clang-repl] Builtin Type printing in ValuePrinter.cpp (PR #88729)

2024-04-15 Thread via cfe-commits
https://github.com/wlonestar updated https://github.com/llvm/llvm-project/pull/88729 >From c953691de3eda4b72e16d215a6a0e5d230742c59 Mon Sep 17 00:00:00 2001 From: wlonestar <68649094+wlones...@users.noreply.github.com> Date: Mon, 15 Apr 2024 13:12:55 + Subject: [PATCH 1/2] [PATCH] [clang-rep

[clang] [X86][test] Added extra cet tests (PR #88736)

2024-04-15 Thread Isha Agarwal via cfe-commits
https://github.com/iagarwa created https://github.com/llvm/llvm-project/pull/88736 Updated cet test to: -Check different modules based on different cet options -Added negative tests also >From 2ee7dd40b0f2c4eed6d8631d60a31372785a2d6e Mon Sep 17 00:00:00 2001 From: Isha Agarwal Date: Mon, 15 Ap

[clang-tools-extra] [clang-tidy] Refactor how NamedDecl are renamed (PR #88735)

2024-04-15 Thread Edwin Vane via cfe-commits
revane wrote: @PiotrZSL Second-last in the sequence of PRs which fix another renaming issue. https://github.com/llvm/llvm-project/pull/88735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [X86][test] Added extra cet tests (PR #88736)

2024-04-15 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [X86][test] Added extra cet tests (PR #88736)

2024-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-x86 Author: Isha Agarwal (iagarwa) Changes Updated cet test to: -Check different modules based on different cet options -Added negative tests also --- Full diff: https://github.com/llvm/llvm-project/pull/88736.diff 1

[clang] [clang][dataflow] Fix result object location for builtin `<=>`. (PR #88726)

2024-04-15 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/88726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix result object location for builtin `<=>`. (PR #88726)

2024-04-15 Thread Yitzhak Mandelbaum via cfe-commits
@@ -508,6 +508,11 @@ class ResultObjectVisitor : public RecursiveASTVisitor { isa(E)) { return; } +if (auto *Op = dyn_cast(E); ymand wrote: aside: Might lines 506 through 553 be better expressed as a switch on `E->getStmtClass()`? http

[clang] [clang][dataflow] Fix result object location for builtin `<=>`. (PR #88726)

2024-04-15 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/88726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-15 Thread Erich Keane via cfe-commits
@@ -3903,7 +3904,14 @@ bool Sema::CheckLoopHintExpr(Expr *E, SourceLocation Loc) { if (R.isInvalid()) return true; - bool ValueIsPositive = ValueAPS.isStrictlyPositive(); + // GCC allows the value of unroll count to be 0. + // https://gcc.gnu.org/onlinedocs/gcc/Loop-

  1   2   3   4   5   >