https://github.com/NagyDonat approved this pull request.

LGTM, thanks for introducing `CDM::CLibrary` in this checker.

However, for the backporting note that this commit depends on two recently 
added commits:
[1] https://github.com/llvm/llvm-project/pull/83432 -- this introduces 
`CDM::CLibrary`
[2] https://github.com/llvm/llvm-project/pull/85791 -- ensures that e.g. 
`std::asctime` is matched by this checker

There were two other related commits, but as far as I understand this commit 
would work without them:
[3] https://github.com/llvm/llvm-project/pull/86536 -- ensures that 
`CDM::CLibrary` doesn't match calls that have more arguments than the expected 
amount
[4] https://github.com/llvm/llvm-project/pull/87764 -- trivial NFC fix of 
buildbot failures caused by [3] 

https://github.com/llvm/llvm-project/pull/88536
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to