[clang] [clang] Fix crash when declaring invalid lambda member (PR #74110)

2024-03-04 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman Thanks for the review. Sorry for responding so late - I've > missed your review. > > The tests aren't actually unrelated to the path. This is the file where I > discovered the crash, so I just used it to demonstrate that it's fixed. I'm > not sure how to sp

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-03-04 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov updated https://github.com/llvm/llvm-project/pull/79842 >From af323998a63a72f569d543cf5167d5d28e784682 Mon Sep 17 00:00:00 2001 From: Dinar Temirbulatov Date: Mon, 29 Jan 2024 14:43:13 + Subject: [PATCH 1/8] [Clang][AArch64] Warn when calling streaming/non-

[clang] [clang] Fix crash when declaring invalid lambda member (PR #74110)

2024-03-04 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. There's a minor nit with a comment in the test file where the comment should be updated, and the changes need a release note. Otherwise, LGTM https://github.com/llvm/llvm-project/pull/74110 _

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-03-04 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/79683 >From 7d05842505dbcabcc54cb365006c794ab9371983 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 16 Jan 2024 08:05:33 -0500 Subject: [PATCH] Reapply "[Clang][Sema] Diagnose function/variable templa

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/83611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/83611 >From 8152ad56b320719553701edf020c30aea8c3213e Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 1 Mar 2024 11:36:14 -0800 Subject: [PATCH 1/3] Fix null-deref thanks to an attribute on a global declarator

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-03-04 Thread Sander de Smalen via cfe-commits
@@ -7531,19 +7531,15 @@ void Sema::checkCall(NamedDecl *FDecl, const FunctionProtoType *Proto, // vector lengths may be different. if (CallerFD && Context.getTargetInfo().hasFeature("sme") && !IsBuiltin) { ArmStreamingType CallerFnType = getArmStreamingFnType(Cal

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-03-04 Thread Sander de Smalen via cfe-commits
@@ -7513,6 +7516,36 @@ void Sema::checkCall(NamedDecl *FDecl, const FunctionProtoType *Proto, } } +auto *CallerFD = dyn_cast(CurContext); +bool IsCalleeStreaming = +(ExtInfo.AArch64SMEAttributes & FunctionType::SME_PStateSMEnabledMask); +bool IsC

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/83611 >From 8152ad56b320719553701edf020c30aea8c3213e Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 1 Mar 2024 11:36:14 -0800 Subject: [PATCH 1/3] Fix null-deref thanks to an attribute on a global declarator

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-04 Thread Erich Keane via cfe-commits
erichkeane wrote: > Note to self when I get back to work: Both done now! https://github.com/llvm/llvm-project/pull/83611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1e429ff - [Clang][Docs] Fix issue number

2024-03-04 Thread via cfe-commits
Author: cor3ntin Date: 2024-03-04T15:16:46+01:00 New Revision: 1e429ff1439e0b26f4299faa8a29ed1947743fa3 URL: https://github.com/llvm/llvm-project/commit/1e429ff1439e0b26f4299faa8a29ed1947743fa3 DIFF: https://github.com/llvm/llvm-project/commit/1e429ff1439e0b26f4299faa8a29ed1947743fa3.diff LOG:

[clang] c1d8d0a - Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (#79683)

2024-03-04 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-03-04T09:18:21-05:00 New Revision: c1d8d0aa156f651ee48414fa002e9608d6998763 URL: https://github.com/llvm/llvm-project/commit/c1d8d0aa156f651ee48414fa002e9608d6998763 DIFF: https://github.com/llvm/llvm-project/commit/c1d8d0aa156f651ee48414fa002e9608d6998763

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-03-04 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/79683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] bugprone-unused-return-value config now supports regexes (PR #82952)

2024-03-04 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/82952 From 86bc8a57fd56a6b2593af8bcf85d50bbc0ce984e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 25 Feb 2024 22:05:08 -0500 Subject: [PATCH 1/2] [clang-tidy] bugprone-unused-r

[clang-tools-extra] [clang-tidy] bugprone-unused-return-value config now supports regexes (PR #82952)

2024-03-04 Thread Piotr Zegar via cfe-commits
=?utf-8?q?F=C3=A9lix-Antoine?= Constantin Message-ID: In-Reply-To: PiotrZSL wrote: Rebase, and could be merged. https://github.com/llvm/llvm-project/pull/82952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] bbeb946 - [clang][analyzer] Change value of checker option in unix.StdCLibraryFunctions (second try). (#80457)

2024-03-04 Thread Balázs Kéri via cfe-commits
Author: Balázs Kéri Date: 2024-03-04T15:28:20+01:00 New Revision: bbeb946652f2830b3211dcd8c6836bce4dbdd188 URL: https://github.com/llvm/llvm-project/commit/bbeb946652f2830b3211dcd8c6836bce4dbdd188 DIFF: https://github.com/llvm/llvm-project/commit/bbeb946652f2830b3211dcd8c6836bce4dbdd188.diff L

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-04 Thread Endre Fülöp via cfe-commits
gamesh411 wrote: > > The flag approach can probably make a sense for namespace handling (match > > the exact specified namespace, or allow a prefix before, or even something > > in between). > > Even in that case, I'd prefer a separate second parameter (that's either > boolean or a different

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-04 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 approved this pull request. https://github.com/llvm/llvm-project/pull/83432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-04 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 edited https://github.com/llvm/llvm-project/pull/83432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-04 Thread Endre Fülöp via cfe-commits
@@ -27,20 +27,48 @@ class IdentifierInfo; namespace clang { namespace ento { - -enum CallDescriptionFlags : unsigned { - CDF_None = 0, - - /// Describes a C standard function that is sometimes implemented as a macro - /// that expands to a compiler builtin with some __built

[clang-tools-extra] [clang-tidy] bugprone-unused-return-value config now supports regexes (PR #82952)

2024-03-04 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/82952 From 5e30d84368a05bab31a26c413fdc8092449f4111 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 25 Feb 2024 22:05:08 -0500 Subject: [PATCH 1/2] [clang-tidy] bugprone-unused-r

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-04 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 edited https://github.com/llvm/llvm-project/pull/83432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Allow access to a public template alias declaration that refers to friend's private nested type (PR #83847)

2024-03-04 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/83847 >From 99b66fbb5f4219f225bbf8d01038b875b98f2d45 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Mon, 4 Mar 2024 21:51:07 +0800 Subject: [PATCH] [Clang][Sema] Allow access to a public template alias declaration that r

[clang-tools-extra] [clang-tidy] bugprone-unused-return-value config now supports regexes (PR #82952)

2024-03-04 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/82952 From 00885ea60007a1da88f9d476e14252f950f358a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 25 Feb 2024 22:05:08 -0500 Subject: [PATCH] [clang-tidy] bugprone-unused-retur

[clang-tools-extra] [clang-tidy] bugprone-unused-return-value config now supports regexes (PR #82952)

2024-03-04 Thread Félix-Antoine Constantin via cfe-commits
felix642 wrote: > Rebase, and could be merged. Done, thank you for the quick review. https://github.com/llvm/llvm-project/pull/82952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/83611 >From 8152ad56b320719553701edf020c30aea8c3213e Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 1 Mar 2024 11:36:14 -0800 Subject: [PATCH 1/3] Fix null-deref thanks to an attribute on a global declarator

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-04 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM aside from a tiny commenting nit (take it or leave it). https://github.com/llvm/llvm-project/pull/83611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-04 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/83611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-04 Thread Aaron Ballman via cfe-commits
@@ -734,6 +735,9 @@ class AttributePool { pool.Attrs.clear(); } + /// Take a list of attributes from another pool and add them to this pool. AaronBallman wrote: ```suggestion /// Removes the attributes from \c List, which are owned by \c Pool, and ad

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

2024-03-04 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: Actually, I don't think the proposed fix here is quite right. If we _only_ find an `UnresolvedUsingValueDecl`, then we shouldn't assume the name is a template per [[temp.names] p3.3](http://eel.is/c++draft/temp.names#3.3)... will work on a new fix. https://github.com/llvm/ll

[clang-tools-extra] [clang-tidy] bugprone-unused-return-value config now supports regexes (PR #82952)

2024-03-04 Thread Félix-Antoine Constantin via cfe-commits
felix642 wrote: Nevermind I broke the documentation.. Hold on https://github.com/llvm/llvm-project/pull/82952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-04 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/83611 >From 8152ad56b320719553701edf020c30aea8c3213e Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 1 Mar 2024 11:36:14 -0800 Subject: [PATCH 1/4] Fix null-deref thanks to an attribute on a global declarator

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81418)

2024-03-04 Thread Erich Keane via cfe-commits
erichkeane wrote: > @stbergmann is right. @erichkeane How should I proceed? Should I open a > revert PR? Or should I open a separate issue? For now, unless someone insists, I think we're likely fine to do a follow-up PR to fix that. Make sure to put the same reviewers on, and we'll see if we

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-04 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy ,NagyDonat Message-ID: In-Reply-To: NagyDonat wrote: I picked the somewhat scary name "`Unspecified`" for the "match any kind of call" enumerator because it's too vague for practical use (if a checker wants to match something, it will practically always know if it's a

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-04 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy ,NagyDonat Message-ID: In-Reply-To: @@ -27,20 +27,48 @@ class IdentifierInfo; namespace clang { namespace ento { - -enum CallDescriptionFlags : unsigned { - CDF_None = 0, - - /// Describes a C standard function that is sometimes implemented as a ma

[clang] 52a460f - [analyzer] Refactor CallDescription match mode (NFC) (#83432)

2024-03-04 Thread via cfe-commits
Author: NagyDonat Date: 2024-03-04T15:43:37+01:00 New Revision: 52a460f9d4640ddc04e65161c78958bdabaae2b2 URL: https://github.com/llvm/llvm-project/commit/52a460f9d4640ddc04e65161c78958bdabaae2b2 DIFF: https://github.com/llvm/llvm-project/commit/52a460f9d4640ddc04e65161c78958bdabaae2b2.diff LOG

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-04 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy ,NagyDonat Message-ID: In-Reply-To: https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/83432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang-tools-extra] [clang-tidy] CRTP Constructor Accessibility Check (PR #82403)

2024-03-04 Thread via cfe-commits
isuckatcs wrote: ping @PiotrZSL @whisperity https://github.com/llvm/llvm-project/pull/82403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add some CodeGen tests for CWG 4xx issues (PR #83715)

2024-03-04 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/83715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add some CodeGen tests for CWG 4xx issues (PR #83715)

2024-03-04 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/83715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add some CodeGen tests for CWG 4xx issues (PR #83715)

2024-03-04 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexcept

[clang] [clang] Add some CodeGen tests for CWG 4xx issues (PR #83715)

2024-03-04 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,27 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexcept

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-04 Thread via cfe-commits
Sirraide wrote: > But it sounds like my idea doesn't have legs because of OpenMP specification > requirements. I'm fine with (3) as an approach then. I think a hybrid approach between (3) and what you’re suggesting might make sense: 1. Introduce `[[omp::assume]]` for OpenMP 2. Deprecate `[[cla

[clang-tools-extra] [clang-tidy] CRTP Constructor Accessibility Check (PR #82403)

2024-03-04 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/82403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] CRTP Constructor Accessibility Check (PR #82403)

2024-03-04 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. Overall looks fine, at least fine to be merged. I will try to take a deeper look into particular cases, but even if some changes could be needed, probably better would be to merge this, and push fixes in separate PR. So lest merge this, a

[clang-tools-extra] [clang-tidy] CRTP Constructor Accessibility Check (PR #82403)

2024-03-04 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,182 @@ +//===--- CrtpConstructorAccessibilityCheck.cpp - clang-tidy +//-===// PiotrZSL wrote: This should be in single line https://github.com/llvm/llvm-project/pull/82403 ___

[clang] [OpenMP] Parse and Sema support for declare target in local scope (PR #83223)

2024-03-04 Thread Alexey Bataev via cfe-commits
@@ -11326,6 +11326,8 @@ def err_omp_device_type_mismatch : Error< def err_omp_wrong_device_function_call : Error< "function with 'device_type(%0)' is not available on %select{device|host}1">; def note_omp_marked_device_type_here : Note<"marked as 'device_type(%0)' here">; +d

[clang] Issue #63106: [сlang] Representation of ellipsis in AST (PR #80976)

2024-03-04 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Hi @AaronBallman Can you pls explain me your previous response _"It would be > better for us to associate the data with catch statements specifically > because there's a lot fewer of those than there are variable declarations in > general."_ > > I mean storing the ellips

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Erich Keane via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [clang] Add some CodeGen tests for CWG 4xx issues (PR #83715)

2024-03-04 Thread Erich Keane via cfe-commits
@@ -0,0 +1,24 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexcept

[clang] [clang] Add some CodeGen tests for CWG 4xx issues (PR #83715)

2024-03-04 Thread Erich Keane via cfe-commits
@@ -0,0 +1,27 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexcept

[clang] [clang] Add some CodeGen tests for CWG 4xx issues (PR #83715)

2024-03-04 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,27 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexcept

[clang] [clang] Add some CodeGen tests for CWG 4xx issues (PR #83715)

2024-03-04 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/83715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstallAPI] Collect symbols from ObjC Ivars (PR #83632)

2024-03-04 Thread Juergen Ributzka via cfe-commits
@@ -27,12 +27,40 @@ __attribute__((objc_exception)) @interface Exception @end + +//--- Foo.framework/PrivateHeaders/Foo_Private.h +#import + +@interface ClassWithIvars : Visible { ributzka wrote: ``` @interface ClassWithIvars : Visible { @package int _

[clang-tools-extra] [clang-tidy] bugprone-unused-return-value config now supports regexes (PR #82952)

2024-03-04 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/82952 From 00885ea60007a1da88f9d476e14252f950f358a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 25 Feb 2024 22:05:08 -0500 Subject: [PATCH 1/2] [clang-tidy] bugprone-unused-r

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/83625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Erich Keane via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [clang][Interp] Merge ByteCodeExprGen and ByteCodeStmtGen (PR #83683)

2024-03-04 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: > So ByteCodeExprGen can definitely visit statements and expressions. Well yes, the possibility is there, but it doesn't implement any of the functionality when visiting statements. :) > Can't ByteCode

[clang] Issue #63106: [сlang] Representation of ellipsis in AST (PR #80976)

2024-03-04 Thread Erich Keane via cfe-commits
erichkeane wrote: > > Hi @AaronBallman Can you pls explain me your previous response _"It would > > be better for us to associate the data with catch statements specifically > > because there's a lot fewer of those than there are variable declarations > > in general."_ > > I mean storing the e

[clang] [clang] Add some CodeGen tests for CWG 4xx issues (PR #83715)

2024-03-04 Thread Erich Keane via cfe-commits
@@ -0,0 +1,27 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexcept

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [llvm] [HLSL] implement `mad` intrinsic (PR #83826)

2024-03-04 Thread Xiang Li via cfe-commits
@@ -31,4 +31,8 @@ def int_dx_lerp : Intrinsic<[LLVMScalarOrSameVectorWidth<0, LLVMVectorElementType<0>>], [llvm_anyvector_ty, LLVMScalarOrSameVectorWidth<0, LLVMVectorElementType<0>>,LLVMScalarOrSameVectorWidth<0, LLVMVectorElementType<0>>], [IntrNoMem, IntrWillRe

[clang] [llvm] [HLSL] implement `mad` intrinsic (PR #83826)

2024-03-04 Thread Xiang Li via cfe-commits
https://github.com/python3kgae approved this pull request. https://github.com/llvm/llvm-project/pull/83826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/83625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Improve support for `__restrict`-qualified member functions (PR #83855)

2024-03-04 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/83855 The exact semantics of `__restrict` when applied to member functions are somewhat nebulous seeing as it is a compiler extension, and as a result, there are quite a few edge cases that our implementation current

[clang] [Clang] [Sema] Improve support for `__restrict`-qualified member functions (PR #83855)

2024-03-04 Thread via cfe-commits
Sirraide wrote: Sorry for the rather humongous pr description, but I tried to handle every edge case I could come up with (as well as include my rationale as to why I’ve decided to handle them that way)—thought it’s still possible that I missed some. https://github.com/llvm/llvm-project/pull/8

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/83625 >From b62919c2ce24feb3c75a5bbecce3d6b6ee8e5b7e Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 16 Jan 2024 16:40:47 -0600 Subject: [PATCH 1/7] [Frontend] Add leaf constructs and association to Ope

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-03-04 Thread Jan Leyonberg via cfe-commits
jsjodin wrote: @alexey-bataev do you have any concerns about removing this case? https://github.com/llvm/llvm-project/pull/82497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [Clang] [Sema] Improve support for `__restrict`-qualified member functions (PR #83855)

2024-03-04 Thread via cfe-commits
@@ -5052,6 +5052,21 @@ void Sema::InstantiateFunctionDefinition(SourceLocation PointOfInstantiation, Function->setInnerLocStart(PatternDecl->getInnerLocStart()); Function->setRangeEnd(PatternDecl->getEndLoc()); + // Propagate '__restrict' properly. + if (auto MD = dyn_c

[clang] [analyzer] Fix crash on dereference invalid return value of getAdjustedParameterIndex() (PR #83585)

2024-03-04 Thread via cfe-commits
mzyKi wrote: > That would make the behavior consistent with the behavior for other explicit > object functions (deducing this). > To illustrate we have the following code, the AST and produced CallEvent are > different: Thanks for your help very much.I only fixed the symptoms of this bug witho

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/83625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implement the rcp intrinsic (PR #83857)

2024-03-04 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/83857 This PR implements the frontend for llvm#70100 This PR is part 1 of 2. Part 2 depends on `DXILIntrinsicExpansion.cpp` in [dixl-lerp-intrinsic-lowering PR](https://github.com/llvm/llvm-project/compare/main...farzo

[clang] [llvm] [HLSL] implement the rcp intrinsic (PR #83857)

2024-03-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Farzon Lotfi (farzonl) Changes This PR implements the frontend for llvm#70100 This PR is part 1 of 2. Part 2 depends on `DXILIntrinsicExpansion.cpp` in [dixl-lerp-intrinsic-lowering PR](https://github.com/llvm/llvm-project/compare/main...f

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/83625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve documentation of StreamChecker (NFC). (PR #83858)

2024-03-04 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/83858 None From bb81a944b78315471df8866bf21b317e8c50166c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Mon, 4 Mar 2024 09:48:41 +0100 Subject: [PATCH] [clang][analyzer] Improve documentatio

[clang] [clang][analyzer] Improve documentation of StreamChecker (NFC). (PR #83858)

2024-03-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balázs Kéri (balazske) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/83858.diff 1 Files Affected: - (modified) clang/docs/analyzer/checkers.rst (+52-14) ``diff

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-04 Thread Visoiu Mistrih Francis via cfe-commits
https://github.com/francisvm approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/83584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/83625 >From b62919c2ce24feb3c75a5bbecce3d6b6ee8e5b7e Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 16 Jan 2024 16:40:47 -0600 Subject: [PATCH 1/8] [Frontend] Add leaf constructs and association to Ope

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-04 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/83625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implement exp intrinsic (PR #83832)

2024-03-04 Thread Xiang Li via cfe-commits
@@ -218,6 +218,9 @@ class DXILOpMapping; +def Exp : DXILOpMapping<21, unary, int_exp, + "Returns the base-e exponential of the x parameter." python3kgae wrote: DXIL exp is 2^x instead of e^x. For hlsl, there're exp and exp2(https://learn.

[clang] [llvm] [HLSL] implement exp intrinsic (PR #83832)

2024-03-04 Thread Farzon Lotfi via cfe-commits
@@ -218,6 +218,9 @@ class DXILOpMapping; +def Exp : DXILOpMapping<21, unary, int_exp, + "Returns the base-e exponential of the x parameter." farzonl wrote: I'm confused by this answer opcode 21 is `exp` not` exp2` https://godbolt.org/z/Me

[clang] 89e41e2 - [clang][Interp] Implement __builtin_complex

2024-03-04 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-04T17:15:42+01:00 New Revision: 89e41e2965b2b38a4aa1ad7757684566679ef762 URL: https://github.com/llvm/llvm-project/commit/89e41e2965b2b38a4aa1ad7757684566679ef762 DIFF: https://github.com/llvm/llvm-project/commit/89e41e2965b2b38a4aa1ad7757684566679ef762.diff LO

[clang] [clang][analyzer] Improve documentation of StreamChecker (NFC). (PR #83858)

2024-03-04 Thread via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/83858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve documentation of StreamChecker (NFC). (PR #83858)

2024-03-04 Thread via cfe-commits
https://github.com/NagyDonat approved this pull request. Looks reasonable. https://github.com/llvm/llvm-project/pull/83858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve documentation of StreamChecker (NFC). (PR #83858)

2024-03-04 Thread via cfe-commits
@@ -3020,44 +3020,82 @@ Check for misuses of stream APIs. Check for misuses of stream APIs: ``fopen, fcl alpha.unix.Stream (C) " -Check stream handling functions: ``fopen, tmpfile, fclose, fread, fwrite, fseek, ftell, rewind, fgetpos,`` -``fsetpos, cleare

[clang] [llvm] [HLSL] implement exp intrinsic (PR #83832)

2024-03-04 Thread Farzon Lotfi via cfe-commits
@@ -218,6 +218,9 @@ class DXILOpMapping; +def Exp : DXILOpMapping<21, unary, int_exp, + "Returns the base-e exponential of the x parameter." farzonl wrote: ok I see whats going on. seems like we should make exp2 the intrinsic then do exp

[clang] [llvm] [HLSL] implement exp intrinsic (PR #83832)

2024-03-04 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/83832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implement exp intrinsic (PR #83832)

2024-03-04 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl deleted https://github.com/llvm/llvm-project/pull/83832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implement exp intrinsic (PR #83832)

2024-03-04 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl converted_to_draft https://github.com/llvm/llvm-project/pull/83832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implement the rcp intrinsic (PR #83857)

2024-03-04 Thread Xiang Li via cfe-commits
@@ -0,0 +1,27 @@ + +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -verify -verify-ignore-unexpected python3kgae wrote: We have all those intrinsic error check tests which

[clang] [Clang][ARM][AArch64] Add branch protection attributes to the defaults. (PR #83277)

2024-03-04 Thread via cfe-commits
@@ -0,0 +1,30 @@ +// RUN: %clang_cc1 -triple aarch64-none-none -mbranch-target-enforce -msign-return-address=all -fcxx-exceptions -fexceptions -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK DanielKristofKiss wrote: > perhaps it's time to add CodeGenCX

[clang] [Clang][ARM][AArch64] Add branch protection attributes to the defaults. (PR #83277)

2024-03-04 Thread via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/83277 >From c421b6b9c167e82cedc5db2a67f47d3ba12deba9 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Wed, 28 Feb 2024 15:18:31 +0100 Subject: [PATCH 1/5] Add branch protection attributes to the defaults. Th

[clang] c240aca - Revert "Reland "[clang][modules] Print library module manifest path." (#82160)"

2024-03-04 Thread Kazushi Marukawa via cfe-commits
Author: Kazushi (Jam) Marukawa Date: 2024-03-05T01:34:48+09:00 New Revision: c240aca7a8a71f7218724aeb6c040289b51057dc URL: https://github.com/llvm/llvm-project/commit/c240aca7a8a71f7218724aeb6c040289b51057dc DIFF: https://github.com/llvm/llvm-project/commit/c240aca7a8a71f7218724aeb6c040289b5105

[clang] Reland "[clang][modules] Print library module manifest path." (PR #82160)

2024-03-04 Thread Kazushi Marukawa via cfe-commits
kaz7 wrote: Reverted. It is possible to reproduce erros by following commands. ``` $ mkdir build $ cd build $ cmake -G Ninja -DCMAKE_BUILD_TYPE=Release ../llvm-project/llvm -DLLVM_ENABLE_PROJECTS=clang -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" $ ninja $ ninja check-clang

[clang-tools-extra] [clangd] Add metric for rename decl kind (PR #83867)

2024-03-04 Thread David Goldman via cfe-commits
https://github.com/DavidGoldman created https://github.com/llvm/llvm-project/pull/83867 This will give us insight into what users are renaming in practice - for instance, try to gauge the impact of the ObjC rename support. >From 42dddf4a5fbd862bf2f122a6c6216fe0dbd34e54 Mon Sep 17 00:00:00 2001

[clang-tools-extra] [clangd] Add metric for rename decl kind (PR #83867)

2024-03-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: David Goldman (DavidGoldman) Changes This will give us insight into what users are renaming in practice - for instance, try to gauge the impact of the ObjC rename support. --- Full diff: https://github.com/llvm/llvm-project/pull/83867.di

[clang] [HIP] fix host-used external kernel (PR #83870)

2024-03-04 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/83870 In -fgpu-rdc mode, when an external kernel is used by a host function with weak_odr linkage (e.g. explicitly instantiated template function), the kernel should not be marked as host-used external kernel, since

[clang] [HIP] fix host-used external kernel (PR #83870)

2024-03-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes In -fgpu-rdc mode, when an external kernel is used by a host function with weak_odr linkage (e.g. explicitly instantiated template function), the kernel should not be marked as host-used external kernel,

<    1   2   3   4   5   6   >