[llvm] [clang] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Artem Belevich via cfe-commits
@@ -20,10 +20,12 @@ using EntryArrayTy = std::pair; /// \param EntryArray Optional pair pointing to the `__start` and `__stop` /// symbols holding the `__tgt_offload_entry` array. /// \param Suffix An optional suffix appended to the emitted symbols. +/// \param Relocatable Indi

[clang] [llvm] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Artem Belevich via cfe-commits
@@ -265,6 +329,11 @@ Error runLinker(ArrayRef Files, const ArgList &Args) { LinkerArgs.push_back(Arg); if (Error Err = executeCommands(LinkerPath, LinkerArgs)) return Err; + + if (Args.hasArg(OPT_relocatable)) +if (Error Err = relocateOffloadSection(Args, Execut

[llvm] [clang] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/80066 >From af382e03e41ef679c35a6126a1b131a7a8a28360 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 30 Jan 2024 15:34:22 -0600 Subject: [PATCH 1/2] [LinkerWrapper] Support relocatable linking for offloading S

[clang] [llvm] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7155c1ef658b66132f15bf1406e84e68eed3358f 1a91a8a1a5bd0a0b6d47dd0e50e801a820400203 --

[clang] [llvm] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/80066 >From af382e03e41ef679c35a6126a1b131a7a8a28360 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 30 Jan 2024 15:34:22 -0600 Subject: [PATCH 1/3] [LinkerWrapper] Support relocatable linking for offloading S

[clang] [clang][FMV] Direct-call FMV callees from FMV callers (PR #80093)

2024-01-31 Thread Erich Keane via cfe-commits
erichkeane wrote: > My gut feel was that recovering this information from the callee's resolver's > body would take heroics if we tried to do it in the backend. Opt can already see the feature strings in the llvm-attributes, and can introspect into it for the resolver. I could PERHAPS see val

[llvm] [clang] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Artem Belevich via cfe-commits
Artem-B wrote: Supporting such mixed mode opens an interesting set of issues we may need to consider going forward: * who/where/how runs initializers in the fully linked parts? * Are public functions in the fully linked parts visible to the functions in partially linked parts? In the full-rdc m

[clang-tools-extra] [llvm] [clang] [CLANG] Add warning when INF or NAN are used in a binary operation or as function argument in fast math mode. (PR #76873)

2024-01-31 Thread via cfe-commits
zeroomega wrote: Hi, I am seeing breakages on some of our audio code on tip of tree Clang and I traced it back to this patch. We uses `-ffast-math` mode for performance reasons but we also uses `-fhonor-infinities`, `-fhonor-nans` and `fno-finite-math-only` to ensure that the behavior of infi

[llvm] [clang] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Supporting such mixed mode opens an interesting set of issues we may need to > consider going forward: > > who/where/how runs initializers in the fully linked parts? I'm assuming you're talking about GPU-side constructors? I don't think the CUDA runtime supports those, but Op

[clang] [clang][FMV] Direct-call FMV callees from FMV callers (PR #80093)

2024-01-31 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/80093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][FMV] Direct-call FMV callees from FMV callers (PR #80093)

2024-01-31 Thread Jon Roelofs via cfe-commits
jroelofs wrote: Fair. I'll give that a shot. Doing it in opt has another big advantage I only just realized: it allows LTO to do the transformation. https://github.com/llvm/llvm-project/pull/80093 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [llvm] [clang-tools-extra] [CLANG] Add warning when INF or NAN are used in a binary operation or as function argument in fast math mode. (PR #76873)

2024-01-31 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Hi, I am seeing breakages on some of our audio code on tip of tree Clang and > I traced it back to this patch. > > We uses `-ffast-math` mode for performance reasons but we also uses > `-fhonor-infinities`, `-fhonor-nans` and `fno-finite-math-only` to ensure > that the behav

[libcxx] [clang] [clang-tools-extra] [llvm] [lldb] [mlir] [compiler-rt] [lld] [libc] [flang] [libc++][memory] P2652R2: Disallow Specialization of `allocator_traits` (PR #79978)

2024-01-31 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/79978 >From c2b9a249689b2b6928d50aeea4717fc9dfe87162 Mon Sep 17 00:00:00 2001 From: Zingam Date: Sat, 27 Jan 2024 13:54:21 +0200 Subject: [PATCH 1/6] [libc++][memory] P2652R2 - Disallow Specialization of `allocato

[openmp] [libcxx] [clang] [clang-tools-extra] [llvm] [lldb] [mlir] [compiler-rt] [lld] [libc] [libcxxabi] [flang] [libc++][memory] P2652R2: Disallow Specialization of `allocator_traits` (PR #79978)

2024-01-31 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/79978 >From c2b9a249689b2b6928d50aeea4717fc9dfe87162 Mon Sep 17 00:00:00 2001 From: Zingam Date: Sat, 27 Jan 2024 13:54:21 +0200 Subject: [PATCH 1/6] [libc++][memory] P2652R2 - Disallow Specialization of `allocato

[openmp] [libcxx] [clang] [clang-tools-extra] [llvm] [lldb] [mlir] [compiler-rt] [lld] [libc] [libcxxabi] [flang] [libc++][memory] P2652R2: Disallow Specialization of `allocator_traits` (PR #79978)

2024-01-31 Thread Hristo Hristov via cfe-commits
@@ -0,0 +1,34 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm] [libcxxabi] [flang] [libc] [clang] [clang-tools-extra] [openmp] [mlir] [libcxx] [lldb] [compiler-rt] [lld] [libc++][memory] P2652R2: Disallow Specialization of `allocator_traits` (PR #79978)

2024-01-31 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov edited https://github.com/llvm/llvm-project/pull/79978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [libcxxabi] [flang] [libc] [clang] [clang-tools-extra] [openmp] [mlir] [libcxx] [lldb] [compiler-rt] [lld] [libc++][memory] P2652R2: Disallow Specialization of `allocator_traits` (PR #79978)

2024-01-31 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/79978 >From c2b9a249689b2b6928d50aeea4717fc9dfe87162 Mon Sep 17 00:00:00 2001 From: Zingam Date: Sat, 27 Jan 2024 13:54:21 +0200 Subject: [PATCH 1/7] [libc++][memory] P2652R2 - Disallow Specialization of `allocato

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-01-31 Thread Tom Praschan via cfe-commits
tom-anders wrote: Thanks for the feedback! > Thanks, the approach in this patch looks pretty good to me. > > My only feedback is to encapsulate the "hard coding" into a function like: > > ``` > Option TryConvertToRename(const Diag *D, const Fix > *F) > ``` > > because I can imagine in the fu

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-01-31 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders updated https://github.com/llvm/llvm-project/pull/78454 >From 579d681323db5f92d494f0cd0aaa9158dc8c4e3b Mon Sep 17 00:00:00 2001 From: tom-anders <13141438+tom-and...@users.noreply.github.com> Date: Wed, 17 Jan 2024 15:36:02 +0100 Subject: [PATCH] [clangd] forward cl

[clang] [compiler-rt] [openmp] [libcxx] [libc] [llvm] [libcxxabi] [clang-tools-extra] [mlir] [lldb] [lld] [flang] [libc++][memory] P2652R2: Disallow Specialization of `allocator_traits` (PR #79978)

2024-01-31 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/79978 >From c2b9a249689b2b6928d50aeea4717fc9dfe87162 Mon Sep 17 00:00:00 2001 From: Zingam Date: Sat, 27 Jan 2024 13:54:21 +0200 Subject: [PATCH 1/8] [libc++][memory] P2652R2 - Disallow Specialization of `allocato

[clang] [compiler-rt] [openmp] [libcxx] [libc] [llvm] [libcxxabi] [clang-tools-extra] [mlir] [lldb] [lld] [flang] [libc++][memory] P2652R2: Disallow Specialization of `allocator_traits` (PR #79978)

2024-01-31 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/79978 >From c2b9a249689b2b6928d50aeea4717fc9dfe87162 Mon Sep 17 00:00:00 2001 From: Zingam Date: Sat, 27 Jan 2024 13:54:21 +0200 Subject: [PATCH 1/8] [libc++][memory] P2652R2 - Disallow Specialization of `allocato

[clang-tools-extra] [clangd] Add multiRange support to textDocument/rangeFormatting (PR #80180)

2024-01-31 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders created https://github.com/llvm/llvm-project/pull/80180 Uses the protocol changes proposed in https://github.com/microsoft/language-server-protocol/pull/1556 and https://github.com/microsoft/vscode/pull/163190 Related issue: https://github.com/clangd/clangd/issue

[clang-tools-extra] [clangd] Add multiRange support to textDocument/rangeFormatting (PR #80180)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Tom Praschan (tom-anders) Changes Uses the protocol changes proposed in https://github.com/microsoft/language-server-protocol/pull/1556 and https://github.com/microsoft/vscode/pull/163190 Related issue: https://github.com/cla

[clang-tools-extra] [clangd] Add multiRange support to textDocument/rangeFormatting (PR #80180)

2024-01-31 Thread Tom Praschan via cfe-commits
tom-anders wrote: Hmm so it looks like there have been some changes to the proposed LSP spec since my original phabricator diff, so I think I need to adapt this PR a bit. Will convert to a draft for now. https://github.com/llvm/llvm-project/pull/80180 __

[clang-tools-extra] [clangd] Add multiRange support to textDocument/rangeFormatting (PR #80180)

2024-01-31 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders converted_to_draft https://github.com/llvm/llvm-project/pull/80180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-31 Thread Shourya Goel via cfe-commits
https://github.com/Sh0g0-1758 updated https://github.com/llvm/llvm-project/pull/78338 >From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001 From: Sh0g0-1758 Date: Wed, 17 Jan 2024 01:24:17 +0530 Subject: [PATCH 01/17] Fix : more detailed no expected directive message --- cla

[clang] [llvm] [clang-tools-extra] [clang-tidy] Remove cert-dcl21-cpp check (PR #80181)

2024-01-31 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/80181 Deprecated since clang-tidy 17. The rule DCL21-CPP has been removed from the CERT guidelines, so it does not make sense to keep the check. Fixes #42788 >From fdb65ef4805152ad143a120e343d696f8b08d3db Mon S

[clang] [clang][dataflow][NFC] Rename a confusingly named variable. (PR #80182)

2024-01-31 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/80182 None >From 15dda1270db67adb815c18d03115847fcd0b09f3 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Wed, 31 Jan 2024 19:16:06 + Subject: [PATCH] [clang][dataflow][NFC] Rename a confusingly named var

[llvm] [clang] [clang-tools-extra] [clang-tidy] Remove cert-dcl21-cpp check (PR #80181)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-tidy Author: Carlos Galvez (carlosgalvezp) Changes Deprecated since clang-tidy 17. The rule DCL21-CPP has been removed from the CERT guidelines, so it does not make sense to keep the check. Fixes #42788 --- Full diff:

[clang] [clang][dataflow][NFC] Rename a confusingly named variable. (PR #80182)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/80182.diff 1 Files Affected: - (modified) clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp (+9-9) ``diff diff --git a/clang/lib/Analysis/Flo

[clang] [llvm] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Artem Belevich via cfe-commits
Artem-B wrote: > I'm assuming you're talking about GPU-side constructors? I don't think the > CUDA runtime supports those, but OpenMP runs them when the image is loaded, > so it would handle both independantly. Yes. I'm thinking of the expectations from a C++ user standpoint, and this is one

[clang] [llvm] [clang-tools-extra] [clang-tidy] Remove cert-dcl21-cpp check (PR #80181)

2024-01-31 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cf2533e75ec4360da460bb577e0a4e64f2d8997f fdb65ef4805152ad143a120e343d696f8b08d3db --

[clang] [llvm] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-31 Thread Shourya Goel via cfe-commits
https://github.com/Sh0g0-1758 edited https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Allow w64 ballot to be used on w32 targets (PR #80183)

2024-01-31 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/80183 Summary: Currently we cannot compile `__builtin_amdgcn_ballot_w64` on non-wave64 targets even though it is valid. This is relevant for making library code that can handle both without needing to check the wavefron

[clang] [AMDGPU] Allow w64 ballot to be used on w32 targets (PR #80183)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: Currently we cannot compile `__builtin_amdgcn_ballot_w64` on non-wave64 targets even though it is valid. This is relevant for making library code that can handle both without needing to check the wave

[clang] [llvm] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-31 Thread Shourya Goel via cfe-commits
Sh0g0-1758 wrote: Hey @AaronBallman, I have added a test for the same in ```clang/test/Frontend/verify.c``` and made the necessary changes as well. I have added a short **PR SUMMARY** to the top-level comment as you instructed. As for changes in other error messages, I think its best to merge

[clang] [clang][dataflow][NFC] Rename a confusingly named variable. (PR #80182)

2024-01-31 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/80182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-31 Thread Shourya Goel via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; def err_verify_no_directives : Error< -"no expected direc

[clang] [llvm] [clang-tools-extra] [clang-tidy] Remove cert-dcl21-cpp check (PR #80181)

2024-01-31 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: The code formatting job seems to produce incorrect changes. https://github.com/llvm/llvm-project/pull/80181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [lld] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-31 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/72714 >From c493d78e6c482bb530189de05b79e7082a224fab Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Thu, 28 Sep 2023 03:14:35 +0300 Subject: [PATCH 1/8] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH

[clang-tools-extra] [llvm] [clang] [lld] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-31 Thread Daniil Kovalev via cfe-commits
@@ -0,0 +1,83 @@ +# REQUIRES: aarch64 + +# RUN: rm -rf %t && split-file %s %t && cd %t + +# RUN: llvm-mc -filetype=obj -triple=aarch64-linux-gnu abi-tag1.s -o tag11.o +# RUN: cp tag11.o tag12.o +# RUN: ld.lld -shared tag11.o tag12.o -o tagok.so +# RUN: llvm-readelf -n tagok.so | F

[clang] [llvm] [clang-tools-extra] [lld] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-31 Thread Daniil Kovalev via cfe-commits
@@ -543,7 +553,8 @@ class RelocationBaseSection : public SyntheticSection { static bool classof(const SectionBase *d) { return SyntheticSection::classof(d) && (d->type == llvm::ELF::SHT_RELA || d->type == llvm::ELF::SHT_REL || -d->type == llvm::ELF:

[clang] [clang-tools-extra] [llvm] [lld] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-31 Thread Daniil Kovalev via cfe-commits
@@ -1461,6 +1493,33 @@ template void RelocationScanner::scanOne(RelTy *&i) { } } + // if (config->emachine == EM_AARCH64 && type == R_AARCH64_AUTH_ABS64) { kovdan01 wrote: Ah, thanks, removed that. The logic was moved to `RelocationScanner::processAu

[clang] [clang-tools-extra] [llvm] [clang-tidy] Remove cert-dcl21-cpp check (PR #80181)

2024-01-31 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. Looks OK for me, but will be good idea if @PiotrZSL will also take a look. https://github.com/llvm/llvm-project/pull/80181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang-tools-extra] [clang-tidy] Add AllowStringArrays option to modernize-avoid-c-arrays (PR #71701)

2024-01-31 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/71701 >From 050d53bdbc01be93a15f6851faddc24e520f0472 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Wed, 8 Nov 2023 16:52:06 + Subject: [PATCH 1/4] [clang-tidy] Add AllowStringArrays option to modernize-avoid-c

[clang] [clang-tools-extra] [llvm] [clang-tidy] Remove cert-dcl21-cpp check (PR #80181)

2024-01-31 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/80181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I'm assuming you're talking about GPU-side constructors? I don't think the > > CUDA runtime supports those, but OpenMP runs them when the image is loaded, > > so it would handle both independantly. > > Yes. I'm thinking of the expectations from a C++ user standpoint, and thi

[clang] [llvm] Computing, storing, and restoring conservative call graphs with LLVM (PR #80104)

2024-01-31 Thread Paul Kirth via cfe-commits
ilovepi wrote: while its kind of nice to see the complete patch, it looks to me like each of these changes is independent, and should be stacked rather than commited in bulk. Many of us have had good experience with `spr`, so I'd suggest maybe abandoning this PR and re-uploading a stack that c

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: > I tried running clang-format but the diff was huge and beyond just my changes. I usually do `git clang-format HEAD~N` where N is the number of commits of mine (N is optional when N == 1). https://github.com/llvm/llvm-project/pull/80089 _

[clang] 4cb13f2 - [clang-tidy] Remove cert-dcl21-cpp check (#80181)

2024-01-31 Thread via cfe-commits
Author: Carlos Galvez Date: 2024-01-31T20:35:28+01:00 New Revision: 4cb13f2d2328b80687c9dcbe6815faf397b05c42 URL: https://github.com/llvm/llvm-project/commit/4cb13f2d2328b80687c9dcbe6815faf397b05c42 DIFF: https://github.com/llvm/llvm-project/commit/4cb13f2d2328b80687c9dcbe6815faf397b05c42.diff

[clang-tools-extra] [llvm] [clang] [clang-tidy] Remove cert-dcl21-cpp check (PR #80181)

2024-01-31 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/80181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4cb13f2 - [clang-tidy] Remove cert-dcl21-cpp check (#80181)

2024-01-31 Thread via cfe-commits
Author: Carlos Galvez Date: 2024-01-31T20:35:28+01:00 New Revision: 4cb13f2d2328b80687c9dcbe6815faf397b05c42 URL: https://github.com/llvm/llvm-project/commit/4cb13f2d2328b80687c9dcbe6815faf397b05c42 DIFF: https://github.com/llvm/llvm-project/commit/4cb13f2d2328b80687c9dcbe6815faf397b05c42.diff

[clang] [AMDGPU] Allow w64 ballot to be used on w32 targets (PR #80183)

2024-01-31 Thread Yaxun Liu via cfe-commits
@@ -151,7 +151,7 @@ BUILTIN(__builtin_amdgcn_mqsad_u32_u8, "V4UiWUiUiV4Ui", "nc") //===--===// TARGET_BUILTIN(__builtin_amdgcn_ballot_w32, "ZUib", "nc", "wavefrontsize32") -TARGET_BUILTIN(__builtin_amdgcn_ba

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

2024-01-31 Thread Matheus Izvekov via cfe-commits
@@ -457,6 +457,28 @@ Note that **currently** the compiler doesn't consider inconsistent macro definit Currently Clang would accept the above example. But it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` also in other translation

[clang] [AMDGPU] Allow w64 ballot to be used on w32 targets (PR #80183)

2024-01-31 Thread Joseph Huber via cfe-commits
@@ -151,7 +151,7 @@ BUILTIN(__builtin_amdgcn_mqsad_u32_u8, "V4UiWUiUiV4Ui", "nc") //===--===// TARGET_BUILTIN(__builtin_amdgcn_ballot_w32, "ZUib", "nc", "wavefrontsize32") -TARGET_BUILTIN(__builtin_amdgcn_ba

[openmp] [libcxx] [clang] [clang-tools-extra] [llvm] [lldb] [mlir] [compiler-rt] [lld] [libc] [libcxxabi] [flang] [libc++][memory] P2652R2: Disallow Specialization of `allocator_traits` (PR #79978)

2024-01-31 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/79978 >From c2b9a249689b2b6928d50aeea4717fc9dfe87162 Mon Sep 17 00:00:00 2001 From: Zingam Date: Sat, 27 Jan 2024 13:54:21 +0200 Subject: [PATCH 1/9] [libc++][memory] P2652R2 - Disallow Specialization of `allocato

[clang] [llvm] [clang-tools-extra] [CLANG] Add warning when INF or NAN are used in a binary operation or as function argument in fast math mode. (PR #76873)

2024-01-31 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Hi, I am seeing breakages on some of our audio code on tip of tree Clang and > I traced it back to this patch. > > We uses `-ffast-math` mode for performance reasons but we also uses > `-fhonor-infinities`, `-fhonor-nans` and `fno-finite-math-only` to ensure > that the b

[clang] [llvm] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Artem Belevich via cfe-commits
Artem-B wrote: > the idea is that it would be the desired effect if someone went out of their > way to do this GPU subset linking thing. That would only be true when someone owns the whole build. That will not be the case in practice. A large enough project is usually a bunch of libraries cre

[clang] [flang] [flang]Add support for -moutline-atomics and -mno-outline-atomics (PR #78755)

2024-01-31 Thread Mats Petersson via cfe-commits
https://github.com/Leporacanthicus updated https://github.com/llvm/llvm-project/pull/78755 >From a0e256f379130a98ba03793f7102c67d02cbdef1 Mon Sep 17 00:00:00 2001 From: Mats Petersson Date: Fri, 19 Jan 2024 16:30:31 + Subject: [PATCH 1/3] [flang]Add support for -moutline-atomics and -mno-o

[clang] [llvm] [clang-tools-extra] [CLANG] Add warning when INF or NAN are used in a binary operation or as function argument in fast math mode. (PR #76873)

2024-01-31 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > > > Is this expected and wanted? > > > > > > > > > > > > Good catch! I would not expect that diagnostic; we should silence the > > > > diagnostic if it's used in a `#ifdef`, `#elifdef`, or `defined` because > > > > the value isn't necessary. Perhaps we should also si

[clang] [llvm] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > the idea is that it would be the desired effect if someone went out of > > their way to do this GPU subset linking thing. > > That would only be true when someone owns the whole build. That will not be > the case in practice. A large enough project is usually a bunch of libr

[clang] [llvm] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-31 Thread Shourya Goel via cfe-commits
https://github.com/Sh0g0-1758 updated https://github.com/llvm/llvm-project/pull/78338 >From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001 From: Sh0g0-1758 Date: Wed, 17 Jan 2024 01:24:17 +0530 Subject: [PATCH 01/18] Fix : more detailed no expected directive message --- cla

[clang] [OpenMP][Clang] Handle unsupported inscan modifier for generic types (PR #79431)

2024-01-31 Thread Saiyedul Islam via cfe-commits
@@ -19520,6 +19520,13 @@ static bool actOnOMPReductionKindClause( bool FirstIter = true; for (Expr *RefExpr : VarList) { assert(RefExpr && "nullptr expr in OpenMP reduction clause."); +if (ClauseKind == OMPC_reduction && +RD.RedModifier == OMPC_REDUCTION_ins

[clang] [HIP] fix HIP detection for /usr (PR #80190)

2024-01-31 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/80190 Skip checking HIP version file under parent directory for /usr/local since /usr will be checked after /usr/local. Fixes: https://github.com/llvm/llvm-project/issues/78344 >From 4da60eac1a940d922703381a9a07c932

[clang] [HIP] fix HIP detection for /usr (PR #80190)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Yaxun (Sam) Liu (yxsamliu) Changes Skip checking HIP version file under parent directory for /usr/local since /usr will be checked after /usr/local. Fixes: https://github.com/llvm/llvm-project/issues/78344 --- Full diff: https:/

[clang] [HIP] fix HIP detection for /usr (PR #80190)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes Skip checking HIP version file under parent directory for /usr/local since /usr will be checked after /usr/local. Fixes: https://github.com/llvm/llvm-project/issues/78344 --- Full diff: https://github.c

[compiler-rt] [llvm] [clang] [flang] [clang-tools-extra] [llvm][AArch64] intrinsic to generate a ubfx instruction (PR #80103)

2024-01-31 Thread via cfe-commits
@@ -855,6 +855,9 @@ def int_aarch64_crc32x : DefaultAttrsIntrinsic<[llvm_i32_ty], [llvm_i32_ty, llv [IntrNoMem]>; def int_aarch64_crc32cx : DefaultAttrsIntrinsic<[llvm_i32_ty], [llvm_i32_ty, llvm_i64_ty], [IntrNoMem]>; +def int_aarch64_ubfx : DefaultAttrsIntrinsic< -

[clang] [HIP] fix HIP detection for /usr (PR #80190)

2024-01-31 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Do we have any tests for this kind of stuff? We really should have some mock ROCm installation in one of the `Inputs/` directories and then do `--rocm-path=` or something. https://github.com/llvm/llvm-project/pull/80190 ___

[clang] c003d85 - [clang][DependencyScanner] Remove unused -fmodule-map-file arguments (#80090)

2024-01-31 Thread via cfe-commits
Author: Michael Spencer Date: 2024-01-31T12:28:27-08:00 New Revision: c003d851f5cc1476774153fa9ed02fda725e9d57 URL: https://github.com/llvm/llvm-project/commit/c003d851f5cc1476774153fa9ed02fda725e9d57 DIFF: https://github.com/llvm/llvm-project/commit/c003d851f5cc1476774153fa9ed02fda725e9d57.dif

[clang] [clang][DependencyScanner] Remove unused -fmodule-map-file arguments (PR #80090)

2024-01-31 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese closed https://github.com/llvm/llvm-project/pull/80090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang-tools-extra] [llvm] [compiler-rt] [llvm][AArch64] intrinsic to generate a ubfx instruction (PR #80103)

2024-01-31 Thread Dawei Pan via cfe-commits
dwpan wrote: The feature will be very useful for hardware language like Verilog/SystemVerilog which insert/extract bits are parts of language reference manual. https://github.com/llvm/llvm-project/pull/80103 ___ cfe-commits mailing list cfe-commits

[clang] [llvm] [clang-tools-extra] [CLANG] Add warning when INF or NAN are used in a binary operation or as function argument in fast math mode. (PR #76873)

2024-01-31 Thread via cfe-commits
zeroomega wrote: > > Hi, I am seeing breakages on some of our audio code on tip of tree Clang > > and I traced it back to this patch. > > We uses `-ffast-math` mode for performance reasons but we also uses > > `-fhonor-infinities`, `-fhonor-nans` and `fno-finite-math-only` to ensure > > that t

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p… (PR #80193)

2024-01-31 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/80193 …refer-member-init This functionality already exists in cppcoreguidelines-use-default-member-init. It was deprecated from this check in clang-tidy 17. This allows us to fully decouple this check from the

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p… (PR #80193)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Carlos Galvez (carlosgalvezp) Changes …refer-member-init This functionality already exists in cppcoreguidelines-use-default-member-init. It was deprecated from this check in clang-tidy 17. This allows us to fully decouple thi

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p… (PR #80193)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Carlos Galvez (carlosgalvezp) Changes …refer-member-init This functionality already exists in cppcoreguidelines-use-default-member-init. It was deprecated from this check in clang-tidy 17. This allows us to fully decouple this check

[llvm] [clang] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/80066 >From af382e03e41ef679c35a6126a1b131a7a8a28360 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 30 Jan 2024 15:34:22 -0600 Subject: [PATCH 1/4] [LinkerWrapper] Support relocatable linking for offloading S

[clang-tools-extra] [llvm] [libc] [flang] [clang] [compiler-rt] [DirectX][docs] Architecture and design philosophy of DXIL support (PR #78221)

2024-01-31 Thread Chris B via cfe-commits
@@ -0,0 +1,102 @@ +=== +Architecture and Design of DXIL Support in LLVM +=== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +LLVM supports reading and

[llvm] [clang] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-31 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/80066 >From af382e03e41ef679c35a6126a1b131a7a8a28360 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 30 Jan 2024 15:34:22 -0600 Subject: [PATCH 1/5] [LinkerWrapper] Support relocatable linking for offloading S

[clang] [OpenMP][Clang] Handle unsupported inscan modifier for generic types (PR #79431)

2024-01-31 Thread Alexey Bataev via cfe-commits
@@ -19520,6 +19520,13 @@ static bool actOnOMPReductionKindClause( bool FirstIter = true; for (Expr *RefExpr : VarList) { assert(RefExpr && "nullptr expr in OpenMP reduction clause."); +if (ClauseKind == OMPC_reduction && +RD.RedModifier == OMPC_REDUCTION_ins

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt updated https://github.com/llvm/llvm-project/pull/80089 >From 68805d7871230033be43c1d87dfcd2aa2b668589 Mon Sep 17 00:00:00 2001 From: Justin Stitt Date: Tue, 23 Jan 2024 23:28:42 + Subject: [PATCH 1/4] add signed-integer-wrap sanitizer --- clang/include/clan

[compiler-rt] [clang] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt edited https://github.com/llvm/llvm-project/pull/80089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-31 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/79981 >From 634c7d1a1205c9d047f8b3000cb93128a278006f Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 30 Jan 2024 14:01:11 +0300 Subject: [PATCH 1/2] [clang] Add tests for DRs about inheriting constructors

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-31 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/79981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Allow w64 ballot to be used on w32 targets (PR #80183)

2024-01-31 Thread Joseph Huber via cfe-commits
@@ -151,7 +151,7 @@ BUILTIN(__builtin_amdgcn_mqsad_u32_u8, "V4UiWUiUiV4Ui", "nc") //===--===// TARGET_BUILTIN(__builtin_amdgcn_ballot_w32, "ZUib", "nc", "wavefrontsize32") -TARGET_BUILTIN(__builtin_amdgcn_ba

[llvm] [clang] [Clang] Correct __builtin_dynamic_object_size for subobject types (PR #78526)

2024-01-31 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/78526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-31 Thread via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexcept

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p… (PR #80193)

2024-01-31 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. https://github.com/llvm/llvm-project/pull/80193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Preprocessor] Fix __has_builtin for CPU ID functions (PR #80058)

2024-01-31 Thread via cfe-commits
alexfh wrote: LGTM. Thank you for the quick fix! https://github.com/llvm/llvm-project/pull/80058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p… (PR #80193)

2024-01-31 Thread Carlos Galvez via cfe-commits
@@ -230,139 +197,99 @@ void PreferMemberInitializerCheck::check( updateAssignmentLevel(Field, InitValue, Ctor, AssignedFields); if (!canAdvanceAssignment(AssignedFields[Field])) continue; -const bool IsInDefaultMemberInitializer = -IsUseDefaultMemberIn

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-31 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: To be honest, I'm not keen on the idea of filing bug tracker issues for problems accounted for in other way (DR status, `FIXME`), until we get bug tracker in a good shape, or at least have an understanding how project management side of things is going to look. > Is there anyth

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-31 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/79981 >From 634c7d1a1205c9d047f8b3000cb93128a278006f Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 30 Jan 2024 14:01:11 +0300 Subject: [PATCH 1/3] [clang] Add tests for DRs about inheriting constructors

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-31 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexcept

[clang-tools-extra] [llvm] [flang] [clang] [compiler-rt] [llvm][AArch64] intrinsic to generate a ubfx instruction (PR #80103)

2024-01-31 Thread Rama Malladi via cfe-commits
https://github.com/RamaMalladiAWS updated https://github.com/llvm/llvm-project/pull/80103 >From e6df837fa223046677b162f817b2b00a99b68a74 Mon Sep 17 00:00:00 2001 From: Ubuntu Date: Fri, 26 Jan 2024 18:49:23 + Subject: [PATCH 1/2] intrinsic to generate a ubfx instruction --- llvm/include/l

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt updated https://github.com/llvm/llvm-project/pull/80089 >From 68805d7871230033be43c1d87dfcd2aa2b668589 Mon Sep 17 00:00:00 2001 From: Justin Stitt Date: Tue, 23 Jan 2024 23:28:42 + Subject: [PATCH 1/5] add signed-integer-wrap sanitizer --- clang/include/clan

[clang] [AMDGPU] Allow w64 ballot to be used on w32 targets (PR #80183)

2024-01-31 Thread Joseph Huber via cfe-commits
@@ -151,7 +151,7 @@ BUILTIN(__builtin_amdgcn_mqsad_u32_u8, "V4UiWUiUiV4Ui", "nc") //===--===// TARGET_BUILTIN(__builtin_amdgcn_ballot_w32, "ZUib", "nc", "wavefrontsize32") -TARGET_BUILTIN(__builtin_amdgcn_ba

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Justin Stitt via cfe-commits
@@ -0,0 +1,66 @@ +// Check that -fsanitize=signed-integer-wrap instruments with -fwrapv +// RUN: %clang_cc1 -fwrapv -triple x86_64-apple-darwin -emit-llvm -o - %s -fsanitize=signed-integer-wrap | FileCheck %s --check-prefix=CHECK + +// Check that -fsanitize=signed-integer-overflo

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt edited https://github.com/llvm/llvm-project/pull/80089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Nick Desaulniers via cfe-commits
@@ -0,0 +1,77 @@ +// Check that -fsanitize=signed-integer-wrap instruments with -fwrapv nickdesaulniers wrote: Have you seen `llvm/utils/update_cc_test_checks.py` before? Honestly, ALL new tests to clang (or llvm) involving codegen should strive to use that (or

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Justin Stitt via cfe-commits
@@ -0,0 +1,77 @@ +// Check that -fsanitize=signed-integer-wrap instruments with -fwrapv JustinStitt wrote: I must be doing something wrong because it suggest I remove all my `Check: ...`'s and replcae them with `Check: {{.*}}` https://github.com/llvm/llvm-proje

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt edited https://github.com/llvm/llvm-project/pull/80089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >