tomasz-kaminski-sonarsource wrote:
Reworked response to provide constructive feedback.
> What I don't want to lose from this patch are the changes to places like
> `InitializationStyle getInitializationStyle() const` and
> `CXXNewExpr::CXXNewExpr` where the old code was unclear and the new cod
carlobertolli wrote:
Automatic zero-copy doesn't work on some of the bbot's. I will have to land
this once the lit test harness extension in #77851 re-lands.
https://github.com/llvm/llvm-project/pull/76571
___
cfe-commits mailing list
cfe-commits@lis
@@ -144,7 +144,8 @@ _LIBCPP_HIDE_FROM_ABI decltype(auto)
__visit_format_arg(_Visitor&& __vis, basic_
__libcpp_unreachable();
}
-# if _LIBCPP_STD_VER >= 26
+# if _LIBCPP_STD_VER >= 26 && (!defined(_LIBCPP_COMPILER_CLANG_BASED) ||
_LIBCPP_CLANG_VER >= 1800)
---
@@ -11,7 +11,7 @@
#error
// expected-error@-1 {{}}
-// CHECK: error: no expected directives found: consider use of
'expected-no-diagnostics'
+// CHECK: error: no expected directives found: consider use of
'{{.*}}-no-diagnostics'
Sh0g0-1758 wrote:
madler wrote:
> > We have provided a fix for zlib
> > ([madler/zlib#895](https://github.com/madler/zlib/pull/895)) which was
> > accepted by @madler.
>
> But nowhere released, not even in the repository :(
This should be fixed in the zlib develop branch. Have you tried it?
https://github.com
sethp wrote:
Yeah, I've still got some history editing to do: for now, the merge made the
"all commits" diff look like it represents just the changes this PR represents.
Thank you very much for your review feedback: I really like how it ended up
coming out. I think we got something that's at a
https://github.com/jakeegan created
https://github.com/llvm/llvm-project/pull/78748
This will prevent unnecessary symbols being exported in libclang, which could
cause issues with non-unique objects.
>From a51256cdab8a04474d4ae168d969516af1878c29 Mon Sep 17 00:00:00 2001
From: Jake Egan <53264
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jake Egan (jakeegan)
Changes
This will prevent unnecessary symbols being exported in libclang, which could
cause issues with non-unique objects.
---
Full diff: https://github.com/llvm/llvm-project/pull/78748.diff
14 Files Affected:
- (
llvm-beanz wrote:
@rjmccall, do my latest updates here cover all your concerns?
https://github.com/llvm/llvm-project/pull/71098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,556 @@
+// RUN: mkdir -p %t
ldionne wrote:
Are these files missing a license?
https://github.com/llvm/llvm-project/pull/75371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
@@ -0,0 +1,556 @@
+// RUN: mkdir -p %t
+// RUN: %clang++ %s -o %t/run
+// RUN: %t/run
ldionne wrote:
I'm not sure if this is going to work on all configurations, for example when
they cross compile. Is there a precedent for these kinds of runtime tests in
the c
https://github.com/paschalis-mpeis created
https://github.com/llvm/llvm-project/pull/78749
Flags `-fveclib=name` were not passed to LTO flags.
This pass fixes that by converting the `-fveclib` flags to their relevant names
for opt's `-vector-lib=name` flags.
For example:
`-fveclib=SLEEF` would
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Paschalis Mpeis (paschalis-mpeis)
Changes
Flags `-fveclib=name` were not passed to LTO flags.
This pass fixes that by converting the `-fveclib` flags to their relevant names
for opt's `-vector-lib=name` fl
https://github.com/jansvoboda11 approved this pull request.
LGTM, thank you!
https://github.com/llvm/llvm-project/pull/78748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Logikable wrote:
Updated with suggestions. How does this look?
https://github.com/llvm/llvm-project/pull/73176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/manbearian updated
https://github.com/llvm/llvm-project/pull/78484
>From b83074fa260d2ce4b876b71d507224cb9476a944 Mon Sep 17 00:00:00 2001
From: Ian Bearman
Date: Wed, 17 Jan 2024 17:54:25 +
Subject: [PATCH] port fixes from local llvm
---
.../IR/BufferizableOpInterface.
https://github.com/manbearian ready_for_review
https://github.com/llvm/llvm-project/pull/78484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-mlir-bufferization
Author: ian Bearman (manbearian)
Changes
Collection of changes with the goal of being able to convert `encoding` to
`memorySpace` during bufferization
- new API for encoder to allow implementation to select destination memory
space
@@ -13861,6 +13897,36 @@ Sema::CheckReturnValExpr(Expr *RetValExp, QualType
lhsType,
CheckPPCMMAType(RetValExp->getType(), ReturnLoc);
}
+/// Diagnose comparison to NAN or INFINITY in fast math modes.
+/// The comparison to NaN or INFINITY is always false in
+/// fast mod
zahiraam wrote:
Any other comments from @arsenm and @andykaylor?
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/manbearian edited
https://github.com/llvm/llvm-project/pull/78484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manbearian wrote:
Based on the work discussed here:
https://discourse.llvm.org/t/using-tensor-encoding-attribute/69142
https://github.com/llvm/llvm-project/pull/78484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/mshockwave updated
https://github.com/llvm/llvm-project/pull/78489
>From ab316ea2c76320ec2f044c43bb9f6ed82f6802c3 Mon Sep 17 00:00:00 2001
From: Min Hsu
Date: Wed, 17 Jan 2024 10:28:14 -0800
Subject: [PATCH 1/4] [RISCV] Add support for Smepmp 1.0
Smepmp is a supervisor exten
@@ -1047,6 +1048,14 @@
// RUN: -o - | FileCheck --check-prefix=CHECK-SSAIA-EXT %s
// CHECK-SSAIA-EXT: __riscv_ssaia 100{{$}}
+// RUN: %clang --target=riscv32 -menable-experimental-extensions \
+// RUN: -march=rv32ismepmp1p0 -x c -E -dM %s \
+// RUN: -o - | FileCheck --che
@@ -116,6 +116,7 @@
// CHECK-NOT: __riscv_smaia {{.*$}}
// CHECK-NOT: __riscv_ssaia {{.*$}}
+// CHECK-NOT: __riscv_smepmp {{.*$}}
mshockwave wrote:
It's fixed now.
https://github.com/llvm/llvm-project/pull/78489
__
@@ -318,17 +396,87 @@ static Messages getTaintMsgs(const SubRegion *Region,
const char *OffsetName) {
RegName, OffsetName)};
}
-void ArrayBoundCheckerV2::performCheck(const Expr *E, CheckerContext &C) const
{
- // NOTE: Instead of using ProgramState::assum
@@ -318,17 +396,87 @@ static Messages getTaintMsgs(const SubRegion *Region,
const char *OffsetName) {
RegName, OffsetName)};
}
-void ArrayBoundCheckerV2::performCheck(const Expr *E, CheckerContext &C) const
{
- // NOTE: Instead of using ProgramState::assum
https://github.com/j-jorge created
https://github.com/llvm/llvm-project/pull/78752
Resolves #27008, #39735, #53013, #63619.
Hello, this PR adds the MainIncludeChar option to clang-format, allowing to
select which include syntax must be considered when searching for the main
header: quotes (`#
cor3ntin wrote:
I tried a whole bunch of stuffs, this is the best we can do to improve
`LexIdentifierContinue`
https://github.com/llvm/llvm-project/pull/78699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (j-jorge)
Changes
Resolves #27008, #39735, #53013, #63619.
Hello, this PR adds the MainIncludeChar option to clang-format, allowing to
select which include syntax must be considered when searching for the main
header: quotes (`#incl
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b6677835fed3a204fa043e079a135c4a225d2c0e
db59f23f7dff603b00c40761c8fa935876b1654b --
@@ -0,0 +1,128 @@
+// RUN: %clang_analyze_cc1 -Wno-array-bounds -analyzer-output=text\
+// RUN:
-analyzer-checker=core,alpha.security.ArrayBoundV2,unix.Malloc,alpha.security.taint,debug.ExprInspection
-verify %s
+
+int array[10];
+
+void clang_analyzer_value(unsigned
@@ -0,0 +1,128 @@
+// RUN: %clang_analyze_cc1 -Wno-array-bounds -analyzer-output=text\
+// RUN:
-analyzer-checker=core,alpha.security.ArrayBoundV2,unix.Malloc,alpha.security.taint,debug.ExprInspection
-verify %s
+
+int array[10];
+
+void clang_analyzer_value(unsigned
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/78315
>From c75c05c6e894a46797913c5bdccb240cbcc01ae9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Tue, 12 Dec 2023 13:07:54 +0100
Subject: [PATCH 1/2] [analyzer] Support interestingness in Array
NagyDonat wrote:
@steakhal Thanks for the review! I'll apply your suggestions on the next week.
https://github.com/llvm/llvm-project/pull/78315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/j-jorge updated
https://github.com/llvm/llvm-project/pull/78752
>From 11c7a60c5487d01e49b113bc264bb166d6df5457 Mon Sep 17 00:00:00 2001
From: Julien Jorge
Date: Fri, 19 Jan 2024 18:44:58 +0100
Subject: [PATCH] [clang-format] Add MainIncludeChar option.
Resolves #27008, #3973
https://github.com/jansvoboda11 approved this pull request.
LGTM once CI passes and Flang conflicts are resolved.
https://github.com/llvm/llvm-project/pull/75530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/78489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1401,17 +1406,48 @@ void AsmPrinter::emitBBAddrMapSection(const
MachineFunction &MF) {
uint8_t BBAddrMapVersion = OutStreamer->getContext().getBBAddrMapVersion();
OutStreamer->emitInt8(BBAddrMapVersion);
OutStreamer->AddComment("feature");
- auto FeaturesBits = stat
https://github.com/Leporacanthicus created
https://github.com/llvm/llvm-project/pull/78755
This adds the support to add the target-feature.
It will be fully supported once the generic support for adding target-cpu and
target-features attributes to functions has landed. See #78289. Regression
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Mats Petersson (Leporacanthicus)
Changes
This adds the support to add the target-feature.
It will be fully supported once the generic support for adding target-cpu and
target-features attributes to functi
https://github.com/NorthBlue333 updated
https://github.com/llvm/llvm-project/pull/77456
>From 490343ec3461a8a3a5703198f6b9af57a853ef24 Mon Sep 17 00:00:00 2001
From: NorthBlue333
Date: Tue, 9 Jan 2024 14:01:14 +0100
Subject: [PATCH] [clang-format] Do not update cursor pos if no includes
replac
https://github.com/NorthBlue333 updated
https://github.com/llvm/llvm-project/pull/77456
>From 7ee61d585faf393921f8964451ddc97e4cfb7444 Mon Sep 17 00:00:00 2001
From: NorthBlue333
Date: Tue, 9 Jan 2024 14:01:14 +0100
Subject: [PATCH] [clang-format] Do not update cursor pos if no includes
replac
AaronBallman wrote:
I had an offline discussion with @Endilll during my morning office hours today,
and our current plan is:
1) Remove `Implicit` from the enumeration, rename `Call` and `List` to
`ParenList` and `BraceList`, respectively
2) Add a new bit to the bit-field for `CXXNewExpr` to tr
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 42b160356fe5d3b41bf07c428d0142d3721b1d44
490343ec3461a8a3a5703198f6b9af57a853ef24 --
https://github.com/NorthBlue333 updated
https://github.com/llvm/llvm-project/pull/77456
>From 1c794e5544d5f4d1a73a4410a00412f445e5c1f9 Mon Sep 17 00:00:00 2001
From: NorthBlue333
Date: Tue, 9 Jan 2024 14:01:14 +0100
Subject: [PATCH] [clang-format] Do not update cursor pos if no includes
replac
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 1/7] Fix : more detailed no expected directive message
---
clang
https://github.com/mmoadeli created
https://github.com/llvm/llvm-project/pull/78759
- Address space cast of nullptr in local_space into a generic_space for the
CUDA backend. The reason for this cast was having invalid local memory base
address for the associated variable.
- In the context of A
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (mmoadeli)
Changes
- Address space cast of nullptr in local_space into a generic_space for the
CUDA backend. The reason for this cast was having invalid local memory base
address for the associated variable.
- In the context of AMD G
@@ -11,7 +11,7 @@
#error
// expected-error@-1 {{}}
-// CHECK: error: no expected directives found: consider use of
'expected-no-diagnostics'
+// CHECK: error: no expected directives found: consider use of
'{{.*}}-no-diagnostics'
Sh0g0-1758 wrote:
https://github.com/bd1976bris updated
https://github.com/llvm/llvm-project/pull/74629
>From 5bae541608ffacfee767da592afe65003ccdad79 Mon Sep 17 00:00:00 2001
From: Ben Dunbobbin
Date: Wed, 6 Dec 2023 15:47:52 +
Subject: [PATCH 1/2] Add a "don't override" mapping for
-fvisibility-from-dllst
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 51afb101743855e2ae2624ebbe087da77128d92c
75c02dbdc6ce9ba6a7b9df47ff9540943f543f9f --
Sh0g0-1758 wrote:
Please see the desired behavior in this screenshot :
With `-verify=` we get `expected-no-diagnostics` and with `-verify=foo` we get
`foo-no-dia
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 1/8] Fix : more detailed no expected directive message
---
clang
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?=
Message-ID:
In-Reply-To:
https://github.com/NagyDonat approved this pull request.
https://github.com/llvm/llvm-project/pull/78180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -318,17 +396,87 @@ static Messages getTaintMsgs(const SubRegion *Region,
const char *OffsetName) {
RegName, OffsetName)};
}
-void ArrayBoundCheckerV2::performCheck(const Expr *E, CheckerContext &C) const
{
- // NOTE: Instead of using ProgramState::assum
=?utf-8?q?Balázs_Kéri?= ,
=?utf-8?q?Balázs_Kéri?= ,
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
@@ -2201,6 +2214,56 @@ void StdLibraryFunctionsChecker::initFunctionSummaries(
ErrnoNEZeroIrrelevant, GenericFailureMsg)
.ArgConstraint(NotNull(A
https://github.com/wheatman updated
https://github.com/llvm/llvm-project/pull/78742
>From 58d6df871eed40db23a4f182f9cb7989de1b2677 Mon Sep 17 00:00:00 2001
From: Brian Wheatman
Date: Fri, 19 Jan 2024 11:13:33 -0500
Subject: [PATCH] [clang][Sema] Fix for enums overflowing (#24667)
Enums which d
Author: Min-Yih Hsu
Date: 2024-01-19T11:09:35-08:00
New Revision: 5330daad41d761aaa1aea554dbeca7c050da7fb6
URL:
https://github.com/llvm/llvm-project/commit/5330daad41d761aaa1aea554dbeca7c050da7fb6
DIFF:
https://github.com/llvm/llvm-project/commit/5330daad41d761aaa1aea554dbeca7c050da7fb6.diff
L
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= ,
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= ,
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?=
Message-ID:
In-Reply-To:
https://github.com/NagyDonat approved this pull request.
https://github.com/llvm/llvm-project/pull/76979
___
cfe-commi
https://github.com/mshockwave closed
https://github.com/llvm/llvm-project/pull/78489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
@uweigand
Thanks for the analysis. `bot = alloca(i);` is a dynamic alloca that cannot be
optimized out.
It triggers `FunctionStackPoisoner::createDynamicAllocasInitStorage`, which
creates an alloca of 32-byte alignment.
In x86-64, aarch64, riscv, and others, the alloca translat
@@ -3924,6 +3925,154 @@ class ASTDeclContextNameLookupTrait {
} // namespace
+namespace {
+class SpecializationsLookupTrait {
+ ASTWriter &Writer;
+ llvm::SmallVector DeclIDs;
+
+public:
+ using key_type = unsigned;
+ using key_type_ref = key_type;
+
+ /// A start and en
https://github.com/ahatanak created
https://github.com/llvm/llvm-project/pull/78763
The option allows users to enable libc++ hardening, which was discussed in the
following RFC:
https://discourse.llvm.org/t/rfc-hardening-in-libc/73925
Users specifiy the hardening mode by passing one of the fo
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Akira Hatanaka (ahatanak)
Changes
The option allows users to enable libc++ hardening, which was discussed in the
following RFC:
https://discourse.llvm.org/t/rfc-hardening-in-libc/73925
Users specifiy the hardening mode by passing
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78400
>From c3856543fd56ec33bab6bcdcd3d833c0e19f58f9 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Wed, 17 Jan 2024 14:16:34 +0800
Subject: [PATCH] fix
---
clang/lib/Sema/SemaTemplateInstantiate.cpp | 12 ++--
vgvassilev wrote:
@vitalybuka, thank you!
I am trying to add a fix but I get `unsupported option '-fsanitize=hwaddress'
for target 'x86_64-apple-darwin21.6.0'`. If you have a compatible platform, do
you mind testing:
```diff
diff --git a/clang/unittests/Interpreter/InterpreterTest.cpp
b/clan
cor3ntin wrote:
@antangelo do you need me to merge this for you?
https://github.com/llvm/llvm-project/pull/78670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/78682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/78712
>From 1c17da188035ec39c23c62f9f467cfbee05f4f63 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Fri, 19 Jan 2024 14:40:38 +0100
Subject: [PATCH] CI Test - Please ignore
---
clang/utils/ci/buildkite-pipel
mbrkusanin wrote:
Rebased.
https://github.com/llvm/llvm-project/pull/77795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HazardyKnusperkeks requested changes to this pull request.
I think splitting the two features would be better.
Also please add a note to the changelog.
https://github.com/llvm/llvm-project/pull/77918
___
cfe-commits mailing list
cfe
https://github.com/HazardyKnusperkeks edited
https://github.com/llvm/llvm-project/pull/77918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2459,6 +2459,52 @@ struct FormatStyle {
/// \version 12
EmptyLineBeforeAccessModifierStyle EmptyLineBeforeAccessModifier;
+ /// \brief Number of lines after includes.
+ /// If set, determines the number of lines to insert after includes.
+ /// Limited by MaxEmptyLin
@@ -2459,6 +2459,52 @@ struct FormatStyle {
/// \version 12
EmptyLineBeforeAccessModifierStyle EmptyLineBeforeAccessModifier;
+ /// \brief Number of lines after includes.
+ /// If set, determines the number of lines to insert after includes.
+ /// Limited by MaxEmptyLin
@@ -0,0 +1,70 @@
+//===--- TopLevelCommentSeparator.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -1035,6 +1039,8 @@ template <> struct MappingTraits {
IO.mapOptional("MaxEmptyLinesToKeep", Style.MaxEmptyLinesToKeep);
IO.mapOptional("NamespaceIndentation", Style.NamespaceIndentation);
IO.mapOptional("NamespaceMacros", Style.NamespaceMacros);
+IO.mapOption
@@ -2459,6 +2459,52 @@ struct FormatStyle {
/// \version 12
EmptyLineBeforeAccessModifierStyle EmptyLineBeforeAccessModifier;
+ /// \brief Number of lines after includes.
+ /// If set, determines the number of lines to insert after includes.
+ /// Limited by MaxEmptyLin
@@ -26846,6 +26846,26 @@ TEST_F(FormatTest, BreakAdjacentStringLiterals) {
Style.BreakAdjacentStringLiterals = false;
verifyFormat(Code, Style);
}
+
+TEST_F(FormatTest, EmptyLinesAfterInclude) {
+ auto Style = getLLVMStyle();
+ Style.EmptyLinesAfterIncludes = 2;
+ Style.
@@ -0,0 +1,70 @@
+//===--- TopLevelCommentSeparator.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,112 @@
+//===- unittest/Format/TopLevelCommentSeparatorTest.cpp - Formatting unit tests
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Id
@@ -4827,6 +4873,8 @@ struct FormatStyle {
DerivePointerAlignment == R.DerivePointerAlignment &&
DisableFormat == R.DisableFormat &&
EmptyLineAfterAccessModifier == R.EmptyLineAfterAccessModifier &&
+ EmptyLinesAfterIncludes == R.Empty
@@ -26846,6 +26846,26 @@ TEST_F(FormatTest, BreakAdjacentStringLiterals) {
Style.BreakAdjacentStringLiterals = false;
verifyFormat(Code, Style);
}
+
+TEST_F(FormatTest, EmptyLinesAfterInclude) {
+ auto Style = getLLVMStyle();
+ Style.EmptyLinesAfterIncludes = 2;
+ Style.
jplehr wrote:
> Automatic zero-copy doesn't work on some of the bbot's. I will have to land
> this once the lit test harness extension in #77851 re-lands.
Having your work landed would be very helpful indeed.
https://github.com/llvm/llvm-project/pull/76571
_
@@ -138,13 +138,20 @@ struct TypeErasedDataflowAnalysisState {
/// dataflow analysis cannot be performed successfully. Otherwise, calls
/// `PostVisitCFG` on each CFG element with the final analysis results at that
/// program point.
+///
+/// `MaxBlockVisits` caps the number o
@@ -186,6 +186,14 @@ template struct DataflowAnalysisState {
/// the dataflow analysis cannot be performed successfully. Otherwise, calls
/// `PostVisitCFG` on each CFG element with the final analysis results at that
/// program point.
+///
+/// `MaxBlockVisits` caps the numbe
@@ -138,13 +138,20 @@ struct TypeErasedDataflowAnalysisState {
/// dataflow analysis cannot be performed successfully. Otherwise, calls
/// `PostVisitCFG` on each CFG element with the final analysis results at that
/// program point.
+///
+/// `MaxBlockVisits` caps the number o
@@ -261,14 +270,23 @@ auto createAnalysis(ASTContext &ASTCtx, Environment &Env)
/// iterations.
/// - This limit is still low enough to keep runtimes acceptable (on typical
/// machines) in cases where we hit the limit.
+///
+/// `MaxBlockVisits` caps the number of block vi
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/78571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/77699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/77481
>From 02f3e6ad46db8df8256ec15f3388399f24eaafad Mon Sep 17 00:00:00 2001
From: Yitzhak Mandelbaum
Date: Thu, 4 Jan 2024 15:36:40 +
Subject: [PATCH 1/3] [clang][dataflow] Make cap on block visits configurable
by
@@ -186,6 +186,14 @@ template struct DataflowAnalysisState {
/// the dataflow analysis cannot be performed successfully. Otherwise, calls
/// `PostVisitCFG` on each CFG element with the final analysis results at that
/// program point.
+///
+/// `MaxBlockVisits` caps the numbe
https://github.com/HazardyKnusperkeks requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/78752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3392,6 +3392,24 @@ the configuration (without a prefix: ``Auto``).
Priority:1
SortPriority:0
+.. _MainIncludeChar:
HazardyKnusperkeks wrote:
Did you add this by hand? I'm wondering why it has a different order than in
the head
https://github.com/HazardyKnusperkeks edited
https://github.com/llvm/llvm-project/pull/78752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -151,6 +151,21 @@ struct IncludeStyle {
/// before any other include.
/// \version 10
std::string IncludeIsMainSourceRegex;
+
+ /// Character to consider in the include directives for the main header.
+ enum MainIncludeCharDiscriminator {
+/// Main include uses q
@@ -151,6 +151,21 @@ struct IncludeStyle {
/// before any other include.
/// \version 10
std::string IncludeIsMainSourceRegex;
+
+ /// Character to consider in the include directives for the main header.
+ enum MainIncludeCharDiscriminator {
HazardyKnus
@@ -0,0 +1,27 @@
+// Test the combination of regrouped include directives, via regexes and
HazardyKnusperkeks wrote:
Our tests reside in `clang/unittests/Format/SortIncludesTest.cpp`.
https://github.com/llvm/llvm-project/pull/78752
__
@@ -151,6 +151,21 @@ struct IncludeStyle {
/// before any other include.
/// \version 10
std::string IncludeIsMainSourceRegex;
+
+ /// Character to consider in the include directives for the main header.
HazardyKnusperkeks wrote:
It should also be added
cor3ntin wrote:
Let me merge that lest I forget. Our windows bots have a lot of issues
https://github.com/llvm/llvm-project/pull/77768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
301 - 400 of 583 matches
Mail list logo
