cor3ntin wrote:
Thanks for the patch!
Requires Expressions should be in an unevaluated context, so we should never
try to capture variables they mentioned.
Maybe we need to test the evaluation context in either `tryCaptureVariable` or
`NeedToCaptureVariable`, rather than a specific handling f
@@ -0,0 +1,149 @@
+// RUN: %check_clang_tidy %s readability-use-std-min-max %t
+
+#define MY_MACRO_MIN(a, b) ((a) < (b) ? (a) : (b))
+
+constexpr int myConstexprMin(int a, int b) {
+ return a < b ? a : b;
+}
+
+constexpr int myConstexprMax(int a, int b) {
+ return a > b ? a : b;
https://github.com/erichkeane commented:
I think this needs a 'merge' to get rid of the }}} patch changes from its diff,
but I'm in favor of the patch otherwise. Probably could use a release note,
and a look over @cor3ntin or @cjdb perhaps?
https://github.com/llvm/llvm-project/pull/74852
___
https://github.com/11happy edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mordante approved this pull request.
> LGTM. @mordante could you please have another look if the current state
> addressed your concerns?
Yes looks fine to me.
https://github.com/llvm/llvm-project/pull/71819
___
cfe-commits mailing
@@ -0,0 +1,149 @@
+// RUN: %check_clang_tidy %s readability-use-std-min-max %t
+
+#define MY_MACRO_MIN(a, b) ((a) < (b) ? (a) : (b))
+
+constexpr int myConstexprMin(int a, int b) {
+ return a < b ? a : b;
+}
+
+constexpr int myConstexprMax(int a, int b) {
+ return a > b ? a : b;
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/78243
>From 2bb667e61d2f07d216e6744d72d8b73a638f2d5d Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Fri, 12 Jan 2024 13:45:15 -0500
Subject: [PATCH 1/2] [Clang][Parse] Diagnose member template declarations
@@ -804,6 +806,46 @@ void FormatTokenLexer::handleTableGenMultilineString() {
FirstLineText, MultiLineString->OriginalColumn, Style.TabWidth,
Encoding);
}
+void FormatTokenLexer::handleTableGenNumericLikeIdentifier() {
+ FormatToken *Tok = Tokens.back();
+ // TableGen
https://github.com/math-fehr closed
https://github.com/llvm/llvm-project/pull/76400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -457,7 +457,7 @@ TargetPassConfig
*PPCTargetMachine::createPassConfig(PassManagerBase &PM) {
void PPCPassConfig::addIRPasses() {
if (TM->getOptLevel() != CodeGenOptLevel::None)
addPass(createPPCBoolRetToIntPass());
- addPass(createAtomicExpandPass());
+ addPass(crea
ilya-biryukov wrote:
We saw some failures internally with this patch:
- ` "'absl::AnyInvocable' has different definitions in different
modules;". `
Probably related to the template arguments stability you mention.
- `"No type named 'MemberType' in 'some_object::Traits'"`.
I suspect that's e
https://github.com/Ris-Bali edited
https://github.com/llvm/llvm-project/pull/71220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
@@ -1112,6 +1121,140 @@ prepareAndFilterRanges(const
SmallVectorImpl &Ranges,
return LineRanges;
}
+/// Creates syntax highlighting information in form of StyleRanges.
+///
+/// The returned unique ptr has always exactly si
Author: Joseph Huber
Date: 2024-01-18T10:42:13-06:00
New Revision: 2b804f875579995b1588f1a079e265929163d0e4
URL:
https://github.com/llvm/llvm-project/commit/2b804f875579995b1588f1a079e265929163d0e4
DIFF:
https://github.com/llvm/llvm-project/commit/2b804f875579995b1588f1a079e265929163d0e4.diff
https://github.com/mordante approved this pull request.
> Thanks. The documentation build fails due to some CMake error consistently
> otherwise I believe I addressed all comments.
I think I fixed this a few days ago.
LGTM modulo 1 nit.
https://github.com/llvm/llvm-project/pull/78157
___
https://github.com/mordante edited
https://github.com/llvm/llvm-project/pull/78157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,38 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -5,39 +5,134 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===--===//
+
// UNSUPPORTED: c++03, c++11, c++14, c++17
//
-#include
+// constexpr explicit(extent != dynamic_extent)
Author: Joseph Huber
Date: 2024-01-18T10:56:33-06:00
New Revision: cb2f340850db007aebf5012858697ba5afc1ce4e
URL:
https://github.com/llvm/llvm-project/commit/cb2f340850db007aebf5012858697ba5afc1ce4e
DIFF:
https://github.com/llvm/llvm-project/commit/cb2f340850db007aebf5012858697ba5afc1ce4e.diff
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/69498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
What I don't want to lose from this patch are the changes to places like
`InitializationStyle getInitializationStyle() const` and
`CXXNewExpr::CXXNewExpr` where the old code was unclear and the new code is
significantly more clear. We should not be performing math on the en
zygoloid wrote:
> When you say that we can't detect what the front-end considers the "closest
> surrounding subobject" to be, is that mostly due to corner cases or is it a
> more general concern?
It's a more general concern: LLVM simply has no idea what the frontend
considers to be a subobjec
@@ -342,331 +342,331 @@ let TargetGuard = "sme2" in {
//
let TargetGuard = "sme2" in {
- def SVSMOPA : Inst<"svmopa_za32[_{d}]_m", "viPPdd", "s", MergeNone,
"aarch64_sme_smopa_za32", [IsSharedZA, IsStreaming], [ImmCheck<0,
ImmCheck0_3>]>;
- def SVUSMOPA : Inst<"svmopa_za3
zyn0217 wrote:
I think this also fixes https://github.com/llvm/llvm-project/issues/63845 and
the example in
https://github.com/llvm/llvm-project/issues/41751#issuecomment-1696389046.
https://github.com/llvm/llvm-project/pull/78598
___
cfe-commits mai
Fznamznon wrote:
> Should we still emit shadowing warning in case lambda captured this and has
> an init-capture with the same name as a class field?
Yes, we should probably do that.
I'm struggling with detecting the following case:
```
struct A {
int b = 5;
int foo() {
return [b = b,
https://github.com/philnik777 commented:
LGTM % nit.
https://github.com/llvm/llvm-project/pull/69498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/69498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7,6 +7,8 @@
//===--===//
#include <__memory/aligned_alloc.h>
+#include <__overridable_function>
philnik777 wrote:
We already have `#include "include/refstring.h" // from libc++` inside
https://github.com/philnik777 approved this pull request.
https://github.com/llvm/llvm-project/pull/69498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -70,6 +70,10 @@ def warn_pragma_debug_missing_argument : Warning<
def warn_pragma_debug_unexpected_argument : Warning<
"unexpected argument to debug command">, InGroup;
+def warn_fp_nan_inf_when_disabled : Warning<
+ "use of %select{infinity|NaN}0%select{| via a macro}1
@@ -0,0 +1,273 @@
+// RUN: %clang_cc1 -x c++ -verify -triple powerpc64le-unknown-unknown %s \
+// RUN: -menable-no-infs -menable-no-nans -DFAST=1
+
+// RUN: %clang_cc1 -x c++ -verify -triple powerpc64le-unknown-unknown %s \
+// RUN: -DNOFAST=1
+
+// RUN: %clang_cc1 -x c++ -verify
Author: Vlad Serebrennikov
Date: 2024-01-18T20:25:18+03:00
New Revision: 30da0f5a359ab4a684c5fdf0f4dbed20bae10f99
URL:
https://github.com/llvm/llvm-project/commit/30da0f5a359ab4a684c5fdf0f4dbed20bae10f99
DIFF:
https://github.com/llvm/llvm-project/commit/30da0f5a359ab4a684c5fdf0f4dbed20bae10f99.
Endilll wrote:
@nico I tried to address this in 30da0f5a359ab4a684c5fdf0f4dbed20bae10f99
https://github.com/llvm/llvm-project/pull/77637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mordante requested changes to this pull request.
Thanks I think this is getting close, I would like to see it again after
addressing the comments.
https://github.com/llvm/llvm-project/pull/77967
___
cfe-commits mailing list
cfe-comm
@@ -0,0 +1,75 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,76 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/mordante edited
https://github.com/llvm/llvm-project/pull/77967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,157 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,281 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,267 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,267 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,119 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,281 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,267 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,281 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/llvm-beanz approved this pull request.
Sorry for my delayed review. LGTM.
https://github.com/llvm/llvm-project/pull/76749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
@@ -136,10 +136,10 @@ defm SVWRITE_ZA128 : ZAWrite<"za128", "csilUcUsUiUlhbfd",
"aarch64_sme_writeq",
let TargetGuard = "sme" in {
def SVZERO_MASK_ZA : SInst<"svzero_mask_za", "vi", "", MergeNone,
"aarch64_sme_zero",
- [IsOverloadNone, IsStreami
@@ -1720,21 +1720,29 @@ void SVEEmitter::createBuiltinZAState(raw_ostream &OS) {
for (auto *R : RV)
createIntrinsic(R, Defs);
- std::map> DefsZAState;
-
- uint64_t IsSharedZAFlag = getEnumValueForFlag("IsSharedZA");
+ std::map> IntrinsicsPerState;
for (auto &Def :
@@ -102,3 +102,8 @@ svint8_t missing_za(svint8_t zd, svbool_t pg, uint32_t
slice_base) __arm_streami
// expected-warning@+1 {{builtin call is not valid when calling from a
function without active ZA state}}
return svread_hor_za8_s8_m(zd, pg, 0, slice_base);
}
+
+__arm_n
@@ -3005,6 +3005,15 @@ enum ArmStreamingType {
ArmStreamingOrSVE2p1
};
+enum ArmSMEState : unsigned {
+ ArmNoState = 0,
+
+ ArmInZA = 0b01,
+ ArmOutZA = 0b10,
+ ArmInOutZA = 0b11,
+ ArmZAMask = 0b11,
MDevereau wrote:
```suggestion
ArmZAMask = ArmInOu
@@ -1720,21 +1720,29 @@ void SVEEmitter::createBuiltinZAState(raw_ostream &OS) {
for (auto *R : RV)
createIntrinsic(R, Defs);
- std::map> DefsZAState;
-
- uint64_t IsSharedZAFlag = getEnumValueForFlag("IsSharedZA");
+ std::map> IntrinsicsPerState;
for (auto &Def :
@@ -342,331 +342,331 @@ let TargetGuard = "sme2" in {
//
let TargetGuard = "sme2" in {
- def SVSMOPA : Inst<"svmopa_za32[_{d}]_m", "viPPdd", "s", MergeNone,
"aarch64_sme_smopa_za32", [IsSharedZA, IsStreaming], [ImmCheck<0,
ImmCheck0_3>]>;
- def SVUSMOPA : Inst<"svmopa_za3
sudonatalie wrote:
Rebased again and local `check-all` succeeds.
https://github.com/llvm/llvm-project/pull/76749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Natalie Chouinard
Date: 2024-01-18T12:52:00-05:00
New Revision: c21f48e5ad1799db41cc9f16541b8365e3b75e63
URL:
https://github.com/llvm/llvm-project/commit/c21f48e5ad1799db41cc9f16541b8365e3b75e63
DIFF:
https://github.com/llvm/llvm-project/commit/c21f48e5ad1799db41cc9f16541b8365e3b75e63.d
https://github.com/sudonatalie closed
https://github.com/llvm/llvm-project/pull/76749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76451
>From f3f0db64da4d341f8e4a2054f9f25c87f8eda829 Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 27 Dec 2023 17:34:10 +0100
Subject: [PATCH 1/5] [clang][modules] Print library module manifest path.
This i
@@ -0,0 +1,149 @@
+// RUN: %check_clang_tidy %s readability-use-std-min-max %t
+
+#define MY_MACRO_MIN(a, b) ((a) < (b) ? (a) : (b))
+
+constexpr int myConstexprMin(int a, int b) {
+ return a < b ? a : b;
+}
+
+constexpr int myConstexprMax(int a, int b) {
+ return a > b ? a : b;
https://github.com/rjmccall approved this pull request.
LGTM as far as my requests; please wait for approval from the other reviewers.
This is unrelated, but I wonder if we should proactively outline this sequence;
it's quite long.
https://github.com/llvm/llvm-project/pull/78330
__
https://github.com/H-G-Hristov updated
https://github.com/llvm/llvm-project/pull/78215
>From 328c55879848d98a9bc068436d959b409b239bcc Mon Sep 17 00:00:00 2001
From: Zingam
Date: Thu, 11 Jan 2024 09:46:26 +0200
Subject: [PATCH 1/2] [libc++][any] LWG3305: `any_cast`
Implements: https://wg21.link
@@ -2186,11 +2178,43 @@ static void createBodyOfOp(
const llvm::SmallVector &args = {},
bool outerCombined = false, DataSharingProcessor *dsp = nullptr) {
fir::FirOpBuilder &firOpBuilder = converter.getFirOpBuilder();
+
+ auto insertMarker = [](fir::FirOpBuilder &bui
@@ -2223,37 +2247,64 @@ static void createBodyOfOp(
mlir::omp::YieldOp>(
firOpBuilder, eval.getNestedEvaluations());
- // Insert the terminator.
- Fortran::lower::genOpenMPTerminator(firOpBuilder, op.getOperation(), loc);
-
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/76365
>From 5ece73a5b14e86172b900f4ae9d63d8fa1590d4a Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Mon, 25 Dec 2023 16:18:45 +
Subject: [PATCH 1/3] [clang-tidy] Add bugprone-chained-comparison check
Check that
jrtc27 wrote:
I guess Zaamo + Zacas is technically a way one could implement atomics without
LR/SC?
https://github.com/llvm/llvm-project/pull/77424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
efriedma-quic wrote:
clang has never emitted diagnostics for failure to inline an always_inline
function. But if gcc is doing it, maybe defaulting to an error isn't such a
big deal.
Separately, it's probably worth ensuring that the LLVM inlining passes don't
actually perform illegal inlining
aeubanks wrote:
should this have had a test? I'm trying to do the same thing for
`-mlarge-data-threshold` and am trying to find an appropriate place to add a
test
https://github.com/llvm/llvm-project/pull/70740
___
cfe-commits mailing list
cfe-commit
@@ -11,6 +11,7 @@
//===--===//
#include "SystemZ.h"
+#include "clang/AST/Decl.h"
efriedma-quic wrote:
If I recall correctly, in certain build configurations, like if you enable
shared libra
dtcxzyw wrote:
> I guess Zaamo + Zacas is technically a way one could implement atomics
> without LR/SC?
The Zacas extension depends upon the A extension.
https://github.com/llvm/llvm-project/pull/77424
___
cfe-commits mailing list
cfe-commits@lists
topperc wrote:
> > I guess Zaamo + Zacas is technically a way one could implement atomics
> > without LR/SC?
>
> The Zacas extension depends upon the A extension.
I filed an issue asking about that
https://github.com/riscv/riscv-zaamo-zalrsc/issues/5
https://github.com/llvm/llvm-project/pull
https://github.com/H-G-Hristov updated
https://github.com/llvm/llvm-project/pull/78157
>From 01f0ed005f2037fa4a4ec64ad5e1a114da1f5e99 Mon Sep 17 00:00:00 2001
From: Zingam
Date: Thu, 11 Jan 2024 10:42:55 +0200
Subject: [PATCH 1/9] [libc++][span] P2447R4: `std::span` over an initializer
list
I
topperc wrote:
Can we split the CodeGen part out of this patch?
https://github.com/llvm/llvm-project/pull/77424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> This is unrelated, but I wonder if we should proactively outline this
> sequence; it's quite long.
Not sure what you mean.
https://github.com/llvm/llvm-project/pull/78330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/H-G-Hristov updated
https://github.com/llvm/llvm-project/pull/78157
>From 01f0ed005f2037fa4a4ec64ad5e1a114da1f5e99 Mon Sep 17 00:00:00 2001
From: Zingam
Date: Thu, 11 Jan 2024 10:42:55 +0200
Subject: [PATCH 01/10] [libc++][span] P2447R4: `std::span` over an initializer
list
https://github.com/H-G-Hristov updated
https://github.com/llvm/llvm-project/pull/78562
>From fadaafbf791d5fe78f6ac9ee3494b128339781ba Mon Sep 17 00:00:00 2001
From: Zingam
Date: Thu, 18 Jan 2024 09:47:40 +0200
Subject: [PATCH 1/3] [libc++][memory] P2868R1 - Removing deprecated typedef
`std::al
https://github.com/sudonatalie created
https://github.com/llvm/llvm-project/pull/78611
Add the -fspv-target-env option to the clang-dxc compatibility driver to
specify the SPIR-V target environment, which is propagated to the target Triple.
>From d950de9ff25efdb81492eb630ba190a75c2762cf Mon Se
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Natalie Chouinard (sudonatalie)
Changes
Add the -fspv-target-env option to the clang-dxc compatibility driver to
specify the SPIR-V target environment, which is propagated to the target Triple.
---
Full diff: https://github.com/llvm/llvm-
https://github.com/H-G-Hristov updated
https://github.com/llvm/llvm-project/pull/78562
>From fadaafbf791d5fe78f6ac9ee3494b128339781ba Mon Sep 17 00:00:00 2001
From: Zingam
Date: Thu, 18 Jan 2024 09:47:40 +0200
Subject: [PATCH 1/4] [libc++][memory] P2868R1 - Removing deprecated typedef
`std::al
https://github.com/H-G-Hristov updated
https://github.com/llvm/llvm-project/pull/78562
>From fadaafbf791d5fe78f6ac9ee3494b128339781ba Mon Sep 17 00:00:00 2001
From: Zingam
Date: Thu, 18 Jan 2024 09:47:40 +0200
Subject: [PATCH 1/5] [libc++][memory] P2868R1 - Removing deprecated typedef
`std::al
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/78613
These are largely copy-pasted from the corresponding function descriptions.
Updated _rdtsc definition because it was just plain wrong.
>From e4c9272ee9cbb918347a23d2dce14c9c12765009 Mon Sep 17 00:00:00 2001
From:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Paul T Robinson (pogo59)
Changes
These are largely copy-pasted from the corresponding function descriptions.
Updated _rdtsc definition because it was just plain wrong.
---
Full diff: https://github.com/llvm/llvm-project/pull/78613.diff
@@ -0,0 +1,40 @@
+// Test that -print-library-module-manifest-path finds the correct file.
+
+// RUN: rm -rf %t
MaskRay wrote:
You can remove `mkdir -p %t` and simplify this to `rm -rf %t && split-file %s
%t && cd %t`. This does place 3 commands on one line, but
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From 1ac47a1548f0dbd21747ef05c64fc2f08668e0e1 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH] [clang] Fix parenthesized list initialization of arrays not
working
pogo59 wrote:
Reviewer questions:
1. When a macro is merely an alternate name for an intrinsic function, does it
want to be documented as its own intrinsic function? I assume yes in this
patch, but if there's a different tactic that avoids duplicating a bunch of
descriptions, I'm open to sugge
Good point! Thanks!
On Wed, Jan 17, 2024 at 3:34 PM David Blaikie wrote:
> In general, if the lambda is only used within its scope, I'd suggest
> switching to a default ref capture "[&]" to reduce maintenance burden of
> keeping the capture list up to date.
>
> On Thu, Jan 11, 2024 at 12:09 PM
Author: Alan Zhao
Date: 2024-01-18T10:53:54-08:00
New Revision: 2c9f04c98a1922d711fd1a88563506ee75c771bf
URL:
https://github.com/llvm/llvm-project/commit/2c9f04c98a1922d711fd1a88563506ee75c771bf
DIFF:
https://github.com/llvm/llvm-project/commit/2c9f04c98a1922d711fd1a88563506ee75c771bf.diff
LOG
https://github.com/alanzhao1 closed
https://github.com/llvm/llvm-project/pull/76976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/76451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,40 @@
+// Test that -print-library-module-manifest-path finds the correct file.
+
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+// RUN: touch %t/libc++.so
+// RUN: split-file %s %t
+// RUN: cd %t
+
+// RUN: %clang -print-library-module-manifest-path \
+// RUN: -stdlib=li
https://github.com/minglotus-6 updated
https://github.com/llvm/llvm-project/pull/78610
>From 90074a8722090a9144d987b10ee59ff37891c109 Mon Sep 17 00:00:00 2001
From: mingmingl
Date: Thu, 11 Jan 2024 12:46:09 -0800
Subject: [PATCH] [CGProfile] Use callee's PGO name when caller->callee is an
indi
rjmccall wrote:
> > This is unrelated, but I wonder if we should proactively outline this
> > sequence; it's quite long.
>
> Not sure what you mean.
I mean that we could lazily emit a helper function like
`__clang_smiths_division_double` and call it instead of emitting like twenty
instructio
@@ -0,0 +1,254 @@
+//===--- RedundantCastingCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,254 @@
+//===--- RedundantCastingCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/70595
>From ff65fcca6047b0eebf73a87285dcff5f641a8ef0 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Tue, 10 Oct 2023 20:37:05 +
Subject: [PATCH 1/8] [clang-tidy] Add readability-redundant-casting check
Detects
vitalybuka wrote:
I guess buildkite/github-pull-requests is stuck
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Haopeng Liu
Date: 2024-01-18T11:10:16-08:00
New Revision: a58ad3e2a33eafc821714f9d27b74279fb4d607c
URL:
https://github.com/llvm/llvm-project/commit/a58ad3e2a33eafc821714f9d27b74279fb4d607c
DIFF:
https://github.com/llvm/llvm-project/commit/a58ad3e2a33eafc821714f9d27b74279fb4d607c.diff
L
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
andykaylor wrote:
@MaskRay I see that in 3bbc912d37f03d9ad3be330b81d91c2eaf6c37f2 you removed
some tests that fail because of this change. Why do you think that is an
appropriate solution? I have some other tests in a downstream product that are
failing because we build with CLANG_DEFAULT_PIE_
@@ -4212,6 +4213,89 @@ MachineSDNode *X86DAGToDAGISel::emitPCMPESTR(unsigned
ROpc, unsigned MOpc,
return CNode;
}
+// When the consumer of a right shift (arithmetic or logical) wouldn't
+// notice the difference if the instruction was a rotate right instead
+// (because the
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/76451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/76451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -602,6 +602,17 @@ class Driver {
// FIXME: This should be in CompilationInfo.
std::string GetProgramPath(StringRef Name, const ToolChain &TC) const;
+ /// GetStdModuleManifestPath - Lookup the path to the Standard library module
MaskRay wrote:
Remove
301 - 400 of 579 matches
Mail list logo
