https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/69340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2315,6 +2315,8 @@ bool UnwrappedLineParser::tryToParseLambdaIntroducer() {
if (Next->is(tok::greater))
return false;
}
+ if (tok::isLiteral(FormatTok->Tok.getKind()))
+return false;
XDeme wrote:
With this change this code will crash:
```cp
https://github.com/XDeme deleted https://github.com/llvm/llvm-project/pull/77045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1079,6 +1079,7 @@ clang-format
- Add ``ObjCPropertyAttributeOrder`` which can be used to sort ObjC property
attributes (like ``nonatomic, strong, nullable``).
- Add ``.clang-format-ignore`` files.
+- Add ``AlignFunctionPointers`` sub-option for
``AlignConsecutiveDeclarat
@@ -2315,6 +2315,8 @@ bool UnwrappedLineParser::tryToParseLambdaIntroducer() {
if (Next->is(tok::greater))
return false;
}
+ if (tok::isLiteral(FormatTok->Tok.getKind()))
+return false;
XDeme wrote:
With this change, a code like this will cras
https://github.com/XDeme updated https://github.com/llvm/llvm-project/pull/77045
>From d9cbbe48b96d27bff3fc926b60d039ed05f00489 Mon Sep 17 00:00:00 2001
From: XDeme
Date: Fri, 5 Jan 2024 01:23:16 -0300
Subject: [PATCH 1/8] [clang-format] Fix crash involving array designators and
dangling comma
https://github.com/XDeme edited https://github.com/llvm/llvm-project/pull/77045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2315,6 +2315,8 @@ bool UnwrappedLineParser::tryToParseLambdaIntroducer() {
if (Next->is(tok::greater))
return false;
}
+ if (tok::isLiteral(FormatTok->Tok.getKind()))
+return false;
owenca wrote:
You are right! Then how about the following
https://github.com/XDeme updated https://github.com/llvm/llvm-project/pull/77045
>From d9cbbe48b96d27bff3fc926b60d039ed05f00489 Mon Sep 17 00:00:00 2001
From: XDeme
Date: Fri, 5 Jan 2024 01:23:16 -0300
Subject: [PATCH 1/9] [clang-format] Fix crash involving array designators and
dangling comma
https://github.com/gedare updated
https://github.com/llvm/llvm-project/pull/69340
>From b4c8809a948799be51a35b10e4d9d303b78a98db Mon Sep 17 00:00:00 2001
From: Gedare Bloom
Date: Thu, 9 Nov 2023 09:30:24 -0700
Subject: [PATCH 01/10] Revert "Revert "[clang-format] Fix align consecutive
declarat
https://github.com/rymiel approved this pull request.
https://github.com/llvm/llvm-project/pull/77045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aqjune updated
https://github.com/llvm/llvm-project/pull/77281
>From 1bbfe05bc50e1fbdb207f21a178b6fc7ab24e8cf Mon Sep 17 00:00:00 2001
From: Juneyoung Lee
Date: Mon, 8 Jan 2024 02:01:41 -0600
Subject: [PATCH 1/3] [WebAssembly] Correctly consider signext/zext arg flags
at fun
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/77534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/77045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/77556
None
>From 42d64ab78fe1c001e766fe2b94de167ae7bc6ddf Mon Sep 17 00:00:00 2001
From: Quentin Chateau
Date: Mon, 18 Sep 2023 03:01:03 -0400
Subject: [PATCH 1/4] [clangd] Support outgoing calls in call hierar
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Nathan Ridge (HighCommander4)
Changes
---
Patch is 49.27 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/77556.diff
23 Files Affected:
- (modified) clang-tools-extra/clangd/ClangdLSPServer.
HighCommander4 wrote:
(Not sure what happened here, the PR was somehow created while I was still
writing the description. Anyways, updating the title now.)
https://github.com/llvm/llvm-project/pull/77556
___
cfe-commits mailing list
cfe-commits@lists.
https://github.com/HighCommander4 edited
https://github.com/llvm/llvm-project/pull/77556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
Since Phabricator has been [taken
down](https://discourse.llvm.org/t/llvm-phabricator-turndown/76137), I'm
resubmitting the patch implementing outgoing calls in call hierarchy that was
previously posted at https://reviews.llvm.org/D93829.
Previous discussion can still be
Author: Owen Pan
Date: 2024-01-09T21:34:21-08:00
New Revision: b53628a52d1947c51e250d6fa4ff5dd12b737aa0
URL:
https://github.com/llvm/llvm-project/commit/b53628a52d1947c51e250d6fa4ff5dd12b737aa0
DIFF:
https://github.com/llvm/llvm-project/commit/b53628a52d1947c51e250d6fa4ff5dd12b737aa0.diff
LOG:
Author: Timm Bäder
Date: 2024-01-10T06:38:28+01:00
New Revision: c2b57a052daee22cb6401bc7bc514d858ea11eb6
URL:
https://github.com/llvm/llvm-project/commit/c2b57a052daee22cb6401bc7bc514d858ea11eb6
DIFF:
https://github.com/llvm/llvm-project/commit/c2b57a052daee22cb6401bc7bc514d858ea11eb6.diff
LO
aqjune wrote:
I checked that the CI has passed - thanks all!
https://github.com/llvm/llvm-project/pull/77281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aqjune closed https://github.com/llvm/llvm-project/pull/77281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bzEq created https://github.com/llvm/llvm-project/pull/77557
`ca` is not accepted in clobber list of inline assembly right now. Make `ca`
aliased to `xer`, so it can be accepted in clobber list.
Fixes #77549.
>From e1caee46dc81e59b8eab0379e200ca2a709801c3 Mon Sep 17 00:00:00
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kai Luo (bzEq)
Changes
`ca` is not accepted in clobber list of inline assembly right now. Make `ca`
aliased to `xer`, so it can be accepted in clobber list.
Fixes #77549.
---
Full diff: https://github.com/llvm/llvm-project/pull/77557.dif
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff db78c30ba772af1466bb0d0c1d376c8e642ee4a9
aaee97fb9f7bef5ff4e3f845fa29d45e9c7a83b0 --
https://github.com/bzEq updated https://github.com/llvm/llvm-project/pull/77557
>From e1caee46dc81e59b8eab0379e200ca2a709801c3 Mon Sep 17 00:00:00 2001
From: Kai Luo
Date: Wed, 10 Jan 2024 05:29:22 +
Subject: [PATCH 1/3] Alias
---
clang/lib/Basic/Targets/PPC.cpp | 2 +-
1 file changed, 1 i
https://github.com/evelez7 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/77451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
11happy wrote:
Are there any more changes for this PR required from my end?
https://github.com/llvm/llvm-project/pull/77194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8262,6 +8262,64 @@ SDValue TargetLowering::expandFMINNUM_FMAXNUM(SDNode
*Node,
return SDValue();
}
+SDValue TargetLowering::expandFMINIMUM_FMAXIMUM(SDNode *N,
+SelectionDAG &DAG) const {
+ SDLoc DL(N);
+ SDValue LHS = N-
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Brandon Wu (4vtomat)
Changes
[RISCV] RISCV vector calling convention (1/2)
This is the vector calling convention based on
https://github.com/riscv-non-isa/riscv-elf-psabi-doc,
the idea is to split between "scalar"
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7388b7422f9307dd5ae3fe3876a676d83d702daf
3e000d49ecc3769efa2051332c04163b84b0f9ae --
https://github.com/ecnelises updated
https://github.com/llvm/llvm-project/pull/67301
>From 92abb76631594dfc2ca586c46c38031610be0548 Mon Sep 17 00:00:00 2001
From: Qiu Chaofan
Date: Mon, 25 Sep 2023 17:08:59 +0800
Subject: [PATCH 1/6] [Legalizer] Expand fmaximum and fminimum
According to langre
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/77470
>From ae231d88c5b5e2e0996edefd45389992f8e97d05 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Tue, 9 Jan 2024 13:16:24 +
Subject: [PATCH 1/3] [AMDGPU] Precommit tests for broken combine
Add tests for sign-ext
https://github.com/ecnelises updated
https://github.com/llvm/llvm-project/pull/77412
>From 87e1d4acdd87d45f265e590ad135e21f352dc5ad Mon Sep 17 00:00:00 2001
From: Qiu Chaofan
Date: Tue, 9 Jan 2024 13:33:56 +0800
Subject: [PATCH 1/3] [Legalizer] Soften EXTRACT_ELEMENT on ppcf128
ppc_fp128 value
https://github.com/lukel97 updated
https://github.com/llvm/llvm-project/pull/77458
>From 53993a1f1eaf0f6dc336d45a94b8638c4119ba2e Mon Sep 17 00:00:00 2001
From: Luke Lau
Date: Tue, 9 Jan 2024 19:42:10 +0700
Subject: [PATCH 1/4] [RISCV] Add support for new unprivileged extensions
defined in pro
lukel97 wrote:
@asb I got a response from https://github.com/riscv/riscv-profiles/issues/139,
looks like Ziccrse, Ziccamoa, Za64rs, and Za128rs don't imply A.
https://github.com/llvm/llvm-project/pull/77458
___
cfe-commits mailing list
cfe-commits@lis
https://github.com/lukel97 updated
https://github.com/llvm/llvm-project/pull/77458
>From 53993a1f1eaf0f6dc336d45a94b8638c4119ba2e Mon Sep 17 00:00:00 2001
From: Luke Lau
Date: Tue, 9 Jan 2024 19:42:10 +0700
Subject: [PATCH 1/5] [RISCV] Add support for new unprivileged extensions
defined in pro
lukel97 wrote:
> These names will be used in profiles only, but I don't know if we should add
> them to RISCVUsage.rst.
Good point, I added them in anyway so we're consistent at least. I couldn't
find any other "featureless" extensions that we currently support.
https://github.com/llvm/llvm-p
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/77509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Bhuminjay Soni
Date: 2024-01-10T08:27:58+01:00
New Revision: efcf192a0a5993165f837ce71250fb6df689634b
URL:
https://github.com/llvm/llvm-project/commit/efcf192a0a5993165f837ce71250fb6df689634b
DIFF:
https://github.com/llvm/llvm-project/commit/efcf192a0a5993165f837ce71250fb6df689634b.diff
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/77194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM.
Do you need me to merge that for you?
https://github.com/llvm/llvm-project/pull/77552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/ecnelises updated
https://github.com/llvm/llvm-project/pull/76495
>From aaa11bc775b9aa3a0398ba2bbca4087e99f04243 Mon Sep 17 00:00:00 2001
From: Qiu Chaofan
Date: Thu, 28 Dec 2023 16:54:25 +0800
Subject: [PATCH 1/4] [PowerPC] Implement fence builtin
---
clang/include/clang/B
https://github.com/hahnjo edited https://github.com/llvm/llvm-project/pull/69076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hahnjo wrote:
> address my previous comment: [#69076
> (comment)](https://github.com/llvm/llvm-project/pull/69076#issuecomment-1780327252)
I had already expanded the commit message with the full details, now also
copied to the PR summary. Is that sufficient to address the comment?
https://git
cor3ntin wrote:
This looks like a duplicate of https://github.com/llvm/llvm-project/pull/77312
@danix800
https://github.com/llvm/llvm-project/pull/77312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
cor3ntin wrote:
This change needs a release note.
Please add an entry to `clang/docs/ReleaseNotes.rst` in the section the most
adapted to the change, and referencing any Github issue this change fixes.
Thanks!
https://github.com/llvm/llvm-project/pull/69076
jcsxky wrote:
> This looks like a duplicate of #77312 @danix800
The opposite is true. I will close this pr.
https://github.com/llvm/llvm-project/pull/77312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/77312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/77444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -42,6 +42,28 @@ namespace dr1611 { // dr1611: dup 1658
C c;
}
+namespace dr1626 { // dr1626: no open
+// FIXME: current consensus for CWG2335 is that the examples are well-formed.
cor3ntin wrote:
It is not clear from
https://www.open-std.org/jtc1/sc22/w
https://github.com/hahnjo updated
https://github.com/llvm/llvm-project/pull/69076
>From a55ca99a373b17501d56d18af9e8aa2dc2cbcea0 Mon Sep 17 00:00:00 2001
From: Jonas Hahnfeld
Date: Sat, 14 Oct 2023 20:10:28 +0200
Subject: [PATCH 1/3] Fix crash with modules and constexpr destructor
With modules
@@ -15754,10 +15754,18 @@ bool Expr::EvaluateAsInitializer(APValue &Value,
const ASTContext &Ctx,
LValue LVal;
LVal.set(VD);
-if (!EvaluateInPlace(Value, Info, LVal, this,
- /*AllowNonLiteralTypes=*/true) ||
-EStatus.HasSideEffects)
hahnjo wrote:
> Please add a release note
> This change needs a release note. Please add an entry to
> `clang/docs/ReleaseNotes.rst` in the section the most adapted to the change,
> and referencing any Github issue this change fixes. Thanks!
Done.
https://github.com/llvm/llvm-project/pull/69
https://github.com/cor3ntin approved this pull request.
LGTM modulo comment
https://github.com/llvm/llvm-project/pull/77444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hana =?utf-8?q?Dusi=CC=81kova=CC=81?=
Message-ID:
In-Reply-To:
https://github.com/cor3ntin approved this pull request.
LGTM
@hanickadot do you need me to merge that for you?
https://github.com/llvm/llvm-project/pull/77214
___
cfe-commits mailing lis
hanickadot wrote:
yes please, I don't have merge rights
https://github.com/llvm/llvm-project/pull/77214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/77465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1743,7 +1743,7 @@ bool CoroutineStmtBuilder::makeOnFallthrough() {
return false;
} else if (HasRVoid) {
Fallthrough = S.BuildCoreturnStmt(FD.getLocation(), nullptr,
- /*IsImplicit*/false);
+
https://github.com/cor3ntin approved this pull request.
LGTM modulo nit
https://github.com/llvm/llvm-project/pull/77465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM modulo comment
https://github.com/llvm/llvm-project/pull/77303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/77303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -613,15 +615,34 @@ static bool interp__builtin_ffs(InterpState &S, CodePtr
OpPC,
return true;
}
+static bool interp__builtin_addressof(InterpState &S, CodePtr OpPC,
+ const InterpFrame *Frame,
+ co
ChuanqiXu9 wrote:
Can you provide more context for this?
https://github.com/llvm/llvm-project/pull/77465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@AaronBallman this looks sensible. WDYT?
https://github.com/llvm/llvm-project/pull/71709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
501 - 566 of 566 matches
Mail list logo
