github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4ea5c603b4c4db36b8ee7e04adf96416f4d996dc
938019a3c34e322b6ead871dd66d973e50c084f1 --
erichkeane wrote:
> I think I've followed all the steps in
> https://llvm.org/docs/GitHub.html#landing-your-change except performing the
> actual merge (or squash), for which I lack write permissions. Is there
> anything else for me to do here?
Nope! I'll put this on my list to merge when te
sethp wrote:
Awesome, thank you for your help!
https://github.com/llvm/llvm-project/pull/77326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/muneebkhan85 updated
https://github.com/llvm/llvm-project/pull/77328
>From 91418f78aad0c994a49e9305516bd6bbb3d69d65 Mon Sep 17 00:00:00 2001
From: Muneeb Khan
Date: Tue, 7 Nov 2023 23:52:17 +0800
Subject: [PATCH 01/14] [MLIR][LLVM] Add Continuous Loop Peeling transform to
SC
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 036e48e2f5f890e1f9574cdb610e2336f12038a2
d0c6477734356ac3ce898deb84e069ddbfc0fead --
https://github.com/muneebkhan85 updated
https://github.com/llvm/llvm-project/pull/77328
>From 91418f78aad0c994a49e9305516bd6bbb3d69d65 Mon Sep 17 00:00:00 2001
From: Muneeb Khan
Date: Tue, 7 Nov 2023 23:52:17 +0800
Subject: [PATCH 01/14] [MLIR][LLVM] Add Continuous Loop Peeling transform to
SC
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/77147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
This makes sense to me but I would like @cor3ntin to review as well.
This needs a release note.
I see that there was two test cases. Do you think it is worth it to add the
second test case as well?
https://github.com/llvm/llvm-project/pull/77434
__
https://github.com/doru1004 approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/71045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ributzka approved this pull request.
Sorry for the breakage and thanks for fixing it.
https://github.com/llvm/llvm-project/pull/77485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/agozillon approved this pull request.
the PR LGTM.
https://github.com/llvm/llvm-project/pull/71045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/77481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Romaric Jodin
Date: 2024-01-09T16:47:53Z
New Revision: 9160f49e08af4267efdc870a1c9a434bfd155ae3
URL:
https://github.com/llvm/llvm-project/commit/9160f49e08af4267efdc870a1c9a434bfd155ae3
DIFF:
https://github.com/llvm/llvm-project/commit/9160f49e08af4267efdc870a1c9a434bfd155ae3.diff
LOG:
https://github.com/kpet closed https://github.com/llvm/llvm-project/pull/66901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/balazske updated
https://github.com/llvm/llvm-project/pull/74627
From cbcb81ebdbc49e3bd11b6f716ac14658a729b787 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?=
Date: Tue, 5 Dec 2023 15:23:37 +0100
Subject: [PATCH 1/4] [clang][ASTImporter] Improve import of f
@@ -5919,15 +5919,26 @@ ExpectedDecl
ASTNodeImporter::VisitClassTemplateDecl(ClassTemplateDecl *D) {
if (ToD)
return ToD;
- bool IsFriendTemplate = D->getFriendObjectKind() != Decl::FOK_None;
- bool IsDependentContext = DC != LexicalDC ? LexicalDC->isDependentContext(
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sethp updated https://github.com/llvm/llvm-project/pull/74852
>From f281d34a51f662c934f158e4770774b0dc3588a2 Mon Sep 17 00:00:00 2001
From: Seth Pellegrino
Date: Thu, 7 Dec 2023 08:45:51 -0800
Subject: [PATCH 1/7] [Clang][Sema] Print more static_assert exprs
This change intro
cor3ntin wrote:
@nikic looks like you closed the wrong issue
https://github.com/llvm/llvm-project/pull/77147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin reopened
https://github.com/llvm/llvm-project/pull/77147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nemanjai commented:
It is not my intent to hold up approval of this patch. In addition to the minor
comments I added, I plan to do some local testing but even if the testing
reveals issues, they can be fixed on subsequent commits.
https://github.com/llvm/llvm-project/pull/76
https://github.com/nemanjai edited
https://github.com/llvm/llvm-project/pull/76777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -38,3 +40,14 @@ def CSR_XLEN_F32_Interrupt: CalleeSavedRegs<(add
CSR_Interrupt,
// Same as CSR_Interrupt, but including all 64-bit FP registers.
def CSR_XLEN_F64_Interrupt: CalleeSavedRegs<(add CSR_Interrupt,
(sequence "F%u_D", 0
@@ -83,13 +88,14 @@ RISCVRegisterInfo::getCalleeSavedRegs(const MachineFunction
*MF) const {
}
BitVector RISCVRegisterInfo::getReservedRegs(const MachineFunction &MF) const {
+ const RISCVSubtarget &STI = MF.getSubtarget();
nemanjai wrote:
Why was this adde
@@ -985,9 +1003,10 @@ void
RISCVFrameLowering::determineCalleeSaves(MachineFunction &MF,
};
for (auto Reg : CSRegs)
- SavedRegs.set(Reg);
+ if (Reg < RISCV::X16 || !Subtarget.isRVE())
nemanjai wrote:
What happens if we are using `ilp32e/lp6
@@ -17,6 +17,13 @@ def HasStdExtZicsr :
Predicate<"Subtarget->hasStdExtZicsr()">,
AssemblerPredicate<(all_of FeatureStdExtZicsr),
"'Zicsr' (CSRs)">;
+def FeatureStdExtI
+: SubtargetFeature<"i", "HasStdExtI",
@@ -179,6 +180,11 @@ Assembly Support
Supported
Fully supported by the compiler. This includes everything in Assembly
Support, along with - if relevant - C language intrinsics for the instructions
and pattern matching by the compiler to recognize idiomatic patterns which ca
@@ -50,11 +50,14 @@ void RISCVTargetStreamer::setTargetABI(RISCVABI::ABI ABI) {
void RISCVTargetStreamer::emitTargetAttributes(const MCSubtargetInfo &STI,
bool EmitStackAlign) {
- if (STI.hasFeature(RISCV::FeatureRVE))
-repor
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= ,
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= ,
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?=
Message-ID:
In-Reply-To:
https://github.com/NagyDonat approved this pull request.
https://github.com/llvm/llvm-project/pull/74627
___
cfe-commi
nikic wrote:
Ooops, sorry about that.
https://github.com/llvm/llvm-project/pull/77147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bolshakov-a updated
https://github.com/llvm/llvm-project/pull/71077
>From 4435d1ed5ed4785be7df35c129332359d89f132b Mon Sep 17 00:00:00 2001
From: Bolshakov
Date: Thu, 2 Nov 2023 19:20:27 +0300
Subject: [PATCH] [clang] Improve bit-field in ref NTTP diagnostic
Prior to this, a
bolshakov-a wrote:
@cor3ntin, thank you! Could you please take a look and probably merge #71077?
This depends on that PR.
https://github.com/llvm/llvm-project/pull/77428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/cor3ntin approved this pull request.
Still looks good, thanks
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Andrey Ali Khan Bolshakov
Date: 2024-01-09T18:14:17+01:00
New Revision: 79e17cd01491c0fde241097ad4c5c24afbb1883e
URL:
https://github.com/llvm/llvm-project/commit/79e17cd01491c0fde241097ad4c5c24afbb1883e
DIFF:
https://github.com/llvm/llvm-project/commit/79e17cd01491c0fde241097ad4c5c24afb
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
Merging at @bolshakov-a's request
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3,8 +3,8 @@
# Out of range immediates
## simm12
-flh ft1, -2049(a0) # CHECK: :[[@LINE]]:10: error: operand must be a symbol
with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047]
-fsh ft2, 2048(a1) # CHECK: :[[@LINE]]:10: error: operand must be a s
sethp wrote:
In playing around with this some more, I found it was pretty effective for me
to have an intializer-like expression (as in
[e769f15](https://github.com/llvm/llvm-project/pull/74852/commits/e769f158c8ee001e95299ce4c83e5250e2a8f963)
), because then I could copy/paste the output from
Author: Piotr Zegar
Date: 2024-01-09T18:22:03+01:00
New Revision: 6eb372e4e46a6dc4511f454b6501e93eb4cad22d
URL:
https://github.com/llvm/llvm-project/commit/6eb372e4e46a6dc4511f454b6501e93eb4cad22d
DIFF:
https://github.com/llvm/llvm-project/commit/6eb372e4e46a6dc4511f454b6501e93eb4cad22d.diff
L
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/72705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,115 @@
+// RUN: %clang_cc1 -std=c++2a -verify %s
+
+struct A {
+ int a, b[3], c;
+ bool operator==(const A&) const = default;
+};
+
+constexpr auto a0 = A{0, 0, 3, 4, 5};
+
+// expected-note@+1 {{evaluates to 'A{0, {0, 3, 4}, 5} == A{1, {2, 3, 4}, 5}'}}
+static_assert
kees wrote:
Thanks! The update fixes the anon struct issue I hit. I've found one more
issue, though this appears to be a miscalculation with a pathological `count`
value (i.e. `count` is signed type and contains a negative value):
```
struct annotated {
unsigned long flags;
int count;
@@ -0,0 +1,44 @@
+# RUN: llvm-mc -filetype=obj -triple riscv32 < %s --defsym RV32=1 |
llvm-objdump -d -M no-aliases - | FileCheck %s --check-prefixes=INST,RV32
+# RUN: llvm-mc -filetype=obj -triple riscv64 < %s | llvm-objdump -d -M
no-aliases - | FileCheck %s --check-prefixes=I
https://github.com/danix800 updated
https://github.com/llvm/llvm-project/pull/77434
>From 2f9e45458d21952f9e81cd54297f538d1d04b9f9 Mon Sep 17 00:00:00 2001
From: dingfei
Date: Tue, 9 Jan 2024 16:40:23 +0800
Subject: [PATCH] [clang][Parser] Pop scope prior VarDecl invalidating by
invalid direct
danix800 wrote:
> This makes sense to me but I would like @cor3ntin to review as well.
>
> This needs a release note.
Release note is added.
>
> I see that there was two test cases. Do you think it is worth it to add the
> second test case as well?
The original testcase from #30908 is added
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/76117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bolshakov-a wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,115 @@
+// RUN: %clang_cc1 -std=c++2a -verify %s
+
+struct A {
+ int a, b[3], c;
+ bool operator==(const A&) const = default;
+};
+
+constexpr auto a0 = A{0, 0, 3, 4, 5};
+
+// expected-note@+1 {{evaluates to 'A{0, {0, 3, 4}, 5} == A{1, {2, 3, 4}, 5}'}}
+static_assert
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 1/9] [libc++] Implement ranges::contains_subrange
---
libcxx/i
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/10] [libc++] Implement ranges::contains_subrange
---
libcxx
bolshakov-a wrote:
Have I understood correctly that I should open my own PR to proceed working on
this?
https://github.com/llvm/llvm-project/pull/77428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -71,6 +71,18 @@ enum Fixups {
// Used to generate an R_RISCV_ALIGN relocation, which indicates the linker
// should fixup the alignment after linker relaxation.
fixup_riscv_align,
+ // 20-bit fixup corresponding to %tlsdesc_hi(foo) for instructions like
+ // auipc
+
rapidsna wrote:
> This prints a wrapped calculation instead of the expected "0".
Shouldn't `getDefaultBuiltinObjectSizeResult` return `-1`? Have you tried `-2`
to see if it's returning the negative count value or it happens to be equal to
the default value?
https://github.com/llvm/llvm-projec
vitalybuka wrote:
Breaks https://lab.llvm.org/buildbot/#/builders/127/builds/60635
Please fix or revert.
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
jimmy-zx wrote:
Pinging @AaronBallman and @jyknight for review. (sorry if I chose the wrong
people)
https://github.com/llvm/llvm-project/pull/77269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
kees wrote:
> > This prints a wrapped calculation instead of the expected "0".
>
> Shouldn't `getDefaultBuiltinObjectSizeResult` return `-1`? Have you tried
> `-2` to see if it's returning the negative count value or it happens to be
> equal to the default value?
Well, maybe it's not wrapped,
cor3ntin wrote:
Sure! I will close this one.
I wasn't sure you were around and honestly a bit concerned about all the
work that is going to be lost on phabricator.
On Tue, Jan 9, 2024, 18:38 Andrey Ali Khan Bolshakov <
***@***.***> wrote:
> Have I understood correctly that I should open my own
@@ -0,0 +1,115 @@
+// RUN: %clang_cc1 -std=c++2a -verify %s
+
+struct A {
+ int a, b[3], c;
+ bool operator==(const A&) const = default;
+};
+
+constexpr auto a0 = A{0, 0, 3, 4, 5};
+
+// expected-note@+1 {{evaluates to 'A{0, {0, 3, 4}, 5} == A{1, {2, 3, 4}, 5}'}}
+static_assert
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/77434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kmclaughlin-arm edited
https://github.com/llvm/llvm-project/pull/76711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kmclaughlin-arm commented:
Thanks for updating this @MDevereau, I think there are just a few more tests
that should be included in this PR.
https://github.com/llvm/llvm-project/pull/76711
___
cfe-commits mailing list
cfe-commits@lis
@@ -460,7 +460,7 @@ void test_svmla_single4_u16(uint32_t slice_base,
svuint16x4_t zn, svuint16_t zm)
//
void test_svmla_single4_s16(uint32_t slice_base, svint16x4_t zn, svint16_t zm)
__arm_streaming __arm_shared_za
{
- SVE_ACLE_FUNC(svmla_single_za32,,_s16,,_vg2x4)(slice_ba
@@ -494,7 +494,7 @@ void test_svmls_lane1_f16(uint32_t slice_base, svfloat16_t
zn, svfloat16_t zm) _
//
void test_svmls_lane1_bf16(uint32_t slice_base, svbfloat16_t zn, svbfloat16_t
zm) __arm_streaming __arm_shared_za
{
- SVE_ACLE_FUNC(svmls_lane_za32,,_bf16,,_vg2x1)(slice_
ilovepi wrote:
> The base branch can be edited if you click "Edit" near the title, which will
> help reveal the lld side changes...
hmm, I was hoping that would work, but the base branch is in my fork. I think
to make it work correctly I'd have to be using the "user" branches in the main
repo
https://github.com/EthanLuisMcDonough updated
https://github.com/llvm/llvm-project/pull/76587
>From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001
From: Ethan Luis McDonough
Date: Fri, 15 Dec 2023 20:38:38 -0600
Subject: [PATCH 1/9] Add profiling functions to libomptarget
--
https://github.com/diggerlin edited
https://github.com/llvm/llvm-project/pull/67999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Nour1248 created
https://github.com/llvm/llvm-project/pull/77504
None
>From 68af1fcbaade87ec8d20c7a83f20bf4bfba5caf5 Mon Sep 17 00:00:00 2001
From: Nour Fouad
Date: Tue, 9 Jan 2024 19:56:42 +0200
Subject: [PATCH] [clangd] Fix typo
---
clang-tools-extra/clangd/AST.cpp | 12
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it i
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: None (Nour1248)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/77504.diff
1 Files Affected:
- (modified) clang-tools-extra/clangd/AST.cpp (+6-6)
``diff
diff --git a/clang-tools-extra/clangd/AST.cpp b/clang
bolshakov-a wrote:
Seems like I should ping reviewers more actively... Ok, thanks, I'll probably
proceed at the weekend.
https://github.com/llvm/llvm-project/pull/77428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
rapidsna wrote:
> The return value of -1 means "I don't know how large this is".
@kees Oh, I see. I did not know such the convention. Is it documented somewhere?
https://github.com/llvm/llvm-project/pull/76348
___
cfe-commits mailing list
cfe-commits
qiongsiwu wrote:
> Breaks https://lab.llvm.org/buildbot/#/builders/127/builds/60635 Please fix
> or revert.
Thanks for reporting the problem @vitalybuka !
I don't have a Windows machine to reproduce the issue. It is not clear to me
how the IR can contain names like `"??_C@_0BA@MIKMMAII@rawpr
@@ -959,8 +959,12 @@ void CodeGenPGO::emitCounterIncrement(CGBuilderTy
&Builder, const Stmt *S,
unsigned Counter = (*RegionCounterMap)[S];
- llvm::Value *Args[] = {FuncNameVar,
- Builder.getInt64(FunctionHash),
+ // Make sure that pointer to globa
Author: martinboehme
Date: 2024-01-09T19:18:54+01:00
New Revision: 03a0bfa96a6eb09c4bbae344ac3aa062339aa730
URL:
https://github.com/llvm/llvm-project/commit/03a0bfa96a6eb09c4bbae344ac3aa062339aa730
DIFF:
https://github.com/llvm/llvm-project/commit/03a0bfa96a6eb09c4bbae344ac3aa062339aa730.diff
https://github.com/martinboehme closed
https://github.com/llvm/llvm-project/pull/77453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -284,6 +284,7 @@ bool TypePrinter::canPrefixQualifiers(const Type *T,
case Type::FunctionNoProto:
case Type::Paren:
case Type::PackExpansion:
+
erichkeane wrote:
unrelated change?
https://github.com/llvm/llvm-project/pull/72644
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/72644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
A LOT of stuff here... probably going to need a few more cycles on this to
completely grok it. I didn't spend much time on tests, but would love if we
could come up with some 'common patterns' (particularly any that others have
sent you as a 'look at t
@@ -1713,6 +1716,11 @@ class ASTContext : public RefCountedBase {
/// C++11 decltype.
QualType getDecltypeType(Expr *e, QualType UnderlyingType) const;
+ QualType getPackIndexingType(QualType Pattern, Expr *IndexExpr,
+ bool FullyExpanded = f
@@ -1685,7 +1685,12 @@ enum CXCursorKind {
*/
CXCursor_CXXParenListInitExpr = 155,
- CXCursor_LastExpr = CXCursor_CXXParenListInitExpr,
+ /**
+ * Represents a C++26 pack indexing expression
erichkeane wrote:
```suggestion
* Represents a C++26 pa
@@ -4884,6 +4884,72 @@ class DependentDecltypeType : public DecltypeType,
public llvm::FoldingSetNode {
Expr *E);
};
+class PackIndexingType final
+: public Type,
+ public llvm::FoldingSetNode,
+ private llvm::TrailingObjects {
+ friend Tr
@@ -836,6 +836,8 @@ ANNOTATION(primary_expr) // annotation for a primary
expression, used when
// message send
ANNOTATION(decltype) // annotation for a decltype expression,
// e.g., "decltype(foo.bar())"
+ANNOTATION(indexed
@@ -1061,6 +1070,59 @@ ExprResult Sema::ActOnSizeofParameterPackExpr(Scope *S,
RParenLoc);
}
+static bool isParameterPack(Expr *PackExpression) {
+ if (auto D = dyn_cast(PackExpression); D) {
+ValueDecl *VD = D->getDecl();
+return VD->i
@@ -309,6 +309,7 @@ class DeclSpec {
static const TST TST_typeof_unqualExpr = clang::TST_typeof_unqualExpr;
static const TST TST_decltype = clang::TST_decltype;
static const TST TST_decltype_auto = clang::TST_decltype_auto;
+ static const TST TST_indexed_typename_pack =
@@ -4344,6 +4344,112 @@ class SizeOfPackExpr final
}
};
+class PackIndexingExpr final
+: public Expr,
+ private llvm::TrailingObjects {
+ friend class ASTStmtReader;
+ friend class ASTStmtWriter;
+ friend TrailingObjects;
+
+ SourceLocation EllipsisLoc;
+
+ //
@@ -6460,6 +6476,100 @@ QualType
TreeTransform::TransformDecltypeType(TypeLocBuilder &TLB,
return Result;
}
+template
+QualType
+TreeTransform::TransformPackIndexingType(TypeLocBuilder &TLB,
+ PackIndexingTypeLoc TL) {
+ //
@@ -1061,6 +1070,59 @@ ExprResult Sema::ActOnSizeofParameterPackExpr(Scope *S,
RParenLoc);
}
+static bool isParameterPack(Expr *PackExpression) {
+ if (auto D = dyn_cast(PackExpression); D) {
erichkeane wrote:
```suggestion
@@ -1665,6 +1665,43 @@ NonTypeTemplateParmDecl
*SubstNonTypeTemplateParmExpr::getParameter() const {
getReplacedTemplateParameterList(getAssociatedDecl())->asArray()[Index]);
}
+PackIndexingExpr *PackIndexingExpr::Create(ASTContext &Context,
+
@@ -978,6 +978,20 @@ bool Parser::ConsumeAndStoreFunctionPrologue(CachedTokens
&Toks) {
} else {
break;
}
+ // Pack indexing
+ if (getLangOpts().CPlusPlus26 && Tok.is(tok::ellipsis) &&
erichkeane wrote:
While I think allowing thi
@@ -1884,6 +1884,10 @@ class Parser : public CodeCompletionHandler {
// C++ Expressions
ExprResult tryParseCXXIdExpression(CXXScopeSpec &SS, bool isAddressOfOperand,
Token &Replacement);
+
+ ExprResult tryParseCXXPackIndexingExpression(
@@ -1665,6 +1665,43 @@ NonTypeTemplateParmDecl
*SubstNonTypeTemplateParmExpr::getParameter() const {
getReplacedTemplateParameterList(getAssociatedDecl())->asArray()[Index]);
}
+PackIndexingExpr *PackIndexingExpr::Create(ASTContext &Context,
+
@@ -1665,6 +1665,43 @@ NonTypeTemplateParmDecl
*SubstNonTypeTemplateParmExpr::getParameter() const {
getReplacedTemplateParameterList(getAssociatedDecl())->asArray()[Index]);
}
+PackIndexingExpr *PackIndexingExpr::Create(ASTContext &Context,
+
@@ -5697,6 +5698,39 @@ QualType ASTContext::getDecltypeType(Expr *e, QualType
UnderlyingType) const {
return QualType(dt, 0);
}
+QualType ASTContext::getPackIndexingType(QualType Pattern, Expr *IndexExpr,
+ bool FullyExpanded,
+
@@ -1067,6 +1067,17 @@ ExprResult Parser::ParseCastExpression(CastParseKind
ParseKind,
// where the syntax forbids a type.
const Token &Next = NextToken();
+ if (getLangOpts().CPlusPlus26 && Next.is(tok::ellipsis) &&
erichkeane wrote:
Same s
minglotus-6 wrote:
> > Breaks https://lab.llvm.org/buildbot/#/builders/127/builds/60635 Please fix
> > or revert.
>
> Thanks for reporting the problem @vitalybuka !
>
> I don't have a Windows machine to reproduce the issue. It is not clear to me
> how the IR can contain names like
> `"??_C@_
qiongsiwu wrote:
> Sometimes godbolt output (like https://godbolt.org/z/MxbjcnanW) could be
> faster and more convenient (e.g., there is no need to get windows executable
> to for debugging, only LLVM IR is needed).
Thanks for the pointer! Yup godbolt can indeed reproduce IR quite well.
https
Author: Jake Egan
Date: 2024-01-09T13:40:21-05:00
New Revision: 1b8e39a1a2e8237852914501e3361d98af6db054
URL:
https://github.com/llvm/llvm-project/commit/1b8e39a1a2e8237852914501e3361d98af6db054
DIFF:
https://github.com/llvm/llvm-project/commit/1b8e39a1a2e8237852914501e3361d98af6db054.diff
LOG
https://github.com/jakeegan closed
https://github.com/llvm/llvm-project/pull/77485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
qmfrederik wrote:
CI looks green, let me know if there's anything else you need from me on this
PR!
https://github.com/llvm/llvm-project/pull/77255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/10] [libc++] Implement ranges::contains_subrange
---
libcxx
201 - 300 of 566 matches
Mail list logo
