================
@@ -50,11 +50,14 @@ void RISCVTargetStreamer::setTargetABI(RISCVABI::ABI ABI) {
void RISCVTargetStreamer::emitTargetAttributes(const MCSubtargetInfo &STI,
bool EmitStackAlign) {
- if (STI.hasFeature(RISCV::FeatureRVE))
- report_fatal_error("Codegen not yet implemented for RVE");
-
- if (EmitStackAlign)
- emitAttribute(RISCVAttrs::STACK_ALIGN, RISCVAttrs::ALIGN_16);
+ if (EmitStackAlign) {
+ if (STI.hasFeature(RISCV::FeatureRVE))
----------------
nemanjai wrote:
This seems to not match what the usage doc above says. Namely, the doc says
that the alignment is dependent on the ABI but this uses the ISA feature rather
than the ABI.
Furthermore, `getABIStackAlignment()` also obviously uses the ABI rather than
the ISA feature.
https://github.com/llvm/llvm-project/pull/76777
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
