[libunwind] [libunwind] Add length info for dynamic .eh_frame registration (PR #77185)

2024-01-06 Thread via cfe-commits
https://github.com/SihangZhu created https://github.com/llvm/llvm-project/pull/77185 Fix this issue [#76957](https://github.com/llvm/llvm-project/issues/76957) Libgcc provides __register_frame to register a dynamic .eh_frame section, while __unw_add_dynamic_eh_frame_section can be used to do t

[libunwind] [libunwind] Add length info for dynamic .eh_frame registration (PR #77185)

2024-01-06 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[libunwind] [libunwind] Add length info for dynamic .eh_frame registration (PR #77185)

2024-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: None (SihangZhu) Changes Fix this issue [#76957](https://github.com/llvm/llvm-project/issues/76957) Libgcc provides __register_frame to register a dynamic .eh_frame section, while __unw_add_dynamic_eh_frame_section can be used to do t

[libunwind] [libunwind] Add length info for dynamic .eh_frame registration (PR #77185)

2024-01-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ba1f4c6c50205bb7c6937c236084987f8669191c 877f03067280873953d2f38f518301c02b4877e4 --

[clang] [llvm] [llvm] Add support for building on illumos (PR #74930)

2024-01-06 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/74930 >From bc209c885f00c5eb4b00ca16bfbd279c62549d89 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sat, 9 Dec 2023 01:43:09 -0500 Subject: [PATCH] [llvm] Add support for building on illumos illumos has an older version

[clang] [llvm] [llvm] Add support for building on illumos (PR #74930)

2024-01-06 Thread Brad Smith via cfe-commits
@@ -241,6 +241,11 @@ if (NOT DEFINED LLVM_LINKER_DETECTED AND NOT WIN32) set(LLVM_LINKER_DETECTED YES CACHE INTERNAL "") set(LLVM_LINKER_IS_GNULD YES CACHE INTERNAL "") message(STATUS "Linker detection: GNU ld") +elseif("${stderr}" MATCHES "(illumos)" OR +

[libunwind] [libunwind] Add length info for dynamic .eh_frame registration (PR #77185)

2024-01-06 Thread via cfe-commits
https://github.com/SihangZhu updated https://github.com/llvm/llvm-project/pull/77185 >From b9957ac0a33c9ee0f1144862621fcea8f33a1d69 Mon Sep 17 00:00:00 2001 From: SihangZhu Date: Sat, 6 Jan 2024 15:43:41 +0800 Subject: [PATCH] [libunwind] Add length info for .eh_frame registration --- libunwi

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/77056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-06 Thread Piotr Zegar via cfe-commits
@@ -295,6 +295,11 @@ Changes in existing checks coroutine functions and increase issue detection for cases involving type aliases with references. +- Improved :doc:`cppcoreguidelines-missing-std-forward + ` check to + provide fixes of false positive that forwarded in cap

[libc] [compiler-rt] [clang-tools-extra] [flang] [lldb] [llvm] [clang] [GlobalIsel] Combine select of binops (PR #76763)

2024-01-06 Thread Amara Emerson via cfe-commits
Thorsten =?utf-8?q?Sch=C3=BCtt?= , Thorsten =?utf-8?q?Sch=C3=BCtt?= , Thorsten =?utf-8?q?Sch=C3=BCtt?= Message-ID: In-Reply-To: https://github.com/aemerson approved this pull request. https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits m

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-06 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/77056 >From 880554dc7a73fbfad8229e15f8398097611e326d Mon Sep 17 00:00:00 2001 From: huqizhi Date: Wed, 3 Jan 2024 09:44:26 +0800 Subject: [PATCH] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-06 Thread Qizhi Hu via cfe-commits
@@ -295,6 +295,11 @@ Changes in existing checks coroutine functions and increase issue detection for cases involving type aliases with references. +- Improved :doc:`cppcoreguidelines-missing-std-forward + ` check to + provide fixes of false positive that forwarded in cap

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-06 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/76680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-06 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM Make sure to rebase to fix the conflict. Thanks for working on this https://github.com/llvm/llvm-project/pull/76680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-06 Thread via cfe-commits
@@ -2634,16 +2637,29 @@ bool QualType::isTriviallyCopyableType(const ASTContext &Context) const { if (const auto *RT = CanonicalType->getAs()) { if (const auto *ClassDecl = dyn_cast(RT->getDecl())) { - if (!ClassDecl->isTriviallyCopyable()) return false; + if

[libc] [clang] [lld] [mlir] [lldb] [compiler-rt] [clang-tools-extra] [llvm] [openmp] [flang] [libcxx] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-06 Thread Hristo Hristov via cfe-commits
Zingam wrote: > Hi, this change breaks libcxx test on Windows due to unable to find > "unistd.h" file (which doesn't exist on msvc based environment). > > Failed test message and failed commandline: > > ``` > > Failed Tests (8): > llvm-libc++-static-clangcl.cfg.in :: >

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-06 Thread Owen Pan via cfe-commits
https://github.com/owenca commented: Please also update the release notes. LGTM otherwise. https://github.com/llvm/llvm-project/pull/69340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-06 Thread Owen Pan via cfe-commits
@@ -76,40 +76,49 @@ template <> struct MappingTraits { FormatStyle::AlignConsecutiveStyle( {/*Enabled=*/false, /*AcrossEmptyLines=*/false, /*AcrossComments=*/false, /*AlignCompound=*/false, + /*AlignF

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-06 Thread Owen Pan via cfe-commits
@@ -76,40 +76,49 @@ template <> struct MappingTraits { FormatStyle::AlignConsecutiveStyle( {/*Enabled=*/false, /*AcrossEmptyLines=*/false, /*AcrossComments=*/false, /*AlignCompound=*/false, + /*AlignF

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-06 Thread Owen Pan via cfe-commits
@@ -76,40 +76,49 @@ template <> struct MappingTraits { FormatStyle::AlignConsecutiveStyle( {/*Enabled=*/false, /*AcrossEmptyLines=*/false, /*AcrossComments=*/false, /*AlignCompound=*/false, + /*AlignF

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-06 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-06 Thread Owen Pan via cfe-commits
@@ -76,40 +76,49 @@ template <> struct MappingTraits { FormatStyle::AlignConsecutiveStyle( {/*Enabled=*/false, /*AcrossEmptyLines=*/false, /*AcrossComments=*/false, /*AlignCompound=*/false, + /*AlignF

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-06 Thread Owen Pan via cfe-commits
@@ -225,6 +225,22 @@ struct FormatStyle { /// bbb = 2; /// \endcode bool AlignCompound; +/// Only for ``AlignConsecutiveDeclarations``. Whether function pointers +/// are aligned. owenca wrote: ```suggestion /// Only for ``AlignConsec

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-06 Thread Owen Pan via cfe-commits
@@ -978,7 +978,14 @@ void WhitespaceManager::alignConsecutiveDeclarations() { AlignTokens( Style, - [](Change const &C) { + [&](Change const &C) { +if (Style.AlignConsecutiveDeclarations.AlignFunctionPointers) { + for (FormatToken *Prev = C.T

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2024-01-06 Thread Owen Pan via cfe-commits
@@ -76,40 +76,49 @@ template <> struct MappingTraits { FormatStyle::AlignConsecutiveStyle( {/*Enabled=*/false, /*AcrossEmptyLines=*/false, /*AcrossComments=*/false, /*AlignCompound=*/false, + /*AlignF

[flang] [lldb] [compiler-rt] [libc] [clang] [clang-tools-extra] [llvm] [GlobalIsel] Combine select of binops (PR #76763)

2024-01-06 Thread Thorsten Schütt via cfe-commits
https://github.com/tschuett closed https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [mlir] [emacs] Fix Emacs library formatting (PR #76110)

2024-01-06 Thread Owen Pan via cfe-commits
owenca wrote: @darkfeline I'm ok with adding the Version comment in clang/tools/clang-format/clang-format.el, but you may have to explicitly request others to review the rest of the patch. https://github.com/llvm/llvm-project/pull/76110 ___ cfe-commi

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-06 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy updated https://github.com/llvm/llvm-project/pull/76680 >From 3c8dfcf96e732f4546f8019c0111fd873b233162 Mon Sep 17 00:00:00 2001 From: 11happy Date: Mon, 1 Jan 2024 19:53:45 +0530 Subject: [PATCH 01/13] Changed Checks from TriviallyCopyable to TriviallyCopyConstructib

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-06 Thread Bhuminjay Soni via cfe-commits
11happy wrote: Thank you @cor3ntin for your guidance being a new contributor to LLVM your guidance was very helpful and as my First PR gets approved this makes me more excited to work and contribute more to the org. https://github.com/llvm/llvm-project/pull/76680

[clang-tools-extra] d084829 - [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (#77056)

2024-01-06 Thread via cfe-commits
Author: Qizhi Hu Date: 2024-01-06T19:50:00+08:00 New Revision: d08482924efe8b2c44913583af7b8f60a29975d1 URL: https://github.com/llvm/llvm-project/commit/d08482924efe8b2c44913583af7b8f60a29975d1 DIFF: https://github.com/llvm/llvm-project/commit/d08482924efe8b2c44913583af7b8f60a29975d1.diff LOG:

[clang-tools-extra] [clang-tidy] fix false positive in cppcoreguidelines-missing-std-forward (PR #77056)

2024-01-06 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/77056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve modeling of 'getcwd' in the StdLibraryFunctionsChecker (PR #77040)

2024-01-06 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/77040 >From 10a0e9aae5effdd6e26476e78a778b89373358df Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Fri, 5 Jan 2024 10:05:15 +0800 Subject: [PATCH 1/2] Improve modeling of 'getcwd' in the StdLibraryFunctionsChecker 1

[clang] [Clang][NFC] Fix out-of-bounds access (PR #77193)

2024-01-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/77193 The changes to tablegen made by https://github.com/llvm/llvm-project/pull/76825 result in `StmtClass::lastStmtConstant` changing from `StmtClass::WhileStmtClass` to `StmtClass::GCCAsmStmtClass`. Since `CFG::

[clang] [Clang][NFC] Fix out-of-bounds access (PR #77193)

2024-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) Changes The changes to tablegen made by https://github.com/llvm/llvm-project/pull/76825 result in `StmtClass::lastStmtConstant` changing from `StmtClass::WhileStmtClass` to `StmtClass::GCCAsmStmtClass`. Si

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

2024-01-06 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy created https://github.com/llvm/llvm-project/pull/77194 **Overview:** This pull request fixes #47355 where in the Clang compiler's range-loop-analysis incorrectly checks for trivial copyability instead of trivial copy constructibility, leading to erroneous warnings.

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

2024-01-06 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] [Clang][NFC] Fix out-of-bounds access (PR #77193)

2024-01-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/77193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

2024-01-06 Thread Bhuminjay Soni via cfe-commits
11happy wrote: Hello @cor3ntin In my previous pull request I mistakenly added add the commits so I closed that one and opened this new one.Sorry for any inconvenience . https://github.com/llvm/llvm-project/pull/77194 ___ cfe-commits mailing list cfe-c

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

2024-01-06 Thread Bhuminjay Soni via cfe-commits
11happy wrote: Hello @Endilll Can you please look into this and request for reviews and review this. I am sorry for my mistake. https://github.com/llvm/llvm-project/pull/77194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [llvm] [SPARC] Consume `tune-cpu` directive in the backend (PR #77195)

2024-01-06 Thread via cfe-commits
https://github.com/koachan created https://github.com/llvm/llvm-project/pull/77195 This lets the backend read the `tune-cpu` directive that is emitted by the frontend. No changes are needed for clang as it is already emits it. >From 119bf3db5799f3db2c7fd151f336c6d688a0eb96 Mon Sep 17 00:00:00

[clang] [llvm] [SPARC] Consume `tune-cpu` directive in the backend (PR #77195)

2024-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Koakuma (koachan) Changes This lets the backend read the `tune-cpu` directive that is emitted by the frontend. No changes are needed for clang as it is already emits it. --- Full diff: https://github.com/llvm/llvm-project/pull/77195.diff

[clang] [llvm] [SPARC] Support reserving arbitrary general purpose registers (PR #74927)

2024-01-06 Thread via cfe-commits
@@ -1125,6 +1130,10 @@ Register SparcTargetLowering::getRegisterByName(const char* RegName, LLT VT, .Case("g4", SP::G4).Case("g5", SP::G5).Case("g6", SP::G6).Case("g7", SP::G7) .Default(0); + const SparcRegisterInfo *TRI = Subtarget->getRegisterInfo(); + if (!TRI->

[clang] [llvm] [libcxx] "Reapply "[Sema] Fix crash on invalid code with parenthesized aggrega… (PR #76833)

2024-01-06 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: @mordante The lines could be changed to `// expected-error-re@*:* 0-1 (excess elements in struct initializer|no matching constructor for initialization of)}}{{.*` to still have coverage. FWIW the `{{.*}}` at the end seems to be redundant too. https://github.com/llvm/

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-01-06 Thread Amirreza Ashouri via cfe-commits
AMP999 wrote: > I think I would like some more eyes on this, I don't know if it is obvious to > me what it means to reallocate a volatile object. "Both active [wg21.link/p1144](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p1144r9.html) and [wg21.link/p2786](https://www.open-std.o

[clang] [llvm] [RFC] Introducing `__builtin_consistent` to generate AArch64 BC.cond … (PR #72175)

2024-01-06 Thread Dávid Bolvanský via cfe-commits
davidbolvansky wrote: but we already have _builtin_expect_with_probability, this looks less general… cc @nikic https://github.com/llvm/llvm-project/pull/72175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [Clang] Correctly construct template arguments for template template parameters (PR #76811)

2024-01-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/76811 >From e017bed2ee443d72f445f584dd6356bf151c5d79 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 3 Jan 2024 19:33:01 +0800 Subject: [PATCH 1/3] [Clang] Correctly construct template arguments for file-scope

[clang] [Clang] Correctly construct template arguments for template template parameters (PR #76811)

2024-01-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3fb0d8dc808cb7f315670d76109edc9c57cb3d90 323a3ec564da5018e6f7f2be4072b37c0ca49e5a --

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

2024-01-06 Thread via cfe-commits
@@ -870,9 +870,9 @@ Bug Fixes to AST Handling - Fixed a bug where RecursiveASTVisitor fails to visit the initializer of a bitfield. `Issue 64916 `_ -- Fixed a bug where Template Instantiation failed to handle Lambda Express

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

2024-01-06 Thread via cfe-commits
cor3ntin wrote: Review previously done in https://github.com/llvm/llvm-project/pull/76680 https://github.com/llvm/llvm-project/pull/77194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

2024-01-06 Thread Bhuminjay Soni via cfe-commits
@@ -870,9 +870,9 @@ Bug Fixes to AST Handling - Fixed a bug where RecursiveASTVisitor fails to visit the initializer of a bitfield. `Issue 64916 `_ -- Fixed a bug where Template Instantiation failed to handle Lambda Express

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

2024-01-06 Thread Bhuminjay Soni via cfe-commits
@@ -870,9 +870,9 @@ Bug Fixes to AST Handling - Fixed a bug where RecursiveASTVisitor fails to visit the initializer of a bitfield. `Issue 64916 `_ -- Fixed a bug where Template Instantiation failed to handle Lambda Express

[clang-tools-extra] [mlir] [llvm] [compiler-rt] [flang] [clang] [MLIR][Presburger] Function to compute the generating function corresponding to a unimodular cone (PR #77199)

2024-01-06 Thread via cfe-commits
https://github.com/Abhinav271828 created https://github.com/llvm/llvm-project/pull/77199 We implement a function to compute the generating function for a signed unimodular cone with a parametric vertex. These functions, summed over tangential cones, provide the generating function correspondin

[clang-tools-extra] [mlir] [llvm] [compiler-rt] [flang] [clang] [MLIR][Presburger] Function to compute the generating function corresponding to a unimodular cone (PR #77199)

2024-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-presburger Author: None (Abhinav271828) Changes We implement a function to compute the generating function for a signed unimodular cone with a parametric vertex. These functions, summed over tangential cones, provide the generating function corres

[clang] [mlir] [compiler-rt] [flang] [llvm] [clang-tools-extra] [MLIR][Presburger] Function to compute the generating function corresponding to a unimodular cone (PR #77199)

2024-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: None (Abhinav271828) Changes We implement a function to compute the generating function for a signed unimodular cone with a parametric vertex. These functions, summed over tangential cones, provide the generating function corresponding to

[clang-tools-extra] [mlir] [llvm] [compiler-rt] [flang] [clang] [MLIR][Presburger] Function to compute the generating function corresponding to a unimodular cone (PR #77199)

2024-01-06 Thread via cfe-commits
https://github.com/Abhinav271828 closed https://github.com/llvm/llvm-project/pull/77199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correctly construct template arguments for template template parameters (PR #76811)

2024-01-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/76811 >From e017bed2ee443d72f445f584dd6356bf151c5d79 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 3 Jan 2024 19:33:01 +0800 Subject: [PATCH 1/4] [Clang] Correctly construct template arguments for file-scope

[clang] [Clang] Correctly construct template arguments for template template parameters (PR #76811)

2024-01-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/76811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0c7d46a - [Clang] Correctly construct template arguments for template template parameters (#76811)

2024-01-06 Thread via cfe-commits
Author: Younan Zhang Date: 2024-01-06T22:26:34+08:00 New Revision: 0c7d46a7fd5b7956e285d385a6945153d6a06eb0 URL: https://github.com/llvm/llvm-project/commit/0c7d46a7fd5b7956e285d385a6945153d6a06eb0 DIFF: https://github.com/llvm/llvm-project/commit/0c7d46a7fd5b7956e285d385a6945153d6a06eb0.diff

[llvm] [clang] [RFC] Introducing `__builtin_consistent` to generate AArch64 BC.cond … (PR #72175)

2024-01-06 Thread Nikita Popov via cfe-commits
nikic wrote: @davidbolvansky The semantics of this builtin are slightly different, see the discussion at https://discourse.llvm.org/t/rfc-consistent-branches-support-in-llvm/74889. But yes, the consensus is that adding this builtin is not worthwhile. https://github.com/llvm/llvm-project/pull/

[clang-tools-extra] [compiler-rt] [lldb] [llvm] [libc] [flang] [clang] [GlobalIsel] Combine select of binops (PR #76763)

2024-01-06 Thread via cfe-commits
Thorsten =?utf-8?q?Sch=C3=BCtt?= , Thorsten =?utf-8?q?Sch=C3=BCtt?= , Thorsten =?utf-8?q?Sch=C3=BCtt?= Message-ID: In-Reply-To: ronlieb wrote: this lit test is now taking a very long time after this patch landed ./bin/llvm-lit ../llvm/test/CodeGen/AMDGPU/llvm.log2.ll relevant cmake settings

[clang-tools-extra] [compiler-rt] [lldb] [llvm] [libc] [flang] [clang] [GlobalIsel] Combine select of binops (PR #76763)

2024-01-06 Thread via cfe-commits
Thorsten =?utf-8?q?Schütt?= , Thorsten =?utf-8?q?Schütt?= , Thorsten =?utf-8?q?Schütt?= Message-ID: In-Reply-To: ronlieb wrote: @jhuber6 @jplehrthis may also be failing in staging libc bot https://lab.llvm.org/staging/#/builders/134 https://github.com/llvm/llvm-project/pull/76763 ___

[clang-tools-extra] [compiler-rt] [lldb] [llvm] [libc] [flang] [clang] [GlobalIsel] Combine select of binops (PR #76763)

2024-01-06 Thread Thorsten Schütt via cfe-commits
tschuett wrote: I had also issues with this test. There is also a GH issue: https://github.com/llvm/llvm-project/issues/76821. https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2024-01-06 Thread via cfe-commits
https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/75440 >From 18af0ae248707b7c33b24065cdbab5399337f8bc Mon Sep 17 00:00:00 2001 From: hstk30-hw Date: Thu, 14 Dec 2023 15:40:03 +0800 Subject: [PATCH] feat: arm_acle.h add Coprocessor Instrinsics --- clang/lib/Basic/

[clang-tools-extra] [compiler-rt] [lldb] [llvm] [libc] [flang] [clang] [GlobalIsel] Combine select of binops (PR #76763)

2024-01-06 Thread Thorsten Schütt via cfe-commits
tschuett wrote: The file was not changed by this PR and there is no `select` in the file. https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2024-01-06 Thread via cfe-commits
@@ -836,6 +837,70 @@ void ARMTargetInfo::getTargetDefines(const LangOptions &Opts, if (Opts.RWPI) Builder.defineMacro("__ARM_RWPI", "1"); + // Macros for enabling co-proc intrinsics + uint64_t FeatureCoprocBF = 0; + switch (ArchKind) { + default: +break; + case

[clang-tools-extra] [compiler-rt] [lldb] [llvm] [libc] [flang] [clang] [GlobalIsel] Combine select of binops (PR #76763)

2024-01-06 Thread Kai Luo via cfe-commits
Thorsten =?utf-8?q?Schütt?= , Thorsten =?utf-8?q?Schütt?= , Thorsten =?utf-8?q?Schütt?= Message-ID: In-Reply-To: bzEq wrote: It's also exhausting memory when `llvm-lit llvm-project/llvm/test/CodeGen/AMDGPU/llvm.exp2.ll`. See https://lab.llvm.org/buildbot/#/builders/249/builds/13786. https://

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2024-01-06 Thread via cfe-commits
@@ -836,6 +837,70 @@ void ARMTargetInfo::getTargetDefines(const LangOptions &Opts, if (Opts.RWPI) Builder.defineMacro("__ARM_RWPI", "1"); + // Macros for enabling co-proc intrinsics + uint64_t FeatureCoprocBF = 0; + switch (ArchKind) { + default: +break; + case

[llvm] [libcxx] [clang] Reapply "[libc++][streams] P1759R6: Native handles and file streams" (PR #77190)

2024-01-06 Thread Hristo Hristov via cfe-commits
https://github.com/Zingam updated https://github.com/llvm/llvm-project/pull/77190 >From 1d2c365efe493b4d62cb84a517d00a7d9dbd58b7 Mon Sep 17 00:00:00 2001 From: Zingam Date: Sat, 6 Jan 2024 12:47:23 +0200 Subject: [PATCH 1/2] Revert "Revert "[libc++][streams] P1759R6: Native handles and file st

[flang] [clang] [llvm] [compiler-rt] [libc] [clang-tools-extra] [lldb] [GlobalIsel] Combine select of binops (PR #76763)

2024-01-06 Thread Thorsten Schütt via cfe-commits
tschuett wrote: I reverted the commit. https://github.com/llvm/llvm-project/pull/76763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle templated elaborated type specifier in function… (PR #77013)

2024-01-06 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks commented: Ok, one last thing. From what I figured it was wrongly detected as class definition. So you could add a token annotator test, which verifies that the `{` is not an `ClassLBrace`? https://github.com/llvm/llvm-project/pull/77013 __

[clang] [clang-format] Fix crash involving array designators and dangling comma (PR #77045)

2024-01-06 Thread Björn Schäpers via cfe-commits
@@ -1444,16 +1444,22 @@ WhitespaceManager::CellDescriptions WhitespaceManager::getCells(unsigned Start, } else if (C.Tok->is(tok::comma)) { if (!Cells.empty()) Cells.back().EndIndex = i; -if (C.Tok->getNextNonComment()->isNot(tok::r_brace)) // d

[clang] [clang-format] Break after string literals with trailing line breaks (PR #76795)

2024-01-06 Thread Björn Schäpers via cfe-commits
@@ -2499,6 +2499,15 @@ TEST_F(TokenAnnotatorTest, BraceKind) { EXPECT_BRACE_KIND(Tokens[6], BK_Block); } +TEST_F(TokenAnnotatorTest, StreamOperator) { + auto Tokens = annotate("\"foo\\n\" << aux << \"foo\\n\" << \"foo\";"); + ASSERT_EQ(Tokens.size(), 9u) << Tokens; + EXPE

[clang] [Clang][Sema] Print more static_assert exprs (PR #74852)

2024-01-06 Thread via cfe-commits
@@ -0,0 +1,117 @@ +// RUN: %clang_cc1 -std=c++2a -verify %s + +struct A { + int a, b[3], c; + bool operator==(const A&) const = default; +}; + +constexpr auto a0 = A{0, 0, 3, 4, 5}; + +// expected-note@+1 {{evaluates to '{0, {0, 3, 4}, 5} == {1, {2, 3, 4}, 5}'}} +static_assert(a

[clang] [compiler-rt] [flang] [libc] [libunwind] [llvm] [lld] [libcxxabi] [mlir] [libcxx] [lldb] [clang-tools-extra] [clang] static operators should evaluate object argument (PR #68485)

2024-01-06 Thread Tianlan Zhou via cfe-commits
https://github.com/SuperSodaSea updated https://github.com/llvm/llvm-project/pull/68485 >From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001 From: SuperSodaSea Date: Sat, 7 Oct 2023 21:05:17 +0800 Subject: [PATCH 01/10] [clang] static operators should evaluate object argumen

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

2024-01-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/77178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

2024-01-06 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ Endilll wrote: ```suggestion const int v(int

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

2024-01-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: I think this PR moves things in the right direction, but I'm not well-versed in C enough to approve. > This should have a release note and I think this is a potentially breaking > change since folks using Wextra may get this diagnostic now. I agree that r

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

2024-01-06 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ +int x(long); + +typedef int (f1)(long); +typedef int (f2)(voi

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

2024-01-06 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify Endilll wrote: As written, tests checks only default language mode for C (which is `gnu99` AFAIK). Maybe we want to check other modes as well? https://github.com/llvm/llvm-project/pull/77178

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

2024-01-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/77178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix false-positives in misc-static-assert caused by non-constexpr variables (PR #77203)

2024-01-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/77203 Ignore false-positives when referring to non-constexpr variables in non-unevaluated context (like decltype, sizeof, ...). Moved from https://reviews.llvm.org/D158657 Fixes: #24066 >From 66900e4518b439cb9190e2

[clang-tools-extra] [clang-tidy] Fix false-positives in misc-static-assert caused by non-constexpr variables (PR #77203)

2024-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Ignore false-positives when referring to non-constexpr variables in non-unevaluated context (like decltype, sizeof, ...). Moved from https://reviews.llvm.org/D158657 Fixes: #24066 --- Full diff: https

[clang-tools-extra] [clang-tidy] Add support for in-class initializers in readability-redundant-member-init (PR #77206)

2024-01-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/77206 Support detecting redundant in-class initializers. Moved from https://reviews.llvm.org/D157262 Fixes: #62525 >From 66e4026ff568fbd805ddd777596102381e4e0066 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Sat

[clang-tools-extra] [clang-tidy] Add support for in-class initializers in readability-redundant-member-init (PR #77206)

2024-01-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/77206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add support for in-class initializers in readability-redundant-member-init (PR #77206)

2024-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Support detecting redundant in-class initializers. Moved from https://reviews.llvm.org/D157262 Fixes: #62525 --- Full diff: https://github.com/llvm/llvm-project/pull/77206.diff 4 Files Affected: - (

[flang] [clang] [libunwind] [compiler-rt] [libc] [libcxx] [clang-tools-extra] [lldb] [llvm] [libc++] Implement ranges::iota (PR #68494)

2024-01-06 Thread James E T Smith via cfe-commits
@@ -1149,9 +1171,11 @@ struct Proxy { // Calling swap(Proxy{}, Proxy{}) would fail (pass prvalues) // Compare operators are defined for the convenience of the tests - friend constexpr bool operator==(const Proxy&, const Proxy&) -requires (std::equality_comparable && !

[compiler-rt] [mlir] [clang-tools-extra] [flang] [lldb] [llvm] [libcxx] [libunwind] [lld] [libc] [clang] [libcxxabi] [clang] static operators should evaluate object argument (PR #68485)

2024-01-06 Thread Tianlan Zhou via cfe-commits
https://github.com/SuperSodaSea updated https://github.com/llvm/llvm-project/pull/68485 >From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001 From: SuperSodaSea Date: Sat, 7 Oct 2023 21:05:17 +0800 Subject: [PATCH 01/11] [clang] static operators should evaluate object argumen

[libcxx] [clang] [llvm] Reapply "[libc++][streams] P1759R6: Native handles and file streams" (PR #77190)

2024-01-06 Thread Hristo Hristov via cfe-commits
https://github.com/Zingam ready_for_review https://github.com/llvm/llvm-project/pull/77190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang] [llvm] Reapply "[libc++][streams] P1759R6: Native handles and file streams" (PR #77190)

2024-01-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Hristo Hristov (H-G-Hristov) Changes Fixes build on Windows in C++26 mode. Reverted in: https://github.com/llvm/llvm-project/commit/40c07b559aa6ab4bac074c943967d3207bc07ae0 Original PR: https://github.com/llvm/llvm-project/pull/76632 --

[compiler-rt] [clang-tools-extra] [flang] [lldb] [llvm] [libcxx] [libunwind] [libc] [clang] [libc++] Implement ranges::iota (PR #68494)

2024-01-06 Thread James E T Smith via cfe-commits
@@ -0,0 +1,71 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[compiler-rt] [clang-tools-extra] [flang] [lldb] [llvm] [libcxx] [libunwind] [libc] [clang] [libc++] Implement ranges::iota (PR #68494)

2024-01-06 Thread James E T Smith via cfe-commits
@@ -0,0 +1,71 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[compiler-rt] [clang-tools-extra] [flang] [lldb] [llvm] [libcxx] [libunwind] [libc] [clang] [libc++] Implement ranges::iota (PR #68494)

2024-01-06 Thread James E T Smith via cfe-commits
@@ -0,0 +1,71 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[clang] [clang] Reword apologetic Clang diagnostic messages (PR #76310)

2024-01-06 Thread Pavel Gueorguiev via cfe-commits
https://github.com/pav-code updated https://github.com/llvm/llvm-project/pull/76310 >From 82fe20f1ccc2e9129282c71bf5bdfd6cfd4fadf3 Mon Sep 17 00:00:00 2001 From: Pavel Gueorguiev Date: Sat, 23 Dec 2023 14:19:50 -0500 Subject: [PATCH 1/2] [clang] Reword apologetic Clang diagnostic messages Fixe

[mlir] [clang-tools-extra] [clang] [llvm] [mlir][spirv] Support function argument decorations for ptr in the PhysicalStorageBuffer (PR #76353)

2024-01-06 Thread Lei Zhang via cfe-commits
https://github.com/antiagainst updated https://github.com/llvm/llvm-project/pull/76353 >From ebd9634057e9417905d7fcd27bac829c5d0889e0 Mon Sep 17 00:00:00 2001 From: Kohei Yamaguchi Date: Fri, 22 Dec 2023 17:22:25 + Subject: [PATCH 01/10] [mlir][spirv] Support function argument decorations f

[mlir] [clang-tools-extra] [clang] [llvm] [mlir][spirv] Support function argument decorations for ptr in the PhysicalStorageBuffer (PR #76353)

2024-01-06 Thread Lei Zhang via cfe-commits
antiagainst wrote: Thanks a lot for the contribution and bearing with me for the nitpicking. :) To avoid burden you further, I rebased and revised some comment/error message slightly. :) I'll land once bots are happy. https://github.com/llvm/llvm-project/pull/76353

[clang] [Clang][Sema] Print more static_assert exprs (PR #74852)

2024-01-06 Thread Craig Topper via cfe-commits
https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/74852 >From f281d34a51f662c934f158e4770774b0dc3588a2 Mon Sep 17 00:00:00 2001 From: Seth Pellegrino Date: Thu, 7 Dec 2023 08:45:51 -0800 Subject: [PATCH 1/4] [Clang][Sema] Print more static_assert exprs This change in

[clang] [llvm] [flang] [libcxx] [libc] [clang-tools-extra] [compiler-rt] [lldb] [libunwind] [libc++] Implement ranges::iota (PR #68494)

2024-01-06 Thread James E T Smith via cfe-commits
@@ -13,7 +13,7 @@ // Range algorithms should return `std::ranges::dangling` when given a dangling range. jamesETsmith wrote: This should be resolved with [be7faa6](https://github.com/llvm/llvm-project/pull/68494/commits/be7faa6fb11c09822a9a855c7cf1aecab4f4c7

[clang] [llvm] [flang] [libcxx] [libc] [clang-tools-extra] [compiler-rt] [lldb] [libunwind] [libc++] Implement ranges::iota (PR #68494)

2024-01-06 Thread James E T Smith via cfe-commits
https://github.com/jamesETsmith edited https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang-tools-extra] [clang] [llvm] [mlir][spirv] Support alias/restrict function argument decorations (PR #76353)

2024-01-06 Thread Lei Zhang via cfe-commits
https://github.com/antiagainst edited https://github.com/llvm/llvm-project/pull/76353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang-tools-extra] [clang] [llvm] [mlir][spirv] Support alias/restrict function argument decorations (PR #76353)

2024-01-06 Thread Lei Zhang via cfe-commits
https://github.com/antiagainst closed https://github.com/llvm/llvm-project/pull/76353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >