[clang] [llvm] [clang-tools-extra] Remove unused LoopInfo from InlineSpiller and SpillPlacement (NFC) (PR #71874)

https://github.com/MatzeB updated https://github.com/llvm/llvm-project/pull/71874 >From 3b502f8cc14456b325efc3017a4a114391284b37 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Wed, 19 Oct 2022 10:58:40 -0700 Subject: [PATCH] Remove unused LoopInfo from InlineSpiller and SpillPlacement ---

[lldb] [clang] [mlir] [compiler-rt] [libc] [flang] [llvm] [lld] [libcxx] [clang-tools-extra] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

silee2 wrote: @antiagainst @kuhar Any comments? https://github.com/llvm/llvm-project/pull/71430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 34e4e5e - [flang][Driver] Support -rpath, -shared, and -static in the frontend (#66702)

Author: Tarun Prabhu Date: 2023-11-16T12:01:17-07:00 New Revision: 34e4e5eb70818fca90574beb8f5617e27bfac138 URL: https://github.com/llvm/llvm-project/commit/34e4e5eb70818fca90574beb8f5617e27bfac138 DIFF: https://github.com/llvm/llvm-project/commit/34e4e5eb70818fca90574beb8f5617e27bfac138.diff

[clang] [flang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

https://github.com/tarunprabhu closed https://github.com/llvm/llvm-project/pull/66702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

wheatman wrote: @AaronBallman if there are no more comments, could you please merge it in https://github.com/llvm/llvm-project/pull/69061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [llvm] [WIP][AMDGPU] Enable hostcall printf for OpenCL (PR #70932)

vikramRH wrote: Two different patch sets have been created here, https://github.com/llvm/llvm-project/pull/72554 https://github.com/llvm/llvm-project/pull/72556 https://github.com/llvm/llvm-project/pull/70932 ___ cfe-commits mailing list cfe-commits

[lldb] [clang] [mlir] [compiler-rt] [libc] [flang] [libunwind] [llvm] [lld] [libcxx] [clang-tools-extra] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table a

minglotus-6 wrote: > One heads up, the latest 'git merge main' brings a failure in test > https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/fuzzer/gc-sections.test > :( . `ninja check-all` on a clean main gives the same failure. Hopefully it > would be fixed soon. This is fixed

[clang] [compiler-rt] [flang] [llvm] [clang-tools-extra] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/70762 >From 93d46d40f46663cfa30fc01da965887508684e25 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 30 Oct 2023 21:41:00 -0700 Subject: [PATCH 01/29] [clang] Add support for new loop attribute [[clang::code

[clang] f8e8530 - [StaticAnalyzer] Fix warnings about missing override

Author: Kazu Hirata Date: 2023-11-16T11:06:01-08:00 New Revision: f8e8530f7377ab84b23c268454015fbcb95231c0 URL: https://github.com/llvm/llvm-project/commit/f8e8530f7377ab84b23c268454015fbcb95231c0 DIFF: https://github.com/llvm/llvm-project/commit/f8e8530f7377ab84b23c268454015fbcb95231c0.diff L

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/72478 >From 3a2a066eeadce6b8f3cd5645965ffe564e68fba3 Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Wed, 15 Nov 2023 22:06:46 -0800 Subject: [PATCH 1/3] [CodeGen] Add conditional to module cloning in bitcode linkin

[llvm] [flang] [clang-tools-extra] [clang] [compiler-rt] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,71 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang] [compiler-rt] [flang] [llvm] [clang-tools-extra] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,71 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

MaskRay added a comment. In D150930#4656909 , @brunodf wrote: > Hi, > > I found this review request and I just want to comment that I find it strange > that it was rejected. > > @MaskRay I understand that using a compile_commands.json configured for gcc

[clang] fix: compatible C++ empty record with align UB with gcc (PR #72197)

efriedma-quic wrote: The proper fix here is probably to just delete the `return ABIArgInfo::getDirect(llvm::Type::getInt8Ty(getVMContext()));` from the empty struct codepath on aarch64. Alignment shouldn't affect whether a class is empty. The issue here is just that according to aarch64 AAPC

[llvm] [flang] [clang] [clang-tools-extra] [compiler-rt] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,71 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

https://github.com/AaronBallman approved this pull request. LGTM assuming precommit CI is now fixed. https://github.com/llvm/llvm-project/pull/70877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[llvm] [flang] [clang] [clang-tools-extra] [compiler-rt] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,71 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/72554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

@@ -2458,6 +2458,11 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, &getTarget().getLongDoubleFormat() == &llvm::APFloat::IEEEquad()) BuiltinID = mutateLongDoubleBuiltin(BuiltinID); + // Mutate the printf builtin ID so that we u

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

https://github.com/jhuber6 commented: Any tests? Can you explain why it's not sufficient to do this lowering in the AMDGPU pass? https://github.com/llvm/llvm-project/pull/72554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [clang-tools-extra] [llvm] [compiler-rt] [flang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -359,16 +359,34 @@ static Attr *handleCodeAlignAttr(Sema &S, Stmt *St, const ParsedAttr &A) { static void CheckForDuplicateCodeAlignAttrs(Sema &S, const SmallVectorImpl &Attrs) { - const Attr *A = nullptr; - for (const auto *I : Attrs) { -

[clang-tools-extra] [clang-tidy][NFC][DOC] Add missing HICPP rule id's (PR #72553)

https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/72553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang codegen][regression] Add dso_local/hidden/etc. markings to VTT definitions and declarations (PR #72452)

efriedma-quic wrote: I'd prefer not to call setGVProperties() twice on the same variable; under what conditions is the first call not sufficient? https://github.com/llvm/llvm-project/pull/72452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [Driver] Simply some gcc search logic (PR #72558)

https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/72558 None >From 3a0896141cf11c604f28326b3a6eee3762b4f79d Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 16 Nov 2023 05:54:29 + Subject: [PATCH] [Driver] Simply some gcc search logic --- clang/lib/Drive

[clang] [Driver] Simply some gcc search logic (PR #72558)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Stellard (tstellar) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/72558.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/Gnu.cpp (+7-11) - (modified) clang/lib/Driver/ToolChains/Gnu.h (-1)

[clang] [clang-tools-extra] [llvm] [compiler-rt] [flang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -359,16 +359,34 @@ static Attr *handleCodeAlignAttr(Sema &S, Stmt *St, const ParsedAttr &A) { static void CheckForDuplicateCodeAlignAttrs(Sema &S, const SmallVectorImpl &Attrs) { - const Attr *A = nullptr; - for (const auto *I : Attrs) { -

[llvm] [flang] [clang] [clang-tools-extra] [compiler-rt] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/70762 >From 93d46d40f46663cfa30fc01da965887508684e25 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 30 Oct 2023 21:41:00 -0700 Subject: [PATCH 01/30] [clang] Add support for new loop attribute [[clang::code

[llvm] [clang] [compiler-rt] [clang-tools-extra] [flang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/70762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [flang] [clang] [clang-tools-extra] [compiler-rt] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/70762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [compiler-rt] [llvm] [clang] [flang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,61 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[llvm] [clang] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

@@ -80,6 +94,139 @@ class Address { return Alignment; } + /// Return address with different element type, but same pointer and + /// alignment. + RawAddress withElementType(llvm::Type *ElemTy) const { +return RawAddress(getPointer(), ElemTy, getAlignment(), isKnow

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

@@ -395,27 +395,27 @@ namespace { void CodeGenFunction::EmitAnyExprToExn(const Expr *e, Address addr) { // Make sure the exception object is cleaned up if there's an // exception during initialization. - pushFullExprCleanup(EHCleanup, addr.getPointer()); - EHScopeStack::s

[llvm] [clang] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

@@ -232,19 +232,19 @@ static Value *MakeBinaryAtomicValue( static Value *EmitNontemporalStore(CodeGenFunction &CGF, const CallExpr *E) { Value *Val = CGF.EmitScalarExpr(E->getArg(0)); - Value *Address = CGF.EmitScalarExpr(E->getArg(1)); + Address Addr = CGF.EmitPointerWith

[flang] [clang-tools-extra] [llvm] [clang] [compiler-rt] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -359,16 +359,34 @@ static Attr *handleCodeAlignAttr(Sema &S, Stmt *St, const ParsedAttr &A) { static void CheckForDuplicateCodeAlignAttrs(Sema &S, const SmallVectorImpl &Attrs) { - const Attr *A = nullptr; - for (const auto *I : Attrs) { -

[libcxx] [clang-tools-extra] [llvm] [clang] [libunwind] [libc++] Allow running the test suite with optimizations (PR #68753)

https://github.com/mordante commented: In general I like the patch, some comments. https://github.com/llvm/llvm-project/pull/68753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [llvm] [clang] [libunwind] [clang-tools-extra] [libc++] Allow running the test suite with optimizations (PR #68753)

@@ -0,0 +1,4 @@ +set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "") +set(LIBCXX_TEST_PARAMS "optimization=speed" CACHE STRING "") mordante wrote: Since it's possible to optimized for size too, I'd like "speed" in the name of the cache. https://github.com/llvm

[clang-tools-extra] [llvm] [libcxx] [clang] [libunwind] [libc++] Allow running the test suite with optimizations (PR #68753)

@@ -0,0 +1,28 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[llvm] [libcxx] [libunwind] [clang] [clang-tools-extra] [libc++] Allow running the test suite with optimizations (PR #68753)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/68753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxx] [clang] [clang-tools-extra] [llvm] [libc++] Allow running the test suite with optimizations (PR #68753)

@@ -0,0 +1,28 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[clang] [Clang] Introduce scoped variants of GNU atomic functions (PR #72280)

efriedma-quic wrote: I'm a little wary of adding these without actually going through any sort of standardization process; if other vendors don't support the same interface, we just have more variations. (See also https://clang.llvm.org/get_involved.html#criteria ) How consistent are the var

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

@@ -2458,6 +2458,11 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, &getTarget().getLongDoubleFormat() == &llvm::APFloat::IEEEquad()) BuiltinID = mutateLongDoubleBuiltin(BuiltinID); + // Mutate the printf builtin ID so that we u

[compiler-rt] [llvm] [flang] [clang] [clang-tools-extra] [RISCV] Add bset optimization for left shift code (PR #71420)

https://github.com/rtayl closed https://github.com/llvm/llvm-project/pull/71420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [flang] [clang] [clang-tools-extra] [llvm] [RISCV] Add bset optimization for left shift code (PR #71420)

rtayl wrote: Closing as https://github.com/llvm/llvm-project/pull/72549 covers this. https://github.com/llvm/llvm-project/pull/71420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [flang] [clang] [clang-tools-extra] [llvm] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,71 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[compiler-rt] [flang] [clang] [clang-tools-extra] [llvm] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,71 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[compiler-rt] [flang] [clang] [clang-tools-extra] [llvm] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,71 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[compiler-rt] [llvm] [flang] [clang] [clang-tools-extra] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,61 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang] [clang][driver] Add \/../include/c++/v1 to include path on Darwin (PR #70817)

https://github.com/ilg-ul updated https://github.com/llvm/llvm-project/pull/70817 >From 7fbc229ee7316d826517480ee7896c91dad941f3 Mon Sep 17 00:00:00 2001 From: Liviu Ionescu Date: Tue, 31 Oct 2023 17:09:04 +0200 Subject: [PATCH 01/18] Add \/../include/c++/v1 to include path On macOS, when clan

[clang] [clang][driver] Add \/../include/c++/v1 to include path on Darwin (PR #70817)

https://github.com/ldionne approved this pull request. LGTM assuming CI passes. Thanks! https://github.com/llvm/llvm-project/pull/70817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [llvm] [flang] [clang] [clang-tools-extra] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,71 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang] [clang][driver] Add \/../include/c++/v1 to include path on Darwin (PR #70817)

ilg-ul wrote: > assuming CI passes It passed on my Mac, let's hope that the CI will pass too. But, not related to this PR, on my Mac, I always had several test failing: ``` Failed Tests (7): Clang :: Driver/baremetal.cpp Clang :: Driver/csky-toolchain.c Clang :: Driver/freebsd-include-pa

[compiler-rt] [llvm] [flang] [clang] [clang-tools-extra] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,59 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang] fix: compatible C++ empty record with align UB with gcc (PR #72197)

rjmccall wrote: > This is the code I debug located. Seem the comment is out of date? That seems like the right place to fix the issue, specifically the place below where it always passes a single `i8`. The right rule is to just fall through to the normal conventions for passing the argument i

[clang] fix: compatible C++ empty record with align UB with gcc (PR #72197)

https://github.com/rjmccall closed https://github.com/llvm/llvm-project/pull/72197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix: compatible C++ empty record with align UB with gcc (PR #72197)

rjmccall wrote: > The code you noted is supposed to handle two cases, neither of which are > relevant to your testcase: > > * Darwin-specific calling convention rules. > * GNU extensions for zero-size structs (which aren't allowed according to > either C or C++ standards, but GNU invented a bu

[clang] fix: compatible C++ empty record with align UB with gcc (PR #72197)

https://github.com/rjmccall reopened https://github.com/llvm/llvm-project/pull/72197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2516 +extern bool checkFailParameter(OpenMPClauseKind FailParameter); +/// This represents 'fail' clause in the '#pragma omp atomic' No way for extern functions. Declare in includ

[clang] [flang] [Flang][Clang] Add support for frame pointers in Flang Driver (PR #72146)

https://github.com/Radu2k edited https://github.com/llvm/llvm-project/pull/72146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

@@ -2458,6 +2458,11 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, &getTarget().getLongDoubleFormat() == &llvm::APFloat::IEEEquad()) BuiltinID = mutateLongDoubleBuiltin(BuiltinID); + // Mutate the printf builtin ID so that we u

[clang] [Clang] Introduce scoped variants of GNU atomic functions (PR #72280)

jhuber6 wrote: > I'm a little wary of adding these without actually going through any sort of > standardization process; if other vendors don't support the same interface, > we just have more variations. (See also > https://clang.llvm.org/get_involved.html#criteria ) > > How consistent are th

[llvm] [clang-tools-extra] [libunwind] [clang] [libcxx] [libc++] Allow running the test suite with optimizations (PR #68753)

https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68753 >From 9824ef111975386152173916c1fd6a85264be0a0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Oct 2023 16:35:11 -0700 Subject: [PATCH 1/9] [libc++] Allow running the test suite with optimizations This

[clang] [clang] Ensure fixed point conversions work in C++ (PR #68344)

https://github.com/rjmccall approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/68344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b2d62c9 - [clang] Ensure fixed point conversions work in C++ (#68344)

Author: PiJoules Date: 2023-11-16T13:11:15-08:00 New Revision: b2d62c9a58433e2a2ca8d2c9cd6b0b612dca2e76 URL: https://github.com/llvm/llvm-project/commit/b2d62c9a58433e2a2ca8d2c9cd6b0b612dca2e76 DIFF: https://github.com/llvm/llvm-project/commit/b2d62c9a58433e2a2ca8d2c9cd6b0b612dca2e76.diff LOG:

[clang] [clang] Ensure fixed point conversions work in C++ (PR #68344)

https://github.com/PiJoules closed https://github.com/llvm/llvm-project/pull/68344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [compiler-rt] [flang] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,59 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[llvm] [clang-tools-extra] [lldb] [compiler-rt] [flang] [clang] [mlir] [Profile] Add binary profile correlation for code coverage. (PR #69493)

ZequanWu wrote: > Some further discussion/pre-work needed before proceeding with this PR. These two discussions are addressed and this is ready to be reviewed. 1. Support for merging with multiple correlation files will be done in a separate change. 2. Removed the `VARIANT_MASK_BIN_CORRELATE`

[clang] [clang][driver] Add \/../include/c++/v1 to include path on Darwin (PR #70817)

ldionne wrote: That's a question for the Clang regulars -- I generally don't run those tests since I primarily work on libc++, not Clang. https://github.com/llvm/llvm-project/pull/70817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[llvm] [clang-tools-extra] [compiler-rt] [flang] [clang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

@@ -322,6 +322,59 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, +Expr *E) { + if

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

@@ -13540,6 +13540,15 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr *Init, bool DirectInit) { CreateRecoveryExpr(Init->getBeginLoc(), Init->getEndLoc(), Args); if (RecoveryExpr.get()) VDecl->setInit(RecoveryExpr.get()); + // In general, f

[libcxx] [clang] [compiler-rt] [llvm] fix python SyntaxWarnings in check-all output (PR #72538)

https://github.com/ldionne approved this pull request. LGTM. @petrhosek might want to take a quick look at the compiler-rt part though. https://github.com/llvm/llvm-project/pull/72538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [ClangModule] Fix decl-params-determinisim test after serialization change (PR #72572)

https://github.com/cachemeifyoucan created https://github.com/llvm/llvm-project/pull/72572 Fix decl-params-determinisim test after 48be81e1 packed some information in the clang module. The test is to make sure the decls are appearing in a strict ordering and it relies on check the correct fiel

[clang] [ClangModule] Fix decl-params-determinisim test after serialization change (PR #72572)

llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Steven Wu (cachemeifyoucan) Changes Fix decl-params-determinisim test after 48be81e1 packed some information in the clang module. The test is to make sure the decls are appearing in a strict ordering and it relies on check the cor

[clang] [ClangModule] Fix decl-params-determinisim test after serialization change (PR #72572)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Steven Wu (cachemeifyoucan) Changes Fix decl-params-determinisim test after 48be81e1 packed some information in the clang module. The test is to make sure the decls are appearing in a strict ordering and it relies on check the correct fie

[clang] [llvm] [clang-tools-extra] Remove unused LoopInfo from InlineSpiller and SpillPlacement (NFC) (PR #71874)

https://github.com/MatzeB updated https://github.com/llvm/llvm-project/pull/71874 >From 3b502f8cc14456b325efc3017a4a114391284b37 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Wed, 19 Oct 2022 10:58:40 -0700 Subject: [PATCH 1/2] Remove unused LoopInfo from InlineSpiller and SpillPlacement

[clang-tools-extra] [llvm] [clang] Remove unused LoopInfo from InlineSpiller and SpillPlacement (NFC) (PR #71874)

https://github.com/MatzeB updated https://github.com/llvm/llvm-project/pull/71874 >From 3b502f8cc14456b325efc3017a4a114391284b37 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Wed, 19 Oct 2022 10:58:40 -0700 Subject: [PATCH 1/3] Remove unused LoopInfo from InlineSpiller and SpillPlacement

[clang] ae623d1 - [Driver,Gnu] Simplify -static -static-pie -shared -pie handling and suppress -shared -rdynamic warning

Author: Fangrui Song Date: 2023-11-16T13:48:04-08:00 New Revision: ae623d16d50c9f12de7ae7ac1aa11c9d6857e081 URL: https://github.com/llvm/llvm-project/commit/ae623d16d50c9f12de7ae7ac1aa11c9d6857e081 DIFF: https://github.com/llvm/llvm-project/commit/ae623d16d50c9f12de7ae7ac1aa11c9d6857e081.diff

[PATCH] D154396: [clang] Add support for SerenityOS

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:25 + +static bool getPIE(const ArgList &Args, const ToolChain &TC) { + if (Args.hasArg(options::OPT_static, options::OPT_shared, I've simplified `Gnu.cpp` a bit for handling diff

[clang] [-Wunsafe-buffer-usage] Add FixableGadget for AddAssign in UnspecifiedUntypedContext (PR #71862)

https://github.com/t-rasmud updated https://github.com/llvm/llvm-project/pull/71862 >From 6636745d1c444747a33c91b366a730d81ca5db5a Mon Sep 17 00:00:00 2001 From: Rashmi Mudduluru Date: Wed, 1 Nov 2023 13:43:12 -0700 Subject: [PATCH 01/13] [-Wunsafe-buffer-usage][WIP] Fixable gadget for AddAssi

[clang] [ClangModule] Fix decl-params-determinisim test after serialization change (PR #72572)

@@ -23,27 +23,28 @@ jansvoboda11 wrote: Should `op13` in the comment be updated? https://github.com/llvm/llvm-project/pull/72572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[lldb] [clang] [llvm] [clang-tools-extra] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -627,7 +628,7 @@ class Target : public std::enable_shared_from_this, // used. const lldb::ProcessSP &CreateProcess(lldb::ListenerSP listener_sp, llvm::StringRef plugin_name, - const FileSpec *cr

[clang] [ClangModule] Fix decl-params-determinisim test after serialization change (PR #72572)

https://github.com/jansvoboda11 approved this pull request. LGTM with little nit. https://github.com/llvm/llvm-project/pull/72572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

https://github.com/GeorgeHuyubo edited https://github.com/llvm/llvm-project/pull/71769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ClangModule] Fix decl-params-determinisim test after serialization change (PR #72572)

https://github.com/cachemeifyoucan updated https://github.com/llvm/llvm-project/pull/72572 >From 89938936f2e021360e3889548608e76022c3d73b Mon Sep 17 00:00:00 2001 From: Steven Wu Date: Thu, 16 Nov 2023 13:21:27 -0800 Subject: [PATCH 1/2] [ClangModule] Fix decl-params-determinisim test after se

[clang] [Clang] Introduce scoped variants of GNU atomic functions (PR #72280)

efriedma-quic wrote: > I figured we can just treat these as clang extensions for the time being. We > already have two variants that are more or less redundant for specific > use-cases, (OpenCL and HIP), which should be able to be removed after this. I'm not sure what you mean here. If you me

[clang] 066c452 - [AArch64] Add support for Cortex-A520, Cortex-A720 and Cortex-X4 CPUs (#72395)

Author: Jonathan Thackray Date: 2023-11-16T22:08:58Z New Revision: 066c4524bc1d91b49048e7f05dc6e045bb3c9eef URL: https://github.com/llvm/llvm-project/commit/066c4524bc1d91b49048e7f05dc6e045bb3c9eef DIFF: https://github.com/llvm/llvm-project/commit/066c4524bc1d91b49048e7f05dc6e045bb3c9eef.diff

[clang] [llvm] [AArch64] Add support for Cortex-A520, Cortex-A720 and Cortex-X4 CPUs (PR #72395)

https://github.com/jthackray closed https://github.com/llvm/llvm-project/pull/72395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Introduce scoped variants of GNU atomic functions (PR #72280)

jhuber6 wrote: > > I figured we can just treat these as clang extensions for the time being. > > We already have two variants that are more or less redundant for specific > > use-cases, (OpenCL and HIP), which should be able to be removed after this. > > I'm not sure what you mean here. If you

[clang] [Driver] Make ELF -nopie specific to OpenBSD (PR #72578)

https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/72578 -no-pie[1]/-nopie is rarely used and among the rare uses almost everwhere uses -no-pie, since GCC does not recognize -nopie. However, OpenBSD seems to prefer -nopie. Therefore, make -nopie specific to OpenBSD to p

[clang] [Driver] Make ELF -nopie specific to OpenBSD (PR #72578)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Fangrui Song (MaskRay) Changes -no-pie[1]/-nopie is rarely used and among the rare uses almost everwhere uses -no-pie, since GCC does not recognize -nopie. However, OpenBSD seems to prefer -nopie. Therefore, make -nopie specific to O

[clang] [AVR] make the AVR ABI Swift compatible (PR #72298)

efriedma-quic wrote: Can you not test this by checking an `__attribute__((swiftcall))` function works in C? https://github.com/llvm/llvm-project/pull/72298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [AVR] make the AVR ABI Swift compatible (PR #72298)

efriedma-quic wrote: See also #71986 https://github.com/llvm/llvm-project/pull/72298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix finding instantiated decls for class template specializations during instantiation (PR #72346)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/72346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix finding instantiated decls for class template specializations during instantiation (PR #72346)

https://github.com/shafik commented: This makes some sense but I am not familiar enough with this area. https://github.com/llvm/llvm-project/pull/72346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [Clang] Fix finding instantiated decls for class template specializations during instantiation (PR #72346)

@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 -verify -fsyntax-only %s shafik wrote: Normally we put lone tests for a specific bug report in its own file e.g. GH70735.cpp for this case or we find a test that covers a similar area and put the test in a namespace named af

[clang] [AVR] make the AVR ABI Swift compatible (PR #72298)

rjmccall wrote: Right, that would be the way to test it. I don't know much about AVR, but you should also look at some of the parameters to the lowering (e.g. how many max values it's okay to break an aggregate into) and make sure you're happy with them. https://github.com/llvm/llvm-project/p

[clang] [Driver] Make ELF -nopie specific to OpenBSD (PR #72578)

brad0 wrote: -nopie is for the linker. We only use -fno-pie for the compiler. https://github.com/llvm/llvm-project/pull/72578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f0ad9ea - [clang-format] Handle lambdas in QualifierAlignment (#72456)

Author: Owen Pan Date: 2023-11-16T15:00:09-08:00 New Revision: f0ad9ea36ad65cec8c5e5d1d59c00192b87f287d URL: https://github.com/llvm/llvm-project/commit/f0ad9ea36ad65cec8c5e5d1d59c00192b87f287d DIFF: https://github.com/llvm/llvm-project/commit/f0ad9ea36ad65cec8c5e5d1d59c00192b87f287d.diff LOG:

[clang] [clang-format] Handle lambdas in QualifierAlignment (PR #72456)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/72456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix crashes in AlignArrayOfStructures (PR #72520)

@@ -1316,6 +1316,8 @@ void WhitespaceManager::alignArrayInitializersRightJustified( auto Offset = std::distance(Cells.begin(), CellIter); for (const auto *Next = CellIter->NextColumnElement; Next; Next = Next->NextColumnElement) { + if (Ro

[libunwind] [libunwind] Introduce _LIBUNWIND_TRACE_DWARF_EVAL for increased baremetal friendliness (PR #72040)

@@ -381,24 +381,22 @@ typename A::pint_t DwarfInstructions::evaluateExpression(pint_t expression, A &addressSpace, const R ®isters, pint_t initialStackValue) { - const bool log = false;

<    1   2   3   4   >