================ @@ -322,6 +322,71 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, + Expr *E) { + if (!E->isValueDependent()) { + llvm::APSInt ArgVal; + ExprResult Res = VerifyIntegerConstantExpression(E, &ArgVal); + if (Res.isInvalid()) + return nullptr; + E = Res.get(); + + // This attribute requires an integer argument which is a constant power of + // two between 1 and 4096 inclusive. + if (ArgVal < CodeAlignAttr::MinimumAlignment || + ArgVal > CodeAlignAttr::MaximumAlignment || + (ArgVal < CodeAlignAttr::MaximumAlignment && !ArgVal.isPowerOf2())) { + if (std::optional<int64_t> Value = ArgVal.trySExtValue()) + Diag(CI.getLoc(), diag::err_attribute_power_of_two_in_range) + << CI << CodeAlignAttr::MinimumAlignment + << CodeAlignAttr::MaximumAlignment << Value.value(); + else + Diag(CI.getLoc(), diag::err_attribute_power_of_two_in_range) + << CI << CodeAlignAttr::MinimumAlignment + << CodeAlignAttr::MaximumAlignment << E; + return nullptr; + } + } + return new (Context) CodeAlignAttr(Context, CI, E); +} + +static Attr *handleCodeAlignAttr(Sema &S, Stmt *St, const ParsedAttr &A) { + + Expr *E = A.getArgAsExpr(0); + return S.BuildCodeAlignAttr(A, E); +} + +// Emit duplicate error for [[clang::code_align()]] attribute. +static void CheckForDuplicateCodeAlignAttrs(Sema &S, + ArrayRef<const Attr *> Attrs) { + // Create a list of CodeAlign attributes only. + SmallVector<const CodeAlignAttr *, 8> OnlyCodeAlignAttrs; ---------------- smanna12 wrote:
Thanks @erichkeane. This is fixed with commit https://github.com/llvm/llvm-project/pull/70762/commits/09b00c761f177c3c6ad2285fa5b7642f9c7d28cc https://github.com/llvm/llvm-project/pull/70762 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits