[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-12 Thread Aaron Ballman via cfe-commits
@@ -185,6 +185,9 @@ New Compiler Flags the preprocessed text to the output. This can greatly reduce the size of the preprocessed output, which can be helpful when trying to reduce a test case. +* ``-conversion-bitfield-assign`` was added to detect assignments of integral -

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-12 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 created https://github.com/llvm/llvm-project/pull/68908 The svldr_vnum_za and svstr_vnum_za builtins/intrinsics currently require that the vnum argument be an immediate, but since vnum is used to modify the base register via a mul and add, that restriction is not

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

2023-10-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Sam Tebbs (SamTebbs33) Changes The svldr_vnum_za and svstr_vnum_za builtins/intrinsics currently require that the vnum argument be an immediate, but since vnum is used to modify the base register via a mul and add, that restrictio

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

2023-10-12 Thread Sam Tebbs via cfe-commits
SamTebbs33 wrote: I've decided to keep this PR up for the patch that modifies the codegen and IR intrinsic since there's a lot of good relevant review of that here. I've made a [new PR](https://github.com/llvm/llvm-project/pull/68908) with the separated changes that just modify the clang built

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

2023-10-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: This appears to have broken the clang-tools-extra Sphinx bot: https://lab.llvm.org/buildbot/#/builders/115/builds/54901 ``` CMake Error at /home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/src/clang/docs/CMakeLists.txt:110 (message): Cannot find DOT ``` https:

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-10-12 Thread Hongtao Yu via cfe-commits
htyu wrote: > @htyu Pretty much a drive-by question if it's convenient for you to share > more, how ranges are selected out of sampled values? For example, are ranges > the same for all workloads or dynamically generated based on the distribution > of size from the per-workload profile data?

[clang] 7b12d8b - [clang][Tests] Fix shared build. NFC

2023-10-12 Thread Michael Liao via cfe-commits
Author: Michael Liao Date: 2023-10-12T12:24:18-04:00 New Revision: 7b12d8bf8a1ff1540e32345b045f813644708a71 URL: https://github.com/llvm/llvm-project/commit/7b12d8bf8a1ff1540e32345b045f813644708a71 DIFF: https://github.com/llvm/llvm-project/commit/7b12d8bf8a1ff1540e32345b045f813644708a71.diff

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

2023-10-12 Thread Stephen Tozer via cfe-commits
SLTozer wrote: Small ping - all comments have now been addressed now I think. https://github.com/llvm/llvm-project/pull/66632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Okay, I made sure it says `argument unused during compilation: > '/Zc:__STDC__'` and never defines **STDC** in C++ mode, but I have couple of > questions: > > * Where should I put the test to make sure `-fno-ms-define-stdc` is not > accepted? I think that would make

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-12 Thread via cfe-commits
https://github.com/DanielKristofKiss requested changes to this pull request. Could you please update the documentation too? ( https://clang.llvm.org/docs/AttributeReference.html#id587 lives here `clang/include/clang/Basic/AttrDocs.td` ) https://github.com/llvm/llvm-project/pull/68678

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-12 Thread via cfe-commits
@@ -76,10 +80,14 @@ int __attribute__((target("fpmath=387"))) walrus(void) { return 4; } int __attribute__((target("float128,arch=hiss"))) meow(void) { return 4; } // no warning, same as saying 'nothing'. int __attribute__((target("arch="))) turtle(void) { return 4; } +// no

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-12 Thread via cfe-commits
https://github.com/DanielKristofKiss requested changes to this pull request. Could you please update the documentation too? ( https://clang.llvm.org/docs/AttributeReference.html#id587 lives here `clang/include/clang/Basic/AttrDocs.td` ) https://github.com/llvm/llvm-project/pull/68678

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-12 Thread via cfe-commits
https://github.com/DanielKristofKiss edited https://github.com/llvm/llvm-project/pull/68678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-12 Thread via cfe-commits
https://github.com/DanielKristofKiss edited https://github.com/llvm/llvm-project/pull/68678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

2023-10-12 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @AaronBallman, we need to install dot/doxygen on this machine as Sphinx requires graphviz. The PR has a link to the discussion and we could not find the bot owners. https://github.com/llvm/llvm-project/pull/65650 ___ cfe-commits ma

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! Thank you for the cleanup on the diagnostics, too. :-) https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-12 Thread Aaron Ballman via cfe-commits
@@ -282,7 +282,7 @@ class CorrectionCandidateCallback { public: static const unsigned InvalidDistance = TypoCorrection::InvalidDistance; - explicit CorrectionCandidateCallback(IdentifierInfo *Typo = nullptr, + explicit CorrectionCandidateCallback(const IdentifierInfo *Typo

[clang] [clang][Interp] Support AddOffset with 128bit offsets (PR #68679)

2023-10-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

2023-10-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman, we need to install dot/doxygen on this machine as Sphinx > requires graphviz. The PR has a link to the discussion and we could not find > the bot owners. Ouch, we've struggled recently to get the attention of the sphinx bot owners. :-( The publication bot

[clang] [Clang][Frontend] Fix a crash when -Wdocumentation is used (PR #68525)

2023-10-12 Thread Byoungchan Lee via cfe-commits
bc-lee wrote: Since **I'm not an expert in clang AST**, it is hard to reduce the failing cases. According to my analysis, this crash only happens when the multiple files are involved, so code reduction tools like creduce doesn't helpful a lot. Instead, I'm providing an explanation of the crash

[clang] Lower std::string's alignment requirement from 16 to 8. (PR #68807)

2023-10-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 05181a849b4c1ec14fdd6d667285d6f5ad34a5a2..ffc0f0ffa4164f9b426e4b30897c86577e2aa867 mlir/p

[libunwind] Lower std::string's alignment requirement from 16 to 8. (PR #68807)

2023-10-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 05181a849b4c1ec14fdd6d667285d6f5ad34a5a2..ffc0f0ffa4164f9b426e4b30897c86577e2aa867 mlir/p

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-12 Thread Aaron Ballman via cfe-commits
@@ -100,12 +100,13 @@ template class IntegralAP final { } static IntegralAP from(const Boolean &B) { assert(false); -return IntegralAP::zero(); +return IntegralAP::zero(1); AaronBallman wrote: Why does this not look at the value of `B`? https

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-12 Thread Aaron Ballman via cfe-commits
@@ -100,12 +100,13 @@ template class IntegralAP final { } static IntegralAP from(const Boolean &B) { assert(false); -return IntegralAP::zero(); +return IntegralAP::zero(1); } - static IntegralAP zero() { -assert(false); -return IntegralAP(0); + s

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-12 Thread Aaron Ballman via cfe-commits
@@ -1642,9 +1642,9 @@ bool ByteCodeExprGen::visitZeroInitializer(QualType QT, case PT_Uint64: return this->emitZeroUint64(E); case PT_IntAP: +return this->emitZeroIntAP(128, E); // FIXME: Ctx.getBitWidth() case PT_IntAPS: -assert(false); -return false; +

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-12 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/68276 >From 47e36266e93de9c34ba3028951a58124864bb2b4 Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 5 Oct 2023 02:39:12 +0200 Subject: [PATCH] [Sema] Add check for bitfield assignments to integral types W

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-12 Thread via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: %clang_cc1 -Wconversion -fsyntax-only -verify %s +// RUN: %clang_cc1 -Wbitfield-conversion -fsyntax-only -verify %s + +typedef struct _xx { + int bf:9; // expected-note{{declared here}} + // expected-note@-1{{declared here}} + // expected-note

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-12 Thread via cfe-commits
@@ -185,6 +185,9 @@ New Compiler Flags the preprocessed text to the output. This can greatly reduce the size of the preprocessed output, which can be helpful when trying to reduce a test case. +* ``-conversion-bitfield-assign`` was added to detect assignments of integral -

[clang] [clang][Interp] Only emit function_param_value_unknown in C++11 (PR #67990)

2023-10-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Test coverage? https://github.com/llvm/llvm-project/pull/67990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Specify Type and ExtQuals as having 16-byte alignment (PR #68377)

2023-10-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! If @zygoloid (or others) have concerns, we can revert and address them post-commit. https://github.com/llvm/llvm-project/pull/68377 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

2023-10-12 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie edited https://github.com/llvm/llvm-project/pull/66632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

2023-10-12 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. looks good - a few bits should be committed separately from this change, so please do those first and then commit this change https://github.com/llvm/llvm-project/pull/66632 ___ cfe-commits mail

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

2023-10-12 Thread David Blaikie via cfe-commits
@@ -1085,6 +1085,7 @@ The integer codes are mapped to well-known attributes as follows. * code 77: ``elementtype`` * code 78: ``disable_sanitizer_instrumentation`` * code 79: ``nosanitize_bounds`` +* code 88: ``optdebug`` dwblaikie wrote: This could/should be

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

2023-10-12 Thread David Blaikie via cfe-commits
@@ -2028,6 +2030,8 @@ example: This attribute suggests that optimization passes and code generator passes should make choices that try to preserve debug info without significantly degrading runtime performance. +This attribute is incompatible with the ``minsize`

[clang] Add `target modules dump separate-debug-info` (PR #66035)

2023-10-12 Thread Tom Yang via cfe-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035 >From 9a52ac5193af2a8ddca2a5d922684935b043d0ef Mon Sep 17 00:00:00 2001 From: Tom Yang Date: Mon, 11 Sep 2023 17:17:13 -0700 Subject: [PATCH 1/2] Add `target modules dump separate-debug-info` Summary: Add a new co

[clang-tools-extra] Add `target modules dump separate-debug-info` (PR #66035)

2023-10-12 Thread Tom Yang via cfe-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035 >From 9a52ac5193af2a8ddca2a5d922684935b043d0ef Mon Sep 17 00:00:00 2001 From: Tom Yang Date: Mon, 11 Sep 2023 17:17:13 -0700 Subject: [PATCH 1/2] Add `target modules dump separate-debug-info` Summary: Add a new co

[clang] 4c6cba3 - [clang][NFC] Specify Type and ExtQuals as having 16-byte alignment (#68377)

2023-10-12 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-10-12T21:54:07+04:00 New Revision: 4c6cba31767cdb7f83ec4ca0eab9b6eae127 URL: https://github.com/llvm/llvm-project/commit/4c6cba31767cdb7f83ec4ca0eab9b6eae127 DIFF: https://github.com/llvm/llvm-project/commit/4c6cba31767cdb7f83ec4ca0eab9b6eae127.

[clang] [clang][NFC] Specify Type and ExtQuals as having 16-byte alignment (PR #68377)

2023-10-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/68377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dd0f642 - [Sema] Add check for bitfield assignments to larger integral types (#68276)

2023-10-12 Thread via cfe-commits
Author: vabridgers Date: 2023-10-12T13:14:20-05:00 New Revision: dd0f642e6ec5049ccabe3f462cc427ffe213829b URL: https://github.com/llvm/llvm-project/commit/dd0f642e6ec5049ccabe3f462cc427ffe213829b DIFF: https://github.com/llvm/llvm-project/commit/dd0f642e6ec5049ccabe3f462cc427ffe213829b.diff LO

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-12 Thread via cfe-commits
https://github.com/vabridgers closed https://github.com/llvm/llvm-project/pull/68276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-10-12 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,14 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.6-library -x hlsl -finclude-default-header -verify %s + + +int2 ToTwoInts(int V) { + return V.xy; // expected-error{{vector component access exceeds type 'int __attribute__((ext_vector_type(1)))' (vector of 1 'i

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-10-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/67700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-10-12 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,78 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.6-library -x hlsl \ +// RUN: -finclude-default-header -ast-dump %s | FileCheck %s + + +// CHECK: ExtVectorElementExpr {{.*}} 'int __attribute__((ext_vector_type(2)))' xx +// CHECK-NEXT: ImplicitCastExpr {{.*}} '

[clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2023-10-12 Thread Nemanja Ivanovic via cfe-commits
https://github.com/nemanjai created https://github.com/llvm/llvm-project/pull/68919 Make __builtin_cpu_{init|supports|is} target independent and provide an opt-in query for targets that want to support it. Each target is still responsible for their specific lowering/code-gen. Also provide code

[clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2023-10-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nemanja Ivanovic (nemanjai) Changes Make __builtin_cpu_{init|supports|is} target independent and provide an opt-in query for targets that want to support it. Each target is still responsible for their specific lowering/code-gen. Also prov

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

2023-10-12 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added a comment. In D152914#4653669 , @lei wrote: > HI @nemanjai, Did you get a chance to post this as a github PR? Long overdue, but I finally have it up at https://github.com/llvm/llvm-project/pull/68919 Repository: rG LLVM Github Monorep

[clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2023-10-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dd0f642e6ec5049ccabe3f462cc427ffe213829b 71f1352bf00d6a9eefa3f199859d47d093f272f8 --

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-10-12 Thread via cfe-commits
@@ -1950,6 +1950,10 @@ bool Lexer::LexNumericConstant(Token &Result, const char *CurPtr) { while (isPreprocessingNumberBody(C)) { CurPtr = ConsumeChar(CurPtr, Size, Result); PrevCh = C; +if (LangOpts.HLSL && C == '.' && (*CurPtr == 'x' || *CurPtr == 'r')) { +

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-10-12 Thread via cfe-commits
@@ -930,7 +930,11 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling, // and FP constants (specifically, the 'pp-number' regex), and assumes that // the byte at "*end" is both valid and not part of the regex. Because of // this, it doesn't have to check

[clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2023-10-12 Thread Nemanja Ivanovic via cfe-commits
https://github.com/nemanjai updated https://github.com/llvm/llvm-project/pull/68919 >From 71f1352bf00d6a9eefa3f199859d47d093f272f8 Mon Sep 17 00:00:00 2001 From: Nemanja Ivanovic Date: Thu, 12 Oct 2023 14:08:42 -0400 Subject: [PATCH 1/2] [PowerPC][X86] Make cpu id builtins target independent a

[clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2023-10-12 Thread Sami Tolvanen via cfe-commits
samitolvanen wrote: The patch basically changes the ShadowCallStack back-end to emit an sspush/sspopchk instead of the usual SCS push/pop, which seems like a reasonable approach to me. However, it would be helpful to mention the dependency on `-fsanitize=shadow-call-stack` in the commit messag

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-12 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/68921 clang-cl is a driver mode that accepts options of MSVC cl.exe as a drop-in replacement for cl.exe. Currently clang-cl accepts mixed clang style options and cl style options. To let clang-cl accept a clang-style

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes clang-cl is a driver mode that accepts options of MSVC cl.exe as a drop-in replacement for cl.exe. Currently clang-cl accepts mixed clang style options and cl style options. To let clang-cl accept a clan

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

2023-10-12 Thread via cfe-commits
cor3ntin wrote: This is the documentation i found. Can you confirm the intent is only to support `.x???` and `r???` ? It alludes to more options. Maybe we need a `isHLSLSwizzleStart` function to avoid comparing to `'x'` and `'r'` in multiple places. https://learn.microsoft.com/en-us/windows/win

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-10-12 Thread David Li via cfe-commits
david-xl wrote: The performance win depends a lot on value distribution. For large copies, using SIMD with nontemporal hint is the way to go. https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [PowerPC] Fix use of FPSCR builtins in smmintrin.h (PR #67299)

2023-10-12 Thread Nemanja Ivanovic via cfe-commits
@@ -11595,6 +11595,50 @@ SDValue PPCTargetLowering::LowerFP_EXTEND(SDValue Op, SelectionDAG &DAG) const { llvm_unreachable("ERROR:Should return for all cases within swtich."); } +// Lower mffsl intrinsic with mffs in targets without ISA 3.0 +static SDValue lowerMFFSL(SDValu

[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-12 Thread Stanislav Mekhanoshin via cfe-commits
rampitec wrote: > LGTM modulo one remaining comment about validateVOPLiteral. Done. https://github.com/llvm/llvm-project/pull/68740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-12 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/68740 >From cc9e065a9218eb36750a2c2a4a4d08fae3f329fa Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Wed, 4 Oct 2023 13:36:25 -0700 Subject: [PATCH 1/6] [AMDGPU] Change the representation of double literals

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-12 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/68922 `S.getScopeForContext` determins the **active** scope associated with the given `declContext`. This fails to find the matching `operator!=` if candidate `operator==` was found via ADL since that scope is not activ

[clang] [clang][dataflow] Check for backedges directly (instead of loop statements). (PR #68923)

2023-10-12 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand created https://github.com/llvm/llvm-project/pull/68923 Widen on backedge nodes, instead of nodes with a loop statement as terminator. This fixes #67834 and a precision loss from assignment in a loop condition. The commit contains tests for both of these issues. >From d

[clang] [clang][dataflow] Check for backedges directly (instead of loop statements). (PR #68923)

2023-10-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yitzhak Mandelbaum (ymand) Changes Widen on backedge nodes, instead of nodes with a loop statement as terminator. This fixes #67834 and a precision loss from assignment in a loop condition. The commit contains tests for both of these issue

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-12 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 ready_for_review https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Utkarsh Saxena (usx95) Changes `S.getScopeForContext` determins the **active** scope associated with the given `declContext`. This fails to find the matching `operator!=` if candidate `operator==` was found via ADL since that scope is no

[clang] [clang][dataflow] Check for backedges directly (instead of loop statements). (PR #68923)

2023-10-12 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/68923 >From 83486a35e6d0e754dd99369fc546d04afedbe923 Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Thu, 12 Oct 2023 19:35:54 + Subject: [PATCH] [clang][dataflow] Check for backedges directly (instead of loo

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-12 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922 >From 0c71b6bdd557ff4b9ad9a4ec4f0919e3460596b0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 12 Oct 2023 21:35:52 +0200 Subject: [PATCH 1/2] Find opertor!= in the correct namespace --- clang/lib/Sema/Se

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-12 Thread Richard Smith via cfe-commits
zygoloid wrote: Does this work for function-scope operator declarations? https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Check for backedges directly (instead of loop statements). (PR #68923)

2023-10-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 50ece4cba949787241b5fbfc94be6cfdc66e90ee da8cacb47b8f80f7ecb1e86f98683be6c54b4e57 --

[PATCH] D117593: [clang-tidy] Change google-explicit-constructor to ignore conversions and operators marked `explicit(false)`

2023-10-12 Thread Luka Govedič via Phabricator via cfe-commits
ProExpertProg added a comment. Is there an update on this? I agree adding a flag to control this behavior would be good but the Google style guide clearly does not take the `explicit(false)` option into consideration. Currently the only alternatives are a disabling the check completely or addin

[clang] [clang][dataflow] Check for backedges directly (instead of loop statements). (PR #68923)

2023-10-12 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. Nice fix! So, it looks like our definition of "loop head" was wrong. https://github.com/llvm/llvm-project/pull/68923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [Driver] Corrections for linker flags passed with relocatable linking on OpenBSD (PR #67254)

2023-10-12 Thread Brad Smith via cfe-commits
brad0 wrote: @MaskRay ping. https://github.com/llvm/llvm-project/pull/67254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ef38833 - Revert "Reapply "InstCombine: Introduce SimplifyDemandedUseFPClass""

2023-10-12 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2023-10-12T20:23:39Z New Revision: ef388334ee5a3584255b9ef5b3fefdb244fa3fd7 URL: https://github.com/llvm/llvm-project/commit/ef388334ee5a3584255b9ef5b3fefdb244fa3fd7 DIFF: https://github.com/llvm/llvm-project/commit/ef388334ee5a3584255b9ef5b3fefdb244fa3fd7.diff LOG:

[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-12 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/68740 >From cc9e065a9218eb36750a2c2a4a4d08fae3f329fa Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Wed, 4 Oct 2023 13:36:25 -0700 Subject: [PATCH 1/6] [AMDGPU] Change the representation of double literals

[clang] [clang][dataflow] Check for backedges directly (instead of loop statements). (PR #68923)

2023-10-12 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/68923 >From 83486a35e6d0e754dd99369fc546d04afedbe923 Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Thu, 12 Oct 2023 19:35:54 + Subject: [PATCH 1/2] [clang][dataflow] Check for backedges directly (instead of

[clang] [clang][dataflow] Check for backedges directly (instead of loop statements). (PR #68923)

2023-10-12 Thread Yitzhak Mandelbaum via cfe-commits
ymand wrote: > Nice fix! So, it looks like our definition of "loop head" was wrong. Indeed. We didn't think of the way control-flow constructs *inside* the condition expression would be represented. Ironically (?), this is actually simpler and fixes another issue besides, which is nice. ;) ht

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

2023-10-12 Thread Yusra Syeda via cfe-commits
https://github.com/ysyeda created https://github.com/llvm/llvm-project/pull/68926 This PR adds support for the PPA2 fields. >From 5ea8bea2bdf345e2baee07e0a94ac40bd0f109c4 Mon Sep 17 00:00:00 2001 From: Yusra Syeda Date: Thu, 12 Oct 2023 16:56:27 -0400 Subject: [PATCH] This change adds support

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

2023-10-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Yusra Syeda (ysyeda) Changes This PR adds support for the PPA2 fields. --- Patch is 21.58 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/68926.diff 12 Files Affected: - (modified) cl

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-12 Thread David Li via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-12 Thread David Li via cfe-commits
@@ -902,12 +890,16 @@ std::error_code SampleProfileReaderExtBinaryBase::readFuncProfiles() { for (const auto &NameOffset : FuncOffsetList) { const auto &FContext = NameOffset.first; auto FName = FContext.getName(); +StringRef FNameString;

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-12 Thread David Li via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-12 Thread David Li via cfe-commits
@@ -902,12 +890,16 @@ std::error_code SampleProfileReaderExtBinaryBase::readFuncProfiles() { for (const auto &NameOffset : FuncOffsetList) { const auto &FContext = NameOffset.first; auto FName = FContext.getName(); +StringRef FNameString; +

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-12 Thread David Li via cfe-commits
@@ -902,12 +890,16 @@ std::error_code SampleProfileReaderExtBinaryBase::readFuncProfiles() { for (const auto &NameOffset : FuncOffsetList) { const auto &FContext = NameOffset.first; auto FName = FContext.getName(); +StringRef FNameString; +

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-12 Thread David Li via cfe-commits
@@ -902,12 +890,16 @@ std::error_code SampleProfileReaderExtBinaryBase::readFuncProfiles() { for (const auto &NameOffset : FuncOffsetList) { const auto &FContext = NameOffset.first; auto FName = FContext.getName(); +StringRef FNameString; +

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

2023-10-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2ae3a712304870adf639a33547c1139a7b6304e5 5ea8bea2bdf345e2baee07e0a94ac40bd0f109c4 --

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

2023-10-12 Thread Yusra Syeda via cfe-commits
https://github.com/ysyeda updated https://github.com/llvm/llvm-project/pull/68926 >From 5ea8bea2bdf345e2baee07e0a94ac40bd0f109c4 Mon Sep 17 00:00:00 2001 From: Yusra Syeda Date: Thu, 12 Oct 2023 16:56:27 -0400 Subject: [PATCH 1/2] This change adds support for the PPA2 section in zOS --- clang

[clang] [clang][Interp] Fix crash during `InterpStack` printing (PR #68246)

2023-10-12 Thread via cfe-commits
isuckatcs wrote: >it could come in handy in the future For me it was helpful to check what is on the stack at the moment, so it's definitely handy I think. https://github.com/llvm/llvm-project/pull/68246 ___ cfe-commits mailing list cfe-commits@lists

[clang] 403e0e8 - [clang][Interp] Fix crash during `InterpStack` printing (#68246)

2023-10-12 Thread via cfe-commits
Author: isuckatcs Date: 2023-10-12T23:26:44+02:00 New Revision: 403e0e8cd95f21d5f94f1e0663c2cfe48e54bf08 URL: https://github.com/llvm/llvm-project/commit/403e0e8cd95f21d5f94f1e0663c2cfe48e54bf08 DIFF: https://github.com/llvm/llvm-project/commit/403e0e8cd95f21d5f94f1e0663c2cfe48e54bf08.diff LOG

[clang] [clang][Interp] Fix crash during `InterpStack` printing (PR #68246)

2023-10-12 Thread via cfe-commits
https://github.com/isuckatcs closed https://github.com/llvm/llvm-project/pull/68246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-12 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec closed https://github.com/llvm/llvm-project/pull/68740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-12 Thread Brad Smith via cfe-commits
brad0 wrote: > Agreed: AFAICS the only open issue is whether the Solaris test should use the > `GNU` label as I have done, introduce an new common one (like `UNIX`; there's > nothing GNU-specific in that test), or really introduce a separate copy of > the check under a different label per targ

[clang] 8da1e3d - [Driver] Have -rdynamic be a no-op on Haiku (#67872)

2023-10-12 Thread via cfe-commits
Author: Brad Smith Date: 2023-10-12T18:05:49-04:00 New Revision: 8da1e3dd24a1cc6bc99bf3334009d2d19f21018f URL: https://github.com/llvm/llvm-project/commit/8da1e3dd24a1cc6bc99bf3334009d2d19f21018f DIFF: https://github.com/llvm/llvm-project/commit/8da1e3dd24a1cc6bc99bf3334009d2d19f21018f.diff LO

[clang] [Driver] Have -rdynamic be a no-op on Haiku (PR #67872)

2023-10-12 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/67872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 46cb8d9 - [TSAN] add support for riscv64 (#68735)

2023-10-12 Thread via cfe-commits
Author: AdityaK Date: 2023-10-12T16:03:07-07:00 New Revision: 46cb8d9a325233ac11ed5e90367c43774294d87e URL: https://github.com/llvm/llvm-project/commit/46cb8d9a325233ac11ed5e90367c43774294d87e DIFF: https://github.com/llvm/llvm-project/commit/46cb8d9a325233ac11ed5e90367c43774294d87e.diff LOG:

[clang] [TSAN] add support for riscv64 (PR #68735)

2023-10-12 Thread via cfe-commits
https://github.com/hiraditya closed https://github.com/llvm/llvm-project/pull/68735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TSAN] add support for riscv64 (PR #68735)

2023-10-12 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > The review context is on > > [reviews.llvm.org/D145214](https://reviews.llvm.org/D145214) . Moving it > > here just causes more confusion. > > @alexfanqi is the author of the patch and they can drive a reland. > > Can you elaborate what is confusing? The patch was already re

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-10-12 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Add a CI job for the LLDB data formatters (PR #65174)

2023-10-12 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/65174 >From 9ff29c54e97dab71488ffe50ac871f007d357e4f Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 9 Sep 2022 19:12:18 -0400 Subject: [PATCH 1/2] [libc++] Add a CI job for the LLDB data formatters This patch

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-10-12 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/12] [libc++] Implement ranges::contains Differential Revision

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-12 Thread via cfe-commits
@@ -478,6 +480,43 @@ template class SourceLocScope final { bool Enabled = false; }; +template class StoredOpaqueValueScope final { +public: + StoredOpaqueValueScope(ByteCodeExprGen *Ctx) : Ctx(Ctx) {} + + bool VisitAndStoreOpaqueValue(const OpaqueValueExpr *Ove) { +a

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-12 Thread via cfe-commits
@@ -478,6 +480,43 @@ template class SourceLocScope final { bool Enabled = false; }; +template class StoredOpaqueValueScope final { +public: + StoredOpaqueValueScope(ByteCodeExprGen *Ctx) : Ctx(Ctx) {} + + bool VisitAndStoreOpaqueValue(const OpaqueValueExpr *Ove) { +a

<    1   2   3   >