shafik wrote:
Please next time before you commit add a more detailed description of the
change so that readers of git log can get a better understanding of the change
w/o having to view it in detail.
https://github.com/llvm/llvm-project/pull/67066
__
@@ -180,6 +180,20 @@ TEST(PagedVectorTest, FillNonTrivialConstructor) {
EXPECT_EQ(std::distance(V.materialized_begin(), V.materialized_end()), 10LL);
}
+// Test that isMaterialized returns true for all the elements
+// of the page, not only the one that was accessed.
+TEST(P
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/67960
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
Weird, the commit in the MR has a description, but it lost the description when
merging through the github interface.
https://github.com/llvm/llvm-project/pull/67066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
@@ -288,10 +288,12 @@ class ModuleFile {
/// for the entry is SLocEntryOffsetsBase + SLocEntryOffsets[i].
uint64_t SLocEntryOffsetsBase = 0;
- /// Offsets for all of the source location entries in the
- /// AST file.
+ /// Stream bit offsets for all of the source locati
@@ -50,6 +50,7 @@ int y = a2;
// CHECK: In module 'a':
// CHECK-NEXT: a.h:1:45: error:
+int z = b;
// MISSING-B: could not find file '{{.*}}b.h'
// MISSING-B-NOT: please delete the module cache
jansvoboda11 wrote:
I'm not sure. To me, this seems like an imp
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/66966
>From 4edf9d8559339a12108d9c4d1e2f3bb062a5a768 Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Wed, 20 Sep 2023 17:30:45 -0700
Subject: [PATCH 1/7] [clang][modules] Move `SLocEntry` search into `ASTReader`
dpaoliello added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64CallingConvention.td:248-257
+ // The first 4 FP/Vector arguments are passed in XMM registers.
+ CCIfType<[f16],
+ CCAssignToRegWithShadow<[H0, H1, H2, H3],
+
@@ -90,9 +90,33 @@ public:
}
};
+/// VirtualTableValueProfilingPlugin
+class VTableProfilingPlugin {
+ Function &F;
+
+public:
+ static constexpr InstrProfValueKind Kind = IPVK_VTableTarget;
+
+ VTableProfilingPlugin(Funct
Author: Kirill Stoimenov
Date: 2023-10-03T00:09:46Z
New Revision: 149346286801a5f32d254676760a7f4211801667
URL:
https://github.com/llvm/llvm-project/commit/149346286801a5f32d254676760a7f4211801667
DIFF:
https://github.com/llvm/llvm-project/commit/149346286801a5f32d254676760a7f4211801667.diff
L
https://github.com/tripleCC updated
https://github.com/llvm/llvm-project/pull/67563
>From 0783db5bcaed863cd0cd5c5a2e0d8cc3355e7f51 Mon Sep 17 00:00:00 2001
From: tripleCC
Date: Wed, 27 Sep 2023 22:05:19 +0800
Subject: [PATCH] [analyzer] Fix false negative when accessing a nonnull
property from
https://github.com/christycylee created
https://github.com/llvm/llvm-project/pull/68058
It can be hard to predict whether a section exist when using the `INSERT
AFTER/BEFORE ` directive, this makes it difficult to apply a global
linker script that's applicable to the entire build system. We sh
llvmbot wrote:
@llvm/pr-subscribers-lld
Changes
It can be hard to predict whether a section exist when using the `INSERT
AFTER/BEFORE ` directive, this makes it difficult to apply a
global linker script that's applicable to the entire build system. We should
warn instead of hard
mizvekov wrote:
@kstoimenov I believe you are supposed to notify the MR in case of reverts,
otherwise I could have missed this if I wasn't awake.
I believe in this case the bot is misconfigured, it's using
`-Werror,-Wmissing-field-initializers`, the 'error' is just a missing
initializer, whic
https://github.com/aloisklink created
https://github.com/llvm/llvm-project/pull/68059
Ignore the `[[malloc(x)]]` or `[[malloc(x, 1)]]` function attribute syntax
added in [GCC 11][1].
Unlike `[[malloc]]` with no arguments (which is supported by Clang), GCC uses
the one or two argument form to
tripleCC wrote:
> Looks good, thanks! I think a comment about how the types in the AST already
> has the nullability propagated correctly might be helpful for the future
> readers, otherwise it looks good to me!
Thanks for reviewing, I added a comment for nullability propagated now.
https://
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 149346286801a5f32d254676760a7f4211801667
4dc3e74efa5dae42c2ffa408ef5d4a83c4b4754c --
shraiysh wrote:
> I'll see what I can do about adding an OpenMPIRBuilderTest.cpp to the patch.
I think it’s okay if it’s tested by clang tests (as Johannes mentioned). In
case you decide to add tests for this, there is already an
OpenMPIRBuilderTest.cpp in `llvm/unittests/Frontend/OpenMPIRBuil
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/67162
>From b4b44809dcbc487239b4430751a232563c5ac590 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Thu, 21 Sep 2023 13:52:16 -0400
Subject: [PATCH] [HIP] Support compressing device binary
Add option -f[no-]o
@@ -881,6 +900,184 @@ CreateFileHandler(MemoryBuffer &FirstInput,
"'" + FilesType + "': invalid file type specified");
}
+OffloadBundlerConfig::OffloadBundlerConfig() {
+ auto IgnoreEnvVarOpt =
+ llvm::sys::Process::GetEnv("OFFLOAD_BUNDLER_IGNO
@@ -1183,6 +1183,10 @@ def fgpu_inline_threshold_EQ : Joined<["-"],
"fgpu-inline-threshold=">,
def fgpu_sanitize : Flag<["-"], "fgpu-sanitize">, Group,
HelpText<"Enable sanitizer for supported offloading devices">;
def fno_gpu_sanitize : Flag<["-"], "fno-gpu-sanitize">, Grou
https://github.com/smeenai created
https://github.com/llvm/llvm-project/pull/68060
The C23 standard supports enums with fixed underlying types (N3030 [1]),
so we shouldn't emit `-Wfixed-enum-extension` in C23 mode (since it's no
longer a Clang extension at that point).
[1]
https://thephd.dev/_
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
The C23 standard supports enums with fixed underlying types (N3030 [1]),
so we shouldn't emit `-Wfixed-enum-extension` in C23 mode (since it's no
longer a Clang extension at that point).
[1]
https://thephd.dev/_vendor/future_cxx/papers/C%2
ahatanak wrote:
The commit fixed an assertion that was failing in SemaInit.cpp.
Assertion failed: (Kind.getKind() == InitializationKind::IK_Copy ||
Kind.isExplicitCast() || Kind.getKind() == InitializationKind::IK_DirectList),
function Perform, file SemaInit.cpp, line 8607.
The assertion in
Author: Matheus Izvekov
Date: 2023-10-03T03:23:34+02:00
New Revision: e8970141ec4326acb139789db01fb7c51538a4be
URL:
https://github.com/llvm/llvm-project/commit/e8970141ec4326acb139789db01fb7c51538a4be
DIFF:
https://github.com/llvm/llvm-project/commit/e8970141ec4326acb139789db01fb7c51538a4be.dif
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/68015
>From be5fab19a147c979c7e8afb421d157b194f4a125 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 2 Oct 2023 13:52:35 +0200
Subject: [PATCH] [clang][codegen] Add a verifier IR pass before any further
pas
@@ -923,6 +923,8 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
PB.crossRegisterProxies(LAM, FAM, CGAM, MAM);
ModulePassManager MPM;
+ // Add a verifier pass, before any other passes, to catch CodeGen issues.
+ MPM.addPass(VerifierPass());
mizvekov
https://github.com/ahatanak created
https://github.com/llvm/llvm-project/pull/68061
None
>From bc5093e4942b3ac3d538eb1253515e4b7c562a4a Mon Sep 17 00:00:00 2001
From: Akira Hatanaka
Date: Mon, 2 Oct 2023 18:43:26 -0700
Subject: [PATCH] Add a release note for
https://github.com/llvm/llvm-proje
https://github.com/shraiysh updated
https://github.com/llvm/llvm-project/pull/68042
>From c7c9e907d897ae667331761d8097ccb7852c5d93 Mon Sep 17 00:00:00 2001
From: Shraiysh Vaishay
Date: Mon, 2 Oct 2023 16:43:13 -0500
Subject: [PATCH 1/2] [mlir][OpenMP] Added translation for `omp.teams` to LLVM
felix642 updated this revision to Diff 557545.
felix642 marked 3 inline comments as done.
felix642 added a comment.
Updated documentation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
clang-too
felix642 updated this revision to Diff 557546.
felix642 added a comment.
Wrong check name
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
clang-tools-extra/clang-tidy/ClangTidyCheck.h
clang-too
Bigcheese added a comment.
This change looks good with the stdint.h comments resolved.
Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2
typedef int my_awesome_nonstandard_integer_type;
+
+/* C99 7.18.1.1 Exact-width integer types.
iana wrote
https://github.com/mizvekov deleted
https://github.com/llvm/llvm-project/pull/68015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pandaninjas updated
https://github.com/llvm/llvm-project/pull/66315
>From ead65bfcb70be46788bc9e88c891e7ae7f91b8d7 Mon Sep 17 00:00:00 2001
From: PandaNinjas
Date: Wed, 13 Sep 2023 17:38:17 -0700
Subject: [PATCH 01/22] [libc++] Prevent calling the projection more than three
https://github.com/pandaninjas updated
https://github.com/llvm/llvm-project/pull/66315
>From ead65bfcb70be46788bc9e88c891e7ae7f91b8d7 Mon Sep 17 00:00:00 2001
From: PandaNinjas
Date: Wed, 13 Sep 2023 17:38:17 -0700
Subject: [PATCH 01/22] [libc++] Prevent calling the projection more than three
dexonsmith added inline comments.
Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2
typedef int my_awesome_nonstandard_integer_type;
+
+/* C99 7.18.1.1 Exact-width integer types.
Bigcheese wrote:
> iana wrote:
> > dexonsmith wrote:
> > > benlan
@@ -1183,6 +1183,10 @@ def fgpu_inline_threshold_EQ : Joined<["-"],
"fgpu-inline-threshold=">,
def fgpu_sanitize : Flag<["-"], "fgpu-sanitize">, Group,
HelpText<"Enable sanitizer for supported offloading devices">;
def fno_gpu_sanitize : Flag<["-"], "fno-gpu-sanitize">, Grou
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/67162
>From c2d5f809ab0f1be50cee4baaffdf3994807e5ef2 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Thu, 21 Sep 2023 13:52:16 -0400
Subject: [PATCH] [HIP] Support compressing device binary
Add option -f[no-]o
owenpan added inline comments.
Comment at: clang/lib/Format/ContinuationIndenter.cpp:1338-1341
PreviousNonComment->isOneOf(
-TT_AttributeRParen, TT_AttributeSquare,
TT_FunctionAnnotationRParen,
-TT_JavaAnnotation, TT_LeadingJavaAnnotation))) ||
+
Author: Timm Baeder
Date: 2023-10-03T06:05:39+02:00
New Revision: ef9666aa81abdbcff54448446ba1f6fffe5fa45c
URL:
https://github.com/llvm/llvm-project/commit/ef9666aa81abdbcff54448446ba1f6fffe5fa45c
DIFF:
https://github.com/llvm/llvm-project/commit/ef9666aa81abdbcff54448446ba1f6fffe5fa45c.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/67961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/67563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4122,6 +4122,9 @@ def RestrictDocs : Documentation {
The ``malloc`` attribute indicates that the function acts like a system memory
allocation function, returning a pointer to allocated storage disjoint from the
storage for any other object accessible to the caller.
+
+The
https://github.com/topperc created
https://github.com/llvm/llvm-project/pull/68065
The driver doesn't have code to pass these down to cc1. It just prints an
unused option warning. Remove them from the driver.
>From b6be263a9b07425471f17e66b506bb805f29b8a0 Mon Sep 17 00:00:00 2001
From: Craig T
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Changes
The driver doesn't have code to pass these down to cc1. It just prints an
unused option warning. Remove them from the driver.
---
Full diff: https://github.com/llvm/llvm-project/pull/68065.diff
1 Files Affected:
- (modified) cl
Author: Timm Bäder
Date: 2023-10-03T06:31:03+02:00
New Revision: fb0a7c8589e1320de1bf48161a4995a0e5dc8b77
URL:
https://github.com/llvm/llvm-project/commit/fb0a7c8589e1320de1bf48161a4995a0e5dc8b77
DIFF:
https://github.com/llvm/llvm-project/commit/fb0a7c8589e1320de1bf48161a4995a0e5dc8b77.diff
LO
tbaederr wrote:
> Maybe we should change the existing evaluator to be consistent? Otherwise LGTM
I'm not 100% sure what output is better, but we can change that later. This
change is more about correctness.
https://github.com/llvm/llvm-project/pull/67131
___
Author: Timm Baeder
Date: 2023-10-03T06:46:31+02:00
New Revision: f58d54ab969b2f342a882dfb03334f18f4ec1dcc
URL:
https://github.com/llvm/llvm-project/commit/f58d54ab969b2f342a882dfb03334f18f4ec1dcc
DIFF:
https://github.com/llvm/llvm-project/commit/f58d54ab969b2f342a882dfb03334f18f4ec1dcc.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/67131
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Pointer.h:81-88
+ /// Equality operators are just for tests.
+ bool operator==(const Pointer &P) const {
+return Pointee == P.Pointee && Base == P.Base && Offset == P.Offset;
+ }
+
+ bool operator!=(const Poi
iana updated this revision to Diff 557549.
iana added a comment.
Minimize the testing stdint.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159064/new/
https://reviews.llvm.org/D159064
Files:
clang/lib/Basic/Module.cpp
clang/lib/Headers/__std
iana marked 5 inline comments as done.
iana added inline comments.
Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2
typedef int my_awesome_nonstandard_integer_type;
+
+/* C99 7.18.1.1 Exact-width integer types.
dexonsmith wrote:
> Bigcheese wr
owenpan added a comment.
Can you add a github issue to show the behavior before this patch?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145262/new/
https://reviews.llvm.org/D145262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
@@ -18525,12 +18525,17 @@ TEST_F(FormatTest, AlignConsecutiveAssignments) {
" a_longer_name_for_wrap}};",
Alignment);
- Alignment.ColumnLimit = 60;
+ Alignment = getLLVMStyleWithColumns(60);
+ Alignment.AlignConsecutiveAssig
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/68069
Make sure we pass the expected bitwidth around when casting to IntAP/IntAPS and
move the tests to their own file.
This makes it easier to test the `IntegralAP` code for different bit widths
than 128.
>From d7
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
Make sure we pass the expected bitwidth around when casting to IntAP/IntAPS and
move the tests to their own file.
This makes it easier to test the `IntegralAP` code for different bit widths
than 128.
---
Full diff: https://github.com/llv
@@ -1601,6 +1617,46 @@ bool CastFloatingIntegral(InterpState &S, CodePtr OpPC) {
}
}
+static inline bool CastFloatingIntegralAP(InterpState &S, CodePtr OpPC,
+ uint32_t BitWidth) {
+ const Floating &F = S.Stk.pop();
+
+ APSInt Resul
@@ -582,11 +598,21 @@ def CastIntegralFloating : Opcode {
// Cast a floating to an integer type
def CastFloatingIntegral : Opcode {
- let Types = [AluTypeClass];
+ let Types = [FixedSizeIntegralTypes];
tbaederr wrote:
The type classes for these get kinda co
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/67095
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
tbaederr wrote:
Ping
https://g
401 - 461 of 461 matches
Mail list logo
