[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string TargetStr) { std::unique_ptr TheTargetMachine( TheTarget->createTargetMachine(TargetStr, "", "", Options, std::nullopt)); const llvm::Triple &MachineTriple = TheTargetMachine->getTargetTriple(); +

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 1c05651 - [clang] [C23] Fix crash with _BitInt running clang-tidy (#65889)

2023-09-20 Thread via cfe-commits
Author: vabridgers Date: 2023-09-20T05:06:45-05:00 New Revision: 1c05651426297c773334943b9e8875bcc67b5db3 URL: https://github.com/llvm/llvm-project/commit/1c05651426297c773334943b9e8875bcc67b5db3 DIFF: https://github.com/llvm/llvm-project/commit/1c05651426297c773334943b9e8875bcc67b5db3.diff LO

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-20 Thread via cfe-commits
https://github.com/vabridgers closed https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
@@ -22,7 +23,8 @@ struct RISCVExtensionInfo { unsigned MinorVersion; }; -void riscvExtensionsHelp(); +void getAllExtensions(StringMap &Features); cbalint13 wrote: It was men't as example. Anyway, prior certain versions (in our case 18) that accessor is sti

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
@@ -22,7 +23,8 @@ struct RISCVExtensionInfo { unsigned MinorVersion; }; -void riscvExtensionsHelp(); +void getAllExtensions(StringMap &Features); cbalint13 wrote: I remove it (all), and add only partial fillers. https://github.com/llvm/llvm-project/pull/66

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

2023-09-20 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo approved this pull request. LGTM, thanks. (But let's wait with landing it until e.g. tomorrow, in case someone else has comments on it.) https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commi

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
@@ -210,24 +210,42 @@ static void verifyTables() { #endif } -void llvm::riscvExtensionsHelp() { - outs() << "All available -march extensions for RISC-V\n\n"; - outs() << '\t' << left_justify("Name", 20) << "Version\n"; +void llvm::getAllExtensions(StringMap &ExtMap) { + for

[clang] [analyzer] Fix StackAddrEscapeChecker crash on temporary object fields (PR #66493)

2023-09-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal resolved https://github.com/llvm/llvm-project/pull/66493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Brandon Wu via cfe-commits
@@ -599,15 +599,21 @@ def HasStdExtZvkned : Predicate<"Subtarget->hasStdExtZvkned()">, def FeatureStdExtZvknha : SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true", "'Zvknha' (Vector SHA-2 (SHA-256 only))">; - -def FeatureStdExtZvknhb

[clang] [RISCV] Add missing V extensions for zvk-invalid-features.c (PR #66875)

2023-09-20 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/66875 >From f2321c370a71272b179ee596918205a226008bec Mon Sep 17 00:00:00 2001 From: 4vtomat Date: Wed, 20 Sep 2023 01:44:33 -0700 Subject: [PATCH] [RISCV] Add missing V extensions for zvk-invalid-features.c If we don'

[clang] 97ae760 - [RISCV] Add missing V extensions for zvk-invalid-features.c (#66875)

2023-09-20 Thread via cfe-commits
Author: Brandon Wu Date: 2023-09-20T18:23:32+08:00 New Revision: 97ae760825972d788cdaa467a83b3219c343f7f3 URL: https://github.com/llvm/llvm-project/commit/97ae760825972d788cdaa467a83b3219c343f7f3 DIFF: https://github.com/llvm/llvm-project/commit/97ae760825972d788cdaa467a83b3219c343f7f3.diff LO

[clang] [RISCV] Add missing V extensions for zvk-invalid-features.c (PR #66875)

2023-09-20 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/66875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread David Spickett via cfe-commits
@@ -210,24 +210,42 @@ static void verifyTables() { #endif } -void llvm::riscvExtensionsHelp() { - outs() << "All available -march extensions for RISC-V\n\n"; - outs() << '\t' << left_justify("Name", 20) << "Version\n"; +void llvm::getAllExtensions(StringMap &ExtMap) { + for

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Reassociate loop invariant GEP index calculations.

2023-09-20 Thread Paul Walker via Phabricator via cfe-commits
paulwalker-arm added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:2332 } - + if (GEP.getNumIndices() == 1 && !GEP.getType()->isVectorTy()) { +auto *Idx = dyn_cast(GEP.getOperand(1)); Perhaps move this block after t

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
@@ -11,9 +11,10 @@ // //===--===// -#include "llvm/TargetParser/ARMTargetParser.h" #include "llvm/ADT/StringSwitch.h" +#include "llvm/Support/Format.h" #include "llvm/Support/raw_ostream.h" +#include "llvm/

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 deleted https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 unresolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From 3ab99383074e775da3b25a3be68780ed437e91d0 Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 13:36:13 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix handling of cyclical data structures in HTMLLogger. (PR #66887)

2023-09-20 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/66887 * Include more information. We can include the "kind" field for values and "type" for storage locations without risking infinite recursion. Previously, we would display these as "undefined" (simply bec

[clang] [clang][dataflow] Fix handling of cyclical data structures in HTMLLogger. (PR #66887)

2023-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes * Include more information. We can include the "kind" field for values and "type" for storage locations without risking infinite recursion. Previously, we would display these as "undefined" (simply because this is the JavaScript va

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-20 Thread Jon Phillips via cfe-commits
jp4a50 wrote: > I'm not sure I understand, looking at > https://clang.llvm.org/docs/ClangFormatStyleOptions.html#lambdabodyindentation > it seems to explicitly state it should be at the outer function scope, can > you point to a github issue this is trying to solve or is this just personal >

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

2023-09-20 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. In D86310#4648646 , @hvdijk wrote: > In D86310#4648634 , @nikic wrote: > >> I'm happy to sign off on the x86-64 part here, but I'm less sure about >> x86-32. If I understood correctly, the i1

[clang] [clang][dataflow] Fix handling of cyclical data structures in HTMLLogger. (PR #66887)

2023-09-20 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/66887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix StackAddrEscapeChecker crash on temporary object fields (PR #66493)

2023-09-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/66493 >From 895826d0c2d65f5282096562bc5e015d511afbbf Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 20 Sep 2023 12:50:36 +0200 Subject: [PATCH] [analyzer] Fix StackAddrEscapeChecker crash on temporary object

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #66782)

2023-09-20 Thread via cfe-commits
https://github.com/DonatNagyE approved this pull request. This commit was reverted once (see discussion on earlier pull request #65887), because the buildbot linaro-clang-armv8-quick couldn't handle the large `_BitInt()`s in the testcase. Pinning to the x86_64 triple solves this problem, so i

[clang] [analyzer] Fix StackAddrEscapeChecker crash on temporary object fields (PR #66493)

2023-09-20 Thread Balazs Benics via cfe-commits
steakhal wrote: Fixed tests for Windows, to use `size_t` for operator new. I'll land this if premerge-tests pass. https://github.com/llvm/llvm-project/pull/66493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) { TEST(TargetParserTest, ARMPrintSupportedExtensions) { std::string expected = "All available -march extensions for ARM\n\n" - "\tcrc\n\tcrypto\n\tsha2"; + "N

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-20 Thread Jon Phillips via cfe-commits
@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) { " }\n" "}", Style); - verifyFormat("std::sort(v.begin(), v.end(),\n" - " [](const auto &foo, const auto &bar) {\n" - " return foo.

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-20 Thread Jon Phillips via cfe-commits
@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) { " }\n" "}", Style); - verifyFormat("std::sort(v.begin(), v.end(),\n" - " [](const auto &foo, const auto &bar) {\n" - " return foo.

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Reassociate loop invariant GEP index calculations.

2023-09-20 Thread Nikita Popov via Phabricator via cfe-commits
nikic added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:2336 +// Try to reassociate loop invariant index calculations to enable LICM. +if (Idx && (Idx->getOpcode() == Instruction::Add)) { + Value *Ptr = GEP.getOperand(0); ---

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

2023-09-20 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. LGTM. Sorry for the delay https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] da26500 - [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (#66782)

2023-09-20 Thread via cfe-commits
Author: vabridgers Date: 2023-09-20T06:11:39-05:00 New Revision: da26500aa82316f607ddc60e56982775d7f45cff URL: https://github.com/llvm/llvm-project/commit/da26500aa82316f607ddc60e56982775d7f45cff DIFF: https://github.com/llvm/llvm-project/commit/da26500aa82316f607ddc60e56982775d7f45cff.diff LO

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #66782)

2023-09-20 Thread via cfe-commits
https://github.com/vabridgers edited https://github.com/llvm/llvm-project/pull/66782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #66782)

2023-09-20 Thread via cfe-commits
https://github.com/vabridgers closed https://github.com/llvm/llvm-project/pull/66782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

2023-09-20 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66893 Fixes #66857. >From a03878c28110c26c6119f3c5038640b01df3cfe0 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 20 Sep 2023 03:54:09 -0700 Subject: [PATCH] [clang-format] Correctly annotate return type of functio

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

2023-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Changes Fixes #66857. --- Full diff: https://github.com/llvm/llvm-project/pull/66893.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+6-2) - (modified) clang/unittests/Format/TokenAnnotatorTest.cpp (+7) ``

[clang] 69183f8 - [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (#65938)

2023-09-20 Thread via cfe-commits
Author: Juan Manuel Martinez Caamaño Date: 2023-09-20T13:37:13+02:00 New Revision: 69183f8eb97d3055b2a2617be85e8cb39d877acc URL: https://github.com/llvm/llvm-project/commit/69183f8eb97d3055b2a2617be85e8cb39d877acc DIFF: https://github.com/llvm/llvm-project/commit/69183f8eb97d3055b2a2617be85e8cb

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

2023-09-20 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-20 Thread via cfe-commits
https://github.com/DaMatrix created https://github.com/llvm/llvm-project/pull/66894 This makes __builtin_bit_cast support converting to and from vector types in a constexpr context. >From d4c7b67eff9997479712f1a25ebb162756d431c6 Mon Sep 17 00:00:00 2001 From: DaPorkchop_ Date: Sun, 13 Aug 202

[clang] 73dcbd4 - [analyzer] Fix StackAddrEscapeChecker crash on temporary object fields (#66493)

2023-09-20 Thread via cfe-commits
Author: Balazs Benics Date: 2023-09-20T13:54:21+02:00 New Revision: 73dcbd411b4573a4283d30307e48fde0f84423e5 URL: https://github.com/llvm/llvm-project/commit/73dcbd411b4573a4283d30307e48fde0f84423e5 DIFF: https://github.com/llvm/llvm-project/commit/73dcbd411b4573a4283d30307e48fde0f84423e5.diff

[clang] [analyzer] Fix StackAddrEscapeChecker crash on temporary object fields (PR #66493)

2023-09-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/66493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-20 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/66310 >From 21157a0e3b4c4e4e2430752ef806148685a942a2 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Thu, 14 Sep 2023 09:17:39 +0800 Subject: [PATCH 1/4] [X86] Align 128/256 variants to use void * as 512 variants.

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-20 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf edited https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-20 Thread Freddy Ye via cfe-commits
FreddyLeaf wrote: > LGTM - please update the description to mention that you're updating the > movnti i32/i64 scalar integer nt ops as well as the vector ops I think this description has covered? May display wrong in the preview, highlighted here: `For *_stream_* series intrinsics` https://gi

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Some improvements for path handling on NetBSD (PR #66863)

2023-09-20 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan approved this pull request. This is similar to a change that I did for the Linux toolchain a while ago (https://github.com/llvm/llvm-project/commit/e917801eddbe1b32f1adc81391fd434557391b5e), LGTM! 👍 https://github.com/llvm/llvm-project/pull/66863 __

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread David Spickett via cfe-commits
@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) { TEST(TargetParserTest, ARMPrintSupportedExtensions) { std::string expected = "All available -march extensions for ARM\n\n" - "\tcrc\n\tcrypto\n\tsha2"; + "N

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread via cfe-commits
cor3ntin wrote: @tbaederr I think you need to use the preprocessor that exists ( which you get in `DiagnosticConsumer::BeginSourceFile`, I hope you can plug to `TextDiagnosticPrinter::BeginSourceFile` in particular), but you are right that you can't reuse the Lexer because of comments (and mac

[clang] 765b38f - [clang][Interp][NFC] Small code refactoring

2023-09-20 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-20T14:33:46+02:00 New Revision: 765b38fbf16bef0a0646a4bfc9a933cb8d11f5ba URL: https://github.com/llvm/llvm-project/commit/765b38fbf16bef0a0646a4bfc9a933cb8d11f5ba DIFF: https://github.com/llvm/llvm-project/commit/765b38fbf16bef0a0646a4bfc9a933cb8d11f5ba.diff LO

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-20 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: I meant the patch title - I'm never quite sure how the title/description appears when these are squashed+merged https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-20 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon approved this pull request. LGTM - cheers https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/OpenCL: set sqrt fp accuracy on call to Z4sqrt (PR #66651)

2023-09-20 Thread Romaric Jodin via cfe-commits
https://github.com/rjodinchr resolved https://github.com/llvm/llvm-project/pull/66651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align other variants to use void * as 512 variants. (PR #66310)

2023-09-20 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf edited https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Identify post-visit state changes in the HTML logger. (PR #66746)

2023-09-20 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall approved this pull request. Thanks, this looks nice! https://github.com/llvm/llvm-project/pull/66746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] libclc: generic: add half implementation for erf/erfc (PR #66901)

2023-09-20 Thread Romaric Jodin via cfe-commits
https://github.com/rjodinchr created https://github.com/llvm/llvm-project/pull/66901 libclc does not have a half implementation for erf/erfc Add one based on the float implementation by extending the input and truncating the output. >From 64826c23cfaef764c9a60600a2c0e96244c95cf6 Mon Sep 17 00:

[libclc] libclc: generic: add half implementation for erf/erfc (PR #66901)

2023-09-20 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: @kpet @alan-baker could you review this PR please? https://github.com/llvm/llvm-project/pull/66901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 632d13c - [X86] Align other variants to use void * as 512 variants. (#66310)

2023-09-20 Thread via cfe-commits
Author: Freddy Ye Date: 2023-09-20T20:59:25+08:00 New Revision: 632d13ce84a806717ef367e3dd44640bde7b7d7e URL: https://github.com/llvm/llvm-project/commit/632d13ce84a806717ef367e3dd44640bde7b7d7e DIFF: https://github.com/llvm/llvm-project/commit/632d13ce84a806717ef367e3dd44640bde7b7d7e.diff LOG

[clang] [X86] Align other variants to use void * as 512 variants. (PR #66310)

2023-09-20 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf closed https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] libclc: clspv: create gen_convert.cl for clspv (PR #66902)

2023-09-20 Thread Romaric Jodin via cfe-commits
https://github.com/rjodinchr created https://github.com/llvm/llvm-project/pull/66902 Create clspv own convert.cl This is needed as Vulkan SPIR-V does not respect the assumptions needed to have the generic convert.cl compliant on many platforms. It is needed because of the conversion of TYPE_MA

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-20 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66904 Fixes #66890. >From 95780df0571c27453b77e893e5020d9b451b0e6d Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 20 Sep 2023 05:56:27 -0700 Subject: [PATCH] [clang-format] Correctly annotate keyword operator funct

[libclc] libclc: clspv: create gen_convert.cl for clspv (PR #66902)

2023-09-20 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: @kpet @alan-baker could you review this PR please? https://github.com/llvm/llvm-project/pull/66902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Changes Fixes #66890. --- Full diff: https://github.com/llvm/llvm-project/pull/66904.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+5) - (modified) clang/unittests/Format/TokenAnnotatorTest.cpp (+10) ```

[clang] [clang][dataflow] Identify post-visit state changes in the HTML logger. (PR #66746)

2023-09-20 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/66746 >From 5561e080b14e59ad2ea9edd79de1b2fa1f4527be Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 19 Sep 2023 12:54:44 + Subject: [PATCH] [clang][dataflow] Identify post-visit state changes in the

[clang] ed65ced - [clang][dataflow] Identify post-visit state changes in the HTML logger. (#66746)

2023-09-20 Thread via cfe-commits
Author: martinboehme Date: 2023-09-20T15:18:57+02:00 New Revision: ed65ced22af8a31ab374179d3d56b1e7c1456069 URL: https://github.com/llvm/llvm-project/commit/ed65ced22af8a31ab374179d3d56b1e7c1456069 DIFF: https://github.com/llvm/llvm-project/commit/ed65ced22af8a31ab374179d3d56b1e7c1456069.diff

[clang] [clang][dataflow] Identify post-visit state changes in the HTML logger. (PR #66746)

2023-09-20 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/66746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Timm Baeder via cfe-commits
tbaederr wrote: ![Screenshot from 2023-09-20 15-26-50](https://github.com/llvm/llvm-project/assets/49720664/763b0f28-3b05-4843-b71b-0465fba110ca) Slightly sad that `true`/`false`/`nullptr` are also marked as keywords now, I was hoping they would be literals. https://github.com/llvm/llvm-proje

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 6d973cbb6cb29f0983ea6a023baf83d205757b3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 20 Sep 2023 10:3

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: The `CodeSnippetHighlighter` class also seems useless now. https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@li

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 4323e6952a577a81a5fdc51ce9571f28d7ccb6f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject: [PATC

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: ![Screenshot from 2023-09-20 15-36-55](https://github.com/llvm/llvm-project/assets/49720664/fae01c5d-5d36-4be0-905e-54d860017ce0) We might also have to tweak the colors. I'm just not sure if the predefined ones from `llvm::raw_

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: cor3ntin wrote: Neat. I'm perfectly happy special casing `kw_` if that's prettier, at least it's a bounded list. As for the color of the shed, ideally light/pastel colors so that they don't overtake the one in the diagnostic messages https:/

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: cor3ntin wrote: @erichkeane @cjdb @shafik https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 4323e6952a577a81a5fdc51ce9571f28d7ccb6f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject: [PATC

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: > As for the color of the shed, ideally light/pastel colors so that they don't > overtake the one in the diagnostic messages It's also about readability - notice how two of the three terminals render the comments in literal bla

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-20 Thread Tarun Prabhu via cfe-commits
@@ -50,3 +50,19 @@ ! MSVC-SAME: FortranDecimal.lib ! MSVC-SAME: /subsystem:console ! MSVC-SAME: "[[object_file]]" + +! Verify that certain linker flags are known to the frontend and are passed on +! to the linker. + +! RUN: %flang -### -rpath /path/to/dir %s 2>&1 \

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 4323e6952a577a81a5fdc51ce9571f28d7ccb6f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject: [PATC

[clang-tools-extra] [clang-tidy] Fix support for typedefs in readability-identifier-naming (PR #66835)

2023-09-20 Thread Carlos Galvez via cfe-commits
@@ -729,3 +729,21 @@ struct forward_declared_as_struct; class forward_declared_as_struct { }; +namespace pr55156 { + +typedef enum { + VALUE0, + VALUE1, +} ValueType; +// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: invalid case style for typedef 'ValueType' [readability-identi

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

2023-09-20 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699 >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in t

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

2023-09-20 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699 >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in t

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-20 Thread Daniel Grumberg via cfe-commits
@@ -374,11 +374,10 @@ TEST(SourceCodeTest, getAssociatedRangeWithComments) { // Does not include comments when only the decl or the comment come from a // macro. daniel-grumberg wrote: Good spot, can't believe I removed the FIXME and not the comment expla

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-20 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg edited https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 700f683 - Revert "[clang] Don't inherit dllimport/dllexport to exclude_from_explicit_instantiation members during explicit instantiation (#65961)"

2023-09-20 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2023-09-20T16:31:12+02:00 New Revision: 700f683f9ddd64528d848cd3efef3ca7003cbd7e URL: https://github.com/llvm/llvm-project/commit/700f683f9ddd64528d848cd3efef3ca7003cbd7e DIFF: https://github.com/llvm/llvm-project/commit/700f683f9ddd64528d848cd3efef3ca7003cbd7e.diff

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-20 Thread Alex Brachet via cfe-commits
https://github.com/abrachet approved this pull request. Awesome! I couldn't figure this out when I looked :) https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Erich Keane via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: @@ -0,0 +1,75 @@ + erichkeane wrote: Needs our comment /license thing at the top i think. https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Erich Keane via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: erichkeane wrote: This is a really great idea! I like the direction this is going! I think we need to find some way to get the source colors/have them be configurable. Is there some sort of 'source' of terminal coloring that we could use? O

[clang] Introduce paged vector (PR #66430)

2023-09-20 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,303 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-20 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 5d2553755add3e7d2adb0b2119d6a0c355df1551 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/16] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

2023-09-20 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix support for typedefs in readability-identifier-naming (PR #66835)

2023-09-20 Thread Piotr Zegar via cfe-commits
@@ -729,3 +729,21 @@ struct forward_declared_as_struct; class forward_declared_as_struct { }; +namespace pr55156 { + +typedef enum { + VALUE0, + VALUE1, +} ValueType; +// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: invalid case style for typedef 'ValueType' [readability-identi

<    1   2   3   4   5   >