[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

2023-09-12 Thread via cfe-commits
martinboehme wrote: I'm not convinced of the value of this change. Wouldn't it be simpler to keep the template arguments of `diagnoseFunction()` unchanged and instead change the return type to be `llvm::Expected>`? In other words, always return an `llvm::SmallVector` instead of a `std::vector`

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

2023-09-12 Thread via cfe-commits
https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

2023-09-12 Thread via cfe-commits
https://github.com/martinboehme requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

2023-09-12 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

2023-09-12 Thread via cfe-commits
@@ -245,10 +245,10 @@ runDataflowAnalysis( /// iterations. /// - This limit is still low enough to keep runtimes acceptable (on typical /// machines) in cases where we hit the limit. -template -llvm::Expected> diagnoseFunction( +template +llvm::Expected diagnoseFunction(

[clang] 7cf20f1 - [clang][dataflow] Eliminate `RecordValue::getChild()`. (#65586)

2023-09-12 Thread via cfe-commits
Author: martinboehme Date: 2023-09-12T09:17:38+02:00 New Revision: 7cf20f156f6c6133456fb7bcf2f7b88e87fa5ff5 URL: https://github.com/llvm/llvm-project/commit/7cf20f156f6c6133456fb7bcf2f7b88e87fa5ff5 DIFF: https://github.com/llvm/llvm-project/commit/7cf20f156f6c6133456fb7bcf2f7b88e87fa5ff5.diff

[clang] [clang][dataflow] Eliminate `RecordValue::getChild()`. (PR #65586)

2023-09-12 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/65586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

2023-09-12 Thread via cfe-commits
martinboehme wrote: > Here's the screenshot for a simple code snippet ! [snip] > You can see some more screenshots here: > https://docs.google.com/document/d/1gJqU5g7HCUifDUJBb5NzSBC0K-9W4nyZ3zxtpbTUDdk/view Thanks for this -- looks great! Just wanted to make sure the output makes sense in con

[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

2023-09-12 Thread via cfe-commits
https://github.com/martinboehme approved this pull request. https://github.com/llvm/llvm-project/pull/65645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159498: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

2023-09-12 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 556531. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159498/new/ https://reviews.llvm.org/D159498 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools

[clang] [AMDGPU] Remove Code Object V2 (PR #65715)

2023-09-12 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

2023-09-12 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo marked 2 inline comments as done. VitaNuo added a comment. I'm sorry I think the upload failed because I tried to upload without a message or something, and I didn't notice that it failed :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[clang] [AMDGPU] Remove Code Object V2 (PR #65715)

2023-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld-elf Changes Code Object V2 has been deprecated for more than a year now. We can safely remove it from LLVM. - [clang] Remove support for the `-mcode-object-version=2` option. - [lld] Remove/refactor tests that were still using COV2 - [llvm] Update AMDG

[PATCH] D135341: adds `__reference_constructs_from_temporary`

2023-09-12 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:33 #include "clang/Basic/TypeTraits.h" +#include "clang/Basic/TokenKinds.h" #include "clang/Lex/Preprocessor.h" Superfluous change Comment at: clang/lib/Sema/SemaExprC

[clang] [include-mapping] Python fixes (PR #65401)

2023-09-12 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. thanks. https://github.com/llvm/llvm-project/pull/65401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

2023-09-12 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 556532. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153769/new/ https://reviews.llvm.org/D153769 Files: clang-too

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

2023-09-12 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo added a comment. I think I also managed to update the wrong patch. Not sure how an alternative patch got created in the first place :( Sorry for the mess, should be fine now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153769/new/ https:

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
@@ -214,6 +214,14 @@ class StmtComparer { return E1->size() == E2->size(); } + bool IsStmtEquivalent(const DeclRefExpr *DRE1, const DeclRefExpr *DRE2) { +if (nullptr == DRE1->getDecl() || nullptr == DRE2->getDecl()) { + return false; +} +return IsStruct

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
https://github.com/cor3ntin requested changes to this pull request. Thanks for working on that! Can you explain why you are comparing declaration only with their name? that seems suspicious to me. Otherwise, I think the intent of the change is correct https://github.com/llvm/llvm-project/pull/6

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
@@ -214,6 +214,14 @@ class StmtComparer { return E1->size() == E2->size(); } + bool IsStmtEquivalent(const DeclRefExpr *DRE1, const DeclRefExpr *DRE2) { +if (nullptr == DRE1->getDecl() || nullptr == DRE2->getDecl()) { cor3ntin wrote: ```suggestion

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

2023-09-12 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo marked an inline comment as done. VitaNuo added a comment. Respond to comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/OrganizeImports.cpp:56 +return false; + Range PreambleRange; + PreambleRange.start = kadircet wrote: > VitaNuo wro

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-12 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. You obviously have a better grasp of that part of the code than I do, but the patch looks sensible to me. Thanks! https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-12 Thread via cfe-commits
@@ -218,6 +218,9 @@ Bug Fixes in This Version (`#65156 `_`) - Clang no longer considers the loss of ``__unaligned`` qualifier from objects as an invalid conversion during method function overload resolution. +- Clang now p

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-12 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-12 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME]Update intrinsic interface for ldr/str (PR #65593)

2023-09-12 Thread via cfe-commits
https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/65593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME]Update intrinsic interface for ldr/str (PR #65593)

2023-09-12 Thread via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. https://github.com/llvm/llvm-project/pull/65593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME]Update intrinsic interface for ldr/str (PR #65593)

2023-09-12 Thread via cfe-commits
@@ -216,9 +216,9 @@ void test_range_0_15(svbool_t pg, void *ptr) { SVE_ACLE_FUNC(svst1_ver_vnum_za8,,,)(0, -1, 16, pg, ptr, 1); // expected-error@+1 {{argument value 16 is outside the valid range [0, 15]}} - SVE_ACLE_FUNC(svldr_vnum_za,,,)(-1, 16, ptr); + SVE_ACLE_FUNC(s

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld-elf Changes Also update LIT tests and docs. For more details, see https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata Differential Revision: https://reviews.llvm.org/D129818 -- Patch is 1.92 MiB, truncated to 20.00 KiB below, full version:

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Also update LIT tests and docs. For more details, see https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata Differential Revision: https://reviews.llvm.org/D129818 -- Patch is 1.92 MiB, truncated to 20.00 KiB below, full version: ht

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-12 Thread via cfe-commits
llvmbot wrote: >@llvm/pr-subscribers-lld-elf > > >Changes > >Also update LIT tests and docs. >For more details, see >https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata > >Differential Revision: https://reviews.llvm.org/D129818 >-- > >Patch is 1.92 MiB, truncated to 20.00 KiB below, f

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-12 Thread via cfe-commits
llvmbot wrote: >@llvm/pr-subscribers-clang > > >Changes > >Also update LIT tests and docs. >For more details, see >https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata > >Differential Revision: https://reviews.llvm.org/D129818 >-- > >Patch is 1.92 MiB, truncated to 20.00 KiB below, ful

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-12 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam closed https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D129818: AMDGPU: Make default AMDHSA Code Object Version to be 5

2023-09-12 Thread Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a8d17e79b02: [AMDGPU] Make default AMDHSA Code Object Version to

[clang] [LLD][AARCH64] lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

2023-09-12 Thread via cfe-commits
@@ -770,6 +770,9 @@ void AArch64::relocateAlloc(InputSectionBase &sec, uint8_t *buf) const { uint64_t secAddr = sec.getOutputSection()->addr; if (auto *s = dyn_cast(&sec)) secAddr += s->outSecOff; + else if (auto *eh = dyn_cast(&sec)) simpal01 wrote:

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041: >From 18039e20fd8bbc97373eaec3f788eeb4e4b53194 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivale

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
cor3ntin wrote: You should edit `clang/docs/ReleaseNotes.rst`, indicating that https://github.com/llvm/llvm-project/issues/66047 was fixed, and edit the description of the PR with `Fixes #66047` so that it gets closed automatically. Otherwise LGTM https://github.com/llvm/llvm-project/pull/66

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 commented: I wonder whether we should also add some test in clang/analysis module? Crash happens in `StmtProfiler` but only add test case in clang-tidy level. https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commit

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/66055: None >From ed5150a69925dc3b6557796026a2820ac5c2e2f5 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 12 Sep 2023 14:41:57 +0800 Subject: [PATCH] add --- .../bugprone/BugproneTidyModule.cpp

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
@@ -214,6 +214,14 @@ class StmtComparer { return E1->size() == E2->size(); } + bool IsStmtEquivalent(const DeclRefExpr *DRE1, const DeclRefExpr *DRE2) { +if (nullptr == DRE1->getDecl() || nullptr == DRE2->getDecl()) { + return false; +} +return IsStruct

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes None -- Full diff: https://github.com/llvm/llvm-project/pull/66055.diff 8 Files Affected: - (modified) clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp (+3) - (modified) clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt (

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/66055: >From ed5150a69925dc3b6557796026a2820ac5c2e2f5 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 12 Sep 2023 14:41:57 +0800 Subject: [PATCH 1/2] add --- .../bugprone/BugproneTidyModule.cpp |

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread via cfe-commits
llvmbot wrote: >@llvm/pr-subscribers-clang-tidy > > >Changes > >None >-- >Full diff: https://github.com/llvm/llvm-project/pull/66055.diff > >8 Files Affected: > >- (modified) clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp (+3) >- (modified) clang-tools-extra/clang-tidy/bugprone/CM

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

2023-09-12 Thread Tobias Hieta via cfe-commits
tru wrote: Instead of updating the module manually on the bot, I still think it's a good idea to add a requirements.txt that should be installed before running the build, ideally in a virtualenv. WDYT @andreil99 https://github.com/llvm/llvm-project/pull/65664 _

[clang] [Driver] Also respect SysRoot for the system library paths on DragonFly (PR #66056)

2023-09-12 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/66056: None >From df6d22fb217837a0b0d00b8905b077347fca6143 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Tue, 12 Sep 2023 04:43:49 -0400 Subject: [PATCH] [Driver] Also respect SysRoot for the system library paths on

[clang] [Driver] Also respect SysRoot for the system library paths on DragonFly (PR #66056)

2023-09-12 Thread Brad Smith via cfe-commits
https://github.com/brad0 review_requested https://github.com/llvm/llvm-project/pull/66056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also respect SysRoot for the system library paths on DragonFly (PR #66056)

2023-09-12 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also respect SysRoot for the system library paths on DragonFly (PR #66056)

2023-09-12 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also respect SysRoot for the system library paths on DragonFly (PR #66056)

2023-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes None -- Full diff: https://github.com/llvm/llvm-project/pull/66056.diff 9 Files Affected: - (modified) clang/lib/Driver/ToolChains/DragonFly.cpp (+5-3) - (added) clang/test/Driver/Inputs/basic_dragonfly_tree/usr/lib/crt1.o () - (adde

[clang] [Driver] Also respect SysRoot for the system library paths on DragonFly (PR #66056)

2023-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes None -- Full diff: https://github.com/llvm/llvm-project/pull/66056.diff 9 Files Affected: - (modified) clang/lib/Driver/ToolChains/DragonFly.cpp (+5-3) - (added) clang/test/Driver/Inputs/basic_dragonfly_tree/usr/lib/crt1.o () - (added) clan

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

2023-09-12 Thread Ashley Roll via Phabricator via cfe-commits
AshleyRoll added a comment. I've not been able to get the time for a while, I hope to be able to spend some more time on it, but I'd probably do that through a GitHub PR now. If someone else wants to take it on, I'd be fine with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

2023-09-12 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 556535. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h clang/lib/Analysis/ThreadSafety.cpp c

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,89 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,89 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,89 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,89 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,89 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,29 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.h - clang-tidy *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,29 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.h - clang-tidy *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041: >From 0ddd5dbb2e2a9097e762334a0d903e4043721cc2 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivale

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL commented: Not bad, just basic nits. https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
https://github.com/mzyKi review_requested https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158156: [analyzer] Add C++ array delete checker

2023-09-12 Thread Donát Nagy via Phabricator via cfe-commits
donat.nagy added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CXXDeleteChecker.cpp:47 +protected: + class PtrCastVisitor : public BugReporterVisitor { public: I like that yo switched to a more descriptive class name :) Com

[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

2023-09-12 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/65645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e791535 - [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (#65645)

2023-09-12 Thread via cfe-commits
Author: Kinuko Yasuda Date: 2023-09-12T11:25:40+02:00 New Revision: e791535b1333898abef0d30cbccce8c788006414 URL: https://github.com/llvm/llvm-project/commit/e791535b1333898abef0d30cbccce8c788006414 DIFF: https://github.com/llvm/llvm-project/commit/e791535b1333898abef0d30cbccce8c788006414.diff

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-12 Thread Congcong Cai via cfe-commits
@@ -0,0 +1,89 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-12 Thread via cfe-commits
https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread David Spickett via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

2023-09-12 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156743/new/ https://reviews.llvm.org/D156743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156989: FloatingPointMode: Use -1 for "Dynamic"

2023-09-12 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. ping. This enum should just match FLT_ROUNDS and designing ABI around whatever this was doing doesn't really make sense CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156989/new/ https://reviews.llvm.org/D156989 ___ cf

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

2023-09-12 Thread Sergio Afonso via Phabricator via cfe-commits
skatrak updated this revision to Diff 556542. skatrak marked 3 inline comments as done. skatrak added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/inc

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

2023-09-12 Thread Sergio Afonso via Phabricator via cfe-commits
skatrak added a comment. Thank you Kiran for having a look at this! In D147218#4643257 , @kiranchandramohan wrote: > Could you add to the summary that the `atomic` related handling is done > elsewhere. Done. > Could you expand the tests to cover the

[PATCH] D158156: [analyzer] Add C++ array delete checker

2023-09-12 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added inline comments. Comment at: clang/test/Analysis/ArrayDelete.cpp:85-88 +Derived *d3 = new DoubleDerived[10]; +Base *b3 = d3; // expected-note{{Conversion from derived to base happened here}} +delete[] b3; // expected-warning{{Deleting an array of polym

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

2023-09-12 Thread Sergio Afonso via Phabricator via cfe-commits
skatrak updated this revision to Diff 556543. skatrak added a comment. Remove leftover comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib/Lowe

[PATCH] D151730: [RISCV] Support target attribute for function

2023-09-12 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 556544. BeMg added a comment. Update to lastest spec 1. When it exist the duplicate target attribute, select the lastest one. 2. arch's features will override cpu's features. TargetFeature will override commandline feature. 3. enhence the testcase Repository:

[PATCH] D158156: [analyzer] Add C++ array delete checker

2023-09-12 Thread Donát Nagy via Phabricator via cfe-commits
donat.nagy added inline comments. Comment at: clang/test/Analysis/ArrayDelete.cpp:85-88 +Derived *d3 = new DoubleDerived[10]; +Base *b3 = d3; // expected-note{{Conversion from derived to base happened here}} +delete[] b3; // expected-warning{{Deleting an array of pol

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr resolved https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr resolved https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr resolved https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   >