[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

cor3ntin wrote: Agreed. I have found that the full set of needed pip modules is `sphinx myst-parser sphinx-markdown-tables sphinx-automodapi furo` - I think most of theses are only used by LLDB but might as well document them as requirements for everything. https://github.com/llvm/llvm-project

[clang] [Parse] Split incremental-extensions (PR #65683)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

@@ -4,6 +4,7 @@ ! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,GNU ! RUN: %flang -### -target aarch64-apple-darwin %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,DARWIN +! RUN: %flang -### -target s

[clang] [NFC] fix failed ompt tests on M1 device (PR #65696)

https://github.com/lixi-zhou updated https://github.com/llvm/llvm-project/pull/65696: >From eacec22651766c6c6961d14964ddb6a180fbfec0 Mon Sep 17 00:00:00 2001 From: Lixi Zhou Date: Thu, 7 Sep 2023 16:15:25 -0700 Subject: [PATCH 1/2] fix failed ompt test on M1 device --- openmp/runtime/test/omp

[clang] [sema] Improve -Wsign-compare (PR #65684)

cor3ntin wrote: Thanks for working on this. I wonder if it's maybe too clever? Comparing to 0 is only one of the possible fix, I usually try to make sure my types are consistent instead - which is not something a fixit could do. The more annoying thing is that this does not interact well with

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

@@ -4,6 +4,7 @@ ! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,GNU ! RUN: %flang -### -target aarch64-apple-darwin %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,DARWIN +! RUN: %flang -### -target s

[clang] [clang-format][NFC] Skip additional tests of the same case upon failure (PR #65540)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/65540: >From dbcdf774da71129572e4844a0998b4e810f7aae4 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 6 Sep 2023 14:53:39 -0700 Subject: [PATCH] [clang-format][NFC] Skip remaining tests of the same case upon failure

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

cor3ntin wrote: Generally looks good, thanks for working on this I'd like to see more tests in `clang/test/Sema/alignas.c` - we don't have a test for `struct _Alignas(int) T` either apparently. Given this fixes a bug, it could benefit from a release note in `clang/docs/ReleaseNotes.rst` http

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

manosanag added a comment. Hello Dave, thanks for replying. Yes, this is an optimization. On some AArch64 cores, including Ampere's ampere1 architecture that this is targeted for, load/store pair instructions are faster compared to simple loads/stores only when the alignment of the pair is at

[clang] [clang-format][NFC] Skip remaining tests of the same case upon failure (PR #65540)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Skip remaining tests of the same case upon failure (PR #65540)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7ecbf6c - [clang-format][NFC] Skip remaining tests of the same case upon failure (#65540)

Author: Owen Date: 2023-09-08T01:06:54-07:00 New Revision: 7ecbf6c30605ecbee4fdbcdec8f0866328c5217f URL: https://github.com/llvm/llvm-project/commit/7ecbf6c30605ecbee4fdbcdec8f0866328c5217f DIFF: https://github.com/llvm/llvm-project/commit/7ecbf6c30605ecbee4fdbcdec8f0866328c5217f.diff LOG: [cl

[clang] [clang-format][NFC] Skip remaining tests of the same case upon failure (PR #65540)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove Code Object V2 (PR #65715)

https://github.com/arsenm commented: The test updates to update the target can be done in a precommit. Is this dropping read support? https://github.com/llvm/llvm-project/pull/65715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

https://github.com/danix800 converted_to_draft https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/65723: When applying format changes to staged files, git-clang-format erroneously checks out all files in the index and thus may overwrite unstaged changes. Fixes #65643. >From eb3fc8f7c9f61650d458ffbd2952fa97e7c2e28d

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

https://github.com/owenca review_requested https://github.com/llvm/llvm-project/pull/65723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

https://github.com/rorth edited https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 96122b5 - [C++20] [Modules] Introduce ForceCheckCXX20ModulesInputFiles options for

Author: Chuanqi Xu Date: 2023-09-08T16:53:12+08:00 New Revision: 96122b5b717c2b1a291d7298ac50b1daf02bd97c URL: https://github.com/llvm/llvm-project/commit/96122b5b717c2b1a291d7298ac50b1daf02bd97c DIFF: https://github.com/llvm/llvm-project/commit/96122b5b717c2b1a291d7298ac50b1daf02bd97c.diff LO

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

cor3ntin added a comment. LGTM, but please wait a few days for @erichkeane CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157526/new/ https://reviews.llvm.org/D157526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

https://github.com/danix800 updated https://github.com/llvm/llvm-project/pull/65448: >From 235f39a6a5137e53239105727798d4540e5dd563 Mon Sep 17 00:00:00 2001 From: dingfei Date: Wed, 6 Sep 2023 10:03:21 +0800 Subject: [PATCH 1/3] [analyzer] Reduce constraint on modulo with small concrete range

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

https://github.com/danix800 unlabeled https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

https://github.com/danix800 updated https://github.com/llvm/llvm-project/pull/65448: >From 501595caf608aaeb8253235c32de5dd3ef4d3439 Mon Sep 17 00:00:00 2001 From: dingfei Date: Wed, 6 Sep 2023 10:03:21 +0800 Subject: [PATCH 1/3] [analyzer] Reduce constraint on modulo with small concrete range

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d60c474 - [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-09-08T11:20:16+02:00 New Revision: d60c47476dde601f1e48d44717ef23b7f1006fe6 URL: https://github.com/llvm/llvm-project/commit/d60c47476dde601f1e48d44717ef23b7f1006fe6 DIFF: https://github.com/llvm/llvm-project/commit/d60c47476dde601f1e48d44717ef23b

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

This revision was automatically updated to reflect the committed changes. Closed by commit rGd60c47476dde: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode (authored by jmmartinez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

https://github.com/danix800 unlabeled https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Don't crash when BlockToState is called from unreachable path (PR #65732)

https://github.com/kinu created https://github.com/llvm/llvm-project/pull/65732: When we call `getEnvironment`, `BlockToState[BlockId]` for the block can return null even if CFCtx.isBlockReachable(B) returns true if it is called from a particular block that is marked unreachable to the block.

[clang] [clang][dataflow] Don't crash when BlockToState is called from unreachable path (PR #65732)

https://github.com/kinu review_requested https://github.com/llvm/llvm-project/pull/65732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Don't crash when BlockToState is called from unreachable path (PR #65732)

https://github.com/kinu review_requested https://github.com/llvm/llvm-project/pull/65732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Don't crash when BlockToState is called from unreachable path (PR #65732)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Split incremental-extensions (PR #65683)

https://github.com/vgvassilev approved this pull request. LGTM! Maybe we can cherry pick it for the patch release 17.0.1. If that’s a critical patch for swift we can try for the 17.0.0 release. https://github.com/llvm/llvm-project/pull/65683 ___ cfe-

[clang] [clang][dataflow] Don't crash when BlockToState is called from unreachable path (PR #65732)

@@ -43,7 +43,20 @@ const Environment *StmtToEnvMap::getEnvironment(const Stmt &S) const { if (!CFCtx.isBlockReachable(*BlockIt->getSecond())) return nullptr; const auto &State = BlockToState[BlockIt->getSecond()->getBlockID()]; - assert(State); + if (!(State)) { +

[clang] [clang][dataflow] Don't crash when BlockToState is called from unreachable path (PR #65732)

kinu wrote: CC @martinboehme @Xazax-hun @ymand https://github.com/llvm/llvm-project/pull/65732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

https://github.com/cor3ntin approved this pull request. Oh wow. Thanks for fixing that so quickly! https://github.com/llvm/llvm-project/pull/65723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/65737: Differential Revision: https://reviews.llvm.org/D159257 From 1c2c8c7045d7298644f08833d3b2cdec694ea91d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Fri, 8 Sep 2023

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/jmmartinez review_requested https://github.com/llvm/llvm-project/pull/65737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/jmmartinez labeled https://github.com/llvm/llvm-project/pull/65737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/jmmartinez review_requested https://github.com/llvm/llvm-project/pull/65737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159257: [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode

jmmartinez abandoned this revision. jmmartinez added a comment. Moved into https://github.com/llvm/llvm-project/pull/65737 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159257/new/ https://reviews.llvm.org/D159257 _

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

https://github.com/danix800 review_requested https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

https://github.com/danix800 ready_for_review https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

cor3ntin wrote: There is similar effort on Phab, we should pick one of them https://reviews.llvm.org/D141177 https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

https://github.com/steakhal commented: In 1 minute it makes sense. Will need a thorough evaluation. I'll review this properly once I'm back from vacation. https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159138/new/ https://reviews.llvm.org/D159138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][LLVM] Model side effects of volatile and atomic load-store (PR #65730)

https://github.com/zero9178 updated https://github.com/llvm/llvm-project/pull/65730: From d32d6c5faca4141120482b7346c75f6656a29299 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20B=C3=B6ck?= Date: Fri, 8 Sep 2023 11:16:22 +0200 Subject: [PATCH 1/2] [mlir][LLVM] Model side effects of volatile

[clang] [mlir][LLVM] Model side effects of volatile and atomic load-store (PR #65730)

https://github.com/zero9178 resolved https://github.com/llvm/llvm-project/pull/65730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][LLVM] Model side effects of volatile and atomic load-store (PR #65730)

https://github.com/zero9178 resolved https://github.com/llvm/llvm-project/pull/65730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. In D159115#4640154 , @tuliom wrote: > This new test does not work on ppc64le. I've tested right now (as of 3398744a6106c83993611bd3c5e79ec6b94417dc ) and all c

[clang] [clang][dataflow] Don't crash when BlockToState is called from unreachable path (PR #65732)

https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/65732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Don't crash when BlockToState is called from unreachable path (PR #65732)

https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/65732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Don't crash when BlockToState is called from unreachable path (PR #65732)

@@ -43,7 +43,20 @@ const Environment *StmtToEnvMap::getEnvironment(const Stmt &S) const { if (!CFCtx.isBlockReachable(*BlockIt->getSecond())) return nullptr; const auto &State = BlockToState[BlockIt->getSecond()->getBlockID()]; - assert(State); + if (!(State)) { +

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

mizvekov wrote: Yep, I definitely I agree this is a good change, thanks for working on it! I thought about doing the same at the time, but I just didn't have the bandwidth for yet another patch with a lot of test churn :) https://github.com/llvm/llvm-project/pull/65214 _

[clang] [mlir][LLVM] Model side effects of volatile and atomic load-store (PR #65730)

https://github.com/zero9178 closed https://github.com/llvm/llvm-project/pull/65730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

aaron.ballman added a comment. In D152752#4641396 , @rnk wrote: > Following up, the vararg fix is here: > https://github.com/llvm/llvm-project/pull/65692 Thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/AaronBallman review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/AaronBallman review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/AaronBallman commented: I believe these changes are correct and they look to be reasonable, but adding the codegen code owners for final approval. https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-comm

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

@@ -121,18 +121,18 @@ static Value *mergeDistinctValues(QualType Type, Value &Val1, Value *MergedVal = nullptr; if (auto *RecordVal1 = dyn_cast(&Val1)) { -[[maybe_unused]] auto *RecordVal2 = cast(&Val2); - -// Values to be merged are always associated with the sam

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

@@ -121,18 +121,18 @@ static Value *mergeDistinctValues(QualType Type, Value &Val1, Value *MergedVal = nullptr; if (auto *RecordVal1 = dyn_cast(&Val1)) { -[[maybe_unused]] auto *RecordVal2 = cast(&Val2); - -// Values to be merged are always associated with the sam

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/RKSimon approved this pull request. LGTM if the clang team are happy with us not raising the alignment error https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [clang] Better bitfield access units (PR #65742)

https://github.com/urnathan converted_to_draft https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

AaronBallman wrote: > LGTM if the clang team are happy with us not raising the alignment error Yup, that's what got us on this path in the first place. Our downstream at Intel started getting errors on code that was previously working, this restores the previous behavior in that case. https:/

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/AaronBallman approved this pull request. Approving, but do wait a bit before landing in case a codegen code owner has comments. https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

ldionne added a comment. Ping. What's missing to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [sema] Improve -Wsign-compare (PR #65684)

apple-fcloutier wrote: IMO, the `< 0` check is fundamentally the right in-place fix to offer, although I went back and forth on attaching it to the warning or the note. It's a little disappointing that we still need the explicit cast to silence the warning, however. https://github.com/llvm/ll

[clang] [sema] Improve -Wsign-compare (PR #65684)

cor3ntin wrote: Not emitting a warning at all when there is an explicit comparison to `0` is an interesting idea, maybe that would be worth exploring? I wonder how complicated that would be https://github.com/llvm/llvm-project/pull/65684 ___ cfe-comm

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sema] Improve -Wsign-compare (PR #65684)

apple-fcloutier wrote: There's two main reasons I didn't go that route. First, we don't have great ways to check that two expressions refer to the same object (that I'm aware of). We can keep track of DeclRefExprs or maybe MemberExprs alone, but that creates a weird cliff of fixit availability

[PATCH] D143524: Make the -Wunused-template default.

ldionne removed reviewers: ldionne, libc++. ldionne added a comment. Herald added a subscriber: wangpc. [Github PR transition cleanup] Dropping libc++ since this shouldn't affect libc++ since D144667 . Repository: rC Clang CHANGES SINCE LAST ACTION https:

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

ldionne added inline comments. Comment at: runtimes/CMakeLists.txt:20 +set(RUNTIMES_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + This shouldn't be necessary, CMake already creates a `Project_SOURCE_DIR` variable for each declared `project()` IIRC. Repository:

[clang-tools-extra] [AArch64][CodeGen] Fix wrong operand order when creating vcmla intrinsic (PR #65278)

https://github.com/daisy202309 updated https://github.com/llvm/llvm-project/pull/65278: >From 9b68bfc6078a400247a55d181a6bc8ff73819cd4 Mon Sep 17 00:00:00 2001 From: lizhijin Date: Tue, 5 Sep 2023 00:56:23 +0800 Subject: [PATCH] [AArch64][CodeGen] Fix wrong operand order when creating vcmla in

[clang] [clang][dataflow] Don't crash when BlockToState is called from unreachable path (PR #65732)

https://github.com/kinu updated https://github.com/llvm/llvm-project/pull/65732: >From bc119f4bb478431bf85cda47dbc2a25faa59e85f Mon Sep 17 00:00:00 2001 From: Kinuko Yasuda Date: Fri, 8 Sep 2023 09:03:35 + Subject: [PATCH 1/2] [clang][dataflow] Don't crash when BlockToState doesn't have unr

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

tuliom added a comment. In D159115#4640388 , @mgorny wrote: > I'm sorry, by "new" you mean the version with `uintptr_t` or the original as > well? Both with `uintptr_t` as well as `unsigned long long`. In D159115#4641721

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2005 +static void +overrideFunctionFeaturesWithTargetFeatures(llvm::AttrBuilder &FuncAttr, + const llvm::Function &F, can you add a comment about how

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

https://github.com/yetingk review_requested https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >