[clang] [clang][dataflow] Eliminate `RecordValue::getChild()`. (PR #65586)

2023-09-07 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/65586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow][NFC] Delete unused function. (PR #65602)

2023-09-07 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/65602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

2023-09-07 Thread Manos Anagnostakis via Phabricator via cfe-commits
manosanag updated this revision to Diff 556154. manosanag added a comment. Updated Options.td to provide visibility for the options, because it caused a regression for my fortran tests after rebasing to current llvm main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141714: Fix ast print of variables with attributes

2023-09-07 Thread Giuliano Belinassi via Phabricator via cfe-commits
giulianobelinassi added a comment. In D141714#4638225 , @erichkeane wrote: > Looks fine to me, please don't commit for a day or two to give @aaron.ballman > a chance to make a final comment. I am sorry, but how am I supposed to commit those changes to

[PATCH] D141714: Fix ast print of variables with attributes

2023-09-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D141714#4640825 , @giulianobelinassi wrote: > In D141714#4638225 , @erichkeane > wrote: > >> Looks fine to me, please don't commit for a day or two to give >> @aaron.ballman a cha

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -66,16 +66,18 @@ bool ParseDiagnosticArgs(DiagnosticOptions &Opts, llvm::opt::ArgList &Args, DiagnosticsEngine *Diags = nullptr, bool DefaultDiagColor = true); +namespace CompilerInvocationDetail { /// The base class of Co

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -94,47 +96,37 @@ class CompilerInvocationRefBase { /// Options controlling the static analyzer. AnalyzerOptionsRef AnalyzerOpts; - CompilerInvocationRefBase(); - CompilerInvocationRefBase(const CompilerInvocationRefBase &X); - CompilerInvocationRefBase(CompilerInvoca

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -154,46 +146,158 @@ class CompilerInvocationValueBase { PreprocessorOutputOptions PreprocessorOutputOpts; public: - MigratorOptions &getMigratorOpts() { return MigratorOpts; } + // clang-format off const MigratorOptions &getMigratorOpts() const { return MigratorOpts;

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -123,49 +123,101 @@ static Expected> parseToleranceOption(StringRef Arg) { } //===--===// -// Initialization. +// Storage details. //===--

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -94,47 +96,37 @@ class CompilerInvocationRefBase { /// Options controlling the static analyzer. AnalyzerOptionsRef AnalyzerOpts; - CompilerInvocationRefBase(); - CompilerInvocationRefBase(const CompilerInvocationRefBase &X); - CompilerInvocationRefBase(CompilerInvoca

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -123,49 +123,101 @@ static Expected> parseToleranceOption(StringRef Arg) { } //===--===// -// Initialization. +// Storage details. //===--

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -94,47 +96,37 @@ class CompilerInvocationRefBase { /// Options controlling the static analyzer. AnalyzerOptionsRef AnalyzerOpts; - CompilerInvocationRefBase(); - CompilerInvocationRefBase(const CompilerInvocationRefBase &X); - CompilerInvocationRefBase(CompilerInvoca

[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > I think that might be a bit too accelerated. I work mostly with a fork of > LLVM (https://github.com/apple/llvm-project) and do care about the usability > of `cmd` as a shell (however, it is significantly behind but is working on > updating to a more recent version). I thi

[clang] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > I think that might be a bit too accelerated. I work mostly with a fork of > LLVM (https://github.com/apple/llvm-project) and do care about the usability > of `cmd` as a shell (however, it is significantly behind but is working on > updating to a more recent version). I thi

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -94,47 +96,37 @@ class CompilerInvocationRefBase { /// Options controlling the static analyzer. AnalyzerOptionsRef AnalyzerOpts; - CompilerInvocationRefBase(); - CompilerInvocationRefBase(const CompilerInvocationRefBase &X); - CompilerInvocationRefBase(CompilerInvoca

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

2023-09-07 Thread Yusra Syeda via cfe-commits
https://github.com/ysyeda updated https://github.com/llvm/llvm-project/pull/65407: >From d83e1e72f584619b6e035795558618581fdff3fd Mon Sep 17 00:00:00 2001 From: Yusra Syeda Date: Tue, 5 Sep 2023 15:43:24 -0400 Subject: [PATCH] [SystemZ][z/OS] This change adds support for the PPA2 section in zO

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -94,47 +96,37 @@ class CompilerInvocationRefBase { /// Options controlling the static analyzer. AnalyzerOptionsRef AnalyzerOpts; - CompilerInvocationRefBase(); - CompilerInvocationRefBase(const CompilerInvocationRefBase &X); - CompilerInvocationRefBase(CompilerInvoca

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Björn Pettersson via cfe-commits
https://github.com/bjope created https://github.com/llvm/llvm-project/pull/65624: - Update CodeGenTypeCache to use a single union for all pointers in address space zero. - Introduce a UnqualPtrTy in CodeGenTypeCache, and use that (for example instead of llvm::PointerType::getUnqual) in some

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Björn Pettersson via cfe-commits
https://github.com/bjope review_requested https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Björn Pettersson via cfe-commits
https://github.com/bjope review_requested https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Björn Pettersson via cfe-commits
https://github.com/bjope review_requested https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-07 Thread via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or adriannistor wrote: Done! (int commit ef9c4b68c2ec

[clang-tools-extra] [clang-tidy] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-07 Thread via cfe-commits
https://github.com/adriannistor edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Paul T Robinson via cfe-commits
pogo59 wrote: I have no stake in Apple/Swift, but for myself, `cmd` is the natural shell to use on Windows. (When I install Visual Studio, it creates a widget that brings up a `cmd` shell with the right environment. I'm not aware of a similar widget for PowerShell.) While I rarely try to copy-

[clang] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Paul T Robinson via cfe-commits
pogo59 wrote: I have no stake in Apple/Swift, but for myself, `cmd` is the natural shell to use on Windows. (When I install Visual Studio, it creates a widget that brings up a `cmd` shell with the right environment. I'm not aware of a similar widget for PowerShell.) While I rarely try to copy-

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -154,46 +146,158 @@ class CompilerInvocationValueBase { PreprocessorOutputOptions PreprocessorOutputOpts; public: - MigratorOptions &getMigratorOpts() { return MigratorOpts; } + // clang-format off const MigratorOptions &getMigratorOpts() const { return MigratorOpts;

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Björn Pettersson via cfe-commits
@@ -51,14 +51,11 @@ struct CodeGenTypeCache { llvm::IntegerType *PtrDiffTy; }; - /// void* in address space 0 + /// void*, void** in address space 0 union { +llvm::PointerType *UnqualPtrTy; bjope wrote: Maybe `OpaquePtrTy` is a better name. But

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -123,49 +123,101 @@ static Expected> parseToleranceOption(StringRef Arg) { } //===--===// -// Initialization. +// Storage details. //===--

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" checker. (PR #65189)

2023-09-07 Thread via cfe-commits
https://github.com/adriannistor edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Jessica Clarke via cfe-commits
@@ -51,14 +51,11 @@ struct CodeGenTypeCache { llvm::IntegerType *PtrDiffTy; }; - /// void* in address space 0 + /// void*, void** in address space 0 union { +llvm::PointerType *UnqualPtrTy; jrtc27 wrote: Not qualified (c.f. QualType) https://g

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -123,49 +123,101 @@ static Expected> parseToleranceOption(StringRef Arg) { } //===--===// -// Initialization. +// Storage details. //===--

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

2023-09-07 Thread Ulrich Weigand via cfe-commits
uweigand wrote: SystemZ back-end changes LGTM.Additional reviews as to the Clang and time support changes would be appreciated. https://github.com/llvm/llvm-project/pull/65407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-07 Thread Ronan Keryell via cfe-commits
https://github.com/keryell edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > When I install Visual Studio, it creates a widget that brings up a cmd shell > with the right environment. I'm not aware of a similar widget for PowerShell. At least in VS 2022, there is a `Developer PowerShell for VS 2022` in Start menu beside the usual `x64 Native Tools Comm

[PATCH] D141714: Fix ast print of variables with attributes

2023-09-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:312 + // printing on the left side for readbility. +else if (const VarDecl *VD = dyn_cast(D); + VD && VD->getInit() && While compiling this, I discovere

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

2023-09-07 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. The libc++ changes are reasonable. We could discuss more around how to handle C++03 in `__libcpp_is_constant_evaluated` but I don't think it's worth delaying this patch for that.

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Jessica Clarke via cfe-commits
@@ -51,14 +51,11 @@ struct CodeGenTypeCache { llvm::IntegerType *PtrDiffTy; }; - /// void* in address space 0 + /// void*, void** in address space 0 union { +llvm::PointerType *UnqualPtrTy; jrtc27 wrote: (Presumably the IR type's nomenclature h

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -123,49 +123,101 @@ static Expected> parseToleranceOption(StringRef Arg) { } //===--===// -// Initialization. +// Storage details. //===--

[clang] [Driver] Fix linking with -lm on Solaris (PR #65632)

2023-09-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth created https://github.com/llvm/llvm-project/pull/65632: As noticed in D158846, the Solaris driver deviates from other targets in that it links every executable with `-lm`, but doesn't for shared objects. For C code, this is unnecessary, while for C++ `libm` is always

[clang] [Driver] Fix linking with -lm on Solaris (PR #65632)

2023-09-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth review_requested https://github.com/llvm/llvm-project/pull/65632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix linking with -lm on Solaris (PR #65632)

2023-09-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth review_requested https://github.com/llvm/llvm-project/pull/65632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix linking with -lm on Solaris (PR #65632)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

2023-09-07 Thread Max Iyengar via Phabricator via cfe-commits
miyengar updated this revision to Diff 556170. miyengar added a comment. Moved pattern from `AArchInstrFormats.td` to `AArchInstrInfo.td` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158626/new/ https://reviews.llvm.org/D158626 Files: clang/include/clang/Basic/arm_neon.td clang/li

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

2023-09-07 Thread Max Iyengar via Phabricator via cfe-commits
miyengar added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6309 + + def : Pat<(v1f64 (OpNode (v1f64 FPR64:$Rn))), + (!cast(NAME # Dr) FPR64:$Rn)>; dmgreen wrote: > miyengar wrote: > > dmgreen wrote: > > > I think the ins

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

2023-09-07 Thread Louis Dionne via Phabricator via cfe-commits
ldionne resigned from this revision. ldionne added a subscriber: philnik. ldionne added a comment. Herald added a subscriber: wangpc. Herald added a project: All. @philnik you might be interested by this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] [Driver] Fix linking with -lm on Solaris (PR #65632)

2023-09-07 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/65632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148381: [Clang] Add counted_by attribute

2023-09-07 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Patch LGTM; just want moar tests. --- Mind adding a test for #if !__has_attribute(counted_by) #error "has attribute broken" #endif Comment at: clang/test/CodeGen/attr-counted-by.c:2 +// NOTE: Assertions have been autogenerated by utils/

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

2023-09-07 Thread via cfe-commits
https://github.com/adriannistor edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-07 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: What about an option that just redirects the PrintIRInstrumentation output to files instead of stderr? The files can be something like `$N-$modulename.ll` where `$N` is an int that increments. https://github.com/llvm/llvm-project/pull/65179 _

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-07 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: What about an option that just redirects the PrintIRInstrumentation output to files instead of stderr? The files can be something like `$N-$modulename.ll` where `$N` is an int that increments. https://github.com/llvm/llvm-project/pull/65179 _

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

2023-09-07 Thread Justin Bogner via Phabricator via cfe-commits
bogner added a comment. Ping. Please take another look when you get a chance, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159103/new/ https://reviews.llvm.org/D159103 ___ cfe-commits mailing li

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-09-07 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip created https://github.com/llvm/llvm-project/pull/65638: Fixes https://github.com/llvm/llvm-project/issues/58637. Additionally accounts for `_AlignAs` when constructing Attribute Form. This breaks a few tests because `IsAlignAs` is coupled with `CXX11Attribute`.

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-09-07 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip review_requested https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-07 Thread Nuri Amari via cfe-commits
NuriAmari wrote: > What about an option that just redirects the PrintIRInstrumentation output to > files instead of stderr? The files can be something like `$N-$modulename.ll` > where `$N` is an int that increments. Yeah that's more or less what I'm working on now. My plan is: - Add a flag th

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-07 Thread Nuri Amari via cfe-commits
NuriAmari wrote: > What about an option that just redirects the PrintIRInstrumentation output to > files instead of stderr? The files can be something like `$N-$modulename.ll` > where `$N` is an int that increments. Yeah that's more or less what I'm working on now. My plan is: - Add a flag th

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

2023-09-07 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > I have no stake in Apple/Swift, but for myself, `cmd` is the natural shell to > use on Windows. (When I install Visual Studio, it creates a widget that > brings up a `cmd` shell with the right environment. I'm not aware of a > similar widget for PowerShell.) While I rarely

[clang] 1e6b0df - [Driver] Fix linking with -lm on Solaris (#65632)

2023-09-07 Thread via cfe-commits
Author: Rainer Orth Date: 2023-09-07T19:14:55+02:00 New Revision: 1e6b0df3503567488e7df2d574c90f8f31a001a2 URL: https://github.com/llvm/llvm-project/commit/1e6b0df3503567488e7df2d574c90f8f31a001a2 DIFF: https://github.com/llvm/llvm-project/commit/1e6b0df3503567488e7df2d574c90f8f31a001a2.diff L

[clang] [Driver] Fix linking with -lm on Solaris (PR #65632)

2023-09-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/65632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[CUDA][HIP] Fix overloading resolution in global variable ini… (PR #65606)

2023-09-07 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. LGTM. I'm still figuring out the github-based workflow. One thing that may be useful in the future would be to start the pull request branch with the original/reverted commit and put the updates into separate commits, so one could see inc

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth review_requested https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth review_requested https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth created https://github.com/llvm/llvm-project/pull/65644: I noticed that `flang-new` cannot link Fortran executables on Solaris since the runtime libs are missing. This patch fixes this, following `Gnu.cpp`. The `linker-flags.f90` testcase is augmented to test for thi

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-07 Thread Rainer Orth via cfe-commits
https://github.com/rorth review_requested https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (PR #65596)

2023-09-07 Thread Eli Friedman via cfe-commits
@@ -14,8 +14,8 @@ class B : A { // NO-AS: @_ZTISt9type_info = external constant ptr // AS: @_ZTIi = external addrspace(1) constant ptr addrspace(1) // NO-AS: @_ZTIi = external constant ptr -// AS: @_ZTVN10__cxxabiv117__class_type_infoE = external addrspace(1) global ptr addrsp

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

2023-09-07 Thread Yusra Syeda via cfe-commits
https://github.com/ysyeda review_requested https://github.com/llvm/llvm-project/pull/65407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

2023-09-07 Thread via cfe-commits
https://github.com/adriannistor updated https://github.com/llvm/llvm-project/pull/65189: >From c6d70f6f851f0553e3e83b762618d48744a4f706 Mon Sep 17 00:00:00 2001 From: Adrian Nistor Date: Fri, 1 Sep 2023 15:35:59 -0700 Subject: [PATCH 1/3] Adding an initial version of the "Initialized Class Mem

[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

2023-09-07 Thread Kinuko Yasuda via cfe-commits
https://github.com/kinu created https://github.com/llvm/llvm-project/pull/65645: We can dump the same information from RecordStorageLocation. Tested the behavior before and after patch, that generates the field values in the HTML in both cases (and also made sure that removing the relevant code

[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

2023-09-07 Thread Kinuko Yasuda via cfe-commits
https://github.com/kinu review_requested https://github.com/llvm/llvm-project/pull/65645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

2023-09-07 Thread via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

2023-09-07 Thread via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][ExtractAPI] Remove test with system header (PR #65646)

2023-09-07 Thread Erick Velez via cfe-commits
https://github.com/evelez7 review_requested https://github.com/llvm/llvm-project/pull/65646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] Remove test with system header (PR #65646)

2023-09-07 Thread Erick Velez via cfe-commits
https://github.com/evelez7 created https://github.com/llvm/llvm-project/pull/65646: Issue raised here: https://reviews.llvm.org/D158474#inline-1543925 We can still test that `bool` is properly serialized using the `bool.cpp` test. >From 966ff8288a16f710c5220b152cb7ce0fa735a2ee Mon Sep 17 00:00

[clang] [clang][ExtractAPI] Remove test with system header (PR #65646)

2023-09-07 Thread Erick Velez via cfe-commits
https://github.com/evelez7 review_requested https://github.com/llvm/llvm-project/pull/65646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make the entire `CompilerInvocation` ref-counted (PR #65647)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make the entire `CompilerInvocation` ref-counted (PR #65647)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make the entire `CompilerInvocation` ref-counted (PR #65647)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/65647: This enables making the whole `CompilerInvocation` more efficient through copy-on-write. >From 4a29ff15728ac3e93de26066274493c1fd6c50fa Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 7 Sep 2023 10:

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -4588,28 +4641,29 @@ std::string CompilerInvocation::getModuleHash() const { return toString(llvm::APInt(64, Hash), 36, /*Signed=*/false); } -void CompilerInvocation::generateCC1CommandLine( +void CompilerInvocationBase::generateCC1CommandLine( ArgumentConsumer Consu

[clang] [clang][ExtractAPI] Remove test with system header (PR #65646)

2023-09-07 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] Remove test with system header (PR #65646)

2023-09-07 Thread Erick Velez via cfe-commits
https://github.com/evelez7 edited https://github.com/llvm/llvm-project/pull/65646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Made the entirety of `ValBase` ref-counted in https://github.com/llvm/llvm-project/pull/65647, which also resolves some other comments here. https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

2023-09-07 Thread via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

2023-09-07 Thread via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %check_clang_tidy %s google-cpp-init-class-members %t + +class PositiveDefaultedDefaultConstructor { +public: + PositiveDefaultedDefaultConstructor() = default; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: constructor should initialize these fields: X

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

2023-09-07 Thread Yusra Syeda via cfe-commits
https://github.com/ysyeda review_requested https://github.com/llvm/llvm-project/pull/65407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

2023-09-07 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: clang/test/ExtractAPI/bool.c:14 +//--- input.h +#include +bool Foo; aeubanks wrote: > clang tests should not be including system headers since that makes the tests > non-hermetic (this test fails in our internal build

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

2023-09-07 Thread via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

2023-09-07 Thread via cfe-commits
@@ -0,0 +1,51 @@ +//===--- CppInitClassMembersCheck.h - clang-tidy *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang][ExtractAPI] Remove test with system header (PR #65646)

2023-09-07 Thread Erick Velez via cfe-commits
https://github.com/evelez7 closed https://github.com/llvm/llvm-project/pull/65646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] Remove test with system header (PR #65646)

2023-09-07 Thread Erick Velez via cfe-commits
evelez7 wrote: Nevermind: https://reviews.llvm.org/D158474#inline-1544258 https://github.com/llvm/llvm-project/pull/65646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

2023-09-07 Thread Krishna Narayanan via cfe-commits
https://github.com/Krishna-13-cyber created https://github.com/llvm/llvm-project/pull/65650: [clang-repl] Add Documentation for Execution Results Handling. This patch adds documentation for execution results handling in Clang-REPL with the below features: - Automatic Printf feature - Value Syn

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

2023-09-07 Thread Krishna Narayanan via cfe-commits
https://github.com/Krishna-13-cyber review_requested https://github.com/llvm/llvm-project/pull/65650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

2023-09-07 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev review_requested https://github.com/llvm/llvm-project/pull/65650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   >