================ @@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include <string> + +#include "CppInitClassMembersCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/AST/Decl.h" +#include "clang/AST/Type.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/ASTMatchers/ASTMatchers.h" +#include "clang/ASTMatchers/ASTMatchersMacros.h" +#include "clang/Basic/Diagnostic.h" +#include "clang/Basic/LLVM.h" +#include "llvm/ADT/STLExtras.h" +#include "llvm/Support/raw_ostream.h" + +using namespace clang::ast_matchers; + +namespace clang::tidy::google { + +namespace { + +// Matches records that have a default constructor. +AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) { + return Node.hasDefaultConstructor(); +} + +// Returns the names of `Fields` in a comma separated string. +std::string +toCommaSeparatedString(const SmallVector<const FieldDecl *, 16> &Fields) { + std::string Buffer; + llvm::raw_string_ostream OS(Buffer); + llvm::interleave( + Fields, OS, [&OS](const FieldDecl *Decl) { OS << Decl->getName(); }, + ", "); + return Buffer; +} + +// Returns `true` for field types that should be reported (if additional +// conditions are also met). For example, returns `true` for `int` because an +// uninitialized `int` field can contain uninitialized values. +bool shouldReportThisFieldType(QualType Ty) { + if (Ty.isNull()) + return false; + + // FIXME: For now, this checker focuses on several allowlisted types. We will + // expand coverage in future. + return Ty->isIntegerType() || Ty->isBooleanType(); +} + +} // anonymous namespace + +void CppInitClassMembersCheck::checkMissingMemberInitializer( + ASTContext &Context, const CXXRecordDecl &ClassDecl, + const CXXConstructorDecl *Ctor) { + SmallVector<const FieldDecl *, 16> FieldsToReport; + + for (const FieldDecl *F : ClassDecl.fields()) { + if (shouldReportThisFieldType(F->getType()) && !F->hasInClassInitializer()) + FieldsToReport.push_back(F); + } + + if (FieldsToReport.empty()) + return; + + DiagnosticBuilder Diag = ---------------- adriannistor wrote:
Thanks for the feedback! I added this in an internal Feature Request tracker for this check (I have two other internal reviewers who suggested something similar, so I am clustering this feedback and I will implement a version that meets all 3 feedback: from you and from the two reviewers). Is tracking this as a Feature Request internally ok ? Or would you prefer I open a Feature Request in the [LLVM tracker](https://github.com/llvm/llvm-project/issues). I am a bit worried that, with this check being in very early stages, I will just be spamming the LLVM tracker with feature requests for an under-development check. However, if you think using the LLVM tracker is the right thing to do, I would be very glad to use the LLVM tracker, just let me know! Thanks! https://github.com/llvm/llvm-project/pull/65189 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
