[clang] 37458c6 - [clang][dataflow] Eliminate deprecated `DataflowAnalysis` constructor.

Author: Martin Braenne Date: 2023-09-04T07:00:11Z New Revision: 37458c66bfefaa4f4cb40043cb88413e5b826e3f URL: https://github.com/llvm/llvm-project/commit/37458c66bfefaa4f4cb40043cb88413e5b826e3f DIFF: https://github.com/llvm/llvm-project/commit/37458c66bfefaa4f4cb40043cb88413e5b826e3f.diff LOG

[PATCH] D159261: [clang][dataflow] Eliminate deprecated `DataflowAnalysis` constructor.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37458c66bfef: [clang][dataflow] Eliminate deprecated `DataflowAnalysis` constructor. (authored by mboehme). Repository: rG LLVM Github Monorepo C

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

cor3ntin wrote: Ouch the inability to comment outside of modified code is going to be painful. The changed code being ```cpp unsigned DisplayLineNo = Loc.getPresumedLoc().getLine(); for (const auto &I : Ranges) { DisplayLineNo = std::min(DisplayLineNo, SM.getPresumedLineNumbe

[clang] [Clang] Fix missing diagnostic for non-standard layout type in (PR #65246)

https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/65246: >From d15196f5148194c5cb2f59c438d06f9fa61c8b4a Mon Sep 17 00:00:00 2001 From: "kasuga.ryotaro" Date: Wed, 30 Aug 2023 13:26:31 +0900 Subject: [PATCH 1/2] [Clang] Fix missing diagnostic for non-standard layout

[clang] b70f1f8 - Haiku: Pick up a few more codegen parametres from downstream

Author: X512 Date: 2023-09-04T03:05:51-04:00 New Revision: b70f1f836da9b66675db74d19c84bddd0f6708a8 URL: https://github.com/llvm/llvm-project/commit/b70f1f836da9b66675db74d19c84bddd0f6708a8 DIFF: https://github.com/llvm/llvm-project/commit/b70f1f836da9b66675db74d19c84bddd0f6708a8.diff LOG: Hai

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb70f1f836da9: Haiku: Pick up a few more codegen parametres from downstream (authored by X512 , committed by brad). Repository:

[clang] [Clang] Fix missing diagnostic for non-standard layout type in (PR #65246)

cor3ntin wrote: Thanks. LGTM. I'd like to do things properly so I'll wait for CI to be fixed before approving, hopefully we can figure that out today! (Nothing to do on your end) https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing

[clang] [Clang] Fix missing diagnostic for non-standard layout type in (PR #65246)

kasuga-fj wrote: Thank you for your quick review! https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86Subtarget.cpp:271 + // Attach EVEX512 feature when we have AVX512 features and EVEX512 is not set. + size_t posNoEVEX512 = FS.rfind("-evex512"); skan wrote: > It seems the change in X86.cpp is

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

hazohelet wrote: > Ouch the inability to comment outside of modified code is going to be painful. > > The changed code being > > ```c++ > unsigned DisplayLineNo = Loc.getPresumedLoc().getLine(); > for (const auto &I : Ranges) { > DisplayLineNo = > std::min(DisplayLineNo, SM.g

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

kadircet added a comment. thanks, the fix LGTM as well. but i wonder how this surfaces, to make sure we're taking necessary precautions in the future. we definitely have a dangling reference, which isn't great. but it's surprising that we access diags consumer during indexing. I assume it's abo

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

kadircet added a comment. thanks, the fix LGTM as well. but i wonder how this surfaces, to make sure we're taking necessary precautions in the future. we definitely have a dangling reference, which isn't great. but it's surprising that we access diags consumer during indexing. I assume it's abo

[clang] 27bba42 - [clang] Use range-based for loops (NFC)

Author: Kazu Hirata Date: 2023-09-04T00:31:37-07:00 New Revision: 27bba42fc9e7674c6a8936c14e9614f3d7a30a85 URL: https://github.com/llvm/llvm-project/commit/27bba42fc9e7674c6a8936c14e9614f3d7a30a85 DIFF: https://github.com/llvm/llvm-project/commit/27bba42fc9e7674c6a8936c14e9614f3d7a30a85.diff L

[clang] 266c12a - [clang][dataflow] When dumping `ExprToVal`, dump the `Value`, not just its location.

Author: Martin Braenne Date: 2023-09-04T07:38:33Z New Revision: 266c12a1bd603fa3ecbf26a6f93621f0f8488da1 URL: https://github.com/llvm/llvm-project/commit/266c12a1bd603fa3ecbf26a6f93621f0f8488da1 DIFF: https://github.com/llvm/llvm-project/commit/266c12a1bd603fa3ecbf26a6f93621f0f8488da1.diff LOG

[PATCH] D159274: [clang][dataflow] When dumping `ExprToVal`, dump the `Value`, not just its location.

This revision was automatically updated to reflect the committed changes. Closed by commit rG266c12a1bd60: [clang][dataflow] When dumping `ExprToVal`, dump the `Value`, not just its… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D159300: [AST] Support ConceptReference in DynTypedNode, add dump().

massberg accepted this revision. massberg added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159300/new/ https://reviews.llvm.org/D159300

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

omjavaid wrote: Hi Have you compared build performance between cl and clang-cl? If only cl.exe is taking a lot of time while clang-cl doesnt then may be we should make this change specific to cl.exe. https://github.com/llvm/llvm-project/pull/65215 __

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f2

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp resolved https://github.com/llvm/llvm-project/pull/65231 ___

[PATCH] D159414: Haiku: Fixes for header / library paths

brad created this revision. brad added reviewers: nielx, korli, kallisti5. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Some fixes for the header / library paths.. - Use concat macro for all paths - Correct t

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

tru wrote: I suspect maybe the MSVC_VERSION check might exclude clang-cl, but we should make sure, because @omjavaid is correct, we shouldn't apply this to clang-cl unless it shows the same problems. https://github.com/llvm/llvm-project/pull/65215 __

[clang] [Clang] Fix missing diagnostic for non-standard layout type in (PR #65246)

@@ -39,6 +40,4 @@ struct C { static_assert(__builtin_offsetof(C, n) == 8, "long long field in ms_struct should be 8-byte aligned"); -#if !defined(TEST_FOR_ERROR) && !defined(TEST_FOR_WARNING) -// expected-no-diagnostics -#endif +// expected-warning@-2 {{offset of

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/hazohelet labeled https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/hazohelet created https://github.com/llvm/llvm-project/pull/65248: Loss of `__unaligned` qualifier does not invalidate overload candidates. This fixes a regression reported in https://reviews.llvm.org/D153690 >From eee4c3aee9350be51c9333f284810ffebd9d1663 Mon Sep 17 00:00:00

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/kasuga-fj edited https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/kasuga-fj edited https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

kinu updated this revision to Diff 555676. kinu added a comment. reverted wrong changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159284/new/ https://reviews.llvm.org/D159284 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp clang/unitt

[PATCH] D153690: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

hazohelet added a comment. I submitted PR to fix the crash: https://github.com/llvm/llvm-project/pull/65248 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153690/new/ https://reviews.llvm.org/D153690 ___

[PATCH] D159309: [ASTMatchers] basic matcher support for ConceptReference

massberg added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:2545 }; -dependentSizedArrayType() +dependentSizedArrayType matches "T data[Size]" Was this change to drop the () by purpose? Comment at: clang/docs/LibAS

[clang] d948d91 - [clang][dataflow] Remove deprecated synonyms related to `RecordStorageLocation` and `RecordValue`

Author: Martin Braenne Date: 2023-09-04T08:18:43Z New Revision: d948d9121f104f06b47361528289030a28e1e044 URL: https://github.com/llvm/llvm-project/commit/d948d9121f104f06b47361528289030a28e1e044 DIFF: https://github.com/llvm/llvm-project/commit/d948d9121f104f06b47361528289030a28e1e044.diff LOG

[PATCH] D159264: [clang][dataflow] Remove deprecated synonyms related to `RecordStorageLocation` and `RecordValue`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd948d9121f10: [clang][dataflow] Remove deprecated synonyms related to `RecordStorageLocation`… (authored by mboehme). Repository: rG LLVM Github M

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

nridge added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:102 + + if (clang::Expr *const RequiresClause = + LExpr->getTrailingRequiresClause(); nit: just `if (clang::Expr *const RequiresClause = LExp

[clang] bf46b0b - [clang][dataflow] Eliminate deprecated `ControlFlowContext::build()` overload.

Author: Martin Braenne Date: 2023-09-04T08:30:54Z New Revision: bf46b0b551011d958ae642f808894311513517ef URL: https://github.com/llvm/llvm-project/commit/bf46b0b551011d958ae642f808894311513517ef DIFF: https://github.com/llvm/llvm-project/commit/bf46b0b551011d958ae642f808894311513517ef.diff LOG

[PATCH] D159262: [clang][dataflow] Eliminate deprecated `ControlFlowContext::build()` overload.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf46b0b55101: [clang][dataflow] Eliminate deprecated `ControlFlowContext::build()` overload. (authored by mboehme). Repository: rG LLVM Github Mon

[PATCH] D159174: [Clang] Use stable_sort in AppendTargetMangling

ilinpv added a comment. In D159174#4635886 , @BeMg wrote: > I'm working on RISC-V FMV support, and we found the large set of extension > features is hard to maintain the priority that doesn't collision at all. On AArch64 for FMV we are using ##target_ve

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= https://github.com/PiotrZSL approved this pull request. No more comments from me. https://github.c

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

nridge requested changes to this revision. nridge added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:187 +// Allow expressions, but only allow completely selected lambda +/

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

nridge added a comment. (Otherwise the updates look good!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141757/new/ https://reviews.llvm.org/D141757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -39,6 +40,4 @@ struct C { static_assert(__builtin_offsetof(C, n) == 8, "long long field in ms_struct should be 8-byte aligned"); -#if !defined(TEST_FOR_ERROR) && !defined(TEST_FOR_WARNING) -// expected-no-diagnostics -#endif +// expected-warning@-2 {{offset of

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -39,6 +40,4 @@ struct C { static_assert(__builtin_offsetof(C, n) == 8, "long long field in ms_struct should be 8-byte aligned"); -#if !defined(TEST_FOR_ERROR) && !defined(TEST_FOR_WARNING) -// expected-no-diagnostics -#endif +// expected-warning@-2 {{offset of

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko added a comment. In D159363#4636581 , @kadircet wrote: > thanks, the fix LGTM as well. > > but i wonder how this surfaces, to make sure we're taking necessary > precautions in the future. we definitely have a dangling reference, which > isn

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555689. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp Index: clang/lib/Driver/ToolChains/Haiku.cpp ==

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -39,6 +40,4 @@ struct C { static_assert(__builtin_offsetof(C, n) == 8, "long long field in ms_struct should be 8-byte aligned"); -#if !defined(TEST_FOR_ERROR) && !defined(TEST_FOR_WARNING) -// expected-no-diagnostics -#endif +// expected-warning@-2 {{offset of

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez updated this revision to Diff 555691. jmmartinez marked 4 inline comments as done. jmmartinez added a comment. - Review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159206/new/ https://reviews.llvm.org/D159206 Files: clang/lib/CodeGe

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2017 +for (StringRef Feature : llvm::split(FFeatures.getValueAsString(), ',')) { + bool EnabledForFunc = Feature[0] == '+'; + StringRef Name = Feature.substr(1); arsenm wrote

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/65246: >From d15196f5148194c5cb2f59c438d06f9fa61c8b4a Mon Sep 17 00:00:00 2001 From: "kasuga.ryotaro" Date: Wed, 30 Aug 2023 13:26:31 +0900 Subject: [PATCH 1/3] [Clang] Fix missing diagnostic for non-standard layout

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. @RIscRIpt Do you need further help on this patch? You have commit access, right? (I'm trying to make sure things don't fall through the cracks as we move to github) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/ne

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/kasuga-fj resolved https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154893: [Clang] Fix some triviality computations

cor3ntin added a comment. @royjacobson Are you still working on that? It seems it's only missing updates to a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 _

[clang-tools-extra] [mlir][OpenMP] Added omp.region operation (PR #65243)

kiranchandramohan wrote: Please add a quick RFC in the mlir discourse channel. Would it make sense to call it an internal region? Or specialize it further and call it canonical_loop_region? https://github.com/llvm/llvm-project/pull/65243 ___ cfe-comm

[PATCH] D154716: [SemaCXX] Fix bug where unexpanded lambda captures where assumed to be expanded

cor3ntin added a comment. @MitalAshok Are you still working on this? Do you need further help on this patch? You have commit access, correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154716/new/ https://reviews.llvm.org/D154716 _

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

@@ -39,6 +40,4 @@ struct C { static_assert(__builtin_offsetof(C, n) == 8, "long long field in ms_struct should be 8-byte aligned"); -#if !defined(TEST_FOR_ERROR) && !defined(TEST_FOR_WARNING) -// expected-no-diagnostics -#endif +// expected-warning@-2 {{offset of

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. @cor3ntin, thanks for asking. No, I do not have access. Please merge. Commits should have correct email and name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 ___

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. Oh! I should have asked sooner. Will do! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 ___ cfe-commits mailing list cfe-commi

[PATCH] D159412: [analyzer]FieldRegion in getStaticSize should return size of pointee type

donat.nagy added a comment. Please add a testcase that demonstrates this issue (fails when your change in MemRegion.cpp isn't added) and shows that your commit fixes it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159412/new/ https://reviews.llv

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. Hum. before I do - I think the commit message could be more explicit as to what the patch does ("Add support of Windows Trace Logging macros" is a bit vague) - Do we need a release note ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D159421: [NFC] Remove unneeded header includes

void created this revision. void added reviewers: erichkeane, nickdesaulniers. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use forward decls instead of #including the header files. Repository: rG LL

[clang-tools-extra] fdb6e8b - [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (#65231)

Author: Carlos Galvez Date: 2023-09-04T11:45:04+02:00 New Revision: fdb6e8b7926572bcb855d59d6bc84c7be5277768 URL: https://github.com/llvm/llvm-project/commit/fdb6e8b7926572bcb855d59d6bc84c7be5277768 DIFF: https://github.com/llvm/llvm-project/commit/fdb6e8b7926572bcb855d59d6bc84c7be5277768.diff

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/65231 _

[PATCH] D158413: [Lex] Introduce Preprocessor::LexAll()

Hahnfeld added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D158414: [LexerTest] Use LexAll() in StringifyArgs

Hahnfeld added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158414/new/ https://reviews.llvm.org/D158414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

Hahnfeld added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D159355: [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening.

mboehme accepted this revision. mboehme added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:53 +// +// FIXME: this function is a hook that enable unsoundness in support of +// convergence. On

[clang] [clang][bpf] Fix invalid RUN lines in stack protector warning test (PR #65251)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/65251: 2 of them were missing the ":" on the end. Adding them broke the test so I had to add a new prefix just for the warning runs only. I manually checked the first RUNs and there is no warning emitted, as ex

[clang] [clang][bpf] Fix invalid RUN lines in stack protector warning test (PR #65251)

https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bpf] Fix invalid RUN lines in stack protector warning test (PR #65251)

https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. In D158591#4636814 , @cor3ntin wrote: > Hum. before I do > > - I think the commit message could be more explicit as to what the patch does > ("Add support of Windows Trace Logging macros" is a bit vague) > - Do we need a release

[clang] 916415b - [AArch64][SME] Make the overloaded svreinterpret_* functions streaming-compatible.

Author: Sander de Smalen Date: 2023-09-04T10:15:26Z New Revision: 916415b83732332d15125dee6d7a4b55438c8d7b URL: https://github.com/llvm/llvm-project/commit/916415b83732332d15125dee6d7a4b55438c8d7b DIFF: https://github.com/llvm/llvm-project/commit/916415b83732332d15125dee6d7a4b55438c8d7b.diff L

[PATCH] D159188: [AArch64][SME] Make the overloaded svreinterpret_* functions streaming-compatible.

This revision was automatically updated to reflect the committed changes. Closed by commit rG916415b83732: [AArch64][SME] Make the overloaded svreinterpret_* functions streaming… (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 86c31c1 - [APINotes] Remove unused OS-availability feature

Author: Egor Zhdan Date: 2023-09-04T11:59:11+01:00 New Revision: 86c31c1406cfff001c0a52ebf3a31185635d6ad6 URL: https://github.com/llvm/llvm-project/commit/86c31c1406cfff001c0a52ebf3a31185635d6ad6 DIFF: https://github.com/llvm/llvm-project/commit/86c31c1406cfff001c0a52ebf3a31185635d6ad6.diff LO

[clang] [APINotes] Remove unused OS-availability feature (PR #65178)

https://github.com/egorzhdan closed https://github.com/llvm/llvm-project/pull/65178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/65187: >From e2150c20056e44a6ecbc82c63f499b6010c37930 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Fri, 1 Sep 2023 22:07:47 +0100 Subject: [PATCH] [APINotes] Upstream APINotesWriter This upstreams more of the Cla

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -749,6 +750,17 @@ struct Context { Context(ContextID id, ContextKind kind) : id(id), kind(kind) {} }; + +/// A temporary reference to an Objective-C selector, suitable for +/// referencing selector data on the stack. +/// +/// Instances of this struct do not store referen

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -19,11 +19,11 @@ namespace clang { namespace api_notes { -class APINotesWriter::Implementation { - template - using VersionedSmallVector = - llvm::SmallVector, 1>; +template +using VersionedSmallVector = +llvm::SmallVector, 1>; egorzhdan wrote:

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default; void APINotesWriter::writeToStream(llvm::raw_ostream &OS) { Implementation->writeToStream(OS); } + +ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID, +

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default; void APINotesWriter::writeToStream(llvm::raw_ostream &OS) { Implementation->writeToStream(OS); } + +ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID, +

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default; void APINotesWriter::writeToStream(llvm::raw_ostream &OS) { Implementation->writeToStream(OS); } + +ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID, +

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

tbaederr wrote: Okay, makes sense to me. Should probably also be backported to 17. https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159398: [AArch64][Clang] Disable outline atomics in freestanding env

ilinpv added a comment. From what i understand in freestanding environment runtime library is not used and clang driver can detect this situation and set outline atomics off by default ( see ##clang/lib/Driver/ToolChains/Linux.cpp## ##Linux::IsAArch64OutlineAtomicsDefault## -> ##GetRuntimeLibTy

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

cor3ntin wrote: @tbaederr We are getting rather conservative as to what gets backported. I think that does not meet the bar. Maybe for 17.0.x https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] 3dcf3cb - [ASTMatchers] Bring comments & docs back in sync

Author: Sam McCall Date: 2023-09-04T13:42:29+02:00 New Revision: 3dcf3cbc421cb5ee985b3b4a697c51247df8b5dc URL: https://github.com/llvm/llvm-project/commit/3dcf3cbc421cb5ee985b3b4a697c51247df8b5dc DIFF: https://github.com/llvm/llvm-project/commit/3dcf3cbc421cb5ee985b3b4a697c51247df8b5dc.diff LO

Re: [PATCH] D159309: [ASTMatchers] basic matcher support for ConceptReference

(by mail as phab is unusable today) On Mon, Sep 4, 2023 at 10:16 AM Jens Massberg via Phabricator < revi...@reviews.llvm.org> wrote: > massberg added inline comments. > > > > Comment at: clang/docs/LibASTMatchersReference.html:2545 >}; > -dependentSizedArrayType() > +dependen

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/egorzhdan review_requested https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

eddyz87 added a comment. After retesting kernel build with LLVM=1 and libbpf patch to reconstruct btf_decl_tag [1], statistics for BPF selftests looks as follows: - out of 653 object files 13 have some differences with and w/o this change;

[PATCH] D159338: [clangd][tests] Bump timeouts in TUSchedulerTests to 60 secs

sammccall added a comment. In D159338#4635010 , @hiraditya wrote: > not sure if this is the right way to fix these tests. The problem is if a > device is constraiend, this will further slow down the device and create more > backlogs. Can we allow a way

[clang] da5e11c - [AST] Support ConceptReference in DynTypedNode, add dump().

Author: Sam McCall Date: 2023-09-04T13:56:15+02:00 New Revision: da5e11cd1ce0754a123ff0bf6f3ce4a41be14355 URL: https://github.com/llvm/llvm-project/commit/da5e11cd1ce0754a123ff0bf6f3ce4a41be14355 DIFF: https://github.com/llvm/llvm-project/commit/da5e11cd1ce0754a123ff0bf6f3ce4a41be14355.diff LO

[PATCH] D159309: [ASTMatchers] basic matcher support for ConceptReference

sammccall updated this revision to Diff 555709. sammccall added a comment. regenerate HTML after rebasing on 415d9e8ca39c0b42f351cc532ccfb48b6ac97f7f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] [clang-repl] Emit const variables only once (PR #65257)

https://github.com/hahnjo labeled https://github.com/llvm/llvm-project/pull/65257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Emit const variables only once (PR #65257)

https://github.com/hahnjo created https://github.com/llvm/llvm-project/pull/65257: Disable internal linkage for const variables if IncrementalExtensions are enabled. Otherwise the variables are emitted multiple times, with multiple constructions at unique memory locations, during every PTU. >

[clang] [clang-repl] Emit const variables only once (PR #65257)

https://github.com/hahnjo review_requested https://github.com/llvm/llvm-project/pull/65257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Emit const variables only once (PR #65257)

https://github.com/hahnjo review_requested https://github.com/llvm/llvm-project/pull/65257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Emit const variables only once (PR #65257)

https://github.com/hahnjo review_requested https://github.com/llvm/llvm-project/pull/65257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Emit const variables only once (PR #65257)

https://github.com/vgvassilev review_requested https://github.com/llvm/llvm-project/pull/65257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

eddyz87 added a comment. In D133361#4629292 , @ast wrote: > ... > Right. Such recursive propagation of PAI is necessary. For btf_tag we cannot > do it. Always propagating it won't be correct. > New preserve_const_field_offset would need to be propagated

[PATCH] D159398: [AArch64][Clang] Disable outline atomics in freestanding env

yota9 added a comment. The problem here is that if you would remove the freestanding condition and run this test it would fail since "-target-feature" "+outline-atomics" would be passed to the clang. And usually we don't want the compiler to use any external symbols in freestanding mode, this

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

metaflow wrote: @kasuga-fj could you please re-upload change to trigger the build? https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   >