mboehme accepted this revision. mboehme added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:53 +// +// FIXME: this function is a hook that enable unsoundness in support of +// convergence. Once we have widening support for the reference/pointer and ---------------- Did you mean "hack"? If you did indeed mean "hook" -- I think it's not strictly speaking a [hook](https://en.wikipedia.org/wiki/Hooking), as there's no way to change the behavior here (i.e. install a different handler). Maybe just "this function enables unsoundness..."? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159355/new/ https://reviews.llvm.org/D159355 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
