[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc updated this revision to Diff 554197. wangpc marked 2 inline comments as done. wangpc added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files: clang-tools-extra/clangd/unit

[clang] e5d8160 - Revert "[OpenMP] Allow exceptions in target regions when offloading to GPUs"

Author: antonrydahl Date: 2023-08-29T00:09:21-07:00 New Revision: e5d8160040f69d9084e89260eec85f98038611b5 URL: https://github.com/llvm/llvm-project/commit/e5d8160040f69d9084e89260eec85f98038611b5 DIFF: https://github.com/llvm/llvm-project/commit/e5d8160040f69d9084e89260eec85f98038611b5.diff L

[PATCH] D158977: [clang][dataflow] Don't associate prvalue expressions with storage locations.

mboehme added a comment. In D158977#4623402 , @xazax.hun wrote: > Thanks! Sometimes I am wondering whether we actually need a full map for > PRValues. E.g., once we processed a `MaterializeTemporaryExpr`, we now have a > location for the value, and it f

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

cor3ntin added a comment. Thanks a lot for working on this. LGTM, except for the failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/ https://reviews.llvm.org/D159024 ___ cfe-commits ma

[clang] 330d5bc - [clang][dataflow] Don't associate prvalue expressions with storage locations.

Author: Martin Braenne Date: 2023-08-29T07:28:46Z New Revision: 330d5bcbf61043b5ca2bf5a65bd4488718c85e6e URL: https://github.com/llvm/llvm-project/commit/330d5bcbf61043b5ca2bf5a65bd4488718c85e6e DIFF: https://github.com/llvm/llvm-project/commit/330d5bcbf61043b5ca2bf5a65bd4488718c85e6e.diff LOG

[PATCH] D158977: [clang][dataflow] Don't associate prvalue expressions with storage locations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG330d5bcbf610: [clang][dataflow] Don't associate prvalue expressions with storage locations. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

goncharov added inline comments. Comment at: .ci/generate-buildkite-pipeline-premerge:163 + +if [[ ! ${SPECIFIC_PIPELINE_AVAILABLE} -eq 1 ]]; then + # Figure out which projects need to be built on each platform ldionne wrote: > goncharov wrote: > > do I understa

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc added a comment. Thanks all! I will land this patch later. If there are some failures (especially `libcxx` part @Mordante :-) ), please help me to fix them. Thanks in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https:

[clang-tools-extra] 2916b12 - [clang] Enable sized deallocation by default in C++14 onwards

Author: wangpc Date: 2023-08-29T15:42:50+08:00 New Revision: 2916b125f686115deab2ba573dcaff3847566ab9 URL: https://github.com/llvm/llvm-project/commit/2916b125f686115deab2ba573dcaff3847566ab9 DIFF: https://github.com/llvm/llvm-project/commit/2916b125f686115deab2ba573dcaff3847566ab9.diff LOG: [

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2916b125f686: [clang] Enable sized deallocation by default in C++1

[clang] 6982f1f - [clang-format][NFC] Test formatting the input before messing it up

Author: Owen Pan Date: 2023-08-29T00:59:33-07:00 New Revision: 6982f1fc2e750cfbb4b0098a6294d341238656ca URL: https://github.com/llvm/llvm-project/commit/6982f1fc2e750cfbb4b0098a6294d341238656ca DIFF: https://github.com/llvm/llvm-project/commit/6982f1fc2e750cfbb4b0098a6294d341238656ca.diff LOG:

[PATCH] D158947: [clang-format][NFC] Test formatting the input before messing it up

This revision was automatically updated to reflect the committed changes. Closed by commit rG6982f1fc2e75: [clang-format][NFC] Test formatting the input before messing it up (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158947/

[PATCH] D158933: [clang] Implement -funsigned-bitfields

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18137 + + // TODO: Somehow get the explicit signdness info, maybe with the usage of + // the typedef's name (Typedef->getDecl()->getNameAsString()), look it up The information seems

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

Fznamznon updated this revision to Diff 554220. Fznamznon added a comment. Apply suggestion, rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158615/new/ https://reviews.llvm.org/D158615 Files: clang/docs/ReleaseNotes

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

nikic added a comment. FYI this resulted in some pretty wild code size swings, in particular between -10% and -15% for tramp3d-v4 (http://llvm-compile-time-tracker.com/compare.php?from=6cde64a94986165547ae5237ac7dd4bddfc9f2a7&to=2916b125f686115deab2ba573dcaff3847566ab9&stat=size-text). Not sure

[clang] 13a044c - [DebugInfo] Fix incorrect dbg.declare when nrvo flag is used

Author: Nikita Popov Date: 2023-08-29T11:39:59+02:00 New Revision: 13a044c6993a914fc33549b72215e698a1cdef63 URL: https://github.com/llvm/llvm-project/commit/13a044c6993a914fc33549b72215e698a1cdef63 DIFF: https://github.com/llvm/llvm-project/commit/13a044c6993a914fc33549b72215e698a1cdef63.diff

[PATCH] D158972: [DebugInfo] Fix incorrect dbg.declare when nrvo flag is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG13a044c6993a: [DebugInfo] Fix incorrect dbg.declare when nrvo flag is used (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 14cc7a0 - [Clang] Allow __declspec(noalias) to access inaccessible memory

Author: Nikita Popov Date: 2023-08-29T11:43:57+02:00 New Revision: 14cc7a07727555102c52e711f476ec7671317d6a URL: https://github.com/llvm/llvm-project/commit/14cc7a07727555102c52e711f476ec7671317d6a DIFF: https://github.com/llvm/llvm-project/commit/14cc7a07727555102c52e711f476ec7671317d6a.diff

[PATCH] D158984: [Clang] Allow __declspec(noalias) to access inaccessible memory

This revision was automatically updated to reflect the committed changes. Closed by commit rG14cc7a077275: [Clang] Allow __declspec(noalias) to access inaccessible memory (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[clang] 125abbd - [flang][driver] Ensure negative flags have the same visibility as positive

Author: Tom Eccles Date: 2023-08-29T09:48:28Z New Revision: 125abbdc97671d8300cfc1ebcc010d8d4248974b URL: https://github.com/llvm/llvm-project/commit/125abbdc97671d8300cfc1ebcc010d8d4248974b DIFF: https://github.com/llvm/llvm-project/commit/125abbdc97671d8300cfc1ebcc010d8d4248974b.diff LOG: [f

[PATCH] D158612: [flang][driver] Ensure negative flags have the same visibility as positive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG125abbdc9767: [flang][driver] Ensure negative flags have the same visibility as positive (authored by tblah). Changed prior to commit: https://rev

[PATCH] D155858: Add a concept AST node.

sammccall added inline comments. Comment at: clang/lib/AST/TypeLoc.cpp:625 -DeclarationNameInfo AutoTypeLoc::getConceptNameInfo() const { - return DeclarationNameInfo(getNamedConcept()->getDeclName(), - getLocalData()->ConceptNameLoc); +ConceptRefer

[PATCH] D158688: [Driver,ARM,AArch64] Ignore -mbranch-protection= diagnostics for assembler input

stuij added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158688/new/ https://reviews.llvm.org/D158688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D158688: [Driver,ARM,AArch64] Ignore -mbranch-protection= diagnostics for assembler input

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. The change LGTM, and "agree with gcc" seems like a reasonable justification in this case. But I'm curious more generally about what options should / shouldn't be covered by `-Wunu

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554257. massberg marked 7 inline comments as done. massberg added a comment. Resolve more of the open comments. - add `getBeginLoc()`, `getEndLoc()` and `getSourceRange()` to `ConceptReference` and updated corresponding functions in `ConceptSpecializationE

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

ABataev added a comment. In D158778#4622901 , @tra wrote: > @ABataev > > This patch breaks breaks two tests: > > - > github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/nvptx_unsupported_type_codegen.cpp > - > github.com/llvm/llvm-project/blob/main

[PATCH] D154838: [analyzer] Add check for null pointer passed to %p of printf family

CuriousGeorgiy updated this revision to Diff 554259. CuriousGeorgiy marked 2 inline comments as done. CuriousGeorgiy added a comment. Herald added a subscriber: ormris. [analyzer] Add check for null pointer passed to the %p of printf family The result of passing a null pointer to the pointer conv

[PATCH] D159083: Clang: Don't warn about unused private fields of types declared maybe_unused

hans created this revision. hans added reviewers: aaron.ballman, shafik. Herald added a project: All. hans requested review of this revision. Herald added a project: clang. The compiler should not warn on code such as: class [[maybe_unused]] MaybeUnusedClass {}; class C { MaybeUnusedClass

[clang] f616c3e - [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

Author: Saiyedul Islam Date: 2023-08-29T06:35:44-05:00 New Revision: f616c3eeb43f3732f53f81d291723a6a34af2de1 URL: https://github.com/llvm/llvm-project/commit/f616c3eeb43f3732f53f81d291723a6a34af2de1 DIFF: https://github.com/llvm/llvm-project/commit/f616c3eeb43f3732f53f81d291723a6a34af2de1.diff

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf616c3eeb43f: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5 (authored by saiislam). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-code-object-version-linking.cu:12 +// RUN: llvm-link %t_0 %t_5 -o -| llvm-dis -o - | FileCheck -check-prefix=LINKED5 %s + +#include "Inputs/cuda.h" yaxunl wrote: > saiislam wrote: > > yaxu

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/83485/step_7.txt Please take a look and revert for now if it takes a while to fix. (Also, if the patch doesn't already do it, it probably shouldn't change defaults in clang-cl mode?) Repository: rG LLVM

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

sunmy2019 added a comment. For note: it possibly break fmtlib. https://github.com/fmtlib/fmt/issues/3607 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153156/new/ https://reviews.llvm.org/D153156 ___ cfe

[clang] b63c6e5 - [NFC][Clang] Add missing & to function argument

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-08-29T13:59:17+02:00 New Revision: b63c6e585d8662b67b38988f0cd38a0bd6e0d38a URL: https://github.com/llvm/llvm-project/commit/b63c6e585d8662b67b38988f0cd38a0bd6e0d38a DIFF: https://github.com/llvm/llvm-project/commit/b63c6e585d8662b67b38988f0cd38a0

[PATCH] D158991: [NFC][Clang] Add missing & to function argument

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb63c6e585d86: [NFC][Clang] Add missing & to function argument (authored by jmmartinez). Repository: rG LLVM Github Mono

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

jhuber6 added a comment. This caused some linking errors with the GPU libc test suite, see https://lab.llvm.org/staging/#/builders/247/builds/5659. clang++: error: ld.lld command failed with exit code 1 (use -v to see invocation) [331/473] Linking CXX executable libc/test/src/__support/lib

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. friendly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

eddyz87 added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:2432 ImmArg>]>; +def int_context_marker_bpf : DefaultAttrsIntrinsic<[llvm_ptr_ty], + [llvm_ptr_ty], -

[PATCH] D154838: [analyzer] Add check for null pointer passed to the %p of printf family

CuriousGeorgiy added a comment. @steakhal Thanks for the review comments! > This line should be just as long, as the line above. Fixed. > Our docs aren't great, but we should have a brief description what the > checker detects, basically here it would be "Find null pointers being passed > to

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc added a comment. In D112921#4624488 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/83485/step_7.txt > > Please take a look and revert for now if it takes a while to fix. > > (Also, if the patch doesn't already

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc added a comment. In D112921#4624547 , @jhuber6 wrote: > This caused some linking errors with the GPU libc test suite, see > https://lab.llvm.org/staging/#/builders/247/builds/5659. > > clang++: error: ld.lld command failed with exit code 1 (use

[PATCH] D159086: Change begin of macro in translateSourceRange in libclang

quic-cbusold created this revision. quic-cbusold added a reviewer: klimek. Herald added a subscriber: arphaman. Herald added a project: All. quic-cbusold requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently translateSourceRange changes

[PATCH] D159068: [clang][X86] Update excessive register save diagnostic to more closely follow the interrupt attribute spec

aaron.ballman edited reviewers, added: pengfei; removed: mibintc. aaron.ballman added a comment. Changing the reviewers up a bit; the changes generally seem reasonable to me, but I'd appreciate some x86 reviewer viewpoints. Comment at: clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc added a comment. In D112921#4624141 , @nikic wrote: > FYI this resulted in some pretty wild code size swings, in particular between > -10% and -15% for tramp3d-v4 > (http://llvm-compile-time-tracker.com/compare.php?from=6cde64a94986165547ae5237ac

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554277. ldionne added a comment. Don't upload the Windows build artifacts cause we don't use them and it fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files:

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

yonghong-song added a comment. > I can rename these things, but tbh I don't think this functionality would be > useful anywhere outside BPF, thus such renaming would be kind-of deceptive > (and in case it would be useful, the renaming could be done at the time of > second use). Then let us kee

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

jhuber6 added a subscriber: sivachandra. jhuber6 added a comment. In D112921#4624580 , @wangpc wrote: > It seems that the linker can't find sized deallocation (no support in the > environment or AMDGPU libraries?). We should have some implementations he

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan updated this revision to Diff 554279. zyounan added a comment. Herald added a project: clang. Adopt the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files: clang-tools-extra/clangd/

[PATCH] D156565: Diagnose use of VLAs in C++ by default

cor3ntin added a comment. In D156565#4605027 , @shafik wrote: > In D156565#4599812 , @aaron.ballman > wrote: > >> Enable the diagnostic by default in C++ language modes, and under -Wall in >> GNU++ language mode

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan updated this revision to Diff 554283. zyounan added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/support/

[PATCH] D159083: Clang: Don't warn about unused private fields of types declared maybe_unused

aaron.ballman added a comment. Thank you for working on this! Mostly looks good, but I did have another test request. Also, please be sure to add a release note for the fix. Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:291-292 +enum [[maybe_unused]] MaybeUnused

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan added a comment. @ilya-biryukov I've updated the patch following your suggestion. PTAL, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 ___ cfe-

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

uabelho added a comment. I've no idea what's happening but it seems like linking compiler-rt/lib/memprof/tests/MemProfUnitTests fails with this commit: [17/17] Linking CXX executable compiler-rt/lib/memprof/tests/MemProfUnitTests FAILED: compiler-rt/lib/memprof/tests/MemProfUnitTests : &&

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 554285. zyounan added a comment. Oops, something went wrong accidently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files: clang-tools-extra/clangd/support/Thre

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

TWeaver added a comment. Good afternoon from the UK! It looks as though this change has caused the following buildbot to start failing: https://lab.llvm.org/buildbot/#/builders/216/builds/26407 are you able to take a look? Thanks in advance, Tom W Repository: rG LLVM Github Monorepo CHAN

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

aaron.ballman added a comment. Because the issues have been ongoing for a few hours now, I think it'd make sense to revert these changes while trying to determine what the appropriate fix is. @wangpc would you mind doing the revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D159018: [clang][modules] Add a c23 module feature

aaron.ballman accepted this revision. aaron.ballman added a comment. In D159018#4623880 , @v.g.vassilev wrote: > LGTM! > > In D159018#4622598 , @iana wrote: > >> Would we want to back port this to llvm 17? > > Ye

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

aaron.ballman added a comment. In D152752#4611206 , @aaron.ballman wrote: > In D152752#4611043 , @rnk wrote: > >> Thanks, I think this is a clang bug. As I understand MSVC's behavior, we >> should not pass highl

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554295. ldionne added a comment. Poke CI -- Phabricator keeps timing out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.y

[PATCH] D153690: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

michael-jabbour-sonarsource added a comment. The removal of the early return in this patch causes a crash when parsing the following example: struct S { bool operator==(int) const; }; void func() { S __unaligned s; s == 42; } See this Compiler Explorer link with a stacktr

[PATCH] D159090: [clang][dataflow][NFC] Remove obsolete references to `ReferenceValue` from comments.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `ReferenceValue` was removed in https://reviews.

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc added a comment. In D112921#4624674 , @aaron.ballman wrote: > Because the issues have been ongoing for a few hours now, I think it'd make > sense to revert these changes while trying to determine what the appropriate > fix is. @wangpc would you

[clang-tools-extra] a02f9a7 - Revert "[clang] Enable sized deallocation by default in C++14 onwards"

Author: Aaron Ballman Date: 2023-08-29T09:36:59-04:00 New Revision: a02f9a7756e5e4c76b422f9948d5dc3f56a1d139 URL: https://github.com/llvm/llvm-project/commit/a02f9a7756e5e4c76b422f9948d5dc3f56a1d139 DIFF: https://github.com/llvm/llvm-project/commit/a02f9a7756e5e4c76b422f9948d5dc3f56a1d139.diff

[clang] a02f9a7 - Revert "[clang] Enable sized deallocation by default in C++14 onwards"

Author: Aaron Ballman Date: 2023-08-29T09:36:59-04:00 New Revision: a02f9a7756e5e4c76b422f9948d5dc3f56a1d139 URL: https://github.com/llvm/llvm-project/commit/a02f9a7756e5e4c76b422f9948d5dc3f56a1d139 DIFF: https://github.com/llvm/llvm-project/commit/a02f9a7756e5e4c76b422f9948d5dc3f56a1d139.diff

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

aaron.ballman reopened this revision. aaron.ballman added a comment. >> In D112921#4624674 , >> @aaron.ballman wrote: >> Because the issues have been ongoing for a few hours now, I think it'd make >> sense to revert these changes while trying to determin

[PATCH] D159068: [clang][X86] Update excessive register save diagnostic to more closely follow the interrupt attribute spec

pengfei added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:317 + " with attribute 'no_caller_saved_registers'" + " or be compiled with '-mgeneral-regs-only'">, + InGroup>; aaron.ballman wrote: > Can you add a test case showing

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

stephenpeckham updated this revision to Diff 554299. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158739/new/ https://reviews.llvm.org/D158739 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/aix-common.c llvm/lib

[PATCH] D159068: [clang][X86] Update excessive register save diagnostic to more closely follow the interrupt attribute spec

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:317 + " with attribute 'no_caller_saved_registers'" + " or be compiled with '-mgeneral-regs-only'">, + InGroup>; pengfei wrote: > aaron.ballman wrote: > > Can you

[PATCH] D159092: [APINotes] Initial support for C++ namespaces

egorzhdan created this revision. egorzhdan added a reviewer: compnerd. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This upstreams a part of the C++ namespaces support in Clang API Notes. The compl

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne marked an inline comment as done. ldionne added inline comments. Comment at: .ci/generate-buildkite-pipeline-premerge:163 + +if [[ ! ${SPECIFIC_PIPELINE_AVAILABLE} -eq 1 ]]; then + # Figure out which projects need to be built on each platform goncharov w

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

Fznamznon added a comment. The failures in CI are unrelated and caused by another patch - https://reviews.llvm.org/D112921. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158615/new/ https://reviews.llvm.org/D158615 ___

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

aaron.ballman added reviewers: r4nt, sammccall. aaron.ballman added a comment. In D158872#4623193 , @danix800 wrote: > In D158872#4622124 , @aaron.ballman > wrote: > >> Are these matchers going to be used in-tree

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

DiggerLin accepted this revision. DiggerLin added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158739/new/ https://reviews.llvm.org/D158739 ___ cfe-commits mailing list cfe-com

[clang] bcc8811 - [clang] Emit an error if variable ends up with incomplete array type

Author: Podchishchaeva, Mariya Date: 2023-08-29T06:50:32-07:00 New Revision: bcc881161aeb56ea5a38858fe0007e59f21042c4 URL: https://github.com/llvm/llvm-project/commit/bcc881161aeb56ea5a38858fe0007e59f21042c4 DIFF: https://github.com/llvm/llvm-project/commit/bcc881161aeb56ea5a38858fe0007e59f2104

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcc881161aeb: [clang] Emit an error if variable ends up with incomplete array type (authored by Fznamznon). Repository: rG LLVM Github Monorepo C

[PATCH] D159068: [clang][X86] Update excessive register save diagnostic to more closely follow the interrupt attribute spec

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. I don't have prior experience about interrupt diagnostic but know something about mgeneral-regs-only. I think the diagnostic great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + -

[PATCH] D159083: Clang: Don't warn about unused private fields of types declared maybe_unused

hans updated this revision to Diff 554312. hans added a comment. Add release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159083/new/ https://reviews.llvm.org/D159083 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/warn-unused-private-f

[PATCH] D159083: Clang: Don't warn about unused private fields of types declared maybe_unused

hans added inline comments. Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:291-292 +enum [[maybe_unused]] MaybeUnusedEnum {}; +typedef int MaybeUnusedTypedef [[maybe_unused]]; +class C { + MaybeUnusedClass c; // no-warning aaron.ballman wrote: > Le

[clang] de0df63 - [CUDA][HIP] Fix overloading resolution in global variable initializer

Author: Yaxun (Sam) Liu Date: 2023-08-29T10:17:24-04:00 New Revision: de0df639724b10001ea9a74539381ea494296be9 URL: https://github.com/llvm/llvm-project/commit/de0df639724b10001ea9a74539381ea494296be9 DIFF: https://github.com/llvm/llvm-project/commit/de0df639724b10001ea9a74539381ea494296be9.dif

[PATCH] D158247: [CUDA][HIP] Fix overloading resolution in global variable initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde0df639724b: [CUDA][HIP] Fix overloading resolution in global variable initializer (authored by yaxunl). Herald added a project: clang. Repository:

[PATCH] D159083: Clang: Don't warn about unused private fields of types declared maybe_unused

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:291-292 +enum [[maybe_unused]] MaybeUnusedEnum {}; +typedef int MaybeUnusedTypedef [[maybe_unused]]; +class C { + MaybeUnusedClass c; // no-warning hans wrote: > aa

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews.llvm.org/D158803 ___ cfe-commits mailing list cfe-comm

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Changes LGTM, but should come with a release note. Comment at: clang/docs/LanguageExtensions.rst:3543-3544 the floating-point value, specified by the first arg

[PATCH] D159083: Clang: Don't warn about unused private fields of types declared maybe_unused

hans added inline comments. Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:291-292 +enum [[maybe_unused]] MaybeUnusedEnum {}; +typedef int MaybeUnusedTypedef [[maybe_unused]]; +class C { + MaybeUnusedClass c; // no-warning aaron.ballman wrote: > ha

[PATCH] D159083: Clang: Don't warn about unused private fields of types declared maybe_unused

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:291-292 +enum [[maybe_unused]] MaybeUnusedEnum {}; +typedef int MaybeUnusedTypedef [[maybe_un

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

shafik updated this revision to Diff 554345. shafik added a comment. - Add release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158808/new/ https://reviews.llvm.org/D158808 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/ParseExprCXX.cpp clang/test/Parser/cxx2a-template

[PATCH] D159083: Clang: Don't warn about unused private fields of types declared maybe_unused

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159083/new/ https://reviews.llvm.org/D159083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

dexonsmith added inline comments. Comment at: clang/lib/Headers/__stddef_null.h:14 + * __need_NULL and rely on stddef.h to redefine NULL to the correct value again. + * Modules don't support redefining macros like that, but support that pattern + * in the non-modules case. -

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner created this revision. bogner added reviewers: aaron.ballman, beanz. Herald added subscribers: Anastasia, mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This adds more

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12395-12398 + // TODO: This should probably just be llvm_unreachable and we should + // reject triples with random ABIs and such when we build the target. + // For now, crash. + llvm::report

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, donat.nagy, Szelethus. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revision. Herald

[PATCH] D159106: [analyzer] ArrayBoundCheckerV2 should listen to check::Bind as well

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, donat.nagy, Szelethus. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revision. Herald

[PATCH] D159107: [analyzer] ArrayBoundCheckerV2 should disallow forming lvalues to out-of-bounds locations

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, donat.nagy, Szelethus. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revision. Herald

[PATCH] D159108: [analyzer] CStringChecker should check the first byte of the destination of strcpy, strncpy

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, donat.nagy, Szelethus. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revision. Herald

[PATCH] D159109: [analyzer] CStringChecker buffer access checks should check the first bytes

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, donat.nagy, Szelethus. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revision. Herald

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

aaron.ballman added a comment. I think this is looking close to good, just had some minor nits and an extra test case to consider. Comment at: clang/lib/Sema/SemaExpr.cpp:17255 + // Check if these are compatible types according to the C rules even in C++ + // because va_arg

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

v.g.vassilev created this revision. v.g.vassilev added reviewers: lhames, sunho. Herald added a project: All. v.g.vassilev requested review of this revision. ORC splits into separate dylibs symbols coming from the process and symbols materialized in the Jit. This patch adapts intent of the existi

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1758 + *ToAttrLocOrErr); +} + At cases like this (many imported values) `importChecked` can be used, like at `VisitDependentSizedArrayType`. Comment at: clang/unitt

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. Otherwise LGTM! Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:96-100 + JITDylibSearchOrder O; + JITDylibLookupFlags Flags = JITDylibLookupFlags::MatchExportedSy

  1   2   3   >