[clang] 86258bd - [ORC][clang-repl] Fix another unit test after 122ebe3b500.

Author: Lang Hames Date: 2023-08-24T08:20:07-07:00 New Revision: 86258bda2016323d32efbe6a298654cd77cde644 URL: https://github.com/llvm/llvm-project/commit/86258bda2016323d32efbe6a298654cd77cde644 DIFF: https://github.com/llvm/llvm-project/commit/86258bda2016323d32efbe6a298654cd77cde644.diff LO

[clang-tools-extra] 109bc02 - [clangd] Add --query-driver flag to clangd-indexer

Author: Nathan Ridge Date: 2023-08-24T11:51:59-04:00 New Revision: 109bc024c8d741e57fa6bb5a028d8a4ed4e64a61 URL: https://github.com/llvm/llvm-project/commit/109bc024c8d741e57fa6bb5a028d8a4ed4e64a61 DIFF: https://github.com/llvm/llvm-project/commit/109bc024c8d741e57fa6bb5a028d8a4ed4e64a61.diff

[PATCH] D157990: [clangd] Add --query-driver flag to clangd-indexer

This revision was automatically updated to reflect the committed changes. Closed by commit rG109bc024c8d7: [clangd] Add --query-driver flag to clangd-indexer (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157990/new/ https://rev

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev accepted this revision. ABataev added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D157990: [clangd] Add --query-driver flag to clangd-indexer

nridge added a comment. Committed, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157990/new/ https://reviews.llvm.org/D157990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] a173edc - [NFC][Clang][RISCV] Move test case to its corret belonging

Author: eopXD Date: 2023-08-24T09:02:12-07:00 New Revision: a173edc987454927b95d6adefc4c36ccad294c97 URL: https://github.com/llvm/llvm-project/commit/a173edc987454927b95d6adefc4c36ccad294c97 DIFF: https://github.com/llvm/llvm-project/commit/a173edc987454927b95d6adefc4c36ccad294c97.diff LOG: [N

[PATCH] D158730: [DebugMetadata][DwarfDebug] Don't retain local types with -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Seems fine to me, but please triple check as the presubmit tests are failing. Perhaps you meant to mark this as a parent or child revision in phab with your other change, so that the presubmit builds know to apply both? See the box in the top right; Edit Related

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. @ldionne could you please upstream 9edb9a711503d540cf3126c0fde11ce9a0d9a7aa (I don't know what it is)? Alternatively I can figure out what to do with this test (it is just copies of the same te

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicExtent.cpp:92 + + return ElementCount.castAs(); +} donat.nagy wrote: > Are you sure that this cannot cause crashes? (E.g. did you check that there > is no corner case when `getElem

[clang] b9d78bd - [clang][modules] Use relative offsets for input files

Author: Jan Svoboda Date: 2023-08-24T09:16:04-07:00 New Revision: b9d78bdc730b2fcfe029a7579c24020536c3fa25 URL: https://github.com/llvm/llvm-project/commit/b9d78bdc730b2fcfe029a7579c24020536c3fa25 DIFF: https://github.com/llvm/llvm-project/commit/b9d78bdc730b2fcfe029a7579c24020536c3fa25.diff L

[clang] 7d15657 - [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

Author: Jan Svoboda Date: 2023-08-24T09:16:04-07:00 New Revision: 7d1565727dad3acb54fe76a908630843835d7bc8 URL: https://github.com/llvm/llvm-project/commit/7d1565727dad3acb54fe76a908630843835d7bc8 DIFF: https://github.com/llvm/llvm-project/commit/7d1565727dad3acb54fe76a908630843835d7bc8.diff L

[PATCH] D158572: [clang][modules] Use relative offsets for input files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d78bdc730b: [clang][modules] Use relative offsets for input files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D158573: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rG7d1565727dad: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file (authored by jansvobod

[clang] 4ad8913 - [NFC] Add checks for self-assignment.

Author: Sindhu Chittireddy Date: 2023-08-24T09:20:58-07:00 New Revision: 4ad89131e0de9368bc41395d770e1923366deba1 URL: https://github.com/llvm/llvm-project/commit/4ad89131e0de9368bc41395d770e1923366deba1 DIFF: https://github.com/llvm/llvm-project/commit/4ad89131e0de9368bc41395d770e1923366deba1.

[PATCH] D155776: [NFC] Add checks for self-assignment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ad89131e0de: [NFC] Add checks for self-assignment. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D158407: #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

sammccall added a comment. This simplification makes sense, but if we're adding the layer, we're missing an opportunity to apply it completely. (Intuitively, I don't see any reason that two passes is "enough") To do this, we'd want to simplify existing formulas when we learn something new. Curio

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 added a comment. In D158707#4614100 , @steakhal wrote: > As a general comment on requiring all extents to be of unsigned APSInts. > Checkers, like the `MallocChecker`, binds the result of arbitrary > expression's values (the argument of malloc,

[PATCH] D158730: [DebugMetadata][DwarfDebug] Don't retain local types with -fno-eliminate-unused-debug-types

dzhidzhoev added a comment. In D158730#4614172 , @nickdesaulniers wrote: > Seems fine to me, but please triple check as the presubmit tests are failing. > > Perhaps you meant to mark this as a parent or child revision in phab with > your other change, s

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

dyung added a comment. Hi @serge-sans-paille, the test you added seems to be failing on some bots. Can you take a look and revert if you need time to investigate? - https://lab.llvm.org/buildbot/#/builders/139/builds/48265 - https://lab.llvm.org/buildbot/#/builders/216/builds/26208 Repository:

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin marked 2 inline comments as done. yronglin added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubEx

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

steakhal added a comment. In D158707#4614268 , @danix800 wrote: > In D158707#4614100 , @steakhal > wrote: > >> As a general comment on requiring all extents to be of unsigned APSInts. >> Checkers, like the `Mallo

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 553179. saiislam marked 7 inline comments as done. saiislam added a comment. Updated test case to check internalization of newly inserted global variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/ne

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8649-8650 + // code-object-version=X needs to be passed to clang-linker-wrapper to ensure + // that it is used by lld. + if (const Arg *A = Args.getLastArg(options::OPT_mcode_object_version_EQ)

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:49 -static_assert(sizeof(AMDGPUImplicitArgsTy) == 56, - "Unexpected size of implicit arguments"); +enum IMPLICITARGS : uint32_t { + COV4_SIZE = 56, -

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:49 -static_assert(sizeof(AMDGPUImplicitArgsTy) == 56, - "Unexpected size of implicit arguments"); +enum IMPLICITAR

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:49 -static_assert(sizeof(AMDGPUImplicitArgsTy) == 56, - "Unexpected size of implicit arguments"); +enum IMPLICITARGS : uint32_t { + COV4_SIZE = 56, -

[clang] bfbea45 - Revert "[clang] - Add missing builtin name to AtomicExpr JSON dump"

Author: Douglas Yung Date: 2023-08-24T10:11:59-07:00 New Revision: bfbea459af391266cf6a4611f0da4952930d7834 URL: https://github.com/llvm/llvm-project/commit/bfbea459af391266cf6a4611f0da4952930d7834 DIFF: https://github.com/llvm/llvm-project/commit/bfbea459af391266cf6a4611f0da4952930d7834.diff

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan created this revision. shenhan added a reviewer: MaskRay. Herald added a subscriber: pengfei. Herald added a project: All. shenhan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, when clang reports an error when -fno-spl

[PATCH] D158695: [clang] Fix missing contract flag in sqrt intrinsic

rjmccall added a comment. Code change LGTM; I'll let you hash out the test feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158695/new/ https://reviews.llvm.org/D158695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik updated this revision to Diff 553195. shafik added a comment. - Silence -Wconstant-conversion warning in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-string.

[PATCH] D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA

argentite edited the summary of this revision. argentite updated this revision to Diff 553197. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151904/new/ https://reviews.llvm.org/D151904 Files: clang/unittests/Interpreter/CMakeLists.txt clang/uni

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

erichkeane added a comment. Still think a codegen test for this example is VERY valuable here. Comment at: clang/test/SemaCXX/constexpr-string.cpp:681 +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wconstant-conversion" +namespace GH64876 {

[PATCH] D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA

argentite added inline comments. Comment at: clang/unittests/Interpreter/InteractiveCudaTest.cpp:92 + std::unique_ptr Interp = createInterpreter(); + auto Err = Interp->LoadDynamicLibrary("libcudart.so"); + if (Err) { // CUDA runtime is not installed/usable, cannot continue te

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4613622 , @aaron.ballman wrote: > In D157572#4612141 , @cjdb wrote: > >> I don't dislike it, but I am a bit concerned about misuse being noisy. > > So you're concerned that a libr

[clang] 426c2c4 - [Driver][test] Clean up -fsplit-machine-function tests

Author: Fangrui Song Date: 2023-08-24T11:00:16-07:00 New Revision: 426c2c44b525dc52863de18d8a5c0f697f8c11e3 URL: https://github.com/llvm/llvm-project/commit/426c2c44b525dc52863de18d8a5c0f697f8c11e3 DIFF: https://github.com/llvm/llvm-project/commit/426c2c44b525dc52863de18d8a5c0f697f8c11e3.diff

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay added a comment. Thanks for the patch. We need a test. I cleaned up `fsplit-machine-functions.c` a bit. You can rebase and modify the `not %clang -### -c --target=arm-unknown-linux -fsplit-machine-functions -fno-split-machine-functions` RUN line in `clang/test/Driver/fsplit-machine-fun

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 553199. ZijunZhao added a comment. Rename the warn_overflow_builtin_can_not_be_short for precision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang/do

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik added inline comments. Comment at: clang/test/SemaCXX/constexpr-string.cpp:681 +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wconstant-conversion" +namespace GH64876 { erichkeane wrote: > rather than suppress these, it makes sense to m

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

erjin created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. erjin requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

erjin updated this revision to Diff 553217. erjin added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763 Files: clang/include/clang/Driver/Options.td flang/test/Driver/driver-hel

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan updated this revision to Diff 553219. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158755/new/ https://reviews.llvm.org/D158755 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/fsplit-machine-functions.c Index: clang/tes

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan added a comment. In D158755#4614566 , @MaskRay wrote: > Thanks for the patch. We need a test. I cleaned up > `fsplit-machine-functions.c` a bit. You can rebase and modify the `not %clang > -### -c --target=arm-unknown-linux -fsplit-machine-funct

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Phew, that completes my first pass through the review! I'm also adding @erichkeane as a reviewer now that he's off sabbatical. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9378-9381 + "

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We used to rely on the monorepo-wide premerge checks for running Clang tests, but I think it makes more sense to run the Cla

[PATCH] D158766: [AST] TypeSourceInfo for params of inherited constructor should be null

sammccall created this revision. sammccall added a reviewer: ymandel. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This matches behavior of other synthetic members like copy constructors, and avoids

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/constexpr-string.cpp:681 +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wconstant-conversion" +namespace GH64876 { shafik wrote: > erichkeane wrote: > > rather than suppress t

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

aaron.ballman added a comment. Thank you for working on this! Precommit CI found an issue with libc++'s tests: https://reviews.llvm.org/harbormaster/unit/view/8606248/ -- it'd be best if those could be addressed before landing the changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D158766: [AST] TypeSourceInfo for params of inherited constructor should be null

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:13895-13896 Context.getTrivialTypeSourceInfo(BaseCtor->getType(), UsingLoc); FunctionProtoTypeLoc ProtoLoc =

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

vvereschaka added a comment. Hi @serge-sans-paille, also on this builder: https://lab.llvm.org/buildbot/#/builders/60/builds/13587 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158558/new/ https://reviews.llvm.org/D158558

[PATCH] D158766: [AST] TypeSourceInfo for params of inherited constructor should be null

sammccall added a reviewer: aaron.ballman. sammccall marked 4 inline comments as done. sammccall added a subscriber: aaron.ballman. sammccall added a comment. +Aaron for guidance & in case I'm making things up, TypeLocs/TSI have always confused me... Comment at: clang/lib/Sema

[PATCH] D158766: [AST] TypeSourceInfo for params of inherited constructor should be null

sammccall updated this revision to Diff 553234. sammccall marked 2 inline comments as done. sammccall added a comment. address review comments, also null the TSI of the constructor itself Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158766/new/ ht

[clang] 7cabb54 - [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim

Author: Blue Gaston Date: 2023-08-24T13:11:54-07:00 New Revision: 7cabb54f3867867451368ce72928f76cf38831cb URL: https://github.com/llvm/llvm-project/commit/7cabb54f3867867451368ce72928f76cf38831cb DIFF: https://github.com/llvm/llvm-project/commit/7cabb54f3867867451368ce72928f76cf38831cb.diff L

[PATCH] D158570: [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7cabb54f3867: [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim (authored by Blue Gaston ). Reposito

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

ziqingluo-90 updated this revision to Diff 553226. ziqingluo-90 marked an inline comment as done. ziqingluo-90 edited the summary of this revision. ziqingluo-90 added a comment. In our offline discussion, we realized that `p = q.data()` is not always a correct fix to `p = q` for cases where only

[clang] a23bf17 - [clang] [MinGW] Pass LTO options to the linker

Author: Martin Storsjö Date: 2023-08-24T23:15:26+03:00 New Revision: a23bf1786be7c0738a4cf999c2957155bb32d5af URL: https://github.com/llvm/llvm-project/commit/a23bf1786be7c0738a4cf999c2957155bb32d5af DIFF: https://github.com/llvm/llvm-project/commit/a23bf1786be7c0738a4cf999c2957155bb32d5af.diff

[PATCH] D158411: [clang] [MinGW] Pass LTO options to the linker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa23bf1786be7: [clang] [MinGW] Pass LTO options to the linker (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya added a subscriber: nridge. hiraditya added a comment. Added previously reported issues shared by @nridge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 ___ cfe-commits mailing list cfe-co

[PATCH] D158771: [clang][tooling] Fix `name` range-selector to handle TypeLocs correctly.

ymandel created this revision. ymandel added reviewers: sammccall, li.zhe.hua. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Previously, where `name` was applied to a template-specialization TypeLoc, it returned the entire specialization (na

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

iana updated this revision to Diff 553242. iana added a comment. Fixed the failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158709/new/ https://reviews.llvm.org/D158709 Files: clang-tools-extra/clang-include-fixer/find-all-symbols/STLP

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions.c:19 +// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 | FileCheck %s --check-prefix=ERR2 +// ERR2: clang: error: unsupported option '-fsplit-machine-f

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2586 #endif it = FixablesForAllVars.byVar.erase(it); } else if (Tracker.hasUnclaimedUses(it->first)) { We cannot fix reference type variable declarations for

[PATCH] D158411: [clang] [MinGW] Pass LTO options to the linker

MaskRay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158411/new/ https://reviews.llvm.org/D158411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

hazohelet added a comment. In D158562#4614835 , @aaron.ballman wrote: > Thank you for working on this! > > Precommit CI found an issue with libc++'s tests: > https://reviews.llvm.org/harbormaster/unit/view/8606248/ -- it'd be best if > those could be a

[PATCH] D158771: [clang][tooling] Fix `name` range-selector to handle TypeLocs correctly.

li.zhe.hua accepted this revision. li.zhe.hua added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/RangeSelector.cpp:239-240 + !SpecLoc.isNull()) +return CharSourceRange::getTokenRange(SpecLoc.getTempla

[PATCH] D158775: [NFC] Initialize member pointer and avoid potential null dereference

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann. Herald added a reviewer: NoQ. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

hazohelet updated this revision to Diff 553246. hazohelet added a comment. Fixes `EstimateSizeFormatHandler`'s `%g` handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158562/new/ https://reviews.llvm.org/D158562 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diag

[PATCH] D158695: [clang] Fix missing contract flag in sqrt intrinsic

yaxunl updated this revision to Diff 553250. yaxunl added a comment. fix test for strict fp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158695/new/ https://reviews.llvm.org/D158695 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/fp-contract-fast-pragma.cpp Index: clang

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

brendandahl added a comment. @efriedma ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156172/new/ https://reviews.llvm.org/D156172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

ldionne updated this revision to Diff 553255. ldionne added a comment. Only run check-clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158765/new/ https://reviews.llvm.org/D158765 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan updated this revision to Diff 553256. shenhan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158755/new/ https://reviews.llvm.org/D158755 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/fsp

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions.c:19 +// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 | FileCheck %s --check-prefix=ERR2 +// ERR2: clang: error: unsupported option '-fsplit-machine-f

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, kerbowa, bixia, tpr, yaxunl, jvesely. Herald added a project: All. tra edited the summary of this revision. tra published this revision for review. tra added reviewers: jlebar, yaxunl. tra added a comment. Herald a

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

tra added a comment. Also, https://github.com/llvm/llvm-project/issues/46903 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158778/new/ https://reviews.llvm.org/D158778 ___ cfe-commits mailing list cfe-co

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. With a test nit Comment at: clang/test/Driver/fsplit-machine-functions.c:19 +// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 | F

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay added a comment. > Make "-fno-split-machine-functions" a valid flag for all archs. Driver changes usually are named `[Driver] ...`. The popular convention is to omit the full stop at the end of the subject. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D158775: [NFC] Initialize member pointer and avoid potential null dereference

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2243 const auto *CurrentFunction = dyn_cast(D); CurrentMethod = dyn_cast(D); It seems to me that `CurrentMethod` is unconditionally assigned a value here, before it is be

[PATCH] D158572: [clang][modules] Use relative offsets for input files

phosek added a comment. After this change, all libc++ `clang_modules_include.gen.py` tests started failing on our Linux builders: Script: -- : 'COMPILED WITH'; /b/s/w/ir/x/w/llvm_build/./bin/clang++ /b/s/w/ir/x/w/llvm_build/runtimes/runtimes-aarch64-unknown-linux-gnu-bins/test/libcxx/cla

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 added a comment. In D158572#4615198 , @phosek wrote: > After this change, all libc++ `clang_modules_include.gen.py` tests started > failing on our Linux builders: > > ... > > You can see the full output at > https://luci-milo.appspot.com/

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 added a comment. @phosek BTW can you confirm whether these started failing with this patch or with D158573 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158572/new/ https://reviews.llvm.org/D158572

[PATCH] D158572: [clang][modules] Use relative offsets for input files

phosek added a comment. In D158572#4615231 , @jansvoboda11 wrote: > @phosek BTW can you confirm whether these started failing with this patch or > with D158573 ? I'm trying to do a local build now to find out. Reposi

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158778/new/ https://reviews.llvm.org/D158778 ___

[clang] b6ba804 - Revert "[clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file"

Author: Jan Svoboda Date: 2023-08-24T14:43:23-07:00 New Revision: b6ba804f7775f89f230ee1e62526a2f8225c7966 URL: https://github.com/llvm/llvm-project/commit/b6ba804f7775f89f230ee1e62526a2f8225c7966 DIFF: https://github.com/llvm/llvm-project/commit/b6ba804f7775f89f230ee1e62526a2f8225c7966.diff L

[clang] 870f158 - Revert "[clang][modules] Use relative offsets for input files"

Author: Jan Svoboda Date: 2023-08-24T14:43:23-07:00 New Revision: 870f1583eed0f22ddfb1a1979a90198c3dc09927 URL: https://github.com/llvm/llvm-project/commit/870f1583eed0f22ddfb1a1979a90198c3dc09927 DIFF: https://github.com/llvm/llvm-project/commit/870f1583eed0f22ddfb1a1979a90198c3dc09927.diff L

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik updated this revision to Diff 553270. shafik marked 2 inline comments as done. shafik added a comment. - Add codegen test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGen/gh648

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

PiotrZSL marked an inline comment as done. PiotrZSL added a comment. I'm pushing this in current state, if you want to change something after that, fell free to do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158665/new/ https://reviews.llvm.

[clang-tools-extra] 0e2c5cd - [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

Author: Piotr Zegar Date: 2023-08-24T21:49:28Z New Revision: 0e2c5cda3cc713cac2cae651554fc070788760a6 URL: https://github.com/llvm/llvm-project/commit/0e2c5cda3cc713cac2cae651554fc070788760a6 DIFF: https://github.com/llvm/llvm-project/commit/0e2c5cda3cc713cac2cae651554fc070788760a6.diff LOG: [

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e2c5cda3cc7: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters… (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

fcloutier updated this revision to Diff 553271. fcloutier added a comment. It seems that clang allows `char` specifiers to match `bool` in `scanf` today, without my change (https://godbolt.org/z/e8PrjY65h). I think that this is a mistake, but that's almost certainly up for debate and I'd like to

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 553274. ZijunZhao added a comment. Prevent result type from being short and fix the breaking in builtinoverflow.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331

[PATCH] D126586: [InstrProf] Single byte counters in coverage

ayzhao added a comment. Thanks for your work on this! FYI, I'm getting the following crash when I try to build Chrome's base_unittests with `-mllvm -enable-single-byte-coverage=true`: [195/4447] CXX obj/base/allocator/partition_allocator/allocator_core/pcscan_internal.o FAILED: obj/base/a

[PATCH] D158787: llvm-project/issues/42451

MasterCopy8GB created this revision. MasterCopy8GB added a reviewer: llvm-commits. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. MasterCopy8GB requested review of this revision. Herald added a project: clang-tools-extra. Herald ad

[PATCH] D158787: llvm-project/issues/42451

PiotrZSL added a comment. - Missing documentation entry about this style. - Missing release notes entry - Commit title / description should be more in line with style used in project Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https:/

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 updated this revision to Diff 553285. ziqingluo-90 marked 2 inline comments as done. ziqingluo-90 added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153059/new/ https://reviews.llvm.org/D153059 Files: clang/include/clang/Analysis/Analyses/Uns

[clang] 7b27167 - [Driver] Make "-fno-split-machine-functions" a valid flag for all archs

Author: Han Shen Date: 2023-08-24T15:55:43-07:00 New Revision: 7b27167a57c5809e9936fe3c0920054009cb46f4 URL: https://github.com/llvm/llvm-project/commit/7b27167a57c5809e9936fe3c0920054009cb46f4 DIFF: https://github.com/llvm/llvm-project/commit/7b27167a57c5809e9936fe3c0920054009cb46f4.diff LOG:

[PATCH] D158755: [Driver] Make "-fno-split-machine-functions" a valid flag for all archs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b27167a57c5: [Driver] Make "-fno-split-machine-functions" a valid flag for all archs (authored by shenhan). Repository: rG LLVM Github Monorepo

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai updated this revision to Diff 553290. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158475/new/ https://reviews.llvm.org/D158475 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/Driver.cpp

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai updated this revision to Diff 553291. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.c

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

MaskRay added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1382 +return; +#if defined(__ANDROID__) + // ifunc resolvers don't have hwcaps in arguments on Android API lower enh wrote: > ilinpv wrote: > > MaskRay wrote: > > > I am unfamili

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

MasterCopy8GB updated this revision to Diff 553294. MasterCopy8GB added a comment. Update documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/docs/clang-tidy/checks

[PATCH] D158135: [Clang][CodeGen] Add __builtin_bcopy

shafik added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3567 + case Builtin::BI__builtin_bcopy: { +Address Dest = EmitPointerWithAlignment(E->getArg(1)); +Address Src = EmitPointerWithAlignment(E->getArg(0)); Maybe it is better to do th

<    1   2   3   >