erichkeane added a comment.
Still think a codegen test for this example is VERY valuable here.
================
Comment at: clang/test/SemaCXX/constexpr-string.cpp:681
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wconstant-conversion"
+namespace GH64876 {
----------------
rather than suppress these, it makes sense to me to just mark them
expected-warning.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158557/new/
https://reviews.llvm.org/D158557
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
