[PATCH] D158252: Fix regression of D157680

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG. IMHO such fixes to the tests can be committed without review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158252/new/ https://review

[PATCH] D158252: Fix regression of D157680

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158252/new/ https://reviews.llvm.org/D158252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. I reverted the change yesterday because the test wasn't passing on Windows, for example https://lab.llvm.org/buildbot/#/builders/216/builds/25769/steps/7/logs/FAIL__Clang__inline-virtual_cpp. The problem is that the JIT cannot find `??_7type_info@@6B@` related to RTTI.

[PATCH] D158252: Fix regression of D157680

XinWang10 added a comment. In D158252#4597933 , @Hahnfeld wrote: > LG. IMHO such fixes to the tests can be committed without review :) OK, Thanks for explanation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] b7cf9bb - Fix regression of D157680

Author: XinWang10 Date: 2023-08-18T00:12:10-07:00 New Revision: b7cf9bbfde5e623e16fe8669e18aa34cbb3afafa URL: https://github.com/llvm/llvm-project/commit/b7cf9bbfde5e623e16fe8669e18aa34cbb3afafa DIFF: https://github.com/llvm/llvm-project/commit/b7cf9bbfde5e623e16fe8669e18aa34cbb3afafa.diff LOG

[PATCH] D158252: Fix regression of D157680

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7cf9bbfde5e: Fix regression of D157680 (authored by XinWang10, committed by xin10.wang ). Repository: rG LLVM

[PATCH] D157953: [CGCall][RISCV] Handle function calls with parameter of RVV tuple type

kito-cheng added a comment. Herald added a subscriber: sunshaoce. LGTM, but I would like to wait few more days to make sure no other comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157953/new/ https://reviews.llvm.org/D157953 ___

[PATCH] D158242: [Clang][Attribute] Introduce linkage attribute to specify the exact LLVM linkage type for functions or variables

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. I understand that you're adding this for your project's internal purposes, but it's a permanent language feature that I don't think we want. Repository: rG LLVM Github Monorep

[PATCH] D157953: [CGCall][RISCV] Handle function calls with parameter of RVV tuple type

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5268 + assert(STy->containsHomogeneousScalableVectorTypes() && + "ABI only supports structure with hmogeneous scalable vector " + "type"); Homoge

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama created this revision. hchilama created this object with edit policy "Administrators". Herald added a project: All. hchilama requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama accepted this revision. hchilama added a comment. This revision is now accepted and ready to land. Using the split() instead of strtok to improve the performance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llv

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder added a comment. In D155568#4596497 , @vitalybuka wrote: > Breaks the bot > https://lab.llvm.org/buildbot/#/builders/74/builds/21336/steps/13/logs/stdio > > Please take a look or revert? > > Note: msan_track_origins step may have useful details.

[clang] c861d32 - [CodeGen] Keep track of eagerly emitted globals

Author: Jonas Hahnfeld Date: 2023-08-18T09:42:28+02:00 New Revision: c861d32d7c2791bdc058d9d9fbaecc1c2f07b8c7 URL: https://github.com/llvm/llvm-project/commit/c861d32d7c2791bdc058d9d9fbaecc1c2f07b8c7 DIFF: https://github.com/llvm/llvm-project/commit/c861d32d7c2791bdc058d9d9fbaecc1c2f07b8c7.diff

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc861d32d7c27: [CodeGen] Keep track of eagerly emitted globals (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. In D155627#4596321 , @aaron.ballman wrote: > In D155627#4595089 , @tbaeder wrote: > >> Having https://reviews.llvm.org/D144457 and https://reviews.llvm.org/D144457 >> approved would make

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:852 + return false; +return this->emitInitGlobalTempComp(TempDecl, E); } aaron.ballman wrote: > Should this still happen even if `TempDecl` is null? It looks like > `

[PATCH] D158257: [RISCV] Add feature checks for vector crypto C intrinsics

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, sunshaoce, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D158257: [RISCV] Add feature checks for vector crypto C intrinsics

4vtomat updated this revision to Diff 551419. 4vtomat added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158257/new/ https://reviews.llvm.org/D158257 Files: clang/include/clang/Basic/riscv_vector.td clang/include

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

tbaeder added subscribers: tuliom, tbaeder. tbaeder added a comment. CC @tstellar @tuliom since we use `GCC_INSTALL_PREFIX` at least in RHEL/CentOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158218/new/ https://reviews.llvm.org/D158218 ___

[clang] 673ef8c - Re-land "[clang][Interp] Make sure we push integers of the correct size"

Author: Timm Bäder Date: 2023-08-18T10:25:54+02:00 New Revision: 673ef8ceaece6c9a7194474ef7d97b3b240c0dc5 URL: https://github.com/llvm/llvm-project/commit/673ef8ceaece6c9a7194474ef7d97b3b240c0dc5 DIFF: https://github.com/llvm/llvm-project/commit/673ef8ceaece6c9a7194474ef7d97b3b240c0dc5.diff LO

[PATCH] D158046: [X86] Support -march=gracemont

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158046/new/ https://reviews.llvm.org/D158046

[PATCH] D158248: [clangd] Fix incorrect RecursiveASTVisitor usage in summarizeExpr()

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Oops, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158248/new/ https://reviews.llvm.org/D158248

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

nridge requested changes to this revision. nridge added a comment. This revision now requires changes to proceed. Ok, I've finished looking through the patch; sorry it took so long to get to. It generally looks pretty good to me, I just have some fairly minor comments. Thanks again for your work

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

DavidSpickett resigned from this revision. DavidSpickett added a comment. I do cross build lldb a lot but never needed to set either of these, so I have no opinion on this. > clang/cmake/caches/CrossWinToARMLinux.cmake Is not one of Linaro's, there's a buildbot for it (https://lab.llvm.org/bui

[clang] 09c5041 - Fix MSVC "'|': unsafe operation: no value of type '_Ty' promoted to type 'int' can equal the given constant" warning. NFC.

Author: Simon Pilgrim Date: 2023-08-18T09:43:46+01:00 New Revision: 09c5041911024c220a820369e17f76fe7fe2adee URL: https://github.com/llvm/llvm-project/commit/09c5041911024c220a820369e17f76fe7fe2adee DIFF: https://github.com/llvm/llvm-project/commit/09c5041911024c220a820369e17f76fe7fe2adee.diff

[clang] 25b9696 - [analyzer] Upstream BitwiseShiftChecker

Author: Donát Nagy Date: 2023-08-18T10:47:05+02:00 New Revision: 25b9696b61e53a958e217bb3d0eab66350dc187f URL: https://github.com/llvm/llvm-project/commit/25b9696b61e53a958e217bb3d0eab66350dc187f DIFF: https://github.com/llvm/llvm-project/commit/25b9696b61e53a958e217bb3d0eab66350dc187f.diff LO

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25b9696b61e5: [analyzer] Upstream BitwiseShiftChecker (authored by donat.nagy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2659-2664 + if (FromT == PT_Float) { +// Floating to floating. +if (ToT == PT_Float) { + const llvm::fltSemantics *ToSem = &Ctx.getFloatSema

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

tbaeder updated this revision to Diff 551434. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157596/new/ https://reviews.llvm.org/D157596 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/PrimType.h clang/test/AST/Interp/fl

[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/InlayHints.cpp:508 + // Only one of Callee or ProtoTypeLoc is set. + const FunctionDecl *Callee = nullptr; + FunctionProtoTy

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder updated this revision to Diff 551435. tbaeder marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Descriptor.h clang/lib/AST/Interp/

[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:466 +// so that we can recover argument names from it. +// FIXME: This function is mostly duplicated in SemaCodeComplete.cpp; unify. +static FunctionProtoTypeLoc getPrototypeLoc(Expr *Callee) { -

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D149236#4597600 , @nridge wrote: > Adding Sam, since you're on a review roll ;) back from vacation :-) Comment at: clang-

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

steakhal added a comment. 🎉 🚀 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://reviews.llvm.org/D156312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158265: [clang][AST] TextNodeDumper learned to output refers_to_enclosing_variable_or_capture flag for DeclRefExpr

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158265 File

[PATCH] D158266: Patch for Support to loop bind clause : Checking Parent Region

koops created this revision. koops added reviewers: ddpagan, ABataev, jdoerfert, dreachem, tianshilei1992, soumitra, RitanyaB, thakis. Herald added a project: All. koops requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. http

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551454. skatrak added a comment. Rebase patch to fix unrelated build error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime

[PATCH] D154382: [ClangRepl] support code completion at a REPL

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:341 + +/// Code completion at a top level in a REPL session. +CCC_TopLevelOrExpression

[clang] 3b28dce - [flang][driver] Mark the remaining Flang options as FlangOption

Author: Andrzej Warzynski Date: 2023-08-18T10:48:55Z New Revision: 3b28dce6daa4e70694cfe9df4526c9e6ee40b87e URL: https://github.com/llvm/llvm-project/commit/3b28dce6daa4e70694cfe9df4526c9e6ee40b87e DIFF: https://github.com/llvm/llvm-project/commit/3b28dce6daa4e70694cfe9df4526c9e6ee40b87e.diff

[PATCH] D158267: [clang][CodeGen] Avoid emitting unnecessary memcpy of records without content

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang codegen emits an unnecessary memcpy for C++ class without content. This patch fixes the issue. See https://githu

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon updated this revision to Diff 551460. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.org/D157879 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaInit.cpp clang

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

hans accepted this revision. hans added a comment. lgtm Maybe add a short release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158137/new/ https://reviews.llvm.org/D158137 ___ cfe-commits mailing

[PATCH] D158093: [Sema] Clean up ActionResult type a little. NFCI

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/include/clang/Sema/Ownership.h:204 + PtrTy get() const { +void *VP = reinterpret_cast(Value & ~0x01); +return PtrTraits::getFromVoidPointer(VP); kadircet wrote

[PATCH] D158093: [Sema] Clean up ActionResult type a little. NFCI

tbaeder added inline comments. Comment at: clang/include/clang/Sema/Ownership.h:180 - /// An opaque type for threading parsed type information through the - /// parser. - using ParsedType = OpaquePtr; - using UnionParsedType = UnionOpaquePtr; +// If we PtrTy has a free bit,

[clang] efe4a54 - [Sema] Clean up ActionResult type a little. NFCI

Author: Sam McCall Date: 2023-08-18T13:30:14+02:00 New Revision: efe4a54884cb1e5f1d6306f5e831d369c6fd6f54 URL: https://github.com/llvm/llvm-project/commit/efe4a54884cb1e5f1d6306f5e831d369c6fd6f54 DIFF: https://github.com/llvm/llvm-project/commit/efe4a54884cb1e5f1d6306f5e831d369c6fd6f54.diff LO

[PATCH] D158093: [Sema] Clean up ActionResult type a little. NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGefe4a54884cb: [Sema] Clean up ActionResult type a little. NFCI (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 30f0cd5 - [Sema] followups from efe4a54884cb

Author: Sam McCall Date: 2023-08-18T13:33:30+02:00 New Revision: 30f0cd55c614639ad5af7b32846cd4fea75d968e URL: https://github.com/llvm/llvm-project/commit/30f0cd55c614639ad5af7b32846cd4fea75d968e DIFF: https://github.com/llvm/llvm-project/commit/30f0cd55c614639ad5af7b32846cd4fea75d968e.diff LO

[clang] 9e11a6d - [Sema] Fix handling of functions that hide classes

Author: John Brawn Date: 2023-08-18T12:39:37+01:00 New Revision: 9e11a6d8fdd745f20bada10473b701d2e21492a5 URL: https://github.com/llvm/llvm-project/commit/9e11a6d8fdd745f20bada10473b701d2e21492a5 DIFF: https://github.com/llvm/llvm-project/commit/9e11a6d8fdd745f20bada10473b701d2e21492a5.diff LO

[PATCH] D158265: [clang][AST] TextNodeDumper learned to output refers_to_enclosing_variable_or_capture flag for DeclRefExpr

aaron.ballman added a comment. This adds quite a bit of output to the dump; given that the `DeclRefExpr` already links back to the `Decl` it refers to, do we actually need to expose this directly instead of letting users infer the relationship through pointer matching? Repository: rG LLVM G

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added a comment. I've committed an updated version of this that checks for invalid decls when deciding if a decl has been hidden. This stops the assertion failure happening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ http

[PATCH] D145648: [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas`

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wdng. LGTM, not recognizing this in the driver is incomplete CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145648/new/ https://reviews.llvm.org/D145648 ___

[PATCH] D158266: Patch for Support to loop bind clause : Checking Parent Region

ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:251 +/// or 'omp for' directive, otherwise - false. +bool isOpenMPForDirective(OpenMPDirectiveKind DKind); + What if the outer regioun is sections? Repository: rG LLVM Github M

[PATCH] D158266: Patch for Support to loop bind clause : Checking Parent Region

ABataev added a comment. Add tests for the nesting of regions to check all possible combinations correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158244/new/ https://reviews.llvm.org/D158244 ___

[PATCH] D158265: [clang][AST] TextNodeDumper learned to output refers_to_enclosing_variable_or_capture flag for DeclRefExpr

strimo378 added a comment. It is not that easy. It is an important flag for lambdas and it took me quite a while analyzing codegen to find it. In general, it is very seldom useful. OpenMP seems to have to good test coverage of ast-dump test cases. I think it is also used for nested C function t

[clang] 2e4d2d8 - Reapply "[DebugInfo] Alternate (more efficient) MD5 fix"

Author: Paul Robinson Date: 2023-08-18T05:24:00-07:00 New Revision: 2e4d2d800b9ce0924513a2f24e7a1f3d22b52383 URL: https://github.com/llvm/llvm-project/commit/2e4d2d800b9ce0924513a2f24e7a1f3d22b52383 DIFF: https://github.com/llvm/llvm-project/commit/2e4d2d800b9ce0924513a2f24e7a1f3d22b52383.diff

[PATCH] D158156: [analyzer] Add C++ array delete checker

donat.nagy added a comment. This checker is a straightforward, clean implementation of the SEI-CERT rule EXP51-CPP, it'll be a good addition to Static Analyzer. I'm satisfied with the implementation, although there might be others who have a more refined taste in C++ coding style. The only issu

[PATCH] D158269: [clang] Prevent possible use-after-free

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This prevents further parsing of tokens (that'll be freed) inside meth

[clang-tools-extra] 90ecadd - [include-cleaner] Filter references to identity macros

Author: Kadir Cetinkaya Date: 2023-08-18T14:40:03+02:00 New Revision: 90ecadde62f30275c35fdf7928e3477a41691d21 URL: https://github.com/llvm/llvm-project/commit/90ecadde62f30275c35fdf7928e3477a41691d21 DIFF: https://github.com/llvm/llvm-project/commit/90ecadde62f30275c35fdf7928e3477a41691d21.dif

[PATCH] D157905: [include-cleaner] Filter references to identity macros

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG90ecadde62f3: [include-cleaner] Filter references to identity macros (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D157905?vs=55079

[PATCH] D157879: [clang] Report missing designated initializers in C++

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.org/D157879

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing lis

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a testing nit. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2659-2664 + if (FromT == PT_Float) { +// Floating to floating. +if (ToT =

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

aaron.ballman added a comment. In D155627#4598032 , @tbaeder wrote: > In D155627#4596321 , @aaron.ballman > wrote: > >> In D155627#4595089 , @tbaeder >> wrote: >> >>> Ha

[PATCH] D152132: [clang][Interp] Fix lifetime diagnostics for dead records

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 ___ cfe-commits mailing lis

[PATCH] D158242: [Clang][Attribute] Introduce linkage attribute to specify the exact LLVM linkage type for functions or variables

aaron.ballman added a comment. In D158242#4597968 , @rjmccall wrote: > I understand that you're adding this for your project's internal purposes, > but it's a permanent language feature that I don't think we want. +1 -- I'm wary of exposing internal LLV

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! This is an NFC change that doesn't require additional testing because `CurEnd` is only used in an assertion, not for any of the function's semantics. Repository: rG LLVM

[PATCH] D158242: [Clang][Attribute] Introduce linkage attribute to specify the exact LLVM linkage type for functions or variables

strimo378 added a comment. > I'm wary of exposing internal LLVM implementation details through a > user-facing attribute like this. @aaron.ballman That means you would be more open to an attribute like `__attribute__((onedefinitionrule))` because it is part of the C++ standard? Repository:

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1797 +def NoUniqueAddressMSVC : InheritableAttr, TargetSpecificAttr { + let Spellings = [CXX11<"msvc", "no_unique_address", 201803>]; erichkeane wrote: > I think I would combin

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

donat.nagy added a comment. The results on open-source projects are depressing, but acceptable. This checker is looking for a serious defect, so it doesn't find any true positives on stable versions of open-source projects; however it produces a steady trickle of false positives because the Cla

[clang] 5956648 - Revert "Reapply "[DebugInfo] Alternate (more efficient) MD5 fix""

Author: Paul Robinson Date: 2023-08-18T06:35:34-07:00 New Revision: 5956648fc3ba11dd6b0d0f2d1d9b923e7f80f247 URL: https://github.com/llvm/llvm-project/commit/5956648fc3ba11dd6b0d0f2d1d9b923e7f80f247 DIFF: https://github.com/llvm/llvm-project/commit/5956648fc3ba11dd6b0d0f2d1d9b923e7f80f247.diff

[PATCH] D158265: [clang][AST] TextNodeDumper learned to output refers_to_enclosing_variable_or_capture flag for DeclRefExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Ah, I see where the complexity is now, thank you. In that case, this is reasonably helpful, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D158269: [clang] Prevent possible use-after-free

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks for getting to the bottom of this! Comment at: clang/lib/Parse/ParseObjc.cpp:3768 + // Clean up the remaining EOF token, only if it's inserted by

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

DavidSpickett added a comment. Failing on one of our 2 stage AArch64 bots https://lab.llvm.org/buildbot/#/builders/176/builds/4267 after the reland (that bot has been red for various reasons today, so no emails got sent). Maybe it helps to know that it doesn't fail on the same config with singl

[clang] 547ee1c - clang: Fix x86-no-gather-no-scatter.cpp on macOS after 993bdb047c90e9

Author: Nico Weber Date: 2023-08-18T09:46:11-04:00 New Revision: 547ee1c81fceaabcb7064ed525f11f9e94083f56 URL: https://github.com/llvm/llvm-project/commit/547ee1c81fceaabcb7064ed525f11f9e94083f56 DIFF: https://github.com/llvm/llvm-project/commit/547ee1c81fceaabcb7064ed525f11f9e94083f56.diff LO

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

thakis added inline comments. Comment at: clang/test/Driver/x86-no-gather-no-scatter.cpp:3 +// RUN: %clang -c -mno-gather -### %s 2>&1 | FileCheck --check-prefix=NOGATHER %s +// RUN: %clang_cl -c /Qgather- -### %s 2>&1 | FileCheck --check-prefix=NOGATHER %s +// NOGATHER: "-targ

[clang] 6cfbfb4 - [flang][driver] Add `-l` to the list of "visble" flags

Author: Andrzej Warzynski Date: 2023-08-18T13:48:23Z New Revision: 6cfbfb44cb8c140b1b74a3288ed32808bbc066d3 URL: https://github.com/llvm/llvm-project/commit/6cfbfb44cb8c140b1b74a3288ed32808bbc066d3 DIFF: https://github.com/llvm/llvm-project/commit/6cfbfb44cb8c140b1b74a3288ed32808bbc066d3.diff

[PATCH] D158279: clang: Make rewrite-includes-macros.cpp runnable on non-Win

thakis created this revision. thakis added a reviewer: aganea. Herald added a project: All. thakis requested review of this revision. As far as I can tell, there's nothing Windows-specific about the test and it passes fine on other platforms. I found this test when running rg clang_cl clang/te

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551497. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 551500. skatrak added a comment. Rebase and address conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib

[PATCH] D158265: [clang][AST] TextNodeDumper learned to output refers_to_enclosing_variable_or_capture flag for DeclRefExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd34e97c8a117: [clang][AST] TextNodeDumper learned to output… (authored by strimo378). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 551502. skatrak marked an inline comment as done. skatrak added a comment. Update to split generic MLIR into its own patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D14

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

steelannelida added a comment. Unfortunately the option -Wno-reserved-user-defined-literal fails after this: #define MYTHING "_something_" const char* f() { return "ONE"MYTHING"TWO"; } $ clang -Wno-reserved-user-defined-literal repro.cxx repro.cxx:4:15: error: no matching litera

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 551506. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib/Lower/Bridge.cpp fl

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

pscoro added a comment. Ping I will not be able to help out with flang (for a while) after the end of August so the sooner I can get this reviewed the smoother the landing process will be for myself and the community. So I would appreciate if I could get reviewers looking at this as soon as po

[clang] 851c248 - [clang] Prevent possible use-after-free

Author: Kadir Cetinkaya Date: 2023-08-18T16:27:57+02:00 New Revision: 851c248dfcdbf52ee88e4643e59453fcc13501d5 URL: https://github.com/llvm/llvm-project/commit/851c248dfcdbf52ee88e4643e59453fcc13501d5 DIFF: https://github.com/llvm/llvm-project/commit/851c248dfcdbf52ee88e4643e59453fcc13501d5.dif

[PATCH] D158269: [clang] Prevent possible use-after-free

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG851c248dfcdb: [clang] Prevent possible use-after-free (authored by kadircet). Changed prior to commit:

[PATCH] D158279: clang: Make rewrite-includes-macros.cpp runnable on non-Win

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. Sure. This was meant to catch an issue that only happened on Windows but it should work on all platforms. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158279/new/ https://rev

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot planned changes to this revision. robot marked 3 inline comments as done. robot added a comment. I'm working on the comments, but it will take a while. Comment at: clang-tools-extra/clangd/refactor/tweaks/DeclarePureVirtuals.cpp:58 + + const llvm::ArrayRef Tokens = +

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

rZhBoYao added a comment. In D153156#4598915 , @steelannelida wrote: > Unfortunately the option -Wno-reserved-user-defined-literal fails after this: > > #define MYTHING "_something_" > > const char* f() { > return "ONE"MYTHING"TWO"; > } > >

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

klausler added inline comments. Comment at: flang-rt/unittests/FortranEvaluate/testing.h:1 +#ifndef FORTRAN_EVALUATE_TESTING_H_ +#define FORTRAN_EVALUATE_TESTING_H_ Why was this file (and testing.cpp) added instead of being moved, like other files were? Why are

[PATCH] D158246: [amdgpu] WIP variadics

JonChesterfield added a comment. @arsenm suggested va_start/va_end should be addrspace aware, similar idea to https://reviews.llvm.org/D15. Should be less invasive for the va intrinsics as they're not used so widely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D158206: [Driver] Add PIE support on Solaris

ro marked 2 inline comments as done. ro added a comment. In D158206#4596471 , @MaskRay wrote: >> I'll submit a follow-up patch to make use of crtbeginS.o and crtendS.o >> shortly. > > I think this patch should make this change, so that the change is corr

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

pscoro added inline comments. Comment at: flang-rt/unittests/FortranEvaluate/testing.h:1 +#ifndef FORTRAN_EVALUATE_TESTING_H_ +#define FORTRAN_EVALUATE_TESTING_H_ klausler wrote: > Why was this file (and testing.cpp) added instead of being moved, like other > fi

[PATCH] D157838: [clang-repl] Disambiguate declarations with private typedefs

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:94 + // involve namespaces and friend declarations. + if (NextToken().is(tok::identifier)) +return true; I am wondering what is the false positive rat

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 ___ cfe

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/ https://reviews.llvm.org/D157350 ___ cfe

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:1129 template <> -struct has_function_signature : public std::true_type {}; +struct has_function_signature : public std::true_type { +}; Can we get rid of these types of changes to ke

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo htt

[PATCH] D157579: [clang][ExtractAPI] Add support for C++ global function templates

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/ExtractAPI/API.h:1077 : public std::true_type {}; +template <> +struct has_template : public std::true_type {}; Mega ni

  1   2   3   >