sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
LGTM, thanks! ================ Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:341 + + /// Code completion at a top level in a REPL session. + CCC_TopLevelOrExpression, ---------------- I think this is non-obvious & worthy of more explanation ``` /// Completion in a namespace or global scope, but also accept expressions. /// This occurs in REPL inputs, which may declare things or print expression /// values. ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
