[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

bob80905 added a comment. Shouldn't this new builtin be mentioned in Release Notes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156737/new/ https://reviews.llvm.org/D156737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D156565: Diagnose use of VLAs in C++ by default

Endill added a comment. In D156565#4547909 , @aaron.ballman wrote: > In D156565#4543503 , @aaron.ballman > wrote: > >> In D156565#4543414 , @jrtc27 wrote: >> >>> Given G

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Anastasia added inline comments. Comment at: llvm/unittests/TargetParser/TripleTest.cpp:1307 + EXPECT_TRUE(T.isSPIRV()); + T.setArch(Triple::spirv32); pmatos wrote: > Keenuts wrote: > > pmatos wrote: > > > I am not well-versed in SPIRV for gfx but if we are u

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cjdb added inline comments. Comment at: clang/test/SemaCXX/warn-constant-evaluated-constexpr.cpp:38 constexpr int fn5() { - if constexpr (__builtin_is_constant_evaluated()) // expected-warning {{'__builtin_is_constant_evaluated' will always evaluate to 'true' in a manifestly

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ye-luo, ABataev, RaviNarayanaswamy. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

jmciver added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:809-811 + Updater.AddAvailableValue( + Alloca.getParent(), + getInitialValueOfAllocation(&Alloca, nullptr, VectorTy)); arsenm wrote: > This is very specifically h

[PATCH] D157130: [RISCV] Check type size for lax conversions between RVV builtin types and VectorType::RVVFixedLengthDataVector.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157130/new/ https://reviews.llvm.org/D157130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman added a comment. In D156565#4580716 , @Endill wrote: > In D156565#4547909 , @aaron.ballman > wrote: > >> In D156565#4543503 , >> @aaron.ballman wrote: >> >

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra abandoned this revision. raghavendhra added a comment. setPropertyExecutionMode function is no longer present / used in clang because of a change in https://reviews.llvm.org/D142569 So abandoning this patch to migrate that function into OMPIRBuilder. Repository: rG LLVM Github M

[PATCH] D157747: Support Unicode Microsoft predefined macros

RIscRIpt created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, martong. Herald added a reviewer: shafik. Herald added a reviewer: njames93. Herald added a project: All. RIscRIpt requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a su

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

efriedma added a comment. Sure, diverging from MSVC here seems fine. I agree it's unlikely anyone would actually want to put a variable that will be modified in a "const" section. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -

[clang] c384e79 - [OpenMP][IR] Set correct alignment for internal variables

Author: Hao Jin Date: 2023-08-11T15:20:15-04:00 New Revision: c384e79675fe44cd2651dbd9d506d0a421c37533 URL: https://github.com/llvm/llvm-project/commit/c384e79675fe44cd2651dbd9d506d0a421c37533 DIFF: https://github.com/llvm/llvm-project/commit/c384e79675fe44cd2651dbd9d506d0a421c37533.diff LOG:

[PATCH] D157040: [OpenMP][IR] Set correct alignment for internal variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGc384e79675fe: [OpenMP][IR] Set correct alignment for internal variables (authored by erjin, committed by congzhe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

arsenm updated this revision to Diff 549490. arsenm added a comment. Release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156737/new/ https://reviews.llvm.org/D156737 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Builtins.def

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

efriedma added a comment. You can't, in general, check whether a type is stored in a no_unique_address field. Consider the following; the bad store is in the constructor S2, but the relevant no_unique_address attribute doesn't even show up until the definition of S3. struct S {}; S f();

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan created this revision. shenhan added reviewers: xur, snehasish. Herald added subscribers: mattd, asavonic, pengfei, hiraditya. Herald added a project: All. shenhan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang,

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2697 +bool SanitizeBuiltin = SanOpts.has(SanitizerKind::Builtin); +bool SanitizeOverflow = SanOpts.has(SanitizerKind::SignedIntegerOverflow); + artem wrote: > efriedma wrote: > >

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added a comment. In D157632#4580576 , @zequanwu wrote: > BTW, I noticed something strange with `-pgo-function-entry-coverage` when > merging via llvm-profdata. This is intentional. The two raw profiles individually store blocks as either covered

[clang] e789bcb - [clang][NFC] Robustify testcase

Author: Nathan Sidwell Date: 2023-08-11T15:59:52-04:00 New Revision: e789bcbb967f391d4f641bc8fa0403a45039a592 URL: https://github.com/llvm/llvm-project/commit/e789bcbb967f391d4f641bc8fa0403a45039a592 DIFF: https://github.com/llvm/llvm-project/commit/e789bcbb967f391d4f641bc8fa0403a45039a592.diff

[PATCH] D157661: [clang][NFC] Robustify testcase

This revision was automatically updated to reflect the committed changes. Closed by commit rGe789bcbb967f: [clang][NFC] Robustify testcase (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

snehasish added a subscriber: dhoekwater. snehasish added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1278 } -addPass(createMachineFunctionSplitterPass()); +if (TM->getTargetTriple().isX86()) + addPass(createMachineFunctionSplitterPass());

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

tra added a comment. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions We will

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo updated this revision to Diff 549517. mstorsjo added a comment. Updated to just check isEmptyRecord in EmitCall. The second part of the test probably is kinda redundant/pointless at this point, and I guess the test comment needs updating too; can do that later when the implementation i

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

efriedma added a comment. This approach looks fine. Comment at: clang/lib/CodeGen/CGCall.cpp:5781 // If the value is offset in memory, apply the offset now. + if (!isEmptyRecord(getContext(), RetTy, true)) { The isEmptyRecord call could use a comm

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana created this revision. iana added reviewers: aaron.ballman, rsmith, steplong, efriedma, jyknight, erichkeane. Herald added a subscriber: ributzka. Herald added a project: All. iana requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang.

[PATCH] D157747: Support Unicode Microsoft predefined macros

RIscRIpt added a comment. This implementation preserves support for identifiers `L__FUNCSIG__` and `L__FUNCTION__` (which have never been supported by MSVC), and adds other identifiers for all supported encodings: L, u8, u, U. If breaking backwards compatibility in clang (with Microsoft Extensi

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions t

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1278 } -addPass(createMachineFunctionSplitterPass()); +if (TM->getTargetTriple().isX86()) + addPass(createMachineFunctionSplitterPass()); snehasish wrote: > Can you

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

efriedma added inline comments. Comment at: clang/lib/Headers/stddef.h:112 #if defined(_MSC_EXTENSIONS) && defined(_NATIVE_NULLPTR_SUPPORTED) -namespace std { typedef decltype(nullptr) nullptr_t; } -using ::std::nullptr_t; +// __need_NULL would previously define nullptr_t for C+

[clang] 368a0ac - Revert part of "[test][asan] Disable new test from D157552 on Android"

Author: Vitaly Buka Date: 2023-08-11T15:07:29-07:00 New Revision: 368a0acea56e8f89860f5a64b4d0587bce6cff54 URL: https://github.com/llvm/llvm-project/commit/368a0acea56e8f89860f5a64b4d0587bce6cff54 DIFF: https://github.com/llvm/llvm-project/commit/368a0acea56e8f89860f5a64b4d0587bce6cff54.diff L

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 549534. iana added a comment. Don't define nullptr_t in C++ if __need_NULL is set without __need_nullptr_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 Files: clang

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked an inline comment as done. iana added inline comments. Comment at: clang/lib/Headers/stddef.h:112 #if defined(_MSC_EXTENSIONS) && defined(_NATIVE_NULLPTR_SUPPORTED) -namespace std { typedef decltype(nullptr) nullptr_t; } -using ::std::nullptr_t; +// __need_NULL would

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 ___

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked an inline comment as done. iana added inline comments. Comment at: clang/test/Headers/stddef.c:20-23 +// rsize_t will only be defined if __STDC_WANT_LIB_EXT1__ is set to >= 1. +// It would be nice to test the default undefined behavior, but that emits +// a note comin

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

tra added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions shenh

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added inline comments. Comment at: clang/test/Headers/stddefneeds.c:85-87 +// __need_nullptr_t generates an error in https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 ___ cfe-commits mailing list cfe-commits@

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

akhuang created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This attribute should match the behavior of MSVC's [[msvc::no_unique_address]] attr

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

arsenm added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1281-1282 +else + WithColor::warning() + << "-fsplit-machine-functions is only valid for X86.\n"; } You cannot spam warnings here. The other instance of printing

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

efriedma added inline comments. Comment at: clang/test/Headers/stddef.c:20-23 +// rsize_t will only be defined if __STDC_WANT_LIB_EXT1__ is set to >= 1. +// It would be nice to test the default undefined behavior, but that emits +// a note coming from stddef.h "rsize_t, did you m

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks! My concerns are addressed, but please confirm that Eli's are too. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -if (var->

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked an inline comment as done. iana added inline comments. Comment at: clang/test/Headers/stddef.c:20-23 +// rsize_t will only be defined if __STDC_WANT_LIB_EXT1__ is set to >= 1. +// It would be nice to test the default undefined behavior, but that emits +// a note comin

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rnk added a comment. What are the next steps here? Have concerns been addressed? The CI failures seem unrelated (libcxx tests is an AIX bot out of disk, clang CI is an interpreter test that seems unrelated, but please confirm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16899 + uint32_t CodePoint = static_cast(V.getInt().getZExtValue()); + PrintCharLiteralPrefix(BTy->getKind(), OS); + OS << '\''; cor3ntin wrote: >

[clang] 9e3d9c9 - clang: Add __builtin_elementwise_sqrt

Author: Matt Arsenault Date: 2023-08-11T19:32:39-04:00 New Revision: 9e3d9c9eae03910d93e2312e1e0845433c779998 URL: https://github.com/llvm/llvm-project/commit/9e3d9c9eae03910d93e2312e1e0845433c779998 DIFF: https://github.com/llvm/llvm-project/commit/9e3d9c9eae03910d93e2312e1e0845433c779998.diff

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

arsenm closed this revision. arsenm added a comment. 9e3d9c9eae03910d93e2312e1e0845433c779998 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156737/new/ https://reviews.llvm.org/D156737 __

[clang] d77c620 - [clang][AMDGPU]: Don't use byval for struct arguments in function ABI

Author: Changpeng Fang Date: 2023-08-11T16:37:42-07:00 New Revision: d77c62053c944652846c00a35c921e14b43b1877 URL: https://github.com/llvm/llvm-project/commit/d77c62053c944652846c00a35c921e14b43b1877 DIFF: https://github.com/llvm/llvm-project/commit/d77c62053c944652846c00a35c921e14b43b1877.diff

[PATCH] D155986: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd77c62053c94: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI (authored by cfang). Herald added a project: clang. Herald added

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 549547. iana marked an inline comment as done. iana added a comment. Update the tests to handle diagnostics from stddef.h Fix stddef.h to support defining __STDC_WANT_LIB_EXT1__ if stddef.h has already been included Repository: rG LLVM Github Monorepo CHANG

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

rnk added a comment. I think MSVC defines `_MSC_EXTENSIONS` under one of its compatibility modes as well, so it's not a good indicator of "is this compiler MSVC-like". I think we should be exposing the `__cpudex` builtin any time we are being MSVC-like, not under `fms-compatibility`. Would that

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16930-16936 +case BuiltinType::Char_S: +case BuiltinType::Char_U: +case BuiltinType::Char8: +case BuiltinType::Char16: +case BuiltinType::Char32: +

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman added a comment. The main issue here is that there's no way to reliably detect whether the built in is defined (can't check if a function is defined in the preprocessor, preprocessor macro isn't exposed correctly in all configurations), which ends up breaking some configurations.

[clang] 182de29 - Add argument to static_assert() call to work with compilers that default to c++14 or earlier.

Author: Douglas Yung Date: 2023-08-11T17:54:58-07:00 New Revision: 182de296f7bac49c655304d5c9f6b0edadf48302 URL: https://github.com/llvm/llvm-project/commit/182de296f7bac49c655304d5c9f6b0edadf48302 DIFF: https://github.com/llvm/llvm-project/commit/182de296f7bac49c655304d5c9f6b0edadf48302.diff

[PATCH] D157331: [clang] Implement C23

ZijunZhao added a comment. In D157331#4576540 , @aaron.ballman wrote: > In D157331#4575224 , @ZijunZhao > wrote: > >> Another followup question: I check >> https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2683

[PATCH] D155986: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI

JonChesterfield added a comment. Thanks! Happy to see function calls getting cheaper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155986/new/ https://reviews.llvm.org/D155986 ___ cfe-commits mailing lis

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

brad created this revision. brad added a reviewer: nielx. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Here is a first cut at moving the Haiku header search path management to the driver as has be

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

hubert.reinterpretcast added inline comments. Comment at: clang/test/Parser/c2x-attributes.c:29 +[[deprecated(L"abc")]] void unevaluated_string(void); +// expected-warning@-1 {{encoding prefix 'L' on an unevaluated string literal has no effec}} + "Typo" fix. =

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16899 + uint32_t CodePoint = static_cast(V.getInt().getZExtValue()); + PrintCharLiteralPrefix(BTy->getKind(), OS); + OS << '\''; hubert.reinterpre

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 549571. XinWang10 added a comment. - resolve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 marked 4 inline comments as done. XinWang10 added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoS

[clang] c053345 - [clang] Fix typos in documentation

Author: Kazu Hirata Date: 2023-08-11T21:44:33-07:00 New Revision: c053345b059bd3fa7f0e5f51498c71095b7a1d88 URL: https://github.com/llvm/llvm-project/commit/c053345b059bd3fa7f0e5f51498c71095b7a1d88 DIFF: https://github.com/llvm/llvm-project/commit/c053345b059bd3fa7f0e5f51498c71095b7a1d88.diff L

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 549572. iana added a comment. Let clang-format update stddef.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 Files: clang/lib/Headers/stddef.h clang/test/Headers/s

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo updated this revision to Diff 549575. mstorsjo added a comment. Move the existing comment into the new if statement, add a comment to the new if. Add a comment to the second part of the testcase, which probably is good to keep anyway. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo marked an inline comment as done. mstorsjo added a comment. Thanks a lot for the guidance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157332/new/ https://reviews.llvm.org/D157332 ___ cfe-comm

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoScatter XinWang10 wrote: > ska

<    1   2