[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/44176 Repository: rG LLVM Github Mono

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Comment at: clang/test/SemaCXX/constexpr-function-recovery-crash.cpp:81 +constexpr int test13() { do {} while (a < 10); return 0; } // expected-error

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

tbaeder added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1897-1898 if (Cond.isUsable()) -Cond = Actions.CorrectDelayedTyposInExpr(Cond); +Cond = Actions.CorrectDelayedTyposInExpr(Cond, /*InitDecl*/ nullptr, +

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

tbaeder updated this revision to Diff 547660. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157074/new/ https://reviews.llvm.org/D157074 Files: clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Interp.h clang/test/Misc/constexpr-source-ra

[PATCH] D157256: [clangd][clang-tidy][std_symbol_map] Add missing symbol.

VitaNuo created this revision. VitaNuo added a reviewer: kadircet. Herald added subscribers: carlosgalvezp, arphaman, xazax.hun. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Rep

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:221 TEST_F(FormatTestCSharp, CSharpFatArrows) { - verifyFormat("Task serverTask = Task.Run(async() => {"); + verifyIncompleteFormat("Task serverTask = Task.Run(async() => {"); veri

[PATCH] D157207: [clangd] Fix typo in comment

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! LMK if i should land this for you (and an email address to set as commit author) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15720

[PATCH] D157129: [NFC] Fix unnecessary copy with auto.

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. I went over the patch and I found only a single debatable case for taking by reference. To clarify why I would prefer taking by value: value semantics is good for local reasoning

[PATCH] D157227: [Clang] Don't add `undef` for `operator new` under -fno-exceptions.

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Removing noundef makes no sense to me, because the return value is noundef even under fno-exceptions. If we remove something, it should be the nonnull attribute, because that's what's

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Thanks for the update @asb. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142327/new/ https://reviews.llvm.org/D142327 ___ cfe-c

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

Fznamznon added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int x2[__builtin_offsetof(struct X2, X2::a) == 0 ? 1 : -1]; +int x3[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; // expected-error{{no member named 'X2'}} + It probably makes se

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

DavidSpickett added a comment. One of the kernel tests now fails to build for AArch64 and Arm: 00:00:48 ++ make CC=/home/tcwg-buildslave/workspace/tcwg_kernel_0/bin/aarch64-cc LD=/home/tcwg-buildslave/workspace/tcwg_kernel_0/llvm-install/bin/ld.lld SUBLEVEL=0 EXTRAVERSION=-bisect ARCH=arm64

[clang] 8a5c0cc - [clangd][clang-tidy][std_symbol_map] Add missing symbol.

Author: Viktoriia Bakalova Date: 2023-08-07T08:41:58Z New Revision: 8a5c0ccee2938dfec0082024aea664e7338adbe7 URL: https://github.com/llvm/llvm-project/commit/8a5c0ccee2938dfec0082024aea664e7338adbe7 DIFF: https://github.com/llvm/llvm-project/commit/8a5c0ccee2938dfec0082024aea664e7338adbe7.diff

[PATCH] D157256: [clangd][clang-tidy][std_symbol_map] Add missing symbol.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a5c0ccee293: [clangd][clang-tidy][std_symbol_map] Add missing symbol. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

hans added a comment. For those following along, this was relanded in https://reviews.llvm.org/D154007 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 ___ cfe-c

[clang] 52ac71f - [clang][analyzer] Improve StdCLibraryFunctions socket send/recv functions.

Author: Balázs Kéri Date: 2023-08-07T10:45:09+02:00 New Revision: 52ac71f92d38f75df5cb88e9c090ac5fd5a71548 URL: https://github.com/llvm/llvm-project/commit/52ac71f92d38f75df5cb88e9c090ac5fd5a71548 DIFF: https://github.com/llvm/llvm-project/commit/52ac71f92d38f75df5cb88e9c090ac5fd5a71548.diff L

[PATCH] D155715: [clang][analyzer] Improve StdCLibraryFunctions socket send/recv functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG52ac71f92d38: [clang][analyzer] Improve StdCLibraryFunctions socket send/recv functions. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D157227: [Clang] Don't add `undef` for `operator new` under -fno-exceptions.

DianQK added a comment. In D157227#4564817 , @nikic wrote: > Removing noundef makes no sense to me, because the return value is noundef > even under fno-exceptions. If we remove something, it should be the nonnull > attribute, because that's what's actu

[PATCH] D157262: [clang-tidy] Add support for in-class initializers in readability-redundant-member-init

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Support detecting red

[clang] e3c57fd - [clang][RISCV] Fix bug in ABI handling of empty structs with hard FP calling conventions in C++

Author: Alex Bradbury Date: 2023-08-07T10:45:22+01:00 New Revision: e3c57fdd8439ba82c67347629a3c66f293e1f3d0 URL: https://github.com/llvm/llvm-project/commit/e3c57fdd8439ba82c67347629a3c66f293e1f3d0 DIFF: https://github.com/llvm/llvm-project/commit/e3c57fdd8439ba82c67347629a3c66f293e1f3d0.diff

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3c57fdd8439: [clang][RISCV] Fix bug in ABI handling of empty structs with hard FP calling… (authored by asb). Changed prior to commit: https://reviews.llvm.org/D142327?vs=546012&id=547684#toc Reposito

[PATCH] D155858: Add a concept AST node.

cor3ntin added inline comments. Comment at: clang/include/clang/AST/ASTConcept.h:118 /// template arguments. -class ConceptReference { +class ConceptLoc { protected: hokein wrote: > I'm not sure the `ConceptLoc` is a reasonable name for this structure. > 1) In

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157074/new/ https://reviews.llvm.org/D157074 ___ cfe-commits mailing list cfe-co

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak updated this revision to Diff 547686. skatrak added a comment. Declare sets as `inline` inside of header file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157090/new/ https://reviews.llvm.org/D157090 Files: clang/docs/tools/clang-forma

[PATCH] D157238: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

balazske added a comment. `ASTImporter` part looks good, I did not check the generated documentation for correctness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157238/new/ https://reviews.llvm.org/D157238 _

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak added a comment. In D157090#4562088 , @kiranchandramohan wrote: > This looks OK. The only concern is whether we will lose the ability to inline > the code for set membership. Can these sets be put in a header file with > `inline constexpr`? Th

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. Thanks. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157090/new/ https://reviews.llvm.org/D157090 __

[clang] ec70627 - [Flang][Sema] Move directive sets to a shared location

Author: Sergio Afonso Date: 2023-08-07T11:18:43+01:00 New Revision: ec70627dd17703a2a12ce0f28bd3794aa77d2058 URL: https://github.com/llvm/llvm-project/commit/ec70627dd17703a2a12ce0f28bd3794aa77d2058 DIFF: https://github.com/llvm/llvm-project/commit/ec70627dd17703a2a12ce0f28bd3794aa77d2058.diff

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec70627dd177: [Flang][Sema] Move directive sets to a shared location (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 547696. sdesmalen added a comment. Added `enum AArch64SMECallConversionKind` to make it explicit when calling `IsInvalidSMECallConversion` whether or not 'preserves_za' can be dropped (e.g. in assignment), can be added (e.g. when overriding a parent method)

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen created this revision. sdesmalen added reviewers: rsandifo-arm, aaron.ballman. Herald added subscribers: ctetreau, hiraditya, kristof.beyls. Herald added a project: All. sdesmalen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen created this revision. sdesmalen added reviewers: rsandifo-arm, aaron.ballman. Herald added a subscriber: kristof.beyls. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The caller is required

[PATCH] D157245: [clang/cxx-interop] Teach clang to ignore availability errors that come from CF_OPTIONS

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Maybe we want this for the release/17.x branch too? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157245/new/ https://reviews.llvm.org/D157245 _

[PATCH] D128256: [Clang][AArch64] Limit arm_locally_streaming to function definitions only.

sdesmalen abandoned this revision. sdesmalen added a comment. This patch can be abandoned, since this is now properly implemented in D127762 as a declaration attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

yichi170 updated this revision to Diff 547703. yichi170 added a comment. updated ReleaseNotes and applied suggestions. The related issue #63443 is still not fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

PiotrZSL updated this revision to Diff 547704. PiotrZSL marked 10 inline comments as done. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. rebase, add support for dependent context, update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

rsandifo-arm abandoned this revision. rsandifo-arm added a comment. Superceded by D148700 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139028/new/ https://reviews.llvm.org/D139028 ___

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

PiotrZSL added inline comments. Comment at: test/clang-tidy/readability-container-size-empty.cpp:135 + // CHECK-FIXES: {{^ }}if (str.empty()){{$}} + if (str.length() == 0) +; MyDeveloperDay wrote: > could you add a test that checks if StringRef.str().leng

[PATCH] D157238: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

danix800 added a comment. In D157238#4565051 , @balazske wrote: > `ASTImporter` part looks good, I did not check the generated documentation > for correctness. Matcher part will be committed in https://reviews.llvm.org/D157237, these code is added here

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

SixWeining updated this revision to Diff 547711. SixWeining added a comment. add an extra check for when a candidate from detectFAREligibleStructHelper may not be valid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156116/new/ https://reviews.llvm

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

yronglin updated this revision to Diff 547712. yronglin added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157195/new/ https://reviews.llvm.org/D157195 Files: clang/lib/Parse/ParseStmt.cpp clang/test/AST/ast-dump-

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

yronglin marked 2 inline comments as done. yronglin added a comment. Thanks for your review! @hokein @tbaeder Comment at: clang/lib/Parse/ParseStmt.cpp:1897-1898 if (Cond.isUsable()) -Cond = Actions.CorrectDelayedTyposInExpr(Cond); +Cond = Actions.CorrectDelayedTypos

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

yichi170 added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int x2[__builtin_offsetof(struct X2, X2::a) == 0 ? 1 : -1]; +int x3[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; // expected-error{{no member named 'X2'}} + Fznamznon wrote: > It

[clang] 4d3e917 - [Clang] Make __arm_streaming apply only to prototyped functions.

Author: Sander de Smalen Date: 2023-08-07T11:31:44Z New Revision: 4d3e91783938291cc53880a0e6c0689b8f2b2970 URL: https://github.com/llvm/llvm-project/commit/4d3e91783938291cc53880a0e6c0689b8f2b2970 DIFF: https://github.com/llvm/llvm-project/commit/4d3e91783938291cc53880a0e6c0689b8f2b2970.diff L

[PATCH] D152141: [Clang] Make __arm_streaming apply only to prototyped functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d3e91783938: [Clang] Make __arm_streaming apply only to prototyped functions. (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152141/

[PATCH] D155978: [SPIR-V] Add SPIR-V logical triple.

Keenuts created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. Keenuts updated this revision to Diff 544701. Keenuts added a comment. Herald added a subscriber: pmatos. Keenuts updated this revision to Diff 544703. Keenuts updated this revision to Diff 547682. Kee

[PATCH] D155978: [SPIR-V] Add SPIR-V logical triple.

Keenuts updated this revision to Diff 547722. Keenuts added a comment. Herald added subscribers: wangpc, s.egerton, simoncook, asb, fedor.sergeev, aheejin, dschuff, rampitec. git-clang-format on changed files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D157229: Fix edge case in declare target initializer expression

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157229/new/ https://reviews.llvm.org/D157229 ___

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 ___

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. As described in Issue #53709

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet added a comment. I've noticed several shortcoming/limitations of this patch. 1. Function arguments: When we parse the arguments to a function call, the callee isn't still resolved, so we don't know whether it's consteval. If the callee is consteval, its argument is known to be constan

[PATCH] D157238: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

balazske added a comment. In D157238#4565260 , @danix800 wrote: > In D157238#4565051 , @balazske > wrote: > >> `ASTImporter` part looks good, I did not check the generated documentation >> for correctness. > > M

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

cor3ntin added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int x2[__builtin_offsetof(struct X2, X2::a) == 0 ? 1 : -1]; +int x3[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; // expected-error{{no member named 'X2'}} + yichi170 wrote: > Fzn

[PATCH] D157207: [clangd] Fix typo in comment

Eymay added a comment. Thanks @kadircet. Can you land this patch for me? Please use “Eymen Ünay eymenu...@outlook.com" to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157207/new/ https://reviews.llvm.org/D157207 __

[clang] 7f00389 - [OpenCL] Fix grammar in test error messages; NFC

Author: Sven van Haastregt Date: 2023-08-07T13:45:23+01:00 New Revision: 7f00389e7792d585cdda615324ebc094fa3c4247 URL: https://github.com/llvm/llvm-project/commit/7f00389e7792d585cdda615324ebc094fa3c4247 DIFF: https://github.com/llvm/llvm-project/commit/7f00389e7792d585cdda615324ebc094fa3c4247.

[PATCH] D157237: [clang][ASTMatcher] Add Matcher 'dependentSizedExtVectorType'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157237/new/ https://reviews.llvm.org/D157237

[PATCH] D157248: [clang][ASTMatcher] Add Matcher 'convertVectorExpr'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157248/new/ https://reviews.llvm.org/D157248

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

jhuber6 added a comment. In D156928#4562239 , @JonChesterfield wrote: > Or, the front end could define those objects directly, without importing IR > files that define the objects with the content clang used to choose the > object file. E.g. instead of

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 547751. saiislam marked 5 inline comments as done. saiislam added a comment. Removed unused cov5 implicitargs fields. Added comments about EmitAMDGPUWorkGroupSize and ABI-agnostica code emission. Adressed reviewers' comments. Repository: rG LLVM Github Mo

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added a comment. In D139730#4561622 , @arsenm wrote: > In D139730#4561619 , @arsenm wrote: > >> In D139730#4561575 , @jhuber6 >> wrote: >> >>> In D139730#4561573

[clang] 4097a24 - [Clang][OpenMP] Support for Code Generation of loop bind clause

Author: Sunil Kuravinakop Date: 2023-08-07T07:58:59-05:00 New Revision: 4097a24584121dba562d471fab97d3dfec1b5bff URL: https://github.com/llvm/llvm-project/commit/4097a24584121dba562d471fab97d3dfec1b5bff DIFF: https://github.com/llvm/llvm-project/commit/4097a24584121dba562d471fab97d3dfec1b5bff.d

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

saiislam added a comment. In D156928#4565506 , @jhuber6 wrote: > In D156928#4562239 , > @JonChesterfield wrote: > >> Or, the front end could define those objects directly, without importing IR >> files that defi

[PATCH] D157249: [clang][ASTImporter] Add import of 'ConvertVectorExpr'

aaron.ballman added a comment. > Depends on https://reviews.llvm.org/D157248 FWIW, this would usually be done via a "patch stack": https://kurtisnusbaum.medium.com/stacked-diffs-keeping-phabricator-diffs-small-d9964f4dcfa6 so that it's clear which changes are part of this patch and which change

[PATCH] D157200: [clang][Interp] Visit Logical-not operand as bool

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a testing request. Comment at: clang/test/AST/Interp/c.c:12-13 _Static_assert( (5 > 4) + (3 > 2) == 2, ""); +_Static_assert(!!1.0, ""); +_Static_asse

[PATCH] D157174: [clang][Interp] Convert logical binop operands to bool

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:531-534 + // For C, cast back to integer type. + assert(T); + if (T != PT_Bool) +return this->emitCast(PT_Bool, *T, E); This is casting to boolean type, not integer t

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: MaskRay, davidxl, w2yehia. Herald added subscribers: wlei, ormris, wenlei, hiraditya. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17138 +///and use its value for COV_4 or COV_5 approach. It is used for +///compiling device libraries in ABI-agnostic way. +/// Comment at: cla

[PATCH] D157174: [clang][Interp] Convert logical binop operands to bool

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:531-534 + // For C, cast back to integer type. + assert(T); + if (T != PT_Bool) +return this->emitCast(PT_Bool, *T, E); aaron.ballman wrote: > This is casting to boolean ty

[PATCH] D157174: [clang][Interp] Convert logical binop operands to bool

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:531-534 + // For C, cast back to integer type. + assert(T); + if (T != PT_Bool) +return this->e

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

rsandifo-arm added a comment. The intent looks good to me, but I'm not in a position to approve. Very pedantic, sorry, but on the description, I think: > Calls from non-streaming functions to streaming-functions require the > compiler to enable/disable streaming-SVE mode around the call-site.

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

yichi170 updated this revision to Diff 547764. yichi170 marked an inline comment as not done. yichi170 added a comment. updated test in `test/SemaCXX/offsetof.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157201/new/ https://reviews.llvm.org/D

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

rsandifo-arm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6737 +else if (const auto *FPT = CallerFD->getType()->getAs()) + CallerHasZAState |= FPT->getExtProtoInfo().AArch64SMEAttributes & + FunctionType::SME_PS

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

aaron.ballman added a comment. Precommit CI found a related issue that should be addressed. Comment at: clang/www/cxx_dr_status.html:4376 Can nullptr be passed to an ellipsis? -Unknown +Clang 17 MitalAshok wrote: > It may be better to mark this

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw updated this revision to Diff 547767. sstwcw marked 2 inline comments as done. sstwcw added a comment. - Add tests for code in JavaScript template strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D15

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:221 TEST_F(FormatTestCSharp, CSharpFatArrows) { - verifyFormat("Task serverTask = Task.Run(async() => {"); + verifyIncompleteFormat("Task serverTask = Task.Run(async() => {"); verifyFormat

[clang] 4cce27d - [clang][ASTMatcher] Add Matcher 'dependentSizedExtVectorType'

Author: dingfei Date: 2023-08-07T21:50:42+08:00 New Revision: 4cce27d9184ed5a71e296c8a18a603ec3e23b06d URL: https://github.com/llvm/llvm-project/commit/4cce27d9184ed5a71e296c8a18a603ec3e23b06d DIFF: https://github.com/llvm/llvm-project/commit/4cce27d9184ed5a71e296c8a18a603ec3e23b06d.diff LOG:

[PATCH] D157237: [clang][ASTMatcher] Add Matcher 'dependentSizedExtVectorType'

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cce27d9184e: [clang][ASTMatcher] Add Matcher 'dependentSizedExtVectorType' (authored by dingfei ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw updated this revision to Diff 547770. sstwcw added a comment. - Add tests for code in JavaScript template strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyl

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

rsandifo-arm accepted this revision. rsandifo-arm added a comment. LGTM too, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127762/new/ https://reviews.llvm.org/D127762 ___ cfe-commits mailing lis

[clang] 8baf862 - [clang][ASTMatcher] Add Matcher 'convertVectorExpr'

Author: dingfei Date: 2023-08-07T21:53:14+08:00 New Revision: 8baf86275639ec332408f1e1fac0066e4f0788d2 URL: https://github.com/llvm/llvm-project/commit/8baf86275639ec332408f1e1fac0066e4f0788d2 DIFF: https://github.com/llvm/llvm-project/commit/8baf86275639ec332408f1e1fac0066e4f0788d2.diff LOG:

[PATCH] D157248: [clang][ASTMatcher] Add Matcher 'convertVectorExpr'

This revision was automatically updated to reflect the committed changes. Closed by commit rG8baf86275639: [clang][ASTMatcher] Add Matcher 'convertVectorExpr' (authored by dingfei ). Changed prior to commit: https://reviews.llvm.org/D157248?vs=547625&id=547771#toc Repository:

[clang] bb58748 - [clang/cxx-interop] Teach clang to ignore availability errors that come from CF_OPTIONS

Author: zoecarver Date: 2023-08-07T09:56:25-04:00 New Revision: bb58748e52ebd48a46de20525ef2c594db044a11 URL: https://github.com/llvm/llvm-project/commit/bb58748e52ebd48a46de20525ef2c594db044a11 DIFF: https://github.com/llvm/llvm-project/commit/bb58748e52ebd48a46de20525ef2c594db044a11.diff LOG

[PATCH] D152275: Use memory region declaration intrinsic when generating code for array subscripts

simeon updated this revision to Diff 547763. simeon added a comment. Herald added subscribers: llvm-commits, kmitropoulou, ChuanqiXu, pengfei, asbirlea, haicheng, hiraditya, jvesely. Herald added a project: LLVM. The patch now includes the changes that need to be made to the optimization passes

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157245: [clang/cxx-interop] Teach clang to ignore availability errors that come from CF_OPTIONS

thakis closed this revision. thakis added a comment. bb58748e52ebd48a46de20525ef2c594db044a11 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157245/new/ https://reviews.llvm.org/D157245 __

[PATCH] D157245: [clang/cxx-interop] Teach clang to ignore availability errors that come from CF_OPTIONS

thakis added a comment. In D157245#4565166 , @hans wrote: > lgtm Thanks! > Maybe we want this for the release/17.x branch too? Sure, trying that here: https://github.com/llvm/llvm-project/issues/64496 CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D157249: [clang][ASTImporter] Add import of 'ConvertVectorExpr'

danix800 added a comment. In D157249#4565580 , @aaron.ballman wrote: >> Depends on https://reviews.llvm.org/D157248 > > FWIW, this would usually be done via a "patch stack": > https://kurtisnusbaum.medium.com/stacked-diffs-keeping-phabricator-diffs-smal

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: ldionne, dexonsmith, MaskRay. DmitryPolukhin added a project: clang. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a subscriber: cfe-commits. See discussion in https://reviews.llvm.o

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske updated this revision to Diff 54. balazske added a comment. Herald added a subscriber: wangpc. Using the latest version of the checker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152436/new/ https://reviews.llvm.org/D152436 Files:

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

DmitryPolukhin added a comment. @dexonsmith thank you for quick response. I think we need to update upstream behaviour to match system compiler behaviour otherwise clang-tools that uses path to compiler binary form CDB will not work as expected and extra options won't help much because it is no

[PATCH] D157285: [clang-tidy] Add support for lambdas in cppcoreguidelines-owning-memory

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93, ccotter. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D157249: [clang][ASTImporter] Add import of 'ConvertVectorExpr'

danix800 updated this revision to Diff 547781. danix800 added a comment. Cleanup since D157248 is landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157249/new/ https://reviews.llvm.org/D157249 Files: clang/

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen updated this revision to Diff 547782. sdesmalen marked 4 inline comments as done. sdesmalen added a comment. - Renamed `sme` to `'sme'` to make it clear that it relates to the target feature - Split `function executed in streaming-SVE mode or using ZA state, requires sme` into: - `fu

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

dexonsmith resigned from this revision. dexonsmith added subscribers: arphaman, jroelofs. dexonsmith added a comment. This looks correct to me, but I'd rather have someone at Apple confirm. @ldionne (or @arphaman or @jroelofs), can you review and/or help to find the right person? Repository:

[PATCH] D157238: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

danix800 updated this revision to Diff 547783. danix800 added a comment. Cleanup since D157237 is landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157238/new/ https://reviews.llvm.org/D157238 Files: clang/

[PATCH] D157238: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

danix800 added a comment. In D157238#4565442 , @balazske wrote: > In D157238#4565260 , @danix800 > wrote: > >> In D157238#4565051 , @balazske >> wrote: >> >>> `ASTImport

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK rsandifo-arm wrote: > Would be good to have some tests for indirect function calls too (via > function pointers

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. In D157119#4564546 , @vitalybuka wrote: > I suspect one of your recent changes broke > https://lab.llvm.org/buildbot/#/builders/168/builds/14944 > Can you please take a look? Happy to take a look, but there are 28 commits in t

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. In D156749#4562469 , @vsapsai wrote: > In D156749#4561803 , @jansvoboda11 > wrote: > >> My suggestion is to use the actual real on-disk path. Not

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

dexonsmith added a comment. SGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89001/new/ https://reviews.llvm.org/D89001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

  1   2   3   >