PiotrZSL added inline comments.
================
Comment at: test/clang-tidy/readability-container-size-empty.cpp:135
+ // CHECK-FIXES: {{^ }}if (str.empty()){{$}}
+ if (str.length() == 0)
+ ;
----------------
MyDeveloperDay wrote:
> could you add a test that checks if StringRef.str().length() >0 becomes
> !StringRef.str.empty()
>
> e.g.
>
>
> ```
> LLVM::StringRef ArgRef;
> ....
> return (ArgRef.str().length() > 0) ? ArgRef.str() + ")" : "()";
> ```
No point, should work anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56644/new/
https://reviews.llvm.org/D56644
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
