[clang] 7d876c6 - [clang][Interp] Add 'Invalid' opcode and use it for throw stmts

Author: Timm Bäder Date: 2023-07-26T08:59:53+02:00 New Revision: 7d876c62a306fe09a69a5a923c757d2cae305d0c URL: https://github.com/llvm/llvm-project/commit/7d876c62a306fe09a69a5a923c757d2cae305d0c DIFF: https://github.com/llvm/llvm-project/commit/7d876c62a306fe09a69a5a923c757d2cae305d0c.diff LO

[PATCH] D150364: [clang][Interp] Add 'Invalid' opcode and use it for throw/asm stmts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d876c62a306: [clang][Interp] Add 'Invalid' opcode and use it for throw stmts (authored by tbaeder). Changed prior to commit: https://reviews.llvm

[clang] 3b48613 - [docs] [C++20] [Modules] Mark the compatiblity issue within clang-cl.exe

Author: Chuanqi Xu Date: 2023-07-26T15:06:13+08:00 New Revision: 3b48613f2d90bde544669437c20fcdeb01316411 URL: https://github.com/llvm/llvm-project/commit/3b48613f2d90bde544669437c20fcdeb01316411 DIFF: https://github.com/llvm/llvm-project/commit/3b48613f2d90bde544669437c20fcdeb01316411.diff LO

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 544228. fakepaper56 added a comment. Address Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/riscv-target-featur

[clang] 7a3ad8e - [clang] Provide source range to 'invalid subexpr in const expr' diags

Author: Timm Bäder Date: 2023-07-26T09:12:11+02:00 New Revision: 7a3ad8ed77eef2e9ac218dd5161dda5fab1238b6 URL: https://github.com/llvm/llvm-project/commit/7a3ad8ed77eef2e9ac218dd5161dda5fab1238b6 DIFF: https://github.com/llvm/llvm-project/commit/7a3ad8ed77eef2e9ac218dd5161dda5fab1238b6.diff LO

[PATCH] D150566: [clang] Provide source range to 'invalid subexpr in const expr' diags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a3ad8ed77ee: [clang] Provide source range to 'invalid subexpr in const expr' diags (authored by tbaeder). Repository: rG LLVM Github Monorepo CH

[clang] 907fb33 - [Clang][AArch64] Fix up immediate range of f64f64 mopa/mops intrinsics

Author: Sander de Smalen Date: 2023-07-26T07:13:18Z New Revision: 907fb338a2df8fe0f41ddace487b05661ecdc6aa URL: https://github.com/llvm/llvm-project/commit/907fb338a2df8fe0f41ddace487b05661ecdc6aa DIFF: https://github.com/llvm/llvm-project/commit/907fb338a2df8fe0f41ddace487b05661ecdc6aa.diff L

[PATCH] D156128: [Clang][AArch64] Fix up immediate range of f64f64 mopa/mops intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG907fb338a2df: [Clang][AArch64] Fix up immediate range of f64f64 mopa/mops intrinsics (authored by sdesmalen). Repository: rG LLVM Github Monorepo

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 544235. RIscRIpt marked an inline comment as done. RIscRIpt added a comment. Rename MicrosoftStringLiteralFromPredefined Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D1539

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added a comment. Thank you for the review! I apologize for missing the small details; I should have noticed and addressed them myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D153914 ___

[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

eopXD added inline comments. Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:136 case Invalid: + case Undefined: llvm_unreachable("Unhandled type."); Could we just reuse `Invalid`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b2e6516 - [clang][Interp][NFC] Return std::nullopt explicitly from classify()

Author: Timm Bäder Date: 2023-07-26T09:34:26+02:00 New Revision: b2e6516fd1abdd9416c6085102523d577c8a2238 URL: https://github.com/llvm/llvm-project/commit/b2e6516fd1abdd9416c6085102523d577c8a2238 DIFF: https://github.com/llvm/llvm-project/commit/b2e6516fd1abdd9416c6085102523d577c8a2238.diff LO

[PATCH] D156254: [clang][dataflow] Add convenience function for analysing and `FunctionDecl` and diagnosing it.

mboehme accepted this revision. mboehme added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:244 +/// Runs a dataflow analysis over the given function and then runs `Diagnoser` +/// ove

[clang] c725138 - [clang][Interp] Check pointers for live-ness when returning them

Author: Timm Bäder Date: 2023-07-26T09:52:09+02:00 New Revision: c7251385c85ddcc1059548038e60099fcc5b304c URL: https://github.com/llvm/llvm-project/commit/c7251385c85ddcc1059548038e60099fcc5b304c DIFF: https://github.com/llvm/llvm-project/commit/c7251385c85ddcc1059548038e60099fcc5b304c.diff LO

[PATCH] D154795: [clang][Interp] Check pointers for live-ness when returning them

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7251385c85d: [clang][Interp] Check pointers for live-ness when returning them (authored by tbaeder). Changed prior to commit: https://reviews.llv

[PATCH] D155819: [include-cleaner] Loose matching for verbatim headers

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:198 llvm::StringMap> BySpelling; + llvm::StringMap> BySpellingAlternate; llvm::DenseMap> ByFile; maybe add a comment saying that these spel

[PATCH] D156255: [clang-tidy] Update unchecked-optional-access-check to use convenience function for diagnosing `FunctionDecl`s.

mboehme accepted this revision. mboehme added a comment. This revision is now accepted and ready to land. Note this appears to have clang-format errors Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:58-63 + if (llvm::Expected> Errors = +

[clang] 8c0246c - [clang][Interp] Reject reinterpret_casts

Author: Timm Bäder Date: 2023-07-26T09:56:29+02:00 New Revision: 8c0246c7f517a9b901224474f1a608d7e5193583 URL: https://github.com/llvm/llvm-project/commit/8c0246c7f517a9b901224474f1a608d7e5193583 DIFF: https://github.com/llvm/llvm-project/commit/8c0246c7f517a9b901224474f1a608d7e5193583.diff LO

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8c0246c7f517: [clang][Interp] Reject reinterpret_casts (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D153276?vs=533238&

[clang] 73362c4 - Revert "[CMake] Include riscv32-unknown-elf runtimes in Fuchsia toolchain"

Author: Petr Hosek Date: 2023-07-26T08:05:03Z New Revision: 73362c44eb430b759c81639e67a87231ea51c48a URL: https://github.com/llvm/llvm-project/commit/73362c44eb430b759c81639e67a87231ea51c48a DIFF: https://github.com/llvm/llvm-project/commit/73362c44eb430b759c81639e67a87231ea51c48a.diff LOG: Re

[clang] 4744693 - [clang][Interp][NFC] Move CastKind operator<< to PrimTypes.h

Author: Timm Bäder Date: 2023-07-26T10:06:26+02:00 New Revision: 47446939e0e60cf52ffdd3fa671949ff3183a4ca URL: https://github.com/llvm/llvm-project/commit/47446939e0e60cf52ffdd3fa671949ff3183a4ca DIFF: https://github.com/llvm/llvm-project/commit/47446939e0e60cf52ffdd3fa671949ff3183a4ca.diff LO

[clang] ae667f0 - [clang][Interp][NFC] Take a const InterpFrame* in InterpBuiltin.cpp

Author: Timm Bäder Date: 2023-07-26T10:06:26+02:00 New Revision: ae667f03d369cab8f32f28c3d765695ed4c1972b URL: https://github.com/llvm/llvm-project/commit/ae667f03d369cab8f32f28c3d765695ed4c1972b DIFF: https://github.com/llvm/llvm-project/commit/ae667f03d369cab8f32f28c3d765695ed4c1972b.diff LO

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan created this revision. zyounan added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is a

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 544252. zyounan added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd/un

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

jplehr added a comment. Hi, this seems to have broken the OpenMP AMDGPU buildbot (https://lab.llvm.org/buildbot/#/builders/193/builds/35471) I'm happy to help if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153276/new/ https://reviews.llv

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

tbaeder added a comment. Yeah sorry about that, but should already be fixed by https://github.com/llvm/llvm-project/commit/47446939e0e60cf52ffdd3fa671949ff3183a4c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153276/new/ https://reviews.llvm.org/D

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

jplehr added a comment. Wow, thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153276/new/ https://reviews.llvm.org/D153276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

4vtomat updated this revision to Diff 544254. 4vtomat added a comment. Add a test case for invalid example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156223/new/ https://reviews.llvm.org/D156223 Files: clang/include/clang/Support/RISCVVIntri

[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

4vtomat added inline comments. Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:136 case Invalid: + case Undefined: llvm_unreachable("Unhandled type."); eopXD wrote: > Could we just reuse `Invalid`? We can't reuse Invalid, since `ScalarType` in `RVVT

[PATCH] D156277: [Parser][ObjC] Stop parsing on eof

danix800 added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:749 + if (!Tok.is(tok::eof)) +ConsumeToken(); break; tbaeder wrote: > Why is there a `ConsumeToken()` call at all here? The token is already being > consumed in line 72

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder updated this revision to Diff 544258. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155356/new/ https://reviews.llvm.org/D155356 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST/Interp/builtin-functions.cpp =

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin added a comment. @efriedma You still have objection to landing that now with the goal to backport later in the release process? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155955/new/ https://reviews.llvm.org/D155955 __

[clang] bc37893 - [clang][dataflow] fix bug for transparent ListInitExpr handling

Author: Paul Semel Date: 2023-07-26T08:50:28Z New Revision: bc37893433d35b1448c5d4628d932fafec92efd0 URL: https://github.com/llvm/llvm-project/commit/bc37893433d35b1448c5d4628d932fafec92efd0 DIFF: https://github.com/llvm/llvm-project/commit/bc37893433d35b1448c5d4628d932fafec92efd0.diff LOG: [c

[clang] 145f353 - [clang][dataflow] fix failing assert in copyRecord

Author: Paul Semel Date: 2023-07-26T08:52:06Z New Revision: 145f353fd67909e03c39b968b464ac625edde6cb URL: https://github.com/llvm/llvm-project/commit/145f353fd67909e03c39b968b464ac625edde6cb DIFF: https://github.com/llvm/llvm-project/commit/145f353fd67909e03c39b968b464ac625edde6cb.diff LOG: [c

[PATCH] D155844: [clang][dataflow] fix failing assert in copyRecord

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG145f353fd679: [clang][dataflow] fix failing assert in copyRecord (authored by paulsemel). Herald added a subscriber: cfe-commits. Repository: rG L

[PATCH] D155878: [clangd] Loose include-cleaner matching for verbatim headers

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:185 + // The entries will be the same, but canonicalizing to find out is expensive! + if (SearchPathCanonical.empty()) { +for (const auto &Dir : nit: early exit =

[PATCH] D156222: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 544262. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156222/new/ https://reviews.llvm.org/D156222 Files: clang/lib/Sema/TypeLocBuilder.h Index:

[PATCH] D156303: [clang-tidy] Remove AnalyzeTemporaryDestructors configuration option

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Since it was depre

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

jhenderson added inline comments. Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:68 + +## Test the invalid -X option and OBJECT_MODE enviornment var. +# RUN: not env OBJECT_MODE= llvm-ranlib t_X32.a 2>&1 | FileCheck --implicit-check-not="error:" --check-prefixes=INVA

[clang] 2ca7416 - [clang][DeclPrinter] Fix AST print of delegating constructors

Author: Timo Stripf Date: 2023-07-26T09:26:53Z New Revision: 2ca74162258b6e808e84d6700a5613c0cbf6efe9 URL: https://github.com/llvm/llvm-project/commit/2ca74162258b6e808e84d6700a5613c0cbf6efe9 DIFF: https://github.com/llvm/llvm-project/commit/2ca74162258b6e808e84d6700a5613c0cbf6efe9.diff LOG: [

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ca74162258b: [clang][DeclPrinter] Fix AST print of delegating constructors (authored by strimo378). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ilya-biryukov added a comment. Thanks for the quick feedback! I understand that this goes against common practice in Clang, but the reason we want this warning is very practical. At Google, we would like to postpone adoption of coroutines until the aforementioned bugs are fixed, but we feel tha

[clang] d913aa6 - [clang][Interp][NFC] Make a local function static

Author: Timm Bäder Date: 2023-07-26T11:50:07+02:00 New Revision: d913aa6971c582724a2ba71689fe4908a951e935 URL: https://github.com/llvm/llvm-project/commit/d913aa6971c582724a2ba71689fe4908a951e935 DIFF: https://github.com/llvm/llvm-project/commit/d913aa6971c582724a2ba71689fe4908a951e935.diff LO

[clang] e9eb836 - [clang][Interp][NFC] Add an assertion

Author: Timm Bäder Date: 2023-07-26T11:50:07+02:00 New Revision: e9eb8362f0a580ba8a4cb173b6e8414a6d1a4db4 URL: https://github.com/llvm/llvm-project/commit/e9eb8362f0a580ba8a4cb173b6e8414a6d1a4db4 DIFF: https://github.com/llvm/llvm-project/commit/e9eb8362f0a580ba8a4cb173b6e8414a6d1a4db4.diff LO

[clang] 744a968 - [clang][Interp] Fix return statements with expresssion in void functions

Author: Timm Bäder Date: 2023-07-26T11:50:07+02:00 New Revision: 744a968f91f7bb92594a422c1b71f03a47c2415d URL: https://github.com/llvm/llvm-project/commit/744a968f91f7bb92594a422c1b71f03a47c2415d DIFF: https://github.com/llvm/llvm-project/commit/744a968f91f7bb92594a422c1b71f03a47c2415d.diff LO

[PATCH] D153649: [clang][Interp] Fix return statements with expresssion in void functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG744a968f91f7: [clang][Interp] Fix return statements with expresssion in void functions (authored by tbaeder). Changed prior to commit: https://rev

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt updated this revision to Diff 544275. yamt added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driver/wasm-t

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 544277. victorkingi added a comment. rebasing no changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D156303: [clang-tidy] Remove AnalyzeTemporaryDestructors configuration option

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156303/new/ https://reviews.llvm.org/D156303 ___

[PATCH] D156307: [clang][DeclPrinter] Fix AST print of curly constructor initializers

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156307 Files: clang/lib/AST/DeclPrinter.cpp

[clang] 378fcbf - [clang][Interp] Handle CXXNoexceptExprs

Author: Timm Bäder Date: 2023-07-26T12:23:54+02:00 New Revision: 378fcbf20ff80035dc1b5df4dc769908a80e0c3e URL: https://github.com/llvm/llvm-project/commit/378fcbf20ff80035dc1b5df4dc769908a80e0c3e DIFF: https://github.com/llvm/llvm-project/commit/378fcbf20ff80035dc1b5df4dc769908a80e0c3e.diff LO

[PATCH] D155707: [clang][Interp] Handle CXXNoexceptExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG378fcbf20ff8: [clang][Interp] Handle CXXNoexceptExprs (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155707?vs=543266&i

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

cor3ntin added a comment. In D156247#4534645 , @ilya-biryukov wrote: > Thanks for the quick feedback! > I understand that this goes against common practice in Clang, but the reason > we want this warning is very practical. > > At Google, we would like t

[clang-tools-extra] b7c6b39 - [clang-tidy] Remove AnalyzeTemporaryDestructors configuration option

Author: Carlos Galvez Date: 2023-07-26T10:26:43Z New Revision: b7c6b39651b3ffdabf0081c45e0455a04a8be992 URL: https://github.com/llvm/llvm-project/commit/b7c6b39651b3ffdabf0081c45e0455a04a8be992 DIFF: https://github.com/llvm/llvm-project/commit/b7c6b39651b3ffdabf0081c45e0455a04a8be992.diff LOG:

[PATCH] D156303: [clang-tidy] Remove AnalyzeTemporaryDestructors configuration option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7c6b39651b3: [clang-tidy] Remove AnalyzeTemporaryDestructors configuration option (authored by carlosgalvezp). Repository: rG LLVM Github Monorep

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37 +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unk

[clang] 970569b - [AMDGPU] __builtin_amdgcn_read_exec_* should be implemented with llvm.amdgcn.ballot

Author: ranapratap55 Date: 2023-07-26T16:21:31+05:30 New Revision: 970569b6ccb071d32e67ed26e3b972141efd2c31 URL: https://github.com/llvm/llvm-project/commit/970569b6ccb071d32e67ed26e3b972141efd2c31 DIFF: https://github.com/llvm/llvm-project/commit/970569b6ccb071d32e67ed26e3b972141efd2c31.diff

[PATCH] D156219: [AMDGPU] __builtin_amdgcn_read_exec_* should be implemented with llvm.amdgcn.ballot

This revision was automatically updated to reflect the committed changes. Closed by commit rG970569b6ccb0: [AMDGPU] __builtin_amdgcn_read_exec_* should be implemented with llvm.amdgcn. (authored by ranapratap55). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 5e8b44c - [OpenCL] Add cl_ext_image_raw10_raw12 extension

Author: Sven van Haastregt Date: 2023-07-26T11:59:12+01:00 New Revision: 5e8b44cc447e9b901c8168825f0c77491d9111e8 URL: https://github.com/llvm/llvm-project/commit/5e8b44cc447e9b901c8168825f0c77491d9111e8 DIFF: https://github.com/llvm/llvm-project/commit/5e8b44cc447e9b901c8168825f0c77491d9111e8.

[PATCH] D151339: [OpenCL] Add cl_ext_image_raw10_raw12 extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e8b44cc447e: [OpenCL] Add cl_ext_image_raw10_raw12 extension (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D151339?vs=5

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37 +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN: llc

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141757/new/ https://reviews.llvm.org/D141757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D154475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. donat.nagy requested review of this revi

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37 +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unk

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

AMP999 added a comment. Sure, I just filed this as a GitHub issue in the following link: https://github.com/llvm/llvm-project/issues/64124 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151625/new/ https://reviews.llvm.org/D151625

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3936-3937 +return std::move(Err); + if (ToInitializer) +ToField->setInClassInitializer(ToInitializer); return ToField; danix800 wrote: > Initializer could indirectly depends on

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ChuanqiXu added a subscriber: rsmith. ChuanqiXu added a comment. There are several topics now. Let's discuss them separately to make things clear: (1) Should we add such warning? > Does the use-case mentioned above make sense (allow C++20, disallow > coroutines for code using Clang 17)? This

[clang] ae4849f - [clang][Interp] PointerToIntegral casts

Author: Timm Bäder Date: 2023-07-26T13:39:37+02:00 New Revision: ae4849f96706cde460e6c792a6c8110791a6db32 URL: https://github.com/llvm/llvm-project/commit/ae4849f96706cde460e6c792a6c8110791a6db32 DIFF: https://github.com/llvm/llvm-project/commit/ae4849f96706cde460e6c792a6c8110791a6db32.diff LO

[PATCH] D150946: [clang][Interp] PointerToIntegral casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae4849f96706: [clang][Interp] PointerToIntegral casts (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D150946?vs=523698&i

[clang-tools-extra] f6307b2 - [include-cleaner] Switch Include from FileEntry* -> FileEntryRef

Author: Sam McCall Date: 2023-07-26T13:41:55+02:00 New Revision: f6307b260b0c0d93d25d13bab7ec02d762f4a2a6 URL: https://github.com/llvm/llvm-project/commit/f6307b260b0c0d93d25d13bab7ec02d762f4a2a6 DIFF: https://github.com/llvm/llvm-project/commit/f6307b260b0c0d93d25d13bab7ec02d762f4a2a6.diff LO

[PATCH] D155885: [include-cleaner] Switch Include from FileEntry* -> FileEntryRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6307b260b0c: [include-cleaner] Switch Include from FileEntry* -> FileEntryRef (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155885/

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

jplehr added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4914 + GVMode->setVisibility(llvm::GlobalVariable::ProtectedVisibility); + assert(!GVMode->isDeclaration() && + "Only globals with definition can force usage."); raghave

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe marked 3 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37 +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN: llc

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 544308. jp4a50 added a comment. Address minor review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 marked 2 inline comments as done. jp4a50 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:263 State.StartOfStringLiteral = 0; + State.NoLineBreak = false; State.StartOfLineLevel = 0; HazardyKnusperkeks wrote: > Was this u

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 544310. jp4a50 added a comment. Format files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/ContinuationInden

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:430 + { {"arrowlake-s"}, CK_ArrowlakeS, FEATURE_AVX2, FeaturesArrowlakeS, '\0', false }, + { {"arrowlake_s"}, CK_Lunarlake, FEATURE_AVX2, FeaturesArrowlakeS, 'p', true }, + // Lunarlake micr

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe updated this revision to Diff 544314. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 Files: clang/lib/Basi

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. > What do you mean with libstdc++ is fine? What I mean is when I do (current patch is applied to clang): source/llvm-project/build/bin/clang++ -std=c++20 t.cpp -c // compilation succeeds But when I do (libc++ is built together with clang) source/llvm-project/bui

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy added a comment. I tested this commit on several open source projects (in the default mode Pedantic=false), the following table summarizes the results: | vim_v8.2.1920_baseline_vs_vim_v8.2.1920_with_bitwise_shift | New reports

[PATCH] D156286: [docs] Bump minimum GCC version to 7.5

aaron.ballman added subscribers: cfe-commits, clang-vendors, aaron.ballman. aaron.ballman added a reviewer: sylvestre.ledru. aaron.ballman added a comment. There's a mention on the RFC thread that Ubuntu 18.04 still ships with GCC 7.3. That's an LTS release but it EOLed just last month, so it's n

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy updated this revision to Diff 544317. donat.nagy added a comment. (Fix incorrect filename mark in the license header.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://reviews.llvm.org/D156312 Files: clang/docs/analyz

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added

[PATCH] D156321: [Clang[RISCV] Remove RVV intrinsics `vread_csr`,`vwrite_csr`

eopXD created this revision. eopXD added reviewers: kito-cheng, craig.topper, rogfer01. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D156229: [clang][dataflow] Remove checks that test for consistency between `StructValue` and `AggregateStorageLocation`.

mboehme abandoned this revision. mboehme added a comment. This is a duplicate of https://reviews.llvm.org/D155813 that I uploaded for some reason. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156229/new/ https://reviews.llvm.

[PATCH] D156322: Outputs parameter comments using clang-doc and markdown generator

BotellaA created this revision. BotellaA added a reviewer: juliehockett. BotellaA added a project: clang-tools-extra. Herald added a project: All. BotellaA requested review of this revision. Herald added a subscriber: cfe-commits. Current implementation outputs the parameter name when used with @p

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:240 +return Initializing ? this->visitInitializer(SubExpr) +: this->visit(SubExpr); This pattern shows up a few times, so it might make sense to add

[PATCH] D155819: [include-cleaner] Loose matching for verbatim headers

sammccall updated this revision to Diff 544323. sammccall marked 6 inline comments as done. sammccall added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155819/new/ https://reviews.llvm.org/D155819 Files: clan

[PATCH] D155819: [include-cleaner] Loose matching for verbatim headers

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Types.cpp:110-112 + while (!P.empty() && path::is_separator(P.back())) +P.pop_back(); + return P; kadircet wrote: > nit: `return P.rtrim('/');` // only separator we can encou

[PATCH] D155870: [Clang][CodeGen] Another follow-up for `vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 544324. AlexVlx added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155870/new/ https://reviews.llvm.org/D155870 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/dynamic-cast-address-space.cpp Index: clang/t

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

danix800 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3936-3937 +return std::move(Err); + if (ToInitializer) +ToField->setInClassInitializer(ToInitializer); return ToField; balazske wrote: > danix800 wrote: > > Initializer could in

[PATCH] D155870: [Clang][CodeGen] Another follow-up for `vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155870/new/ https://reviews.llvm.org/D155870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D155878: [clangd] Loose include-cleaner matching for verbatim headers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:185 + // The entries will be the same, but canonicalizing to find out is expensive! + if (SearchPathCanonical.empty()) { +for (const auto &Dir : kadircet wrote: > nit: early e

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

ro created this revision. ro added reviewers: vitalybuka, MaskRay. ro added a project: clang. Herald added a subscriber: fedor.sergeev. Herald added a project: All. ro requested review of this revision. As detailed in Issue #64126, several asan tests `FAIL` due to a cycle in `AsanInitInternal`.

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

mboehme updated this revision to Diff 544335. mboehme added a comment. Rebase to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155921/new/ https://reviews.llvm.org/D155921 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironmen

[PATCH] D155922: [clang][dataflow] Eliminate `ReferenceValue`.

mboehme updated this revision to Diff 544336. mboehme added a comment. Rebase to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155922/new/ https://reviews.llvm.org/D155922 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironmen

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

mboehme updated this revision to Diff 544337. mboehme added a comment. Rebase to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155921/new/ https://reviews.llvm.org/D155921 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironmen

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

aaron.ballman added subscribers: efriedma, rjmccall. aaron.ballman added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:1659 mangleCXXDtorType(Dtor_Complete); +assert(ND); writeAbiTags(ND, AdditionalAbiTags); This seems incorrect --

  1   2   3   >