mboehme accepted this revision.
mboehme added a comment.
This revision is now accepted and ready to land.
Note this appears to have clang-format errors
================
Comment at:
clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:58-63
+ if (llvm::Expected<std::vector<SourceLocation>> Errors =
+ dataflow::diagnoseFunction<UncheckedOptionalAccessModel,
+ SourceLocation>(*FuncDecl,
*Result.Context,
+ Diagnoser))
for (const SourceLocation &Loc : *Errors)
diag(Loc, "unchecked access to optional value");
----------------
`Errors` could be confused with the error that is present inside the `Expected`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156255/new/
https://reviews.llvm.org/D156255
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
