cfe-commits@lists.llvm.org

2023-07-23 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7897-7899 + if (Args.hasArg(options::OPT_regcall4)) { +CmdArgs.push_back("-regcall4"); + } Remove parentheses Comment at: clang/lib/Driver/ToolChains/Clang.c

[PATCH] D155857: [CMake] Disable GCC -Wnonnull

2023-07-23 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f8f8760b586: [CMake] Disable GCC -Wnonnull (authored by fzakaria, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D15585

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

2023-07-23 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: stefanp, shchenz, amyk, tingwang, PowerPC. Herald added a subscriber: nemanjai. Herald added a reviewer: aaron.ballman. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D155661: [ASTImporter] Fix friend class template import within dependent context

2023-07-23 Thread Ding Fei via Phabricator via cfe-commits
danix800 updated this revision to Diff 543387. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155661/new/ https://reviews.llvm.org/D155661 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp Index: clang/unittests/AST/AS

[PATCH] D154931: [LoongArch] Support InlineAsm for LSX and LASX

2023-07-23 Thread WÁNG Xuěruì via Phabricator via cfe-commits
xen0n accepted this revision. xen0n added a comment. Seems the `u` and `w` modifiers are strictly an implementation detail that's different from ordinary inline asm constraints, so even though they take up precious single-letter namespace I'd be fine. Given the architecture-specific nature of t

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

2023-07-23 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new ForwardingDiagnosticConsumer(Compiler.getDiagnos

[PATCH] D155445: [analyzer][docs] Add CSA release notes

2023-07-23 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. After removing all commit refs, here is how it looks: F28416948: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155445/new/ https://reviews.llvm.org/D155445 __

[PATCH] D155445: [analyzer][docs] Add CSA release notes

2023-07-23 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG862b93a8095c: [analyzer][docs] Add CSA release notes (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D155445?vs=541356&id=543390#toc Repository: rG LLVM Github Monorepo CHA

[clang] 862b93a - [analyzer][docs] Add CSA release notes

2023-07-23 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2023-07-24T08:26:54+02:00 New Revision: 862b93a8095cd350d8b398f03dca92b93002f984 URL: https://github.com/llvm/llvm-project/commit/862b93a8095cd350d8b398f03dca92b93002f984 DIFF: https://github.com/llvm/llvm-project/commit/862b93a8095cd350d8b398f03dca92b93002f984.diff

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

2023-07-23 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Please provide a description justifying this change. There is no context here for the viewer to determine whether this change makes sense. Repository: rG LLVM Github Monorepo

[clang-tools-extra] 047273f - [clang-tidy] Add bugprone-empty-catch check

2023-07-23 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-07-24T06:34:34Z New Revision: 047273fc9c84aa8b4197111b0de068b853ccfe27 URL: https://github.com/llvm/llvm-project/commit/047273fc9c84aa8b4197111b0de068b853ccfe27 DIFF: https://github.com/llvm/llvm-project/commit/047273fc9c84aa8b4197111b0de068b853ccfe27.diff LOG: [

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

2023-07-23 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG047273fc9c84: [clang-tidy] Add bugprone-empty-catch check (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156065: [clang-format] Insert namespace comments with leading spaces

2023-07-23 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:29 +FormatStyle S = Style; +S.SpacesBeforeTrailingComments = 0; tooling::Replacements Replaces = I'd rather fix all the tests. Repository

<    1   2