pengfei added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7897-7899 + if (Args.hasArg(options::OPT_regcall4)) { + CmdArgs.push_back("-regcall4"); + } ---------------- Remove parentheses ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7937-7939 + if (Args.hasArg(options::OPT__SLASH_Gregcall4)) { + CmdArgs.push_back("-regcall4"); + } ---------------- ditto. ================ Comment at: llvm/lib/Target/X86/X86CallingConv.td:468 +defm X86_32_RegCallv4_Win : + X86_RegCall_base<RC_X86_32_RegCallv4_Win>; defm X86_Win64_RegCall : ---------------- This will define RetCC_* as well but it is not used, hence will emit warning. Any way to solve it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits