[clang] 1d7f9ce - [clang][dataflow] Don't crash when creating pointers to members.

Author: Martin Braenne Date: 2023-06-29T07:12:55Z New Revision: 1d7f9ce61f6e689ca63df2e36808885c873cf80b URL: https://github.com/llvm/llvm-project/commit/1d7f9ce61f6e689ca63df2e36808885c873cf80b DIFF: https://github.com/llvm/llvm-project/commit/1d7f9ce61f6e689ca63df2e36808885c873cf80b.diff LOG

[PATCH] D153960: [clang][dataflow] Don't crash when creating pointers to members.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d7f9ce61f6e: [clang][dataflow] Don't crash when creating pointers to members. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 535653. BeMg added a comment. Use getTargetFeatureForExtension instead of isSupportExtension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Tar

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

balazske updated this revision to Diff 535655. balazske marked 3 inline comments as done. balazske added a comment. Fixed review issues. Note tag is added for `fread`. Notes contain now the function name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[libunwind] 9e37142 - [libunwind] Add cached compile and link flags to libunwind

Author: mgrzywac Date: 2023-06-29T07:41:08Z New Revision: 9e37142dc12a7d57a793db56ea5fd259171fe20a URL: https://github.com/llvm/llvm-project/commit/9e37142dc12a7d57a793db56ea5fd259171fe20a DIFF: https://github.com/llvm/llvm-project/commit/9e37142dc12a7d57a793db56ea5fd259171fe20a.diff LOG: [lib

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:56 // WINDOWS: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4 -/

[PATCH] D153957: [C++20] [Modules] Allow Stmt::Profile to treat lambdas as equal conditionally

ChuanqiXu updated this revision to Diff 535664. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153957/new/ https://reviews.llvm.org/D153957 Files: clang/include/clang/AST/Stmt.h clang/lib/AST/ASTContext.cpp clang/lib/AST/StmtProfile.cpp

[clang] 54c79fa - [test] Replace aarch64-*-eabi with aarch64

Author: Michael Platings Date: 2023-06-29T09:06:00+01:00 New Revision: 54c79fa53c17a93d3d784738cae52d847102d279 URL: https://github.com/llvm/llvm-project/commit/54c79fa53c17a93d3d784738cae52d847102d279 DIFF: https://github.com/llvm/llvm-project/commit/54c79fa53c17a93d3d784738cae52d847102d279.di

[PATCH] D153943: [test] Replace aarch64-*-eabi with aarch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54c79fa53c17: [test] Replace aarch64-*-eabi with aarch64 (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] dc8cbbd - [Clang][Driver] Change missing multilib error to warning

Author: Michael Platings Date: 2023-06-29T09:08:15+01:00 New Revision: dc8cbbd55f807e832bf8c500205b0f4184531b00 URL: https://github.com/llvm/llvm-project/commit/dc8cbbd55f807e832bf8c500205b0f4184531b00 DIFF: https://github.com/llvm/llvm-project/commit/dc8cbbd55f807e832bf8c500205b0f4184531b00.di

[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc8cbbd55f80: [Clang][Driver] Change missing multilib error to warning (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153885/ne

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:319 + Prev->Previous->isOneOf(tok::period, tok::arrow)) || + (!Line.MustBeDeclaration && !Line.InMacroBody); Contexts.back().IsExpression = Ope

[PATCH] D153889: [analyzer][NFC] Fix dangling StringRef in barely used code

balazske added a comment. This is actually needed to get correct bug reports in D153612 , otherwise I got garbage messages (probably a `std::string` stack variable was passed to the `getNoteTag` function). I would not say that this is NFC because it is a bugfix

[PATCH] D154050: [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup

eopXD created this revision. eopXD added reviewers: craig.topper, 4vtomat, kito-cheng. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jo

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe marked an inline comment as done. FreddyYe added a comment. In D151696#4458443 , @pengfei wrote: > It looks to me the failed unit tests might be related to this patch, please > take a look. This is due to FeatureCMOV adding. Should I split into

[PATCH] D154050: [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup

eopXD updated this revision to Diff 535677. eopXD added a comment. Add test case of C++ compilation rvv-intrinsics-handcrafted/xsfvcp.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154050/new/ https://reviews.llvm.org/D154050 Files: clang/inc

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

cor3ntin added inline comments. Comment at: clang/test/CXX/expr/expr.const/p5-26.cpp:13 +(void)static_cast(a); //cxx23-note {{cast from 'void *' is not allowed in a constant expression in C++ standards before C++2c}} +(void)static_cast(a); +(void)static_cast(a);

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. In D151696#4458435 , @pengfei wrote: > I have some concerns for RULE 3, especially `core_aes_pclmulqdq -> westmere` > and `atom_sse4_2_movbe -> silvermont`. > Sometimes, we have minor feature differences in the same generation t

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon updated this revision to Diff 535687. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153962/new/ https://reviews.llvm.org/D153962 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:7374 auto *E = ExprWithCleanups::Create( Context, SubExpr, Cleanup.cleanupsHaveSideEffects(), Cleanups); ilya-biryukov wrote: > Because we may potentially pass some cleanups h

[PATCH] D154050: [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, thanks for quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154050/new/ https://reviews.llvm.org/D154050

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added a comment. In D151696#4458751 , @FreddyYe wrote: > In D151696#4458443 , @pengfei wrote: > >> It looks to me the failed unit tests might be related to this patch, please >> take a look. > > This is d

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 535696. 4vtomat added a comment. Herald added a subscriber: wangpc. Ready for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files: clang/include/clang/Basi

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

donat.nagy added a comment. I'm also using `gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0` (which supported according to the LLVM "Getting Started" page ) and I see the same std::optional compilation errors. Please r

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with two NITs. Thanks a lot for fixing this! Comment at: clang/lib/Sema/SemaExpr.cpp:18187 + if (Cleanup.exprNeedsCleanups()) { +// Since an immediate

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

ABataev added a comment. Upload full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

cor3ntin added a comment. Sorry, I missed the ping on Discord. Thanks for working on this I don't feel qualified to review this, but I don't think there are nearly enough tests. FYI there is a previous attempt at this here https://reviews.llvm.org/D139586 - with some test suggestions Reposito

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:20871 TotalDepCount.getZExtValue()); + if ((DepKind == OMPC_DEPEND_sink || DepKind == OMPC_DEPEND_source) && Remove this new line Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

hokein updated this revision to Diff 535712. hokein marked an inline comment as done. hokein added a comment. address the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153652/new/ https://reviews.llvm.org/D153652 Files: llvm/lib/Support

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

hokein added inline comments. Comment at: llvm/unittests/Support/raw_ostream_test.cpp:525 + ASSERT_TRUE(Perms) << "should be able to get permissions"; + // Verify that writeToOutput doesn't set exe bit. + EXPECT_EQ(Perms.get(), llvm::sys::fs::all_read | llvm::sys::fs::all_writ

[PATCH] D151445: [Flang] Add main-file-name flag to flang -fc1

domada abandoned this revision. domada added a comment. Herald added subscribers: gysit, Dinistro. Patch not needed. Preprocessor change: https://reviews.llvm.org/D153910 enables passing information about original source file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151445/new/ h

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon updated this revision to Diff 535721. Fznamznon added a comment. Update the comment, add blocks test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153962/new/ https://reviews.llvm.org/D153962 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. In D153701#4459036 , @cor3ntin wrote: > Sorry, I missed the ping on Discord. > Thanks for working on this > > I don't feel qualified to review this, but I don't think there are nearly > enough tests. > FYI there is a previous at

[PATCH] D154050: [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup

eopXD updated this revision to Diff 535722. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154050/new/ https://reviews.llvm.org/D154050 Files: clang/include/clang/Sema/RISCVIntrinsicManager.h clang/lib/Sema/SemaL

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. In D153701#4459036 , @cor3ntin wrote: > Sorry, I missed the ping on Discord. > Thanks for working on this > > I don't feel qualified to review this, but I don't think there are nearly > enough tests. > FYI there is a previous at

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

mikecrowe requested review of this revision. mikecrowe added a comment. I believe that the problems that caused this to be reverted have been fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153860/new/ https://reviews.llvm.org/D153860 ___

[PATCH] D154068: [clangd] Don't show header for namespace decl in Hover

hokein created this revision. hokein added a reviewer: VitaNuo. Herald added subscribers: kadircet, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The header for namespace

[PATCH] D154050: [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup

4vtomat accepted this revision. 4vtomat added a comment. LGTM, thanks~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154050/new/ https://reviews.llvm.org/D154050 ___ cfe-commits mailing list cfe-commits@

[clang] 989879f - [Clang] Allow C++11 style initialisation of SVE types.

Author: Paul Walker Date: 2023-06-29T11:55:36Z New Revision: 989879f8fded41c732db93864461b3a67b9f1501 URL: https://github.com/llvm/llvm-project/commit/989879f8fded41c732db93864461b3a67b9f1501 DIFF: https://github.com/llvm/llvm-project/commit/989879f8fded41c732db93864461b3a67b9f1501.diff LOG: [

[PATCH] D153560: [Clang] Allow C++11 style initialisation of SVE types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG989879f8fded: [Clang] Allow C++11 style initialisation of SVE types. (authored by paulwalker-arm). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D153694: [clang][CodeGen] Remove no-op EmitCastToVoidPtr (NFC)

barannikov88 updated this revision to Diff 535736. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153694/new/ https://reviews.llvm.org/D153694 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuilti

[PATCH] D154070: [Driver][lld/COFF] Support DWARF fission when using LTO on Windows

HaohaiWen created this revision. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch added /dwodir to lld/COFF which is

[clang] af19e40 - [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup

Author: eopXD Date: 2023-06-29T05:23:56-07:00 New Revision: af19e406f28e644e645781021c56720b60dc2238 URL: https://github.com/llvm/llvm-project/commit/af19e406f28e644e645781021c56720b60dc2238 DIFF: https://github.com/llvm/llvm-project/commit/af19e406f28e644e645781021c56720b60dc2238.diff LOG: [C

[PATCH] D154050: [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf19e406f28e: [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup (authored by eopXD). Repository: rG LLVM Github Monorepo

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 535740. VitaNuo marked 27 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/ https://reviews.llvm.org/D152900 Files: clang-to

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo added a comment. Thanks for comments! Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:40 /// Adds a file-to-string mapping from \p ID to \p CanonicalPath. void addMapping(FileEntryRef Header, llvm::StringRef CanonicalPath); kadirc

[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

simon_tatham added a comment. The details of this approach look good to me, but is this the best place to solve it? Doing it in clang means that //every// language front end that wants to use either of these sanitizers is responsible for doing this same work: tagging every IR function with `ali

[PATCH] D154068: [clangd] Don't show header for namespace decl in Hover

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154068/new/ https://reviews.llvm.org/D154068 __

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. The new test LGTM, albeit with one query: I assume `umask` sets some global state. When the lit unit tests are running, do the tests within the same process run sequentially, or are th

[clang] 5e87ec1 - [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs)

Author: Sean Perry Date: 2023-06-29T08:57:11-04:00 New Revision: 5e87ec1e19ce0226ff7c812db07aec1734c407b3 URL: https://github.com/llvm/llvm-project/commit/5e87ec1e19ce0226ff7c812db07aec1734c407b3 DIFF: https://github.com/llvm/llvm-project/commit/5e87ec1e19ce0226ff7c812db07aec1734c407b3.diff LO

[PATCH] D153580: [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e87ec1e19ce: [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs) (authored by SeanP, committed by abhina.sreeskantharajan).

[PATCH] D153363: [clang][analyzer] No end-of-file when seek to file begin.

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153363/new/ https://reviews.llvm.org/D153363 __

[PATCH] D154077: [HIP] Fix version detection for old HIP-PATH

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. ROCm used to install components under individual directories, e.g. HIP installed to /op

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

donat.nagy added a comment. Thanks for the update! I have two minor remarks (string handling is complicated in C++...) but the code looks good otherwise. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1305 + std::string Note = + llv

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG09ed2102eab5: [clang-tidy] Fix modernize-use-std-print check when return value used (authored by mikecrowe, committed by P

[clang-tools-extra] 09ed210 - [clang-tidy] Fix modernize-use-std-print check when return value used

Author: Mike Crowe Date: 2023-06-29T14:00:08Z New Revision: 09ed2102eab5d3d3786046009ff0d6724118b76b URL: https://github.com/llvm/llvm-project/commit/09ed2102eab5d3d3786046009ff0d6724118b76b DIFF: https://github.com/llvm/llvm-project/commit/09ed2102eab5d3d3786046009ff0d6724118b76b.diff LOG: [c

[clang] 8038086 - [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

Author: Takuya Shimizu Date: 2023-06-29T23:02:09+09:00 New Revision: 8038086aa75a122e5e632ebb1e7da06a2f7eed4b URL: https://github.com/llvm/llvm-project/commit/8038086aa75a122e5e632ebb1e7da06a2f7eed4b DIFF: https://github.com/llvm/llvm-project/commit/8038086aa75a122e5e632ebb1e7da06a2f7eed4b.diff

[PATCH] D153690: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8038086aa75a: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier (authored by hazohelet). Repository: rG LLVM Github Monorepo

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon updated this revision to Diff 535779. Fznamznon added a comment. Move test cases to CXX/drs/dr21xx.cpp, update DR status page, add alignof/sizeof cases, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153857/new/ https://reviews.llvm

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added a comment. Please help me, I have no better idea on this issue, do you have any better idea? @erichkeane @shafik Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 ___

[PATCH] D153770: Fix test regression on 32-bit x86.

zahiraam updated this revision to Diff 535783. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153770/new/ https://reviews.llvm.org/D153770 Files: clang/test/Sema/fp-eval-pragma-with-float-double_t-1.c clang/test/Sema/fp-eval-pragma-with-float-double_t-2.c clang/test/Sema/fp-eval-pra

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 updated this revision to Diff 535794. jyu2 added a comment. Sorry, full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/

[PATCH] D154050: [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup

jrtc27 added inline comments. Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:201 -void RISCVIntrinsicManagerImpl::InitIntrinsicList() { +void RISCVIntrinsicManagerImpl::ConstructRVVIntrinsics( +ArrayRef Recs, IntrinsicKind K) { As far as I can tell th

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

balazske updated this revision to Diff 535800. balazske added a comment. Fixed review issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153612/new/ https://reviews.llvm.org/D153612 Files: clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.cpp

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:3474 +/// IF __M[j+31] == 1 +/// result[j+31:j] := Load32(__X+(i*4)) +/// ELSE pengfei wrote: > A more intrinsic guide format is `MEM[__X+j:j]` LoadXX is the syntax in the gather

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

hazohelet updated this revision to Diff 535801. hazohelet edited the summary of this revision. hazohelet added a comment. Address comment from cjdb - Added example code & before/after diagnostic display to release note Thanks for reminding! CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 535804. probinson added a comment. s/:7/:j/ correcting bit references. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153993/new/ https://reviews.llvm.org/D153993 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h =

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM once again with one NIT about the comment line placement. Thanks! Comment at: clang/lib/Sema/SemaExpr.cpp:18198-18199 +// - blocks are not allowed inside constant expressions and compiler will +//

[clang] 9fd3321 - Fix test regression on 32-bit x86.

Author: Zahira Ammarguellat Date: 2023-06-29T11:02:38-04:00 New Revision: 9fd3321db7429098e115c2c46bf6528a85070e53 URL: https://github.com/llvm/llvm-project/commit/9fd3321db7429098e115c2c46bf6528a85070e53 DIFF: https://github.com/llvm/llvm-project/commit/9fd3321db7429098e115c2c46bf6528a85070e53

[PATCH] D153770: Fix test regression on 32-bit x86.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fd3321db742: Fix test regression on 32-bit x86. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM, but please wait until you can merge this together with D153776 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang-tools-extra] 21b6da3 - [clangd] Don't show header for namespace decl in Hover

Author: Haojian Wu Date: 2023-06-29T17:11:19+02:00 New Revision: 21b6da35f1d5c8ee50c14fa4e498b6c46ac4bc0f URL: https://github.com/llvm/llvm-project/commit/21b6da35f1d5c8ee50c14fa4e498b6c46ac4bc0f DIFF: https://github.com/llvm/llvm-project/commit/21b6da35f1d5c8ee50c14fa4e498b6c46ac4bc0f.diff LO

[PATCH] D154068: [clangd] Don't show header for namespace decl in Hover

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21b6da35f1d5: [clangd] Don't show header for namespace decl in Hover (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D1540

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM if you rebase these changes onto the most recent version of D153612 . Thanks for adding this interestingness check! Repository: rG LLVM Githu

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman added a comment. I've not spotted anything major, but I would like some additional test coverage. Btw, you need to add this to the table in https://github.com/llvm/llvm-project/blob/189033e6bede96de0d74e61715fcd1b48d95e247/clang/docs/LanguageExtensions.rst?plain=1#L1429 because th

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2422 + << BS.getType(); + Info.Note(BS.getBeginLoc(), diag::note_constexpr_base_inherited_here); + return false; tbaeder wrote: > Can you pass `<< BS.getSo

[clang] be8a65b - [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

Author: Jeffrey Byrnes Date: 2023-06-29T08:18:28-07:00 New Revision: be8a65b598b3b80f73e862a01c7eaafe84d853a0 URL: https://github.com/llvm/llvm-project/commit/be8a65b598b3b80f73e862a01c7eaafe84d853a0 DIFF: https://github.com/llvm/llvm-project/commit/be8a65b598b3b80f73e862a01c7eaafe84d853a0.diff

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe8a65b598b3: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc (authored by jrbyrnes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

Szelethus added a comment. This is the quintessential example of a patch where while the test files look promising, we need some evaluation on the real world. I understand that its a chore -- but this is simply the nature of the beast. While the changes in the test file look promising. I'd be m

[PATCH] D154091: [clang-format] Prefer breaking long strings at new lines

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Previously, escape sequences in string literals were not rec

[PATCH] D154093: [clang-format] Break strings in Verilog

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. In Verilog, concatenations need to have braces around them a

[PATCH] D154091: [clang-format] Prefer breaking long strings at new lines

sstwcw added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:225 +return BreakableToken::Split(NewLine, 0); + if (AfterSpace >= 2) +return BreakableToken::Split(AfterSpace, 0); Should I change the threshold from 2 to 1? It is set to 2 b

[clang] 6bf66d8 - [clang-format] Indent Verilog struct literal on new line

Author: sstwcw Date: 2023-06-29T15:38:44Z New Revision: 6bf66d839f1386c06e19a3621c02c8fc6a14f94f URL: https://github.com/llvm/llvm-project/commit/6bf66d839f1386c06e19a3621c02c8fc6a14f94f DIFF: https://github.com/llvm/llvm-project/commit/6bf66d839f1386c06e19a3621c02c8fc6a14f94f.diff LOG: [clang

[PATCH] D152623: [clang-format] Indent Verilog struct literal on new line

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf66d839f13: [clang-format] Indent Verilog struct literal on new line (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152623/new/ https

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

jhuber6 updated this revision to Diff 535835. jhuber6 added a comment. Semi-fix hack for `string.h` and fix `ctype.h`. `string.h` required undefining C++ mode so we didn't use weird GNU C++ handling, which we then still need the `extern "C"` for. The cytpe problems come from GNU defining everythin

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 marked 3 inline comments as done. azhan92 added a comment. @hubert.reinterpretcast I have the call stack on AIX: #0 0x0904304c in read () from /usr/lib/libc.a(shr_64.o) #1 0x000100d5f044 in llvm::sys::RetryAfterSignal(int const&, long ( const&)(int, void*, unsigned long

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2422 + << BS.getType(); + Info.Note(BS.getBeginLoc(), diag::note_constexpr_base_inherited_here); + return false; hazohelet wrote: > tbaeder wrote: > > Can

[clang] 08513cb - [OpenMP] Fix lvalue reference type generation in untied task loop

Author: Zhiheng Xie Date: 2023-06-29T09:11:10-07:00 New Revision: 08513cbea4dc1fe10ee864b8fd8c1eccd7917490 URL: https://github.com/llvm/llvm-project/commit/08513cbea4dc1fe10ee864b8fd8c1eccd7917490 DIFF: https://github.com/llvm/llvm-project/commit/08513cbea4dc1fe10ee864b8fd8c1eccd7917490.diff L

[PATCH] D153321: [OpenMP] Fix lvalue reference type generation in untied task loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG08513cbea4dc: [OpenMP] Fix lvalue reference type generation in untied task loop (authored by eastb233, committed by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

Caslyn updated this revision to Diff 535845. Caslyn added a comment. correct reference in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152953/new/ https://reviews.llvm.org/D152953 Files: clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 535846. cor3ntin marked 5 inline comments as done. cor3ntin added a comment. - Address Aaron's feedback - Add more tests - Add a longer description of the feature in the release notes - address nitpicks - Improve error message when using __builtin_offs

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

pengfei added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:3474 +/// IF __M[j+31] == 1 +/// result[j+31:j] := Load32(__X+(i*4)) +/// ELSE probinson wrote: > pengfei wrote: > > A more intrinsic guide format is `MEM[__X+j:j]` > LoadXX is the

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

MyDeveloperDay added a subscriber: aaron.ballman. MyDeveloperDay added a comment. @owenpan @HazardyKnusperkeks @rymiel what are your feeling on how we should close old clang-format reviews like this? (@aaron.ballman any thoughts on how it should be done?) we end up with lots of reviews that ei

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

rymiel updated this revision to Diff 535859. rymiel added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153798/new/ https://reviews.llvm.org/D153798 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/

[PATCH] D154016: [clang][modules] Avoid serializing all diag mappings in non-deterministic order

steven_wu added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:3016 for (const auto &I : *State) { -if (I.second.isPragma() || IncludeNonPragmaStates) { - Record.push_back(I.first); - Record.push_back(I.second.serialize()); -

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:3474 +/// IF __M[j+31] == 1 +/// result[j+31:j] := Load32(__X+(i*4)) +/// ELSE pengfei wrote: > probinson wrote: > > pengfei wrote: > > > A more intrinsic guide format is `MEM[__X

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

yonghong-song accepted this revision. yonghong-song added a comment. I am okay with this change. Once you used this patch and implemented the mechanism inside Google. Could you send a follow-up summary on what the implementation looks like in Google? This will give people a sense why this is us

[clang] 4986f3f - [clang-format] Correctly annotate operator free function call

Author: Emilia Kond Date: 2023-06-29T19:51:27+03:00 New Revision: 4986f3f2f220e4fd2fef4b08e550b399c9f45a9f URL: https://github.com/llvm/llvm-project/commit/4986f3f2f220e4fd2fef4b08e550b399c9f45a9f DIFF: https://github.com/llvm/llvm-project/commit/4986f3f2f220e4fd2fef4b08e550b399c9f45a9f.diff L

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4986f3f2f220: [clang-format] Correctly annotate operator free function call (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SIN

  1   2   3   >