[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, sivachandra, lntue, michaelrj, tra, JonChesterfield. Herald added projects: libc-project, All. Herald added a subscriber: libc-commits. jhuber6 requested review of this revision. Herald added subscribers: cfe-commit

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

jhuber6 added a comment. For reference, here is what one of the newly generated headers looks like that is used. #ifndef __LLVM_LIBC_DECLARATIONS_STDIO_H #define __LLVM_LIBC_DECLARATIONS_STDIO_H #ifndef __LIBC_ATTRS #define __LIBC_ATTRS #endif #ifdef __cplusplus extern "C" {

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay added a comment. In D146777#4457839 , @paulkirth wrote: > In D146777#4457209 , @MaskRay wrote: > >> As mentioned, you may consider landing llvm patch then wait a bit so that >> (a) people can experiment w

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

jhuber6 updated this revision to Diff 535600. jhuber6 added a comment. Hack around the `string` problem. GNU likes to provide different prototypes for C++. Manually disable this for now. Unsure if this will have reasonable fallout, but it seems bizarre that `string.h` would define C++ constructs

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 ___

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llv

[clang] 7372c0d - [CLANG] Fix potential integer overflow value in getRVVTypeSize()

Author: Manna, Soumi Date: 2023-06-28T19:25:53-07:00 New Revision: 7372c0d46d2185017c509eb30910b102b4f9cdaa URL: https://github.com/llvm/llvm-project/commit/7372c0d46d2185017c509eb30910b102b4f9cdaa DIFF: https://github.com/llvm/llvm-project/commit/7372c0d46d2185017c509eb30910b102b4f9cdaa.diff

[PATCH] D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize()

This revision was automatically updated to reflect the committed changes. Closed by commit rG7372c0d46d21: [CLANG] Fix potential integer overflow value in getRVVTypeSize() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153146/new/

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

sameerds requested review of this revision. sameerds added a comment. @pravinjagtap @arsenm ... reverting the mbcnt intrinsic affects tests that were added for atomic optimizations. In particular, the mbcnt is now being moved across/into/out of control flow because it is no longer convergent. I

[PATCH] D153321: [OpenMP] Fix lvalue reference type generation in untied task loop

eastb233 added a comment. In D153321#4455776 , @ABataev wrote: > LG Thanks a lot for the review. And I do not have commit access, could you please help commit the patch And my name is "Zhiheng Xie", email is "eastb...@qq.com" Repository: rG LLVM Git

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 added a comment. These updated tests pass locally for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154038/new/ https://reviews.llvm.org/D154038 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D153836: [RISCV] Bump vector crypto to v1.0.0-rc1

4vtomat added a comment. In D153836#4452236 , @asb wrote: > Agreed that looking at > https://github.com/riscv/riscv-crypto/compare/v20230531...v20230620 there are > no changes that need to be reflected on the LLVM side beyond the version bump > here. L

[clang] 02f94a6 - [RISCV] Bump vector crypto to v1.0.0-rc1

Author: 4vtomat Date: 2023-06-28T19:53:07-07:00 New Revision: 02f94a655fb6ee494df6cd9e136e7ab713be2043 URL: https://github.com/llvm/llvm-project/commit/02f94a655fb6ee494df6cd9e136e7ab713be2043 DIFF: https://github.com/llvm/llvm-project/commit/02f94a655fb6ee494df6cd9e136e7ab713be2043.diff LOG:

[PATCH] D153836: [RISCV] Bump vector crypto to v1.0.0-rc1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02f94a655fb6: [RISCV] Bump vector crypto to v1.0.0-rc1 (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 updated this revision to Diff 535601. jyu2 added a comment. Thanks Alexey's review. This is address his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 Files: clang/include/clang/AST/Ope

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 added a comment. Thanks. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier = getOpenMPSimpleClauseTyp

[PATCH] D140727: [XRay] Add initial support for loongarch64

SixWeining added a comment. In D140727#4019019 , @SixWeining wrote: > D140725 is abandoned. Let me defer this > change until we support 64bit PC-relative relocation for `SymA - SymB`. Update: R_LARCH_64_PCREL can be e

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

This revision was automatically updated to reflect the committed changes. Closed by commit rGa806ec4857c2: [analyzer] Refactor codes in findMethodDecl() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152194/new/ https://reviews.l

[clang] a806ec4 - [analyzer] Refactor codes in findMethodDecl()

Author: Manna, Soumi Date: 2023-06-28T20:40:02-07:00 New Revision: a806ec4857c2c662c89755edba56d893ae1beeb4 URL: https://github.com/llvm/llvm-project/commit/a806ec4857c2c662c89755edba56d893ae1beeb4 DIFF: https://github.com/llvm/llvm-project/commit/a806ec4857c2c662c89755edba56d893ae1beeb4.diff

[clang] 74d8455 - [clang][dataflow] Make `getThisPointeeStorageLocation()` return an `AggregateStorageLocation`.

Author: Martin Braenne Date: 2023-06-29T04:07:08Z New Revision: 74d8455ba6a19d9eeaa561fd0eccc8cbf5351a47 URL: https://github.com/llvm/llvm-project/commit/74d8455ba6a19d9eeaa561fd0eccc8cbf5351a47 DIFF: https://github.com/llvm/llvm-project/commit/74d8455ba6a19d9eeaa561fd0eccc8cbf5351a47.diff LOG

[clang] d363248 - [clang][dataflow] Initialize fields of anonymous records correctly.

Author: Martin Braenne Date: 2023-06-29T04:07:04Z New Revision: d36324866ee1fb4d1c26552b6b686a463d2b448f URL: https://github.com/llvm/llvm-project/commit/d36324866ee1fb4d1c26552b6b686a463d2b448f DIFF: https://github.com/llvm/llvm-project/commit/d36324866ee1fb4d1c26552b6b686a463d2b448f.diff LOG

[PATCH] D153852: [clang][dataflow] Initialize fields of anonymous records correctly.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rGd36324866ee1: [clang][dataflow] Initialize fields of anonymous records correctly. (authored by mboehme). R

[PATCH] D153854: [clang][dataflow] Make `getThisPointeeStorageLocation()` return an `AggregateStorageLocation`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74d8455ba6a1: [clang][dataflow] Make `getThisPointeeStorageLocation()` return an… (authored by mboehme). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. @azhan92, please incorporate a revert of https://reviews.llvm.org/rG64ca650cf9f180cc0b68c0005639028084066e10. Since it is an `XFAIL`. once the problem is fixed, the test will end up being an "unexpected success" unless we remove the `XFAIL`. Repository:

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. @azhan92, rG6ace52e5e49cff6664fc301fa4985fc28c88f26f and rGc14df228ff3ca73e3c5c00c495216bba56665fd5 should also be

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. In D151567#4458232 , @hubert.reinterpretcast wrote: > @azhan92, please incorporate a revert of > https://reviews.llvm.org/rG64ca650cf9f180cc0b68c0005639028084066e10. Since it > is an `XFAIL`. once the problem is

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1022 + +if (DiscardResult) + return this->emitPopPtr(E); shafik wrote: > Could you just pass `DiscardResult` to `visitLocalInitializer` Nope, the `visitInitializer` funct

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

tbaeder added a comment. I think this makes https://reviews.llvm.org/D153653 unnecessary(?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___ cfe-commits mail

[clang] 548e08c - [NFC] Add missing cpu tests in predefined-arch-macros.c

Author: Freddy Ye Date: 2023-06-29T13:30:13+08:00 New Revision: 548e08c3f635f72519d3bcadcc71cca7d31d1e6d URL: https://github.com/llvm/llvm-project/commit/548e08c3f635f72519d3bcadcc71cca7d31d1e6d DIFF: https://github.com/llvm/llvm-project/commit/548e08c3f635f72519d3bcadcc71cca7d31d1e6d.diff LOG

[PATCH] D153714: [NFC] Add missing cpu tests in predefined-arch-macros.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG548e08c3f635: [NFC] Add missing cpu tests in predefined-arch-macros.c (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153714/new/ http

[PATCH] D152356: [clang][ExtractAPI] Add --emit-symbol-graph option

Arsenic updated this revision to Diff 535630. Arsenic added a comment. Changes majorly include fixing issues pointed out by review comments : - Remove WrappingExtractAPIAction::prepareToExecuteAction() - Move knownInputFiles from Base action to ExtractAPIFrontendAction - Fix naming of MacroCallba

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:385 + StringRef ExtName = Ext.substr(1); + if (llvm::RISCVISAInfo::isSupportedExtensionWithVersion(ExtName) || + llvm::RISCVISAInfo::isSupportedExtension(ExtName)) ---

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. In D153003#4456595 , @rsmith wrote: > I think the behavior change for the testcase here is correct, though I'm not > sure that the patch is getting that behaviour change in the right way. Per > [temp.type]/1.4 (http://eel.is/c

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

pengfei added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:1324 +/// k := i*16 +/// result[k+15:k] := SignExtend(__V[j+7:7]) +/// ENDFOR j Comment at: clang/lib/Headers/avx2intrin.h:1352 +/// k := i*32 +/// result[k+31:k]

[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

MaskRay created this revision. MaskRay added reviewers: efriedma, rjmccall, simon_tatham, samitolvanen. Herald added a subscriber: kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. In D153003#4458323 , @ChuanqiXu wrote: > In D153003#4456595 , @rsmith wrote: > >> I think the behavior change for the testcase here is correct, though I'm not >> sure that the patch is g

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:385 + StringRef ExtName = Ext.substr(1); + if (llvm::RISCVISAInfo::isSupportedExtensionWithVersion(ExtName) || + llvm::RISCVISAInfo::isSupportedExtension(ExtName)) ---

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

pravinjagtap added a comment. In D153953#4458134 , @sameerds wrote: > @pravinjagtap @arsenm ... reverting the mbcnt intrinsic affects tests that > were added for atomic optimizations. In particular, the mbcnt is now being > moved across/into/out of cont

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

foad added a comment. In D153953#4458134 , @sameerds wrote: > @pravinjagtap @arsenm ... reverting the mbcnt intrinsic affects tests that > were added for atomic optimizations. In particular, the mbcnt is now being > moved across/into/out of control flow

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. In D153003#4458366 , @Hahnfeld wrote: > In D153003#4458323 , @ChuanqiXu > wrote: > >> In D153003#4456595 , @rsmith wrote: >> >>> I think the be

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153960/new/ https://reviews.llvm.org/D153960 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:57 + CmdArgs.push_back("-nologo"); + + if (Args.hasArg(options::OPT_g_Group, options::OPT__SLASH_Z7)) We should be also passing `-subsystem:efi_application`. Note that COFF also has

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added a comment. For comments that are already address, it's customary to mark those as "Done" to make it clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 ___

[PATCH] D137556: [POC] Clang implementation for AArch64 SME and SME2 builtins

sdesmalen updated this revision to Diff 535645. sdesmalen retitled this revision from "[POC] Clang implementation for AArch64 SME and some SME2 builtins" to "[POC] Clang implementation for AArch64 SME and SME2 builtins". sdesmalen edited the summary of this revision. sdesmalen added a comment. He

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. I have some concerns for RULE 3, especially `core_aes_pclmulqdq -> westmere` and `atom_sse4_2_movbe -> silvermont`. Sometimes, we have minor feature differences in the same generation targets

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

pengfei added a comment. It looks to me the failed unit tests might be related to this patch, please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 _

<    1   2   3