[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri created this revision. sandeepkosuri added reviewers: ABataev, soumitra, koops, RitanyaB, dreachem. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. sandeepkosuri requested review of this revision. Herald added a reviewer: jdoerfert. Herald added sub

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:2200 Diag(Tok, diag::err_expected_semi_for); - else -// Skip until semicolon or rparen, don't consume it. shafik wrote: > Can you explain why you removed this? The cur

[PATCH] D152057: [CMake][Fuchsia] Add LLVM_ENABLE_HTTPLIB to Stage 2 build

aidengrossman created this revision. Herald added subscribers: ekilmer, abrachet. Herald added a project: All. aidengrossman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch sets the LLVM_ENABLE_HTTPLIB flag to ON in the stage 2 b

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

mgorny added a comment. I'm getting completely incomprehensible build errors on Gentoo from this, as of aa7eace8431ba213c5431638b894b0e1b4b481c7 : samu: job failed: : && /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -march=zn

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: tbaeder wrote: > charmitro wrote: > > tbaeder wrote: > > > charmi

[clang] 0beffb8 - [CMake] Ensure `CLANG_RESOURCE_DIR` is respected.

Author: paperchalice Date: 2023-06-03T04:21:35-07:00 New Revision: 0beffb854209a41f31beb18f9631258349a99299 URL: https://github.com/llvm/llvm-project/commit/0beffb854209a41f31beb18f9631258349a99299 DIFF: https://github.com/llvm/llvm-project/commit/0beffb854209a41f31beb18f9631258349a99299.diff

[PATCH] D152061: [clang] fix TranslateXarchArgs to support -Xarch_device -O* Origin code: when passed -Xarch_device -O1, TranslateXarchArgs will parse -O1 as a CLFlag, which has flags NoXarchOption ,

chenguang created this revision. Herald added a project: All. chenguang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152061 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19217 + + // Verify comments and empty lines break the alignment + verifyFormat("switch (level) {\n" Comment at: clang/unittests/Format/FormatTest.cp

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:4532 /// Returns ``true`` if the Style has been set. -bool getPredefinedStyle(StringRef Name, FormatStyle::LanguageKind Language, +LLVM_EXTERNAL_VISIBILITY bool getPredefinedStyle(StringRef

[clang] 684f3c9 - [Clang] Fix status of P0960

Author: Corentin Jabot Date: 2023-06-03T17:03:42+02:00 New Revision: 684f3c968d6bbf124014128b9f5e4f03a50f28c5 URL: https://github.com/llvm/llvm-project/commit/684f3c968d6bbf124014128b9f5e4f03a50f28c5 DIFF: https://github.com/llvm/llvm-project/commit/684f3c968d6bbf124014128b9f5e4f03a50f28c5.diff

[PATCH] D150122: [Clang] Fix status of P0960

This revision was automatically updated to reflect the committed changes. Closed by commit rG684f3c968d6b: [Clang] Fix status of P0960 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150122/new/ https://reviews.llvm.org/D150122

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cor3ntin added a comment. I think we should make sure to land this for clang 17. The rate of consteval bugs is no greater than that of any other feature at this point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 528112. RIscRIpt added a comment. Added diagnostics for [[msvc::constexpr]] virtual Regarding [[msvc::constexpr]] constructors, unfortunatelly I cannot find a reasonable way to support it. During development I found out about Clang's experimental Constant

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

cor3ntin accepted this revision. cor3ntin added a comment. This makes sense to me, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134334/new/ https://reviews.llvm.org/D134334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] 8dc7647 - [AST] Use DenseMapBase::lookup (NFC)

Author: Kazu Hirata Date: 2023-06-03T09:37:36-07:00 New Revision: 8dc7647845a4357f6aee7ffe40839c97f2474d99 URL: https://github.com/llvm/llvm-project/commit/8dc7647845a4357f6aee7ffe40839c97f2474d99 DIFF: https://github.com/llvm/llvm-project/commit/8dc7647845a4357f6aee7ffe40839c97f2474d99.diff L

[clang] 8e6e659 - [Serialization] Remove unused function getKnownModules

Author: Kazu Hirata Date: 2023-06-03T09:37:37-07:00 New Revision: 8e6e659cc800a13876d3239f9f29ea6615d86f40 URL: https://github.com/llvm/llvm-project/commit/8e6e659cc800a13876d3239f9f29ea6615d86f40 DIFF: https://github.com/llvm/llvm-project/commit/8e6e659cc800a13876d3239f9f29ea6615d86f40.diff L

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias updated this revision to Diff 528118. galenelias added a comment. Fixup up review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/ https://reviews.llvm.org/D151761 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias marked 3 inline comments as done. galenelias added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19218 + // Verify comments and empty lines break the alignment + verifyFormat("switch (level) {\n" + "case log::info:return \"info\

[clang] 1cb3827 - [Clang][RISCV] Avoid generating MaskedPrototype if the intrinsic does not have a masked version. NFC

Author: eopXD Date: 2023-06-03T10:20:04-07:00 New Revision: 1cb382718a35f55f51cf3a8e3fa7d627bfa63e85 URL: https://github.com/llvm/llvm-project/commit/1cb382718a35f55f51cf3a8e3fa7d627bfa63e85 DIFF: https://github.com/llvm/llvm-project/commit/1cb382718a35f55f51cf3a8e3fa7d627bfa63e85.diff LOG: [C

[PATCH] D152069: [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 16 bits

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added a project: All. eopXD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The next patch introduces a number of new RVV tuple type

[PATCH] D152070: [2/N][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D152072: [4/N][Clang][RISCV] Expand all variants for unit stride segment store

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D152075: [7/N][Clang][RISCV] Expand all variants for strided segment store

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D152076: [8/N][Clang][RISCV] Expand all variants for indexed strided segment load

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, edward-j

[PATCH] D152078: [10/N][Clang][RISCV] Expand all variants for vget on tuple types

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D152079: [11/N][Clang][RISCV] Expand all variants for vset on tuple types

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

eopXD updated this revision to Diff 528135. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152070/new/ https://reviews.llvm.org/D152070 Files: clang/include/clang/Basic/RISCVVTypes.def clang/include/clang/Support

[PATCH] D152072: [4/11][Clang][RISCV] Expand all variants for unit stride segment store

eopXD updated this revision to Diff 528139. eopXD added a comment. Bump BI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152072/new/ https://reviews.llvm.org/D152072 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152075: [7/11][Clang][RISCV] Expand all variants for strided segment store

eopXD updated this revision to Diff 528142. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152075/new/ https://reviews.llvm.org/D152075 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152076: [8/11][Clang][RISCV] Expand all variants for indexed strided segment load

eopXD updated this revision to Diff 528143. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152076/new/ https://reviews.llvm.org/D152076 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152078: [10/11][Clang][RISCV] Expand all variants for vget on tuple types

eopXD updated this revision to Diff 528145. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152078/new/ https://reviews.llvm.org/D152078 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152079: [11/11][Clang][RISCV] Expand all variants for vset on tuple types

eopXD updated this revision to Diff 528146. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152079/new/ https://reviews.llvm.org/D152079 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Please wait for some other approval (or comments) for a few days. Comment at: clang/unittests/Format/FormatTest.cpp:19218 + // Verify comments and em

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

mstorsjo added a comment. In D148793#4392788 , @mgorny wrote: > I'm getting completely incomprehensible build errors on Gentoo from this I'm also hitting this; it only seems to happen if building with `-DLLVM_LINK_LLVM_DYLIB=ON`. Repository: rG LLVM

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

mgorny added a comment. My educated guess would be that `clangIncludeCleaner` is being linked via `clang_target_link_libraries` while it's not part of `libclang-cpp`, so it should go into regular `target_link_libraries`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

mstorsjo added a comment. In D148793#4393385 , @mgorny wrote: > My educated guess would be that `clangIncludeCleaner` is being linked via > `clang_target_link_libraries` while it's not part of `libclang-cpp`, so it > should go into regular `target_link_

[clang] 4b97649 - [clang-format] Fix overlapping replacements before PPDirectives

Author: Owen Pan Date: 2023-06-03T12:33:03-07:00 New Revision: 4b9764959dc4b8783e18747c1742ab164e4bc4ee URL: https://github.com/llvm/llvm-project/commit/4b9764959dc4b8783e18747c1742ab164e4bc4ee DIFF: https://github.com/llvm/llvm-project/commit/4b9764959dc4b8783e18747c1742ab164e4bc4ee.diff LOG:

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b9764959dc4: [clang-format] Fix overlapping replacements before PPDirectives (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D152057: [CMake][Fuchsia] Add LLVM_ENABLE_HTTPLIB to Stage 2 build

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152057/new/ https://reviews.llvm.org/D152057 ___

[clang-tools-extra] ac0ea75 - [clang-tools-extra] Fix linking when built with CLANG_LINK_CLANG_DYLIB=ON

Author: Martin Storsjö Date: 2023-06-03T23:25:33+03:00 New Revision: ac0ea7555ee4ae872bcd153e04513ba0b88b8985 URL: https://github.com/llvm/llvm-project/commit/ac0ea7555ee4ae872bcd153e04513ba0b88b8985 DIFF: https://github.com/llvm/llvm-project/commit/ac0ea7555ee4ae872bcd153e04513ba0b88b8985.diff

[PATCH] D152083: Warning for uninitialized elements in fixed-size arrays

Sinitax created this revision. Sinitax added a project: clang. Herald added a project: All. Sinitax requested review of this revision. Herald added a subscriber: cfe-commits. This patch implements a warning for uninitialized elements in fixed-size arrays. Without warnings a 'gap' in an array can

[clang] 2ff0aa2 - [CMake][Fuchsia] Add LLVM_ENABLE_HTTPLIB to Stage 2 build

Author: Aiden Grossman Date: 2023-06-03T22:30:19Z New Revision: 2ff0aa207fd55604604bb9eec33dada1a80842db URL: https://github.com/llvm/llvm-project/commit/2ff0aa207fd55604604bb9eec33dada1a80842db DIFF: https://github.com/llvm/llvm-project/commit/2ff0aa207fd55604604bb9eec33dada1a80842db.diff LOG

[PATCH] D152057: [CMake][Fuchsia] Add LLVM_ENABLE_HTTPLIB to Stage 2 build

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ff0aa207fd5: [CMake][Fuchsia] Add LLVM_ENABLE_HTTPLIB to Stage 2 build (authored by aidengrossman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152057/new

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

Sinitax updated this revision to Diff 528162. Sinitax added a comment. Remove new warning from -Wuninitialized group for backwards-compatibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: clang/include/clang/Basic/DiagnosticSema

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, MaskRay. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152090 Fi

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder added a comment. @hans @dyung I've opened https://reviews.llvm.org/D152090 which should fix both of your concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: charmitro wrote: > tbaeder wrote: > > charmitro wrote: > > > tbaede

[clang] 808004f - [clang][NFC] Reformat expandTabs

Author: Timm Bäder Date: 2023-06-04T07:52:46+02:00 New Revision: 808004f82af7ba3d17ddaffbd809d491aa0a865e URL: https://github.com/llvm/llvm-project/commit/808004f82af7ba3d17ddaffbd809d491aa0a865e DIFF: https://github.com/llvm/llvm-project/commit/808004f82af7ba3d17ddaffbd809d491aa0a865e.diff LO

[clang] 59048a3 - [AST] Remove unused declaration makeDeclVisibleInContextInternal

Author: Kazu Hirata Date: 2023-06-03T23:36:50-07:00 New Revision: 59048a3aa3f4b2326ea4dc1abf4b9530cda50b2a URL: https://github.com/llvm/llvm-project/commit/59048a3aa3f4b2326ea4dc1abf4b9530cda50b2a DIFF: https://github.com/llvm/llvm-project/commit/59048a3aa3f4b2326ea4dc1abf4b9530cda50b2a.diff L