[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:594 - // Add paths specified in LIBRARY_PATH environment variable as -L options. - addDirectoryList(Args, CmdArgs, "-L", "LIBRARY_PATH"); -

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 updated this revision to Diff 519957. jhuber6 added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149978/new/ https://reviews.llvm.org/D149978 Files: clang/lib/Driver/ToolChains/Cuda.cpp clang/test/Driver

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 marked an inline comment as done. ziqingluo-90 added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2363-2364 + if (isa(Node)) { +// to visit implicit children of `LambdaExpr`s: +IsVisitingLambda = true; +

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 519958. ziqingluo-90 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/clang/Sema/AnalysisBasedWarnings.h clang/lib/Sema/AnalysisBasedWarnings.cp

[PATCH] D149694: [Clang] Update warning on some designator initializer cases involving unions

shafik updated this revision to Diff 519960. shafik added a comment. - Apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149694/new/ https://reviews.llvm.org/D149694 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaInit.cpp clang/test/Sema

[PATCH] D149776: Re-land "[AMDGPU] Define data layout entries for buffers""

krzysz00 added a comment. From a quick skim of the backtrace, I think this comes down to the fact that there isn't a defined way to stick a `p7` into registers (or, equivalently, there's no `MVT::i160`) and that getting said pointers to that point was supposed to never happen (in that they were

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. These changes look good to me and I agree with not making a change for the `KnownHeaders` case. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1131-1132

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna added a comment. In D149461#4323175 , @tahonermann wrote: > These changes look good to me and I agree with not making a change for the > `KnownHeaders` case. >> I agree with not making a change for the `KnownHeaders` case. Yup. I closed them a

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 added a comment. Somewhat annoying, I've discovered that LLVM adds `-Wl,-fcolor-diagnostics` which obviously isn't supported by `nvlink` so it fails while including this in `libc`'s CMake. Any clue if there's a way to work around that? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 519972. HerrCai0907 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaType.cpp c

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added a comment. > So I'm still not sure this is the 'right' away about it. I think we should > instead properly handle the containsErrors case and just always create a > non-dependent sized array, except with the RecoveryExpr having the correct > type. You are right. Fix as your s

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 added a comment. The main reason I made this patch was to allow passing `--suppress-stack-size-warning` to `nvlink`. But it turns out it's a little more difficult there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149978/new/ https://re

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

tra added a comment. In D149978#4323210 , @jhuber6 wrote: > Somewhat annoying, I've discovered that LLVM adds `-Wl,-fcolor-diagnostics` > which obviously isn't supported by `nvlink` so it fails while including this > in `libc`'s CMake. Any clue if there

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 added a comment. In D149978#4323221 , @tra wrote: > In D149978#4323210 , @jhuber6 wrote: > >> Somewhat annoying, I've discovered that LLVM adds `-Wl,-fcolor-diagnostics` >> which obviously isn't supported

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

efriedma added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1121-1138 +static unsigned getNumDisplayWidth(unsigned N) { + if (N < 10) +return 1; + if (N < 100) +return 2; + if (N < 1'000) +return 3; aaron.ballman wrote: > jrtc

[clang] 0799680 - [NFC] ][CLANG] Fix static code analyzer concerns

Author: Manna, Soumi Date: 2023-05-05T14:34:36-07:00 New Revision: 07996804a0c0290a4ee5d964a94333894c7792c2 URL: https://github.com/llvm/llvm-project/commit/07996804a0c0290a4ee5d964a94333894c7792c2 DIFF: https://github.com/llvm/llvm-project/commit/07996804a0c0290a4ee5d964a94333894c7792c2.diff

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG07996804a0c0: [NFC] ][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://review

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. This looks good with one exception; I think the changes for class `SemaDiagnosticBuilder` are not what was intended. Comment at: clang/include/clang/Anal

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 updated this revision to Diff 519977. jhuber6 added a comment. Putting up the hack that works around my problem with `libc`. Definitely not a good solution though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149978/new/ https://reviews.l

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, hans. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. This fixes running tests with a toolchain that defaults to a MinGW target. Repository: rG LLVM Github Monorepo

[PATCH] D149999: [clang-tidy] [test] Narrow down a special case to MSVC mode

mstorsjo created this revision. mstorsjo added reviewers: alvinhochun, aaron.ballman, hans. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang-tools-extra. For MinGW targets, size_t is

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good. Thanks again for catching our oops @HazardyKnusperkeks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 _

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 519982. myhsu added a comment. Introduce `m68k_rtdcc` the textual LLVM IR designation for M68k_RTD CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 Files: clang/lib/Basic/Targets/M68k.cpp clang/lib/Basic/

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 ___

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

tra added a comment. > The latter is a little difficult, The more we dig, the more we want GPU-capable lld. :-) Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:641 + // by nvlink. + if (llvm::any_of(II.getInputArg().getValues(), [](StringRef Arg) { +retu

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 519983. myhsu added a comment. Minor updates. NFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 Files: clang/lib/Basic/Targets/M68k.cpp clang/lib/Basic/Targets/M68k.h clang/lib/CodeGen/CGCall.cpp

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

Manna added a comment. Thank you everyone for reviews and comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 added a comment. In D149978#4323328 , @tra wrote: >> The latter is a little difficult, > > The more we dig, the more we want GPU-capable lld. :-) My thoughts exactly. I had a small chat with @MaskRay about how difficult it would be to spin up su

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, if a class with a defined public virtual destructor is declared before including and initializer_list is provided

[clang] 8afd831 - ms inline asm: recognize case-insensitive JMP and CALL as TargetLowering::C_Address

Author: Fangrui Song Date: 2023-05-05T15:32:32-07:00 New Revision: 8afd831b456a46677e638cdf00dd649fbd5ca0a1 URL: https://github.com/llvm/llvm-project/commit/8afd831b456a46677e638cdf00dd649fbd5ca0a1 DIFF: https://github.com/llvm/llvm-project/commit/8afd831b456a46677e638cdf00dd649fbd5ca0a1.diff

[PATCH] D149920: ms inline asm: recognize case-insensitive JMP and CALL as TargetLowering::C_Address

This revision was automatically updated to reflect the committed changes. Closed by commit rG8afd831b456a: ms inline asm: recognize case-insensitive JMP and CALL as TargetLowering… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

tra added a comment. > I've discovered that LLVM adds -Wl,-fcolor-diagnostics Can you tell me where it's done? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149978/new/ https://reviews.llvm.org/D149978

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 added a comment. In D149978#4323452 , @tra wrote: >> I've discovered that LLVM adds -Wl,-fcolor-diagnostics > > Can you tell me where it's done? `llvm/cmake/modules/HandleLLVMOptions.cmake:994` Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 8f0eee1 - Remove unused basic_android_tree/mipsel-linux-android

Author: AdityaK Date: 2023-05-05T15:50:22-07:00 New Revision: 8f0eee16d9b420c0b5339bf9c386dc6cbbf29b42 URL: https://github.com/llvm/llvm-project/commit/8f0eee16d9b420c0b5339bf9c386dc6cbbf29b42 DIFF: https://github.com/llvm/llvm-project/commit/8f0eee16d9b420c0b5339bf9c386dc6cbbf29b42.diff LOG:

[PATCH] D149980: Remove unused basic_android_tree/mipsel-linux-android

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f0eee16d9b4: Remove unused basic_android_tree/mipsel-linux-android (authored by AdityaK <1894981+hiradi...@users.noreply.github.com>). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

benlangmuir added a comment. In D103930#4310061 , @ivanmurashko wrote: > Friendly ping > > @arphaman, @jansvoboda11, I have made the patch buildable on all platforms > and have all tests passed. There was also a small fix (temp path for modules > artef

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. In D149978#4323457 , @jhuber6 wrote: > `llvm/cmake/modules/HandleLLVMOptions.cmake:994` I do not think that we should work around this particular

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

barannikov88 added a comment. In D149978#4323457 , @jhuber6 wrote: > In D149978#4323452 , @tra wrote: > >>> I've discovered that LLVM adds -Wl,-fcolor-diagnostics >> >> Can you tell me where it's done? > > `llvm/c

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/6]

barannikov88 updated this revision to Diff 520004. barannikov88 edited the summary of this revision. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

aaronpuchert added inline comments. Comment at: clang/include/clang/Driver/Options.td:2544 +defm diagnostics_show_line_numbers : BoolFOption<"diagnostics-show-line-numbers", + DiagnosticOpts<"ShowLineNumbers">, DefaultTrue, + NegFlag, aaron.ballman wrote: > I'

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > tstellar wrote: > > tstella

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

aaronpuchert added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1121-1138 +static unsigned getNumDisplayWidth(unsigned N) { + if (N < 10) +return 1; + if (N < 100) +return 2; + if (N < 1'000) +return 3; aaronpuchert wrote: > e

[PATCH] D149642: [RISCV] Support vreinterpret intrinsics between vector boolean type and m1 vector integer type

kito-cheng added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vreinterpret.c:1 -// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// NOTE: Assertions have been autogenerated by utils/upd

[PATCH] D149642: [RISCV] Support vreinterpret intrinsics between vector boolean type and m1 vector integer type

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:1418 + def int_riscv_vreinterpret_v +: DefaultAttrsIntrinsic<[llvm_anyvector_ty], Do we need an intrinsic? m1 -> mask is bitcast m1 vscale type to and a llvm.ex

[PATCH] D149642: [RISCV] Support vreinterpret intrinsics between vector boolean type and m1 vector integer type

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:1418 + def int_riscv_vreinterpret_v +: DefaultAttrsIntrinsic<[llvm_anyvector_ty], craig.topper wrote: > Do we need an intrinsic? > > m1 -> mask is bitcast m1 vsca

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

Manna added a comment. >> Thanks again for catching our oops @HazardyKnusperkeks! Yup, Thank you @HazardyKnusperkeks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 ___ cfe-commits mailing list cfe

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining updated this revision to Diff 520014. SixWeining added a comment. Add a test to show related options remain unused on a target that does not support them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/ https://reviews.llvm.or

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 520015. barannikov88 added a comment. - Rebase on top of the stack - Fix a header comment - Split some virtual functions to avoid extra includes in header files - Forward declare a few classes and add necessary includes (IWYU, header files only) Reposi

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining added a comment. Thanks @rengolin and @peter.smith. I just added a new test to show options remain unused on a target that does not support them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/ https://reviews.llvm.org/D149946

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, JonChesterfield. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald a

[clang] babe862 - [NFC][Clang] Fix static analyzer tool remarks about large copies by values in Format.cpp file

Author: Manna, Soumi Date: 2023-05-05T18:55:49-07:00 New Revision: babe8629d73fb52bf85516222cd484da0eed6c12 URL: https://github.com/llvm/llvm-project/commit/babe8629d73fb52bf85516222cd484da0eed6c12 DIFF: https://github.com/llvm/llvm-project/commit/babe8629d73fb52bf85516222cd484da0eed6c12.diff

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

This revision was automatically updated to reflect the committed changes. Closed by commit rGbabe8629d73f: [NFC][Clang] Fix static analyzer tool remarks about large copies by values in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

0x59616e added a comment. I didn't see any issue here. Let's wait for the approval from other (more senior) reviewers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cf

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. Thanks for the patch. I've tested this and it works for my build configuration. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907

[clang] 5b388f8 - [C++20] [Modules] Don't check input files for C++20 Modules

Author: Chuanqi Xu Date: 2023-05-06T11:17:15+08:00 New Revision: 5b388f86aa9ce65778677ae56587867d6786355e URL: https://github.com/llvm/llvm-project/commit/5b388f86aa9ce65778677ae56587867d6786355e DIFF: https://github.com/llvm/llvm-project/commit/5b388f86aa9ce65778677ae56587867d6786355e.diff LO

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 520025. barannikov88 added a comment. Move interface comments to the header file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 520026. ccotter marked 6 inline comments as done. ccotter added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MissingStdForwardCheck.cpp:70 + Finder->addMatcher( + parmVarDecl( + parmVarDecl().bind("param"), isTemplateTypeOfFunction(), PiotrZSL wrote: > maybe think l

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 520027. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt clang

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added a comment. Note, @PiotrZSL I don't have commit access, so if you're happy with the updates, could you please land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 __

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. I think it should be ready for review now. One point to note. I didn't follow IWYU rule in target *.cpp files -- they include the smallest set of headers for now. My memory suggests me that IWYU is a requirement, but I couldn't find a proof in the coding standard. It

[PATCH] D150017: [Clang][BPF] Type print btf_type_tag properly

yonghong-song created this revision. yonghong-song added reviewers: ast, aaron.ballman. Herald added a project: All. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When running bcc tool execsnoop ([1]) which is built with lat

[PATCH] D149518: [clang][NFC] Optimize clang::ASTNodeKind::isBaseOf

PiotrZSL updated this revision to Diff 520031. PiotrZSL added a comment. Rebase without changes, just because some testcase in this baseline looks to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149518/new/ https://reviews.llvm.org/D149518

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 520032. ccotter added a comment. - fix merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:136 +- New :doc:`cppcoreguidelines-missing-std-forward + ` check. Should be after `cppcoreguidelines-misleading-capture-default-by-value`. Repository: rG LLVM Github

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 520034. barannikov88 edited the summary of this revision. barannikov88 added a comment. - Forward declare CodeGenTypes - Split a few more virtual functions into declaration+definition to not depend on transitive includes, which are going to be removed

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

PiotrZSL added a comment. `forwarding reference parameter '' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]` consider ignoring unnamed parameters, they unused, so nothing to forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149579/new/ https://reviews.llvm.org/D149579 __

[PATCH] D149650: Give NullabilityKind a printing operator<

cmtice added a comment. This is breaking some of our tests. I will give the author a reproducible test case. I am going to revert this while waiting for a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149650/new/ https://reviews.llvm.org/D149

[clang] 5326c9e - Revert "Give NullabilityKind a printing operator<<"

Author: Caroline Tice Date: 2023-05-05T23:37:30-07:00 New Revision: 5326c9e480d70e16c2504cb5143524aff3ee2605 URL: https://github.com/llvm/llvm-project/commit/5326c9e480d70e16c2504cb5143524aff3ee2605 DIFF: https://github.com/llvm/llvm-project/commit/5326c9e480d70e16c2504cb5143524aff3ee2605.diff

<    1   2