[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514842. xgupta marked an inline comment as done. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files: clang/test/clang-ren

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 ___

[PATCH] D148315: [RISCV] Modify arch string parsing order according to latest riscv spec

joshua-arch1 added a comment. In D148315#4279486 , @asb wrote: > I'm starting to think we should just remove the ordering rules for z/s/x > altogether when parsing arch strings I see that gcc 12.2.0 actually requires > s and then z: > > [asb@purge ~]$

[PATCH] D148690: [clang][Interp] Handle __extension__ unary operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AFAIK this is just used to suppress warnings, so ig

[PATCH] D148690: [clang][Interp] Handle __extension__ unary operators

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:791 +#endif return __FUNCTION__[index]; } It's weird that the above two statements warn about using `__FUNCTION__` and the return statement doesn't. Repository: rG LLVM Git

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_sifive_vector.td:46 + +multiclass RVVVCIXBuiltinSet range, string prototype, + list intrinsic_types, bit EncodeVtype, We might consider breaking this class

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added inline comments. Comment at: clang/tools/clang-rename/ClangRename.cpp:233 + if (!Entry) { +errs() << "clang-rename: input file does not exist.\n"; +return 1; kbobyrev wrote: > It is worth including the filename in the error messa

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian updated this revision to Diff 514849. IncludeGuardian added a comment. Replace `ResetReadToken` with `SetReadToken` to avoid a conditional CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 Files: clang/include/clang/Lex/Multipl

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4279334 , @tbaeder wrote: > I am not 100% sure about the semantics of passing multiple prefixes, i.e. if > the error is emitted for all prefixes individually or if it's only emitted if > no `expected` line for an

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 107b307 - Reapply D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-19T09:32:09+01:00 New Revision: 107b307bd61e51aa66ea41f1a2c92c1459b39c7e URL: https://github.com/llvm/llvm-project/commit/107b307bd61e51aa66ea41f1a2c92c1459b39c7e DIFF: https://github.com/llvm/llvm-project/commit/107b307bd61e51aa66ea41f1a2c92c1459b39c7e.diff LOG:

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Thanks everyone for begin patient with this one. I've just pushed again after landing D148536 . I am hoping that's the last issue... I am watching the buildbots and chromium build page. Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 7674ae7 - Revert D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-19T10:03:32+01:00 New Revision: 7674ae7231c4e286b93eb399e475765630666f8b URL: https://github.com/llvm/llvm-project/commit/7674ae7231c4e286b93eb399e475765630666f8b DIFF: https://github.com/llvm/llvm-project/commit/7674ae7231c4e286b93eb399e475765630666f8b.diff LOG:

[PATCH] D148694: [SanitizerBinaryMetadata] Respect no_sanitize("thread") function attribute

melver created this revision. melver added a reviewer: dvyukov. Herald added subscribers: Enna1, hiraditya. Herald added a project: All. melver requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. To avoid false positives, resp

[PATCH] D148694: [SanitizerBinaryMetadata] Respect no_sanitize("thread") function attribute

melver updated this revision to Diff 514871. melver added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148694/new/ https://reviews.llvm.org/D148694 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/sanitize-m

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. Nice improvement! I only have minor nitpicks and some recommendations for the taint API. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:2

[PATCH] D148696: [clang][Sema][NFC] Sprinkle some const around in Sema

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NFC but uploading for review for the pre-commit CI and maybe some actual rev

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Re

[PATCH] D148696: [clang][Sema][NFC] Sprinkle some const around in Sema

tbaeder updated this revision to Diff 514878. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148696/new/ https://reviews.llvm.org/D148696 Files: clang/include/clang/AST/DeclarationName.h clang/include/clang/Sema/Sema.h clang/lib/AST/DeclarationName.cpp clang/lib/Sema/Sema.cpp cl

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

donat.nagy added a comment. @steakhal Thanks for the background information! I didn't know about D86874 so I indeed ended up with something very similar to it. I reviewed D88359 and I knew that it's a completely general soluti

[PATCH] D148699: [clang] Mark keywords that have their own parsing rules

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch retroactively classified all existing keyword

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added subscribers: kristof.beyls, dschuff. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added projects: clang, c

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added subscribers: jdoerfert, kristof.beyls, dschuff. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a proje

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

PiotrZSL added a comment. Few issues, first we should have single check for a single cppcoreguidelines rule. And due to that I'm not fan of merging these things, because for example If I would enable this check in my project I woudn't like to enforce noexcept default constructor or destructor.

[PATCH] D148699: [clang] Mark keywords that have their own parsing rules

rsandifo-arm added a comment. See https://reviews.llvm.org/D139028 for previous discussion on this topic. https://reviews.llvm.org/D148700 contains the Attr.td support (and the main rationale) while https://reviews.llvm.org/D148702 contains the main Parse & Sema support. Repository: rG LLV

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. @aaron.ballman ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. There is more to this than meets the eye.. what we have so far, from existing `AfterFunction` use and the propsed here `AfterCSharpProperty` is... public Foo {<--- controlled by **AfterFunction **(rightly or wrongly) get {

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 514901. VitaNuo added a comment. Extract a test for th firstMatchedProvider method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87 +std::optional +firstMatchedProvider(const include_cleaner::Includes &Includes, + llvm::ArrayRef Providers); kadi

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 514908. AMS21 added a comment. Minor code cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files: clang-tools-extra/clang-tidy/performance/AvoidEndlCheck.cpp

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

SixWeining added inline comments. Comment at: clang/test/Driver/linux-header-search.cpp:247 // +// Check header search on Debian loong64 +// RUN: %clang -### %s -fsyntax-only 2>&1 \ Better to use “loongarch64” when talking about debian? Refer https://wiki.debia

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 514909. ipriyanshi1708 added a comment. Updated the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:398 + )cpp", + {include_cleaner::Header{"bar.h"}, include_cleaner::Header{"foo.h

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 514911. ipriyanshi1708 added a comment. Removed spurious whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/docs/ReleaseNotes.rs

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n added inline comments. Comment at: clang/test/Driver/linux-header-search.cpp:247 // +// Check header search on Debian loong64 +// RUN: %clang -### %s -fsyntax-only 2>&1 \ SixWeining wrote: > Better to use “loongarch64” when talking about debian? Refer > h

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

steakhal added a subscriber: tomasz-kaminski-sonarsource. steakhal added a comment. In D148355#4279866 , @donat.nagy wrote: > @steakhal Thanks for the background information! > > I didn't know about D86874 so I indeed >

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

SixWeining accepted this revision. SixWeining added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/linux-header-search.cpp:247 // +// Check header search on Debian loong64 +// RUN: %clang -### %s -fsyntax-only 2>&1 \ -

[clang] bf47c1e - [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

Author: Sam McCall Date: 2023-04-19T14:32:13+02:00 New Revision: bf47c1ed855605324efcca4af92517026c7e53e5 URL: https://github.com/llvm/llvm-project/commit/bf47c1ed855605324efcca4af92517026c7e53e5 DIFF: https://github.com/llvm/llvm-project/commit/bf47c1ed855605324efcca4af92517026c7e53e5.diff LO

[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGbf47c1ed8556: [dataflow] Extract arena for Value/StorageLocation out of… (authored by sammccall). Change

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1053 - for (auto I : CleanedState->get()) { + for (const auto &I : CleanedState->get()) { if (SymbolRef Sym = I.second.getAsSymbol()) I think this is supposed to be

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5051 +return 5; + else +return 4; Instead of returning 4 here, I think it's best to just delegate to the other `GetDiagnosticTypeSpecifierID` function. That way, if the

[clang] 5f605e2 - [SanitizerBinaryMetadata] Respect no_sanitize("thread") function attribute

Author: Marco Elver Date: 2023-04-19T14:49:56+02:00 New Revision: 5f605e254a0f81a41fd69025c572d597f3059ebc URL: https://github.com/llvm/llvm-project/commit/5f605e254a0f81a41fd69025c572d597f3059ebc DIFF: https://github.com/llvm/llvm-project/commit/5f605e254a0f81a41fd69025c572d597f3059ebc.diff L

[PATCH] D148694: [SanitizerBinaryMetadata] Respect no_sanitize("thread") function attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5f605e254a0f: [SanitizerBinaryMetadata] Respect no_sanitize("thread") function attribute (authored by melver). Repository: rG LLVM Github Monorepo

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5041 case DeclSpec::TST_enum: return 4; default: ipriyanshi1708 wrote: > jrtc27 wrote: > > Why not just always pass the full DeclSpec and handle the class case here, > > maybe wit

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 514931. ipriyanshi1708 marked an inline comment as done. ipriyanshi1708 added a comment. Updated the logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 File

[PATCH] D143870: [clang-format] Remove all include duplicates not only those in the same block

Febbe added a comment. Actually, I already wanted to add an enum, controlling this behavior. But even with an enum, this check should only remove includes in consecutive blocks, which could be relocated (are not split by `#defines` or a comment) Or I should add the options to `DeduplicateInclude

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. Sorry I haven't been able to help yet, I'm STILL dealing with IT issues with the server I work on. I appreciate your patience! I have no comments, this all looks fine to me. Does this fix 62110 as well? Is there anythign to hold this up from landing? Repository:

[clang] 89d2785 - Reapply D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-19T14:15:58+01:00 New Revision: 89d27854ec7f5e8bd83e72fa574740bf3d06355b URL: https://github.com/llvm/llvm-project/commit/89d27854ec7f5e8bd83e72fa574740bf3d06355b DIFF: https://github.com/llvm/llvm-project/commit/89d27854ec7f5e8bd83e72fa574740bf3d06355b.diff LOG:

[PATCH] D148696: [clang][Sema][NFC] Sprinkle some const around in Sema

tbaeder updated this revision to Diff 514933. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148696/new/ https://reviews.llvm.org/D148696 Files: clang/include/clang/AST/DeclarationName.h clang/include/clan

[PATCH] D148690: [clang][Interp] Handle __extension__ unary operators

erichkeane added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:791 +#endif return __FUNCTION__[index]; } tbaeder wrote: > It's weird that the above two statements warn about using `__FUNCTION__` and > the return statement doesn't. Aren'

[PATCH] D148690: [clang][Interp] Handle __extension__ unary operators

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:791 +#endif return __FUNCTION__[index]; } erichkeane wrote: > tbaeder wrote: > > It's weird that the above two statements warn about using `__FUNCTION__` > > and the return sta

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. expr.prim.lambda.capture p5 says: If an identifier in a capture appears as the declarator-id of a parameter of the lambd

[PATCH] D148573: Port -fsanitize=function to AArch64

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. With moving the signature before the function entry this looks good to me. I'm not so familiar with the code in https://reviews.llvm.org/D148665 would ideally find someone a bit more

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa443b3d18ef4: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state (authored by sammccall). Changed prior to commit: https://review

[clang] a443b3d - [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

Author: Sam McCall Date: 2023-04-19T15:37:06+02:00 New Revision: a443b3d18ef4d01e767994845b3f2819480a7b48 URL: https://github.com/llvm/llvm-project/commit/a443b3d18ef4d01e767994845b3f2819480a7b48 DIFF: https://github.com/llvm/llvm-project/commit/a443b3d18ef4d01e767994845b3f2819480a7b48.diff LO

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:106 +#include "clang/Basic/AttrTokenKinds.inc" +#undef KEYWORD + ); Does AttrTokenKinds.inc not do this undef for you? Most of our tablegen'ed/.td files tend to... Edit now t

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon abandoned this revision. agozillon added a comment. Herald added a subscriber: bviyer. Closing this patch now that each individual component is upstreamed via seperate phabricator patches! Thank you to all the reviewers for your time and help. Repository: rG LLVM Github Monorepo C

[PATCH] D148699: [clang] Mark keywords that have their own parsing rules

erichkeane added a comment. I see a lot of other attributes are being marked with this CustomKeyword syntax, I find myself thinking tests should be written in terms of them, rather than a 'new'/'incomplete' attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

erichkeane added a comment. So I don't mind the changes in this stack, though this doing a little bit of a 'backdoor' way of getting the arm-streaming attribute in rubs me the wrong way. I'm not a huge fan that the solution we've got here only solves THIS problem, and doesn't extend to improvi

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added a comment. In D146591#4278074 , @xazax.hun wrote: > I am a bit overloaded at the moment, feel free to commit. I can still add > comments later that could be addressed in a follow up. Thanks! Happy to address as they come up. Repository

[clang] bbffa8b - [dataflow] add missing clangLex dep after a443b3d18ef4d01e7

Author: Sam McCall Date: 2023-04-19T16:12:42+02:00 New Revision: bbffa8bd75fdaca8029e9719fa96923a3b15e2fd URL: https://github.com/llvm/llvm-project/commit/bbffa8bd75fdaca8029e9719fa96923a3b15e2fd DIFF: https://github.com/llvm/llvm-project/commit/bbffa8bd75fdaca8029e9719fa96923a3b15e2fd.diff LO

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm marked an inline comment as done. rsandifo-arm added a comment. Thanks for the reviews! In D148702#4280392 , @erichkeane wrote: > So I don't mind the changes in this stack, though this doing a little bit of > a 'backdoor' way of getting th

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder updated this revision to Diff 514954. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang/include/clang/Basic/DiagnosticOptions.def clang/include/clang/Basic/DiagnosticOptions.h clang/include/clang/Driver/Options.td clan

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

serge-sans-paille added a comment. In D147307#4279337 , @jyu2 wrote: > This change seems cause assert: > > https://godbolt.org/z/z9G87Wr37 I can reproduce, investigating... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

carlosgalvezp added a comment. First of all thank you for the contribution! I had just a quick look so here's some very preliminary comments, will have more time to deeply review during the weekend: - Unfortunately we cannot simply rename a check like this, since it breaks backwards compatibil

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 514973. dkrupp marked an inline comment as done. dkrupp added a comment. - Implemented early return in getTaintedSymbols() when it is called by isTainted() for efficiency - Fixed test incompatibility on Windows CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp marked an inline comment as done. dkrupp added a comment. @steakhal thanks for your review. All your remarks have been fixed. Comment at: clang/lib/StaticAnalyzer/Checkers/Taint.cpp:147-150 bool taint::isTainted(ProgramStateRef State, const Stmt *S,

[PATCH] D148658: [clang] Make access to submodules via `iterator_range`

Stoorx updated this revision to Diff 514976. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148658/new/ https://reviews.llvm.org/D148658 Files: clang/include/clang/Basic/Module.h clang/lib/Basic/Module.cpp clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Frontend/CompilerInstance.cpp

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/noexcept-special-functions.rst:10 +`performance-noexcept-special-functions <../performance/noexcept-special-functions.html>`_ +for more information. Piot

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

serge-sans-paille created this revision. serge-sans-paille added reviewers: jyu2, efriedma. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise we end up with link once odr because of the

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm updated this revision to Diff 514993. rsandifo-arm added a comment. Make AttrTokenKinds.inc use a new KEYWORD_ATTRIBUTE macro, rather than using KEYWORD directly. Move the #undef to the .inc file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

This revision was automatically updated to reflect the committed changes. Closed by commit rG029bfc311d4d: [OpenMP] Prefix outlined and reduction func names with original func's name (authored by nextsilicon-itay-bookstein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm marked an inline comment as done. rsandifo-arm added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:106 +#include "clang/Basic/AttrTokenKinds.inc" +#undef KEYWORD + ); erichkeane wrote: > Does AttrTokenKinds.inc not do this unde

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

erichkeane added a comment. Generally ok with all of this, but want some time to think about it/give aaron/etc time to see it. Comment at: clang/include/clang/Basic/TokenKinds.def:751 +// Keywords defined by Attr.td. +#define KEYWORD_ATTRIBUTE(X) KEYWORD(X, KEYALL) +#include "

[PATCH] D148658: [clang] Make access to submodules via `iterator_range`

Stoorx updated this revision to Diff 515001. Herald added a project: clang-tools-extra. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148658/new/ https://reviews.llvm.org/D148658 Files: clang-tools-extra/modularize/CoverageChecker.cpp clang-tools-extra/modularize/ModularizeUtilities.

[clang] 5ddcef2 - [Headers][doc] Add/revise MONITOR/MWAIT descriptions

Author: Paul Robinson Date: 2023-04-19T09:50:15-07:00 New Revision: 5ddcef2ad3db5aa6e20a2e50e7799816c736e785 URL: https://github.com/llvm/llvm-project/commit/5ddcef2ad3db5aa6e20a2e50e7799816c736e785 DIFF: https://github.com/llvm/llvm-project/commit/5ddcef2ad3db5aa6e20a2e50e7799816c736e785.diff

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ddcef2ad3db: [Headers][doc] Add/revise MONITOR/MWAIT descriptions (authored by probinson). Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 1242644 - [Header][doc] Tweak wording for MWAIT[X] intrinsics

Author: Paul Robinson Date: 2023-04-19T09:57:33-07:00 New Revision: 12426441ea2a9fdfcf6121a0061fa91d6112781d URL: https://github.com/llvm/llvm-project/commit/12426441ea2a9fdfcf6121a0061fa91d6112781d DIFF: https://github.com/llvm/llvm-project/commit/12426441ea2a9fdfcf6121a0061fa91d6112781d.diff

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

jyu2 added a comment. Hi @serge-sans-paille, thanks for the fix. Could you please also try some test with dllimport/dllexport with inline function? Jennifer Comment at: clang/lib/AST/ASTContext.cpp:11538 const FunctionDecl *FD) {

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

probinson added inline comments. Comment at: clang/lib/Headers/pmmintrin.h:278 ///the monitor event pending state. Data stored in the monitored address ///range causes the processor to exit the pending state. /// goldstein.w.n wrote: > interrupts too.

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5192 - if (const auto *FD = D->getAsFunction()) + if (const auto *FD = D->getAsFunction()) { if (FD->isMultiVersion() && Linkage == GVA_AvailableExternally) Is this an unre

[clang] 33e2161 - [clang] makes `__is_trivially_equality_comparable` available as a struct

Author: Christopher Di Bella Date: 2023-04-19T17:16:40Z New Revision: 33e21610f9cd40e991b7cac107ba190678970f81 URL: https://github.com/llvm/llvm-project/commit/33e21610f9cd40e991b7cac107ba190678970f81 DIFF: https://github.com/llvm/llvm-project/commit/33e21610f9cd40e991b7cac107ba190678970f81.dif

[PATCH] D148677: [clang] makes `__is_trivially_equality_comparable` available as a struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33e21610f9cd: [clang] makes `__is_trivially_equality_comparable` available as a struct (authored by cjdb). Repository: rG LLVM Github Monorepo CH

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

efriedma added a comment. This seems like a weird way to fix this. The point of an "inline builtin" is that the inline function is actually the original function; it's just the inline implementation is only used in limited circumstances (in particular, it can't be used recursively). Changing

[PATCH] D148658: [clang] Make access to submodules via `iterator_range`

Stoorx updated this revision to Diff 515016. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148658/new/ https://reviews.llvm.org/D148658 Files: clang-tools-extra/modularize/CoverageChecker.cpp clang-tools-extra/modularize/ModularizeUtilities.cpp clang/include/clang/Basic/Module.h

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. I think we may have an issue due to this. I'm basing that on the blamelist, but I'm still bisecting our build, which may take some time to confirm. Can you take a look, and revert if it's not a quick fix? FAILED: obj/third_party/mesa/src/compiler/nir/nir.nir_opt_uni

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

dfaust added a comment. In D143967#4233742 , @eddyz87 wrote: > Moving type tags past typedefs would also make C code reconstruction from BTF > incomplete. Such reconstruction is used now by e.g. bpftool to create a > vmlinux.h header with all kernel typ

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. The relevant language rule from C11 is 6.5.16.1p1: "the left operand is an atomic, qualified,

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. Here are the reproducers, though I haven't reduced them yet. F27193433: clang-crashreports.zip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D1469

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

aaron.ballman updated this revision to Diff 515021. aaron.ballman added a comment. Added an additional test case (assignment of a null pointer constant to an atomic function pointer) that was mentioned in a comment on the original bug report. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

paulkirth added a comment. I'm seeing some test failures in our CI: Clang :: OpenMP/parallel_masked.cpp Clang :: OpenMP/parallel_masked_target.cpp Bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8783369579855138017/overview If this will be hard to fix, can

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

aaron.ballman updated this revision to Diff 515022. aaron.ballman added a comment. Added a `-pedantic` run line and used `(void *)0` as a null pointer constant for the last test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148730/new/ https://reviews.llvm.org/D148730 Files: clang/

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

paulkirth added a comment. Sorry, I missed that this was already reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing list cfe-comm

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

thakis added inline comments. Comment at: clang/utils/bundle_resources.py:6 +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception ---

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10307 CXXCastPath Path; CheckPointerConversion(RHS.get(), LHSType, Kind, Path, /*IgnoreBaseAccess=*/false, Diagnose); Does the LHSType here need

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein reopened this revision. nextsilicon-itay-bookstein marked 2 inline comments as done. nextsilicon-itay-bookstein added a comment. This revision is now accepted and ready to land. Reopening due to revert, will update with a fixed patch Repository: rG LLVM Github Monore

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein updated this revision to Diff 515025. nextsilicon-itay-bookstein edited the summary of this revision. nextsilicon-itay-bookstein added a comment. Updated a couple of tests that were introduced in the interim Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] a65ca45 - Revert D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-19T19:16:40+01:00 New Revision: a65ca4546b9ee042d6c40149d3f820893edbd766 URL: https://github.com/llvm/llvm-project/commit/a65ca4546b9ee042d6c40149d3f820893edbd766 DIFF: https://github.com/llvm/llvm-project/commit/a65ca4546b9ee042d6c40149d3f820893edbd766.diff LOG:

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. > I think we may have an issue due to this. I'm basing that on the blamelist, > but I'm still bisecting our build, which may take some time to confirm. Can > you take a look, and revert if it's not a quick fix? That looks related to assignment tracking to me. I'm unlike

  1   2   >