erichkeane added a comment.
So I don't mind the changes in this stack, though this doing a little bit of a
'backdoor' way of getting the arm-streaming attribute in rubs me the wrong way.
I'm not a huge fan that the solution we've got here only solves THIS problem,
and doesn't extend to improving the situation with older attributes as well.
I would like someone more knowledgeable in parsing to take a look as well.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:5308
for (const ParsedAttr &AL : DS.getAttributes())
- Diag(AL.getLoc(), diag::warn_declspec_attribute_ignored)
+ Diag(AL.getLoc(), AL.isRegularKeywordAttribute()
+ ? diag::err_declspec_keyword_has_no_effect
----------------
Is this function (isRegularKeywordAttribute) checking spellings? If not, it
needs to.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148702/new/
https://reviews.llvm.org/D148702
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
