[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

nridge added a subscriber: dgoldman. nridge added inline comments. Comment at: clang-tools-extra/clangd/SystemIncludeExtractor.cpp:340 +// is not installed. +if (Lang == "objective-c++-header") { + Lang = "c++-header"; kadircet wrote: > nridge wrote:

[PATCH] D143260: [clangd] Add semantic token for labels

nridge added a comment. In D143260#4267883 , @kadircet wrote: > I am not sure if access specifiers and label declarations occur in the same > context often enough for this mixing to actually cause trouble TBH. I think the focus on access specifiers is a

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:55 +AvoidByValueCaptureDefaultWhenCapturingThisCheck>( + "cppcoreguidelines-avoid-by-value-capture-default-when-capturing-this");

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp added a comment. You can find the improved reports on tmux, postgres, twin, openssl here: here

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp marked 3 inline comments as done. carlosgalvezp added a comment. > To be honest for me this check still looks too strict, for example it will > warn when we capture this explicitly, and we don't use any class fields, but > we use some local variables captured by value and for examp

[PATCH] D148418: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Using 'hasUnqualifiedDe

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

carlosgalvezp added a comment. Looks good, some small comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-override-templates.cpp:15 + virtual void foo(); + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:16: warning: prefer using 'override' or (rarely) 'final

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:55 +AvoidByValueCaptureDefaultWhenCapturingThisCheck>( + "cppcoreguidelines-avoid-by-value-capture-default-when-capturing-this"); Check

[PATCH] D147081: [clang-tidy] Fix issues in bugprone-assert-side-effect

carlosgalvezp added a comment. You mention in the commit message that it fixes #25569, but that seems unrelated (and is already closed)? Personally I find it hard to review 2 github issue fixes + 1 NFC (moving the assert code to assert.h) on the same patch, would it be possible to split to hav

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:55 +AvoidByValueCaptureDefaultWhenCapturingThisCheck>( + "cppcoreguidelines-avoid-by-value-capture-default-when-capturing-this"); Check

[PATCH] D147081: [clang-tidy] Fix issues in bugprone-assert-side-effect

PiotrZSL added a comment. You right, I copied wrong issue id, should be #31825. I do not plan to split this review. It's simply too big effort to do that, and then maintain multiple reviews that have dependencies on each other, they they all are related to same check. Repository: rG LLVM Gi

[PATCH] D147808: [clangd] Support non-trivial defaulted special member functions in Define Outline tweak

njames93 updated this revision to Diff 513862. njames93 edited the summary of this revision. njames93 added a comment. Fix unittest, tests had trivial and non trivial mixed up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147808/new/ https://review

[PATCH] D148419: [clang][AST] Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as evaluation failure

hazohelet created this revision. hazohelet added reviewers: rsmith, tbaeder, shafik, aaron.ballman. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch fixes the wrong signal from the constexpr evaluator that `[[gnu::weak]]` member p

[clang-tools-extra] a73b87b - [clang-tidy] Avoid float compare in bugprone-incorrect-roundings

Author: Piotr Zegar Date: 2023-04-15T09:09:21Z New Revision: a73b87b8bd47e0634d741e655ae37a22f6b82287 URL: https://github.com/llvm/llvm-project/commit/a73b87b8bd47e0634d741e655ae37a22f6b82287 DIFF: https://github.com/llvm/llvm-project/commit/a73b87b8bd47e0634d741e655ae37a22f6b82287.diff LOG: [

[clang-tools-extra] aa1642f - [clang-tidy] Add support for long double in bugprone-incorrect-roundings

Author: Piotr Zegar Date: 2023-04-15T09:09:21Z New Revision: aa1642f6cc4ac8403b21f998a1234bea2948ac9d URL: https://github.com/llvm/llvm-project/commit/aa1642f6cc4ac8403b21f998a1234bea2948ac9d DIFF: https://github.com/llvm/llvm-project/commit/aa1642f6cc4ac8403b21f998a1234bea2948ac9d.diff LOG: [

[PATCH] D147906: [clang-tidy] Avoid float compare in bugprone-incorrect-roundings

This revision was automatically updated to reflect the committed changes. Closed by commit rGa73b87b8bd47: [clang-tidy] Avoid float compare in bugprone-incorrect-roundings (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147906/n

[PATCH] D147908: [clang-tidy] Add support for long double in bugprone-incorrect-roundings

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa1642f6cc4a: [clang-tidy] Add support for long double in bugprone-incorrect-roundings (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

RKSimon accepted this revision. RKSimon added a comment. LGTM - just simplify the shuffle masks (even if it break 80-col). Please keep an eye out for any regressions, I'm not certain we've shaken out every possible issue. Comment at: clang/lib/Headers/avx512fintrin.h:401 + r

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

PiotrZSL updated this revision to Diff 513866. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Remove not needed comments from tests, and added new comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147924/new/ https://revi

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

jonpa accepted this revision. jonpa added a comment. This revision is now accepted and ready to land. In D143813#4269073 , @efriedma wrote: > Please don't upload reviews for followup patches on top of the original > patch; it confuses the history of happ

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-override-templates.cpp:46 + // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override] + // CH

[libunwind] ca4fb46 - [libunwind] Sync Unwind_AppleExtras.cpp with downstream version

Author: Louis Dionne Date: 2023-04-15T10:37:28+01:00 New Revision: ca4fb463187ce244d61dc62a8f4e3e01d1872cc2 URL: https://github.com/llvm/llvm-project/commit/ca4fb463187ce244d61dc62a8f4e3e01d1872cc2 DIFF: https://github.com/llvm/llvm-project/commit/ca4fb463187ce244d61dc62a8f4e3e01d1872cc2.diff

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

PiotrZSL updated this revision to Diff 513871. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Remove of fix start/end marker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147924/new/ https://reviews.llvm.org/D147924 Files:

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-override-templates.cpp:46 + // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override] + // CHECK-F

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

carlosgalvezp accepted this revision. carlosgalvezp added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-override-templates.cpp:46 + // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer using

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp updated this revision to Diff 513873. carlosgalvezp marked 2 inline comments as done. carlosgalvezp added a comment. Rename check to latest proposal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148340/new/ https://reviews.llvm.org/D1

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp updated this revision to Diff 513874. carlosgalvezp added a comment. Fix check ordering. Align check documentation across header, .rst file and Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148340/new/ https://reviews.

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp updated this revision to Diff 513875. carlosgalvezp added a comment. Remove excessive whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148340/new/ https://reviews.llvm.org/D148340 Files: clang-tools-extra/clang-tidy/cppcor

[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

njames93 created this revision. njames93 added reviewers: kadircet, sammccall, nridge. Herald added a subscriber: arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ext

[PATCH] D148418: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/dangling-handle.cpp:55-56 - operator basic_string_view() const noexcept; + typedef basic_string_view str_view; + operator str_view() const noexcept; Right

[clang-tools-extra] eedbe81 - [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

Author: Carlos Galvez Date: 2023-04-15T10:10:04Z New Revision: eedbe81b1c6dfbd85c2a46093e9e862335ad6516 URL: https://github.com/llvm/llvm-project/commit/eedbe81b1c6dfbd85c2a46093e9e862335ad6516 DIFF: https://github.com/llvm/llvm-project/commit/eedbe81b1c6dfbd85c2a46093e9e862335ad6516.diff LOG:

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

This revision was automatically updated to reflect the committed changes. Closed by commit rGeedbe81b1c6d: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 513878. AMS21 marked 12 inline comments as done. AMS21 added a comment. Implement suggested fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files: clang-tools-e

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/avoid-endl.cpp:46 +void bad() { + std::cout << "World" << std::endl; + // CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use std::endl with iostreams; use '\n' instead --

[PATCH] D148418: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/dangling-handle.cpp:55-56 - operator basic_string_view() const noexcept; + typedef basic_string_view str_view; + operator str_view() co

[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

njames93 added a comment. Theres definitely scope to improve this in follow ups. We could support this for template methods and classes template struct A { void [[Foo]]() {} template void [[Bar]]() {} }; // Both ranges transformed to template struct A { void Foo(); te

[clang] 19ef8e8 - [clang] Mark CWG2331 as N/A

Author: Vlad Serebrennikov Date: 2023-04-15T13:15:45+03:00 New Revision: 19ef8e8446df10b6bebf6301c1a3e9e8000f842c URL: https://github.com/llvm/llvm-project/commit/19ef8e8446df10b6bebf6301c1a3e9e8000f842c DIFF: https://github.com/llvm/llvm-project/commit/19ef8e8446df10b6bebf6301c1a3e9e8000f842c.

[PATCH] D148260: [clang] Mark CWG2331 as N/A

This revision was automatically updated to reflect the committed changes. Closed by commit rG19ef8e8446df: [clang] Mark CWG2331 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148260/new/ https://reviews.llvm.org/D148260

[clang-tools-extra] 9556409 - [clang-tidy] Exclude template instantiations in modernize-use-override

Author: Piotr Zegar Date: 2023-04-15T10:16:03Z New Revision: 9556409957bbf85ca751ccff8f3a4d981a094b73 URL: https://github.com/llvm/llvm-project/commit/9556409957bbf85ca751ccff8f3a4d981a094b73 DIFF: https://github.com/llvm/llvm-project/commit/9556409957bbf85ca751ccff8f3a4d981a094b73.diff LOG: [

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

This revision was automatically updated to reflect the committed changes. Closed by commit rG9556409957bb: [clang-tidy] Exclude template instantiations in modernize-use-override (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D147924?vs=513871&id=513880#toc Repository

[PATCH] D148424: [clang-tidy][NFC] Improve doc of cppcoreguidelines-misleading-capture-default-by-value

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D148418: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

carlosgalvezp accepted this revision. carlosgalvezp added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/dangling-handle.cpp:55-56 - operator basic_string_view() const noexcept; + typedef basi

[clang-tools-extra] 35f466e - [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

Author: Piotr Zegar Date: 2023-04-15T10:29:39Z New Revision: 35f466eb14b7e57e8bd33a8eb98e89fe3a4cd839 URL: https://github.com/llvm/llvm-project/commit/35f466eb14b7e57e8bd33a8eb98e89fe3a4cd839 DIFF: https://github.com/llvm/llvm-project/commit/35f466eb14b7e57e8bd33a8eb98e89fe3a4cd839.diff LOG: [

[PATCH] D148418: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

This revision was automatically updated to reflect the committed changes. PiotrZSL marked an inline comment as done. Closed by commit rG35f466eb14b7: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/HeaderIncludeCycleCheck.cpp:134-135 +do { + if (CurrentIt->Name.empty()) +continue; + Is this a case that can ever come up? If it does come up, surely any notes emitte

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.h:61-69 struct NamesAndOptions { llvm::StringSet<> Names; llvm::StringSet<> Options; + std::vector Errors; }; NamesAndOptions I don't think this is the correct approach

[libclc] 1ef4c3c - Revert "Revert "[CMake] Bumps minimum version to 3.20.0.""

Author: Mark de Wever Date: 2023-04-15T13:12:04+02:00 New Revision: 1ef4c3c859728008cf707cad8d67f45ae5070ae1 URL: https://github.com/llvm/llvm-project/commit/1ef4c3c859728008cf707cad8d67f45ae5070ae1 DIFF: https://github.com/llvm/llvm-project/commit/1ef4c3c859728008cf707cad8d67f45ae5070ae1.diff

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.h:61-69 struct NamesAndOptions { llvm::StringSet<> Names; llvm::StringSet<> Options; + std::vector Errors; }; NamesAndOptions njames93 wrote: > I don't think this is th

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL marked 4 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/HeaderIncludeCycleCheck.cpp:134-135 +do { + if (CurrentIt->Name.empty()) +continue; + njames93 wrote: > Is this a case that

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 513886. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Small redesign (review comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files:

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, aaron.ballman. Herald added a project: All. v.g.vassilev requested review of this revision. Repository: rC Clang https://reviews.llvm.org/D148425 Files: clang/lib/Parse/ParseTentative.cpp clang/test/Interpreter/disam

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D147815: [clang][deps] Print timing information

akyrtzi added a comment. > Could you also add a -terse option, to avoid printing the full dependency info Note I added something like this in https://reviews.llvm.org/D148369, so ignore it for this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang-tools-extra] fa3de2e - [clang-tidy][NFC] Improve doc of cppcoreguidelines-misleading-capture-default-by-value

Author: Carlos Galvez Date: 2023-04-15T12:07:18Z New Revision: fa3de2ed2964d18dd0b7457e77416fb4e688c8bd URL: https://github.com/llvm/llvm-project/commit/fa3de2ed2964d18dd0b7457e77416fb4e688c8bd DIFF: https://github.com/llvm/llvm-project/commit/fa3de2ed2964d18dd0b7457e77416fb4e688c8bd.diff LOG:

[PATCH] D148424: [clang-tidy][NFC] Improve doc of cppcoreguidelines-misleading-capture-default-by-value

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa3de2ed2964: [clang-tidy][NFC] Improve doc of cppcoreguidelines-misleading-capture-default… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. Ok, taking a step back here, this patch is trying to address 2 unrelated things at once: - using `--dump-config` with bad check options results in a crash - using `--verify-confi

[PATCH] D148426: [clang][Interp] IntegralComplexToBoolean casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I wanted to avoid adding too many opcodes for bitin

[PATCH] D148426: [clang][Interp] IntegralComplexToBoolean casts

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1165 +return visit(LV); + return false; Since complex types are arrays with two elements, we can't dereference them like normal. This change just ignore the dereference.

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM: Just one small nit. Comment at: clang-tools-extra/clang-tidy/misc/HeaderIncludeCycleCheck.cpp:148-150 +return std::any_of( +IgnoredFilesRegexes.begin()

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 513896. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Fix one small nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files: clang-tools-

[clang-tools-extra] 9ece875 - [clang-tidy] Add misc-header-include-cycle check

Author: Piotr Zegar Date: 2023-04-15T12:43:22Z New Revision: 9ece8753d5e6f49c31c2d988ef69225c036b25e0 URL: https://github.com/llvm/llvm-project/commit/9ece8753d5e6f49c31c2d988ef69225c036b25e0 DIFF: https://github.com/llvm/llvm-project/commit/9ece8753d5e6f49c31c2d988ef69225c036b25e0.diff LOG: [

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ece8753d5e6: [clang-tidy] Add misc-header-include-cycle check (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

PiotrZSL added a comment. In D146842#4271089 , @njames93 wrote: > I think this should be split up into 2 separate patches, one for each of the > proposed changes and each can be reviewed on their own. I don't plan to split this. Repository: rG LLVM

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

thakis added a comment. This breaks tests: http://45.33.8.238/linux/104455/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 ___

[clang-tools-extra] 26e164f - Revert "[clang-tidy] Add misc-header-include-cycle check"

Author: Piotr Zegar Date: 2023-04-15T13:16:43Z New Revision: 26e164fada3721b0939e6b7c2dfe1793d95229bb URL: https://github.com/llvm/llvm-project/commit/26e164fada3721b0939e6b7c2dfe1793d95229bb DIFF: https://github.com/llvm/llvm-project/commit/26e164fada3721b0939e6b7c2dfe1793d95229bb.diff LOG: R

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 513898. PiotrZSL added a comment. Small changes remove, file name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files: clang-tools-extra/clang-tidy/misc/CMakeLis

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL added a comment. To be honest I have no idea why it failed, simply because there is CHECK-MESSAGES for that log. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 _

[PATCH] D141892: Implement modernize-use-constraints

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:63-65 +std::string Name = TheType.getType().getAsString(); +if (Name.find("enable_if<") == std::string::npos) + return std::nullopt; This strin

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/AvoidEndlEndsCheck.cpp:28 + declRefExpr( + to(namedDecl(hasAnyName("endl", "ends")).bind("decl"))) + .bind("expr", Why are you

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/AvoidEndlEndsCheck.cpp:28 + declRefExpr( + to(namedDecl(hasAnyName("endl", "ends")).bind("decl"))) + .bind("expr", njames93 wro

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.h:1 +//===--- MisleadingCaptureDefaultByValueCheck.h - clang-tidy*- C++ +//-*-===// Split header comment. Repository: rG LLV

[clang-tools-extra] d69c362 - [clang-tidy][NFC] Fix format of header file comment in MisleadingCaptureDefaultByValueCheck.h

Author: Carlos Galvez Date: 2023-04-15T14:49:20Z New Revision: d69c362dfdc09d9b866cbce007e6342c17af2b2a URL: https://github.com/llvm/llvm-project/commit/d69c362dfdc09d9b866cbce007e6342c17af2b2a DIFF: https://github.com/llvm/llvm-project/commit/d69c362dfdc09d9b866cbce007e6342c17af2b2a.diff LOG:

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.h:1 +//===--- MisleadingCaptureDefaultByValueCheck.h - clang-tidy*- C++ +//-*-===// --

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

njames93 added a comment. In D146842#4271144 , @PiotrZSL wrote: > In D146842#4271089 , @njames93 > wrote: > >> I think this should be split up into 2 separate patches, one for each of the >> proposed changes and

[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

njames93 updated this revision to Diff 513911. njames93 added a comment. - Clang format changes - Update apply logic to not query the FS when its not a cross file edit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148423/new/ https://reviews.llvm.o

[PATCH] D98416: [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive

This revision was automatically updated to reflect the committed changes. Closed by commit rG4530c3bc4897: [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive (authored by njames93, committed by carlosgalvezp). Changed prior to commit: https://reviews.llvm.org/D98416?vs=329

[PATCH] D98416: [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive

carlosgalvezp added a comment. Took the liberty to land it for you, hope it's ok! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98416/new/ https://reviews.llvm.org/D98416 ___ cfe-commits mailing list

[clang-tools-extra] 4530c3b - [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive

Author: Nathan James Date: 2023-04-15T15:07:44Z New Revision: 4530c3bc4897f6633577de07b61ceb1bf7e79f50 URL: https://github.com/llvm/llvm-project/commit/4530c3bc4897f6633577de07b61ceb1bf7e79f50 DIFF: https://github.com/llvm/llvm-project/commit/4530c3bc4897f6633577de07b61ceb1bf7e79f50.diff LOG:

[PATCH] D144036: [clang-tidy] Add bugprone-non-zero-enum-to-bool-conversion check

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks! Would be good to fix the last nit before landing. Comment at: clang-tools-extra/clang-tidy/bugprone/NonZeroEnumToBoolConversionCheck.h:17 + +///

[clang] b9d84b5 - [clang][NFC] Fix DR test ordering

Author: Vlad Serebrennikov Date: 2023-04-15T18:25:08+03:00 New Revision: b9d84b57f680cb294da906a6eeca2d0598c11568 URL: https://github.com/llvm/llvm-project/commit/b9d84b57f680cb294da906a6eeca2d0598c11568 DIFF: https://github.com/llvm/llvm-project/commit/b9d84b57f680cb294da906a6eeca2d0598c11568.

[PATCH] D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape

carlosgalvezp added a comment. There's a lot of changes in this patch (at least 6 as per commit message) - please split into smaller patches fixing 1 problem at a time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145865/new/ https://reviews.llvm

[PATCH] D144036: [clang-tidy] Add bugprone-non-zero-enum-to-bool-conversion check

PiotrZSL updated this revision to Diff 513917. PiotrZSL added a comment. Fix check description in source file (white spaces, sync it with release notes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144036/new/ https://reviews.llvm.org/D144036 Fil

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. TODO: Split tests into multiple files (to isolate issue). If possible remove usage of FileCheck. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.o

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 513918. junaire added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/B

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 16 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:72 + llvm::Error ParseAndExecute(llvm::StringRef Code, Value *V = nullptr); + llvm::Expected CompileDtorCall(CXXRecordDecl *CXXRD);

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

Endill created this revision. Endill added reviewers: erichkeane, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : The intent for CWG2335 (contra those of the olde

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Jun Zhang Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D148434 Files: clang/include/

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 4 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:83 /// mangled name. llvm::Expected getSymbolAddress(GlobalDecl GD) const; sgraenitz wrote: > Most of the Orc and JITLink mo

[PATCH] D144036: [clang-tidy] Add bugprone-non-zero-enum-to-bool-conversion check

PiotrZSL updated this revision to Diff 513923. PiotrZSL added a comment. Rebase due to broken baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144036/new/ https://reviews.llvm.org/D144036 Files: clang-tools-extra/clang-tidy/bugprone/Bugpro

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

junaire updated this revision to Diff 513924. junaire added a comment. Avoid unnecessary changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148434/new/ https://reviews.llvm.org/D148434 Files: clang/include/clang/Interpreter/Interpreter.h cl

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, rjmccall, rsmith, junaire. Herald added a project: All. v.g.vassilev requested review of this revision. Non-incremental Clang can also exit with the WeakRefReferences not empty upon such example. This patch makes cla

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:7226 + // assert(DeferredDeclsToEmit.empty() && + //"Should have emitted all decls deferred to emit."); assert(NewBuilder->DeferredDecls.empty() && aaron.ballman wrot

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 513926. junaire marked an inline comment as done. junaire added a comment. Address more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/includ

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:83 + Value() = default; + Value(void /*Interpreter*/ *In, void /*QualType*/ *Ty); + Value(const Value &RHS); aaron.ballman wrote: > Why

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 513927. junaire added a comment. Sync Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Headers/CMake

[PATCH] D148436: [clang-tidy] Fix crash in --dump-config

njames93 created this revision. njames93 added reviewers: PiotrZSL, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes a crash in dump

[PATCH] D148436: [clang-tidy] Fix crash in --dump-config

njames93 added a comment. @PiotrZSL I hope you don't mind, I've put just the crash fix up here for D146842 and marked you as the coauthor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148436/new/ https://reviews

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo created this revision. sousajo added a reviewer: MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. sousajo requested review of this revision. Fixes: https://github.com/llvm/l

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta created this revision. xgupta added reviewers: vmiklos, alexander-shaposhnikov, kbobyrev, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-rename on a non existing file segfaul

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo added a comment. As I dont have commit access if someone can land It for me: Jorge Pinto Sousa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 ___ cfe-commits mailing list cfe-commits@list

  1   2   >