njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed.
Ok, taking a step back here, this patch is trying to address 2 unrelated things at once: - using `--dump-config` with bad check options results in a crash - using `--verify-config` won't actually verify that the checks are able to parse values from their respective `CheckOptions` I think this should be split up into 2 separate patches, one for each of the proposed changes and each can be reviewed on their own. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146842/new/ https://reviews.llvm.org/D146842 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits